Re: [PATCHv2] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt

2013-07-14 Thread Peter Korsgaard
Mark == Mark Jackson mpfj-l...@newflow.co.uk writes: Hi, Mark On 08/07/13 13:42, Mark Jackson wrote: On 18/01/13 05:14, Mugunthan V N wrote: On 1/18/2013 3:48 AM, Peter Korsgaard wrote: When booting with CONFIG_ARM_APPENDED_DTB (either because of using an old U-Boot, not wanting

Re: [PATCH] dts: am33xx: Correct properties on gpmc node

2013-05-28 Thread Peter Korsgaard
the right values for the Lars gpmc driver. Lars Signed-off-by: Lars Poeschel poesc...@lemonage.de Acked-by: Peter Korsgaard jac...@sunsite.dk -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https

Re: [PATCH v5 1/3] i2c: mux: Add i2c-arb-gpio-challenge 'mux' driver

2013-04-16 Thread Peter Korsgaard
a typo: s/use the claim/use to claim/ -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH-V2 5/6] ARM: dts: AM33XX: Fix uart numbering to match hardware/TRM

2013-03-28 Thread Peter Korsgaard
Vaibhav == Vaibhav Hiremath hvaib...@ti.com writes: Vaibhav With DT support, where naming convention is based on base-addr Vaibhav and not id, so we should follow TRM/Spec numbering label. Vaibhav This patch changes UART numbering as per TRM, as uart0-5. Acked-by: Peter Korsgaard jac

Re: [PATCH 1/5] ARM: dts: AM33XX: Fix the i2c numbering to match hardware/TRM

2013-03-27 Thread Peter Korsgaard
Vaibhav == Vaibhav Hiremath hvaib...@ti.com writes: Vaibhav With DT support, where naming convention is based on base-addr Vaibhav and not id, so we should follow TRM/Spec numbering label. Vaibhav This patch changes I2C numbering as per TRM, as I2C0, I2C1 and I2C2. Acked-by: Peter Korsgaard

Re: [PATCH 3/5] ARM: dts: AM33XX: Fix gpio numbering to match hardware/TRM

2013-03-27 Thread Peter Korsgaard
Korsgaard jac...@sunsite.dk -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 2/2] pwm: pwm-tiehrpwm: Update device-tree binding document

2013-03-25 Thread Peter Korsgaard
Philip == Philip Avinash avinashphi...@ti.com writes: Philip Update binding document of pwm-tiehrpwm to reflect the usage of similar Philip modules in da850 and am3xx SOCs. Acked-by: Peter Korsgaard jac...@sunsite.dk Philip Signed-off-by: Philip Avinash avinashphi...@ti.com Philip Cc

Re: [PATCH v3] gpio: mcp23s08: convert driver to DT

2013-03-25 Thread Peter Korsgaard
on that driver since David.. -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v9 5/9] dmaengine: edma: Add TI EDMA device tree binding

2013-03-12 Thread Peter Korsgaard
Matt On second thought, I'm not sure we're going to get any direction Matt on this one so let's just do what feels right and make it reflect Matt common usage like you suggested. Sounds good to me! -- Bye, Peter Korsgaard ___ devicetree-discuss mailing

Re: [PATCH 1/3] driver: net: ethernet: cpsw: implement ethtool get/set phy setting

2013-03-09 Thread Peter Korsgaard
Richard == Richard Cochran richardcoch...@gmail.com writes: Hi, As Peter Korsgaard mentioned we need to have infrastructure to handle CPSW kind of hardware. Richard This will be a big job, I think, but I agree that it is worth doing. Richard I can think of one other switch-with-host

Re: [PATCH 1/3] driver: net: ethernet: cpsw: implement ethtool get/set phy setting

2013-03-08 Thread Peter Korsgaard
that would simplify all of this quite a bit. -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 1/3] driver: net: ethernet: cpsw: implement ethtool get/set phy setting

2013-03-07 Thread Peter Korsgaard
the existing kernel (bridging/vlan) infrastructure, and the driver always just exposing 2 network interfaces instead of these configuration properties. -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https

Re: [PATCH 1/3] driver: net: ethernet: cpsw: implement ethtool get/set phy setting

2013-03-07 Thread Peter Korsgaard
though it has never been extended to hook into the bridging stuff). I agree that we don't have infrastructure to handle hw like cpsw in a really good way today, but it would be very nice to move towards it. -- Bye, Peter Korsgaard ___ devicetree-discuss

Re: [PATCH v9 5/9] dmaengine: edma: Add TI EDMA device tree binding

2013-03-06 Thread Peter Korsgaard
= 12 13 14; Probably interrupt-parent should be removed from the example as well to match am33xx.dtsi -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH] i2c: busses: i2c-ocores: Fix PM-related warning

2013-03-04 Thread Peter Korsgaard
, - .pm = OCORES_I2C_PM, + .pm = ocores_i2c_pm, }, }; -- 1.7.7 Maxin ping.. -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree

Re: [PATCH 3/3] driver: net: ethernet: cpsw: dual emac interface implementation

2013-02-18 Thread Peter Korsgaard
of a message to majord...@vger.kernel.org M More majordomo info at http://vger.kernel.org/majordomo-info.html -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH] ARM: dts: AM33XX: Corrects typo in interrupt field in SPI node

2013-02-01 Thread Peter Korsgaard
Acked-by: Peter Korsgaard jac...@sunsite.dk -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v4 4/8] MFD: ti_am335x_tscadc: add device tree binding information

2013-01-27 Thread Peter Korsgaard
values in wire-config mean? P + P +adc: P +- ti,adc-channels: Number of ADC channels used. Is there ever any use case for this being something else than 8 - ti,wires? -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss

Re: [PATCH] mtd: devices: elm: Removes xx literals in elm DT node

2013-01-24 Thread Peter Korsgaard
Philip == Philip Avinash avinashphi...@ti.com writes: Philip As part of removing generalized dependency, replace xx Philip literal fields in DT compatible field with 52 for am335x Philip platforms. Acked-by: Peter Korsgaard jac...@sunsite.dk -- Bye, Peter Korsgaard

Re: [PATCH 1/3] ARM: dts: AM33XX: Add ELM node

2013-01-21 Thread Peter Korsgaard
. Acked-by: Peter Korsgaard jac...@sunsite.dk -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 2/3] ARM: dts: AM33XX: Add GPMC node

2013-01-21 Thread Peter Korsgaard
it should be done), but the elm compatible is simply ti,am33xx-elm. Presumably it should have been ti,am3352-elm in the binding instead? Other than that it looks fine. Acked-by: Peter Korsgaard jac...@sunsite.dk -- Bye, Peter Korsgaard ___ devicetree

[PATCHv2] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt

2013-01-17 Thread Peter Korsgaard
troublesome. The am33xx has unique ethernet hwaddrs programmed in the efuse, so it makes more sense to default to these rather than random ones. Add a fixup step which adds mac-address dt properties using the efuse addresses if the DTB didn't contain valid ones. Signed-off-by: Peter Korsgaard jac

Re: [PATCH RESEND] ARM: dts: AM33XX: Rename I2C and GPIO nodes

2013-01-08 Thread Peter Korsgaard
AnilKumar Hi Tony/Benoit, AnilKumar If there are no comments could you please pull this patch? Yes, please do. -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree

Re: [PATCH 1/2] ASoC: tlv320aic326x: Support for TI TLV320AIC3262 audio driver

2012-12-19 Thread Peter Korsgaard
+work_err: Mehar + kfree(aic3262-cfw_p); Mehar + return ret; Mehar +} -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-27 Thread Peter Korsgaard
in advance. We could naturally enforce people to add redundant pinmux info to their .dts files, but I'm not sure I like that idea. -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org

Re: [PATCH 1/2] ASoC: davinci-mcasp: Add pinctrl support

2012-11-26 Thread Peter Korsgaard
might fail, and not all are fatal (E.G. pinmux already setup by bootloader): http://article.gmane.org/gmane.linux.kernel/1399756 -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org

Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support

2012-11-23 Thread Peter Korsgaard
of misconfiguration in dt You could argue that devm_pinctrl_get_select_default() shouldn't return an error for the first situation, but how should it be able to know the difference between 2 and 4? -- Bye, Peter Korsgaard ___ devicetree-discuss mailing

Re: [PATCH RESEND 02/10] ARM: dts: AM33XX: Add matrix keypad device tree data to am335x-evm

2012-11-21 Thread Peter Korsgaard
*/ A +gpio2 26 0/* Bank1, pin26 */ A +gpio2 27 0; /* Bank1, pin27 */ Sigh, can we PLEASE change am33xx.dtsi to use zero based index like the TRM and get rid of this madness? -- Bye, Peter Korsgaard

Re: [PATCH RESEND] ARM: dts: AM33XX: Rename I2C and GPIO nodes

2012-11-21 Thread Peter Korsgaard
: initial patch by pantelis's] A Signed-off-by: AnilKumar Ch anilku...@ti.com Thanks! Acked-by: Peter Korsgaard jac...@sunsite.dk -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org

Re: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-20 Thread Peter Korsgaard
it should be treated as a seperate layout (E.G. bch8-elm) then? -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v2 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-19 Thread Peter Korsgaard
? -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v2 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle

2012-11-19 Thread Peter Korsgaard
field: OFF bit. Set this bit to 1 to enter A OFF state when PWR_EN pin is pulled low. Bit is automatically reset A to 0. A PWR_EN pin pull-down is doing by RTC module. Ahh yes, sorry -ENOCOFFEE. I somehow misread the datasheet and looked at bit 0 instead. -- Bye, Peter Korsgaard

Re: [PATCH V5 7/7] arm/dts: am33xx: Add CPSW and MDIO module nodes for AM33XX

2012-11-19 Thread Peter Korsgaard
: Benoit Cousson b-cous...@ti.com M Acked-by: Peter Korsgaard jac...@sunsite.dk M Acked-by: Richard Cochran richardcoch...@gmail.com M +++ b/arch/arm/boot/dts/am335x-bone.dts M @@ -78,3 +78,11 @@ M }; M }; M }; M + M +cpsw_emac0 { M + phy_id = davinci_mdio, 0; M +}; M

Re: [PATCH v3 2/2] i2c: i2c-ocores: Add support for the GRLIB port of the controller and custom getreg and setreg functions

2012-11-15 Thread Peter Korsgaard
like that. Andreas Yes, that is a good idea. Do you think casting to and from Andreas void * in the following solution is too ugly and rather have a Andreas struct pointed to, or do you think that would be unnecessary? I find the casting OK. Thanks. -- Bye, Peter Korsgaard

Re: [PATCH v4 2/2] i2c: i2c-ocores: Add support for the GRLIB port of the controller and custom getreg and setreg functions

2012-11-15 Thread Peter Korsgaard
? If not, you might as well do the of_match_node inline in the probe instead of this helper. Other than that it looks good. -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo

Re: [PATCH v5 2/2] i2c: i2c-ocores: Add support for the GRLIB port of the controller and use function pointers for getreg and setreg functions

2012-11-15 Thread Peter Korsgaard
; } } -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v6 2/2] i2c: i2c-ocores: Add support for the GRLIB port of the controller and use function pointers for getreg and setreg functions

2012-11-15 Thread Peter Korsgaard
Andreas pointers. Andreas Signed-off-by: Andreas Larsson andr...@gaisler.com Acked-by: Peter Korsgaard jac...@sunsite.dk Thanks! -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https

Re: [PATCH v3 2/2] i2c: i2c-ocores: Add support for the GRLIB port of the controller and custom getreg and setreg functions

2012-11-13 Thread Peter Korsgaard
for an example of a driver doing something like that. -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 2/2] i2c: i2c-ocores: Add support for the GRLIB port of the controller and custom getreg and setreg functions

2012-10-24 Thread Peter Korsgaard
/write32, but not ioread/write32be are frv and mn10300. Do Andreas you know if those platforms are using i2c-ocores? Not to my knowledge, no. In that case: Acked-by: Peter Korsgaard jac...@sunsite.dk -- Bye, Peter Korsgaard ___ devicetree-discuss mailing

Re: [PATCH 1/2] i2c: i2c-ocores: Add irq support for sparc

2012-10-23 Thread Peter Korsgaard
platform_get_resource. I have no idea why sparc is being odd in this regard, but assuming this is how it's done, I'm fine with this change. A quick grep doesn't find any other drivers doing this though: git grep -l archdata.irqs drivers | xargs grep platform_get_irq Acked-by: Peter Korsgaard jac

Re: [PATCH 2/2] i2c: i2c-ocores: Add support for the GRLIB port of the controller and custom getreg and setreg functions

2012-10-23 Thread Peter Korsgaard
Andreas @@ -4,6 +4,9 @@ Andreas * Andreas * Peter Korsgaard jac...@sunsite.dk Andreas * Andreas + * Support for the GRLIB port of the controller by Andreas + * Andreas Larsson andr...@gaisler.com Andreas + * Andreas * This file is licensed under the terms of the GNU General Public

Re: [PATCH 1/4] mtd: nand: omap2: Update nerrors using ecc.strength

2012-10-15 Thread Peter Korsgaard
these defines improve readability very much compared to to just using 4/8, though. -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 3/4] ARM: OMAP2: gpmc: Add support for BCH ECC scheme

2012-10-15 Thread Peter Korsgaard
in the u-boot-am33x tree (ti81xx_nand.c) seems to use 4x14 bytes as well though, so perhaps that's a bug in the documentation instead? -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org

Re: [PATCH 2/4] mtd: devices: elm: Add support for ELM error correction

2012-10-15 Thread Peter Korsgaard
__ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https

Re: [PATCH 1/2] i2c: busses: i2c-ocores: Fix documentation filename

2012-09-23 Thread Peter Korsgaard
Maxin == Maxin B John maxin.j...@gmail.com writes: Maxin Fixes the wrong filename. Maxin Signed-off-by: Maxin B. John maxin.j...@gmail.com Acked-by: Peter Korsgaard jac...@sunsite.dk -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list

Re: [PATCH 2/2] i2c: busses: i2c-ocores: switch to devm_request_and_ioremap

2012-09-23 Thread Peter Korsgaard
Maxin == Maxin B John maxin.j...@gmail.com writes: Maxin This drops a few lines of code and allows common APIs to handle Maxin those for us. Maxin Signed-off-by: Maxin B. John maxin.j...@gmail.com Acked-by: Peter Korsgaard jac...@sunsite.dk -- Bye, Peter Korsgaard

Re: [PATCH 2/4] i2c: i2c-ocores: Use reg-shift property

2012-06-08 Thread Peter Korsgaard
for platform drivers as well? There's no conceptual reason why reg_shift is any better than regstep. -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [RFC PATCH 07/15] dt: uartlite: merge platform and of_platform driver bindings

2011-02-23 Thread Peter Korsgaard
into the CONFIG_OF conditional? Other than that, Acked-by: Peter Korsgaard jac...@sunsite.dk -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v7] spi: New driver for Altera SPI

2011-02-06 Thread Peter Korsgaard
' is the default anyway, so no need for this line. -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 3/3] i2c-ocores: add some device tree documentation

2010-12-24 Thread Peter Korsgaard
for a while so I guess we're stuck with it. Yes, it was more or less the best name I could come with. Just calling it i2c.c wouldn't have been any good either. -- Bye, Peter Korsgaard ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https