Re: [PATCH 1/2] Input: gpio-keys: do not reference platform_data after .probe exits

2011-07-19 Thread Russell King - ARM Linux
On Tue, Jul 19, 2011 at 09:17:26AM +0800, Shawn Guo wrote: On Mon, Jul 18, 2011 at 10:02:44AM -0700, Dmitry Torokhov wrote: On Monday, July 18, 2011 09:45:07 AM Shawn Guo wrote: The patch makes a copy of platform data into driver data, so that any reference to platform_data after .probe

Re: [PATCH 1/2] Input: gpio-keys: do not reference platform_data after .probe exits

2011-07-19 Thread Shawn Guo
On Tue, Jul 19, 2011 at 08:48:41AM +0100, Russell King - ARM Linux wrote: On Tue, Jul 19, 2011 at 09:17:26AM +0800, Shawn Guo wrote: On Mon, Jul 18, 2011 at 10:02:44AM -0700, Dmitry Torokhov wrote: On Monday, July 18, 2011 09:45:07 AM Shawn Guo wrote: The patch makes a copy of platform

[PATCH 1/2] Input: gpio-keys: do not reference platform_data after .probe exits

2011-07-18 Thread Shawn Guo
The patch makes a copy of platform data into driver data, so that any reference to platform_data after .probe exits can be avoided. Signed-off-by: Shawn Guo shawn@linaro.org Cc: Phil Blundell p...@handhelds.org Cc: Dmitry Torokhov d...@mail.ru --- drivers/input/keyboard/gpio_keys.c | 45

Re: [PATCH 1/2] Input: gpio-keys: do not reference platform_data after .probe exits

2011-07-18 Thread Dmitry Torokhov
On Monday, July 18, 2011 09:45:07 AM Shawn Guo wrote: The patch makes a copy of platform data into driver data, so that any reference to platform_data after .probe exits can be avoided. And why is this beneficial? I am of the opinion that platform data should stay on (and be accessed through a

Re: [PATCH 1/2] Input: gpio-keys: do not reference platform_data after .probe exits

2011-07-18 Thread Grant Likely
On Mon, Jul 18, 2011 at 11:02 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Monday, July 18, 2011 09:45:07 AM Shawn Guo wrote: The patch makes a copy of platform data into driver data, so that any reference to platform_data after .probe exits can be avoided. And why is this

Re: [PATCH 1/2] Input: gpio-keys: do not reference platform_data after .probe exits

2011-07-18 Thread Shawn Guo
On Mon, Jul 18, 2011 at 10:02:44AM -0700, Dmitry Torokhov wrote: On Monday, July 18, 2011 09:45:07 AM Shawn Guo wrote: The patch makes a copy of platform data into driver data, so that any reference to platform_data after .probe exits can be avoided. And why is this beneficial? I am of the