Re: [PATCH 1/2] versatile: sic: add device tree bindings

2012-01-13 Thread Jamie Iles
On Thu, Jan 12, 2012 at 07:29:32PM -0700, Grant Likely wrote: On Fri, Jan 13, 2012 at 12:44:00AM +, Jamie Iles wrote: @@ -53,6 +59,10 @@ void __init fpga_irq_init(int parent_irq, u32 valid, struct fpga_irq_data *f) f-chip.irq_ack = fpga_irq_mask; f-chip.irq_mask =

Re: [PATCH 1/2] versatile: sic: add device tree bindings

2012-01-13 Thread Russell King - ARM Linux
On Fri, Jan 13, 2012 at 12:44:00AM +, Jamie Iles wrote: +#ifdef CONFIG_OF +int __init sic_of_init(struct device_node *np, struct device_node *parent) +{ + struct fpga_irq_data *sic_data = kzalloc(sizeof(*sic_data), GFP_KERNEL); + int err = -ENOMEM, irq; + + if

Re: [PATCH 1/2] versatile: sic: add device tree bindings

2012-01-13 Thread Jamie Iles
On Fri, Jan 13, 2012 at 10:48:42AM +, Russell King - ARM Linux wrote: On Fri, Jan 13, 2012 at 12:44:00AM +, Jamie Iles wrote: +#ifdef CONFIG_OF +int __init sic_of_init(struct device_node *np, struct device_node *parent) +{ + struct fpga_irq_data *sic_data =

Re: [PATCH 1/2] versatile: sic: add device tree bindings

2012-01-13 Thread Grant Likely
On Fri, Jan 13, 2012 at 10:58:34AM +, Jamie Iles wrote: On Fri, Jan 13, 2012 at 10:48:42AM +, Russell King - ARM Linux wrote: On Fri, Jan 13, 2012 at 12:44:00AM +, Jamie Iles wrote: +#ifdef CONFIG_OF +int __init sic_of_init(struct device_node *np, struct device_node

Re: [PATCH 1/2] versatile: sic: add device tree bindings

2012-01-13 Thread Russell King - ARM Linux
On Fri, Jan 13, 2012 at 11:41:51AM -0700, Grant Likely wrote: On Fri, Jan 13, 2012 at 10:58:34AM +, Jamie Iles wrote: On Fri, Jan 13, 2012 at 10:48:42AM +, Russell King - ARM Linux wrote: On Fri, Jan 13, 2012 at 12:44:00AM +, Jamie Iles wrote: +#ifdef CONFIG_OF +int

Re: [PATCH 1/2] versatile: sic: add device tree bindings

2012-01-13 Thread Grant Likely
On Fri, Jan 13, 2012 at 10:35:54AM +, Jamie Iles wrote: On Thu, Jan 12, 2012 at 07:29:32PM -0700, Grant Likely wrote: On Fri, Jan 13, 2012 at 12:44:00AM +, Jamie Iles wrote: @@ -53,6 +59,10 @@ void __init fpga_irq_init(int parent_irq, u32 valid, struct fpga_irq_data *f)

Re: [PATCH 1/2] versatile: sic: add device tree bindings

2012-01-13 Thread Russell King - ARM Linux
On Fri, Jan 13, 2012 at 02:00:41PM -0700, Grant Likely wrote: Let me look at it a bit. You can leave the initialization loop in fpga_irq_init() for now. I'm looking at adding a mask field to irq_domain_add_legacy in addition to the host_data pointer. I also want to investigate replacing

[PATCH 1/2] versatile: sic: add device tree bindings

2012-01-12 Thread Jamie Iles
Add a device tree binding for the FPGA SIC on versatile platforms. This also requires the addition of irq domain support for mapping to Linux IRQs. Cc: Grant Likely grant.lik...@secretlab.ca Cc: Rob Herring rob.herr...@calxeda.com Cc: Russell King li...@arm.linux.org.uk Signed-off-by: Jamie Iles

Re: [PATCH 1/2] versatile: sic: add device tree bindings

2012-01-12 Thread Grant Likely
On Fri, Jan 13, 2012 at 12:44:00AM +, Jamie Iles wrote: Add a device tree binding for the FPGA SIC on versatile platforms. This also requires the addition of irq domain support for mapping to Linux IRQs. Cc: Grant Likely grant.lik...@secretlab.ca Cc: Rob Herring rob.herr...@calxeda.com