Re: [PATCH 21/31] ARM: amba: realview: get rid of private platform amba_device initializer

2012-01-26 Thread Russell King - ARM Linux
On Wed, Jan 25, 2012 at 11:06:47AM +, Russell King - ARM Linux wrote: Right, so with the stack of amba patches on top, it looks like this, which to me looks sane. I haven't build-tested it though. Will, Did you see this? Any comment? Thanks. diff --git

Re: [PATCH 21/31] ARM: amba: realview: get rid of private platform amba_device initializer

2012-01-26 Thread Will Deacon
On Thu, Jan 26, 2012 at 05:25:27PM +, Russell King - ARM Linux wrote: On Wed, Jan 25, 2012 at 11:06:47AM +, Russell King - ARM Linux wrote: Right, so with the stack of amba patches on top, it looks like this, which to me looks sane. I haven't build-tested it though. Will, Hi

Re: [PATCH 21/31] ARM: amba: realview: get rid of private platform amba_device initializer

2012-01-26 Thread Russell King - ARM Linux
On Thu, Jan 26, 2012 at 05:37:21PM +, Will Deacon wrote: Acked-by: Will Deacon will.dea...@arm.com Thanks, I'll add that to patch 21 with the fix. ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org

Re: [PATCH 21/31] ARM: amba: realview: get rid of private platform amba_device initializer

2012-01-24 Thread Will Deacon
Hi Russell, On Fri, Jan 20, 2012 at 09:29:30AM +, Russell King - ARM Linux wrote: Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- arch/arm/mach-realview/core.h| 20 --- arch/arm/mach-realview/realview_eb.c | 38 +++---

Re: [PATCH 21/31] ARM: amba: realview: get rid of private platform amba_device initializer

2012-01-24 Thread Russell King - ARM Linux
On Tue, Jan 24, 2012 at 04:00:44PM +, Will Deacon wrote: Hi Russell, On Fri, Jan 20, 2012 at 09:29:30AM +, Russell King - ARM Linux wrote: Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- arch/arm/mach-realview/core.h| 20 ---

Re: [PATCH 21/31] ARM: amba: realview: get rid of private platform amba_device initializer

2012-01-24 Thread Will Deacon
On Tue, Jan 24, 2012 at 04:23:28PM +, Russell King - ARM Linux wrote: On Tue, Jan 24, 2012 at 04:00:44PM +, Will Deacon wrote: but then I see a warning during boot: [1.669654] [ cut here ] [1.684021] WARNING: at drivers/amba/bus.c:514

Re: [PATCH 21/31] ARM: amba: realview: get rid of private platform amba_device initializer

2012-01-24 Thread Linus Walleij
On 01/24/2012 06:26 PM, Will Deacon wrote: Right. I took a quick look at the TRM for the PB1176, and I think we do have an interrupt for GPIO0, it's just on the other GIC. This patch should do the trick, but I'm not sure what I can do to tickle the GPIO stuff anyway: For a simple test just

Re: [PATCH 21/31] ARM: amba: realview: get rid of private platform amba_device initializer

2012-01-24 Thread Russell King - ARM Linux
On Tue, Jan 24, 2012 at 05:26:00PM +, Will Deacon wrote: Right. I took a quick look at the TRM for the PB1176, and I think we do have an interrupt for GPIO0, it's just on the other GIC. This patch should do the trick, but I'm not sure what I can do to tickle the GPIO stuff anyway: diff

[PATCH 21/31] ARM: amba: realview: get rid of private platform amba_device initializer

2012-01-20 Thread Russell King - ARM Linux
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- arch/arm/mach-realview/core.h| 20 --- arch/arm/mach-realview/realview_eb.c | 38 +++--- arch/arm/mach-realview/realview_pb1176.c | 38 +++---