Re: [PATCH 3/5] ARM: vexpress: Add DT support in v2m

2011-11-18 Thread Pawel Moll
On Thu, 2011-11-17 at 15:53 +, Russell King - ARM Linux wrote: You're totally failing to understand the point. That's your opinion, I think otherwise, won't try to convince you. The point is that when Versatile Express first came out, it had a memory map. At this point in time, there was

Re: [PATCH 3/5] ARM: vexpress: Add DT support in v2m

2011-11-18 Thread Russell King - ARM Linux
On Fri, Nov 18, 2011 at 12:20:49PM +, Pawel Moll wrote: On Thu, 2011-11-17 at 15:53 +, Russell King - ARM Linux wrote: Again, this is _not_ how DT is supposed to work. DT is about describing the hardware, not describing the state of something. And that's exactly what I was

Re: [PATCH 3/5] ARM: vexpress: Add DT support in v2m

2011-11-18 Thread Russell King - ARM Linux
On Thu, Nov 17, 2011 at 06:37:26PM +, Dave Martin wrote: On Thu, Nov 17, 2011 at 04:05:37PM +, Russell King - ARM Linux wrote: You do understand that system_rev is for the system _revision_ not for some kind of system ID. For example, it's to identify whether we're on a revision 4,

Re: [PATCH 3/5] ARM: vexpress: Add DT support in v2m

2011-11-17 Thread Pawel Moll
On Wed, 2011-11-16 at 17:57 +, Dave Martin wrote: We should specify a list of all the standard aliases used by the generic motherboard code here, since these are part of the contract between each board-specific device tree and the motherboard code. Is timer the only one, or are

Re: [PATCH 3/5] ARM: vexpress: Add DT support in v2m

2011-11-17 Thread Dave Martin
On Thu, Nov 17, 2011 at 01:50:13PM +, Pawel Moll wrote: On Wed, 2011-11-16 at 17:57 +, Dave Martin wrote: We should specify a list of all the standard aliases used by the generic motherboard code here, since these are part of the contract between each board-specific device

Re: [PATCH 3/5] ARM: vexpress: Add DT support in v2m

2011-11-17 Thread Russell King - ARM Linux
On Wed, Nov 16, 2011 at 05:07:51PM +, Pawel Moll wrote: On Wed, 2011-11-16 at 16:59 +, Rob Herring wrote: It has nothing to do with taste and obviously documentation changes over time. I'm going to start naming everything with legacy because someday it all will be... It's about

Re: [PATCH 3/5] ARM: vexpress: Add DT support in v2m

2011-11-17 Thread Russell King - ARM Linux
On Fri, Nov 11, 2011 at 06:27:04PM +, Pawel Moll wrote: +#if defined(CONFIG_ARCH_VEXPRESS_DT) + int err; + const char *path; + struct device_node *node; + + node = of_find_compatible_node(NULL, NULL, arm,sp810); +

Re: [PATCH 3/5] ARM: vexpress: Add DT support in v2m

2011-11-17 Thread Dave Martin
On Thu, Nov 17, 2011 at 04:05:37PM +, Russell King - ARM Linux wrote: [...] @@ -383,11 +412,18 @@ static struct clk_lookup v2m_lookups[] = { }, }; +static void __init v2m_system_id(void) +{ + if (!system_rev) + system_rev = readl(v2m_sysreg_base +

Re: [PATCH 3/5] ARM: vexpress: Add DT support in v2m

2011-11-16 Thread Pawel Moll
On Wed, 2011-11-16 at 16:26 +, Rob Herring wrote: On 11/16/2011 09:44 AM, Dave Martin wrote: On Fri, Nov 11, 2011 at 06:27:04PM +, Pawel Moll wrote: This patch provides hooks for DT-based tile machine implementations and adds Device Tree description for the motherboard.

Re: [PATCH 3/5] ARM: vexpress: Add DT support in v2m

2011-11-16 Thread Rob Herring
On 11/16/2011 10:37 AM, Pawel Moll wrote: On Wed, 2011-11-16 at 16:26 +, Rob Herring wrote: On 11/16/2011 09:44 AM, Dave Martin wrote: On Fri, Nov 11, 2011 at 06:27:04PM +, Pawel Moll wrote: This patch provides hooks for DT-based tile machine implementations and adds Device Tree

Re: [PATCH 3/5] ARM: vexpress: Add DT support in v2m

2011-11-16 Thread Pawel Moll
On Wed, 2011-11-16 at 16:59 +, Rob Herring wrote: It has nothing to do with taste and obviously documentation changes over time. I'm going to start naming everything with legacy because someday it all will be... It's about how you create compatible strings. They should not be generic,

Re: [PATCH 3/5] ARM: vexpress: Add DT support in v2m

2011-11-16 Thread Dave Martin
On Wed, Nov 16, 2011 at 05:07:51PM +, Pawel Moll wrote: On Wed, 2011-11-16 at 16:59 +, Rob Herring wrote: It has nothing to do with taste and obviously documentation changes over time. I'm going to start naming everything with legacy because someday it all will be... It's about

Re: [PATCH 3/5] ARM: vexpress: Add DT support in v2m

2011-11-16 Thread Pawel Moll
On Wed, 2011-11-16 at 17:07 +, Pawel Moll wrote: I'd rather second Dave's idea of having compatible = arm,vexpress-model, arm-vexpress-rs1, arm-vexpress; and + compatible = arm,vexpress-model, arm,vexpress-legacy, arm-vexpress; If

Re: [PATCH 3/5] ARM: vexpress: Add DT support in v2m

2011-11-16 Thread Dave Martin
On Wed, Nov 16, 2011 at 05:07:51PM +, Pawel Moll wrote: On Wed, 2011-11-16 at 16:59 +, Rob Herring wrote: It has nothing to do with taste and obviously documentation changes over time. I'm going to start naming everything with legacy because someday it all will be... It's about

Re: [PATCH 3/5] ARM: vexpress: Add DT support in v2m

2011-11-16 Thread Dave Martin
On Wed, Nov 16, 2011 at 04:35:15PM +, Pawel Moll wrote: [...] + - for Coretile Express A5x2 (V2P-CA5s): + compatible = arm,vexpress-v2p-ca5s, arm-vexpress; + - Coretile Express A9x4 (V2P-CA9): + comaptible = arm,vexpress-v2p-ca9, arm,vexpress-legacy, arm-vexpress; +

[PATCH 3/5] ARM: vexpress: Add DT support in v2m

2011-11-11 Thread Pawel Moll
This patch provides hooks for DT-based tile machine implementations and adds Device Tree description for the motherboard. Signed-off-by: Pawel Moll pawel.m...@arm.com --- Documentation/devicetree/bindings/arm/vexpress| 92 ++ arch/arm/boot/dts/vexpress-v2m-legacy.dtsi| 190