Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-20 Thread Cousson, Benoit
On 9/19/2011 11:53 PM, Rob Herring wrote: On 09/19/2011 04:14 PM, Grant Likely wrote: On Mon, Sep 19, 2011 at 7:48 AM, Rob Herringrobherri...@gmail.com wrote: On 09/19/2011 07:09 AM, Cousson, Benoit wrote: On 9/18/2011 11:23 PM, Rob Herring wrote: I was headed down the path of implementing

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-19 Thread Cousson, Benoit
On 9/18/2011 8:15 AM, Grant Likely wrote: On Thu, Sep 15, 2011 at 12:07:25PM +0200, Cousson, Benoit wrote: Hi Rob, On 9/15/2011 9:55 AM, Thomas Abraham wrote: Hi Rob, On 14 September 2011 22:01, Rob Herringrobherri...@gmail.com wrote: From: Rob Herringrob.herr...@calxeda.com This adds

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-19 Thread Dave Martin
On Sun, Sep 18, 2011 at 7:21 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Fri, Sep 16, 2011 at 05:09:39PM +0100, Dave Martin wrote: For now, we express the mapping by putting an interrupt-map in the core-tile DT, but this feels inelegant as well as wasteful -- expressing + 32 using a

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-19 Thread Cousson, Benoit
On 9/18/2011 11:23 PM, Rob Herring wrote: On 09/15/2011 11:43 AM, Rob Herring wrote: On 09/15/2011 08:52 AM, Cousson, Benoit wrote: On 9/15/2011 3:11 PM, Rob Herring wrote: On 09/15/2011 05:07 AM, Cousson, Benoit wrote: [...] I have another concern on a similar topic. On OMAP4 the SoC

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-19 Thread Thomas Abraham
Hi Grant, On 18 September 2011 11:40, Grant Likely grant.lik...@secretlab.ca wrote: On Fri, Sep 16, 2011 at 03:04:11PM +0530, Thomas Abraham wrote: Hi Rob, On 15 September 2011 18:24, Rob Herring robherri...@gmail.com wrote: On 09/15/2011 02:55 AM, Thomas Abraham wrote: +void __init

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-19 Thread Cousson, Benoit
On 9/19/2011 2:07 PM, Dave Martin wrote: On Sun, Sep 18, 2011 at 7:21 AM, Grant Likelygrant.lik...@secretlab.ca wrote: On Fri, Sep 16, 2011 at 05:09:39PM +0100, Dave Martin wrote: For now, we express the mapping by putting an interrupt-map in the core-tile DT, but this feels inelegant as well

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-19 Thread Russell King - ARM Linux
On Mon, Sep 19, 2011 at 11:47:18AM +0200, Cousson, Benoit wrote: Since the cpumask is not relevant for the SPI, maybe having two interrupt controllers will be more relevant. Or maybe 3, since there is some SGIs as well. I don't think anyone uses SGIs outside of the common SMP code.

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-19 Thread Rob Herring
On 09/19/2011 07:09 AM, Cousson, Benoit wrote: On 9/18/2011 11:23 PM, Rob Herring wrote: On 09/15/2011 11:43 AM, Rob Herring wrote: On 09/15/2011 08:52 AM, Cousson, Benoit wrote: On 9/15/2011 3:11 PM, Rob Herring wrote: On 09/15/2011 05:07 AM, Cousson, Benoit wrote: [...] I have another

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-19 Thread Cousson, Benoit
On 9/19/2011 3:48 PM, Rob Herring wrote: On 09/19/2011 07:09 AM, Cousson, Benoit wrote: On 9/18/2011 11:23 PM, Rob Herring wrote: On 09/15/2011 11:43 AM, Rob Herring wrote: On 09/15/2011 08:52 AM, Cousson, Benoit wrote: On 9/15/2011 3:11 PM, Rob Herring wrote: On 09/15/2011 05:07 AM,

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-19 Thread Russell King - ARM Linux
On Mon, Sep 19, 2011 at 02:09:46PM +0200, Cousson, Benoit wrote: Every CortexA9 based SoC have to add the 32 offset to the SoC level interrupt number line. The ID numbering scheme is relevant only inside the GIC, but at SoC level only the IRQ lines that entered the MP core are relevant. That

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-19 Thread Grant Likely
On Mon, Sep 19, 2011 at 7:33 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Mon, Sep 19, 2011 at 11:47:18AM +0200, Cousson, Benoit wrote: Since the cpumask is not relevant for the SPI, maybe having two interrupt controllers will be more relevant. Or maybe 3, since there is some

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-19 Thread Grant Likely
On Sun, Sep 18, 2011 at 04:23:40PM -0500, Rob Herring wrote: On 09/15/2011 11:43 AM, Rob Herring wrote: I see 2 options (besides leaving it as is): - Revert back to my previous binding where PPIs are a sub-node and a different interrupt parent. - Use the current binding, but allow

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-19 Thread Grant Likely
On Mon, Sep 19, 2011 at 3:53 PM, Rob Herring robherri...@gmail.com wrote: On 09/19/2011 04:14 PM, Grant Likely wrote: * ARM Generic Interrupt Controller ARM SMP cores are often associated with a GIC, providing per processor interrupts (PPI), shared processor interrupts (SPI) and software

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-19 Thread Grant Likely
On Mon, Sep 19, 2011 at 04:53:39PM -0500, Rob Herring wrote: On 09/19/2011 04:14 PM, Grant Likely wrote: (Alternately, if there is no need for a CPU mask because PPI interrupts will never be wired to more than one CPU, then it would be better to encode the CPU number into the second cell

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-18 Thread Grant Likely
On Fri, Sep 16, 2011 at 03:04:11PM +0530, Thomas Abraham wrote: Hi Rob, On 15 September 2011 18:24, Rob Herring robherri...@gmail.com wrote: On 09/15/2011 02:55 AM, Thomas Abraham wrote: +void __init gic_of_init(struct device_node *node, struct device_node *parent) +{ +       void

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-18 Thread Grant Likely
On Fri, Sep 16, 2011 at 05:09:39PM +0100, Dave Martin wrote: For now, we express the mapping by putting an interrupt-map in the core-tile DT, but this feels inelegant as well as wasteful -- expressing + 32 using a table which is about 1K in size and duplicates that information 43 times.

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-18 Thread Grant Likely
On Thu, Sep 15, 2011 at 12:07:25PM +0200, Cousson, Benoit wrote: Hi Rob, On 9/15/2011 9:55 AM, Thomas Abraham wrote: Hi Rob, On 14 September 2011 22:01, Rob Herringrobherri...@gmail.com wrote: From: Rob Herringrob.herr...@calxeda.com This adds gic initialization using device tree

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-18 Thread Grant Likely
On Wed, Sep 14, 2011 at 11:31:40AM -0500, Rob Herring wrote: From: Rob Herring rob.herr...@calxeda.com This adds gic initialization using device tree data. The initialization functions are intended to be called by a generic OF interrupt controller parsing function once the right pieces are

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-18 Thread Rob Herring
On 09/15/2011 11:43 AM, Rob Herring wrote: Benoit, On 09/15/2011 08:52 AM, Cousson, Benoit wrote: On 9/15/2011 3:11 PM, Rob Herring wrote: Benoit, On 09/15/2011 05:07 AM, Cousson, Benoit wrote: Hi Rob, On 9/15/2011 9:55 AM, Thomas Abraham wrote: Hi Rob, On 14 September 2011 22:01,

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-17 Thread Grant Likely
On Wed, Sep 14, 2011 at 01:51:42PM -0500, Rob Herring wrote: On 09/14/2011 01:34 PM, Marc Zyngier wrote: Hi Rob, On 14/09/11 18:57, Rob Herring wrote: Marc, On 09/14/2011 12:46 PM, Marc Zyngier wrote: On 14/09/11 17:31, Rob Herring wrote: From: Rob Herring rob.herr...@calxeda.com

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-16 Thread Thomas Abraham
Hi Rob, On 15 September 2011 18:24, Rob Herring robherri...@gmail.com wrote: On 09/15/2011 02:55 AM, Thomas Abraham wrote: Hi Rob, On 14 September 2011 22:01, Rob Herring robherri...@gmail.com wrote: From: Rob Herring rob.herr...@calxeda.com This adds gic initialization using device tree

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-16 Thread Dave Martin
On Thu, Sep 15, 2011 at 12:07:25PM +0200, Cousson, Benoit wrote: Hi Rob, On 9/15/2011 9:55 AM, Thomas Abraham wrote: Hi Rob, On 14 September 2011 22:01, Rob Herringrobherri...@gmail.com wrote: From: Rob Herringrob.herr...@calxeda.com This adds gic initialization using device tree

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-15 Thread Cousson, Benoit
Hi Rob, On 9/15/2011 9:55 AM, Thomas Abraham wrote: Hi Rob, On 14 September 2011 22:01, Rob Herringrobherri...@gmail.com wrote: From: Rob Herringrob.herr...@calxeda.com This adds gic initialization using device tree data. The initialization functions are intended to be called by a generic

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-15 Thread Russell King - ARM Linux
On Thu, Sep 15, 2011 at 12:07:25PM +0200, Cousson, Benoit wrote: On OMAP4 the SoC interrupts external to the MPU (SPI) have an offset of 32. Only the internal PPI are between 0 and 31. SGIs are 0 to 15, PPIs are 16 to 31, and SPIs are 32+ - that's the numbering given to us by the GIC. The

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-15 Thread Arnd Bergmann
On Wednesday 14 September 2011, Rob Herring wrote: From: Rob Herring rob.herr...@calxeda.com This adds gic initialization using device tree data. The initialization functions are intended to be called by a generic OF interrupt controller parsing function once the right pieces are in place.

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-15 Thread Cousson, Benoit
On 9/15/2011 12:29 PM, Russell King - ARM Linux wrote: On Thu, Sep 15, 2011 at 12:07:25PM +0200, Cousson, Benoit wrote: On OMAP4 the SoC interrupts external to the MPU (SPI) have an offset of 32. Only the internal PPI are between 0 and 31. SGIs are 0 to 15, PPIs are 16 to 31, and SPIs are 32+

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-15 Thread Russell King - ARM Linux
On Thu, Sep 15, 2011 at 02:28:06PM +0200, Cousson, Benoit wrote: The HW specs is obviously counting the IRQ number at the GIC interface. That offset is not known outside the MPUSS. Please have a look at the OMAP4430 TRM p4761 (NDA vM version). As far as I know, I have no access to that.

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-15 Thread Rob Herring
On 09/15/2011 02:55 AM, Thomas Abraham wrote: Hi Rob, On 14 September 2011 22:01, Rob Herring robherri...@gmail.com wrote: From: Rob Herring rob.herr...@calxeda.com This adds gic initialization using device tree data. The initialization functions are intended to be called by a generic OF

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-15 Thread Cousson, Benoit
On 9/15/2011 2:51 PM, Russell King - ARM Linux wrote: On Thu, Sep 15, 2011 at 02:28:06PM +0200, Cousson, Benoit wrote: The HW specs is obviously counting the IRQ number at the GIC interface. That offset is not known outside the MPUSS. Please have a look at the OMAP4430 TRM p4761 (NDA vM

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-15 Thread Rob Herring
Benoit, On 09/15/2011 05:07 AM, Cousson, Benoit wrote: Hi Rob, On 9/15/2011 9:55 AM, Thomas Abraham wrote: Hi Rob, On 14 September 2011 22:01, Rob Herringrobherri...@gmail.com wrote: From: Rob Herringrob.herr...@calxeda.com This adds gic initialization using device tree data. The

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-15 Thread Cousson, Benoit
On 9/15/2011 3:11 PM, Rob Herring wrote: Benoit, On 09/15/2011 05:07 AM, Cousson, Benoit wrote: Hi Rob, On 9/15/2011 9:55 AM, Thomas Abraham wrote: Hi Rob, On 14 September 2011 22:01, Rob Herringrobherri...@gmail.com wrote: From: Rob Herringrob.herr...@calxeda.com This adds gic

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-15 Thread Rob Herring
Benoit, On 09/15/2011 08:52 AM, Cousson, Benoit wrote: On 9/15/2011 3:11 PM, Rob Herring wrote: Benoit, On 09/15/2011 05:07 AM, Cousson, Benoit wrote: Hi Rob, On 9/15/2011 9:55 AM, Thomas Abraham wrote: Hi Rob, On 14 September 2011 22:01, Rob Herringrobherri...@gmail.com wrote: From:

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-14 Thread Rob Herring
Marc, On 09/14/2011 12:46 PM, Marc Zyngier wrote: On 14/09/11 17:31, Rob Herring wrote: From: Rob Herring rob.herr...@calxeda.com This adds gic initialization using device tree data. The initialization functions are intended to be called by a generic OF interrupt controller parsing function

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-14 Thread Marc Zyngier
On 14/09/11 17:31, Rob Herring wrote: From: Rob Herring rob.herr...@calxeda.com This adds gic initialization using device tree data. The initialization functions are intended to be called by a generic OF interrupt controller parsing function once the right pieces are in place. PPIs are

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-14 Thread Marc Zyngier
Hi Rob, On 14/09/11 18:57, Rob Herring wrote: Marc, On 09/14/2011 12:46 PM, Marc Zyngier wrote: On 14/09/11 17:31, Rob Herring wrote: From: Rob Herring rob.herr...@calxeda.com This adds gic initialization using device tree data. The initialization functions are intended to be called by a

Re: [PATCH 5/5] ARM: gic: add OF based initialization

2011-09-14 Thread Rob Herring
On 09/14/2011 01:34 PM, Marc Zyngier wrote: Hi Rob, On 14/09/11 18:57, Rob Herring wrote: Marc, On 09/14/2011 12:46 PM, Marc Zyngier wrote: On 14/09/11 17:31, Rob Herring wrote: From: Rob Herring rob.herr...@calxeda.com This adds gic initialization using device tree data. The