Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-07-07 Thread Barry Song
2011/6/30 Arnd Bergmann a...@arndb.de: On Thursday 30 June 2011, Barry Song wrote: Is this really just one bus with a huge address space, or rather some nested buses? I'd prefer to have the device tree representation as close as possible to the actual layout. there are two AXI buses in

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-07-06 Thread Barry Song
2011/7/6 Barry Song 21cn...@gmail.com: 2011/7/6 Grant Likely grant.lik...@secretlab.ca: On Tue, Jul 05, 2011 at 04:34:05PM +0800, Barry Song wrote: Hi Arnd, 2011/7/1 Barry Song 21cn...@gmail.com: Hi Arnd, 2011/6/30 Arnd Bergmann a...@arndb.de: On Thursday 30 June 2011, Barry Song

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-07-06 Thread Grant Likely
On Wed, Jul 06, 2011 at 02:01:24PM +0800, Barry Song wrote: 2011/7/6 Barry Song 21cn...@gmail.com: 2011/7/6 Grant Likely grant.lik...@secretlab.ca:                       intc: interrupt-controller@0x8002 {                               #interrupt-cells = 1;                            

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-07-06 Thread Barry Song
Hi Grant, Thanks. 2011/7/6 Grant Likely grant.lik...@secretlab.ca: On Wed, Jul 06, 2011 at 02:01:24PM +0800, Barry Song wrote: 2011/7/6 Barry Song 21cn...@gmail.com: 2011/7/6 Grant Likely grant.lik...@secretlab.ca:                       intc: interrupt-controller@0x8002 {              

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-07-06 Thread Arnd Bergmann
On Wednesday 06 July 2011 09:03:45 Barry Song wrote: but it seems we will still add sirf,alsta6-intc in intc driver if that really happen in the future. in my understanding, drivers should explicitly claim all chips or ip cores they can support. I don't think there is a need for that. I'd only

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-07-05 Thread Barry Song
Hi Arnd, 2011/7/1 Barry Song 21cn...@gmail.com: Hi Arnd, 2011/6/30 Arnd Bergmann a...@arndb.de: On Thursday 30 June 2011, Barry Song wrote: Is this really just one bus with a huge address space, or rather some nested buses? I'd prefer to have the device tree representation as close as

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-07-05 Thread Arnd Bergmann
On Tuesday 05 July 2011, Barry Song wrote: If your hardware can do that, you can replace the msleep() with a single readl or a readl()/msleep(1) loop? i can't agree more. if there is such a register in chip, we would have used it. ic guys confirmed there isn't such a register. so..delay...

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-07-05 Thread Grant Likely
On Tue, Jul 05, 2011 at 04:34:05PM +0800, Barry Song wrote: Hi Arnd, 2011/7/1 Barry Song 21cn...@gmail.com: Hi Arnd, 2011/6/30 Arnd Bergmann a...@arndb.de: On Thursday 30 June 2011, Barry Song wrote: Is this really just one bus with a huge address space, or rather some nested

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-07-05 Thread Barry Song
2011/7/6 Grant Likely grant.lik...@secretlab.ca: On Tue, Jul 05, 2011 at 04:34:05PM +0800, Barry Song wrote: Hi Arnd, 2011/7/1 Barry Song 21cn...@gmail.com: Hi Arnd, 2011/6/30 Arnd Bergmann a...@arndb.de: On Thursday 30 June 2011, Barry Song wrote: Is this really just one bus with

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-07-04 Thread Grant Likely
On Fri, Jul 01, 2011 at 08:04:06AM +0800, Barry Song wrote: 2011/6/30 Arnd Bergmann a...@arndb.de: On Thursday 30 June 2011, Barry Song wrote: Is this really just one bus with a huge address space, or rather some nested buses? I'd prefer to have the device tree representation as

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-07-04 Thread Barry Song
2011/7/4 Arnd Bergmann a...@arndb.de: On Monday 04 July 2011, Barry Song wrote: Great idea. in fact there is only one reset bit for every device. So maybe the rstc.c can be ... Yes, looks good.         /*          * Writing 1 to this bit resets corresponding block.          * Writing 0

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-07-03 Thread Barry Song
2011/7/2 Arnd Bergmann a...@arndb.de: On Friday 01 July 2011, Barry Song wrote: It looks like we can new a common function named as of_io_earlymap() or something in drivers/of/address.c. of_iomap() does ioremap, of_io_earlymap() does early static mapping? Then all SoCs can call this function

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-07-02 Thread Russell King - ARM Linux
On Fri, Jul 01, 2011 at 06:19:43PM +0200, Arnd Bergmann wrote: On Friday 01 July 2011, Barry Song wrote: It looks like we can new a common function named as of_io_earlymap() or something in drivers/of/address.c. of_iomap() does ioremap, of_io_earlymap() does early static mapping? Then all

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-07-02 Thread Arnd Bergmann
On Saturday 02 July 2011 14:25:27 Russell King - ARM Linux wrote: On Fri, Jul 01, 2011 at 06:19:43PM +0200, Arnd Bergmann wrote: On Friday 01 July 2011, Barry Song wrote: It looks like we can new a common function named as of_io_earlymap() or something in drivers/of/address.c. of_iomap()

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-07-01 Thread Barry Song
Hi Arnd, 2011/6/30 Arnd Bergmann a...@arndb.de: On Thursday 30 June 2011, Barry Song wrote: Is this really just one bus with a huge address space, or rather some nested buses? I'd prefer to have the device tree representation as close as possible to the actual layout. there are two AXI

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-07-01 Thread Arnd Bergmann
On Friday 01 July 2011, Barry Song wrote: It looks like we can new a common function named as of_io_earlymap() or something in drivers/of/address.c. of_iomap() does ioremap, of_io_earlymap() does early static mapping? Then all SoCs can call this function to do early static mapping. if so,

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-07-01 Thread Arnd Bergmann
On Friday 01 July 2011, Barry Song wrote: except Wall St and stock, i really didn't realize CSR is something related with 'China Security Surveillance Tech. Inc' . it seems CSR is much more extensively known as a company in Wireless Technology, Audio, Connectivity and GPS. if we lost this

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-06-30 Thread Barry Song
Hi Arnd, Thanks. 2011/6/30 Arnd Bergmann a...@arndb.de: On Tuesday 28 June 2011, Barry Song wrote: This patch adds the basic support for this SoC and EVB board based on device tree. It is following the ZYNQ of Grant Likely in some degree. Hi Barry, There are a few more things I noticed

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-06-30 Thread Arnd Bergmann
On Thursday 30 June 2011, Barry Song wrote: Is this really just one bus with a huge address space, or rather some nested buses? I'd prefer to have the device tree representation as close as possible to the actual layout. there are two AXI buses in prima2. AXI-1 connect to memory, AXI-2

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-06-30 Thread Rob Herring
On 06/30/2011 05:36 AM, Arnd Bergmann wrote: On Thursday 30 June 2011, Barry Song wrote: Is this really just one bus with a huge address space, or rather some nested buses? I'd prefer to have the device tree representation as close as possible to the actual layout. there are two AXI buses

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-06-29 Thread Arnd Bergmann
On Tuesday 28 June 2011, Barry Song wrote: This patch adds the basic support for this SoC and EVB board based on device tree. It is following the ZYNQ of Grant Likely in some degree. Hi Barry, There are a few more things I noticed this time around, and some comments about code that changed

Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support

2011-06-29 Thread Barry Song
Hi Arnd, Thanks! 2011/6/30 Arnd Bergmann a...@arndb.de: On Tuesday 28 June 2011, Barry Song wrote: This patch adds the basic support for this SoC and EVB board based on device tree. It is following the ZYNQ of Grant Likely in some degree. Hi Barry, There are a few more things I noticed