Re: [PATCH v2 4/7] tty: serial: support device tree in pxa

2011-08-01 Thread Russell King - ARM Linux
On Mon, Aug 01, 2011 at 10:50:47AM +0800, Haojian Zhuang wrote: On Sat, Jul 30, 2011 at 12:49 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Oh ffs, why is this DT stuff causing all the clk stuff to have to change. And specifically why is stuff converting to use clk_get_sys().

Re: [PATCH v2 4/7] tty: serial: support device tree in pxa

2011-07-31 Thread Haojian Zhuang
On Sat, Jul 30, 2011 at 12:49 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Jul 29, 2011 at 10:45:39AM -0600, Grant Likely wrote: On Thu, Jul 28, 2011 at 02:41:30PM +0800, Haojian Zhuang wrote: +#ifdef CONFIG_OF +   for (i = 0; i PXA_SERIAL_NR; i++) { +           if

Re: [PATCH v2 4/7] tty: serial: support device tree in pxa

2011-07-29 Thread Grant Likely
On Thu, Jul 28, 2011 at 02:41:30PM +0800, Haojian Zhuang wrote: Support both normal platform driver and device tree driver in serial pxa. Signed-off-by: Haojian Zhuang haojian.zhu...@marvell.com --- drivers/tty/serial/pxa.c | 51 - 1 files

Re: [PATCH v2 4/7] tty: serial: support device tree in pxa

2011-07-29 Thread Russell King - ARM Linux
On Fri, Jul 29, 2011 at 10:45:39AM -0600, Grant Likely wrote: On Thu, Jul 28, 2011 at 02:41:30PM +0800, Haojian Zhuang wrote: +#ifdef CONFIG_OF + for (i = 0; i PXA_SERIAL_NR; i++) { + if (serial_pxa_ports[i] == NULL) + break; + } + if (i =

Re: [PATCH v2 4/7] tty: serial: support device tree in pxa

2011-07-29 Thread Grant Likely
On Fri, Jul 29, 2011 at 05:49:22PM +0100, Russell King - ARM Linux wrote: On Fri, Jul 29, 2011 at 10:45:39AM -0600, Grant Likely wrote: On Thu, Jul 28, 2011 at 02:41:30PM +0800, Haojian Zhuang wrote: +#ifdef CONFIG_OF + for (i = 0; i PXA_SERIAL_NR; i++) { + if