Re: [PATCH v3] Input: keyboard - add device tree bindings for simple key matrixes

2012-01-03 Thread Olof Johansson
Hi, On Mon, Jan 02, 2012 at 10:39:04AM -0800, Simon Glass wrote: diff --git a/Documentation/devicetree/bindings/input/matrix-keymap.txt b/Documentation/devicetree/bindings/input/matrix-keymap.txt new file mode 100644 index 000..1db8e12 --- /dev/null +++

Re: [PATCH v3] Input: keyboard - add device tree bindings for simple key matrixes

2012-01-03 Thread Simon Glass
Hi Olof, On Tue, Jan 3, 2012 at 7:43 AM, Olof Johansson o...@lixom.net wrote: Hi, On Mon, Jan 02, 2012 at 10:39:04AM -0800, Simon Glass wrote: diff --git a/Documentation/devicetree/bindings/input/matrix-keymap.txt b/Documentation/devicetree/bindings/input/matrix-keymap.txt new file mode

Re: [PATCH v3] Input: keyboard - add device tree bindings for simple key matrixes

2012-01-03 Thread Russell King - ARM Linux
On Tue, Jan 03, 2012 at 08:22:21AM -0800, Simon Glass wrote: Can the Linux key codes fit in 8 bits? That depends on your point of view. If you hack on X, then the answer is yes and you ignore the squeels of your users when certain key presses get misinterpreted. (The Psion LX platform,

Re: [PATCH v3] Input: keyboard - add device tree bindings for simple key matrixes

2012-01-03 Thread Dmitry Torokhov
On Tue, Jan 03, 2012 at 04:29:30PM +, Russell King - ARM Linux wrote: On Tue, Jan 03, 2012 at 08:22:21AM -0800, Simon Glass wrote: Can the Linux key codes fit in 8 bits? That depends on your point of view. If you hack on X, then the answer is yes and you ignore the squeels of your

Re: [PATCH v3] Input: keyboard - add device tree bindings for simple key matrixes

2012-01-03 Thread Olof Johansson
On Tue, Jan 3, 2012 at 8:44 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Tue, Jan 03, 2012 at 04:29:30PM +, Russell King - ARM Linux wrote: On Tue, Jan 03, 2012 at 08:22:21AM -0800, Simon Glass wrote: Can the Linux key codes fit in 8 bits? That depends on your point of view.

Re: [PATCH v3] Input: keyboard - add device tree bindings for simple key matrixes

2012-01-03 Thread Russell King - ARM Linux
On Tue, Jan 03, 2012 at 08:44:32AM -0800, Dmitry Torokhov wrote: On Tue, Jan 03, 2012 at 04:29:30PM +, Russell King - ARM Linux wrote: On Tue, Jan 03, 2012 at 08:22:21AM -0800, Simon Glass wrote: Can the Linux key codes fit in 8 bits? That depends on your point of view. If you

RE: [PATCH v3] Input: keyboard - add device tree bindings for simple key matrixes

2012-01-03 Thread Stephen Warren
Olof Johansson wrote at Sunday, January 01, 2012 11:09 PM: This adds a simple device tree binding for simple key matrix data and a helper to fill in the platform data. The implementation is in a shared file outside if drivers/input/keyboard since some drivers in drivers/input/misc might be

Re: [PATCH v3] Input: keyboard - add device tree bindings for simple key matrixes

2012-01-03 Thread Dmitry Torokhov
On Tue, Jan 03, 2012 at 05:06:15PM +, Russell King - ARM Linux wrote: On Tue, Jan 03, 2012 at 08:44:32AM -0800, Dmitry Torokhov wrote: On Tue, Jan 03, 2012 at 04:29:30PM +, Russell King - ARM Linux wrote: On Tue, Jan 03, 2012 at 08:22:21AM -0800, Simon Glass wrote: Can the Linux

Re: [PATCH v3] Input: keyboard - add device tree bindings for simple key matrixes

2012-01-02 Thread Simon Glass
Hi Olof, On Sun, Jan 1, 2012 at 10:09 PM, Olof Johansson o...@lixom.net wrote: This adds a simple device tree binding for simple key matrix data and a helper to fill in the platform data. The implementation is in a shared file outside if drivers/input/keyboard since some drivers in