Re: [PATCH v4 04/14] mfd: Add Samsung PWM/timer master driver

2013-04-11 Thread Mark Brown
On Thu, Apr 11, 2013 at 12:35:47AM +0200, Arnd Bergmann wrote: Sorry for not replying earlier. My idea for the register level interface was to create a platform_device for each PWM, e.g. using the mfd_cell infrastructure. You can then pass a struct regmap as the platform data for each child

Re: [PATCH v4 04/14] mfd: Add Samsung PWM/timer master driver

2013-04-11 Thread Tomasz Figa
On Thursday 11 of April 2013 00:35:47 Arnd Bergmann wrote: On Monday 08 April 2013, Tomasz Figa wrote: On Saturday 06 of April 2013 00:24:18 Tomasz Figa wrote: On Friday 05 of April 2013 21:54:21 Arnd Bergmann wrote: On Friday 05 April 2013, Tomasz Figa wrote: I'm not sure what you

Re: [PATCH v4 04/14] mfd: Add Samsung PWM/timer master driver

2013-04-11 Thread Arnd Bergmann
On Thursday 11 April 2013, Tomasz Figa wrote: On Thursday 11 of April 2013 00:35:47 Arnd Bergmann wrote: On Monday 08 April 2013, Tomasz Figa wrote: On Saturday 06 of April 2013 00:24:18 Tomasz Figa wrote: On Friday 05 of April 2013 21:54:21 Arnd Bergmann wrote: On Friday 05 April

Re: [PATCH v4 04/14] mfd: Add Samsung PWM/timer master driver

2013-04-10 Thread Arnd Bergmann
On Monday 08 April 2013, Tomasz Figa wrote: On Saturday 06 of April 2013 00:24:18 Tomasz Figa wrote: On Friday 05 of April 2013 21:54:21 Arnd Bergmann wrote: On Friday 05 April 2013, Tomasz Figa wrote: I'm not sure what you mean by a register-level interface. Something like

Re: [PATCH v4 04/14] mfd: Add Samsung PWM/timer master driver

2013-04-08 Thread Tomasz Figa
On Saturday 06 of April 2013 00:24:18 Tomasz Figa wrote: On Friday 05 of April 2013 21:54:21 Arnd Bergmann wrote: On Friday 05 April 2013, Tomasz Figa wrote: I don't think anyone ever suggested using a private API though. I must have gotten the last paragraph of

Re: [PATCH v4 04/14] mfd: Add Samsung PWM/timer master driver

2013-04-05 Thread Samuel Ortiz
Hi Tomasz, On Thu, Apr 04, 2013 at 06:37:01PM +0200, Tomasz Figa wrote: This patch adds master driver for PWM/timer block available on many Samsung SoCs providing clocksource and PWM output capabilities. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park

Re: [PATCH v4 04/14] mfd: Add Samsung PWM/timer master driver

2013-04-05 Thread Tomasz Figa
Hi Samuel, On Friday 05 of April 2013 18:39:58 Samuel Ortiz wrote: Hi Tomasz, On Thu, Apr 04, 2013 at 06:37:01PM +0200, Tomasz Figa wrote: This patch adds master driver for PWM/timer block available on many Samsung SoCs providing clocksource and PWM output capabilities.

Re: [PATCH v4 04/14] mfd: Add Samsung PWM/timer master driver

2013-04-05 Thread Arnd Bergmann
On Friday 05 April 2013, Tomasz Figa wrote: On Friday 05 of April 2013 18:39:58 Samuel Ortiz wrote: Hi Tomasz, On Thu, Apr 04, 2013 at 06:37:01PM +0200, Tomasz Figa wrote: This patch adds master driver for PWM/timer block available on many Samsung SoCs providing clocksource and PWM

Re: [PATCH v4 04/14] mfd: Add Samsung PWM/timer master driver

2013-04-05 Thread Tomasz Figa
On Friday 05 of April 2013 19:05:24 Arnd Bergmann wrote: On Friday 05 April 2013, Tomasz Figa wrote: On Friday 05 of April 2013 18:39:58 Samuel Ortiz wrote: Hi Tomasz, On Thu, Apr 04, 2013 at 06:37:01PM +0200, Tomasz Figa wrote: This patch adds master driver for PWM/timer block

Re: [PATCH v4 04/14] mfd: Add Samsung PWM/timer master driver

2013-04-05 Thread Arnd Bergmann
On Friday 05 April 2013, Tomasz Figa wrote: I don't think anyone ever suggested using a private API though. I must have gotten the last paragraph of http://article.gmane.org/gmane.linux.kernel.samsung-soc/16638 wrong then. For me it seemed like the timer driver would expose a private API

Re: [PATCH v4 04/14] mfd: Add Samsung PWM/timer master driver

2013-04-05 Thread Tomasz Figa
On Friday 05 of April 2013 21:54:21 Arnd Bergmann wrote: On Friday 05 April 2013, Tomasz Figa wrote: I don't think anyone ever suggested using a private API though. I must have gotten the last paragraph of http://article.gmane.org/gmane.linux.kernel.samsung-soc/16638 wrong then. For

[PATCH v4 04/14] mfd: Add Samsung PWM/timer master driver

2013-04-04 Thread Tomasz Figa
This patch adds master driver for PWM/timer block available on many Samsung SoCs providing clocksource and PWM output capabilities. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/pwm/pwm-samsung.txt| 37 ++