Re: [PATCH v5 5/9] ARM: versatile: Map local timers using Device Tree when possible

2011-12-12 Thread Pawel Moll
Morning, On Sat, 2011-12-10 at 15:27 +, Sergei Shtylyov wrote: int __cpuinit local_timer_setup(struct clock_event_device *evt) { +#if defined(CONFIG_OF) + if (!twd_base) { + struct device_node *np = of_find_compatible_node(NULL, + NULL,

Re: [PATCH v5 5/9] ARM: versatile: Map local timers using Device Tree when possible

2011-12-12 Thread Sergei Shtylyov
Hello. On 12-12-2011 15:03, Pawel Moll wrote: int __cpuinit local_timer_setup(struct clock_event_device *evt) { +#if defined(CONFIG_OF) + if (!twd_base) { + struct device_node *np = of_find_compatible_node(NULL, + NULL, arm,smp-twd); + +

Re: [PATCH v5 5/9] ARM: versatile: Map local timers using Device Tree when possible

2011-12-12 Thread Pawel Moll
On Mon, 2011-12-12 at 11:18 +, Sergei Shtylyov wrote: I think if of_iomap() fails, it's because the system is out of memory, so -ENOMEM seems more proper error in this case. Although... it's not the only case when of_iomap() fails. I actually think that in this use case it's much

Re: [PATCH v5 5/9] ARM: versatile: Map local timers using Device Tree when possible

2011-12-12 Thread Russell King - ARM Linux
On Fri, Dec 09, 2011 at 07:03:48PM +, Pawel Moll wrote: If twd_base is not set, try to map the TWD registers from arm,smp-twd Device Tree node (compatible value as used in Highbank's DT). Please do it the other way around - allow DT to override twd_base if the DT node is present. The

Re: [PATCH v5 5/9] ARM: versatile: Map local timers using Device Tree when possible

2011-12-12 Thread Pawel Moll
On Mon, 2011-12-12 at 14:04 +, Russell King - ARM Linux wrote: On Fri, Dec 09, 2011 at 07:03:48PM +, Pawel Moll wrote: If twd_base is not set, try to map the TWD registers from arm,smp-twd Device Tree node (compatible value as used in Highbank's DT). Please do it the other way

Re: [PATCH v5 5/9] ARM: versatile: Map local timers using Device Tree when possible

2011-12-10 Thread Sergei Shtylyov
Hello. On 09-12-2011 23:03, Pawel Moll wrote: If twd_base is not set, try to map the TWD registers from arm,smp-twd Device Tree node (compatible value as used in Highbank's DT). Signed-off-by: Pawel Mollpawel.m...@arm.com --- arch/arm/plat-versatile/localtimer.c | 12 1

[PATCH v5 5/9] ARM: versatile: Map local timers using Device Tree when possible

2011-12-09 Thread Pawel Moll
If twd_base is not set, try to map the TWD registers from arm,smp-twd Device Tree node (compatible value as used in Highbank's DT). Signed-off-by: Pawel Moll pawel.m...@arm.com --- arch/arm/plat-versatile/localtimer.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff