Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-02 Thread Mark Brown
On Mon, Oct 01, 2012 at 08:54:23PM +0530, ABRAHAM, KISHON VIJAY wrote: On Mon, Oct 1, 2012 at 5:39 PM, Mark Brown Why would that be helpful? Most platforms don't support DT at all, and I'm not sure how to put it correctly. All I'm trying to tell is mfd is a framework that exposes a set of

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-02 Thread Felipe Balbi
Hi, coming late to the discussion, so bear with me On Tue, Oct 02, 2012 at 01:38:56PM +0100, Mark Brown wrote: This means mfd framework does not have an API to create a device from dt data or so do I think since of_platform_populate() is used. Thats why I suggested the idea of extending

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-02 Thread Mark Brown
On Tue, Oct 02, 2012 at 03:43:22PM +0300, Felipe Balbi wrote: BTW, OTOH writing all children into the DT actually describes the HW, no ? And depending on the device I feel it'd be better to write that Well, it depends on the hardware. Some hardware has a bunch of nice, neat IPs which can

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-02 Thread Felipe Balbi
Hi, On Tue, Oct 02, 2012 at 01:58:20PM +0100, Mark Brown wrote: On Tue, Oct 02, 2012 at 03:43:22PM +0300, Felipe Balbi wrote: BTW, OTOH writing all children into the DT actually describes the HW, no ? And depending on the device I feel it'd be better to write that Well, it depends on

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-02 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Oct 2, 2012 at 6:08 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Mon, Oct 01, 2012 at 08:54:23PM +0530, ABRAHAM, KISHON VIJAY wrote: On Mon, Oct 1, 2012 at 5:39 PM, Mark Brown Why would that be helpful? Most platforms don't support DT at all, and I'm not sure

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-01 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Oct 1, 2012 at 4:31 PM, Sourav Poddar sourav.pod...@ti.com wrote: smsc ece1099 is a keyboard scan or gpio expansion device. The patch create keypad and gpio expander child for this multi function smsc driver. Tested on omap5430 evm with 3.6-rc6 custom kernel. Can we have this

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-01 Thread Mark Brown
On Mon, Oct 01, 2012 at 05:00:06PM +0530, ABRAHAM, KISHON VIJAY wrote: On Mon, Oct 1, 2012 at 4:31 PM, Sourav Poddar sourav.pod...@ti.com wrote: Delete irrelevant context from your replies, it makes it much easier to find new text. +static int smsc_i2c_remove(struct i2c_client *i2c) +{ +

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-01 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Oct 1, 2012 at 5:14 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Mon, Oct 01, 2012 at 05:00:06PM +0530, ABRAHAM, KISHON VIJAY wrote: On Mon, Oct 1, 2012 at 4:31 PM, Sourav Poddar sourav.pod...@ti.com wrote: Delete irrelevant context from your replies, it makes it

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-01 Thread Samuel Ortiz
Hi Sourav, On Mon, Oct 01, 2012 at 04:31:22PM +0530, Sourav Poddar wrote: smsc ece1099 is a keyboard scan or gpio expansion device. The patch create keypad and gpio expander child for this multi function smsc driver. Tested on omap5430 evm with 3.6-rc6 custom kernel. Cc: Samuel Ortiz

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-01 Thread Mark Brown
On Mon, Oct 01, 2012 at 05:23:15PM +0530, ABRAHAM, KISHON VIJAY wrote: On Mon, Oct 1, 2012 at 5:14 PM, Mark Brown No, this is not at all sensible - if there's an mfd_remove_devices() function we really ought to be able to use it to remove the children. If we can't do that we should fix the

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-01 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Oct 1, 2012 at 5:39 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Mon, Oct 01, 2012 at 05:23:15PM +0530, ABRAHAM, KISHON VIJAY wrote: On Mon, Oct 1, 2012 at 5:14 PM, Mark Brown No, this is not at all sensible - if there's an mfd_remove_devices() function we