Re: [RFC/PATCH 2/7] OMAP3: beagle: don't touch omap_device internals

2011-08-01 Thread Felipe Balbi
Hi, On Fri, Jul 29, 2011 at 06:07:17PM -0500, Menon, Nishanth wrote: On Fri, Jul 29, 2011 at 09:05, Felipe Balbi ba...@ti.com wrote: +} +EXPORT_SYMBOL(omap_hwmod_name_get_odev); maybe EXPORT_SYMBOL_GPL() ?? Not sure we want non-GPL code to access this ;-) Sure.. but is this the

Re: [RFC/PATCH 2/7] OMAP3: beagle: don't touch omap_device internals

2011-07-29 Thread Nishanth Menon
On 08:31-20110728, Menon, Nishanth wrote: On Thu, Jul 28, 2011 at 07:57, Cousson, Benoit b-cous...@ti.com wrote: [...] diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index 293fa6c..77d01a2 100644 --- a/arch/arm/mach-omap2/omap_hwmod.c +++

Re: [RFC/PATCH 2/7] OMAP3: beagle: don't touch omap_device internals

2011-07-29 Thread Felipe Balbi
hi, On Fri, Jul 29, 2011 at 08:49:34AM -0500, Nishanth Menon wrote: From f03490456e24f72ca5272303c95a6f0b212494d5 Mon Sep 17 00:00:00 2001 From: Nishanth Menon n...@ti.com Date: Wed, 27 Jul 2011 15:02:32 -0500 Subject: [PATCH 1/2] OMAP: PM: omap_device: add omap_hwmod_name_get_odev An API

Re: [RFC/PATCH 2/7] OMAP3: beagle: don't touch omap_device internals

2011-07-29 Thread Menon, Nishanth
On Fri, Jul 29, 2011 at 09:05, Felipe Balbi ba...@ti.com wrote: +} +EXPORT_SYMBOL(omap_hwmod_name_get_odev); maybe EXPORT_SYMBOL_GPL() ?? Not sure we want non-GPL code to access this ;-) Sure.. but is this the way we want to go? if yes, I can post the series in a formal way to the list.

Re: [RFC/PATCH 2/7] OMAP3: beagle: don't touch omap_device internals

2011-07-28 Thread Russell King - ARM Linux
On Thu, Jul 28, 2011 at 12:53:47AM -0500, Nishanth Menon wrote: +struct device *omap_hwmod_to_device(const char *oh_name) +{ + struct omap_hwmod *oh; + + if (!oh_name) { + WARN(1, %s: no hwmod name!\n, __func__); + return ERR_PTR(-EINVAL); + } + +

Re: [RFC/PATCH 2/7] OMAP3: beagle: don't touch omap_device internals

2011-07-28 Thread Felipe Balbi
Hi, On Thu, Jul 28, 2011 at 02:57:03PM +0200, Cousson, Benoit wrote: Hi Nishanth, On 7/28/2011 7:53 AM, Menon, Nishanth wrote: On 11:57-20110722, Felipe Balbi wrote: [...] /* Custom OPP enabled for all xM versions */ if (cpu_is_omap3630()) { - struct omap_hwmod *mh =

Re: [RFC/PATCH 2/7] OMAP3: beagle: don't touch omap_device internals

2011-07-28 Thread Jean Pihet
Hi, On Fri, Jul 22, 2011 at 10:57 AM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Jul 21, 2011 at 04:52:13PM -0700, Kevin Hilman wrote: Board code should not touch omap_device internals.  To get the MPU/IVA devices, use existing APIs: omap2_get_mpu_device(), omap2_get_iva_device().

Re: [RFC/PATCH 2/7] OMAP3: beagle: don't touch omap_device internals

2011-07-28 Thread Menon, Nishanth
On Thu, Jul 28, 2011 at 07:57, Cousson, Benoit b-cous...@ti.com wrote: [...] diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index 293fa6c..77d01a2 100644 --- a/arch/arm/mach-omap2/omap_hwmod.c +++ b/arch/arm/mach-omap2/omap_hwmod.c @@ -142,6 +142,7 @@  

[RFC/PATCH 2/7] OMAP3: beagle: don't touch omap_device internals

2011-07-22 Thread Kevin Hilman
Board code should not touch omap_device internals. To get the MPU/IVA devices, use existing APIs: omap2_get_mpu_device(), omap2_get_iva_device(). Signed-off-by: Kevin Hilman khil...@ti.com --- arch/arm/mach-omap2/board-omap3beagle.c | 23 ++- 1 files changed, 10