RE: [patch] qla2xxx: locking problem in qla2x00_init_rings()

2010-09-22 Thread Madhu Iyengar
: locking problem in qla2x00_init_rings() IRQs are already disabled here so we don't need to disable them again. But more importantly, the spin_lock_irqsave() overwrites flags and that breaks things when we want to re-enable the IRQs when we call spin_unlock_irqrestore(ha-hardware_lock, flags); Signed-off

[patch] qla2xxx: locking problem in qla2x00_init_rings()

2010-09-12 Thread Dan Carpenter
IRQs are already disabled here so we don't need to disable them again. But more importantly, the spin_lock_irqsave() overwrites flags and that breaks things when we want to re-enable the IRQs when we call spin_unlock_irqrestore(ha-hardware_lock, flags); Signed-off-by: Dan Carpenter