Re: [patch -next] spi: spi-xilinx: cleanup a check in xilinx_spi_txrx_bufs()

2013-06-10 Thread Mark Brown
On Sun, Jun 09, 2013 at 04:07:28PM +0300, Dan Carpenter wrote: '!' has higher precedence than comparisons so the original condition is equivalent to if (xspi-remaining_bytes == 0). This makes the static checkers complain. Applied, thanks. signature.asc Description: Digital signature

[patch -next] spi: spi-xilinx: cleanup a check in xilinx_spi_txrx_bufs()

2013-06-09 Thread Dan Carpenter
'!' has higher precedence than comparisons so the original condition is equivalent to if (xspi-remaining_bytes == 0). This makes the static checkers complain. xspi-remaining_bytes is signed and from looking at the code briefly, I think it might be able to go negative. I suspect that going