re: regulator: palma: add ramp delay support through regulator constraints

[Dan Carpenter]

Hello Laxman Dewangan,

The patch 28d1e8cd671a: "regulator: palma: add ramp delay support
through regulator constraints" from Apr 18, 2013, leads to the
following Smatch warning:
"drivers/regulator/palmas-regulator.c:843 palmas_regulators_probe()
         warn: was || intended here instead of &&?"

drivers/regulator/palmas-regulator.c
   842  
   843                  if ((id == PALMAS_REG_SMPS6) && (id == 
PALMAS_REG_SMPS8))

"id" can't be equal to both.

   844                          ramp_delay_support = true;
   845  
   846                  if (ramp_delay_support) {
   847                          addr = palmas_regs_info[id].tstep_addr;
   848                          ret = palmas_smps_read(pmic->palmas, addr, 
&reg);
   849                          if (ret < 0) {

regards,
dan carpenter

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss