Re: [PATCH v4 5/5] fsl-diu-fb: Support setting display mode using EDID

2010-12-16 Thread Timur Tabi
On Fri, Jul 23, 2010 at 9:00 AM, Anatolij Gustschin ag...@denx.de wrote: Adds support for encoding display mode information in the device tree using verbatim EDID block. If the EDID entry in the DIU node is present, the driver will build mode database using EDID data and allow setting the

Re: [PATCH v4 5/5] fsl-diu-fb: Support setting display mode using EDID

2010-12-16 Thread Grant Likely
On Thu, Dec 16, 2010 at 9:47 AM, Timur Tabi ti...@freescale.com wrote: On Fri, Jul 23, 2010 at 9:00 AM, Anatolij Gustschin ag...@denx.de wrote: Adds support for encoding display mode information in the device tree using verbatim EDID block. If the EDID entry in the DIU node is present, the

Re: [PATCH v4 5/5] fsl-diu-fb: Support setting display mode using EDID

2010-12-16 Thread Timur Tabi
Grant Likely wrote: This is for devices which don't have an i2c edid channel. So are we expecting board-specific code in U-Boot to add the data to the device tree? -- Timur Tabi Linux kernel developer at Freescale ___ devicetree-discuss mailing list

Re: [PATCH v4 5/5] fsl-diu-fb: Support setting display mode using EDID

2010-12-16 Thread Grant Likely
On Thu, Dec 16, 2010 at 9:55 AM, Timur Tabi ti...@freescale.com wrote: Grant Likely wrote: This is for devices which don't have an i2c edid channel. So are we expecting board-specific code in U-Boot to add the data to the device tree? No. It is a static property of the board/machine. It

[PATCH 1/3] of: platform: introduce of_probe_platform_driver()

2010-12-16 Thread Wolfram Sang
Introduce a function equivalent to platform_driver_probe() for of. This is needed to keep some SoC devices in the __init section. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/of/platform.c | 30 +++--- include/linux/of_platform.h |2 ++ 2

[PATCH 2/3] spi: mpc52xx_psc_spi: fix section mismatch warning

2010-12-16 Thread Wolfram Sang
Done by using of_probe_platform_driver() instead of of_register_platform_driver(). Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/spi/mpc52xx_psc_spi.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/mpc52xx_psc_spi.c

[PATCH 3/3] spi: mpc512x_psc_spi: move probe-routine to __init

2010-12-16 Thread Wolfram Sang
Since of_probe_platform_driver(), this SoC-device can be moved from __devinit to __init because it is not hotpluggable. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/spi/mpc512x_psc_spi.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 1/3] of: platform: introduce of_probe_platform_driver()

2010-12-16 Thread Grant Likely
On Thu, Dec 16, 2010 at 10:13 AM, Wolfram Sang w.s...@pengutronix.de wrote: Introduce a function equivalent to platform_driver_probe() for of. This is needed to keep some SoC devices in the __init section. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Hi Wolfram Nack for two reasons: 1-

Re: [PATCH 2/3] spi: mpc52xx_psc_spi: fix section mismatch warning

2010-12-16 Thread Grant Likely
On Thu, Dec 16, 2010 at 10:13 AM, Wolfram Sang w.s...@pengutronix.de wrote: Done by using of_probe_platform_driver() instead of of_register_platform_driver(). Signed-off-by: Wolfram Sang w.s...@pengutronix.de Move the probe hook to the __devinit section instead. g. ---  

Re: [PATCH 3/3] spi: mpc512x_psc_spi: move probe-routine to __init

2010-12-16 Thread Grant Likely
On Thu, Dec 16, 2010 at 10:13 AM, Wolfram Sang w.s...@pengutronix.de wrote: Since of_probe_platform_driver(), this SoC-device can be moved from __devinit to __init because it is not hotpluggable. Signed-off-by: Wolfram Sang w.s...@pengutronix.de I really wouldn't bother. You're counting

Re: [PATCH v4 5/5] fsl-diu-fb: Support setting display mode using EDID

2010-12-16 Thread Timur Tabi
Grant Likely wrote: No. It is a static property of the board/machine. It is expected it to be encoded into the board's .dts file. Ok, but that only makes sense if the monitor is hard-wired to the board itself. If a user can attach any monitor he wants, then the EDID data can't be known at

Re: [PATCH v4 5/5] fsl-diu-fb: Support setting display mode using EDID

2010-12-16 Thread Anatolij Gustschin
On Thu, 16 Dec 2010 10:47:53 -0600 Timur Tabi ti...@freescale.com wrote: On Fri, Jul 23, 2010 at 9:00 AM, Anatolij Gustschin ag...@denx.de wrote: Adds support for encoding display mode information in the device tree using verbatim EDID block. If the EDID entry in the DIU node is present,

Re: [PATCH v4 5/5] fsl-diu-fb: Support setting display mode using EDID

2010-12-16 Thread Grant Likely
On Thu, Dec 16, 2010 at 10:28 AM, Timur Tabi ti...@freescale.com wrote: Grant Likely wrote: No.  It is a static property of the board/machine.  It is expected it to be encoded into the board's .dts file. Ok, but that only makes sense if the monitor is hard-wired to the board itself.  If a