Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-08 Thread Jason
On Wed, Mar 07, 2012 at 09:13:04PM +, Arnd Bergmann wrote: Finally, something could be wrong with the interrupt controller. AFAICT, you register it through the device tree now, but it's also getting initialized through kirkwood_init_irq, so the numbers would all be wrong. Yes, I'm working

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-08 Thread Arnd Bergmann
On Thursday 08 March 2012, Jason wrote: On Wed, Mar 07, 2012 at 09:13:04PM +, Arnd Bergmann wrote: Finally, something could be wrong with the interrupt controller. AFAICT, you register it through the device tree now, but it's also getting initialized through kirkwood_init_irq, so the

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-08 Thread Thomas Gleixner
On Thu, 8 Mar 2012, Arnd Bergmann wrote: On Thursday 08 March 2012, Jason wrote: On Wed, Mar 07, 2012 at 09:13:04PM +, Arnd Bergmann wrote: Finally, something could be wrong with the interrupt controller. AFAICT, you register it through the device tree now, but it's also

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-08 Thread Jason
On Thu, Mar 08, 2012 at 08:27:11PM +0100, Thomas Gleixner wrote: On Thu, 8 Mar 2012, Arnd Bergmann wrote: On Thursday 08 March 2012, Jason wrote: On Wed, Mar 07, 2012 at 09:13:04PM +, Arnd Bergmann wrote: Finally, something could be wrong with the interrupt controller.

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-08 Thread Grant Likely
On Wed, Mar 07, 2012 at 09:13:04PM +, Arnd Bergmann wrote: On Wednesday 07 March 2012, Jason wrote: Grrr. Now I'm getting frustrated. I'm trying to boot without earlyprintk. Evidently, something is wrong with the above, because the device boots all the way up (blinky lights come on),

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-08 Thread Grant Likely
On Wed, Mar 07, 2012 at 02:27:23PM -0500, Jason wrote: On Wed, Mar 07, 2012 at 06:31:31PM +, Arnd Bergmann wrote: On Wednesday 07 March 2012, Jason Cooper wrote: + serial@f1012000 { + compatible = ns16550a; + reg = 0xf1012000 0xff; +

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-08 Thread Grant Likely
On Thu, Mar 08, 2012 at 02:47:25PM -0500, Jason wrote: On Thu, Mar 08, 2012 at 08:27:11PM +0100, Thomas Gleixner wrote: On Thu, 8 Mar 2012, Arnd Bergmann wrote: On Thursday 08 March 2012, Jason wrote: On Wed, Mar 07, 2012 at 09:13:04PM +, Arnd Bergmann wrote: Finally,

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-08 Thread Jason
On Thu, Mar 08, 2012 at 02:32:44PM -0700, Grant Likely wrote: On Thu, Mar 08, 2012 at 02:47:25PM -0500, Jason wrote: On Thu, Mar 08, 2012 at 08:27:11PM +0100, Thomas Gleixner wrote: On Thu, 8 Mar 2012, Arnd Bergmann wrote: On Thursday 08 March 2012, Jason wrote: On Wed,

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-08 Thread Jason
On Thu, Mar 08, 2012 at 02:31:39PM -0700, Grant Likely wrote: On Wed, Mar 07, 2012 at 02:27:23PM -0500, Jason wrote: On Wed, Mar 07, 2012 at 06:31:31PM +, Arnd Bergmann wrote: On Wednesday 07 March 2012, Jason Cooper wrote: + serial@f1012000 { + compatible =

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-08 Thread Rob Herring
On 03/08/2012 03:50 PM, Jason wrote: On Thu, Mar 08, 2012 at 02:32:44PM -0700, Grant Likely wrote: On Thu, Mar 08, 2012 at 02:47:25PM -0500, Jason wrote: On Thu, Mar 08, 2012 at 08:27:11PM +0100, Thomas Gleixner wrote: On Thu, 8 Mar 2012, Arnd Bergmann wrote: On Thursday 08 March 2012, Jason

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-08 Thread Arnd Bergmann
On Thursday 08 March 2012, Grant Likely wrote: My first guess was that clock-frequency is wrong, but it seems that this one actually is correct, at least it's the same thing that the platform code sets. You should never need to pass the virtual address to a device, most of all

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-08 Thread Arnd Bergmann
On Thursday 08 March 2012, Arnd Bergmann wrote: Since the orion irq chip is based on irqchip_generic, it would be perfect to have a generic irqchip binding to go along with kernel/irq/generic-chip.c. Not sure if anyone has thought about this before, but it looks like we can completely avoid

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-07 Thread Arnd Bergmann
On Wednesday 07 March 2012, Jason Cooper wrote: + serial@f1012000 { + compatible = ns16550a; + reg = 0xf1012000 0xff; + reg-shift = 2; + interrupts = 33; + clock-frequency = 2; + }; I just noticed

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-07 Thread Jason
On Wed, Mar 07, 2012 at 06:31:31PM +, Arnd Bergmann wrote: On Wednesday 07 March 2012, Jason Cooper wrote: + serial@f1012000 { + compatible = ns16550a; + reg = 0xf1012000 0xff; + reg-shift = 2; + interrupts = 33; +

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-07 Thread Jason
On Wed, Mar 07, 2012 at 06:31:31PM +, Arnd Bergmann wrote: On Wednesday 07 March 2012, Jason Cooper wrote: + serial@f1012000 { + compatible = ns16550a; + reg = 0xf1012000 0xff; + reg-shift = 2; + interrupts = 33; +

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-07 Thread Andrew Lunn
On Wed, Mar 07, 2012 at 02:27:23PM -0500, Jason wrote: On Wed, Mar 07, 2012 at 06:31:31PM +, Arnd Bergmann wrote: On Wednesday 07 March 2012, Jason Cooper wrote: + serial@f1012000 { + compatible = ns16550a; + reg = 0xf1012000 0xff; +

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-07 Thread Arnd Bergmann
On Wednesday 07 March 2012, Jason wrote: Grrr. Now I'm getting frustrated. I'm trying to boot without earlyprintk. Evidently, something is wrong with the above, because the device boots all the way up (blinky lights come on), but I get no messages after the usual Uncompressing Linux...

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-07 Thread Michael Walle
Am Mittwoch 07 März 2012, 20:27:23 schrieb Jason: On Wed, Mar 07, 2012 at 06:31:31PM +, Arnd Bergmann wrote: On Wednesday 07 March 2012, Jason Cooper wrote: + serial@f1012000 { + compatible = ns16550a; + reg = 0xf1012000 0xff; +

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-07 Thread Jason
On Wed, Mar 07, 2012 at 09:05:15PM +0100, Andrew Lunn wrote: On Wed, Mar 07, 2012 at 02:27:23PM -0500, Jason wrote: On Wed, Mar 07, 2012 at 06:31:31PM +, Arnd Bergmann wrote: On Wednesday 07 March 2012, Jason Cooper wrote: + serial@f1012000 { + compatible =

Re: [PATCH 06/14] ARM: kirkwood: convert uart0 to devicetree.

2012-03-07 Thread Jason
On Wed, Mar 07, 2012 at 09:13:04PM +, Arnd Bergmann wrote: On Wednesday 07 March 2012, Jason wrote: Grrr. Now I'm getting frustrated. I'm trying to boot without earlyprintk. Evidently, something is wrong with the above, because the device boots all the way up (blinky lights come on),