Re: [freenet-dev] New UPnP2 plugin

2015-12-27 Thread Matthew Toseland
On 26/12/15 16:03, Ian wrote: > Best practice is to use the logging system, using System.out.println() for > logging is almost universally regarded as bad practice, many static > analysis tools will automatically flag it as a problem. > > The example you gave in NodeCrypto is not best practice,

[freenet-dev] Logging policy

2015-12-27 Thread Matthew Toseland
On 26/12/15 13:05, Xiaoyu Huang wrote: > System.out.println() is for easier debugging as I can see the results > directly in wrapper.log. > > I see many examples in Fred code that uses both Logger and println(). An > example in NodeCrypto.java line around 136: > >

Re: [freenet-dev] New UPnP2 plugin

2015-12-27 Thread Ian
On Sun, Dec 27, 2015 at 1:20 PM, Matthew Toseland wrote: > On 26/12/15 16:03, Ian wrote: > > Best practice is to use the logging system, using System.out.println() > for > > logging is almost universally regarded as bad practice, many static > > analysis tools will

Re: [freenet-dev] New UPnP2 plugin

2015-12-27 Thread Matthew Toseland
On 27/12/15 19:55, Ian wrote: > On Sun, Dec 27, 2015 at 1:20 PM, Matthew Toseland > wrote: >> On 26/12/15 16:03, Ian wrote: >>> Best practice is to use the logging system, using System.out.println() >> for >>> logging is almost universally regarded as bad practice, many