Re: [freenet-dev] New UPnP2 plugin

Hi Xiaoyu, That's a huge improvement already, thanks again for all the work! I'm a bit short on time at the moment, I hope to get around fully reading and commenting on your code during the next week. All the best, Bert On Mon, Jan 18, 2016 at 4:50 PM, Huang Xiaoyu <007...@gmail.com> wrote: >

Re: [freenet-dev] New UPnP2 plugin

Hi Bert, I’ve updated my code at https://github.com/007pig/plugin-UPnP2 When you have time, can you please have another look at my code? Thanks a lot, Xiaoyu > On Jan 8, 2016, at 6:29 PM, Bert Massop wrote: > > Hi Xiaoyu, > > Thanks for all your work so far, I'm

Re: [freenet-dev] New UPnP2 plugin

You're manager of the new UPnP2 project on the bugtracker [1] now. It is available at the top right dropdown. You can use the "Manage" menu to do stuff such as edit the categories of the project, create versions for the roadmap, etc. It would be nice if you could: 1) Move existing UPnP issues

Re: [freenet-dev] New UPnP2 plugin

> It would be nice if you could: > 1) Move existing UPnP issues from the Freenet project to the UPnP2 project. Whoa! Please don't do that. The UPnP plugin is still in use and actively deployed. No need to break its bugtracker. ___ Devl mailing list

Re: [freenet-dev] New UPnP2 plugin

On Friday, January 08, 2016 11:29:24 AM Bert Massop wrote: > I'm not sure how to proceed with code review, as there obviously is no > related pull request and Github does not allow comments on trees as a > whole. If you want to commit on a specific line: - Use GitHub's "blame" feature to

Re: [freenet-dev] New UPnP2 plugin

Hi Xiaoyu, Thanks for all your work so far, I'm really happy to see a future without the current CyberGarage code! I'm not sure how to proceed with code review, as there obviously is no related pull request and Github does not allow comments on trees as a whole. From quickly looking through your

Re: [freenet-dev] New UPnP2 plugin

On 26/12/15 16:03, Ian wrote: > Best practice is to use the logging system, using System.out.println() for > logging is almost universally regarded as bad practice, many static > analysis tools will automatically flag it as a problem. > > The example you gave in NodeCrypto is not best practice,

Re: [freenet-dev] New UPnP2 plugin

On Sun, Dec 27, 2015 at 1:20 PM, Matthew Toseland wrote: > On 26/12/15 16:03, Ian wrote: > > Best practice is to use the logging system, using System.out.println() > for > > logging is almost universally regarded as bad practice, many static > > analysis tools will

Re: [freenet-dev] New UPnP2 plugin

On 27/12/15 19:55, Ian wrote: > On Sun, Dec 27, 2015 at 1:20 PM, Matthew Toseland > wrote: >> On 26/12/15 16:03, Ian wrote: >>> Best practice is to use the logging system, using System.out.println() >> for >>> logging is almost universally regarded as bad practice, many

Re: [freenet-dev] New UPnP2 plugin

Best practice is to use the logging system, using System.out.println() for logging is almost universally regarded as bad practice, many static analysis tools will automatically flag it as a problem. The example you gave in NodeCrypto is not best practice, that should probably just be something

Re: [freenet-dev] New UPnP2 plugin

Thanks a lot for providing the plugin! On Saturday, December 26, 2015 09:05:35 PM Xiaoyu Huang wrote: > System.out.println() is for easier debugging as I can see the results > directly in wrapper.log. The Logger logs (= freenet-latest.log) can be instantaneous as well, as long as you configure

Re: [freenet-dev] New UPnP2 plugin

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Maybe I shouldn't be surprised that people have focused on the relatively easy and relatively unimportant (in this stage of development) improvement of logging mechanism. Fred's System.out.println() usages are certainly not best practice, and at

Re: [freenet-dev] New UPnP2 plugin

System.out.println() is for easier debugging as I can see the results directly in wrapper.log. I see many examples in Fred code that uses both Logger and println(). An example in NodeCrypto.java line around 136: Logger.normal(this, "Could not use port: "+bindto+ ':'

[freenet-dev] New UPnP2 plugin

Hi All, As nextgens suggests, I write this plugin which is based on the newer and more stable UPnP lib named Cling (http://4thline.org/projects/cling/). Currently It only supports FredPluginIPDetector and FredPluginPortForward. I will add FredPluginBandwidthIndicator and Web UI support when I

Re: [freenet-dev] New UPnP2 plugin

This looks great! I notice a lot of System.out.println()s in the code, do we not have a logging mechanism in Fred available for use by plugins? On Fri, Dec 25, 2015 at 10:14 AM, Xiaoyu Huang <007...@gmail.com> wrote: > Hi All, > > As nextgens suggests, I write this plugin which is based on the