Re: [xwiki-devs] [VOTE] Change of behavior for the HTML macro when wiki=true

2009-05-06 Thread Pascal Voitot
Just a quick question, I have recompiled my server with your last commits and when I write this page: {{velocity}} {{html wiki=true}} #warning((% style='font-size: 130%;' %)blablabla) {{/html}} {{/velocity}} I get the following exception... Can you confirm it works on your test server? It would

Re: [xwiki-devs] [VOTE] Change of behavior for the HTML macro when wiki=true

2009-05-06 Thread Vincent Massol
On May 6, 2009, at 2:31 PM, Pascal Voitot wrote: Just a quick question, I have recompiled my server with your last commits and when I write this page: {{velocity}} {{html wiki=true}} #warning((% style='font-size: 130%;' %)blablabla) {{/html}} {{/velocity}} I get the following

Re: [xwiki-devs] [VOTE] Change of behavior for the HTML macro when wiki=true

2009-05-06 Thread Pascal Voitot
On Wed, May 6, 2009 at 2:45 PM, Vincent Massol vinc...@massol.net wrote: On May 6, 2009, at 2:31 PM, Pascal Voitot wrote: Just a quick question, I have recompiled my server with your last commits and when I write this page: {{velocity}} {{html wiki=true}} #warning((%

Re: [xwiki-devs] [VOTE] Change of behavior for the HTML macro when wiki=true

2009-05-05 Thread Vincent Massol
After trying to implement it I've found the following caveats: * if the user wants an html comment he needs to escape the -- * if the user wants a NL he'll need to enter br/ * if the user wants a paragraph he'll need to enter p.../p * And the most problematic one IMO: the user needs to be very

Re: [xwiki-devs] [VOTE] Change of behavior for the HTML macro when wiki=true

2009-05-05 Thread Pascal Voitot
no better idea... a very special case to remind in the syntax help to my mind... Pascal On Tue, May 5, 2009 at 9:40 AM, Vincent Massol vinc...@massol.net wrote: After trying to implement it I've found the following caveats: * if the user wants an html comment he needs to escape the -- * if

Re: [xwiki-devs] [VOTE] Change of behavior for the HTML macro when wiki=true

2009-05-05 Thread Vincent Massol
On May 5, 2009, at 4:16 PM, Pascal Voitot wrote: no better idea... a very special case to remind in the syntax help to my mind... Just committed the new behavior. Would be great if some users/devs could verify it works on their use cases. Thanks -Vincent Pascal On Tue, May 5, 2009 at

Re: [xwiki-devs] [VOTE] Change of behavior for the HTML macro when wiki=true

2009-05-05 Thread Pascal Voitot
I will try to compile it and deploy it on my website... To be quicker, what module have you modified? regards Pascal On Tue, May 5, 2009 at 4:58 PM, Vincent Massol vinc...@massol.net wrote: On May 5, 2009, at 4:16 PM, Pascal Voitot wrote: no better idea... a very special case to remind

Re: [xwiki-devs] [VOTE] Change of behavior for the HTML macro when wiki=true

2009-05-05 Thread Vincent Massol
On May 5, 2009, at 5:01 PM, Pascal Voitot wrote: I will try to compile it and deploy it on my website... To be quicker, what module have you modified? xwiki-xml xwiki-rendering-api xwiki-rendering-macro-html You can also wait for a snapshot build at http://maven.xwiki.org Thanks -Vincent

Re: [xwiki-devs] [VOTE] Change of behavior for the HTML macro when wiki=true

2009-05-05 Thread Pascal Voitot
On Tue, May 5, 2009 at 5:04 PM, Vincent Massol vinc...@massol.net wrote: On May 5, 2009, at 5:01 PM, Pascal Voitot wrote: I will try to compile it and deploy it on my website... To be quicker, what module have you modified? xwiki-xml xwiki-rendering-api xwiki-rendering-macro-html

Re: [xwiki-devs] [VOTE] Change of behavior for the HTML macro when wiki=true

2009-05-04 Thread Marius Dumitru Florea
+1 Vincent Massol wrote: Hi, After discussing with Thomas we've reached the conclusion that we should change the way the HTML macro handle its content when wiki=true. For ex take the following input: {{velocity}} ... {{html wiki=true}} form $xwiki.includeForm(XWiki.MyClassSheet)

Re: [xwiki-devs] [VOTE] Change of behavior for the HTML macro when wiki=true

2009-05-04 Thread Sergiu Dumitriu
Vincent Massol wrote: Hi, After discussing with Thomas we've reached the conclusion that we should change the way the HTML macro handle its content when wiki=true. For ex take the following input: {{velocity}} ... {{html wiki=true}} form $xwiki.includeForm(XWiki.MyClassSheet) br /

[xwiki-devs] [VOTE] Change of behavior for the HTML macro when wiki=true

2009-05-04 Thread Vincent Massol
Hi, After discussing with Thomas we've reached the conclusion that we should change the way the HTML macro handle its content when wiki=true. For ex take the following input: {{velocity}} ... {{html wiki=true}} form $xwiki.includeForm(XWiki.MyClassSheet) br / p input type=submit name=submit

Re: [xwiki-devs] [VOTE] Change of behavior for the HTML macro when wiki=true

2009-05-04 Thread Pascal Voitot
As using these kinds of things and even if I'm not committer, I'm +1 for the wiki rendering in depth for {{html}}. Also seems quite normal to escape special wiki chars when wiki=true... as far as everything is explained in the syntax help ;) On Mon, May 4, 2009 at 3:25 PM, Vincent Massol

Re: [xwiki-devs] [VOTE] Change of behavior for the HTML macro when wiki=true

2009-05-04 Thread Thomas Mortagne
+1 On Mon, May 4, 2009 at 15:25, Vincent Massol vinc...@massol.net wrote: Hi, After discussing with Thomas we've reached the conclusion that we should change the way the HTML macro handle its content when wiki=true. For ex take the following input: {{velocity}} ... {{html wiki=true}}

Re: [xwiki-devs] [VOTE] Change of behavior for the HTML macro when wiki=true

2009-05-04 Thread Vincent Massol
As an aside wiki=true, clean=false will not fail anymore if the html isn't valid xml. -Vincent On May 4, 2009, at 3:25 PM, Vincent Massol wrote: Hi, After discussing with Thomas we've reached the conclusion that we should change the way the HTML macro handle its content when