Hey guys,
I've just created a PR, please
review https://github.com/django/django/pull/13873
воскресенье, 10 января 2021 г. в 09:52:56 UTC+3, carlton...@gmail.com:
> I originally sent the ticket here to see if folks were keen.
> Given discussion here, I’ve adjusted to Accepted.
> Next step
I originally sent the ticket here to see if folks were keen.
Given discussion here, I’ve adjusted to Accepted.
Next step would be a PR.
Thanks all.
On Sat, 9 Jan 2021 at 10:21, Tom Carrick wrote:
> Hi Maxim,
>
> I think the best thing you can do is add a ticket on trac -
>
Hi Maxim,
I think the best thing you can do is add a ticket on trac -
https://code.djangoproject.com/ and make a PR on GitHub if it's accepted. I
think it's hard - at least for me - to test something from a gist. Then you
will get some reviews and more feedback.
Cheers,
Tom
On Fri, 4 Dec 2020
Hey guys,
I've updated my prototype. What's changed:
-- moved the JS and CSS to nav_sidebar.js and nav_sidebar.css respectively
-- slight changes in styling
-- added ESC key support
I've updated my gist
https://gist.github.com/MilovanovM/84ffbbec02391c1ba1771a3a6aee5797
My changes are:
>
> I'm not sure that the nav_sidebar.html is the best place for the JS
> snippet. Probably, it should be placed in the main JS. When DOM is ready it
> can be initialized there.
Indeed, we can't use inline JS in the admin since that doesn't work with a
strict CSP.
On Fri, 4 Dec 2020 at 08:42,
Hey guys,
I'm not sure that the nav_sidebar.html is the best place for the JS
snippet. Probably, it should be placed in the main JS. When DOM is ready it
can be initialized there.
About UX. Agree the the "Clear" feature would be useful. It can be an "x"
icon, or a shortkey (ESC?), or both.
I think this would be really helpful. Looking at the code in the gist, that
looks about right. It's not too complicated and the basic
toLowerCase()/indexOf() method of search should hopefully be enough (it's
what I would do if I were implementing this!). I'd suggest adding some sort
of clear
I haven't looked at the gist, but I think in principle it's a good idea.
ctrl+f isn't ideal.
I think we need to be careful that the UX is good, if we go with this.
Tom
On Thu, 19 Nov 2020 at 15:16, Maxim Milovanov wrote:
> Yeah, that's why I came up with that idea. There are two projects, 44
Yeah, that's why I came up with that idea. There are two projects, 44
models on one, 57 models on another. It's very hard to navigate
четверг, 19 ноября 2020 г. в 16:50:37 UTC+3, yasie...@gmail.com:
> I found this feature very helpful. I'm maintaining two sites with more
> than 20 models
I found this feature very helpful. I'm maintaining two sites with more than
20 models registered in the admin and some time is annoying when I try to
find the one I'm looking for
El miércoles, 18 de noviembre de 2020 a la(s) 15:13:02 UTC-5, Maxim
Milovanov escribió:
> Hey guys,
>
> I've
10 matches
Mail list logo