OK, reopened and accepted.
Thanks for bringing it to the list Shai!
C.
--
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to
On Wed, 18 Mar 2020 10:34:30 -0700 (PDT)
charettes wrote:
> I think deleted_selected is *special* since it's the only default
> action provided.
>
I agree, but...
> I guess we could document that a method name string reference should
> be passed to AdminSite.add_action if it's meant to be
I think deleted_selected is *special* since it's the only default action
provided.
I guess we could document that a method name string reference should be
passed to AdminSite.add_action if it's meant to be overridden.
Simon
Le mercredi 18 mars 2020 13:04:35 UTC-4, Carlton Gibson a écrit :
>
>
OK, thanks both. Seems reasonable. Let me have a look at it in the morning.
One question is whether we handle this for just delete_selected or any
action which an AdminSite declares.
The example from #30311 was `expect_inquisition` (Nice) Do we want to
handle that too? 樂
Cheers.
C.
On
(sorry about the previous empty mail, UI glitch)
On Wed, 18 Mar 2020 09:29:17 -0700 (PDT)
charettes wrote:
> Just to make the above clear, here's what I had in mind
>
> https://gist.github.com/charettes/a0cb94242ac9c198625b23f4f55fab45
>
Yes, that would do what I want and seems better than
On Wed, 18 Mar 2020 09:29:17 -0700 (PDT)
charettes wrote:
> Just to make the above clear, here's what I had in mind
>
> https://gist.github.com/charettes/a0cb94242ac9c198625b23f4f55fab45
>
> Le mercredi 18 mars 2020 12:20:54 UTC-4, charettes a écrit :
> >
> > Given the common need to override
Hi Carlton,
On Wed, 18 Mar 2020 17:11:49 +0100
Carlton Gibson wrote:
> I triaged that, and was involved in the change in #29917 that led to
> your issue.
>
> https://code.djangoproject.com/ticket/29917
> https://groups.google.com/d/topic/django-developers/-OWoYL_zryM/discussion
>
Yes, I've
Just to make the above clear, here's what I had in mind
https://gist.github.com/charettes/a0cb94242ac9c198625b23f4f55fab45
Le mercredi 18 mars 2020 12:20:54 UTC-4, charettes a écrit :
>
> Given the common need to override delete_selected I wonder if we could
> define it as ModelAdmin method and
Hi Shai.
I triaged that, and was involved in the change in #29917 that led to your
issue.
https://code.djangoproject.com/ticket/29917
The proposal to change it was made on the list here:
https://groups.google.com/d/topic/django-developers/-OWoYL_zryM/discussion
I’ll have another review of
