Sync and Async versions of the same function: guidelines for contributors

2023-08-05 Thread Olivier Tabone
django's code base ? Is that a best practice ? 2- what do you think about code duplication of async function ? (please point me to existing threads if the discussion already occurred) What is Ok / What is not ok ? Is there some cleanup to be done ? Cheers, - Olivier Tabone -- You re

Re: Sync and Async versions of the same function: guidelines for contributors

2023-08-07 Thread Olivier Tabone
Hi Jon, Thank you for your input. Le samedi 5 août 2023 à 19:43:57 UTC+2, Jon Janzen a écrit : There are a few key things missing from core django before that's possible. Some of which are laid out in that forum thread I linked above, others are listed directly in the DEP like the ORM being

Re: Sync and Async versions of the same function: guidelines for contributors

2023-08-07 Thread Olivier Tabone
Le lundi 7 août 2023 à 14:43:26 UTC+2, Lufafa Joshua a écrit : Hi there, Just a quick assumption, code duplication could be the reason why the follow parameter and the _handle_redirects method was not implemented on the AsyncClient as per the ticket #34757, if my assumption is wrong, no