[PATCH] drm/i915/dp: Add dpcd link_rate quirk for Apple 15" MBP 2017

2020-02-28 Thread Mario Kleiner
This fixes a problem found on the MacBookPro 2017 Retina panel. The panel reports 10 bpc color depth in its EDID, and the firmware chooses link settings at boot which support enough bandwidth for 10 bpc (324000 kbit/sec = multiplier 0xc), but the DP_MAX_LINK_RATE dpcd register only reports 2.7 Gbp

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-02-28 Thread Manasi Navare
On Fri, Feb 28, 2020 at 01:18:45PM -0800, Manasi Navare wrote: > On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote: > > On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: > > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > > the EDID's detailed descri

Re: [PATCH 37/51] drm/rockchip: Drop explicit drm_mode_config_cleanup call

2020-02-28 Thread kbuild test robot
Hi Daniel, I love your patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on next-20200228] [cannot apply to drm-intel/for-linux-next linus/master pinchartl-media/drm/du/next v5.6-rc3] [if your patch is applied to the wrong git tree, please drop

Reverting https://patchwork.freedesktop.org/patch/336850/

2020-02-28 Thread abhinavk
Hi Thierry For DP drivers using MSM chipsets, we are using drm_dp_link_configure, drm_dp_link_power_up and drm_dp_link_power_down functions. Here is the patch for reference: https://patchwork.freedesktop.org/patch/343346/ We will be posting a newer version of the driver soon. For that, we p

[PATCH] drm/nouveau/core/memory: remove redundant assignments to variable ret

2020-02-28 Thread Colin King
From: Colin Ian King The variable ret is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/gpu/drm/nouveau/nvkm/cor

Re: [PATCH] drm: prevent a harmless integer overflow in drm_legacy_sg_alloc()

2020-02-28 Thread Daniel Vetter
On Fri, Feb 28, 2020 at 12:23:21PM +0300, Dan Carpenter wrote: > There is an integer overflow when we round up to PAGE_SIZE, but it's > harmless because we never re-use "request->size" for anything meaningful. > > Signed-off-by: Dan Carpenter > --- > This code predates git. Also not compiled wit

Re: [PATCH v2 1/2] drm/client: Dual licence the file in GPL-2 and MIT

2020-02-28 Thread Daniel Vetter
On Fri, Feb 28, 2020 at 01:28:57PM +0100, Noralf Trønnes wrote: > > > Den 25.02.2020 18.03, skrev Daniel Vetter: > > On Tue, Feb 25, 2020 at 09:18:10AM +0100, Emmanuel Vadot wrote: > >> On Mon, 24 Feb 2020 11:40:38 + > >> Chris Wilson wrote: > >> > >>> Quoting Jani Nikula (2020-02-15 18:33:0

Re: [PATCH 37/51] drm/rockchip: Drop explicit drm_mode_config_cleanup call

2020-02-28 Thread Daniel Vetter
ld test ERROR on next-20200228] > [cannot apply to drm-intel/for-linux-next linus/master > pinchartl-media/drm/du/next v5.6-rc3] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' opti

Re: [PATCH 03/51] drm: add managed resources tied to drm_device

2020-02-28 Thread Daniel Vetter
On Fri, Feb 28, 2020 at 11:45 PM Sam Ravnborg wrote: > > Hi Daniel. > > Some nitpicks / bikeshedding below. > > Sam > > On Thu, Feb 27, 2020 at 07:14:34PM +0100, Daniel Vetter wrote: > > We have lots of these. And the cleanup code tends to be of dubious > > quality. The biggest wrong patte

Re: [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-02-28 Thread Daniel Vetter
On Fri, Feb 28, 2020 at 9:26 PM Sam Ravnborg wrote: > > Hi Daniel. > > Some bikeshedding in the following. > with or with addressing (IMHO valid points) consider the patch: > > Reviewed-by: Sam Ravnborg > > Sam > > On Thu, Feb 27, 2020 at 07:14:57PM +0100, Daniel Vetter wrote: > > drm_mod

Re: [PATCH v4 13/14] drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message

2020-02-28 Thread Lyude Paul
Hey - I've got a good bit of stuff on my plate right now since I just got back from PTO and am going through my backlog of stuff, but I'll try to get this reviewed first chance I get On Tue, 2020-02-18 at 17:02 -0500, Sean Paul wrote: > From: Sean Paul > > Used to query whether an MST stream is

Re: [PATCH 03/51] drm: add managed resources tied to drm_device

2020-02-28 Thread Sam Ravnborg
Hi Daniel. Some nitpicks / bikeshedding below. Sam On Thu, Feb 27, 2020 at 07:14:34PM +0100, Daniel Vetter wrote: > We have lots of these. And the cleanup code tends to be of dubious > quality. The biggest wrong pattern is that developers use devm_, which > ties the release action to the

[Bug 196247] AMD FirePro W5130M - Radeon driver - ring 0 stalled

2020-02-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=196247 Davidian1024 (david.brino...@gmail.com) changed: What|Removed |Added CC||david.brino...@g

Re: [PATCH][next] drm/amd/display: fix indentation issue on a hunk of code

2020-02-28 Thread Alex Deucher
On Fri, Feb 28, 2020 at 8:16 AM Colin King wrote: > > From: Colin Ian King > > There are multiple statements that are indented incorrectly. Add > in the missing tabs. > > Signed-off-by: Colin Ian King Applied. Thanks! Alex > --- > .../gpu/drm/amd/display/dc/calcs/dce_calcs.c | 46 +

Re: [PATCH][next] drm/amdkfd: fix indentation issue

2020-02-28 Thread Alex Deucher
Applied. Thanks! On Fri, Feb 28, 2020 at 8:08 AM Colin King wrote: > > From: Colin Ian King > > There is a statement that is indented with spaces instead of a tab. > Replace spaces with a tab. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 2 +- > 1 file

Re: [RFC v2 5/8] pinctrl: ingenic: add hdmi-ddc pin control group

2020-02-28 Thread Linus Walleij
On Fri, Feb 28, 2020 at 7:19 PM H. Nikolaus Schaller wrote: > From: Paul Boddie > > Signed-off-by: Paul Boddie > Signed-off-by: H. Nikolaus Schaller This looks good, can I just apply this to the pinctrl tree? Yours, Linus Walleij ___ dri-devel mail

[Bug 206393] amdgpu: garbled screen after resume

2020-02-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206393 --- Comment #10 from Alex Deucher (alexdeuc...@gmail.com) --- (In reply to Bjoern Franke from comment #9) > Issue seems to be fixed in 5.6.0-rc3, so it will be hopefully backported > into the 5.5 branch. Can you identify what patch fixed it for y

Re: [PATCH 2/2] drm/amd/display: Allow current eDP link settings to override verified ones.

2020-02-28 Thread Mario Kleiner
On Thu, Feb 27, 2020 at 8:11 PM Mario Kleiner wrote: > > Hi Harry > > Ok, back from various other emergencies and deadlines, sorry for the > late reply. I also fixed my e-mail address - it was mistyped, causing > all these delivery failures :/ > > On Thu, Jan 9, 2020 at 10:26 PM Harry Wentland wr

[PATCH] drm/amd/display: Add link_rate quirk for Apple 15" MBP 2017

2020-02-28 Thread Mario Kleiner
This fixes a problem found on the MacBookPro 2017 Retina panel: The panel reports 10 bpc color depth in its EDID, and the firmware chooses link settings at boot which support enough bandwidth for 10 bpc (324000 kbit/sec aka LINK_RATE_RBR2 aka 0xc), but the DP_MAX_LINK_RATE dpcd register only repor

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Daniel Vetter
On Fri, Feb 28, 2020 at 9:31 PM Dave Airlie wrote: > > On Sat, 29 Feb 2020 at 05:34, Eric Anholt wrote: > > > > On Fri, Feb 28, 2020 at 12:48 AM Dave Airlie wrote: > > > > > > On Fri, 28 Feb 2020 at 18:18, Daniel Stone wrote: > > > > > > > > On Fri, 28 Feb 2020 at 03:38, Dave Airlie wrote: > >

Re: gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Matt Turner
On Fri, Feb 28, 2020 at 12:00 AM Daniel Stone wrote: > > Hi Matt, > > On Thu, 27 Feb 2020 at 23:45, Matt Turner wrote: > > We're paying 75K USD for the bandwidth to transfer data from the > > GitLab cloud instance. i.e., for viewing the https site, for > > cloning/updating git repos, and for down

Re: [PATCH 37/51] drm/rockchip: Drop explicit drm_mode_config_cleanup call

2020-02-28 Thread kbuild test robot
Hi Daniel, I love your patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on next-20200228] [cannot apply to drm-intel/for-linux-next linus/master pinchartl-media/drm/du/next v5.6-rc3] [if your patch is applied to the wrong git tree, please drop

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-02-28 Thread Manasi Navare
On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote: > On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > the EDID's detailed descritors to obtain the adaptive sync monitor range. > > Store this info as

Re: [PATCH 2/2] [RFC] drm/virtgpu: modify uapi with stride/layer_stride fix

2020-02-28 Thread Chia-I Wu
On Wed, Oct 2, 2019 at 5:18 PM Gurchetan Singh wrote: > > On Wed, Oct 2, 2019 at 1:49 AM Gerd Hoffmann wrote: > > > > On Tue, Oct 01, 2019 at 06:49:35PM -0700, Gurchetan Singh wrote: > > > This doesn't really break userspace, since it always passes down > > > 0 for stride/layer_stride currently.

Re: [PATCH 49/51] drm/udl: Drop explicit drm_mode_config_cleanup call

2020-02-28 Thread Sam Ravnborg
On Thu, Feb 27, 2020 at 07:15:20PM +0100, Daniel Vetter wrote: > It's right above the drm_dev_put(). > > This allows us to delete a bit of onion unwinding in > udl_modeset_init(). > > This is made possible by a preceeding patch which added a drmm_ > cleanup action to drm_mode_config_init(), hence

Re: [PATCH 48/51] drm/mipi-dbi: Drop explicit drm_mode_config_cleanup call

2020-02-28 Thread Sam Ravnborg
On Thu, Feb 27, 2020 at 07:15:19PM +0100, Daniel Vetter wrote: > Allows us to drop the drm_driver.release callback from all > drivers, and remove the mipi_dbi_release() function. > > This is made possible by a preceeding patch which added a drmm_ > cleanup action to drm_mode_config_init(), hence a

Re: [PATCH 47/51] drm/mipi-dbi: Move drm_mode_config_init into mipi library

2020-02-28 Thread Sam Ravnborg
On Thu, Feb 27, 2020 at 07:15:18PM +0100, Daniel Vetter wrote: > 7/7 drivers agree that's the right choice, let's do this. > > This avoids duplicating the same old error checking code over all 7 > drivers, which is the motivation here. > > Reviewed-by: Noralf Trønnes > Tested-by: Noralf Trønnes

Re: [PATCH 29/51] drm/cirrus: Drop explicit drm_mode_config_cleanup call

2020-02-28 Thread Sam Ravnborg
On Thu, Feb 27, 2020 at 07:15:00PM +0100, Daniel Vetter wrote: > We can even delete the drm_driver.release hook now! > > This is made possible by a preceeding patch which added a drmm_ > cleanup action to drm_mode_config_init(), hence all we need to do to > ensure that drm_mode_config_cleanup() is

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Dave Airlie
On Sat, 29 Feb 2020 at 05:34, Eric Anholt wrote: > > On Fri, Feb 28, 2020 at 12:48 AM Dave Airlie wrote: > > > > On Fri, 28 Feb 2020 at 18:18, Daniel Stone wrote: > > > > > > On Fri, 28 Feb 2020 at 03:38, Dave Airlie wrote: > > > > b) we probably need to take a large step back here. > > > > > >

Re: [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-02-28 Thread Sam Ravnborg
Hi Daniel. Some bikeshedding in the following. with or with addressing (IMHO valid points) consider the patch: Reviewed-by: Sam Ravnborg Sam On Thu, Feb 27, 2020 at 07:14:57PM +0100, Daniel Vetter wrote: > drm_mode_config_cleanup is idempotent, so no harm in calling this > twice. This

Re: [PATCHv2] drm/omap: Fix drm_handle_vblank() handling for command mode panels

2020-02-28 Thread Laurent Pinchart
Hi Tony, Thank you for the patch. On Fri, Feb 28, 2020 at 09:16:57AM -0800, Tony Lindgren wrote: > When trying to run weston on droid4 with the updated sgx blobs, the LCD > is just black and not updating. Weston also displays the following on > startup: > > Warning: computed repaint delay is ins

Re: [PATCH v4 0/4] drm: Provide a simple encoder

2020-02-28 Thread Sam Ravnborg
Hi Thomas. On Fri, Feb 28, 2020 at 09:18:24AM +0100, Thomas Zimmermann wrote: > Many DRM drivers implement an encoder with an empty implementation. This > patchset adds drm_simple_encoder_init(), which drivers can use instead. > Except for the destroy callback, the simple encoder's implementation

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Eric Anholt
On Fri, Feb 28, 2020 at 12:48 AM Dave Airlie wrote: > > On Fri, 28 Feb 2020 at 18:18, Daniel Stone wrote: > > > > On Fri, 28 Feb 2020 at 03:38, Dave Airlie wrote: > > > b) we probably need to take a large step back here. > > > > > > Look at this from a sponsor POV, why would I give X.org/fd.o >

Re: [RFC v2 1/8] dt-bindings: display: add ingenic-jz4780-lcd DT Schema

2020-02-28 Thread Sam Ravnborg
Hi Nikolaus. On Fri, Feb 28, 2020 at 07:19:26PM +0100, H. Nikolaus Schaller wrote: > From: Sam Ravnborg > > Add DT bindings for the LCD controller on the jz4780 SoC > Based on .txt binding from Zubair Lutfullah Kakakhel > > Signed-off-by: Sam Ravnborg > Cc: Zubair Lutfullah Kakakhel > Cc: H.

[Bug 206393] amdgpu: garbled screen after resume

2020-02-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206393 --- Comment #9 from Bjoern Franke (b...@nord-west.org) --- Issue seems to be fixed in 5.6.0-rc3, so it will be hopefully backported into the 5.5 branch. -- You are receiving this mail because: You are watching the assignee of the bug. __

Re: [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Kristian Høgsberg
On Thu, Feb 27, 2020 at 7:38 PM Dave Airlie wrote: > > On Fri, 28 Feb 2020 at 07:27, Daniel Vetter wrote: > > > > Hi all, > > > > You might have read the short take in the X.org board meeting minutes > > already, here's the long version. > > > > The good news: gitlab.fd.o has become very popular

Re: [PATCH 50/51] drm/udl: drop drm_driver.release hook

2020-02-28 Thread Daniel Vetter
On Fri, Feb 28, 2020 at 12:46 PM Thomas Zimmermann wrote: > > Hi > > Am 28.02.20 um 09:40 schrieb Daniel Vetter: > > On Fri, Feb 28, 2020 at 8:44 AM Thomas Zimmermann > > wrote: > >> > >> Hi Daniel > >> > >> Am 27.02.20 um 19:15 schrieb Daniel Vetter: > >>> There's only two functions called from

[Bug 206705] New: ida_free called for id=32782 which is not allocated.

2020-02-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206705 Bug ID: 206705 Summary: ida_free called for id=32782 which is not allocated. Product: Drivers Version: 2.5 Kernel Version: 5.5.4 Hardware: All OS: Linux Tree:

Re: [Intel-gfx] [Mesa-dev] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Rob Clark
On Fri, Feb 28, 2020 at 3:43 AM Michel Dänzer wrote: > > On 2020-02-28 10:28 a.m., Erik Faye-Lund wrote: > > > > We could also do stuff like reducing the amount of tests we run on each > > commit, and punt some testing to a per-weekend test-run or someting > > like that. We don't *need* to know ab

Re: [PATCH][V2] backlight: sky81452: insure while loop does not allow negative array indexing

2020-02-28 Thread Daniel Thompson
On Thu, Feb 27, 2020 at 03:10:43PM +, Colin Ian King wrote: > On 27/02/2020 11:46, Daniel Thompson wrote: > > On Wed, Feb 26, 2020 at 07:58:26PM +, Colin King wrote: > >> From: Colin Ian King > >> > >> In the unlikely event that num_entry is zero, the while loop > >> pre-decrements num_ent

[PATCH v2 2/2] drm/amd/display: dc_link: code clean up on detect_dp function

2020-02-28 Thread Melissa Wen
Removes codestyle issues on detect_dp function as suggested by checkpatch.pl. CHECK: Lines should not end with a '(' WARNING: Missing a blank line after declarations WARNING: line over 80 characters CHECK: Alignment should match open parenthesis Signed-off-by: Melissa Wen --- drivers/gpu/drm/am

[PATCH v2 1/2] drm/amd/display: dc_link: code clean up on enable_link_dp function

2020-02-28 Thread Melissa Wen
Coding style clean up on enable_link_dp function as suggested by checkpatch.pl: CHECK: Lines should not end with a '(' WARNING: line over 80 characters WARNING: suspect code indent for conditional statements (8, 24) CHECK: braces {} should be used on all arms of this statement ERROR: else should f

[PATCH v2 0/2] drm/amd/display: dc_link: cleaning up some code style issues

2020-02-28 Thread Melissa Wen
This patchset solves some coding style issues on dc_link for readability and cleaning up warnings. Change suggested by checkpatch.pl. Changes in v2: - Apply patches to the right amdgpu repository. - Remove unnecessary {} added in the previous version. Melissa Wen (2): drm/amd/display: dc_link:

Re: [PATCH resend 2/2] drm/i915/dp: Use BDB_GENERAL_FEATURES VBT block info for builtin panel-orientation

2020-02-28 Thread Ville Syrjälä
On Fri, Feb 28, 2020 at 12:41:10PM +0100, Hans de Goede wrote: > Some devices with a builtin panel have the panel mounted upside down, > this is indicated by the rotate_180 bit in the BDB_GENERAL_FEATURES VBT > block. > > We store this info in dev_priv->vbt.orientation, use this to set the > conne

[PATCH][next] drm/amd/display: fix indentation issue on a hunk of code

2020-02-28 Thread Colin King
From: Colin Ian King There are multiple statements that are indented incorrectly. Add in the missing tabs. Signed-off-by: Colin Ian King --- .../gpu/drm/amd/display/dc/calcs/dce_calcs.c | 46 +-- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/a

Re: [PATCH v4 0/9] Huge page-table entries for TTM

2020-02-28 Thread VMware
Andrew, Michal I'm wondering what's the best way here to get the patches touching mm reviewed and accepted? While drm people and VMware internal people have looked at them, I think the huge_fault() fallback splitting and the introduction of vma_is_special_huge() needs looking at more thoroughl

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Lionel Landwerlin
On 28/02/2020 13:46, Michel Dänzer wrote: On 2020-02-28 12:02 p.m., Erik Faye-Lund wrote: On Fri, 2020-02-28 at 10:43 +, Daniel Stone wrote: On Fri, 28 Feb 2020 at 10:06, Erik Faye-Lund wrote: On Fri, 2020-02-28 at 11:40 +0200, Lionel Landwerlin wrote: Yeah, changes on vulkan drivers or

[PATCH][next] drm/amdkfd: fix indentation issue

2020-02-28 Thread Colin King
From: Colin Ian King There is a statement that is indented with spaces instead of a tab. Replace spaces with a tab. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_top

Re: [PATCH v2 1/2] drm/client: Dual licence the file in GPL-2 and MIT

2020-02-28 Thread Noralf Trønnes
Den 25.02.2020 18.03, skrev Daniel Vetter: > On Tue, Feb 25, 2020 at 09:18:10AM +0100, Emmanuel Vadot wrote: >> On Mon, 24 Feb 2020 11:40:38 + >> Chris Wilson wrote: >> >>> Quoting Jani Nikula (2020-02-15 18:33:09) On Sat, 15 Feb 2020, Emmanuel Vadot wrote: > From: Emmanuel Vadot

Re: [PATCH] drm/dp_mst: Check crc4 value while building sideband message

2020-02-28 Thread Benjamin Gaignard
Le mar. 4 févr. 2020 à 20:00, Lyude Paul a écrit : > > Reviewed-by: Lyude Paul > Applied on drm-misc-next Thanks, Benjamin > On Mon, 2020-02-03 at 13:16 +0100, Benjamin Gaignard wrote: > > Check that computed crc value is matching the one encoded in the message. > > > > Signed-off-by: Benjamin

Re: [PATCH v6] drm/dp_mst: Fix W=1 warnings

2020-02-28 Thread Benjamin Gaignard
Le mer. 5 févr. 2020 à 09:53, Benjamin Gaignard a écrit : > > Fix the warnings that show up with W=1. > They are all about unused but set variables. > If functions returns are not used anymore make them void. > > Signed-off-by: Benjamin Gaignard > Reviewed-by: Lyude Paul Applied on drm-misc-nex

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Michel Dänzer
On 2020-02-28 12:02 p.m., Erik Faye-Lund wrote: > On Fri, 2020-02-28 at 10:43 +, Daniel Stone wrote: >> On Fri, 28 Feb 2020 at 10:06, Erik Faye-Lund >> wrote: >>> On Fri, 2020-02-28 at 11:40 +0200, Lionel Landwerlin wrote: Yeah, changes on vulkan drivers or backend compilers should be >>>

Re: [PATCH 50/51] drm/udl: drop drm_driver.release hook

2020-02-28 Thread Thomas Zimmermann
Hi Am 28.02.20 um 09:40 schrieb Daniel Vetter: > On Fri, Feb 28, 2020 at 8:44 AM Thomas Zimmermann wrote: >> >> Hi Daniel >> >> Am 27.02.20 um 19:15 schrieb Daniel Vetter: >>> There's only two functions called from that: >>> drm_kms_helper_poll_fini() and udl_free_urb_list(). Both of these are >>

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Michel Dänzer
On 2020-02-28 10:28 a.m., Erik Faye-Lund wrote: > > We could also do stuff like reducing the amount of tests we run on each > commit, and punt some testing to a per-weekend test-run or someting > like that. We don't *need* to know about every problem up front, just > the stuff that's about to be r

Re: [PATCH 2/2] drm/vmwgfx: Remove a few unused functions

2020-02-28 Thread Emil Velikov
Hi Sebastian, On Mon, 24 Feb 2020 at 16:55, Sebastian Andrzej Siewior wrote: > > I noticed that there is a prototype for vmw_fifo_ping_host_locked() but > no function. Then I looked further and noticed more functions which are > not used anymore or functions protoypes which remained after the > f

[PATCH resend 2/2] drm/i915/dp: Use BDB_GENERAL_FEATURES VBT block info for builtin panel-orientation

2020-02-28 Thread Hans de Goede
Some devices with a builtin panel have the panel mounted upside down, this is indicated by the rotate_180 bit in the BDB_GENERAL_FEATURES VBT block. We store this info in dev_priv->vbt.orientation, use this to set the connector's orientation property so that fbcon and userspace will show the image

[PATCH resend 0/2] drm/i915: Some upside-down panel handling fixes

2020-02-28 Thread Hans de Goede
Hi All, This is a resend of 2 patches which I submitted a while ago, rebased on top of the latest dinq to fix some conflicts. The first patch has already been reviewed. There were some questions about the second patch, which I have answered, see: https://patchwork.freedesktop.org/patch/345305/?s

[PATCH resend 1/2] drm/i915/dsi: Remove readback of panel orientation on BYT / CHT

2020-02-28 Thread Hans de Goede
Commit 82daca297506 ("drm/i915: Add "panel orientation" property to the panel connector, v6.") uses hardware state readback to determine if the GOP is rotating the image by 180 degrees to compensate for upside-down mounted panels. When I wrote that commit I tried to find the VBT bits the GOP used

Re: [PATCH] drm/shmem: drop pgprot_decrypted()

2020-02-28 Thread VMware
On 2/28/20 11:47 AM, Gerd Hoffmann wrote: Was added by commit 95cf9264d5f3 ("x86, drm, fbdev: Do not specify encrypted memory for video mappings"), then it was kept through various changes. While vram actually needs decrypted mappings this is not correct for shmem gem objects which live in main

Re: [PATCH v2] drm: panfrost: Silence warnings during deferred probe

2020-02-28 Thread Daniel Stone
On Fri, 28 Feb 2020 at 09:40, Marek Szyprowski wrote: > Signed-off-by: Marek Szyprowski Reviewed-by: Daniel Stone ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Daniel Stone
Hi Jan, On Fri, 28 Feb 2020 at 10:09, Jan Engelhardt wrote: > On Friday 2020-02-28 08:59, Daniel Stone wrote: > >I believe that in January, we had $2082 of network cost (almost > >entirely egress; ingress is basically free) and $1750 of > >cloud-storage cost (almost all of which was download). Th

[PATCH] drm/shmem: drop pgprot_decrypted()

2020-02-28 Thread Gerd Hoffmann
Was added by commit 95cf9264d5f3 ("x86, drm, fbdev: Do not specify encrypted memory for video mappings"), then it was kept through various changes. While vram actually needs decrypted mappings this is not correct for shmem gem objects which live in main memory not io memory, so remove the call. S

Re: [PATCH v5 1/3] drm/shmem: add support for per object caching flags.

2020-02-28 Thread Gerd Hoffmann
On Fri, Feb 28, 2020 at 10:54:54AM +0100, Thomas Hellström (VMware) wrote: > On 2/28/20 10:49 AM, Gerd Hoffmann wrote: > >Hi, > > > > > > Not clue about the others (lima, tiny, panfrost, v3d). Maybe they use > > > > write-combine just because this is what they got by default from > > > > drm_

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Daniel Stone
On Fri, 28 Feb 2020 at 10:06, Erik Faye-Lund wrote: > On Fri, 2020-02-28 at 11:40 +0200, Lionel Landwerlin wrote: > > Yeah, changes on vulkan drivers or backend compilers should be > > fairly > > sandboxed. > > > > We also have tools that only work for intel stuff, that should never > > trigger an

Re: [PATCH] drm/etnaviv: rework perfmon query infrastructure

2020-02-28 Thread Christian Gmeiner
Hi Lucas, Am Mi., 26. Feb. 2020 um 16:19 Uhr schrieb Lucas Stach : > > Hi Christian, > > sorry for taking so long to get around to this. > No problem... > On Mo, 2020-01-06 at 11:43 +0100, Christian Gmeiner wrote: > > Report the correct perfmon domains and signals depending > > on the supported

[PATCH v2] drm/etnaviv: rework perfmon query infrastructure

2020-02-28 Thread Christian Gmeiner
Report the correct perfmon domains and signals depending on the supported feature flags. Reported-by: Dan Carpenter Fixes: 9e2c2e273012 ("drm/etnaviv: add infrastructure to query perf counter") Cc: sta...@vger.kernel.org Signed-off-by: Christian Gmeiner --- Changes V1 -> V2: - Handle domain =

Re: [RFC PATCH 0/8] *** Refactor struct virtgpu_object ***

2020-02-28 Thread Gerd Hoffmann
Hi, > > struct virtgpu_object { > > Yeah, using "virtgpu_" rather than "virtio_gpu" makes sense. It wasn't my intention to suggest a rename. It's just that the kernel is a bit inconsistent here and I picked the wrong name here. Most places use virtio_gpu but some use virtgpu (file names, ioc

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Lucas Stach
On Fr, 2020-02-28 at 10:47 +0100, Daniel Vetter wrote: > On Fri, Feb 28, 2020 at 10:29 AM Erik Faye-Lund > wrote: > > On Fri, 2020-02-28 at 13:37 +1000, Dave Airlie wrote: > > > On Fri, 28 Feb 2020 at 07:27, Daniel Vetter > > > wrote: > > > > Hi all, > > > > > > > > You might have read the short

Re: [PATCH v10 5/5] soc / drm: mediatek: Fix mediatek-drm device probing

2020-02-28 Thread CK Hu
Hi, Enric: On Thu, 2020-02-27 at 19:08 +0100, Enric Balletbo i Serra wrote: > In the actual implementation the same compatible string > "mediatek,-mmsys" is used to bind the clock drivers > (drivers/soc/mediatek) as well as to the gpu driver > (drivers/gpu/drm/mediatek/mtk_drm_drv.c). This ends wi

Re: [PATCH] drm/bochs: Remove vga write

2020-02-28 Thread Gerd Hoffmann
On Thu, Feb 27, 2020 at 01:04:54PM -0800, Alistair Francis wrote: > The QEMU model for the Bochs display has no VGA memory section at offset > 0x400 [1]. By writing to this register Linux can create a write to > unassigned memory which depending on machine and architecture can result > in a store f

Re: [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-02-28 Thread Thomas Zimmermann
Hi Am 28.02.20 um 09:43 schrieb Daniel Vetter: > On Fri, Feb 28, 2020 at 8:30 AM Thomas Zimmermann wrote: >> >> Hi Daniel >> >> Am 27.02.20 um 19:14 schrieb Daniel Vetter: >>> drm_mode_config_cleanup is idempotent, so no harm in calling this >>> twice. This allows us to gradually switch drivers o

Re: [PATCH v5 1/3] drm/shmem: add support for per object caching flags.

2020-02-28 Thread VMware
On 2/28/20 10:49 AM, Gerd Hoffmann wrote: Hi, Not clue about the others (lima, tiny, panfrost, v3d). Maybe they use write-combine just because this is what they got by default from drm_gem_mmap_obj(). Maybe they actually need that. Trying to Cc: maintainters (and drop stable@). virtio-gpu

Re: [PATCH v5 1/3] drm/shmem: add support for per object caching flags.

2020-02-28 Thread Gerd Hoffmann
Hi, > > Not clue about the others (lima, tiny, panfrost, v3d). Maybe they use > > write-combine just because this is what they got by default from > > drm_gem_mmap_obj(). Maybe they actually need that. Trying to Cc: > > maintainters (and drop stable@). > > virtio-gpu needs it, otherwise the

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Daniel Vetter
On Fri, Feb 28, 2020 at 10:29 AM Erik Faye-Lund wrote: > > On Fri, 2020-02-28 at 13:37 +1000, Dave Airlie wrote: > > On Fri, 28 Feb 2020 at 07:27, Daniel Vetter > > wrote: > > > Hi all, > > > > > > You might have read the short take in the X.org board meeting > > > minutes > > > already, here's t

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Lionel Landwerlin
On 28/02/2020 11:28, Erik Faye-Lund wrote: On Fri, 2020-02-28 at 13:37 +1000, Dave Airlie wrote: On Fri, 28 Feb 2020 at 07:27, Daniel Vetter wrote: Hi all, You might have read the short take in the X.org board meeting minutes already, here's the long version. The good news: gitlab.fd.o has b

[PATCH v2] drm: panfrost: Silence warnings during deferred probe

2020-02-28 Thread Marek Szyprowski
Signed-off-by: Marek Szyprowski --- v2: - fixed build warning --- drivers/gpu/drm/panfrost/panfrost_device.c | 26 +++--- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c index 2

Re: [PATCH v10 4/5] soc / drm: mediatek: Move routing control to mmsys device

2020-02-28 Thread CK Hu
Hi, Enric: On Thu, 2020-02-27 at 19:08 +0100, Enric Balletbo i Serra wrote: > Provide a mtk_mmsys_ddp_connect() and mtk_mmsys_disconnect() functions to > replace mtk_ddp_add_comp_to_path() and mtk_ddp_remove_comp_from_path(). > Those functions will allow DRM driver and others to control the data >

Re: [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Daniel Stone
On Fri, 28 Feb 2020 at 08:48, Dave Airlie wrote: > On Fri, 28 Feb 2020 at 18:18, Daniel Stone wrote: > > The last I looked, Google GCP / Amazon AWS / Azure were all pretty > > comparable in terms of what you get and what you pay for them. > > Obviously providers like Packet and Digital Ocean who

Re: [Intel-gfx] linux-next: Tree for Feb 28 (gpu/drm/i915/display/intel_display.c)

2020-02-28 Thread Jani Nikula
On Thu, 27 Feb 2020, Randy Dunlap wrote: > On 2/27/20 8:42 PM, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20200227: >> > > on i386: > > ../drivers/gpu/drm/i915/display/intel_display.c:252:1: error: > 'has_transcoder' defined but not used [-Werror=unused-function] > has_transcoder(s

Re: [PATCH v10 3/5] soc: mediatek: Move mt8173 MMSYS to platform driver

2020-02-28 Thread CK Hu
Hi, Enric: On Thu, 2020-02-27 at 19:08 +0100, Enric Balletbo i Serra wrote: > From: Matthias Brugger > > There is no strong reason for this to use CLK_OF_DECLARE instead of > being a platform driver. Plus, this driver provides clocks but also > a shared register space for the mediatek-drm and th

[PATCH] drm: prevent a harmless integer overflow in drm_legacy_sg_alloc()

2020-02-28 Thread Dan Carpenter
There is an integer overflow when we round up to PAGE_SIZE, but it's harmless because we never re-use "request->size" for anything meaningful. Signed-off-by: Dan Carpenter --- This code predates git. drivers/gpu/drm/drm_scatter.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gp

Re: [PATCH v10 2/5] dt-bindings: mediatek: Update mmsys binding to reflect it is a system controller

2020-02-28 Thread CK Hu
Hi, Enric: On Thu, 2020-02-27 at 19:08 +0100, Enric Balletbo i Serra wrote: > The mmsys system controller is not only a pure clock controller, so > update the binding documentation to reflect that apart from providing > clocks, it also provides routing and miscellaneous control registers. > Revi

[PATCH] drm/panfrost: Silence warnings during deferred probe

2020-02-28 Thread Marek Szyprowski
Don't confuse user with meaningless warnings about the failure in getting resources in case of deferred probe. Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/panfrost/panfrost_device.c | 29 ++ 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/d

Re: [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Dave Airlie
On Fri, 28 Feb 2020 at 18:18, Daniel Stone wrote: > > On Fri, 28 Feb 2020 at 03:38, Dave Airlie wrote: > > b) we probably need to take a large step back here. > > > > Look at this from a sponsor POV, why would I give X.org/fd.o > > sponsorship money that they are just giving straight to google to

Re: [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-02-28 Thread Daniel Vetter
On Fri, Feb 28, 2020 at 8:30 AM Thomas Zimmermann wrote: > > Hi Daniel > > Am 27.02.20 um 19:14 schrieb Daniel Vetter: > > drm_mode_config_cleanup is idempotent, so no harm in calling this > > twice. This allows us to gradually switch drivers over by removing > > explicit drm_mode_config_cleanup c

Re: [PATCH 50/51] drm/udl: drop drm_driver.release hook

2020-02-28 Thread Daniel Vetter
On Fri, Feb 28, 2020 at 8:44 AM Thomas Zimmermann wrote: > > Hi Daniel > > Am 27.02.20 um 19:15 schrieb Daniel Vetter: > > There's only two functions called from that: > > drm_kms_helper_poll_fini() and udl_free_urb_list(). Both of these are > > also called from the ubs_driver->disconnect hook, so

[PATCH v11 2/6] dt-bindings: display: mediatek: control dpi pins mode to avoid leakage

2020-02-28 Thread Jitao Shi
Add property "pinctrl-names" to swap pin mode between gpio and dpi mode. Set the dpi pins to gpio mode and output-low to avoid leakage current when dpi disabled. Signed-off-by: Jitao Shi --- .../devicetree/bindings/display/mediatek/mediatek,dpi.txt | 7 +++ 1 file changed, 7 insertions(+)

[PATCH v4 3/4] drm/mgag200: Use simple encoder

2020-02-28 Thread Thomas Zimmermann
The mgag200 driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. v4: * print error message with drm_err() v3: * init pre-allocated encoder with drm_simple_encoder_init() v2: * rebase onto new simple-encoder interface Signed

[PATCH v4 2/4] drm/ast: Use simple encoder

2020-02-28 Thread Thomas Zimmermann
The ast driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. v2: * rebase onto new simple-encoder interface Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg --- drivers/gpu/drm/ast/ast_drv.h | 6 +- drivers/gpu/drm/ast/ast_

[PATCH v4 4/4] drm/qxl: Use simple encoder

2020-02-28 Thread Thomas Zimmermann
The qxl driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. v4: * handle errors returned from drm_simple_encoder_init() v2: * rebase onto new simple-encoder interface Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg Ac

[PATCH v4 0/4] drm: Provide a simple encoder

2020-02-28 Thread Thomas Zimmermann
Many DRM drivers implement an encoder with an empty implementation. This patchset adds drm_simple_encoder_init(), which drivers can use instead. Except for the destroy callback, the simple encoder's implementation is empty. The patchset also converts 4 encoder instances to use the simple-encoder h

[PATCH v4 1/4] drm/simple-kms: Add drm_simple_encoder_{init, create}()

2020-02-28 Thread Thomas Zimmermann
This patch makes the internal encoder implementation of the simple KMS helpers available to drivers. These simple-encoder helpers initialize an encoder with an empty implementation. This covers the requirements of most of the existing DRM drivers. A call to drm_simple_encoder_create() allocates an

Re: [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-28 Thread Daniel Stone
On Fri, 28 Feb 2020 at 03:38, Dave Airlie wrote: > b) we probably need to take a large step back here. > > Look at this from a sponsor POV, why would I give X.org/fd.o > sponsorship money that they are just giving straight to google to pay > for hosting credits? Google are profiting in some minor

[PATCH v11 4/6] dt-bindings: display: mediatek: convert the document format from txt to yaml

2020-02-28 Thread Jitao Shi
Signed-off-by: Jitao Shi --- .../display/mediatek/mediatek,dpi.txt | 45 .../display/mediatek/mediatek,dpi.yaml| 100 ++ 2 files changed, 100 insertions(+), 45 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,d

[PATCH v11 5/6] drm/mediatek: dpi sample mode support

2020-02-28 Thread Jitao Shi
DPI can sample on falling, rising or both edge. When DPI sample the data both rising and falling edge. It can reduce half data io pins. Reviewed-by: CK Hu Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dpi.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) d

[PATCH v11 6/6] drm/mediatek: set dpi pin mode to gpio low to avoid leakage current

2020-02-28 Thread Jitao Shi
Config dpi pins mode to output and pull low when dpi is disabled. Aovid leakage current from some dpi pins (Hsync Vsync DE ... ). Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dpi.c | 44 -- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH v11 1/6] dt-bindings: media: add pclk-sample dual edge property

2020-02-28 Thread Jitao Shi
Some chips's sample mode are rising, falling and dual edge (both falling and rising edge). Extern the pclk-sample property to support dual edge. Acked-by: Rob Herring Reviewed-by: CK Hu Signed-off-by: Jitao Shi --- Documentation/devicetree/bindings/media/video-interfaces.txt | 4 ++-- 1 file c

[PATCH v11 3/6] dt-bindings: display: mediatek: dpi sample data in dual edge support

2020-02-28 Thread Jitao Shi
Add property "pclk-sample" to config the dpi sample on falling (0), rising (1), both falling and rising (2). Signed-off-by: Jitao Shi --- .../devicetree/bindings/display/mediatek/mediatek,dpi.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree

[PATCH v11 0/6] mt8183 dpi supports dual edge and pin mode swap

2020-02-28 Thread Jitao Shi
Change since v10: - convert the Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt to yaml format. - read the pclk-sample in endpoint. Changes since v9: - rename pinctrl-names = "gpiomode", "dpimode" to "active", "idle". - fix some typo. Changes since v8: - drop pclk-sam

[PATCH] drm/stm: ltdc: check number of endpoints

2020-02-28 Thread Yannick Fertre
Number of endpoints could exceed the fix value MAX_ENDPOINTS(2). Instead of increase simply this value, the number of endpoint could be read from device tree. Load sequence has been a little rework to take care of several panel or bridge which can be connected/disconnected or enable/disable. Signe

  1   2   >