Re: [RFC] treewide: cleanup unreachable breaks

2020-10-17 Thread Greg KH
On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote: > From: Tom Rix > > This is a upcoming change to clean up a new warning treewide. > I am wondering if the change could be one mega patch (see below) or > normal patch per file about 100 patches or somewhere half way by collecting >

Re: [RFC] treewide: cleanup unreachable breaks

2020-10-17 Thread Dan Williams
On Sat, Oct 17, 2020 at 9:10 AM wrote: > > From: Tom Rix > > This is a upcoming change to clean up a new warning treewide. > I am wondering if the change could be one mega patch (see below) or > normal patch per file about 100 patches or somewhere half way by collecting > early acks. > > clang

Re: [PATCH 1/2] mm: mmap: fix fput in error path v2

2020-10-17 Thread Jason Gunthorpe
On Mon, Oct 12, 2020 at 10:52:02AM +0200, Christian König wrote: > Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." > adds a workaround for a bug in mmap_region. > > As the comment states ->mmap() callback can change > vma->vm_file and so we might call fput() on the wrong file. > > Revert

[PATCH 2/4] drm/msm/dsi_pll_10nm: restore VCO rate during restore_state

2020-10-17 Thread Dmitry Baryshkov
PHY disable/enable resets PLL registers to default values. Thus in addition to restoring several registers we also need to restore VCO rate settings. Signed-off-by: Dmitry Baryshkov Fixes: c6659785dfb3 ("drm/msm/dsi/pll: call vco set rate explicitly") ---

[PATCH 3/3] drm/sun4i: frontend: Fix the scaler phase on A33

2020-10-17 Thread Maxime Ripard
The A33 has a different phase parameter in the Allwinner BSP on the channel1 than the one currently applied. Fix this. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun4i_frontend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [RFC][PATCH] drm/bridge: lvds-codec: Add support for pixel data sampling edge select

2020-10-17 Thread Marek Vasut
On 10/16/20 6:25 PM, Sam Ravnborg wrote: > Hi Marek. Hello Sam, > On Sat, Oct 03, 2020 at 01:08:23AM +0200, Marek Vasut wrote: >> The OnSemi FIN3385 Parallel-to-LVDS encoder has a dedicated input line to >> select input pixel data sampling edge. Add DT property "pixelclk-active", >> same as the

Re: [PATCH v5 3/5] RDMA/uverbs: Add uverbs command for dma-buf based MR registration

2020-10-17 Thread Jason Gunthorpe
On Thu, Oct 15, 2020 at 03:02:55PM -0700, Jianxin Xiong wrote: > Implement a new uverbs ioctl method for memory registration with file > descriptor as an extra parameter. > > Signed-off-by: Jianxin Xiong > Reviewed-by: Sean Hefty > Acked-by: Michael J. Ruhl > Acked-by: Christian Koenig >

Re: [PATCH v5 1/5] RDMA/umem: Support importing dma-buf as user memory region

2020-10-17 Thread Jason Gunthorpe
On Sat, Oct 17, 2020 at 12:57:21AM +, Xiong, Jianxin wrote: > > From: Jason Gunthorpe > > Sent: Friday, October 16, 2020 5:28 PM > > To: Xiong, Jianxin > > Cc: linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org; Doug > > Ledford ; Leon Romanovsky > > ; Sumit Semwal ; Christian

[v3] drm/msm: Fix race condition in msm driver with async layer updates

2020-10-17 Thread Krishna Manikandan
When there are back to back commits with async cursor update, there is a case where second commit can program the DPU hw blocks while first didn't complete flushing config to HW. Synchronize the compositions such that second commit waits until first commit flushes the composition. This change

[PATCH 1/3] drm/sun4i: frontend: Rework a bit the phase data

2020-10-17 Thread Maxime Ripard
The scaler filter phase setup in the allwinner kernel has two different cases for setting up the scaler filter, the first one using different phase parameters for the two channels, and the second one reusing the first channel parameters on the second channel. The allwinner kernel has a third

Re: [PATCH 2/2] mm: introduce vma_set_file function v4

2020-10-17 Thread Jason Gunthorpe
On Mon, Oct 12, 2020 at 10:52:03AM +0200, Christian König wrote: > Add the new vma_set_file() function to allow changing > vma->vm_file with the necessary refcount dance. > > v2: add more users of this. > v3: add missing EXPORT_SYMBOL, rebase on mmap cleanup, > add comments why we drop the

Re: [PATCH v5 1/5] RDMA/umem: Support importing dma-buf as user memory region

2020-10-17 Thread Jason Gunthorpe
On Thu, Oct 15, 2020 at 03:02:45PM -0700, Jianxin Xiong wrote: > +static void ib_umem_dmabuf_invalidate_cb(struct dma_buf_attachment *attach) > +{ > + struct ib_umem_dmabuf *umem_dmabuf = attach->importer_priv; > + > + dma_resv_assert_held(umem_dmabuf->attach->dmabuf->resv); > + > +

[PATCH drm/hisilicon v3 1/2] drm/hisilicon: Use the same style of variable type in hibmc_drm_de

2020-10-17 Thread Tian Tao
Consistently Use the same style of variable type in hibmc_drm_de.c. Signed-off-by: Tian Tao Acked-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 59 +- 1 file changed, 29 insertions(+), 30 deletions(-) diff --git

[PATCH drm/hisilicon v3 0/2] Use the same style of variable type

2020-10-17 Thread Tian Tao
patch #1 and #2 Use the same style of variable type in hisilicon drm driver and both are clean up, no actual functional changes. Changes since v1: -Change part of unsigned int to size_t. Changes since v2: -Modify the type of fb_base and fb_size to resource_size_t. Tian Tao (2):

Re: [Cocci] [RFC] treewide: cleanup unreachable breaks

2020-10-17 Thread Julia Lawall
On Sat, 17 Oct 2020, Joe Perches wrote: > On Sat, 2020-10-17 at 09:09 -0700, t...@redhat.com wrote: > > From: Tom Rix > > > > This is a upcoming change to clean up a new warning treewide. > > I am wondering if the change could be one mega patch (see below) or > > normal patch per file about

[PATCH 2/3] drm/sun4i: frontend: Reuse the ch0 phase for RGB formats

2020-10-17 Thread Maxime Ripard
When using the scaler on the A10-like frontend with single-planar formats, the current code will setup the channel 0 filter (used for the R or Y component) with a different phase parameter than the channel 1 filter (used for the G/B or U/V components). This creates a bleed out that keeps

Re: [v1] drm/msm: Fix race condition in msm driver with async layer updates

2020-10-17 Thread mkrishn
On 2020-10-14 20:55, Rob Clark wrote: On Wed, Oct 14, 2020 at 5:58 AM Krishna Manikandan wrote: When there are back to back commits with async cursor update, there is a case where second commit can program the DPU hw blocks while first didn't complete flushing config to HW. Synchronize the

[PATCH drm/hisilicon v2 2/2] drm/hisilicon: Use the same style of variable type in hibmc_drm_drv

2020-10-17 Thread Tian Tao
Consistently Use the same style of variable type in hibmc_drm_drv.c and hibmc_drm_drv.h. Signed-off-by: Tian Tao Acked-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 13 ++--- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 8 2 files changed,

RE: [PATCH v3] drm/bridge: lvds-codec: Add support for regulator

2020-10-17 Thread Biju Das
Hi Sam, > Subject: Re: [PATCH v3] drm/bridge: lvds-codec: Add support for regulator > > Hi Biju, Laurent > > On Tue, Sep 22, 2020 at 01:55:26PM +0300, Laurent Pinchart wrote: > > From: Biju Das > > > > Add the support for enabling optional regulator that may be used as > > VCC source. > > > >

[PATCH drm/hisilicon v2 0/2] Use the same style of variable type

2020-10-17 Thread Tian Tao
patch #1 and #2 Use the same style of variable type in hisilicon drm driver and both are clean up, no actual functional changes. Changes since v1: -Change part of unsigned int to size_t. Tian Tao (2): drm/hisilicon: Use the same style of variable type in hibmc_drm_de drm/hisilicon: Use the

Re: [RFC PATCH 1/4] Add a RPMSG driver for the APU in the mt8183

2020-10-17 Thread Mathieu Poirier
On Wed, Oct 14, 2020 at 04:55:34PM -0600, Mathieu Poirier wrote: > Hi Alexandre, > > On Wed, Sep 30, 2020 at 01:53:47PM +0200, Alexandre Bailon wrote: > > This adds a driver to communicate with the APU available > > in the mt8183. The driver is generic and could be used for other APU. > > It

[v2] drm/msm: Fix race condition in msm driver with async layer updates

2020-10-17 Thread Krishna Manikandan
When there are back to back commits with async cursor update, there is a case where second commit can program the DPU hw blocks while first didn't complete flushing config to HW. Synchronize the compositions such that second commit waits until first commit flushes the composition. This change

Re: [PATCH v5 4/5] RDMA/mlx5: Support dma-buf based userspace memory region

2020-10-17 Thread Jason Gunthorpe
On Fri, Oct 16, 2020 at 06:40:01AM +, Xiong, Jianxin wrote: > > > + if (!mr) > > > + return -EINVAL; > > > + > > > + return mlx5_ib_update_xlt(mr, 0, mr->npages, PAGE_SHIFT, flags); } > > > + > > > +static struct ib_umem_dmabuf_ops mlx5_ib_umem_dmabuf_ops = { > > > + .init =

Re: [PATCH v5 1/5] RDMA/umem: Support importing dma-buf as user memory region

2020-10-17 Thread Jason Gunthorpe
On Thu, Oct 15, 2020 at 03:02:45PM -0700, Jianxin Xiong wrote: > +struct ib_umem *ib_umem_dmabuf_get(struct ib_device *device, > +unsigned long addr, size_t size, > +int dmabuf_fd, int access, > +const

Re: [PATCH v5 4/5] RDMA/mlx5: Support dma-buf based userspace memory region

2020-10-17 Thread Jason Gunthorpe
On Thu, Oct 15, 2020 at 03:02:58PM -0700, Jianxin Xiong wrote: > Implement the new driver method 'reg_user_mr_dmabuf'. Utilize the core > functions to import dma-buf based memory region and update the mappings. > > Add code to handle dma-buf related page fault. > > Signed-off-by: Jianxin Xiong

[PATCH drm/hisilicon v2 1/2] drm/hisilicon: Use the same style of variable type in hibmc_drm_de

2020-10-17 Thread Tian Tao
Consistently Use the same style of variable type in hibmc_drm_de.c. Signed-off-by: Tian Tao Acked-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 59 +- 1 file changed, 29 insertions(+), 30 deletions(-) diff --git

[PATCH drm/hisilicon v3 2/2] drm/hisilicon: Use the same style of variable type in hibmc_drm_drv

2020-10-17 Thread Tian Tao
Consistently Use the same style of variable type in hibmc_drm_drv.c and hibmc_drm_drv.h. Signed-off-by: Tian Tao Acked-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 13 ++--- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 8 2 files changed,

[PATCH 1/4] drm/msm/dsi_pll_7nm: restore VCO rate during restore_state

2020-10-17 Thread Dmitry Baryshkov
PHY disable/enable resets PLL registers to default values. Thus in addition to restoring several registers we also need to restore VCO rate settings. Signed-off-by: Dmitry Baryshkov Fixes: 1ef7c99d145c ("drm/msm/dsi: add support for 7nm DSI PHY/PLL") ---

Re: [Intel-gfx] [PATCH] Revert "drm/i915: Force state->modeset=true when distrust_bios_wm==true"

2020-10-17 Thread Stefan Joosten
Dear Ville Syrjälä, Thank you for responding so quickly. I was occupied with work and life for the past two weeks, sorry about the wait, but have now managed to find some time to continue pursuing this issue again. On Thu, 2020-10-01 at 18:23 +0300, Ville Syrjälä wrote: > Argh. If only I had

[PATCH 4/4] drm/msm/dsi_phy_10nm: implement PHY disabling

2020-10-17 Thread Dmitry Baryshkov
Implement phy_disable() callback to disable DSI PHY lanes and blocks when phy is not used. Signed-off-by: Dmitry Baryshkov Fixes: ff73ff194060 ("drm/msm/dsi: Populate the 10nm PHY funcs") --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 22 ++ 1 file changed, 22

[PATCH 3/4] drm/msm/dsi_phy_7nm: implement PHY disabling

2020-10-17 Thread Dmitry Baryshkov
Implement phy_disable() callback to disable DSI PHY lanes and blocks when phy is not used. Signed-off-by: Dmitry Baryshkov Fixes: 1ef7c99d145c ("drm/msm/dsi: add support for 7nm DSI PHY/PLL") --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 23 ++- 1 file changed, 22

Re: [Cocci] [RFC] treewide: cleanup unreachable breaks

2020-10-17 Thread Joe Perches
On Sat, 2020-10-17 at 20:21 +0200, Julia Lawall wrote: > On Sat, 17 Oct 2020, Joe Perches wrote: > > On Sat, 2020-10-17 at 09:09 -0700, t...@redhat.com wrote: > > > From: Tom Rix > > > > > > This is a upcoming change to clean up a new warning treewide. > > > I am wondering if the change could be

Re: [RFC] treewide: cleanup unreachable breaks

2020-10-17 Thread Joe Perches
On Sat, 2020-10-17 at 09:09 -0700, t...@redhat.com wrote: > From: Tom Rix > > This is a upcoming change to clean up a new warning treewide. > I am wondering if the change could be one mega patch (see below) or > normal patch per file about 100 patches or somewhere half way by collecting > early

[RFC] treewide: cleanup unreachable breaks

2020-10-17 Thread trix
From: Tom Rix This is a upcoming change to clean up a new warning treewide. I am wondering if the change could be one mega patch (see below) or normal patch per file about 100 patches or somewhere half way by collecting early acks. clang has a number of useful, new warnings see

Re: [PATCH 1/3] drm/vkms: Set preferred depth correctly

2020-10-17 Thread Daniel Vetter
On Sat, Oct 17, 2020 at 10:39 AM Melissa Wen wrote: > > On 10/16, Daniel Vetter wrote: > > On Fri, Oct 16, 2020 at 7:02 PM Melissa Wen wrote: > > > > > > On 10/16, Daniel Vetter wrote: > > > > On Fri, Oct 16, 2020 at 12:38 PM Simon Ser wrote: > > > > > > > > > > > The only thing we support is

Re: [PATCH] vgacon: fix a UAF in do_update_region()

2020-10-17 Thread Sam Ravnborg
Hi Yang. Can you please resend and include Greg in the recipient list. Greg is maintainer of the console subsystem these days. Sam On Mon, Jul 13, 2020 at 11:04:45AM +, Yang Yingliang wrote: > I got a UAF report in do_update_region() when I doing fuzz test. > > [ 51.161905] BUG:

Re: [PATCH v2 0/3] drm/panel: mantix panel reset fixes

2020-10-17 Thread Sam Ravnborg
Hi Guido. On Sat, Oct 17, 2020 at 11:13:07AM +0200, Guido Günther wrote: > Hi Sam, > On Fri, Oct 16, 2020 at 04:29:16PM +0200, Sam Ravnborg wrote: > > Hi Guido. > > On Tue, Oct 13, 2020 at 12:32:45PM +0200, Guido Günther wrote: > [..snip..] > > > > > > Changes from v1: > > > - As per review

Re: [PATCH v2 0/3] drm/panel: mantix panel reset fixes

2020-10-17 Thread Guido Günther
Hi Sam, On Fri, Oct 16, 2020 at 04:29:16PM +0200, Sam Ravnborg wrote: > Hi Guido. > On Tue, Oct 13, 2020 at 12:32:45PM +0200, Guido Günther wrote: [..snip..] > > > > Changes from v1: > > - As per review comments by Fabio Estevam > > > >

Re: [PATCH 1/3] drm/vkms: Set preferred depth correctly

2020-10-17 Thread Melissa Wen
On 10/16, Daniel Vetter wrote: > On Fri, Oct 16, 2020 at 7:02 PM Melissa Wen wrote: > > > > On 10/16, Daniel Vetter wrote: > > > On Fri, Oct 16, 2020 at 12:38 PM Simon Ser wrote: > > > > > > > > > The only thing we support is xrgb. > > > > > > > > > > Signed-off-by: Daniel Vetter > > > > >

Re: [PATCH] drm/via: reduce no need mutex_lock area

2020-10-17 Thread Sam Ravnborg
Hi Bernard. On Fri, Aug 14, 2020 at 01:30:19AM -0700, Bernard Zhao wrote: > In function via_mem_alloc`s error branch, DRM_ERROR is protected > in the mutex_lock(>struct_mutex) area. > >From the code, we see that DRM_ERROR is just an error log print > without any struct element, there is no need

Re: [PATCH 2/2] drm/panel: simple: Add support for Innolux LS075AT011

2020-10-17 Thread Sam Ravnborg
Hi Lubomir. Sorry for the late feedback! On Wed, Aug 19, 2020 at 12:12:06PM +0200, Lubomir Rintel wrote: > This adds support for the Innolux LS075AT011 7.5" 1200x900 panel. There's > no public data sheet for the panel -- the values have been taken from Open > Firmware and the documentation for

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-10-17 Thread Sam Ravnborg
Hi Vinay On Tue, Sep 08, 2020 at 08:57:07PM +0300, Laurent Pinchart wrote: > Hi Vinay, > > On Tue, Sep 08, 2020 at 11:22:48PM +0530, Vinay Simha B N wrote: > > laurent, > > > > Please review or give some feedback. > > I'm sorry, I have very little time these days :-( Maybe Neil can provide >

Re: [PATCH 1/2] drm/mcde: Fix handling of platform_get_irq() error

2020-10-17 Thread Sam Ravnborg
Hi Krzysztof On Thu, Aug 27, 2020 at 09:11:06AM +0200, Krzysztof Kozlowski wrote: > platform_get_irq() returns -ERRNO on error. In such case comparison > to 0 would pass the check. > > Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE") > Signed-off-by: Krzysztof Kozlowski

Re: [PATCH v3] drm/bridge: add it6505 driver

2020-10-17 Thread Sam Ravnborg
Hi Allen On Fri, Sep 04, 2020 at 10:10:23AM +0800, allen wrote: > This adds support for the iTE IT6505. > This device can convert DPI signal to DP output. > > From: Allen Chen > Signed-off-by: Jitao Shi > Signed-off-by: Pi-Hsun Shih > Signed-off-by: Yilun Lin > Signed-off-by: Hermes Wu >

Re: [PATCH 1/3] dt-bindings: vendor-prefixes: Add Yes Optoelectronics

2020-10-17 Thread Sam Ravnborg
Hi Jagan. On Fri, Sep 04, 2020 at 11:38:19PM +0530, Jagan Teki wrote: > Add vendor dt-bindings for Yes Optoelectronics Co.,Ltd. > > Signed-off-by: Jagan Teki I have applied the full series to drm-misc-next. Sorry for the delay. Sam > --- >

Re: [PATCH v3 0/2] Add LT9611UXC DSI to HDMI bridge support

2020-10-17 Thread Sam Ravnborg
Hi Dmitry On Wed, Sep 09, 2020 at 12:28:21PM +0300, Dmitry Baryshkov wrote: > Hi, > > This series adds support for Lontium LT9611UXC bridge chip which takes > MIPI DSI as input and provides HDMI signal as output. > > The chip can be found in Qualcomm RB5 platform [1], [2]. > > [1]

Re: [PATCH] video: fbdev: fsl-diu-fb: remove unneeded variable 'res'

2020-10-17 Thread Sam Ravnborg
On Thu, Sep 10, 2020 at 10:05:58PM +0800, Jason Yan wrote: > Eliminate the following coccicheck warning: > > drivers/video/fbdev/fsl-diu-fb.c:1428:5-8: Unneeded variable: "res". > Return "0" on line 1450 > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Hi Jason, applied to

Re: [PATCH] video: fbdev: sis: remove unneeded semicolon

2020-10-17 Thread Sam Ravnborg
On Thu, Sep 10, 2020 at 10:05:36PM +0800, Jason Yan wrote: > Eliminate the following coccicheck warning: > > drivers/video/fbdev/sis/sis_accel.h:143:72-73: Unneeded semicolon > drivers/video/fbdev/sis/sis_accel.h:144:72-73: Unneeded semicolon > drivers/video/fbdev/sis/sis_accel.h:145:72-73:

Re: [PATCH -next] omapfb: connector-dvi: simplify the return expression of dvic_connect()

2020-10-17 Thread Sam Ravnborg
Hi Liu. On Tue, Sep 15, 2020 at 11:26:27AM +0800, Liu Shixin wrote: > Simplify the return expression. > > Signed-off-by: Liu Shixin Thanks, also applied. If you have other drm/fbdev patches pending then I have missed them. So please resend if this is the case. Sam > --- >

Re: [PATCH -next] drm/panel: simplify the return expression of rb070d30_panel_enable()

2020-10-17 Thread Sam Ravnborg
Hi Liu On Tue, Sep 15, 2020 at 11:26:23AM +0800, Liu Shixin wrote: > Simplify the return expression. > > Signed-off-by: Liu Shixin Thanks, applied to drm-misc-next. The patch will appear in drm-misc-next in a few weeks. Sam > --- > drivers/gpu/drm/panel/panel-ronbo-rb070d30.c | 7

Re: [PATCH] drm/bridge: analogix_dp: make analogix_dp_start_aux_transaction() static

2020-10-17 Thread Sam Ravnborg
Hi Jason. Thanks, also applied to drm-misc-next. If you had other drm/fbdev related patches pending then I have missed them so please resend. Sam On Sat, Sep 12, 2020 at 11:38:43AM +0800, Jason Yan wrote: > This eliminates the following sparse warning: > >

Re: [PATCH] drm: bridge: adv7511: make adv7511_hdmi_hw_params() static

2020-10-17 Thread Sam Ravnborg
Hi Jason, Thanks, applied to drm-misc-next. As for the other patch this will appear in -next in a few weeks. Sam On Sat, Sep 12, 2020 at 11:38:26AM +0800, Jason Yan wrote: > This eliminates the following sparse warning: > > drivers/gpu/drm/bridge/adv7511/adv7511_audio.c:58:5: warning:

Re: [PATCH] drm/panel: st7703: Make jh057n00900_panel_desc static

2020-10-17 Thread Sam Ravnborg
Hi Jason, On Sat, Sep 12, 2020 at 11:38:09AM +0800, Jason Yan wrote: > This eliminates the following sparse warning: > > drivers/gpu/drm/panel/panel-sitronix-st7703.c:156:26: warning: symbol > 'jh057n00900_panel_desc' was not declared. Should it be static? > > Reported-by: Hulk Robot >

Re: [PATCH v4 0/4] drm: panel: add support for TDO tl070wsh30 panel

2020-10-17 Thread Sam Ravnborg
Hi Neil. On Tue, Sep 29, 2020 at 11:25:17AM +0200, Neil Armstrong wrote: > Hi Sam, > > Is there anything more to change ? Sorry for taking so long to get back to you on this. All patches looks good and are: Reviewed-by: Sam Ravnborg I assume you will apply the patches. Sam