Re: [PATCH v10 0/4] drm/panfrost: Add support for mt8183 GPU

2021-01-12 Thread Tomeu Vizoso
On 1/13/21 7:06 AM, Nicolas Boichat wrote: Hi! Follow-up on the v5 [1], things have gotten significantly better in the last 9 months, thanks to the efforts on Bifrost support by the Collabora team (and probably others I'm not aware of). I've been testing this series on a MT8183/kukui device,

[PATCH v10 4/4] drm/panfrost: Add mt8183-mali compatible string

2021-01-12 Thread Nicolas Boichat
Add support for MT8183's G72 Bifrost. Signed-off-by: Nicolas Boichat Reviewed-by: Tomeu Vizoso --- (no changes since v7) Changes in v7: - Fix GPU ID in commit message Changes in v6: - Context conflicts, reflow the code. - Use ARRAY_SIZE for power domains too. Changes in v5: - Change

[PATCH v10 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1

2021-01-12 Thread Nicolas Boichat
GPUs with more than a single regulator (e.g. G72 on MT8183) will require platform-specific handling for devfreq, for 2 reasons: 1. The opp core (drivers/opp/core.c:_generic_set_opp_regulator) does not support multiple regulators, so we'll need custom handlers. 2. Generally, platforms

[PATCH v10 1/4] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183

2021-01-12 Thread Nicolas Boichat
Define a compatible string for the Mali Bifrost GPU found in Mediatek's MT8183 SoCs. Signed-off-by: Nicolas Boichat --- Changes in v10: - Fix the binding to make sure sram-supply property can be provided. Changes in v6: - Rebased, actually tested with recent mesa driver. - No change

[PATCH v10 0/4] drm/panfrost: Add support for mt8183 GPU

2021-01-12 Thread Nicolas Boichat
Hi! Follow-up on the v5 [1], things have gotten significantly better in the last 9 months, thanks to the efforts on Bifrost support by the Collabora team (and probably others I'm not aware of). I've been testing this series on a MT8183/kukui device, with a chromeos-5.10 kernel [2], and got basic

Re: [PATCH v9 1/4] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183

2021-01-12 Thread Nicolas Boichat
On Tue, Jan 12, 2021 at 11:07 PM Rob Herring wrote: > > On Fri, Jan 08, 2021 at 09:10:08AM +0800, Nicolas Boichat wrote: > > Define a compatible string for the Mali Bifrost GPU found in > > Mediatek's MT8183 SoCs. > > > > Signed-off-by: Nicolas Boichat > > Reviewed-by: Alyssa Rosenzweig > > ---

Re: [PATCH 2/2] drm/amdgpu/display: buffer INTERRUPT_LOW_IRQ_CONTEXT interrupt work

2021-01-12 Thread Andrey Grodzovsky
On 1/4/21 1:01 AM, Xiaogang.Chen wrote: From: Xiaogang Chen amdgpu DM handles INTERRUPT_LOW_IRQ_CONTEXT interrupt(hpd, hpd_rx) by using work queue and uses single work_struct. If previous interrupt has not been handled new interrupts(same type) will be discarded and driver just sends

Re: r600/nir: enable soft-fp64 for evengreen class hardware - brake compilation of Mesa git

2021-01-12 Thread Dieter Nützel
Hello Gert, new year, new luck,...;-) mkdir build cd build meson ../ --strip --buildtype release -Ddri-drivers= -Dplatforms=x11 -Dgallium-drivers=r600,radeonsi,swrast -Dvulkan-drivers=amd -Dgallium-nine=true -Dopencl-spirv=true -Dgallium-opencl=standalone -Dglvnd=true -Dgallium-va=enabled

Re: [PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static

2021-01-12 Thread Huang Rui
On Wed, Jan 13, 2021 at 10:21:26AM +0800, Huang Rui wrote: > On Wed, Jan 13, 2021 at 10:13:02AM +0800, Alex Deucher wrote: > > On Tue, Jan 12, 2021 at 8:19 PM Huang Rui wrote: > > > > > > On Wed, Jan 13, 2021 at 03:57:22AM +0800, Souptick Joarder wrote: > > > > kernel test robot throws below

[Bug 211161] list_del corruption in ttm_pool_shrink

2021-01-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211161 --- Comment #3 from Benji Wiebe (benjiwieb...@gmail.com) --- (In reply to Alex Deucher from comment #2) > If it's the same issue, it's fixed with these patches: > https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc- >

Re: [PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static

2021-01-12 Thread Huang Rui
On Wed, Jan 13, 2021 at 10:13:02AM +0800, Alex Deucher wrote: > On Tue, Jan 12, 2021 at 8:19 PM Huang Rui wrote: > > > > On Wed, Jan 13, 2021 at 03:57:22AM +0800, Souptick Joarder wrote: > > > kernel test robot throws below warnings -> > > > > > >

Re: [PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static

2021-01-12 Thread Alex Deucher
On Tue, Jan 12, 2021 at 8:19 PM Huang Rui wrote: > > On Wed, Jan 13, 2021 at 03:57:22AM +0800, Souptick Joarder wrote: > > kernel test robot throws below warnings -> > > > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6: > > warning: no previous prototype for

[Bug 211161] list_del corruption in ttm_pool_shrink

2021-01-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211161 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

Re: [PATCH 5.11 regression fix] drm/ttm: fix combining __GFP_HIGHMEM and __GFP_DMA32 flag for DMA32 pools

2021-01-12 Thread Huang Rui
On Wed, Jan 13, 2021 at 02:32:49AM +0800, Hans de Goede wrote: > GFP_TRANSHUGE_LIGHT includes __GFP_HIGHMEM and combining > __GFP_HIGHMEM with __GFP_DMA32 is not allowed. > > So we must not set add GFP_TRANSHUGE_LIGHT to the gfp_flags when > allocating pages from a dma32 pool. > > This fixes the

Re: [PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static

2021-01-12 Thread Huang Rui
On Wed, Jan 13, 2021 at 03:57:22AM +0800, Souptick Joarder wrote: > kernel test robot throws below warnings -> > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6: > warning: no previous prototype for 'vangogh_clk_dpm_is_enabled' > [-Wmissing-prototypes] >

[Bug 211161] list_del corruption in ttm_pool_shrink

2021-01-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211161 --- Comment #1 from Benji Wiebe (benjiwieb...@gmail.com) --- Created attachment 294613 --> https://bugzilla.kernel.org/attachment.cgi?id=294613=edit kernel BUG dmesg 2 -- You may reply to this email to add a comment. You are receiving this

[Bug 211161] New: list_del corruption in ttm_pool_shrink

2021-01-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211161 Bug ID: 211161 Summary: list_del corruption in ttm_pool_shrink Product: Drivers Version: 2.5 Kernel Version: 5.11.0-rc3 Hardware: All OS: Linux Tree:

Re: [PATCH v3, 12/15] drm/mediatek: separate ccorr module

2021-01-12 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:54寫道: > > ccorr ctm matrix bits will be different in mt8192 This patch has conflicts with the series "Decouple Mediatek DRM sub driver" [1] which has been applied to mediatek-drm-next, so please rebase this patch onto mediatek-drm-next. [1]

Re: [PATCH v3, 09/15] drm/mediatek: Add pm runtime support for gamma

2021-01-12 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:48寫道: > > gamma power domain need controled in the device. In this series, why only gamma and color add pm runtime support? I think all ddp component need pm runtime support. And pm runtime support is not related to mt8192, so move these patches

Re: [PATCH 40/40] drm/amd/display/dc/core/dc_stream: Demote non-conformant kernel-doc headers

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c:253: warning: > Function parameter or member 'pStream' not described in > 'dc_optimize_timing_for_fsft' >

Re: [PATCH 39/40] drm/amd/display/dc/core/dc_surface: Demote kernel-doc abuse

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.c:119: warning: > Cannot understand > * > > Cc: Harry

Re: [PATCH 37/40] drm/amd/display/dc/dce60/dce60_resource: Make local functions static

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:522:17: > warning: no previous prototype for ‘dce60_aux_engine_create’ > [-Wmissing-prototypes] >

Re: [PATCH 36/40] drm/amd/display/dc/dce100/dce100_resource: Make local functions and ones called by reference static

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:55 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > In file included from > drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:54: > drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:614:22: > warning: no

Re: [PATCH 35/40] drm/amd/display/dc/dce60/dce60_timing_generator: Make 'dce60_configure_crc' invoked by reference static

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_timing_generator.c:192:6: > warning: no previous prototype for ‘dce60_configure_crc’ > [-Wmissing-prototypes] > > Cc: Harry Wentland

Re: [PATCH 34/40] drm/amd/display/dc/dce110/dce110_transform_v: Demote kernel-doc abuse

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_transform_v.c:228: > warning: bad line:void > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_transform_v.c:233: >

Re: [PATCH 33/40] drm/amd/display/dc/dce110/dce110_resource: Make local functions invoked by reference static

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_resource.c:262:15: > warning: initialized field overwritten [-Woverride-init] >

Re: [PATCH 32/40] drm/amd/display/dc/dce110/Makefile: Ignore -Woverride-init warning

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > In file included from > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_resource.c:66: > > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_0_sh_mask.h:5936:51: >

Re: [PATCH 31/40] drm/amd/display/dc/dce110/dce110_mem_input_v: Include our own header, containing prototypes

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:1034:6: > warning: no previous prototype for ‘dce110_mem_input_v_construct’ > [-Wmissing-prototypes] > > Cc: Harry

Re: [PATCH 30/40] drm/amd/display/dc/dce110/dce110_timing_generator_v: Demote kernel-doc abuse and line up comments

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator_v.c:54: > warning: Function parameter or member 'tg' not described in > 'dce110_timing_generator_v_enable_crtc' >

Re: [PATCH 29/40] drm/amd/display/dc/dce112/dce112_resource: Make local functions and ones called by reference static

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:55 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:620:22: > warning: no previous prototype for ‘dce112_link_encoder_create’ > [-Wmissing-prototypes] >

Re: [PATCH 27/40] drm/amd/display/dc/dce110/dce110_compressor: Strip out unused function 'controller_id_to_index'

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_compressor.c:429:14: > warning: no previous prototype for ‘controller_id_to_index’ > [-Wmissing-prototypes] > > Cc: Harry Wentland >

Re: [PATCH 26/40] drm/amd/display/dc/dce110/dce110_timing_generator: Demote kernel-doc abuses to standard function headers

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:79: > warning: Cannot understand >

Re: [PATCH 25/40] drm/amd/display/dc/dce120/dce120_timing_generator: Remove unused function 'dce120_timing_generator_get_position'

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_generator.c:602:13: > warning: ‘dce120_timing_generator_get_position’ defined but not used > [-Wunused-function] > > Cc:

Re: [PATCH 24/40] drm/amd/pm/swsmu/smu11/vangogh_ppt: Make local function 'vangogh_clk_dpm_is_enabled' static

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:613:6: warning: > no previous prototype for ‘vangogh_clk_dpm_is_enabled’ [-Wmissing-prototypes] > > Cc: Alex Deucher > Cc:

Re: [PATCH 23/40] drm/amd/display/dc/dce110/dce110_mem_input_v: Make local functions static

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.c:471:6: > warning: no previous prototype for ‘dce_mem_input_v_is_surface_pending’ > [-Wmissing-prototypes] >

Re: [PATCH 22/40] drm/amd/display/dc/dce110/dce110_hw_sequencer: Demote non-conformant kernel-doc header

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1639: > warning: Function parameter or member 'dc' not described in > 'dce110_enable_accelerated_mode' >

Re: [PATCH v5 04/21] gpu: host1x: Remove cancelled waiters immediately

2021-01-12 Thread Mikko Perttunen
On 1/13/21 12:07 AM, Dmitry Osipenko wrote: 11.01.2021 16:00, Mikko Perttunen пишет: -void host1x_intr_put_ref(struct host1x *host, unsigned int id, void *ref) +void host1x_intr_put_ref(struct host1x *host, unsigned int id, void *ref, +bool flush) { struct

Re: [PATCH 21/40] drm/amd/display/dc/dce110/dce110_compressor: Remove unused function 'dce110_get_required_compressed_surfacesize

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_compressor.c:415:6: > warning: no previous prototype for > ‘dce110_get_required_compressed_surfacesize’ [-Wmissing-prototypes] > >

Re: [PATCH 20/40] drm/amd/display/dc/dce110/dce110_timing_generator: Remove unused variable 'value_crtc_vtotal'

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c: > In function ‘dce110_timing_generator_tear_down_global_swap_lock’: > >

Re: [PATCH 19/40] drm/amd/display/dc/dce/dce_opp: Remove duplicate entries causing 'field overwritten' issues

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > In file included from > drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:59: > > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_2_sh_mask.h:10480:62: >

Re: [PATCH 18/40] drm/amd/display/dc/dce112/Makefile: Ignore -Woverride-init warning

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > This file uses a complex abstracted set of hierarchical macros to > setup its applicable register lists within constant structures. > However in the case of TMDS_CNTL we wish to mark it as not applicable > for this use-case. > > One method

Re: [PATCH 17/40] drm/amd/display/dc/dce/dce_aux: Remove duplicate line causing 'field overwritten' issue

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > In file included from > drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:59: > > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_2_sh_mask.h:10014:58: >

Re: [PATCH 16/40] drm/amd/display/dc/dce120/dce120_timing_generator: Demote non-kerneldoc headers

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_generator.c:602:13: > warning: ‘dce120_timing_generator_get_position’ defined but not used > [-Wunused-function] > >

Re: [PATCH 15/40] drm/amd/display/dc/dce120/dce120_resource: Staticify local functions

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_resource.c:426:32: > warning: no previous prototype for ‘dce120_opp_create’ [-Wmissing-prototypes] >

Re: [PATCH 12/40] drm/amd/display/dc/dce120/Makefile: Ignore -Woverride-init warning

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > This file uses a complex abstracted set of hierarchical macros to > setup its applicable register lists within constant structures. > However in the case of TMDS_CNTL we wish to mark it as not applicable > for this use-case. > > One method

Re: [PATCH 11/40] drm/amd/display/dc/dce120/dce120_timing_generator:

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_generator.c:101:6: > warning: no previous prototype for ‘dce120_timing_generator_validate_timing’ > [-Wmissing-prototypes]

Re: [PATCH 10/40] drm/amd/display/dc/dce120/dce120_hw_sequencer: Encompass defines in same clause as their use

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote: > > Ideally someone should strip-out all these garbage 'if 0's. > > Tempted to carry out the work myself on principle! > > Fixes the following W=1 kernel build warning(s): > >

Re: [PATCH 09/40] drm/amd/display/dc/gpio/diagnostics/hw_factory_diag: Include our own header containing prototypes

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.c:50:6: > warning: no previous prototype for ‘dal_hw_factory_diag_fpga_init’ > [-Wmissing-prototypes] > > Cc:

Re: [PATCH 08/40] drm/amd/display/dc/gpio/diagnostics/hw_factory_diag: Fix struct declared inside parameter list error

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_diag.h:30:43: > warning: ‘struct hw_factory’ declared inside parameter list will not be > visible outside of this

Re: [PATCH 07/40] drm/amd/display/dc/irq/irq_service: Make local function static

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/irq/irq_service.c:82:31: warning: > no previous prototype for ‘find_irq_source_info’ [-Wmissing-prototypes] > > Cc: Harry Wentland > Cc: Leo Li >

Re: [PATCH 06/40] drm/amd/display/dc/gpio/diagnostics/hw_translate_diag: Include our own header containing prototypes

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_translate_diag.c:37:6: > warning: no previous prototype for ‘dal_hw_translate_diag_fpga_init’ > [-Wmissing-prototypes] > >

Re: [PATCH 05/40] drm/amd/display/dc/dce/dce_transform: Demote kernel-doc abuse

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote: > > The header doesn't provide any additional parameter descriptions. > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.c:1104: warning: > Cannot understand >

Re: [PATCH 04/40] drm/amd/display/dc/dce/dce_opp: Demote non-compliant kernel-doc headers

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:109: warning: > Function parameter or member 'opp110' not described in 'set_truncation' >

Re: [PATCH 02/40] drm/amd/display/dc/dce/dce_link_encoder: Remove unused variable 'value0'

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_link_encoder.c: In function > ‘dce110_link_encoder_update_mst_stream_allocation_table’: >

Re: [PATCH 01/40] drm/amd/display/dc/dce/dce_aux: Mark 'dce_aux_transfer_raw' as __maybe_unused

2021-01-12 Thread Alex Deucher
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c: In function > ‘dce_aux_transfer_raw’: > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c:579:7: warning: > variable

Re: [PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static

2021-01-12 Thread Alex Deucher
On Tue, Jan 12, 2021 at 3:23 PM Souptick Joarder wrote: > > kernel test robot throws below warnings -> > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6: > warning: no previous prototype for 'vangogh_clk_dpm_is_enabled' > [-Wmissing-prototypes] >

Re: [PATCH 1/1] drm/amdgpu: Remove unused variable

2021-01-12 Thread Alex Deucher
On Tue, Jan 12, 2021 at 12:46 PM Nirmoy Das wrote: > > Remove unused space_needed variable. > > Fixes: 453f617a30a ("drm/amdgpu: Resize BAR0 to the maximum available size, > even if it doesn't cover VRAM") > Signed-off-by: Nirmoy Das Reviewed-by: Alex Deucher > --- >

Re: [PATCH V5 0/3] Decouple config data for configfs

2021-01-12 Thread Melissa Wen
On 01/12, Sumera Priyadarsini wrote: > This patchset aims to lay down some prep work before configfs can be > implemented for the vkms driver. The first patch in the series adds a > new type vkms_config to track device configuration. The second and third > patch add module testing support for

Re: [PATCH v7 00/17] follow_pfn and other iomap races

2021-01-12 Thread Stephen Rothwell
Hi Daniel, On Tue, 12 Jan 2021 14:24:27 +0100 Daniel Vetter wrote: > > As Jason suggested, I've pulled the first 1 patches into a topic branch. > > Stephen, can you please add the below to linux-next for the 5.12 merge > window? > > git://anongit.freedesktop.org/drm/drm

Reboot crash at msm_atomic_commit_tail

2021-01-12 Thread Fabio Estevam
Hi, I have noticed that on an imx53-qsb, it is no longer possible to reboot the system as it fails like this: Requesting system reboot [ 23.819116] cfg80211: failed to load regulatory.db [ 23.827569] imx-sdma 63fb.sdma: external firmware not found, using ROM firmware [ 23.956838]

Re: [PATCH] drm/bridge: ti-sn65dsi86: rename GPIO register bits

2021-01-12 Thread Uwe Kleine-König
On Mon, Jan 11, 2021 at 02:25:37PM -0800, Doug Anderson wrote: > Hi, > > On Mon, Jan 11, 2021 at 2:16 PM Doug Anderson wrote: > > > > Hi, > > > > On Thu, Dec 10, 2020 at 12:19 AM Shawn Guo wrote: > > > > > > From: Shawn Guo > > > > > > It renames GPIO register bits to drop 'SN_' prefix, so

[PATCH 5.11 regression fix] drm/ttm: fix combining __GFP_HIGHMEM and __GFP_DMA32 flag for DMA32 pools

2021-01-12 Thread Hans de Goede
GFP_TRANSHUGE_LIGHT includes __GFP_HIGHMEM and combining __GFP_HIGHMEM with __GFP_DMA32 is not allowed. So we must not set add GFP_TRANSHUGE_LIGHT to the gfp_flags when allocating pages from a dma32 pool. This fixes the following oops when using a driver which uses DMA32 pools such as the

RE: [PATCH v16 0/4] RDMA: Add dma-buf support

2021-01-12 Thread Xiong, Jianxin
-Original Message- > From: Yishai Hadas > Sent: Tuesday, January 12, 2021 4:49 AM > To: Xiong, Jianxin ; Alex Deucher > > Cc: Jason Gunthorpe ; Leon Romanovsky ; > linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org; > Doug Ledford ; Vetter, Daniel ; > Christian Koenig ;

[PULL] drm-intel-next

2021-01-12 Thread Rodrigo Vivi
Hi Dave and Daniel, A very short collection of patches, mostly with display fixes. Plus GVT. The goal is to get both drm-intel-next and drm-intel-gt-next in sync again through drm-next backports so we can continue with ADL enabling in a topic branch. Please be aware that there's a drm only patch

Re: [PATCH] drm/i915/hdcp: Disable the QSES check for HDCP 1.4 over MST

2021-01-12 Thread Jani Nikula
Anshuman, please review. BR, Jani. On Wed, 06 Jan 2021, Sean Paul wrote: > From: Sean Paul > > The HDCP 1.4 spec does not require the QUERY_STREAM_ENCRYPTION_STATUS > check, it was always a nice-to-have. After deploying this across various > devices, we've determined that some MST bridge

[PATCH 1/1] drm/amdgpu: Remove unused variable

2021-01-12 Thread Nirmoy Das
Remove unused space_needed variable. Fixes: 453f617a30a ("drm/amdgpu: Resize BAR0 to the maximum available size, even if it doesn't cover VRAM") Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: omapfb removal (was: Re: [PATCHv1] video: omapfb2: Make standard and custom DSI command mode panel driver mutually exclusive)

2021-01-12 Thread Laurent Pinchart
Hi Sebastian, On Tue, Jan 12, 2021 at 05:24:54PM +0100, Sebastian Reichel wrote: > [dropped linux-next from Cc] > > Hi, > > On Tue, Jan 12, 2021 at 03:10:56PM +0200, Tomi Valkeinen wrote: > > >> But why is it it we need omapfb at all when we have omapdrm? > > > > > > I think there are two

Re: [PATCH 3/4] drm: Extend color correction to support 3D-CLU

2021-01-12 Thread Ville Syrjälä
On Mon, Dec 21, 2020 at 03:57:29AM +0200, Laurent Pinchart wrote: > From: Kieran Bingham > > Extend the existing color management properties to support provision > of a 3D cubic look up table, allowing for color specific adjustments. > > Signed-off-by: Kieran Bingham > Co-developed-by: Laurent

Re: [PATCH v3 01/12] drm: Add dummy page per device or GEM object

2021-01-12 Thread Andrey Grodzovsky
On 1/12/21 7:32 AM, Christian König wrote: Am 12.01.21 um 10:10 schrieb Daniel Vetter: On Mon, Jan 11, 2021 at 03:45:10PM -0500, Andrey Grodzovsky wrote: On 1/11/21 11:15 AM, Daniel Vetter wrote: On Mon, Jan 11, 2021 at 05:13:56PM +0100, Daniel Vetter wrote: On Fri, Jan 08, 2021 at

Re: fbcon: remove soft scrollback code (missing Doc. patch)

2021-01-12 Thread Daniel Vetter
On Sat, Jan 9, 2021 at 12:11 AM Linus Torvalds wrote: > > On Fri, Jan 8, 2021 at 11:13 AM Phillip Susi wrote: > > > > > Could we pause this madness? Scrollback is still useful. I needed it > > > today... it was too small, so command results I was looking for > > > already scrolled away, but...

Re: [PATCH v3 01/12] drm: Add dummy page per device or GEM object

2021-01-12 Thread Andrey Grodzovsky
So - basically allocate the page and pass it as void* pointer to drmm_add_action with a release function which will do the free page, right ? Andrey On 1/12/21 4:10 AM, Daniel Vetter wrote: drm_add_action_or_reset (for better control flow) has both a void * data and a cleanup function (and it

Re: [PATCH v8 1/4] dt-bindings: display: Document the Xylon LogiCVC display controller

2021-01-12 Thread Rob Herring
On Wed, Dec 23, 2020 at 10:29:44PM +0100, Paul Kocialkowski wrote: > The Xylon LogiCVC is a display controller implemented as programmable > logic in Xilinx FPGAs. > > Signed-off-by: Paul Kocialkowski > Acked-by: Rob Herring > --- > .../display/xylon,logicvc-display.yaml| 313

Re: [PATCH v9 1/4] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183

2021-01-12 Thread Rob Herring
On Fri, Jan 08, 2021 at 09:10:08AM +0800, Nicolas Boichat wrote: > Define a compatible string for the Mali Bifrost GPU found in > Mediatek's MT8183 SoCs. > > Signed-off-by: Nicolas Boichat > Reviewed-by: Alyssa Rosenzweig > --- > > (no changes since v6) > > Changes in v6: > - Rebased,

Re: [PATCH v2 0/4] Revert "drm/amd/display: Expose new CRC window property" and changes associated with this commit

2021-01-12 Thread Alex Deucher
On Tue, Jan 12, 2021 at 9:55 AM Rodrigo Siqueira wrote: > > Hi, > > In the V1, Wayne pointed out two problems: > > 1. The revert patch included one extra line that does not belong to it; > 2. The original patch also had other fixes in the same commit; > > I removed the extra line from the

[PATCH v2 4/4] drm/amd/display: Fix to be able to stop crc calculation

2021-01-12 Thread Rodrigo Siqueira
From: Wayne Lin [Why] Find out when we try to disable CRC calculation, crc generation is still enabled. Main reason is that dc_stream_configure_crc() will never get called when the source is AMDGPU_DM_PIPE_CRC_SOURCE_NONE. [How] Add checking condition that when source is

[PATCH v2 3/4] Revert "drm/amd/display: Expose new CRC window property"

2021-01-12 Thread Rodrigo Siqueira
This reverts commit 110d586ba77ed573eb7464ca69b6490ec0b70c5f. Cc: Wayne Lin Cc: Alexander Deucher Cc: Harry Wentland Cc: Roman Li Cc: Bindu R Cc: Daniel Vetter Signed-off-by: Rodrigo Siqueira --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 142 +-

[PATCH v2 2/4] Revert "drm/amdgpu/disply: fix documentation warnings in display manager"

2021-01-12 Thread Rodrigo Siqueira
This reverts commit 1206904465c8a9eebff9ca5a65effc8cf8f3cb84. Cc: Wayne Lin Cc: Alexander Deucher Cc: Harry Wentland Cc: Roman Li Cc: Bindu R Cc: Daniel Vetter Signed-off-by: Rodrigo Siqueira --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 21 +-- 1 file changed, 1

[PATCH v2 1/4] Revert "drm/amd/display: Fix unused variable warning"

2021-01-12 Thread Rodrigo Siqueira
This reverts commit b5d8f1d02ba7021cad1bd5ad8460ce5611c479d8. Cc: Wayne Lin Cc: Alexander Deucher Cc: Harry Wentland Cc: Roman Li Cc: Bindu R Cc: Daniel Vetter Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +++-

[PATCH v2 0/4] Revert "drm/amd/display: Expose new CRC window property" and changes associated with this commit

2021-01-12 Thread Rodrigo Siqueira
Hi, In the V1, Wayne pointed out two problems: 1. The revert patch included one extra line that does not belong to it; 2. The original patch also had other fixes in the same commit; I removed the extra line from the reverted patch for tackling this issue, and I added one additional patch to

Re: [PATCH v9, 01/11] dt-bindings: mediatek: add rdma-fifo-size description for mt8183 display

2021-01-12 Thread Rob Herring
On Thu, 07 Jan 2021 11:11:11 +0800, Yongqiang Niu wrote: > rdma fifo size may be different even in same SOC, add this > property to the corresponding rdma > > Signed-off-by: Yongqiang Niu > --- > .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 9 > + > 1 file

RE: [PATCH 1/2] drm: distinguish return value of drm_dp_check_and_send_link_address.

2021-01-12 Thread Simon Ser
Pushed to drm-misc-next with a re-formatted commit message, thanks for your contribution! ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [RFC PATCH 098/162] drm/i915/gtt: map the PD up front

2021-01-12 Thread Daniel Vetter
On Tue, Jan 12, 2021 at 10:47:57AM +, Matthew Auld wrote: > On Fri, 27 Nov 2020 at 13:32, Chris Wilson wrote: > > > > Quoting Matthew Auld (2020-11-27 12:06:14) > > > We need to general our accessor for the page directories and tables from > > > using the simple kmap_atomic to support local

Re: [PATCH] drm: Improve the output_poll_changed description

2021-01-12 Thread Daniel Vetter
On Tue, Jan 12, 2021 at 06:46:44PM +0800, ZhiJie.Zhang wrote: > From: zhangzhijie > > codeview the implementation of few Drivers. I'm not really understanding what you're trying to say here. > this callback was used by drm_kms_helper_hotplug_event() > > Signed-off-by: zhangzhijie > --- >

Re: [PATCH v4 04/13] drm/shmem-helper: Provide a vmap function for short-term mappings

2021-01-12 Thread Daniel Vetter
On Tue, Jan 12, 2021 at 02:11:24PM +0100, Thomas Zimmermann wrote: > Hi > > Am 11.01.21 um 17:50 schrieb Daniel Vetter: > > On Fri, Jan 08, 2021 at 10:43:31AM +0100, Thomas Zimmermann wrote: > > > Implementations of the vmap/vunmap GEM callbacks may perform pinning > > > of the BO and may acquire

Re: [PATCH] drm/ttm: make the pool shrinker lock a mutex

2021-01-12 Thread Daniel Vetter
On Tue, Jan 12, 2021 at 3:06 PM Christian König wrote: > > Am 12.01.21 um 15:03 schrieb Daniel Vetter: > > On Mon, Jan 11, 2021 at 2:57 PM Christian König > > wrote: > >> set_pages_wb() might sleep and so we can't do this in an atomic context. > >> > >> Signed-off-by: Christian König > >>

Re: [PATCH] drm/ttm: make the pool shrinker lock a mutex

2021-01-12 Thread Christian König
Am 12.01.21 um 15:03 schrieb Daniel Vetter: On Mon, Jan 11, 2021 at 2:57 PM Christian König wrote: set_pages_wb() might sleep and so we can't do this in an atomic context. Signed-off-by: Christian König Reported-by: Mikhail Gavrilov Fixes: d099fc8f540a ("drm/ttm: new TT backend allocation

Re: [PATCH] drm/ttm: make the pool shrinker lock a mutex

2021-01-12 Thread Daniel Vetter
On Mon, Jan 11, 2021 at 2:57 PM Christian König wrote: > > set_pages_wb() might sleep and so we can't do this in an atomic context. > > Signed-off-by: Christian König > Reported-by: Mikhail Gavrilov > Fixes: d099fc8f540a ("drm/ttm: new TT backend allocation pool v3") Hm I guess long term

Re: [PATCH 1/6] drm: Inline AGP wrappers into their only callers

2021-01-12 Thread Daniel Vetter
On Tue, Jan 12, 2021 at 10:56 AM Thomas Zimmermann wrote: > > Hi > > Am 12.01.21 um 09:59 schrieb Daniel Vetter: > > On Tue, Jan 12, 2021 at 09:10:30AM +0100, Thomas Zimmermann wrote: > >> The AGP wrapper functions serve no purpose. > >> > >> Signed-off-by: Thomas Zimmermann > > > > They do,

Re: [PATCH 13/40] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap

2021-01-12 Thread Lee Jones
On Mon, 11 Jan 2021, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function > ‘calculate_bandwidth’: > drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2016:1: warning: > the frame size of 1216

Re: [PATCH 14/40] drm/amd/display/dc/calcs/dce_calcs: Remove some large variables from the stack

2021-01-12 Thread Lee Jones
On Mon, 11 Jan 2021, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function > ‘bw_calcs_init’: > drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2726:1: warning: > the frame size of 1336 bytes

Re: [PATCH v7 00/17] follow_pfn and other iomap races

2021-01-12 Thread Daniel Vetter
On Tue, Jan 12, 2021 at 2:24 PM Daniel Vetter wrote: > > On Fri, Nov 27, 2020 at 05:41:14PM +0100, Daniel Vetter wrote: > > Hi all > > > > Another update of my patch series to clamp down a bunch of races and gaps > > around follow_pfn and other access to iomem mmaps. Previous version: > > > > v1:

Re: [PATCH v7 00/17] follow_pfn and other iomap races

2021-01-12 Thread Daniel Vetter
On Fri, Nov 27, 2020 at 05:41:14PM +0100, Daniel Vetter wrote: > Hi all > > Another update of my patch series to clamp down a bunch of races and gaps > around follow_pfn and other access to iomem mmaps. Previous version: > > v1: >

[PULL] drm-misc-fixes

2021-01-12 Thread Thomas Zimmermann
Hi Dave and Daniel, here's this week's PR for drm-misc-fixes. Best regards Thomas drm-misc-fixes-2021-01-12: * dma-buf: Fix a memory leak in CMAV heap * drm: Fix format check for legacy pageflips * ttm: Pass correct address to dma_mapping_error(); Use mutex in pool shrinker The following

Re: [PATCHv1] video: omapfb2: Make standard and custom DSI command mode panel driver mutually exclusive

2021-01-12 Thread Tomi Valkeinen
Hi, On 12/01/2021 14:02, Sebastian Reichel wrote: > [replace Tomi's TI mail address with something working] > > Hi, > > On Fri, Jan 08, 2021 at 08:58:39PM +0100, Sam Ravnborg wrote: >> Hi Sebastian, >> >> On Fri, Jan 08, 2021 at 12:24:41PM +0100, Sebastian Reichel wrote: >>> Standard DRM panel

Re: [PATCH v4 04/13] drm/shmem-helper: Provide a vmap function for short-term mappings

2021-01-12 Thread Thomas Zimmermann
Hi Am 11.01.21 um 17:50 schrieb Daniel Vetter: On Fri, Jan 08, 2021 at 10:43:31AM +0100, Thomas Zimmermann wrote: Implementations of the vmap/vunmap GEM callbacks may perform pinning of the BO and may acquire the associated reservation object's lock. Callers that only require a mapping of the

[PATCH AUTOSEL 4.19 15/16] drm/msm: Call msm_init_vram before binding the gpu

2021-01-12 Thread Sasha Levin
From: Craig Tatlor [ Upstream commit d863f0c7b536288e2bd40cbc01c10465dd226b11 ] vram.size is needed when binding a gpu without an iommu and is defined in msm_init_vram(), so run that before binding it. Signed-off-by: Craig Tatlor Reviewed-by: Brian Masney Tested-by: Alexey Minnekhanov

[PATCH AUTOSEL 5.4 27/28] drm/msm: Call msm_init_vram before binding the gpu

2021-01-12 Thread Sasha Levin
From: Craig Tatlor [ Upstream commit d863f0c7b536288e2bd40cbc01c10465dd226b11 ] vram.size is needed when binding a gpu without an iommu and is defined in msm_init_vram(), so run that before binding it. Signed-off-by: Craig Tatlor Reviewed-by: Brian Masney Tested-by: Alexey Minnekhanov

[PATCH AUTOSEL 5.4 24/28] drm/amdgpu: fix a GPU hang issue when remove device

2021-01-12 Thread Sasha Levin
From: Dennis Li [ Upstream commit 88e21af1b3f887d217f2fb14fc7e7d3cd87ebf57 ] When GFXOFF is enabled and GPU is idle, driver will fail to access some registers. Therefore change to disable power gating before all access registers with MMIO. Dmesg log is as following: amdgpu :03:00.0:

[PATCH AUTOSEL 5.10 49/51] drm/msm: Call msm_init_vram before binding the gpu

2021-01-12 Thread Sasha Levin
From: Craig Tatlor [ Upstream commit d863f0c7b536288e2bd40cbc01c10465dd226b11 ] vram.size is needed when binding a gpu without an iommu and is defined in msm_init_vram(), so run that before binding it. Signed-off-by: Craig Tatlor Reviewed-by: Brian Masney Tested-by: Alexey Minnekhanov

[PATCH AUTOSEL 5.10 43/51] drm/amd/pm: fix the failure when change power profile for renoir

2021-01-12 Thread Sasha Levin
From: Xiaojian Du [ Upstream commit 44cb39e19a05ca711bcb6e776e0a4399223204a0 ] This patch is to fix the failure when change power profile to "profile_peak" for renoir. Signed-off-by: Xiaojian Du Reviewed-by: Huang Rui Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

  1   2   >