[Bug 210683] Nasty amdgpu powersave regression Navi14

2021-01-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210683 siyia (eutychio...@gmail.com) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH v2 4/5] dt-bindings: dt-bindings: display: simple: Add N116BCA-EA1

2021-01-15 Thread Doug Anderson
Hi, On Fri, Jan 15, 2021 at 2:44 PM Douglas Anderson wrote: > > Another simple eDP panel. > > Signed-off-by: Douglas Anderson > --- > > Changes in v2: > - ("dt-bindings: dt-bindings: display: simple: Add N116BCA-EA1") new for v2. > > .../devicetree/bindings/display/panel/panel-simple.yaml

[PATCH v2 4/5] dt-bindings: dt-bindings: display: simple: Add N116BCA-EA1

2021-01-15 Thread Douglas Anderson
Another simple eDP panel. Signed-off-by: Douglas Anderson --- Changes in v2: - ("dt-bindings: dt-bindings: display: simple: Add N116BCA-EA1") new for v2. .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v2 5/5] drm/panel-simple: Add N116BCA-EA1

2021-01-15 Thread Douglas Anderson
This panel is quite similar to the similarly named N116BGE panel (the nominal timings are, in fact identical). However, let's add a new entry because the full range of clocks listed for N116BGE aren't supported for N116BCA-EA1, at least according to the datasheet. Signed-off-by: Douglas Anderson

[PATCH v2 2/5] drm/panel-simple: Don't wait longer for HPD than hpd_absent_delay

2021-01-15 Thread Douglas Anderson
If a panel has an hpd_absent_delay specified then we know exactly how long the maximum time is before HPD must be asserted. That means we can use it as a timeout for polling the HPD pin instead of using an arbitrary timeout. This is especially useful for dealing with panels that periodically

[PATCH v2 3/5] drm/panel-simple: Retry if we timeout waiting for HPD

2021-01-15 Thread Douglas Anderson
On an Innolux N116BCA panel that I have in front of me, sometimes HPD simply doesn't assert no matter how long you wait for it. As per the very wise advice of The IT Crowd ("Have you tried turning it off and on again?") it appears that power cycling is enough to kick this panel back into a sane

[PATCH v2 1/5] drm/panel-simple: Undo enable if HPD never asserts

2021-01-15 Thread Douglas Anderson
If the HPD signal never asserts in panel_simple_prepare() and we return an error, we should unset the enable GPIO and disable the regulator to make it consistent for the caller. At the moment I have some hardware where HPD sometimes doesn't assert. Obviously that needs to be debugged, but this

[PATCH v2 0/5] drm/panel-simple: Patches for N116BCA-EA1

2021-01-15 Thread Douglas Anderson
This series is to get the N116BCA-EA1 panel working. Most of the patches are simple, but on hardware I have in front of me the panel sometimes doesn't come up. I'm still working with the hardware manufacturer to get to the bottom of it, but I've got it working with retries. Adding the retries

Re: [PATCH v3 2/2] drm/drm_vblank: set the dma-fence timestamp during send_vblank_event

2021-01-15 Thread John Stultz
On Thu, Jan 14, 2021 at 12:54 PM wrote: > > On 2021-01-13 18:28, John Stultz wrote: > > On Wed, Jan 13, 2021 at 11:52 AM Veera Sundaram Sankaran > > wrote: > >> > >> The explicit out-fences in crtc are signaled as part of vblank event, > >> indicating all framebuffers present on the Atomic

Re: [PATCH v2 1/7] dt-bindings: display: mxsfb: Convert binding to YAML

2021-01-15 Thread Laurent Pinchart
Hi Martin, On Fri, Jan 15, 2021 at 08:59:18AM +0100, Martin Kepplinger wrote: > hi Laurent, > > Do you mind me adding a DT property in the old format now? If so, I'd > appreciated an ack in this thread: > https://lore.kernel.org/linux-arm-kernel/20201201134638.ga305...@bogon.m.sigxcpu.org/ > >

[PATCH v3 3/3] dt-bindings: display: mxsfb: Add compatible for i.MX8MM

2021-01-15 Thread Laurent Pinchart
From: Marek Vasut NXP's i.MX8MM has an LCDIF as well. Signed-off-by: Marek Vasut Reviewed-by: Laurent Pinchart Signed-off-by: Laurent Pinchart --- Changes since v1: - Rebased on top of the YAML conversion Cc: Fabio Estevam Cc: Guido Günther Cc: Lucas Stach Cc: NXP Linux Team Cc: Rob

[PATCH v3 2/3] dt-bindings: display: mxsfb: Add and fix compatible strings

2021-01-15 Thread Laurent Pinchart
Additional compatible strings have been added in DT source for the i.MX6SL, i.MX6SLL, i.MX6UL and i.MX7D without updating the bindings. Most of the upstream DT sources use the fsl,imx28-lcdif compatible string, which mostly predates the realization that the LCDIF in the i.MX6 and newer SoCs have

[PATCH v3 1/3] dt-bindings: display: mxsfb: Convert binding to YAML

2021-01-15 Thread Laurent Pinchart
Convert the mxsfb binding to YAML. The deprecated binding is dropped, as neither the DT sources nor the driver support it anymore. The converted binding is named fsl,lcdif.yaml to match the usual bindings naming scheme. The compatible strings are messy, and DT sources use different kinds of

[PATCH v3 0/3] dt-bindings: display: Convert mxsfb DT bindings to YAML

2021-01-15 Thread Laurent Pinchart
Hello, This patch series has previously been posted as part of "[PATCH v2 0/7] drm: mxsfb: Allow overriding bus width". I've split the DT bindings conversion to a separate series as I believe they're ready, and Martin has a patch that he would like to submit to the bindings. All the patches have

Re: [PATCH 10/10] drm: Use state helper instead of the plane state pointer

2021-01-15 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Fri, Jan 15, 2021 at 01:57:02PM +0100, Maxime Ripard wrote: > Many drivers reference the plane->state pointer in order to get the > current plane state in their atomic_update or atomic_disable hooks, Please don't use the word "current", it's ambiguous. Do

Re: [PATCH 09/10] drm/atomic: Pass the full state to planes atomic disable and update

2021-01-15 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Fri, Jan 15, 2021 at 01:57:01PM +0100, Maxime Ripard wrote: > The current atomic helpers have either their object state being passed as > an argument or the full atomic state. > > The former is the pattern that was done at first, before switching to the >

Re: [PATCH][next] drm/vkms: Fix missing kmalloc allocation failure check

2021-01-15 Thread Melissa Wen
On 01/15, Sumera Priyadarsini wrote: > On Fri, Jan 15, 2021 at 6:39 PM Colin King wrote: > > > > From: Colin Ian King > > > > Currently the kmalloc allocation for config is not being null > > checked and could potentially lead to a null pointer dereference. > > Fix this by adding the missing

Re: [PATCH 07/10] drm: Store new plane state in a variable for atomic_update and disable

2021-01-15 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Fri, Jan 15, 2021 at 01:56:59PM +0100, Maxime Ripard wrote: > In order to store the new plane state in a subsequent helper, let's move > the plane->state dereferences into a variable. > > This was done using the following coccinelle script, plus some hand

Re: [PATCH 03/10] drm/atmel-hlcdc: Rename custom plane state variable

2021-01-15 Thread Sam Ravnborg
On Fri, Jan 15, 2021 at 01:56:55PM +0100, Maxime Ripard wrote: > Subsequent reworks will pass the global atomic state in the function > prototype, and atomic_check and atomic_update already have such a > variable already. Let's change them to ease the rework. > > Signed-off-by: Maxime Ripard

Re: [PATCH 05/10] drm: Use the state pointer directly in planes atomic_check

2021-01-15 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Fri, Jan 15, 2021 at 01:56:57PM +0100, Maxime Ripard wrote: > Now that atomic_check takes the global atomic state as a parameter, we > don't need to go through the pointer in the plane state. > > This was done using the following coccinelle script: > > @

Re: [PATCH 04/10] drm/atomic: Pass the full state to planes atomic_check

2021-01-15 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Fri, Jan 15, 2021 at 01:56:56PM +0100, Maxime Ripard wrote: > The current atomic helpers have either their object state being passed as > an argument or the full atomic state. > > The former is the pattern that was done at first, before switching to the >

Re: [PATCH 02/10] drm: Rename plane atomic_check state names

2021-01-15 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Fri, Jan 15, 2021 at 01:56:54PM +0100, Maxime Ripard wrote: > Most drivers call the argument to the plane atomic_check hook simply > state, which is going to conflict with the global atomic state in a > later rework. Let's rename it to new_plane_state (or

Re: [Intel-gfx] [PATCH] drm-buf: Add debug option

2021-01-15 Thread John Stultz
On Thu, Jan 14, 2021 at 1:03 AM Daniel Vetter wrote: > > On Wed, Jan 13, 2021 at 10:08 PM Chris Wilson > wrote: > > Quoting Daniel Vetter (2021-01-13 20:50:11) > > > On Wed, Jan 13, 2021 at 4:43 PM Chris Wilson > > > wrote: > > > > > > > > Quoting Daniel Vetter (2021-01-13 14:06:04) > > > > >

Re: [git pull] drm nouveau ampere modesetting support

2021-01-15 Thread pr-tracker-bot
The pull request you sent on Fri, 15 Jan 2021 14:56:04 +1000: > git://anongit.freedesktop.org/drm/drm > tags/topic/nouveau-ampere-modeset-2021-01-15 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/02c06dc3750be486e143cd553c13f02978e39b14 Thank you! --

Re: [PATCH] dma-buf: Add debug option

2021-01-15 Thread Christian König
Am 15.01.21 um 17:47 schrieb Daniel Vetter: We have too many people abusing the struct page they can get at but really shouldn't in importers. Aside from that the backing page might simply not exist (for dynamic p2p mappings) looking at it and using it e.g. for mmap can also wreak the page

Re: [PATCH RFC] drm/vc4: hdmi: Avoid ASoC error messages on startup

2021-01-15 Thread Mark Brown
On Fri, Jan 15, 2021 at 07:14:37PM +0100, Maxime Ripard wrote: > On Wed, Jan 13, 2021 at 11:42:23AM +, Mark Brown wrote: > > On Wed, Jan 13, 2021 at 10:19:57AM +0100, Maxime Ripard wrote: > > > I'd like to get Mark's opinion before merging though > > I'm not sure what the question is here?

Re: [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!

2021-01-15 Thread Zack Rusin
> On Jan 15, 2021, at 13:15, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Last set! All clean after this for; Arm, Arm64, PPC, MIPS and x86. Thanks! For all

Re: [PATCH] drm/amdgpu:this forword declear maybe not used

2021-01-15 Thread Alex Deucher
On Fri, Jan 15, 2021 at 3:55 AM ZhiJie.Zhang wrote: > > Signed-off-by: ZhiJie.Zhang Applied with a cleaned up commit message. Thanks! Alex > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git

Re: [PATCH 00/40] [Set 14] Rid W=1 warnings from GPU

2021-01-15 Thread Zack Rusin
> On Jan 15, 2021, at 13:12, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Penultimate set, promise. :) Thank you for all that work. For all the vmwgfx bits:

[PATCH 28/29] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or member 'filp' not described in 'nouveau_compat_ioctl' drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or member 'cmd' not described in

[PATCH 23/29] drm/drm_agpsupport: Strip out obviously wrong descriptions and demote to standard headers

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/drm_agpsupport.c:61: warning: Function parameter or member 'dev' not described in 'drm_agp_info' drivers/gpu/drm/drm_agpsupport.c:61: warning: Function parameter or member 'info' not described in 'drm_agp_info'

[PATCH 27/29] drm/nouveau/nouveau_bios: Remove unused variable 'pdev' from 'nouveau_bios_init()'

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_bios.c: In function ‘nouveau_bios_init’: drivers/gpu/drm/nouveau/nouveau_bios.c:2086:18: warning: variable ‘pdev’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter

[PATCH 29/29] drm/vmwgfx/ttm_object: Reorder header to immediately precede its struct

2021-01-15 Thread Lee Jones
Also add missing description for 'refcount' Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/ttm_object.c:60: error: Cannot parse struct or union! Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc:

[PATCH 19/29] drm/gma500/oaktrail_lvds: Demote one documentation header fix another

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/oaktrail_lvds.c:38: warning: Function parameter or member 'dev' not described in 'oaktrail_lvds_set_power' drivers/gpu/drm/gma500/oaktrail_lvds.c:38: warning: Function parameter or member 'gma_encoder' not described in

[PATCH 22/29] drm/gma500/mdfld_intel_display: Demote three kernel-doc formatting abuses

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/mdfld_intel_display.c:103: warning: Function parameter or member 'dev' not described in 'psb_intel_panel_fitter_pipe' drivers/gpu/drm/gma500/mdfld_intel_display.c:273: warning: Function parameter or member 'crtc' not

[PATCH 25/29] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_ioc32.c:2: warning: Cannot understand * file mga_ioc32.c Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Signed-off-by: Lee Jones ---

[PATCH 26/29] drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void function

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_svm.c: In function ‘nouveau_pfns_map’: drivers/gpu/drm/nouveau/nouveau_svm.c:810:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc:

[PATCH 15/29] drm/gma500/cdv_intel_display: Demote kernel-doc abuse in 'cdv_intel_panel_fitter_pipe()'s header

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/cdv_intel_display.c:559: warning: Function parameter or member 'dev' not described in 'cdv_intel_panel_fitter_pipe' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Eric Anholt Cc:

[PATCH 24/29] drm/i915/gvt/handlers: Remove kernel-doc formatting from non-kernel-doc header

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gvt/handlers.c:1666: warning: Function parameter or member 'vgpu' not described in 'bxt_ppat_low_write' drivers/gpu/drm/i915/gvt/handlers.c:1666: warning: Function parameter or member 'offset' not described in

[PATCH 18/29] drm/gma500/oaktrail_lvds_i2c: Remove unused variables 'tmp'

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function ‘get_clock’: drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c:69:11: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function

[PATCH 14/29] drm/gma500/cdv_intel_crt: Demote kernel-doc abuse in 'cdv_intel_crt_detect_hotplug()'s header

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/cdv_intel_crt.c:138: warning: Function parameter or member 'connector' not described in 'cdv_intel_crt_detect_hotplug' drivers/gpu/drm/gma500/cdv_intel_crt.c:138: warning: Function parameter or member 'force' not

[PATCH 16/29] drm/gma500/cdv_intel_lvds: Demote unworthy headers to standard blocks and fix another

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/cdv_intel_lvds.c:83: warning: Function parameter or member 'dev' not described in 'cdv_intel_lvds_set_backlight' drivers/gpu/drm/gma500/cdv_intel_lvds.c:83: warning: Function parameter or member 'level' not described in

[PATCH 17/29] drm/gma500/cdv_intel_dp: Demote one unworthy header fix another

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/cdv_intel_dp.c:315: warning: Function parameter or member 'encoder' not described in 'is_edp' drivers/gpu/drm/gma500/cdv_intel_dp.c:315: warning: Excess function parameter 'intel_dp' description in 'is_edp'

[PATCH 20/29] drm/gma500/oaktrail_crtc: Demote unworthy kernel-doc headers

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/oaktrail_crtc.c:184: warning: Function parameter or member 'limit' not described in 'mrst_lvds_find_best_pll' drivers/gpu/drm/gma500/oaktrail_crtc.c:184: warning: Function parameter or member 'crtc' not described in

[PATCH 21/29] drm/gma500/mdfld_dsi_output: Demote a couple of kernel-doc formatting abuses

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/mdfld_dsi_output.c:71: warning: Function parameter or member 'dev' not described in 'mdfld_dsi_gen_fifo_ready' drivers/gpu/drm/gma500/mdfld_dsi_output.c:71: warning: Function parameter or member 'gen_fifo_stat_reg' not

[PATCH 12/29] drm/gma500/psb_irq: Demote kernel-doc abuse

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/psb_irq.c:134: warning: Function parameter or member 'dev' not described in 'mid_pipe_event_handler' drivers/gpu/drm/gma500/psb_irq.c:134: warning: Function parameter or member 'pipe' not described in

[PATCH 13/29] drm/drm_dp_helper: Fix spelling issue and add missing description for 'enable_frl_ready_hpd'

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/drm_dp_helper.c:965: warning: Function parameter or member 'color_spc' not described in 'drm_dp_downstream_rgb_to_ycbcr_conversion' drivers/gpu/drm/drm_dp_helper.c:965: warning: Excess function parameter 'colorspc' description

[PATCH 11/29] drm/gma500/psb_intel_sdvo: Demote kernel-doc abuses

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/psb_intel_sdvo.c:230: warning: Function parameter or member 'psb_intel_sdvo' not described in 'psb_intel_sdvo_write_sdvox' drivers/gpu/drm/gma500/psb_intel_sdvo.c:230: warning: Function parameter or member 'val' not

[PATCH 10/29] drm/vmwgfx/vmwgfx_thp: Add description for 'vmw_thp_manager's member 'manager'

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_thp.c:21: warning: Function parameter or member 'manager' not described in 'vmw_thp_manager' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc:

[PATCH 06/29] drm/gma500/mmu: Actually return an error if one occurs

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/mmu.c: In function ‘psb_mmu_insert_pfn_sequence’: drivers/gpu/drm/gma500/mmu.c:651:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc:

[PATCH 07/29] drm/vmwgfx/vmwgfx_blit: Add description for 'vmw_bo_cpu_blit's 'diff' param

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:452: warning: Function parameter or member 'diff' not described in 'vmw_bo_cpu_blit' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc:

[PATCH 09/29] drm/vmwgfx/ttm_object: Demote half-assed headers and fix-up another

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/ttm_object.c:60: error: Cannot parse struct or union! drivers/gpu/drm/vmwgfx/ttm_object.c:97: warning: Function parameter or member 'mem_glob' not described in 'ttm_object_device' drivers/gpu/drm/vmwgfx/ttm_object.c:97:

[PATCH 08/29] drm/vmwgfx/vmwgfx_validation: Add some missing struct member/function param descriptions

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:85: warning: Function parameter or member 'dirty' not described in 'vmw_validation_res_node' drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:85: warning: Function parameter or member 'dirty_set' not

[PATCH 05/29] drm/vmwgfx/vmwgfx_msg: Fix misspelling of 'msg'

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_msg.c:261: warning: Function parameter or member 'msg' not described in 'vmw_send_msg' drivers/gpu/drm/vmwgfx/vmwgfx_msg.c:261: warning: Excess function parameter 'logmsg' description in 'vmw_send_msg' Cc: VMware

[PATCH 02/29] drm/vmwgfx/vmwgfx_cotable: Fix a couple of simple documentation problems

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c:72: warning: Function parameter or member 'unbind_func' not described in 'vmw_cotable_info' drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c:308: warning: Function parameter or member 'val_buf' not described in

[PATCH 03/29] drm/vmwgfx/vmwgfx_so: Add description for 'vmw_view's 'rcu' member

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_so.c:73: warning: Function parameter or member 'rcu' not described in 'vmw_view' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org

[PATCH 04/29] drm/vmwgfx/vmwgfx_binding: Provide some missing param descriptions and remove others

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:340: warning: Function parameter or member 'shader_slot' not described in 'vmw_binding_add' drivers/gpu/drm/vmwgfx/vmwgfx_binding.c:340: warning: Function parameter or member 'slot' not described in

[PATCH 01/29] drm/vmwgfx/vmwgfx_cmdbuf: Fix misnaming of 'headers' should be plural

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:137: warning: Function parameter or member 'headers' not described in 'vmw_cmdbuf_man' Cc: VMware Graphics Cc: Roland Scheidegger Cc: Zack Rusin Cc: David Airlie Cc: Daniel Vetter Cc:

[PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!

2021-01-15 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Last set! All clean after this for; Arm, Arm64, PPC, MIPS and x86. Lee Jones (29): drm/vmwgfx/vmwgfx_cmdbuf: Fix misnaming of 'headers' should

[PATCH 39/40] drm/vmwgfx/vmwgfx_cmdbuf_res: Remove unused variable 'ret'

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c: In function ‘vmw_cmdbuf_res_revert’: drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c:162:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: VMware Graphics Cc: Roland Scheidegger

[PATCH 37/40] drm/vmwgfx/vmwgfx_cmdbuf: Fix a bunch of missing or incorrectly formatted/named params

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:58: warning: Function parameter or member 'block_submission' not described in 'vmw_cmdbuf_context' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:109: warning: cannot understand function prototype: 'struct

[PATCH 29/40] drm/vmwgfx/vmwgfx_scrn: Demote unworthy kernel-doc headers and update others

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:90: warning: cannot understand function prototype: 'struct vmw_screen_object_unit ' drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c:122: warning: Function parameter or member 'dev_priv' not described in

[PATCH 24/40] drm/gma500/psb_intel_display: Demote kernel-doc formatting abuse

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/psb_intel_display.c:79: warning: Function parameter or member 'dev' not described in 'psb_intel_panel_fitter_pipe' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Eric Anholt Cc:

[PATCH 28/40] drm/vmwgfx/vmwgfx_context: Demote kernel-doc abuses

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_context.c:121: warning: Function parameter or member 'dev_priv' not described in 'vmw_context_cotables_unref' drivers/gpu/drm/vmwgfx/vmwgfx_context.c:121: warning: Function parameter or member 'uctx' not described

[PATCH 35/40] drm/vmwgfx/vmwgfx_cmdbuf_res: Rename param description and remove another

2021-01-15 Thread Lee Jones
Also fix a small formatting issue. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c:83: warning: Function parameter or member 'res_type' not described in 'vmw_cmdbuf_res_lookup' drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c:83: warning: Excess function

[PATCH 34/40] drm/gma500/mmu: Remove unused function 'psb_get_default_pd_addr'

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/mmu.c:420:10: warning: no previous prototype for ‘psb_get_default_pd_addr’ [-Wmissing-prototypes] Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones ---

[PATCH 30/40] drm/gma500/psb_intel_modes: Provide missing descriptions for function param 'adapter'

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/psb_intel_modes.c:17: warning: Function parameter or member 'adapter' not described in 'psb_intel_ddc_probe' drivers/gpu/drm/gma500/psb_intel_modes.c:51: warning: Function parameter or member 'adapter' not described in

[PATCH 40/40] drm/vmwgfx/vmwgfx_stdu: Add some missing param/member descriptions

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:77: warning: Function parameter or member 'pitch' not described in 'vmw_stdu_dirty' drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:125: warning: Function parameter or member 'content_fb_type' not described in

[PATCH 33/40] drm/vmwgfx/vmwgfx_surface: Fix some kernel-doc related issues

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:55: warning: Function parameter or member 'prime' not described in 'vmw_user_surface' drivers/gpu/drm/vmwgfx/vmwgfx_surface.c:55: warning: Function parameter or member 'backup_base' not described in

[PATCH 31/40] drm/gma500/gem: Do not rely on consumers to include drm/drm_device.h before gem.h

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/gem.h:13:57: warning: ‘struct drm_device’ declared inside parameter list will not be visible outside of this definition or declaration Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc:

[PATCH 36/40] drm/vmwgfx/vmwgfx_shader: Demote kernel-doc abuses and fix-up worthy headers

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_shader.c:134: warning: Function parameter or member 'res' not described in 'vmw_res_to_shader' drivers/gpu/drm/vmwgfx/vmwgfx_shader.c:663: warning: Function parameter or member 'base' not described in

[PATCH 38/40] drm/gma500/power: Remove excess param description 'state'

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/power.c:190: warning: Excess function parameter 'state' description in 'gma_power_suspend' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Benjamin Defnet Cc: Rajesh Poornachandran Cc: Alan Cox Cc:

[PATCH 32/40] drm/gma500/gem: Include our own header containing prototypes

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/gem.c:59:5: warning: no previous prototype for ‘psb_gem_create’ [-Wmissing-prototypes] Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones ---

[PATCH 23/40] drm/vmwgfx/vmwgfx_overlay: Demote kernel-doc abuses to standard comment blocks

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:48: warning: cannot understand function prototype: 'struct vmw_overlay ' drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c:98: warning: Function parameter or member 'dev_priv' not described in

[PATCH 20/40] drm/vmwgfx/vmwgfx_kms: Update worthy function headers and demote others

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:37: drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:483: warning: Function parameter or member 'new_state' not described in 'vmw_du_cursor_plane_atomic_check'

[PATCH 22/40] drm/gma500/gma_device: Include our own header containing prototypes

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/gma_device.c:10:6: warning: no previous prototype for ‘gma_get_core_freq’ [-Wmissing-prototypes] Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones ---

[PATCH 27/40] drm/vmwgfx/vmwgfx_bo: Remove superfluous param description and supply another

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_bo.c:142: warning: Excess function parameter 'pin' description in 'vmw_bo_pin_in_vram_or_gmr' drivers/gpu/drm/vmwgfx/vmwgfx_bo.c:647: warning: Function parameter or member 'p_base' not described in

[PATCH 25/40] drm/gma500/psb_intel_lvds: Supply description for 'mode_dev'

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/psb_intel_lvds.c:635: warning: Function parameter or member 'mode_dev' not described in 'psb_intel_lvds_init' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Eric Anholt Cc: Jesse Barnes Cc:

[PATCH 26/40] drm/vmwgfx/vmwgfx_fence: Add, remove and demote various documentation params/headers

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:82: warning: Function parameter or member 'event' not described in 'vmw_event_fence_action' drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:113: warning: Function parameter or member 'f' not described in

[PATCH 19/40] drm/gma500/power: Fix a bunch of *dev documentation issues

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/power.c:101: warning: Function parameter or member 'pdev' not described in 'gma_resume_display' drivers/gpu/drm/gma500/power.c:155: warning: Function parameter or member 'pdev' not described in 'gma_resume_pci'

[PATCH 18/40] drm/gma500/mmu: Make local function 'psb_mmu_pt_alloc_map_lock()' static

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/mmu.c:316:20: warning: no previous prototype for ‘psb_mmu_pt_alloc_map_lock’ [-Wmissing-prototypes] Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones

[PATCH 21/40] drm/gma500/gma_display: Demote kernel-doc abuses to standard comment blocks

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/gma_display.c:27: warning: Function parameter or member 'crtc' not described in 'gma_pipe_has_type' drivers/gpu/drm/gma500/gma_display.c:27: warning: Function parameter or member 'type' not described in

[PATCH 17/40] drm/gma500/intel_i2c: Remove superflouous parameter description and rename another

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/intel_i2c.c:108: warning: Excess function parameter 'output' description in 'psb_intel_i2c_create' drivers/gpu/drm/gma500/intel_i2c.c:153: warning: Function parameter or member 'chan' not described in

[PATCH 16/40] drm/gma500/intel_bios: Demote non-conformant kernel-doc header

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/intel_bios.c:581: warning: Function parameter or member 'dev' not described in 'psb_intel_destroy_bios' Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: Eric Anholt Cc: dri-devel@lists.freedesktop.org

[PATCH 12/40] drm/vmwgfx/vmwgfx_fifo: Demote non-conformant kernel-doc header

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c:299: warning: Function parameter or member 'dev_priv' not described in 'vmw_local_fifo_reserve' drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c:299: warning: Function parameter or member 'bytes' not described in

[PATCH 14/40] drm/gma500/framebuffer: Fix some possible doc-rot issues

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/framebuffer.c:171: warning: Function parameter or member 'obj' not described in 'psb_framebuffer_init' drivers/gpu/drm/gma500/framebuffer.c:171: warning: Excess function parameter 'gt' description in

[PATCH 15/40] drm/gma500/gem: Add and rename some function parameter descriptions

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/gem.c:57:5: warning: no previous prototype for ‘psb_gem_create’ [-Wmissing-prototypes] drivers/gpu/drm/gma500/gem.c:59: warning: Function parameter or member 'stolen' not described in 'psb_gem_create'

[PATCH 13/40] drm/vmwgfx/vmwgfx_ldu: Supply descriptions for 'state' function parameter

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c:55: warning: cannot understand function prototype: 'struct vmw_legacy_display_unit ' drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c:218: warning: Function parameter or member 'state' not described in

[PATCH 06/40] drm/mga/mga_ioc32: Fix some formatting issues in 'mga_compat_ioctl's header

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/mga/mga_ioc32.c:171: warning: Function parameter or member 'filp' not described in 'mga_compat_ioctl' drivers/gpu/drm/mga/mga_ioc32.c:171: warning: Function parameter or member 'cmd' not described in 'mga_compat_ioctl'

[PATCH 08/40] drm/vmwgfx/vmwgfx_drv: Fix some kernel-doc misdemeanours

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:164: warning: Function parameter or member 'ioctl' not described in 'VMW_IOCTL_DEF' drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:164: warning: Function parameter or member 'func' not described in 'VMW_IOCTL_DEF'

[PATCH 11/40] drm/vmwgfx/vmwgfx_ttm_buffer: Supply some missing parameter descriptions

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c:275: warning: Function parameter or member 'p_offset' not described in 'vmw_piter_start' drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c:676: warning: Function parameter or member 'evict' not described in

[PATCH 10/40] drm/vmwgfx/vmwgfx_resource: Fix worthy function headers demote some others

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:215: warning: Excess function parameter 'obj_type' description in 'vmw_resource_init' drivers/gpu/drm/vmwgfx/vmwgfx_resource.c:303: warning: Excess function parameter 'p_res' description in

[PATCH 09/40] drm/vmwgfx/vmwgfx_ioctl: Provide missing '@' sign required by kernel-doc

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): In file included from drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c:30: drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c:448: warning: Function parameter or member 'offset' not described in 'vmw_fops_read' Cc: VMware Graphics Cc: Roland Scheidegger Cc: David

[PATCH 03/40] drm/vmwgfx/vmwgfx_execbuf: Fix some kernel-doc related issues

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:89: warning: Enum value 'vmw_res_rel_max' not described in enum 'vmw_resource_relocation_type' drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:136: warning: Function parameter or member 'func' not described in

[PATCH 05/40] drm/r128/r128_ioc32: Fix formatting issues in 'r128_compat_ioctl()'s header

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/r128/r128_ioc32.c:182: warning: Function parameter or member 'filp' not described in 'r128_compat_ioctl' drivers/gpu/drm/r128/r128_ioc32.c:182: warning: Function parameter or member 'cmd' not described in 'r128_compat_ioctl'

[PATCH 07/40] drm/vmwgfx/vmwgfx_kms: Mark vmw_{cursor, primary}_plane_formats as __maybe_unused

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:256:23: warning: ‘vmw_cursor_plane_formats’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:248:23: warning: ‘vmw_primary_plane_formats’ defined but not used

[PATCH 04/40] drm/vmwgfx/vmwgfx_kms: Remove unused variable 'ret' from 'vmw_du_primary_plane_atomic_check()'

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_kms.c: In function ‘vmw_du_primary_plane_atomic_check’: drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:460:31: warning: variable ‘vcs’ set but not used [-Wunused-but-set-variable] Cc: VMware Graphics Cc: Roland Scheidegger

[PATCH 02/40] drm/mga/mga_ioc32: Document headers do not make good kernel-doc candidates

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/mga/mga_ioc32.c:2: warning: Cannot understand * file mga_ioc32.c Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/mga/mga_ioc32.c | 2 +- 1 file changed, 1

[PATCH 01/40] drm/r128/r128_ioc32: Document headers do not make good kernel-doc candidates

2021-01-15 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/r128/r128_ioc32.c:2: warning: Cannot understand * file r128_ioc32.c Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/r128/r128_ioc32.c | 2 +- 1 file

[PATCH 00/40] [Set 14] Rid W=1 warnings from GPU

2021-01-15 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Penultimate set, promise. :) Lee Jones (40): drm/r128/r128_ioc32: Document headers do not make good kernel-doc candidates

  1   2   >