Re: [Freedreno] [PATCH] drm/msm/dp: Only create debugfs for PRIMARY minor

2021-10-15 Thread Bjorn Andersson
On Fri 15 Oct 18:44 CDT 2021, abhin...@codeaurora.org wrote: > On 2021-10-15 16:13, Bjorn Andersson wrote: > > dpu_kms_debugfs_init() and hence dp_debug_get() gets invoked for each > > minor being registered. But dp_debug_get() will allocate a new struct > > dp_debug for each call and this will

Re: [PATCH v2 3/4] dt-bindings: drm/bridge: ti-sn65dsi83: Add vcc supply bindings

2021-10-15 Thread Laurent Pinchart
Hi Maxime, On Thu, Oct 14, 2021 at 09:41:10AM +0200, Maxime Ripard wrote: > On Wed, Oct 13, 2021 at 12:37:47PM +0300, Laurent Pinchart wrote: > > On Wed, Oct 13, 2021 at 09:47:22AM +0200, Maxime Ripard wrote: > > > On Tue, Oct 12, 2021 at 08:48:42AM +0200, Alexander Stein wrote: > > > > Add a VCC

Re: [PATCH v8 04/12] iommu/mediatek: Add device_link between the consumer and the larb devices

2021-10-15 Thread Yong Wu
On Mon, 2021-10-11 at 14:36 +0200, Dafna Hirschfeld wrote: > > On 29.09.21 03:37, Yong Wu wrote: > > MediaTek IOMMU-SMI diagram is like below. all the consumer connect > > with > > smi-larb, then connect with smi-common. > > > > M4U > > | > > smi-common > > | >

Re: [PATCH] [RESEND] drm/rcar: stop using 'imply' for dependencies

2021-10-15 Thread Laurent Pinchart
Hi Arnd, Thank you for the patch. On Mon, Sep 27, 2021 at 04:26:23PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The meaning of the 'imply' keyword has changed recently, and neither the > old meaning (select the symbol if its dependencies are met) nor the new > meaning (enable it by

Re: [Freedreno] [PATCH] drm/msm/dp: Move debugfs files into subdirectory

2021-10-15 Thread abhinavk
On 2021-10-15 16:17, Bjorn Andersson wrote: In the cleanup path of the MSM DP driver the DP driver's debugfs files are destroyed by invoking debugfs_remove_recursive() on debug->root, which during initialization has been set to minor->debugfs_root. To allow cleaning up the DP driver's debugfs

[PATCH 2/2] drm/i915/pmu: Connect engine busyness stats from GuC to pmu

2021-10-15 Thread Umesh Nerlige Ramappa
With GuC handling scheduling, i915 is not aware of the time that a context is scheduled in and out of the engine. Since i915 pmu relies on this info to provide engine busyness to the user, GuC shares this info with i915 for all engines using shared memory. For each engine, this info contains: -

[PATCH 1/2] drm/i915/pmu: Add a name to the execlists stats

2021-10-15 Thread Umesh Nerlige Ramappa
In preparation for GuC pmu stats, add a name to the execlists stats structure so that it can be differentiated from the GuC stats. Signed-off-by: Umesh Nerlige Ramappa Acked-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_engine_cs.c| 14 +++---

Re: [Freedreno] [PATCH] drm/msm/dp: Only create debugfs for PRIMARY minor

2021-10-15 Thread abhinavk
On 2021-10-15 16:13, Bjorn Andersson wrote: dpu_kms_debugfs_init() and hence dp_debug_get() gets invoked for each minor being registered. But dp_debug_get() will allocate a new struct dp_debug for each call and this will be associated as dp->debug. As such dp_debug will create debugfs files in

Re: [PATCH v6 04/16] dt-bindings: reset: mt8195: add vdosys1 reset control bit

2021-10-15 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年10月4日 週一 下午2:21寫道: > > Add vdosys1 reset control bit for MT8195 platform. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Nancy.Lin > --- > include/dt-bindings/reset/mt8195-resets.h | 12 > 1 file changed, 12 insertions(+) > > diff --git

Re: [PATCH v6 03/16] dt-bindings: mediatek: add ethdr definition for mt8195

2021-10-15 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年10月4日 週一 下午2:21寫道: > > Add vdosys1 ETHDR definition. > > Signed-off-by: Nancy.Lin > --- > .../display/mediatek/mediatek,ethdr.yaml | 145 ++ > 1 file changed, 145 insertions(+) > create mode 100644 >

[PATCH v2] drm/msm/dp: Use the connector passed to dp_debug_get()

2021-10-15 Thread Bjorn Andersson
The debugfs code is provided an array of a single drm_connector. Then to access the connector, the list of all connectors of the DRM device is traversed and all non-DisplayPort connectors are skipped, to find the one and only DisplayPort connector. But as we move to support multiple DisplayPort

[PATCH] drm/msm/dp: Move debugfs files into subdirectory

2021-10-15 Thread Bjorn Andersson
In the cleanup path of the MSM DP driver the DP driver's debugfs files are destroyed by invoking debugfs_remove_recursive() on debug->root, which during initialization has been set to minor->debugfs_root. To allow cleaning up the DP driver's debugfs files either each dentry needs to be kept track

[PATCH] drm/msm/dp: Only create debugfs for PRIMARY minor

2021-10-15 Thread Bjorn Andersson
dpu_kms_debugfs_init() and hence dp_debug_get() gets invoked for each minor being registered. But dp_debug_get() will allocate a new struct dp_debug for each call and this will be associated as dp->debug. As such dp_debug will create debugfs files in both the PRIMARY and the RENDER minor's

[Bug 214029] [bisected] [amdgpu] Several memory leaks in amdgpu and ttm

2021-10-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214029 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Attachment #298893|0 |1 is obsolete|

[Bug 214029] [bisected] [amdgpu] Several memory leaks in amdgpu and ttm

2021-10-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214029 --- Comment #17 from Erhard F. (erhar...@mailbox.org) --- v5.15-rc5 is still affected. However I reverted d02117f8efaa5fbc37437df1ae955a147a2a424a on top of v5.15-rc5 and can confirm this fixes the leak. -- You may reply to this email to add a

Re: [PATCH v2 6/6] drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR

2021-10-15 Thread Martin Blumenstingl
Hi Neil, Hi Sam, On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong wrote: [...] > +static const struct drm_bridge_funcs meson_encoder_cvbs_bridge_funcs = { > + .attach = meson_encoder_cvbs_attach, > + .enable = meson_encoder_cvbs_enable, > + .disable = meson_encoder_cvbs_disable,

Re: [Freedreno] [PATCH 2/2] drm/msm/hdmi: switch to drm_bridge_connector

2021-10-15 Thread abhinavk
Hi Dmitry On 2021-10-14 17:11, Dmitry Baryshkov wrote: Merge old hdmi_bridge and hdmi_connector implementations. Use drm_bridge_connector instead. Can you please comment on the validation done on this change? Has basic bootup been verified on db820c as thats the only platform which shall use

Re: [Freedreno] [PATCH 1/2] drm/msm/hdmi: use bulk regulator API

2021-10-15 Thread abhinavk
On 2021-10-14 17:10, Dmitry Baryshkov wrote: Switch to using bulk regulator API instead of hand coding loops. Nice cleanup! Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/hdmi/hdmi.c | 34 +++

Re: [PATCH v2 6/6] drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR

2021-10-15 Thread Martin Blumenstingl
On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong wrote: > > Drop the local connector and move all callback to bridge funcs in order > to leverage the generic CVBS display connector. > > This will also permit adding custom cvbs connectors for ADC based HPD > detection on some Amlogic SoC based

Re: [PATCH v2 5/6] drm/meson: rename venc_cvbs to encoder_cvbs

2021-10-15 Thread Martin Blumenstingl
On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong wrote: > > Rename the cvbs encoder to match the newly introduced meson_encoder_hdmi. > > Signed-off-by: Neil Armstrong > Acked-by: Sam Ravnborg Acked-by: Martin Blumenstingl

Re: [PATCH v2 4/6] drm/meson: encoder_hdmi: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR

2021-10-15 Thread Martin Blumenstingl
Hi Neil, On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong wrote: > > This implements the necessary change to no more use the embedded > connector in dw-hdmi and use the dedicated bridge connector driver > by passing DRM_BRIDGE_ATTACH_NO_CONNECTOR to the bridge attach call. > > The necessary

Re: [PATCH v2 3/6] drm/meson: split out encoder from meson_dw_hdmi

2021-10-15 Thread Martin Blumenstingl
Hi Neil, On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong wrote: > > This moves all the non-DW-HDMI code where it should be: > an encoder in the drm/meson core driver. > > The bridge functions are copied as-is, except: > - the encoder init uses the simple kms helper > - the mode_set has been moved

Re: [PATCH v2 2/6] drm/meson: remove useless recursive components matching

2021-10-15 Thread Martin Blumenstingl
On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong wrote: > > The initial design was recursive to cover all port/endpoints, but only the > first layer > of endpoints should be covered by the components list. > This also breaks the MIPI-DSI init/bridge attach sequence, thus only parse the > first

Re: [PATCH] ARM: dts: qcom-apq8064: stop using legacy clock names for HDMI

2021-10-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-10-14 14:42:21) > Stop using legacy clock names (with _clk suffix) for HDMI and HDMI PHY > device tree nodes. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH] drm: panel-orientation-quirks: Add quirk for Aya Neo 2021

2021-10-15 Thread Sam Ravnborg
Hi Bryant, On Fri, Oct 01, 2021 at 03:16:18PM -0700, Bryant Mairs wrote: > Signed-off-by: Bryant Mairs Patch looks fine, but I do not accept empty changelogs. At a minimum describe in the changelog what device benefit from this quirk. Sam

Re: [PATCH] dt-bindings: display/bridge: sil, sii9234: Convert to YAML binding

2021-10-15 Thread Sam Ravnborg
Hi AngeloGioacchino, On Wed, Oct 06, 2021 at 05:21:58PM +0200, AngeloGioacchino Del Regno wrote: > Convert the Silicon Image SiI9234 HDMI/MHL bridge documentation to YAML. > > Signed-off-by: AngeloGioacchino Del Regno > Applied to drm-misc-next. Sam

Re: [PATCH] video: omapfb: replace snprintf in show functions with sysfs_emit

2021-10-15 Thread Sam Ravnborg
Hi Qing, On Tue, Oct 12, 2021 at 08:28:13PM -0700, Qing Wang wrote: > coccicheck complains about the use of snprintf() in sysfs show functions. > > Fix the coccicheck warning: > WARNING: use scnprintf or sprintf. > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. > >

Re: [PATCH] video: fbdev: replace snprintf in show functions with sysfs_emit

2021-10-15 Thread Sam Ravnborg
Hi Qing, On Tue, Oct 12, 2021 at 08:28:00PM -0700, Qing Wang wrote: > coccicheck complains about the use of snprintf() in sysfs show functions. > > Fix the coccicheck warning: > WARNING: use scnprintf or sprintf. > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. > >

Re: [PATCH] drm: Update MST First Link Slot Information Based on Encoding Format

2021-10-15 Thread Lyude Paul
[more snip] On Fri, 2021-10-15 at 15:43 -0400, Bhawanpreet Lakha wrote: > > > Thanks for the response, > > That function is per port so not sure how that will work. Also we only > need to check this inside drm_dp_mst_atomic_check_vcpi_alloc_limit(), > which doesn't have a state. > > We could

Re: [Freedreno] [PATCH 0/3] drm/msm: drop old eDP support

2021-10-15 Thread abhinavk
Hi Dmitry No concerns from our side to drop this. Reviewed-by: Abhinav Kumar for the series. Thanks Abhinav On 2021-10-01 09:50, Dmitry Baryshkov wrote: MSM DRM driver has support for eDP block present on MSM 8x74/8x84 SoC families. However since addition back in 2015 this driver received

Re: [PATCH] drm: Update MST First Link Slot Information Based on Encoding Format

2021-10-15 Thread Lyude Paul
[snip] On Thu, 2021-10-14 at 16:21 -0400, Bhawanpreet Lakha wrote: > > Thanks for the response, > > That function is per port (drm_dp_atomic_find_vcpi_slots) so not sure > how that will work, maybe I don't understand what you mean? Yeah - drm_dp_atomic_find_vcpi_slots() is just one part of

Re: [PATCH v3 5/6] drm/probe-helper: use drm_kms_helper_connector_hotplug_event

2021-10-15 Thread Sam Ravnborg
Hi Simon, On Fri, Oct 15, 2021 at 04:33:45PM +, Simon Ser wrote: > If an hotplug event only updates a single connector, use > drm_kms_helper_connector_hotplug_event instead of > drm_kms_helper_hotplug_event. > > Signed-off-by: Simon Ser > --- > drivers/gpu/drm/drm_probe_helper.c | 20

Re: [Intel-gfx] [PATCH 01/15] gpu/drm: make drm_add_edid_modes() consistent when updating connector->display_info

2021-10-15 Thread Ville Syrjälä
On Fri, Oct 15, 2021 at 10:33:29PM +0300, Ville Syrjälä wrote: > On Fri, Oct 15, 2021 at 09:24:06PM +0200, Claudio Suarez wrote: > > On Fri, Oct 15, 2021 at 03:03:13PM +0300, Ville Syrjälä wrote: > > > On Fri, Oct 15, 2021 at 01:36:59PM +0200, Claudio Suarez wrote: > > > > According to the

Re: [PATCH 1/2] drm/msm/hdmi: use bulk regulator API

2021-10-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-10-14 17:10:59) > Switch to using bulk regulator API instead of hand coding loops. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 6/6] i915/display/dp: send a more fine-grained link-status uevent

2021-10-15 Thread Ville Syrjälä
On Fri, Oct 15, 2021 at 04:33:46PM +, Simon Ser wrote: > When link-status changes, send a hotplug uevent which contains the > connector and property ID. That way, user-space can more easily > figure out that only the link-status property of this connector has > been updated. > >

Re: [PATCH v3 3/6] drm/connector: use drm_sysfs_connector_hotplug_event

2021-10-15 Thread Sam Ravnborg
On Fri, Oct 15, 2021 at 04:33:43PM +, Simon Ser wrote: > In drm_connector_register, use drm_sysfs_connector_hotplug_event > instead of drm_sysfs_hotplug_event, because the hotplug event > only updates a single connector. > > Signed-off-by: Simon Ser Reviewed-by: Sam Ravnborg

Re: [PATCH] drm: Update MST First Link Slot Information Based on Encoding Format

2021-10-15 Thread Bhawanpreet Lakha
On 2021-10-13 6:25 p.m., Lyude Paul wrote: Some comments below (also, sorry again for the mixup on the last review!) On Tue, 2021-10-12 at 17:58 -0400, Bhawanpreet Lakha wrote: 8b/10b encoding format requires to reserve the first slot for recording metadata. Real data transmission starts

Re: [PATCH v3 2/6] drm/probe-helper: add drm_kms_helper_connector_hotplug_event

2021-10-15 Thread Sam Ravnborg
On Fri, Oct 15, 2021 at 04:33:42PM +, Simon Ser wrote: > This function is the same as drm_kms_helper_hotplug_event, but takes > a connector instead of a device. > > Signed-off-by: Simon Ser Reviewed-by: Sam Ravnborg Sam

Re: [PATCH v3 1/6] drm/sysfs: introduce drm_sysfs_connector_hotplug_event

2021-10-15 Thread Sam Ravnborg
On Fri, Oct 15, 2021 at 09:37:04PM +0200, Sam Ravnborg wrote: > Hi Simon, > > On Fri, Oct 15, 2021 at 04:33:41PM +, Simon Ser wrote: > > This function sends a hotplug uevent with a CONNECTOR property. > > A little late feedback. > > Sam If you keep current code then patch is:

Re: [PATCH v3 5/6] drm/probe-helper: use drm_kms_helper_connector_hotplug_event

2021-10-15 Thread Ville Syrjälä
On Fri, Oct 15, 2021 at 04:33:45PM +, Simon Ser wrote: > If an hotplug event only updates a single connector, use > drm_kms_helper_connector_hotplug_event instead of > drm_kms_helper_hotplug_event. > > Signed-off-by: Simon Ser > --- > drivers/gpu/drm/drm_probe_helper.c | 20

Re: [bug report] drm/msm: dsi: Handle dual-channel for 6G as well

2021-10-15 Thread Jessica Zhang
Hey Dmitry, On 10/15/2021 11:24 AM, Dmitry Baryshkov wrote: On Fri, 15 Oct 2021 at 04:43, Jessica Zhang wrote: Hey Dan, On 10/1/2021 5:31 AM, Dan Carpenter wrote: Hello Sean Paul, The patch a6bcddbc2ee1: "drm/msm: dsi: Handle dual-channel for 6G as well" from Jul 25, 2018, leads to the

Re: [PATCH v3 1/6] drm/sysfs: introduce drm_sysfs_connector_hotplug_event

2021-10-15 Thread Sam Ravnborg
Hi Simon, On Fri, Oct 15, 2021 at 04:33:41PM +, Simon Ser wrote: > This function sends a hotplug uevent with a CONNECTOR property. A little late feedback. Sam > > Signed-off-by: Simon Ser > --- > drivers/gpu/drm/drm_sysfs.c | 25 + >

Re: [PATCH 01/15] gpu/drm: make drm_add_edid_modes() consistent when updating connector->display_info

2021-10-15 Thread Ville Syrjälä
On Fri, Oct 15, 2021 at 09:24:06PM +0200, Claudio Suarez wrote: > On Fri, Oct 15, 2021 at 03:03:13PM +0300, Ville Syrjälä wrote: > > On Fri, Oct 15, 2021 at 01:36:59PM +0200, Claudio Suarez wrote: > > > According to the documentation, drm_add_edid_modes > > > "... Also fills out the _display_info

Re: [PATCH] Revert "drm/ast: Zero is missing in detect function"

2021-10-15 Thread Kim Phillips
On 10/15/21 2:25 AM, Thomas Zimmermann wrote: Commit 572994bf18ff ("drm/ast: Zero is missing in detect function") prevents some systems from booting. Seen on Supermicro Super Server/X10SRL-F, BIOS 3.3 10/28/2020 . There's further a bug that results in KASAN: use-after-free in

Re: [PATCH v3 4/6] amdgpu: use drm_kms_helper_connector_hotplug_event

2021-10-15 Thread Harry Wentland
On 2021-10-15 12:33, Simon Ser wrote: > When updating a single connector, use > drm_kms_helper_connector_hotplug_event instead of > drm_kms_helper_hotplug_event. > > Signed-off-by: Simon Ser Reviewed-by: Harry Wentland Patches 1-3 are also Acked-by: Harry Wentland Harry > --- >

Re: [PATCH 01/15] gpu/drm: make drm_add_edid_modes() consistent when updating connector->display_info

2021-10-15 Thread Claudio Suarez
On Fri, Oct 15, 2021 at 03:03:13PM +0300, Ville Syrjälä wrote: > On Fri, Oct 15, 2021 at 01:36:59PM +0200, Claudio Suarez wrote: > > According to the documentation, drm_add_edid_modes > > "... Also fills out the _display_info structure and ELD in @connector > > with any information which can be

Re: [PATCH] dt-bindings: display/bridge: ptn3460: Convert to YAML binding

2021-10-15 Thread Sam Ravnborg
Hi AngeloGioacchino, On Thu, Oct 07, 2021 at 09:58:22AM +0200, AngeloGioacchino Del Regno wrote: > Convert the NXP PTN3460 eDP to LVDS bridge documentation to YAML. > > Signed-off-by: AngeloGioacchino Del Regno > Applied to drm-misc-next with Rob's r-b. It will show up in -next in 1-2 weeks.

Re: [RFC PATCH] drm/panel: ilitek-ili9881d: add support for Wanchanglong W552946ABA panel

2021-10-15 Thread Sam Ravnborg
Hi Michael, > Add this panel's initialzation sequence and timing to ILI9881D driver. > Tested on px30-evb v11 Patch looks good, but we need the vendor and the compatible documented. > > Signed-off-by: Michael Trimarchi > --- > drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 238

[PULL] drm-intel-next

2021-10-15 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-next-2021-10-15: Likely the last one towards 5.15. UAPI Changes: - No Functional change, but a clarification around I915_TILING values (Matt). Driver Changes: - Changes around async flip VT-d w/a (Ville) - Delete bogus NULL check in

Re: [Intel-gfx] [PATCH 15/15] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
On Fri, Oct 15, 2021 at 06:18:34PM +0300, Jani Nikula wrote: > On Fri, 15 Oct 2021, Ville Syrjälä wrote: > > On Fri, Oct 15, 2021 at 03:44:48PM +0300, Jani Nikula wrote: > >> On Fri, 15 Oct 2021, Claudio Suarez wrote: > >> > Once EDID is parsed, the monitor HDMI support information is available

Re: [PATCH RESEND v10 0/2] gpu: drm: add driver for ili9361 panel

2021-10-15 Thread Sam Ravnborg
Hi Daniel, On Fri, Oct 15, 2021 at 05:01:29PM +0200, Daniel Mack wrote: > This is v10 of the series. > > Resending without changes. Hmm... > > Changelog: > > v2 -> v3: > * Turn Documentation into yaml format > > v3 -> v4: > * Fix reference error in yaml file > > v4 -> v5: >

Re: [bug report] drm/msm: dsi: Handle dual-channel for 6G as well

2021-10-15 Thread Dmitry Baryshkov
On Fri, 15 Oct 2021 at 04:43, Jessica Zhang wrote: > > Hey Dan, > > On 10/1/2021 5:31 AM, Dan Carpenter wrote: > > Hello Sean Paul, > > > > The patch a6bcddbc2ee1: "drm/msm: dsi: Handle dual-channel for 6G as > > well" from Jul 25, 2018, leads to the following > > Smatch static checker warning: >

Re: [Intel-gfx] [PATCH 15/15] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
On Fri, Oct 15, 2021 at 03:30:49PM +0300, Ville Syrjälä wrote: > On Fri, Oct 15, 2021 at 01:37:13PM +0200, Claudio Suarez wrote: > > Once EDID is parsed, the monitor HDMI support information is available > > through drm_display_info.is_hdmi. Retriving the same information with > >

Re: [PATCH] drm: panel: replace snprintf in show functions with sysfs_emit

2021-10-15 Thread Sam Ravnborg
Hi Qing and Sebastian. On Fri, Oct 15, 2021 at 01:11:39PM +0200, Sebastian Reichel wrote: > Hi, > > On Thu, Oct 14, 2021 at 11:48:10PM -0700, Qing Wang wrote: > > show() must not use snprintf() when formatting the value to be > > returned to user space. > > > > Fix the following coccicheck

Re: [PATCH v2 3/6] drm/meson: split out encoder from meson_dw_hdmi

2021-10-15 Thread Sam Ravnborg
Hi Neil, On Fri, Oct 15, 2021 at 04:11:04PM +0200, Neil Armstrong wrote: > This moves all the non-DW-HDMI code where it should be: > an encoder in the drm/meson core driver. > > The bridge functions are copied as-is, except: > - the encoder init uses the simple kms helper > - the mode_set has

Re: [PATCH 0/9] treewide: simplify getting .driver_data

2021-10-15 Thread Bjorn Andersson
On Mon, 20 Sep 2021 11:05:12 +0200, Wolfram Sang wrote: > I got tired of fixing this in Renesas drivers manually, so I took the big > hammer. Remove this cumbersome code pattern which got copy-pasted too much > already: > > - struct platform_device *pdev = to_platform_device(dev); > -

RE: [PATCH v3 7/7] drm/kmb: Enable support for framebuffer console

2021-10-15 Thread Chrisanthus, Anitha
Hi Thomas, Thanks for your review. > -Original Message- > From: Thomas Zimmermann > Sent: Thursday, October 14, 2021 5:50 AM > To: Chrisanthus, Anitha ; dri- > de...@lists.freedesktop.org > Cc: s...@ravnborg.org; Dea, Edmund J > Subject: Re: [PATCH v3 7/7] drm/kmb: Enable support for

RE: [PATCH v3 7/7] drm/kmb: Enable support for framebuffer console

2021-10-15 Thread Chrisanthus, Anitha
Hi Thomas, Thanks for your review. > -Original Message- > From: Thomas Zimmermann > Sent: Thursday, October 14, 2021 6:08 AM > To: Chrisanthus, Anitha ; dri- > de...@lists.freedesktop.org > Cc: s...@ravnborg.org; Dea, Edmund J > Subject: Re: [PATCH v3 7/7] drm/kmb: Enable support for

Re: [bug report] drm/msm: dsi: Handle dual-channel for 6G as well

2021-10-15 Thread Jessica Zhang
On 10/15/2021 1:12 AM, Dan Carpenter wrote: On Thu, Oct 14, 2021 at 06:43:22PM -0700, Jessica Zhang wrote: Hey Dan, On 10/1/2021 5:31 AM, Dan Carpenter wrote: Hello Sean Paul, The patch a6bcddbc2ee1: "drm/msm: dsi: Handle dual-channel for 6G as well" from Jul 25, 2018, leads to the

[PATCH v3 3/6] drm/connector: use drm_sysfs_connector_hotplug_event

2021-10-15 Thread Simon Ser
In drm_connector_register, use drm_sysfs_connector_hotplug_event instead of drm_sysfs_hotplug_event, because the hotplug event only updates a single connector. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 4/6] amdgpu: use drm_kms_helper_connector_hotplug_event

2021-10-15 Thread Simon Ser
When updating a single connector, use drm_kms_helper_connector_hotplug_event instead of drm_kms_helper_hotplug_event. Signed-off-by: Simon Ser --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 4 ++-- 2 files

[PATCH v3 6/6] i915/display/dp: send a more fine-grained link-status uevent

2021-10-15 Thread Simon Ser
When link-status changes, send a hotplug uevent which contains the connector and property ID. That way, user-space can more easily figure out that only the link-status property of this connector has been updated. Signed-off-by: Simon Ser --- drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ 1

[PATCH v3 2/6] drm/probe-helper: add drm_kms_helper_connector_hotplug_event

2021-10-15 Thread Simon Ser
This function is the same as drm_kms_helper_hotplug_event, but takes a connector instead of a device. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_probe_helper.c | 23 +++ include/drm/drm_probe_helper.h | 1 + 2 files changed, 24 insertions(+) diff --git

[PATCH v3 5/6] drm/probe-helper: use drm_kms_helper_connector_hotplug_event

2021-10-15 Thread Simon Ser
If an hotplug event only updates a single connector, use drm_kms_helper_connector_hotplug_event instead of drm_kms_helper_hotplug_event. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_probe_helper.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git

[PATCH v3 0/6] drm: add per-connector hotplug events

2021-10-15 Thread Simon Ser
When a uevent only updates a single connector, add a CONNECTOR property to the uevent. This allows user-space to ignore other connectors when handling the uevent. This is purely an optimization, drivers can still send a uevent without the CONNECTOR property. The CONNECTOR property is already set

[PATCH v3 1/6] drm/sysfs: introduce drm_sysfs_connector_hotplug_event

2021-10-15 Thread Simon Ser
This function sends a hotplug uevent with a CONNECTOR property. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_sysfs.c | 25 + include/drm/drm_sysfs.h | 1 + 2 files changed, 26 insertions(+) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c

Re: [PATCH v6 02/16] dt-bindings: mediatek: add vdosys1 MERGE property for mt8195

2021-10-15 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年10月4日 週一 下午2:21寫道: > > MT8195 vdosys1 merge1 to merge4 have HW mute function. > Add MERGE additional mute property description. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Nancy.Lin > --- > .../devicetree/bindings/display/mediatek/mediatek,merge.yaml | 4

Re: [Intel-gfx] [PATCH] drm/i915: fix blank screen booting crashes

2021-10-15 Thread Jani Nikula
On Fri, 15 Oct 2021, John Harrison wrote: > On 10/15/2021 07:52, Tvrtko Ursulin wrote: >> On 04/10/2021 08:36, Jani Nikula wrote: >>> On Fri, 24 Sep 2021, Ville Syrjälä >>> wrote: On Tue, Sep 21, 2021 at 06:50:39PM -0700, Matthew Brost wrote: > From: Hugh Dickins > > 5.15-rc1

Re: [Intel-gfx] [PATCH] drm/i915: fix blank screen booting crashes

2021-10-15 Thread John Harrison
On 10/15/2021 07:52, Tvrtko Ursulin wrote: On 04/10/2021 08:36, Jani Nikula wrote: On Fri, 24 Sep 2021, Ville Syrjälä wrote: On Tue, Sep 21, 2021 at 06:50:39PM -0700, Matthew Brost wrote: From: Hugh Dickins 5.15-rc1 crashes with blank screen when booting up on two ThinkPads using i915. 

Re: [PATCH 1/3] drm/dp: add helpers to read link training delays

2021-10-15 Thread Jani Nikula
On Thu, 14 Oct 2021, Jani Nikula wrote: > The link training delays are different and/or available in different > DPCD offsets depending on: > > - Clock recovery vs. channel equalization > - DPRX vs. LTTPR > - 128b/132b vs. 8b/10b > - DPCD 1.4+ vs. earlier > > Add helpers to get the correct delays

Re: [Intel-gfx] [PATCH 15/15] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Jani Nikula
On Fri, 15 Oct 2021, Ville Syrjälä wrote: > On Fri, Oct 15, 2021 at 03:44:48PM +0300, Jani Nikula wrote: >> On Fri, 15 Oct 2021, Claudio Suarez wrote: >> > Once EDID is parsed, the monitor HDMI support information is available >> > through drm_display_info.is_hdmi. Retriving the same information

Re: [PATCH 02/15] drm/amdgpu: use drm_* functions instead of duplicated code in amdgpu driver

2021-10-15 Thread Harry Wentland
On 2021-10-15 07:37, Claudio Suarez wrote: > a) Once EDID is parsed, the monitor HDMI support information is available > through drm_display_info.is_hdmi. The amdgpu driver still calls > drm_detect_hdmi_monitor() to retrieve the same information, which > is less efficient. Change to

[PATCH RESEND v10 1/2] dt-bindings: display: add bindings for newhaven, 1.8-128160EF

2021-10-15 Thread Daniel Mack
This adds documentation for a new ILI9163 based, SPI connected display. Signed-off-by: Daniel Mack Reviewed-by: Rob Herring --- .../display/panel/ilitek,ili9163.yaml | 69 +++ 1 file changed, 69 insertions(+) create mode 100644

Re: [PATCH v8 0/2] gpu: drm: add driver for ili9361 panel

2021-10-15 Thread Daniel Mack
On 10/15/21 16:59, Daniel Mack wrote: > This is v3 of the series. Ups, sorry. Ignore this one. I meant to resend a different version of this series. My apologies, Daniel > > Changelog: > > v2 -> v3: > * Turn Documentation into yaml format > > v3 -> v4: > * Fix reference error

[PATCH v8 2/2] drm/tiny: add driver for newhaven,1.8-128160EF

2021-10-15 Thread Daniel Mack
This patch adds support for Newhaven's NHD-1.8-128160EF display, featuring an Ilitek ILI9163 controller. Signed-off-by: Daniel Mack Acked-by: Daniel Vetter --- drivers/gpu/drm/tiny/Kconfig | 13 ++ drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/ili9163.c | 224

[PATCH v8 0/2] gpu: drm: add driver for ili9361 panel

2021-10-15 Thread Daniel Mack
This is v3 of the series. Changelog: v2 -> v3: * Turn Documentation into yaml format v3 -> v4: * Fix reference error in yaml file v4 -> v5: * More yaml file documentation fixes v5 -> v6: * More yaml file documentation fixes v6 -> v7: * Fix ordering of

[PATCH v8 1/2] dt-bindings: display: add bindings for newhaven, 1.8-128160EF

2021-10-15 Thread Daniel Mack
This adds documentation for a new ILI9163 based, SPI connected display. Signed-off-by: Daniel Mack --- .../display/panel/ilitek,ili9163.yaml | 69 +++ 1 file changed, 69 insertions(+) create mode 100644

[PATCH RESEND v10 0/2] gpu: drm: add driver for ili9361 panel

2021-10-15 Thread Daniel Mack
This is v10 of the series. Resending without changes. Changelog: v2 -> v3: * Turn Documentation into yaml format v3 -> v4: * Fix reference error in yaml file v4 -> v5: * More yaml file documentation fixes v5 -> v6: * More yaml file documentation fixes v6 ->

[PATCH RESEND v10 2/2] drm/tiny: add driver for newhaven, 1.8-128160EF

2021-10-15 Thread Daniel Mack
This patch adds support for Newhaven's NHD-1.8-128160EF display, featuring an Ilitek ILI9163 controller. Signed-off-by: Daniel Mack Acked-by: Daniel Vetter Acked-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/Kconfig | 13 ++ drivers/gpu/drm/tiny/Makefile | 1 +

Re: [Intel-gfx] [PATCH] drm/i915: fix blank screen booting crashes

2021-10-15 Thread Tvrtko Ursulin
On 04/10/2021 08:36, Jani Nikula wrote: On Fri, 24 Sep 2021, Ville Syrjälä wrote: On Tue, Sep 21, 2021 at 06:50:39PM -0700, Matthew Brost wrote: From: Hugh Dickins 5.15-rc1 crashes with blank screen when booting up on two ThinkPads using i915. Bisections converge convincingly, but

Re: [git pull] drm fixes for 5.15-rc6

2021-10-15 Thread pr-tracker-bot
The pull request you sent on Fri, 15 Oct 2021 15:15:31 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2021-10-15-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/591a495d440ff8dd2b51a47eb6053c83f68a7f6b Thank you! -- Deet-doot-dot, I am a bot.

[PATCH v2 6/6] drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR

2021-10-15 Thread Neil Armstrong
Drop the local connector and move all callback to bridge funcs in order to leverage the generic CVBS display connector. This will also permit adding custom cvbs connectors for ADC based HPD detection on some Amlogic SoC based boards. Signed-off-by: Neil Armstrong Acked-by: Sam Ravnborg ---

[PATCH v2 2/6] drm/meson: remove useless recursive components matching

2021-10-15 Thread Neil Armstrong
The initial design was recursive to cover all port/endpoints, but only the first layer of endpoints should be covered by the components list. This also breaks the MIPI-DSI init/bridge attach sequence, thus only parse the first endpoints instead of recursing. Signed-off-by: Neil Armstrong

[PATCH v2 4/6] drm/meson: encoder_hdmi: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR

2021-10-15 Thread Neil Armstrong
This implements the necessary change to no more use the embedded connector in dw-hdmi and use the dedicated bridge connector driver by passing DRM_BRIDGE_ATTACH_NO_CONNECTOR to the bridge attach call. The necessary connector properties are added to handle the same functionalities as the embedded

[PATCH v2 5/6] drm/meson: rename venc_cvbs to encoder_cvbs

2021-10-15 Thread Neil Armstrong
Rename the cvbs encoder to match the newly introduced meson_encoder_hdmi. Signed-off-by: Neil Armstrong Acked-by: Sam Ravnborg --- drivers/gpu/drm/meson/Makefile| 2 +- drivers/gpu/drm/meson/meson_drv.c | 4 +- ...meson_venc_cvbs.c => meson_encoder_cvbs.c} | 78

[PATCH v2 1/6] drm/bridge: display-connector: implement bus fmts callbacks

2021-10-15 Thread Neil Armstrong
Since this bridge is tied to the connector, it acts like a passthrough, so concerning the output & input bus formats, either pass the bus formats from the previous bridge or return fallback data like done in the bridge function: drm_atomic_bridge_chain_select_bus_fmts() &

[PATCH v2 3/6] drm/meson: split out encoder from meson_dw_hdmi

2021-10-15 Thread Neil Armstrong
This moves all the non-DW-HDMI code where it should be: an encoder in the drm/meson core driver. The bridge functions are copied as-is, except: - the encoder init uses the simple kms helper - the mode_set has been moved to atomic_enable() - debug prints are converted to dev_debg() For now the

[PATCH v2 0/6] drm/meson: rework encoders to pass ATTACH_NO_CONNECTOR

2021-10-15 Thread Neil Armstrong
This serie finnally reworks the drm/meson driver by extracting the encoders in their own file and moves to bridge-only callbacks. This permits passing the ATTACH_NO_CONNECTOR bridge attach flag and finally use the CVBS & HDMI display-connector driver. This will ease Martin Blumenstingl writing

Re: [PATCH] dt-bindings: display/bridge: ptn3460: Convert to YAML binding

2021-10-15 Thread Rob Herring
On Thu, 07 Oct 2021 09:58:22 +0200, AngeloGioacchino Del Regno wrote: > Convert the NXP PTN3460 eDP to LVDS bridge documentation to YAML. > > Signed-off-by: AngeloGioacchino Del Regno > > --- > .../bindings/display/bridge/nxp,ptn3460.yaml | 106 ++ >

Re: [PATCH -next] drm/v3d: nullify pointer se with a NULL

2021-10-15 Thread Melissa Wen
On 10/15, Yang Li wrote: > Currently a plain integer is being used to nullify the pointer > struct v3d_submit_ext *se. Use NULL instead. Cleans up sparse > warnings: > drivers/gpu/drm/v3d/v3d_gem.c:777:53: warning: Using plain integer as > NULL pointer > drivers/gpu/drm/v3d/v3d_gem.c:1010:45:

Re: [Intel-gfx] [PATCH 15/15] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Ville Syrjälä
On Fri, Oct 15, 2021 at 03:44:48PM +0300, Jani Nikula wrote: > On Fri, 15 Oct 2021, Claudio Suarez wrote: > > Once EDID is parsed, the monitor HDMI support information is available > > through drm_display_info.is_hdmi. Retriving the same information with > > drm_detect_hdmi_monitor() is less

Re: [Linaro-mm-sig] [PATCH 2/2] dma-buf: Fix dma_resv_test_signaled.

2021-10-15 Thread Christian König
Am 15.10.21 um 14:52 schrieb Maarten Lankhorst: Op 15-10-2021 om 14:07 schreef Christian König: Am 15.10.21 um 13:57 schrieb Maarten Lankhorst: Commit 7fa828cb9265 ("dma-buf: use new iterator in dma_resv_test_signaled") accidentally forgot to test whether the dma-buf is actually signaled,

Re: [PATCH 2/2] dma-buf: Fix dma_resv_test_signaled.

2021-10-15 Thread Maarten Lankhorst
Op 15-10-2021 om 14:07 schreef Christian König: > Am 15.10.21 um 13:57 schrieb Maarten Lankhorst: >> Commit 7fa828cb9265 ("dma-buf: use new iterator in dma_resv_test_signaled") >> accidentally forgot to test whether the dma-buf is actually signaled, >> breaking >> pretty much everything depending

Re: [PATCH 15/15] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Jani Nikula
On Fri, 15 Oct 2021, Claudio Suarez wrote: > Once EDID is parsed, the monitor HDMI support information is available > through drm_display_info.is_hdmi. Retriving the same information with > drm_detect_hdmi_monitor() is less efficient. Change to > drm_display_info.is_hdmi where possible. > > This

Re: [Intel-gfx] [PATCH 15/15] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Ville Syrjälä
On Fri, Oct 15, 2021 at 01:37:13PM +0200, Claudio Suarez wrote: > Once EDID is parsed, the monitor HDMI support information is available > through drm_display_info.is_hdmi. Retriving the same information with > drm_detect_hdmi_monitor() is less efficient. Change to > drm_display_info.is_hdmi where

[PATCH 05/15] drm/tegra: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Retriving the same information with drm_detect_hdmi_monitor() is less efficient. Change to drm_display_info.is_hdmi Signed-off-by: Claudio Suarez --- drivers/gpu/drm/tegra/hdmi.c | 6 +-

[PATCH 04/15] drm/radeon: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Retriving the same information is less efficient. Change to drm_display_info.is_hdmi This is a TODO task in Documentation/gpu/todo.rst Also, correct an inacurracy or bug in

[PATCH 08/15] drm/msm: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Retriving the same information with drm_detect_hdmi_monitor() is less efficient. Change to drm_display_info.is_hdmi Signed-off-by: Claudio Suarez ---

[PATCH 09/15] drm/sun4i: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi. Retriving the same information with drm_detect_hdmi_monitor() is less efficient. Change to drm_display_info.is_hdmi Signed-off-by: Claudio Suarez --- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c |

[PATCH 00/15] replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-15 Thread Claudio Suarez
Copy from the TODO document Documentation/gpu/todo.rst === Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi --- Once EDID is parsed, the monitor HDMI support information is available through drm_display_info.is_hdmi.

  1   2   >