Re: [PATCH v4] drm/radeon/radeon_kms: Fix a NULL pointer dereference in radeon_driver_open_kms()

2021-11-30 Thread Christian König
Am 01.12.21 um 04:22 schrieb Zhou Qingyang: In radeon_driver_open_kms(), radeon_vm_bo_add() is assigned to vm->ib_bo_va and passes and used in radeon_vm_bo_set_addr(). In radeon_vm_bo_set_addr(), there is a dereference of vm->ib_bo_va, which could lead to a NULL pointer dereference on failure of

Re: [RFC PATCH 1/2] dma-fence: Avoid establishing a locking order between fence classes

2021-11-30 Thread Christian König
Am 30.11.21 um 20:27 schrieb Thomas Hellström: On 11/30/21 19:12, Thomas Hellström wrote: On Tue, 2021-11-30 at 16:02 +0100, Christian König wrote: Am 30.11.21 um 15:35 schrieb Thomas Hellström: On Tue, 2021-11-30 at 14:26 +0100, Christian König wrote: Am 30.11.21 um 13:56 schrieb Thomas

Re: [PATCH v3] drm/radeon/radeon_kms: Fix a NULL pointer dereference in radeon_driver_open_kms()

2021-11-30 Thread Christian König
Am 30.11.21 um 16:57 schrieb Zhou Qingyang: In radeon_driver_open_kms(), radeon_vm_bo_add() is assigned to vm->ib_bo_va and passes and used in radeon_vm_bo_set_addr(). In radeon_vm_bo_set_addr(), there is a dereference of vm->ib_bo_va, which could lead to a NULL pointer dereference on failure of

Re: [PATCH v2 1/2] drm/msm: Allocate msm_drm_private early and pass it as driver data

2021-11-30 Thread kernel test robot
Hi AngeloGioacchino, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on next-20211130] [cannot apply to v5.16-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH] drm: rcar-du: add modifiers support

2021-11-30 Thread Esaki Tomohito
Hi Daniel-san, On 2021/11/30 22:20, Daniel Stone wrote: On Tue, 30 Nov 2021 at 08:44, Esaki Tomohito wrote: On 2021/11/18 23:05, Laurent Pinchart wrote: On Thu, Nov 18, 2021 at 01:02:11PM +, Daniel Stone wrote: Laurent's concern is that the DRM core should handle this rather than

[PATCH v3 2/2] drm: rcar-du: Add R-Car DSI driver

2021-11-30 Thread Laurent Pinchart
From: LUU HOAI The driver supports the MIPI DSI/CSI-2 TX encoder found in the R-Car V3U SoC. It currently supports DSI mode only. Signed-off-by: LUU HOAI Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Tested-by: Kieran Bingham Acked-by: Sam Ravnborg --- Changes since v2: -

[PATCH v3 1/2] dt-bindings: display: bridge: Add binding for R-Car MIPI DSI/CSI-2 TX

2021-11-30 Thread Laurent Pinchart
The R-Car MIPI DSI/CSI-2 TX is embedded in the Renesas R-Car V3U SoC. It can operate in either DSI or CSI-2 mode, with up to four data lanes. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Acked-by: Sam Ravnborg Reviewed-by: Rob Herring Reviewed-by: Geert Uytterhoeven ---

[PATCH v3 0/2] R-Car DU: Add DSI encoder driver for V3U

2021-11-30 Thread Laurent Pinchart
Hello, This patch series adds a driver for the DSI encoder found in the R-Car V3U SoC, which is the first SoC in the family that supports DSI. The driver is based on an implementation from the BSP written by Luu Hoai, with lots of further rework. If anyone is interested in the history, a broken

Re: [PATCH v2 2/2] drm: rcar-du: mipi-dsi: Use devm_drm_of_get_bridge helper

2021-11-30 Thread Laurent Pinchart
Hi Kieran, On Tue, Nov 30, 2021 at 04:52:19PM +, Kieran Bingham wrote: > Quoting Kieran Bingham (2021-11-30 16:25:13) > > Instead of open coding the calls for > > drm_of_find_panel_or_bridge() > > devm_drm_panel_bridge_add() > > > > use the devm_drm_of_get_bridge() helper directly. > >

Re: [PATCH v2 1/2] drm: rcar-du: mipi-dsi: Support bridge probe ordering

2021-11-30 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tue, Nov 30, 2021 at 04:25:12PM +, Kieran Bingham wrote: > The bridge probe ordering for DSI devices has been clarified and further > documented in I've read the document and :-) > To support connecting with the SN65DSI86 device after commit

Re: [PATCH] drm/msm/dpu: fix exception in error path

2021-11-30 Thread Bjorn Andersson
On Thu 25 Nov 12:01 CST 2021, Dmitry Baryshkov wrote: > In case of DPU probe failure, prevent the following NULL pointer > exception: > > [3.976112] Unable to handle kernel NULL pointer dereference at virtual > address 0030 > [3.984983] Mem abort info: > [3.987800] ESR

[PATCH] drm/exynos: drop the use of label from exynos_dsi_register_te_irq

2021-11-30 Thread Inki Dae
Dropped the use of 'out' label from exynos_dsi_register_te_irq function because the label isn't needed. This patch returns an error in each error case directly not going to 'out' label. With this patch build warning[1] is also fixed, which was reported by kernel test robot [1]

Re: [Intel-gfx] [PATCH v5] drm/i915: Re-use i915 macros for checking PTEs

2021-11-30 Thread Lucas De Marchi
On Thu, Nov 18, 2021 at 12:54:32PM -0800, Michael Cheng wrote: Certain gen8 ppgtt/gtt functions are using _PAGE_RW and _PAGE_PRESENT to check bits 0 and 1 for PTEs. These macros are defined per architectures, and some architectures do not have these defined (like arm64). This patch replaces

Re: [PATCH v4 2/2] drm/i915: Use to_root_gt() to refer to the root tile

2021-11-30 Thread Lucas De Marchi
On Wed, Dec 01, 2021 at 12:41:08AM +0200, Andi Shyti wrote: Hi Lucas, fist of all thanks for taking a look at this, I was eagerly waiting for reviewers. On Tue, Nov 30, 2021 at 01:07:30PM -0800, Lucas De Marchi wrote: On Sun, Nov 28, 2021 at 01:09:26PM +0200, Andi Shyti wrote: > Starting from

Re: [PATCH v4 1/2] drm/i915: Store backpointer to GT in uncore

2021-11-30 Thread Andi Shyti
Hi, ping! (Lucas?) > We now support a per-gt uncore, yet we're not able to infer which GT > we're operating upon. Let's store a backpointer for now. > > Signed-off-by: Michał Winiarski > Signed-off-by: Matt Roper > Reviewed-by: Andi Shyti > Signed-off-by: Andi Shyti can we merge this,

[PATCH v16 39/40] ARM: tegra: Add Memory Client resets to Tegra30 GR2D, GR3D and Host1x

2021-11-30 Thread Dmitry Osipenko
Memory access must be blocked before hardware reset is asserted and before power is gated, otherwise a serious hardware fault is inevitable. Add reset for memory clients to the GR2D, GR3D and Host1x nodes. Tested-by: Peter Geis # Ouya T30 Tested-by: Matt Merhar # Ouya T30 Signed-off-by: Dmitry

[PATCH v16 20/40] bus: tegra-gmi: Add runtime PM and OPP support

2021-11-30 Thread Dmitry Osipenko
The GMI bus on Tegra belongs to the core power domain and we're going to enable GENPD support for the core domain. Now GMI must be resumed using runtime PM API in order to initialize the GMI power state. Add runtime PM and OPP support to the GMI driver. Reviewed-by: Ulf Hansson Signed-off-by:

[PATCH v16 18/40] drm/tegra: Consolidate runtime PM management of older UAPI codepath

2021-11-30 Thread Dmitry Osipenko
Move runtime PM management of older UAPI code paths into the common place. This removes boilerplate code from client drivers. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/drm.c | 11 ++- drivers/gpu/drm/tegra/gr2d.c | 10 +- drivers/gpu/drm/tegra/gr3d.c | 10

[PATCH v16 14/40] drm/tegra: gr3d: Support generic power domain and runtime PM

2021-11-30 Thread Dmitry Osipenko
Add runtime power management and support generic power domains. Reviewed-by: Ulf Hansson Tested-by: Peter Geis # Ouya T30 Tested-by: Paul Fertser # PAZ00 T20 Tested-by: Nicolas Chauvet # PAZ00 T20 and TK1 T124 Tested-by: Matt Merhar # Ouya T30 Signed-off-by: Dmitry Osipenko ---

[PATCH v16 32/40] soc/tegra: pmc: Rename core power domain

2021-11-30 Thread Dmitry Osipenko
CORE power domain uses name of device-tree node, which is inconsistent with the names of PMC domains. Set the name to "core" to make it consistent. Reviewed-by: Ulf Hansson Signed-off-by: Dmitry Osipenko --- drivers/soc/tegra/pmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v16 22/40] mmc: sdhci-tegra: Add runtime PM and OPP support

2021-11-30 Thread Dmitry Osipenko
The SDHCI on Tegra belongs to the core power domain and we're going to enable GENPD support for the core domain. Now SDHCI must be resumed using runtime PM API in order to initialize the SDHCI power state. The SDHCI clock rate must be changed using OPP API that will reconfigure the power domain

[PATCH v16 17/40] drm/tegra: submit: Remove pm_runtime_enabled() checks

2021-11-30 Thread Dmitry Osipenko
Runtime PM is now universally available, make it mandatory by removing the pm_runtime_enabled() checks. Reviewed-by: Ulf Hansson Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/submit.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git

[PATCH v16 37/40] ARM: tegra: Add OPP tables and power domains to Tegra30 device-trees

2021-11-30 Thread Dmitry Osipenko
Add OPP tables and power domains to all peripheral devices which support power management on Tegra30 SoC. Tested-by: Peter Geis # Ouya T30 Tested-by: Matt Merhar # Ouya T30 Signed-off-by: Dmitry Osipenko --- arch/arm/boot/dts/tegra20-trimslice.dts |2 +-

[PATCH v16 25/40] media: dt: bindings: tegra-vde: Convert to schema

2021-11-30 Thread Dmitry Osipenko
Convert NVIDIA Tegra video decoder binding to schema. Reviewed-by: Rob Herring Acked-by: Hans Verkuil Signed-off-by: Dmitry Osipenko --- .../bindings/media/nvidia,tegra-vde.txt | 64 --- .../bindings/media/nvidia,tegra-vde.yaml | 107 ++ 2 files changed,

[PATCH v16 16/40] drm/tegra: nvdec: Stop channel on suspend

2021-11-30 Thread Dmitry Osipenko
CDMA must be stopped before hardware is suspended. Add channel stopping to RPM suspend callback. Add system level suspend-resume callbacks. Runtime PM initialization is moved to host1x client init phase because RPM callback now uses host1x channel that is available only when host1x client is

[PATCH v16 19/40] usb: chipidea: tegra: Add runtime PM and OPP support

2021-11-30 Thread Dmitry Osipenko
The Tegra USB controller belongs to the core power domain and we're going to enable GENPD support for the core domain. Now USB controller must be resumed using runtime PM API in order to initialize the USB power state. We already support runtime PM for the CI device, but CI's PM is separated from

[PATCH v16 36/40] ARM: tegra: Add OPP tables and power domains to Tegra20 device-trees

2021-11-30 Thread Dmitry Osipenko
Add OPP tables and power domains to all peripheral devices which support power management on Tegra20 SoC. Tested-by: Paul Fertser # PAZ00 T20 Tested-by: Nicolas Chauvet # PAZ00 T20 Signed-off-by: Dmitry Osipenko --- .../boot/dts/tegra20-acer-a500-picasso.dts| 1 +

[PATCH v16 38/40] ARM: tegra: Add Memory Client resets to Tegra20 GR2D, GR3D and Host1x

2021-11-30 Thread Dmitry Osipenko
Memory access must be blocked before hardware reset is asserted and before power is gated, otherwise a serious hardware fault is inevitable. Add reset for memory clients to the GR2D, GR3D and Host1x nodes. Tested-by: Paul Fertser # PAZ00 T20 Tested-by: Nicolas Chauvet # PAZ00 T20 Signed-off-by:

[PATCH v16 21/40] pwm: tegra: Add runtime PM and OPP support

2021-11-30 Thread Dmitry Osipenko
The PWM on Tegra belongs to the core power domain and we're going to enable GENPD support for the core domain. Now PWM must be resumed using runtime PM API in order to initialize the PWM power state. The PWM clock rate must be changed using OPP API that will reconfigure the power domain

[PATCH v16 13/40] drm/tegra: gr2d: Support generic power domain and runtime PM

2021-11-30 Thread Dmitry Osipenko
Add runtime power management and support generic power domains. Reviewed-by: Ulf Hansson Tested-by: Peter Geis # Ouya T30 Tested-by: Paul Fertser # PAZ00 T20 Tested-by: Nicolas Chauvet # PAZ00 T20 and TK1 T124 Tested-by: Matt Merhar # Ouya T30 Signed-off-by: Dmitry Osipenko ---

[PATCH v16 34/40] ARM: tegra: Rename CPU and EMC OPP table device-tree nodes

2021-11-30 Thread Dmitry Osipenko
OPP table name now should start with "opp-table" and OPP entries shouldn't contain commas and @ signs in accordance to the new schema requirement. Reorganize CPU and EMC OPP table device-tree nodes. Signed-off-by: Dmitry Osipenko --- arch/arm/boot/dts/tegra124-apalis-emc.dtsi| 4 +-

[PATCH v16 35/40] ARM: tegra: Add 500MHz entry to Tegra30 memory OPP table

2021-11-30 Thread Dmitry Osipenko
Extend memory OPPs with 500MHz entry. This clock rate is used by ASUS Transformer tablets. Signed-off-by: Dmitry Osipenko --- arch/arm/boot/dts/tegra30-peripherals-opp.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/tegra30-peripherals-opp.dtsi

[PATCH v16 27/40] media: staging: tegra-vde: Support generic power domain

2021-11-30 Thread Dmitry Osipenko
Currently driver supports legacy power domain API, this patch adds generic power domain support. This allows us to utilize a modern GENPD API for newer device-trees. Reviewed-by: Ulf Hansson Tested-by: Peter Geis # Ouya T30 Tested-by: Paul Fertser # PAZ00 T20 Tested-by: Nicolas Chauvet #

[PATCH v16 33/40] soc/tegra: pmc: Enable core domain support for Tegra20 and Tegra30

2021-11-30 Thread Dmitry Osipenko
All device drivers got runtime PM and OPP support. Flip the core domain support status for Tegra20 and Tegra30 SoCs. Reviewed-by: Ulf Hansson Signed-off-by: Dmitry Osipenko --- drivers/soc/tegra/pmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v16 31/40] soc/tegra: pmc: Rename 3d power domains

2021-11-30 Thread Dmitry Osipenko
Device-tree schema doesn't allow domain name to start with a number. We don't use 3d domain yet in device-trees, so rename it to the name used by Tegra TRMs: TD, TD2. Reported-by: David Heidelberg Reviewed-by: Ulf Hansson Signed-off-by: Dmitry Osipenko --- drivers/soc/tegra/pmc.c | 8

[PATCH v16 28/40] soc/tegra: fuse: Reset hardware

2021-11-30 Thread Dmitry Osipenko
The FUSE controller is enabled at a boot time. Reset it in order to put hardware and clock into clean and disabled state. Reviewed-by: Ulf Hansson Signed-off-by: Dmitry Osipenko --- drivers/soc/tegra/fuse/fuse-tegra.c | 25 + drivers/soc/tegra/fuse/fuse.h | 1 +

[PATCH v16 29/40] soc/tegra: fuse: Use resource-managed helpers

2021-11-30 Thread Dmitry Osipenko
Use resource-managed helpers to make code cleaner and more correct, properly releasing all resources in case of driver probe error. Signed-off-by: Dmitry Osipenko --- drivers/soc/tegra/fuse/fuse-tegra.c | 32 ++ drivers/soc/tegra/fuse/fuse-tegra20.c | 33

[PATCH v16 23/40] mtd: rawnand: tegra: Add runtime PM and OPP support

2021-11-30 Thread Dmitry Osipenko
The NAND on Tegra belongs to the core power domain and we're going to enable GENPD support for the core domain. Now NAND must be resumed using runtime PM API in order to initialize the NAND power state. Add runtime PM and OPP support to the NAND driver. Reviewed-by: Ulf Hansson Acked-by: Miquel

[PATCH v16 40/40] ARM: tegra20/30: Disable unused host1x hardware

2021-11-30 Thread Dmitry Osipenko
MPE, VI, EPP and ISP were never used and we don't have drivers for them. Since these modules are enabled by default in a device-tree, a device is created for them, blocking voltage scaling because there is no driver to bind, and thus, state of PMC driver is never synced. Disable them.

[PATCH v16 30/40] soc/tegra: regulators: Prepare for suspend

2021-11-30 Thread Dmitry Osipenko
Depending on hardware version, Tegra SoC may require a higher voltages during resume from system suspend, otherwise hardware will crash. Set SoC voltages to a nominal levels during suspend. Link: https://lore.kernel.org/all/a8280b5b-7347-8995-c97b-10b798cdf...@gmail.com/ Reviewed-by: Ulf Hansson

[PATCH v16 26/40] media: dt: bindings: tegra-vde: Document OPP and power domain

2021-11-30 Thread Dmitry Osipenko
Document new OPP table and power domain properties of the video decoder hardware. Reviewed-by: Rob Herring Acked-by: Hans Verkuil Signed-off-by: Dmitry Osipenko --- .../devicetree/bindings/media/nvidia,tegra-vde.yaml | 12 1 file changed, 12 insertions(+) diff --git

[PATCH v16 15/40] drm/tegra: vic: Stop channel on suspend

2021-11-30 Thread Dmitry Osipenko
CDMA must be stopped before hardware is suspended. Add channel stopping to RPM suspend callback. Add system level suspend-resume callbacks. Runtime PM initialization is moved to host1x client init phase because RPM callback now uses host1x channel that is available only when host1x client is

[PATCH v16 24/40] spi: tegra20-slink: Add OPP support

2021-11-30 Thread Dmitry Osipenko
The SPI on Tegra belongs to the core power domain and we're going to enable GENPD support for the core domain. Now SPI driver must use OPP API for driving the controller's clock rate because OPP API takes care of reconfiguring the domain's performance state in accordance to the rate. Add OPP

[PATCH v16 12/40] drm/tegra: hdmi: Add OPP support

2021-11-30 Thread Dmitry Osipenko
The HDMI on Tegra belongs to the core power domain and we're going to enable GENPD support for the core domain. Now HDMI driver must use OPP API for driving the controller's clock rate because OPP API takes care of reconfiguring the domain's performance state based on HDMI clock rate. Add OPP

[PATCH v16 10/40] drm/tegra: submit: Add missing pm_runtime_mark_last_busy()

2021-11-30 Thread Dmitry Osipenko
Runtime PM auto-suspension doesn't work without pm_runtime_mark_last_busy(), add it. Cc: Reviewed-by: Ulf Hansson Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/submit.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/submit.c

[PATCH v16 07/40] dt-bindings: host1x: Document Memory Client resets of Host1x, GR2D and GR3D

2021-11-30 Thread Dmitry Osipenko
Memory Client should be blocked before hardware reset is asserted in order to prevent memory corruption and hanging of memory controller. Document Memory Client resets of Host1x, GR2D and GR3D hardware units. Reviewed-by: Rob Herring Signed-off-by: Dmitry Osipenko ---

[PATCH v16 03/40] soc/tegra: Don't print error message when OPPs not available

2021-11-30 Thread Dmitry Osipenko
Previously we assumed that devm_tegra_core_dev_init_opp_table() will be used only by drivers that will always have device with OPP table, but this is not true anymore. For example now Tegra30 will have OPP table for PWM, but Tegra20 not and both use the same driver. Hence let's not print the error

[PATCH v16 11/40] drm/tegra: dc: Support OPP and SoC core voltage scaling

2021-11-30 Thread Dmitry Osipenko
Add OPP and SoC core voltage scaling support to the display controller driver. This is required for enabling system-wide DVFS on pre-Tegra186 SoCs. Reviewed-by: Ulf Hansson Tested-by: Peter Geis # Ouya T30 Tested-by: Paul Fertser # PAZ00 T20 Tested-by: Nicolas Chauvet # PAZ00 T20 and TK1 T124

[PATCH v16 09/40] gpu: host1x: Add host1x_channel_stop()

2021-11-30 Thread Dmitry Osipenko
Add host1x_channel_stop() which waits till channel becomes idle and then stops the channel hardware. This is needed for supporting suspend/resume by host1x drivers since the hardware state is lost after power-gating, thus the channel needs to be stopped before client enters into suspend.

[PATCH v16 02/40] soc/tegra: Add devm_tegra_core_dev_init_opp_table_common()

2021-11-30 Thread Dmitry Osipenko
Only couple drivers need to get the -ENODEV error code and majority of drivers need to explicitly initialize the performance state. Add new common helper which sets up OPP table for these drivers. Reviewed-by: Ulf Hansson Signed-off-by: Dmitry Osipenko --- include/soc/tegra/common.h | 15

[PATCH v16 08/40] gpu: host1x: Add initial runtime PM and OPP support

2021-11-30 Thread Dmitry Osipenko
Add runtime PM and OPP support to the Host1x driver. For the starter we will keep host1x always-on because dynamic power management require a major refactoring of the driver code since lot's of code paths are missing the RPM handling and we're going to remove some of these paths in the future.

[PATCH v16 04/40] dt-bindings: clock: tegra-car: Document new clock sub-nodes

2021-11-30 Thread Dmitry Osipenko
Document sub-nodes which describe Tegra SoC clocks that require a higher voltage of the core power domain in order to operate properly on a higher clock rates. Each node contains a phandle to OPP table and power domain. The root PLLs and system clocks don't have any specific device dedicated to

[PATCH v16 06/40] dt-bindings: host1x: Document OPP and power domain properties

2021-11-30 Thread Dmitry Osipenko
Document new DVFS OPP table and power domain properties of the Host1x bus and devices sitting on the bus. Reviewed-by: Rob Herring Signed-off-by: Dmitry Osipenko --- .../display/tegra/nvidia,tegra20-host1x.txt | 49 +++ 1 file changed, 49 insertions(+) diff --git

[PATCH v16 05/40] clk: tegra: Support runtime PM and power domain

2021-11-30 Thread Dmitry Osipenko
The Clock-and-Reset controller resides in a core power domain on NVIDIA Tegra SoCs. In order to support voltage scaling of the core power domain, we hook up DVFS-capable clocks to the core GENPD for managing of the GENPD's performance state based on the clock changes. Some clocks don't have any

[PATCH v16 01/40] soc/tegra: Enable runtime PM during OPP state-syncing

2021-11-30 Thread Dmitry Osipenko
GENPD core now can set up domain's performance state properly while device is RPM-suspended. Runtime PM of a device must be enabled during setup because GENPD checks whether device is suspended and check doesn't work while RPM is disabled. Instead of replicating the boilerplate RPM-enable code

[PATCH v16 00/40] NVIDIA Tegra power management patches for 5.17

2021-11-30 Thread Dmitry Osipenko
This series adds runtime PM support to Tegra drivers and enables core voltage scaling for Tegra20/30 SoCs, resolving overheating troubles. All patches in this series are interdependent and should go via Tegra tree for simplicity. Changelog: v16: - Replaced redundant "context->client" with

[PATCH v2 4/4] drm/tegra: Use dev_err_probe()

2021-11-30 Thread Dmitry Osipenko
Replace dev_printk() with a generic dev_err_probe() helper which silences noisy error messages about deferred probe and makes easy to debug failing deferred probe by printing notification about the failure to KMSG in the end of kernel booting process and by adding failing device and the reason of

[PATCH v2 1/4] gpu/host1x: Add init/deinit callbacks to host1x driver framework

2021-11-30 Thread Dmitry Osipenko
Add init/deinit callbacks to host1x driver framework which allow to perform early pre-initialization required by Tegra DRM driver. Cc: # 5.13+ Signed-off-by: Dmitry Osipenko --- drivers/gpu/host1x/bus.c | 15 +++ include/linux/host1x.h | 4 2 files changed, 19 insertions(+)

[PATCH v2 3/4] drm/tegra: dpaux: Restore DP AUX DDC registration order

2021-11-30 Thread Dmitry Osipenko
Restore DP AUX I2C DDC registration order by moving registration to DP AUX driver probe phase. This fixes broken display panel driver of Acer Chromebook CB5-311 that fails to probe starting with v5.13 kernel when DP AUX registration order was changed to prevent accessing uninitialized

[PATCH v2 2/4] drm/tegra: Create DRM device early

2021-11-30 Thread Dmitry Osipenko
DRM sub-drivers need to access DRM device early during first stage of drivers' probing. Use new host1x init/deinit callbacks to create DRM device early and destroy late. Cc: # 5.13+ Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/drm.c | 46 ++---

[PATCH v2 0/4] Restore Tegra DRM on Nyan Big Chromebook

2021-11-30 Thread Dmitry Osipenko
This patchset restores regressed SOR driver probing on Nyan Chromebook. Changelog: v2: - Changed host1x and Tegra DRM drivers such that DRM device is registered early now. This removes the need to change DRM core. - Introduced dev_err_probe() patch again. Previously Thierry rejected

Re: [PATCH v4 2/2] drm/i915: Use to_root_gt() to refer to the root tile

2021-11-30 Thread Andi Shyti
Hi Lucas, fist of all thanks for taking a look at this, I was eagerly waiting for reviewers. On Tue, Nov 30, 2021 at 01:07:30PM -0800, Lucas De Marchi wrote: > On Sun, Nov 28, 2021 at 01:09:26PM +0200, Andi Shyti wrote: > > Starting from a patch from Matt to_root_gt() returns the > > reference

[PATCH v3] drm/i915/dp: Perform 30ms delay after source OUI write

2021-11-30 Thread Lyude Paul
While working on supporting the Intel HDR backlight interface, I noticed that there's a couple of laptops that will very rarely manage to boot up without detecting Intel HDR backlight support - even though it's supported on the system. One example of such a laptop is the Lenovo P17 1st generation.

[PATCH v10 5/8] MIPS: DTS: jz4780: Account for Synopsys HDMI driver and LCD controllers

2021-11-30 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Here we add jz4780 device tree setup. Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller ---

[PATCH v10 8/8] [RFC] MIPS: DTS: Ingenic: adjust register size to available registers

2021-11-30 Thread H. Nikolaus Schaller
After getting the regmap size from the device tree we should reduce the ranges to the really available registers. This allows to read only existing registers from the debug fs and makes the regmap check out-of-bounds access. For the jz4780 we have done this already. Suggested-for: Paul Cercueil

[PATCH v10 3/8] dt-bindings: display: Add ingenic, jz4780-dw-hdmi DT Schema

2021-11-30 Thread H. Nikolaus Schaller
From: Sam Ravnborg Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. Based on .txt binding from Zubair Lutfullah Kakakhel We also add generic ddc-i2c-bus to synopsys,dw-hdmi.yaml Signed-off-by: Sam Ravnborg Signed-off-by: H. Nikolaus Schaller Cc: Rob Herring Cc:

[PATCH v10 2/8] drm/ingenic: Add support for JZ4780 and HDMI output

2021-11-30 Thread H. Nikolaus Schaller
From: Paul Boddie Add support for the LCD controller present on JZ4780 SoCs. This SoC uses 8-byte descriptors which extend the current 4-byte descriptors used for other Ingenic SoCs. Tested on MIPS Creator CI20 board. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by:

[PATCH v10 7/8] MIPS: defconfig: CI20: configure for DRM_DW_HDMI_JZ4780

2021-11-30 Thread H. Nikolaus Schaller
Enable CONFIG options as modules. Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- arch/mips/configs/ci20_defconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci20_defconfig index

[PATCH v10 6/8] MIPS: DTS: CI20: Add DT nodes for HDMI setup

2021-11-30 Thread H. Nikolaus Schaller
From: Paul Boddie We need to hook up * HDMI connector * HDMI power regulator * JZ4780_CLK_HDMI @ 27 MHz * DDC pinmux * HDMI and LCDC endpoint connections Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/ci20.dts | 72 -

[PATCH v10 4/8] drm/ingenic: Add dw-hdmi driver for jz4780

2021-11-30 Thread H. Nikolaus Schaller
From: Paul Boddie A specialisation of the generic Synopsys HDMI driver is employed for JZ4780 HDMI support. This requires a new driver, plus device tree and configuration modifications. Here we add Kconfig DRM_INGENIC_DW_HDMI, Makefile and driver code. Signed-off-by: Paul Boddie

[PATCH v10 0/8] MIPS: JZ4780 and CI20 HDMI

2021-11-30 Thread H. Nikolaus Schaller
PATCH V10 2021-11-30 22:26:41: - patch 3/8: fix $id and $ref paths (found by r...@kernel.org) PATCH V9 2021-11-24 22:29:14: - patch 6/8: remove optional <0> for assigned-clocks and unintentionally included "unwedge" setup (found by p...@crapouillou.net) - patch 4/8: some cosmetics

[PATCH v10 1/8] drm/ingenic: prepare ingenic drm for later addition of JZ4780

2021-11-30 Thread H. Nikolaus Schaller
This changes the way the regmap is allocated to prepare for the later addition of the JZ4780 which has more registers and bits than the others. Therefore we make the regmap as big as the reg property in the device tree tells. Suggested-by: Paul Cercueil Signed-off-by: H. Nikolaus Schaller ---

Re: [PATCH v4 2/2] drm/i915: Use to_root_gt() to refer to the root tile

2021-11-30 Thread Lucas De Marchi
On Sun, Nov 28, 2021 at 01:09:26PM +0200, Andi Shyti wrote: Starting from a patch from Matt to_root_gt() returns the reference to the root tile in order to abstract the root tile from th callers. Being the root tile identified as tile '0', embed the id in the name so that i915->gt becomes

Re: [PATCH 1/6] Documentation/gpu: Reorganize DC documentation

2021-11-30 Thread Yann Dirson
> On 2021-11-30 10:48 a.m., Harry Wentland wrote: > > On 2021-11-30 10:46, Rodrigo Siqueira Jordao wrote: > >> > >> > >> On 2021-11-29 7:06 a.m., Jani Nikula wrote: > >>> On Fri, 26 Nov 2021, Daniel Vetter wrote: > On Thu, Nov 25, 2021 at 10:38:25AM -0500, Rodrigo Siqueira > wrote: >

Re: [PATCH v2 1/2] drm/input_helper: Add new input-handling helper

2021-11-30 Thread Brian Norris
Hi Pekka, On Fri, Nov 19, 2021 at 12:38:41PM +0200, Pekka Paalanen wrote: > On Thu, 18 Nov 2021 17:46:10 -0800 > Brian Norris wrote: > > On Thu, Nov 18, 2021 at 12:39:28PM +0200, Pekka Paalanen wrote: > > > On Wed, 17 Nov 2021 14:48:40 -0800 > > > Brian Norris wrote: > > > If KMS gets a

Re: linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2021-11-30 Thread Stephen Rothwell
Hi Maxime, On Tue, 30 Nov 2021 09:58:31 +0100 Maxime Ripard wrote: > > Unfortunately the merge resolution isn't entirely correct :/ > > There's multiple conflicts between those two branches on that file, but > things went wrong between 16e101051f32 and 0c980a006d3f > > The first one changes

Re: [PATCH v2] drm/i915/dp: Perform 30ms delay after source OUI write

2021-11-30 Thread Lyude Paul
On Tue, 2021-11-30 at 12:36 +0200, Jani Nikula wrote: > On Mon, 29 Nov 2021, Lyude Paul wrote: > > While working on supporting the Intel HDR backlight interface, I noticed > > that there's a couple of laptops that will very rarely manage to boot up > > without detecting Intel HDR backlight

Re: [PATCH] staging: fbtft: add spi_device_id table

2021-11-30 Thread Heiner Kallweit
On 30.11.2021 09:16, Geert Uytterhoeven wrote: > Hi Heiner, > > On Mon, Nov 29, 2021 at 10:12 PM Heiner Kallweit wrote: >> After 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT >> compatible") we need the following to make the SPI core happy. >> >> Works for me with a SH1106-based

Re: [PATCH 6/6] Documentation/gpu: Add DC glossary

2021-11-30 Thread Yann Dirson
- Mail original - > De: "Rodrigo Siqueira Jordao" > À: ydir...@free.fr, "Rodrigo Siqueira" , "Christian > König" , > "Alex Deucher" > Cc: "Harry Wentland" , "Linux Doc Mailing List" > , "Mark Yacoub" > , "Michel Dänzer" , "Bas > Nieuwenhuizen" , > "Roman Li" , "amd-gfx list" > ,

Re: [PATCH v1 1/2] dt-bindings: sharp, lq101r1sx01: Add compatible for LQ101R1SX03

2021-11-30 Thread Dmitry Osipenko
30.11.2021 18:54, Dmitry Osipenko пишет: > 30.11.2021 00:32, Rob Herring пишет: >> On Sun, Nov 14, 2021 at 11:07:16PM +0300, Dmitry Osipenko wrote: >>> From: Anton Bambura >>> >>> LQ101R1SX03 is compatible with LQ101R1SX01, document it. >> >> Then sounds like '"sharp,lq101r1sx03",

Re: [PATCH v4] drm/i915: Use per device iommu check

2021-11-30 Thread Lucas De Marchi
On Fri, Nov 26, 2021 at 02:14:24PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin With both integrated and discrete Intel GPUs in a system, the current global check of intel_iommu_gfx_mapped, as done from intel_vtd_active() may not be completely accurate. In this patch we add i915

Re: [RFC PATCH 1/2] dma-fence: Avoid establishing a locking order between fence classes

2021-11-30 Thread Thomas Hellström
On 11/30/21 19:12, Thomas Hellström wrote: On Tue, 2021-11-30 at 16:02 +0100, Christian König wrote: Am 30.11.21 um 15:35 schrieb Thomas Hellström: On Tue, 2021-11-30 at 14:26 +0100, Christian König wrote: Am 30.11.21 um 13:56 schrieb Thomas Hellström: On 11/30/21 13:42, Christian König

Re: [Intel-gfx] [PATCH v2 00/16] drm/i915: Remove short term pins from execbuf.

2021-11-30 Thread Tvrtko Ursulin
On 30/11/2021 11:17, Maarten Lankhorst wrote: On 30-11-2021 09:54, Tvrtko Ursulin wrote: Hi, On 29/11/2021 13:47, Maarten Lankhorst wrote: New version of the series, with feedback from previous series added. If there was a cover letter sent for this work in the past could you please

Re: [RFC PATCH 1/2] dma-fence: Avoid establishing a locking order between fence classes

2021-11-30 Thread Thomas Hellström
On Tue, 2021-11-30 at 16:02 +0100, Christian König wrote: > Am 30.11.21 um 15:35 schrieb Thomas Hellström: > > On Tue, 2021-11-30 at 14:26 +0100, Christian König wrote: > > > Am 30.11.21 um 13:56 schrieb Thomas Hellström: > > > > On 11/30/21 13:42, Christian König wrote: > > > > > Am 30.11.21 um

Re: [PATCH 1/3] drm/simpledrm: Bind to OF framebuffers in /chosen

2021-11-30 Thread Rob Herring
On Tue, Nov 30, 2021 at 12:45 AM Javier Martinez Canillas wrote: > > > > > > > > > Simpledrm is just a driver, but this is platform setup code. Why is this > > > > code located here and not under arch/ or drivers/firmware/? > > > > > > Agreed. Creating platform devices is something for platform

Re: [PATCH v9 3/8] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema

2021-11-30 Thread Rob Herring
On Tue, Nov 30, 2021 at 11:03 AM H. Nikolaus Schaller wrote: > > Hi Rob, > > > Am 25.11.2021 um 22:26 schrieb Rob Herring : > > > > On Wed, 24 Nov 2021 22:29:09 +0100, H. Nikolaus Schaller wrote: > >> From: Sam Ravnborg > >> > >> Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. >

Re: [PATCH] drm/komeda: Fix an undefined behavior bug in komeda_plane_add()

2021-11-30 Thread Liviu Dudau
Hi Zhou, On Tue, Nov 30, 2021 at 10:23:01PM +0800, Zhou Qingyang wrote: > In komeda_plane_add(), komeda_get_layer_fourcc_list() is assigned to > formats and used in drm_universal_plane_init(). > drm_universal_plane_init() passes formats to > __drm_universal_plane_init().

[PATCH v3 0/2] Fix mediatek-drm suspend and resume issue

2021-11-30 Thread jason-jh . lin
Change in v3: - fix return typo: modify -NOEDV to -ENODEV. - add missing complete function in ddp_cmdq_cb. Change in v2: - rollback adding cmdq_mbox_flush in cmdq_suspend and add blocking config mode for mtk_drm_crtc_atomic_disable. - add return error when device_link_add fail. - change the

[PATCH v3 1/2] drm/mediatek: add blocking config mode for crtc disable flow

2021-11-30 Thread jason-jh . lin
mtk_drm_crtc_atomic_disable will send an async cmd to cmdq driver, so it may not finish when cmdq_suspend is called sometimes. Change async cmd to blocking cmd for mtk_drm_crtc_atomic_disable to make sure the lastest cmd is done before cmdq_suspend. Signed-off-by: jason-jh.lin ---

[PATCH v3 2/2] drm/mediatek: add devlink to cmdq dev

2021-11-30 Thread jason-jh . lin
Add devlink to cmdq to make sure the order of suspend and resume is correct. Signed-off-by: jason-jh.lin --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c

Re: [PATCH] drm/amdkfd: Fix a wild pointer dereference in svm_range_add()

2021-11-30 Thread Felix Kuehling
Am 2021-11-30 um 11:51 a.m. schrieb philip yang: > > > On 2021-11-30 6:26 a.m., Zhou Qingyang wrote: >> In svm_range_add(), the return value of svm_range_new() is assigned >> to prange and >insert_list is used in list_add(). There is a >> a dereference of >insert_list in list_add(), which could

[PATCH v2 2/2] drm/mediatek: add devlink to cmdq dev

2021-11-30 Thread jason-jh . lin
Add devlink to cmdq to make sure the order of suspend and resume is correct. Signed-off-by: jason-jh.lin --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c

[PATCH v2 0/2] Fix mediatek-drm suspend and resume issue

2021-11-30 Thread jason-jh . lin
Change in v2: - rollback adding cmdq_mbox_flush in cmdq_suspend and add blocking config mode for mtk_drm_crtc_atomic_disable. - add return error when device_link_add fail. - change the first parameter of device_link_add from dev to priv->dev. jason-jh.lin (2): drm/mediatek: add blocking

[PATCH v2 1/2] drm/mediatek: add blocking config mode for crtc disable flow

2021-11-30 Thread jason-jh . lin
mtk_drm_crtc_atomic_disable will send an async cmd to cmdq driver, so it may not finish when cmdq_suspend is called sometimes. Change async cmd to blocking cmd for mtk_drm_crtc_atomic_disable to make sure the lastest cmd is done before cmdq_suspend. Signed-off-by: jason-jh.lin ---

Re: [PATCH v9 3/8] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema

2021-11-30 Thread H. Nikolaus Schaller
Hi Rob, > Am 25.11.2021 um 22:26 schrieb Rob Herring : > > On Wed, 24 Nov 2021 22:29:09 +0100, H. Nikolaus Schaller wrote: >> From: Sam Ravnborg >> >> Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. >> Based on .txt binding from Zubair Lutfullah Kakakhel >> >> We also add

Re: [PATCH v2 2/2] drm: rcar-du: mipi-dsi: Use devm_drm_of_get_bridge helper

2021-11-30 Thread Kieran Bingham
Hi Laurent, Quoting Kieran Bingham (2021-11-30 16:25:13) > Instead of open coding the calls for > drm_of_find_panel_or_bridge() > devm_drm_panel_bridge_add() > > use the devm_drm_of_get_bridge() helper directly. > > Signed-off-by: Kieran Bingham > --- > v2: > - New patch > >

Re: [PATCH] drm/amdkfd: Fix a wild pointer dereference in svm_range_add()

2021-11-30 Thread philip yang
On 2021-11-30 6:26 a.m., Zhou Qingyang wrote: In svm_range_add(), the return value of svm_range_new() is assigned to prange and >insert_list is used in list_add(). There is a a dereference of >insert_list in list_add(), which could lead to a wild pointer

Re: [PATCH v7 0/9] drm/omap: Add virtual-planes support

2021-11-30 Thread Neil Armstrong
Hi Tomi, On 17/11/2021 15:19, Neil Armstrong wrote: > This patchset is the follow-up the v4 patchset from Benoit Parrot at [1]. > > This patch series adds virtual-plane support to omapdrm driver to allow the > use > of display wider than 2048 pixels. > > In order to do so we introduce the

Re: [PATCH] drm/i915: Don't disable interrupts and pretend a lock as been acquired in __timeline_mark_lock().

2021-11-30 Thread Sebastian Andrzej Siewior
On 2021-11-19 17:04:00 [+0100], Daniel Vetter wrote: > Yeah if we can simplify this with reverts then I'm all for this. > > Acked-by: Daniel Vetter > > I've asked drm/i915 maintainers to check Thanks. Should I repost my queue (excluding this one) or should wait until this one has been taken

[PATCH v2 2/2] drm: rcar-du: mipi-dsi: Use devm_drm_of_get_bridge helper

2021-11-30 Thread Kieran Bingham
Instead of open coding the calls for drm_of_find_panel_or_bridge() devm_drm_panel_bridge_add() use the devm_drm_of_get_bridge() helper directly. Signed-off-by: Kieran Bingham --- v2: - New patch drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c | 19 --- 1 file changed, 4

  1   2   >