Re: [PATCH v3 2/2] drm/tidss: Add support for AM625 DSS

2022-07-28 Thread Tomi Valkeinen
On 27/06/2022 18:12, Aradhya Bhatia wrote: Add support for the DSS IP on TI's new AM625 SoC in the tidss driver. Signed-off-by: Aradhya Bhatia Reviewed-by: Rahul T R --- drivers/gpu/drm/tidss/tidss_dispc.c | 56 - drivers/gpu/drm/tidss/tidss_dispc.h | 2 ++

Re: [PATCH] component: try_module_get() to prevent unloading while in use

2022-07-28 Thread Greg KH
On Thu, Jul 28, 2022 at 11:49:57AM +0100, Richard Fitzgerald wrote: > On 26/07/2022 18:28, Greg KH wrote: > > On Tue, Jul 26, 2022 at 11:32:28AM +0100, Richard Fitzgerald wrote: > > > On 25/07/2022 19:09, Greg KH wrote: > > > > On Mon, Jul 25, 2022 at 05:08:59PM +0100, Richard Fitzgerald wrote: >

Re: [PATCH 4/8] drm/tidss: Add support for Dual Link LVDS Bus Format

2022-07-28 Thread Tomi Valkeinen
On 28/07/2022 14:03, Tomi Valkeinen wrote: On 19/07/2022 11:08, Aradhya Bhatia wrote: The 2 OLDI TXes in the AM625 SoC can be synced together to output a 2K resolution video. Add support in the driver for the discovery of such a dual mode connection on the OLDI video port, using the values of

Re: [PATCH v2 00/10] drm: Add driver for PowerPC OF displays

2022-07-28 Thread Michal Suchánek
Hello, On Thu, Jul 28, 2022 at 09:13:59PM +1000, Michael Ellerman wrote: > Thomas Zimmermann writes: > > (was: drm: Add driverof PowerPC OF displays) > > > > PowerPC's Open Firmware offers a simple display buffer for graphics > > output. Add ofdrm, a DRM driver for the device. As with the

Re: [PATCH v6 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

2022-07-28 Thread Daniel Thompson
On Wed, Jul 27, 2022 at 02:24:46PM +0800, ChiaEn Wu wrote: > On Tue, Jul 26, 2022 at 7:59 PM Daniel Thompson > wrote: > > > > > So should we make all 16384 steps of MT6372 available to users? > > > > > > > > Yes. > > > > > > > > > > > > > Does that mean the DTS needs to be modified as well? > > >

Re: [PATCH 8/8] drm/tidss: Enable Dual and Duplicate Modes for OLDI

2022-07-28 Thread Tomi Valkeinen
On 28/07/2022 11:49, Aradhya Bhatia wrote: Hi Tomi, On 28-Jul-22 12:16, Tomi Valkeinen wrote: On 27/07/2022 16:22, Tomi Valkeinen wrote: Hi, On 19/07/2022 11:08, Aradhya Bhatia wrote: The AM625 DSS peripheral supports 2 OLDI TXes which can work to enable 2 duplicated displays of smaller

Re: [PATCH v2 00/10] drm: Add driver for PowerPC OF displays

2022-07-28 Thread Michael Ellerman
Thomas Zimmermann writes: > (was: drm: Add driverof PowerPC OF displays) > > PowerPC's Open Firmware offers a simple display buffer for graphics > output. Add ofdrm, a DRM driver for the device. As with the existing > simpledrm driver, the graphics hardware is pre-initialized by the > firmware.

Re: [PATCH 1/8] dt-bindings: display: ti,am65x-dss: Add port properties for DSS

2022-07-28 Thread Tomi Valkeinen
On 19/07/2022 11:08, Aradhya Bhatia wrote: Add "ti,oldi-mode" property to indicate the tidss driver the OLDI output mode. The 2 OLDI TXes on am625-dss allow a 3 different types of panel connections with the board. 1. Single Link / Single Mode on OLDI TX 0 OR 1. 2. Single Link / Duplicate

Re: [PATCH 4/8] drm/tidss: Add support for Dual Link LVDS Bus Format

2022-07-28 Thread Tomi Valkeinen
On 19/07/2022 11:08, Aradhya Bhatia wrote: The 2 OLDI TXes in the AM625 SoC can be synced together to output a 2K resolution video. Add support in the driver for the discovery of such a dual mode connection on the OLDI video port, using the values of "ti,oldi-mode" property. Signed-off-by:

Re: [PATCH v3 02/13] drm: bridge: Add Samsung DSIM bridge driver

2022-07-28 Thread Adam Ford
On Wed, Jul 20, 2022 at 10:52 AM Jagan Teki wrote: > > Samsung MIPI DSIM controller is common DSI IP that can be used in various > SoCs like Exynos, i.MX8M Mini/Nano. > > In order to access this DSI controller between various platform SoCs, > the ideal way to incorporate this in the drm stack is

Re: [Intel-gfx] [PATCH v2 06/21] drm/i915/gt: Batch TLB invalidations

2022-07-28 Thread Tvrtko Ursulin
On 28/07/2022 07:32, Mauro Carvalho Chehab wrote: On Wed, 27 Jul 2022 13:56:50 +0100 Tvrtko Ursulin wrote: Because vma_invalidate_tlb() basically stores a TLB seqno, but the actual invalidation is deferred to when the pages are unset, at __i915_gem_object_unset_pages(). So, what happens

Re: [PATCH 7/8] drm/tidss: Fix clock request value for OLDI videoports

2022-07-28 Thread Tomi Valkeinen
On 19/07/2022 11:08, Aradhya Bhatia wrote: The OLDI TX(es) require a serial clock which is 7 times the pixel clock of the display panel. When the OLDI is enabled in DSS, the pixel clock input of the corresponding videoport gets a divided-by 7 value of the requested clock. For the am625-dss, the

RE: [PATCH] drm/i915/ttm: don't leak the ccs state

2022-07-28 Thread C, Ramalingam
> -Original Message- > From: Auld, Matthew > Sent: Thursday, July 28, 2022 1:38 PM > To: C, Ramalingam ; intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Thomas Hellström > > Subject: Re: [PATCH] drm/i915/ttm: don't leak the ccs state > > On 28/07/2022 00:16, C,

Re: [PATCH] drm: lcdif: change burst size to 256B

2022-07-28 Thread Marco Felsch
On 22-07-28, Marco Felsch wrote: > On 22-07-28, Liu Ying wrote: > > On Wed, 2022-07-27 at 05:56 +0200, Marco Felsch wrote: > > > Hi Marek, Liu, > > > > > > On 22-07-26, Liu Ying wrote: > > > > On Tue, 2022-07-26 at 16:19 +0200, Marek Vasut wrote: > > > > > On 7/26/22 11:43, Marco Felsch wrote: >

Re: [PATCH] drm: lcdif: change burst size to 256B

2022-07-28 Thread Marco Felsch
On 22-07-28, Liu Ying wrote: > On Wed, 2022-07-27 at 05:56 +0200, Marco Felsch wrote: > > Hi Marek, Liu, > > > > On 22-07-26, Liu Ying wrote: > > > On Tue, 2022-07-26 at 16:19 +0200, Marek Vasut wrote: > > > > On 7/26/22 11:43, Marco Felsch wrote: > > > > > FIFO underruns are seen if a AXI bus

Re: [PATCH v2 0/5] Add Toshiba Visconti DNN image processing accelerator driver

2022-07-28 Thread Greg KH
On Tue, Jul 26, 2022 at 06:09:50AM +, yuji2.ishik...@toshiba.co.jp wrote: > Hi Greg > > Thank you for your comments. > > > -Original Message- > > From: Greg KH > > Sent: Monday, July 25, 2022 9:47 PM > > To: ishikawa yuji(石川 悠司 ○RDC□AITC○EA開) > > > > Cc: Rob Herring ; Hans Verkuil

Re: [PATCH v2 4/5] MAINTAINERS: Add entries for Toshiba Visconti DNN image processing accelerator

2022-07-28 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I

[PULL] drm-intel-fixes

2022-07-28 Thread Tvrtko Ursulin
Hi Dave, Daniel, Just one fix this time round to further improve reliability of resets on execlists platforms in some edge cases. Not sure if there is scope to do one more fixes pull before 5.19 is out so just in case. If it doesn't get pulled we'll send it to stable after release. Regards,

Re: [PATCH] drm/i915/ttm: don't leak the ccs state

2022-07-28 Thread Matthew Auld
On 28/07/2022 00:16, C, Ramalingam wrote: -Original Message- From: Auld, Matthew Sent: Wednesday, July 27, 2022 10:14 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Thomas Hellström ; C, Ramalingam Subject: [PATCH] drm/i915/ttm: don't leak the ccs state

[PATCH] gpu: lontium-lt9611: Fix NULL pointer dereference in lt9611_connector_init()

2022-07-28 Thread Zeng Jingxiang
From: Zeng Jingxiang A NULL check for bridge->encoder shows that it may be NULL, but it already been dereferenced on all paths leading to the check. 812 if (!bridge->encoder) { Dereference the pointer bridge->encoder. 810 drm_connector_attach_encoder(>connector, bridge->encoder);

BUG: unable to handle kernel paging request in imageblit

2022-07-28 Thread Dipanjan Das
Hi, We would like to report the following bug which has been found by our modified version of syzkaller. == description: BUG: unable to handle kernel paging request in imageblit affected file: drivers/gpu/drm/drm_fb_helper.c kernel version:

[PATCH v3] staging: fbtft: core: set smem_len before fb_deferred_io_init call

2022-07-28 Thread Peter Suti
The fbtft_framebuffer_alloc() calls fb_deferred_io_init() before initializing info->fix.smem_len. It is set to zero by the framebuffer_alloc() function. It will trigger a WARN_ON() at the start of fb_deferred_io_init() and the function will not do anything. Fixes: 856082f021a2 ("fbdev: defio:

[PATCH] drm/udl: Enable damage clipping

2022-07-28 Thread Thomas Zimmermann
Call drm_plane_enable_fb_damage_clips() and give userspace a chance of minimizing the updated display area. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/udl_modeset.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/udl/udl_modeset.c

Re: [RFC PATCH v3 04/19] KVM: x86: mmu: allow to enable write tracking externally

2022-07-28 Thread Maxim Levitsky
On Mon, 2022-07-25 at 16:08 +, Sean Christopherson wrote: > On Wed, Jul 20, 2022, Maxim Levitsky wrote: > > On Sun, 2022-05-22 at 13:22 +0300, Maxim Levitsky wrote: > > > On Thu, 2022-05-19 at 16:37 +, Sean Christopherson wrote: > > > > On Wed, Apr 27, 2022, Maxim Levitsky wrote: > > > > >

Re: [PATCH 12/12] drm/format-helper: Move destination-buffer handling into internal helper

2022-07-28 Thread Thomas Zimmermann
Hi Am 28.07.22 um 09:26 schrieb José Expósito: Hi! On Wed, Jul 27, 2022 at 01:33:12PM +0200, Thomas Zimmermann wrote: The format-convertion helpers handle several cases for different values of destination buffer and pitch. Move that code into the internal helper drm_fb_xfrm() and avoid quite

[PATCH] drm/udl: Restore display mode on resume

2022-07-28 Thread Thomas Zimmermann
Restore the display mode whne resuming from suspend. Currently, the display remains dark. On resume, the CRTC's mode does not change, but the 'active' flag changes to 'true'. Taking this into account when considering a mode switch restores the display mode. The bug is reproducable by using Gnome

Re: [PATCH 04/12] drm/format-helper: Rework XRGB8888-to-RGBG332 conversion

2022-07-28 Thread Thomas Zimmermann
Hi Am 28.07.22 um 09:13 schrieb José Expósito: Hi Thomas, On Wed, Jul 27, 2022 at 01:33:04PM +0200, Thomas Zimmermann wrote: Update XRGB-to-RGB332 conversion to support struct iosys_map and convert all users. Although these are single-plane color formats, the new interface supports

Re: [PATCH 12/12] drm/format-helper: Move destination-buffer handling into internal helper

2022-07-28 Thread José Expósito
Hi! On Wed, Jul 27, 2022 at 01:33:12PM +0200, Thomas Zimmermann wrote: > The format-convertion helpers handle several cases for different > values of destination buffer and pitch. Move that code into the > internal helper drm_fb_xfrm() and avoid quite a bit of duplucation. > > Signed-off-by:

Re: [Intel-gfx] [PATCH v2 06/21] drm/i915/gt: Batch TLB invalidations

2022-07-28 Thread Mauro Carvalho Chehab
On Thu, 28 Jul 2022 08:32:32 +0200 Mauro Carvalho Chehab wrote: > On Wed, 27 Jul 2022 13:56:50 +0100 > Tvrtko Ursulin wrote: > > > > Because vma_invalidate_tlb() basically stores a TLB seqno, but the > > > actual invalidation is deferred to when the pages are unset, at > > >

Re: [PATCH 04/12] drm/format-helper: Rework XRGB8888-to-RGBG332 conversion

2022-07-28 Thread José Expósito
Hi Thomas, On Wed, Jul 27, 2022 at 01:33:04PM +0200, Thomas Zimmermann wrote: > Update XRGB-to-RGB332 conversion to support struct iosys_map > and convert all users. Although these are single-plane color formats, > the new interface supports multi-plane formats for consistency with >

Re: [PATCH v2] drm/ttm: Fix dummy res NULL ptr deref bug

2022-07-28 Thread Arunpravin Paneer Selvam
Hi Andre, On 7/27/2022 8:56 PM, André Almeida wrote: Hi Arunpravin, Às 02:30 de 27/07/22, Arunpravin Paneer Selvam escreveu: Check the bo->resource value before accessing the resource mem_type. v2: Fix commit description unwrapped warning [ 40.191227][ T184] general protection fault,

Re: [PATCH 8/8] drm/tidss: Enable Dual and Duplicate Modes for OLDI

2022-07-28 Thread Tomi Valkeinen
On 27/07/2022 16:22, Tomi Valkeinen wrote: Hi, On 19/07/2022 11:08, Aradhya Bhatia wrote: The AM625 DSS peripheral supports 2 OLDI TXes which can work to enable 2 duplicated displays of smaller resolutions or enable a single Dual-Link display with a higher resolution (1920x1200). Configure

Re: [Intel-gfx] [PATCH v2 06/21] drm/i915/gt: Batch TLB invalidations

2022-07-28 Thread Mauro Carvalho Chehab
On Wed, 27 Jul 2022 13:56:50 +0100 Tvrtko Ursulin wrote: > > Because vma_invalidate_tlb() basically stores a TLB seqno, but the > > actual invalidation is deferred to when the pages are unset, at > > __i915_gem_object_unset_pages(). > > > > So, what happens is: > > > > - on VMA sync mode, the

Re: [PATCH 1/8] dt-bindings: display: ti,am65x-dss: Add port properties for DSS

2022-07-28 Thread Tomi Valkeinen
On 22/07/2022 19:16, Nishanth Menon wrote: On 17:28-20220720, Rob Herring wrote: On the bridge side R0->R2, G0->G1, B0->B2 would be tied to ground. The bridge sees 24bits of data, but the lsb's are always zero. Unless the bridge ignores the LSBs, that's not the right way to do 16 to 24 bit.

[drm-tip:drm-tip 4/8] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:1565:27: error: 'drm_primary_helper_destroy' undeclared here (not in a function); did you mean 'drm_plane_helper

2022-07-28 Thread kernel test robot
-randconfig-r003-20220728 (https://download.01.org/0day-ci/archive/20220728/202207281420.mnf0xrnj-...@intel.com/config) compiler: alpha-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross

<    1   2