Re: [PATCH v3 1/6] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195

2022-09-20 Thread Jason-JH Lin
Hi Krzysztof, Thanks for the reviews. On Tue, 2022-09-20 at 17:25 +0200, Krzysztof Kozlowski wrote: > On 20/09/2022 16:01, Jason-JH.Lin wrote: > > For previous MediaTek SoCs, such as MT8173, there are 2 display HW > > pipelines binding to 1 mmsys with the same power domain, the same > > clock

[PATCH] drm/hisilicon/kirin: Fix typo in kirin_drm_drv.c

2022-09-20 Thread Jammy Huang
'config_max_height' should be used for 'max_height'. Signed-off-by: Jammy Huang --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c

[PATCH v4 15/15] vfio: Add struct device to vfio_device

2022-09-20 Thread Kevin Tian
From: Yi Liu and replace kref. With it a 'vfio-dev/vfioX' node is created under the sysfs path of the parent, indicating the device is bound to a vfio driver, e.g.: /sys/devices/pci\:6f/\:6f\:01.0/vfio-dev/vfio0 It is also a preparatory step toward adding cdev for supporting future

[PATCH v4 14/15] vfio: Rename vfio_device_put() and vfio_device_try_get()

2022-09-20 Thread Kevin Tian
With the addition of vfio_put_device() now the names become confusing. vfio_put_device() is clear from object life cycle p.o.v given kref. vfio_device_put()/vfio_device_try_get() are helpers for tracking users on a registered device. Now rename them: - vfio_device_put() ->

[PATCH v4 13/15] vfio/ccw: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
ccw is the only exception which cannot use vfio_alloc_device() because its private device structure is designed to serve both mdev and parent. Life cycle of the parent is managed by css_driver so vfio_ccw_private must be allocated/freed in css_driver probe/remove path instead of conforming to vfio

[PATCH v4 12/15] vfio/amba: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
Implement amba's own vfio_device_ops. Remove vfio_platform_probe/remove_common() given no user now. Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe Reviewed-by: Eric Auger --- drivers/vfio/platform/vfio_amba.c | 72 ++-

[PATCH v4 11/15] vfio/platform: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
Move vfio_device_ops from platform core to platform drivers so device specific init/cleanup can be added. Introduce two new helpers vfio_platform_init/release_common() for the use in driver @init/@release. vfio_platform_probe/remove_common() will be deprecated. Signed-off-by: Kevin Tian

[PATCH v4 10/15] vfio/fsl-mc: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
From: Yi Liu Also add a comment to mark that vfio core releases device_set if @init fails. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/vfio/fsl-mc/vfio_fsl_mc.c | 85 ++- 1 file changed, 49 insertions(+), 36

[PATCH v4 09/15] vfio/ap: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
From: Yi Liu and manage available_instances inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Tony Krowiak Reviewed-by: Jason Gunthorpe --- drivers/s390/crypto/vfio_ap_ops.c | 50 ++- 1 file changed, 29 insertions(+), 21

[PATCH v4 08/15] drm/i915/gvt: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
Move vfio_device to the start of intel_vgpu as required by the new helpers. Change intel_gvt_create_vgpu() to use intel_vgpu as the first param as other vgpu helpers do. Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe Reviewed-by: Zhenyu Wang --- drivers/gpu/drm/i915/gvt/gvt.h | 5

[PATCH v4 07/15] vfio/mbochs: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
From: Yi Liu and manage avail_mbytes inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- samples/vfio-mdev/mbochs.c | 73 -- 1 file changed, 46 insertions(+), 27 deletions(-) diff --git

[PATCH v4 06/15] vfio/mtty: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
From: Yi Liu and manage available ports inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- samples/vfio-mdev/mtty.c | 67 +++- 1 file changed, 39 insertions(+), 28 deletions(-) diff --git

[PATCH v4 05/15] vfio/mdpy: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
From: Yi Liu and manage mdpy_count inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- samples/vfio-mdev/mdpy.c | 81 +++- 1 file changed, 47 insertions(+), 34 deletions(-) diff --git

[PATCH v4 04/15] vfio/hisi_acc: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
From: Yi Liu Tidy up @probe so all migration specific initialization logic is moved to migration specific @init callback. Remove vfio_pci_core_{un}init_device() given no user now. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe Reviewed-by: Shameer Kolothum ---

[PATCH v4 03/15] vfio/mlx5: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
From: Yi Liu mlx5 has its own @init/@release for handling migration cap. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/vfio/pci/mlx5/main.c | 50 ++-- 1 file changed, 36 insertions(+), 14 deletions(-) diff --git

[PATCH v4 02/15] vfio/pci: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
From: Yi Liu Also introduce two pci core helpers as @init/@release for pci drivers: - vfio_pci_core_init_dev() - vfio_pci_core_release_dev() Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/vfio/pci/vfio_pci.c | 20 +-

[PATCH v4 01/15] vfio: Add helpers for unifying vfio_device life cycle

2022-09-20 Thread Kevin Tian
The idea is to let vfio core manage the vfio_device life cycle instead of duplicating the logic cross drivers. This is also a preparatory step for adding struct device into vfio_device. New pair of helpers together with a kref in vfio_device: - vfio_alloc_device() - vfio_put_device() Drivers

[PATCH v4 00/15] Tidy up vfio_device life cycle

2022-09-20 Thread Kevin Tian
The idea is to let vfio core manage the vfio_device life cycle instead of duplicating the logic cross drivers. Besides cleaner code in driver side this also allows adding struct device to vfio_device as the first step toward adding cdev uAPI in the future. Another benefit is that user can now look

Re: [PATCH v1 01/17] dt-bindings: clk: mediatek: Add MT8195 DPI clocks

2022-09-20 Thread Bo-Chen Chen
On Mon, 2022-09-19 at 18:55 +0200, Guillaume Ranquet wrote: > From: Pablo Sun > > Expand dt-bindings slot for VDOSYS1 of MT8195. > This clock is required by the DPI1 hardware > and is a downstream of the HDMI pixel clock. > > Signed-off-by: Pablo Sun > Signed-off-by: Guillaume Ranquet >

Re: [PATCH v9 09/10] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

2022-09-20 Thread ChiaEn Wu
On Sun, Sep 18, 2022 at 3:22 AM Han Jingoo wrote: > > On Mon, Aug 29, 2022 ChiaEn Wu wrote: ... > > +#define MT6370_ITORCH_MIN_uA 25000 > > +#define MT6370_ITORCH_STEP_uA 12500 > > +#define MT6370_ITORCH_MAX_uA 40 > > +#define MT6370_ITORCH_DOUBLE_MAX_uA

Re: [PATCH v6,3/3] drm: mediatek: Add mt8186 dpi compatible to mtk_dpi.c

2022-09-20 Thread CK Hu
Hi, Xinlei: On Wed, 2022-09-14 at 21:21 +0800, xinlei@mediatek.com wrote: > From: Xinlei Lee > > Add the compatible because use edge_cfg_in_mmsys in mt8186. > > Signed-off-by: Xinlei Lee > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 21 + >

Re: [PATCH v6,2/3] drm: mediatek: Adjust the dpi output format to MT8186

2022-09-20 Thread CK Hu
Hi, Xinlei: On Wed, 2022-09-14 at 21:21 +0800, xinlei@mediatek.com wrote: > From: Xinlei Lee > > Dpi output needs to adjust the output format to dual edge for MT8186. > The bridge ic on MT8186 uses the output format of RGB888_dual_edge. I think different sink ic may support different

[PATCH -next] drm/amd/display: clean up one inconsistent indenting

2022-09-20 Thread Yang Li
clean up one inconsistent indenting https://bugzilla.openanolis.cn/show_bug.cgi?id=2238 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dcn321/dcn321_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/2] drm/amd/display: Reduce number of arguments of dml314's CalculateWatermarksAndDRAMSpeedChangeSupport()

2022-09-20 Thread Alex Deucher
On Tue, Sep 20, 2022 at 7:48 PM Nathan Chancellor wrote: > > On Tue, Sep 20, 2022 at 12:06:46PM -0400, Alex Deucher wrote: > > Applied the series. Thanks! > > Great, thank you so much! Hopefully these could also be applied to the > 6.0 branch so that this error can be resolved there as well. No

Re: [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-09-20 Thread Dixit, Ashutosh
On Fri, 16 Sep 2022 08:00:50 -0700, Badal Nilawar wrote: > > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > index e2974f928e58..bc061238e35c 100644 > --- a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon >

Re: [PATCH 1/2] drm/amd/display: Reduce number of arguments of dml314's CalculateWatermarksAndDRAMSpeedChangeSupport()

2022-09-20 Thread Nathan Chancellor
On Tue, Sep 20, 2022 at 12:06:46PM -0400, Alex Deucher wrote: > Applied the series. Thanks! Great, thank you so much! Hopefully these could also be applied to the 6.0 branch so that this error can be resolved there as well. No worries on timeline if that was already the plan but I just want to

Re: [PATCH v4] drm/msm/dp: add atomic_check to bridge ops

2022-09-20 Thread Abhinav Kumar
On 9/20/2022 3:25 PM, Kuogee Hsieh wrote: DRM commit_tails() will disable downstream crtc/encoder/bridge if both disable crtc is required and crtc->active is set before pushing a new frame downstream. There is a rare case that user space display manager issue an extra screen update

Re: [BUG] ls1046a: eDMA does not transfer data from I2C

2022-09-20 Thread Sean Anderson
On 9/20/22 6:49 PM, Leo Li wrote: > > >> -Original Message- >> From: Sean Anderson >> Sent: Tuesday, September 20, 2022 11:21 AM >> To: Robin Murphy ; Oleksij Rempel >> ; Pengutronix Kernel Team >> ; linux-...@vger.kernel.org; linux-arm-kernel >> ; Vinod Koul ; >>

RE: [BUG] ls1046a: eDMA does not transfer data from I2C

2022-09-20 Thread Leo Li
> > > > Despite the DMA completing successfully, no data was copied into the > > buffer, leaving the original (now junk) contents. I probed the I2C bus > > with an oscilloscope, and I verified that the transfer did indeed occur. > > The timing between submission and completion seems reasonable for

RE: [PATCH v3 15/15] vfio: Add struct device to vfio_device

2022-09-20 Thread Tian, Kevin
> From: Alex Williamson > Sent: Wednesday, September 21, 2022 4:27 AM > > On Fri, 9 Sep 2022 18:22:47 +0800 > Kevin Tian wrote: > > > From: Yi Liu > > > > and replace kref. With it a 'vfio-dev/vfioX' node is created under the > > sysfs path of the parent, indicating the device is bound to a

RE: [PATCH v3 06/15] vfio/mtty: Use the new device life cycle helpers

2022-09-20 Thread Tian, Kevin
> From: Alex Williamson > Sent: Wednesday, September 21, 2022 3:17 AM > > On Fri, 9 Sep 2022 18:22:38 +0800 > Kevin Tian wrote: > > > From: Yi Liu > > > > and manage available ports inside @init/@release. > > > > Signed-off-by: Yi Liu > > Signed-off-by: Kevin Tian > > Reviewed-by: Jason

RE: [BUG] ls1046a: eDMA does not transfer data from I2C

2022-09-20 Thread Leo Li
> -Original Message- > From: Sean Anderson > Sent: Tuesday, September 20, 2022 11:21 AM > To: Robin Murphy ; Oleksij Rempel > ; Pengutronix Kernel Team > ; linux-...@vger.kernel.org; linux-arm-kernel > ; Vinod Koul ; > dmaeng...@vger.kernel.org; Leo Li ; Laurentiu Tudor > > Cc: Linux

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Andi Shyti
Hi Matt, Lucas, thanks for your feedback, > > > + switch (gms) { > > > + case 0x0 ... 0x10: > > > + return gms * 32; > > > + case 0x20: > > > + return 1024; > > > + case 0x30: > > > + return 1536; > > > + case 0x40: > > > + return 2048; > > > + case 0xf0 ... 0xfe:

[PATCH v2 3/3] drm/meson: remove drm bridges at aggregate driver unbind time

2022-09-20 Thread Adrián Larumbe
drm bridges added by meson_encoder_hdmi_init and meson_encoder_cvbs_init were not manually removed at module unload time, which caused dangling references to freed memory to remain linked in the global bridge_list. When loading the driver modules back in, the same functions would again call

[PATCH v4] drm/msm/dp: add atomic_check to bridge ops

2022-09-20 Thread Kuogee Hsieh
DRM commit_tails() will disable downstream crtc/encoder/bridge if both disable crtc is required and crtc->active is set before pushing a new frame downstream. There is a rare case that user space display manager issue an extra screen update immediately followed by close DRM device while down

Re: [PATCH 2/2] drm/panfrost: replace endian-specific types with generic ones

2022-09-20 Thread Alyssa Rosenzweig
Tentative r-b, but we *do* need to make a decision on how we want to handle endianness. I don't have strong feelings but the results of that discussion should go in the commit message. On Tue, Sep 20, 2022 at 10:15:45PM +0100, Adri??n Larumbe wrote: > __le32 and __l64 endian-specific types aren't

[linux-next:master] BUILD REGRESSION ef08d387bbbc20df740ced8caee0ffac835869ac

2022-09-20 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: ef08d387bbbc20df740ced8caee0ffac835869ac Add linux-next specific files for 20220920 Error/Warning reports: https://lore.kernel.org/linux-mm/202209150141.wgbakqmx-...@intel.com https

Re: [PATCH] drm/i915: Perf_limit_reasons are only available for Gen11+

2022-09-20 Thread Rodrigo Vivi
On Mon, Sep 19, 2022 at 09:24:01AM -0700, Ashutosh Dixit wrote: > Register GT0_PERF_LIMIT_REASONS (0x1381a8) is available only for > Gen11+. Therefore ensure perf_limit_reasons sysfs/debugfs files are created > only for Gen11+. Otherwise on Gen < 5 accessing these files results in the > following

[PATCH 1/2] drm/panfrost: Remove type name from internal structs

2022-09-20 Thread Adrián Larumbe
From: Steven Price The two structs internal to struct panfrost_dump_object_header were named, but sadly that is incompatible with C++, causing an error: "an anonymous union may only have public non-static data members". However nothing refers to struct pan_reg_hdr and struct pan_bomap_hdr and

[PATCH 2/2] drm/panfrost: replace endian-specific types with generic ones

2022-09-20 Thread Adrián Larumbe
__le32 and __l64 endian-specific types aren't portable and not available on FreeBSD, for which there's a uAPI compatible reimplementation of Panfrost. Replace these specific types with more generic unsigned ones, to prevent FreeBSD Mesa build errors. Bug:

Re: [PATCH V2 2/2] drm/panel: Add Samsung AMS495QA01 MIPI-DSI LCD panel

2022-09-20 Thread Chris Morgan
On Tue, Sep 20, 2022 at 07:33:00PM +0200, Maya Matuszczyk wrote: > Hi Chris, > Thanks for this patch, > > wt., 20 wrz 2022 o 19:10 Chris Morgan napisał(a): > > > > From: Chris Morgan > > > > Support Samsung AMS495QA01 panel as found on the Anbernic RG503. Note > > This panel receives video

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Matt Roper
On Tue, Sep 20, 2022 at 06:57:46PM +0200, Andi Shyti wrote: > Hi Aravind, > > > +static int get_mtl_gms_size(struct intel_uncore *uncore) > > +{ > > + u16 ggc, gms; > > + > > + ggc = intel_uncore_read16(uncore, _MMIO(0x108040)); > > + > > + /* check GGMS, should be fixed 0x3 (8MB) */ > > +

Re: [PATCH v3 15/15] vfio: Add struct device to vfio_device

2022-09-20 Thread Alex Williamson
On Fri, 9 Sep 2022 18:22:47 +0800 Kevin Tian wrote: > From: Yi Liu > > and replace kref. With it a 'vfio-dev/vfioX' node is created under the > sysfs path of the parent, indicating the device is bound to a vfio > driver, e.g.: > > /sys/devices/pci\:6f/\:6f\:01.0/vfio-dev/vfio0 > >

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Lucas De Marchi
On Tue, Sep 20, 2022 at 01:31:49AM -0700, Lucas De Marchi wrote: On Tue, Sep 20, 2022 at 12:49:40PM +0530, Aravind Iddamsetty wrote: As an integrated GPU, MTL does not have local memory and HAS_LMEM() returns false. However the platform's stolen memory is presented via BAR2 (i.e., the BAR we

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Lucas De Marchi
On Tue, Sep 20, 2022 at 06:57:46PM +0200, Andi Shyti wrote: Hi Aravind, +static int get_mtl_gms_size(struct intel_uncore *uncore) +{ + u16 ggc, gms; + + ggc = intel_uncore_read16(uncore, _MMIO(0x108040)); + + /* check GGMS, should be fixed 0x3 (8MB) */ + if ((ggc &

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/dgfx: Make failure to setup stolen non-fatal

2022-09-20 Thread Wayne Boyer
On 9/16/22 10:36 AM, Lucas De Marchi wrote: There is no reason to consider the setup of Data Stolen Memory fatal on dgfx and non-fatal on integrated. Move the debug and error propagation around so both have the same behavior: non-fatal. Before this change, loading i915 on a system with TGL +

Re: [PATCH v3 06/15] vfio/mtty: Use the new device life cycle helpers

2022-09-20 Thread Alex Williamson
On Fri, 9 Sep 2022 18:22:38 +0800 Kevin Tian wrote: > From: Yi Liu > > and manage available ports inside @init/@release. > > Signed-off-by: Yi Liu > Signed-off-by: Kevin Tian > Reviewed-by: Jason Gunthorpe > --- > samples/vfio-mdev/mtty.c | 67 +++- >

Re: [PATCH v2 2/3] drm/i915: Split i915_gem_init_stolen()

2022-09-20 Thread Wayne Boyer
On 9/16/22 10:36 AM, Lucas De Marchi wrote: Add some helpers: adjust_stolen(), request_smem_stolen_() and init_reserved_stolen() that are now called by i915_gem_init_stolen() to initialize each part of the Data Stolen Memory region. Main goal is to split the reserved part within the stolen,

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Add missing mask when reading GEN12_DSMBASE

2022-09-20 Thread Wayne Boyer
On 9/16/22 10:36 AM, Lucas De Marchi wrote: DSMBASE register is defined so BDSM bitfield contains the bits 63 to 20 of the base address of stolen. For the supported platforms bits 0-19 are zero but that may not be true in future. Add the missing mask. v2: Use REG_GENMASK64() Acked-by:

Re: [PATCH v3] drm/sched: Add FIFO sched policy to run queue v3

2022-09-20 Thread Andrey Grodzovsky
On 2022-09-19 23:11, Luben Tuikov wrote: Please run this patch through checkpatch.pl, as it shows 12 warnings with it. Use these command line options: "--strict --show-types". Inlined: On 2022-09-13 16:40, Andrey Grodzovsky wrote: Given many entities competing for same run queue on the same

Re: [PATCH V2 1/2] dt-bindings: display: panel: Add Samsung AMS495QA01 bindings

2022-09-20 Thread Maya Matuszczyk
Hello, Thanks for the patch, It's so nice seeing more pieces of RG503 being upstreamed. wt., 20 wrz 2022 o 19:10 Chris Morgan napisał(a): > > From: Chris Morgan > > Add documentation for the Samsung AMS495QA01 panel. > > Signed-off-by: Chris Morgan > --- >

Re: [PATCH V2 2/2] drm/panel: Add Samsung AMS495QA01 MIPI-DSI LCD panel

2022-09-20 Thread Maya Matuszczyk
Hi Chris, Thanks for this patch, wt., 20 wrz 2022 o 19:10 Chris Morgan napisał(a): > > From: Chris Morgan > > Support Samsung AMS495QA01 panel as found on the Anbernic RG503. Note > This panel receives video signals via DSI, however it receives > commands via 3-wire SPI. > > Signed-off-by:

[PATCH v7 3/5] drm/bridge: cdns-dsi: Move to drm/bridge/cadence

2022-09-20 Thread Rahul T R
Move the cadence dsi bridge under drm/bridge/cadence directory, to prepare for adding j721e wrapper support Signed-off-by: Rahul T R --- drivers/gpu/drm/bridge/Kconfig| 11 --- drivers/gpu/drm/bridge/Makefile | 1 -

Re: [PATCH] drm/i915: Do not cleanup obj with NULL bo->resource

2022-09-20 Thread Matthew Auld
On 20/09/2022 18:06, Nirmoy Das wrote: For delayed BO release i915_ttm_delete_mem_notify() gets called twice, once with proper bo->resource and another time with NULL. We shouldn't do anything for the 2nd time as we already cleanedup the obj once. References:

[PATCH V2 1/2] dt-bindings: display: panel: Add Samsung AMS495QA01 bindings

2022-09-20 Thread Chris Morgan
From: Chris Morgan Add documentation for the Samsung AMS495QA01 panel. Signed-off-by: Chris Morgan --- .../display/panel/samsung,ams495qa01.yaml | 46 +++ 1 file changed, 46 insertions(+) create mode 100644

[PATCH V2 2/2] drm/panel: Add Samsung AMS495QA01 MIPI-DSI LCD panel

2022-09-20 Thread Chris Morgan
From: Chris Morgan Support Samsung AMS495QA01 panel as found on the Anbernic RG503. Note This panel receives video signals via DSI, however it receives commands via 3-wire SPI. Signed-off-by: Chris Morgan --- drivers/gpu/drm/panel/Kconfig | 10 +

[PATCH V2 0/2] drm/panel: Add Samsung AMS495QA01 Panel

2022-09-20 Thread Chris Morgan
From: Chris Morgan Add the Samsung AMS495QA01 panel as found on the Anbernic RG503. This panel uses DSI to receive video signals, but 3-wire SPI to receive command signals. Changes since V1: - Removed errant reference to backlight in documentation. This is an OLED panel. - Made elvss

[PATCH] drm/i915: Do not cleanup obj with NULL bo->resource

2022-09-20 Thread Nirmoy Das
For delayed BO release i915_ttm_delete_mem_notify() gets called twice, once with proper bo->resource and another time with NULL. We shouldn't do anything for the 2nd time as we already cleanedup the obj once. References: https://gitlab.freedesktop.org/drm/intel/-/issues/6850 Signed-off-by: Nirmoy

Re: [PATCH v2] A simple doc fix

2022-09-20 Thread Andrey Grodzovsky
After rebasing to latest drm-misc-next to latest I actually see someone else already fixed this and other kerneldoc warnings so we can skip this patch. Andrey On 2022-09-20 02:46, Anup K Parikh wrote: Fix two warnings during doc build which also results in corresponding additions in

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Andi Shyti
Hi Aravind, > +static int get_mtl_gms_size(struct intel_uncore *uncore) > +{ > + u16 ggc, gms; > + > + ggc = intel_uncore_read16(uncore, _MMIO(0x108040)); > + > + /* check GGMS, should be fixed 0x3 (8MB) */ > + if ((ggc & 0xc0) != 0xc0) > + return -EIO; > + > + /*

[PATCH v7 4/5] drm/bridge: cdns-dsi: Create a header file

2022-09-20 Thread Rahul T R
Create a header file for cdns dsi and move register offsets and structure to header, to prepare for adding j721e wrapper support Signed-off-by: Rahul T R --- .../gpu/drm/bridge/cadence/cdns-dsi-core.c| 446 + .../gpu/drm/bridge/cadence/cdns-dsi-core.h| 458

Re: [PATCH v2] A simple doc fix

2022-09-20 Thread Andrey Grodzovsky
Reviewed-by: Andrey Grodzovsky Will push it to drm-misc-next Thanks, Andrey On 2022-09-20 02:46, Anup K Parikh wrote: Fix two warnings during doc build which also results in corresponding additions in generated docs Warnings Fixed: 1. include/drm/gpu_scheduler.h:462: warning: Function

Re: [BUG] ls1046a: eDMA does not transfer data from I2C

2022-09-20 Thread Sean Anderson
On 9/20/22 11:44 AM, Sean Anderson wrote: > > > On 9/20/22 11:24 AM, Sean Anderson wrote: >> >> >> On 9/20/22 6:07 AM, Robin Murphy wrote: >>> On 2022-09-19 23:24, Sean Anderson wrote: Hi all, I discovered a bug in either imx_i2c or fsl-edma on the LS1046A where no data

Re: [PATCH linux-next] drm/amd/pm: Remove unneeded result variable

2022-09-20 Thread Alex Deucher
Applied. Thanks! On Tue, Sep 20, 2022 at 2:36 AM wrote: > > From: ye xingchen > > Return the value atomctrl_initialize_mc_reg_table_v2_2() directly instead > of storing it in another redundant variable. > > Reported-by: Zeal Robot > Signed-off-by: ye xingchen > --- >

Re: [PATCH linux-next] drm/amd/pm: Remove the unneeded result variable

2022-09-20 Thread Alex Deucher
Applied. Thanks. On Tue, Sep 20, 2022 at 2:35 AM wrote: > > From: ye xingchen > > Return the value append_vbios_pptable() directly instead of storing it in > another redundant variable. > > Reported-by: Zeal Robot > Signed-off-by: ye xingchen > --- >

Re: [PATCH] drm/amdgpu: fix initial connector audio value

2022-09-20 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Sep 20, 2022 at 6:34 AM hongao wrote: > > This got lost somewhere along the way, This fixes > audio not working until set_property was called. > > Signed-off-by: hongao > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c >

Re: [PATCH 1/2] drm/amd/display: Reduce number of arguments of dml314's CalculateWatermarksAndDRAMSpeedChangeSupport()

2022-09-20 Thread Alex Deucher
Applied the series. Thanks! Alex On Sat, Sep 17, 2022 at 8:38 AM Maíra Canal wrote: > > Hi Nathan, > > On 9/16/22 18:06, Nathan Chancellor wrote: > > Most of the arguments are identical between the two call sites and they > > can be accessed through the 'struct vba_vars_st' pointer. This

Re: [PATCH 4/5] drm/damage-helper: Do partial updates if framebuffer has not been changed

2022-09-20 Thread Ville Syrjälä
On Tue, Sep 20, 2022 at 03:47:39PM +0100, Daniel Stone wrote: > Hi, > > On Tue, 20 Sept 2022 at 15:31, Ville Syrjälä > wrote: > > > On Tue, Sep 20, 2022 at 03:56:18PM +0200, Thomas Zimmermann wrote: > > > Set partial updates on a plane if the framebuffer has not been changed > > > on an atomic

Re: [PATCH v2 2/7] firmware: raspberrypi: Move the clock IDs to the firmware header

2022-09-20 Thread Stefan Wahren
Hi Maxime, Am 20.09.22 um 14:50 schrieb Maxime Ripard: We'll need the clock IDs in more drivers than just the clock driver from now on, so let's move them in the firmware header. recently as i reviewed the clk-raspberrypi i noticed this, too. But from my point of view the clock ids should go

Re: [BUG] ls1046a: eDMA does not transfer data from I2C

2022-09-20 Thread Sean Anderson
On 9/20/22 11:24 AM, Sean Anderson wrote: > > > On 9/20/22 6:07 AM, Robin Murphy wrote: >> On 2022-09-19 23:24, Sean Anderson wrote: >>> Hi all, >>> >>> I discovered a bug in either imx_i2c or fsl-edma on the LS1046A where no >>> data is read in i2c_imx_dma_read except for the last two bytes

[PATCH v7 1/5] dt-bindings: display: bridge: Convert cdns, dsi.txt to yaml

2022-09-20 Thread Rahul T R
Convert cdns,dsi.txt binding to yaml format Signed-off-by: Rahul T R Reviewed-by: Rob Herring --- .../bindings/display/bridge/cdns,dsi.txt | 112 - .../bindings/display/bridge/cdns,dsi.yaml | 157 ++ 2 files changed, 157 insertions(+), 112 deletions(-)

[PATCH v7 2/5] dt-bindings: display: bridge: cdns, dsi: Add compatible for dsi on j721e

2022-09-20 Thread Rahul T R
Add compatible to support dsi bridge on j721e Signed-off-by: Rahul T R Reviewed-by: Rob Herring --- .../bindings/display/bridge/cdns,dsi.yaml | 25 ++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git

[PATCH v7 5/5] drm/bridge: cdns-dsi: Add support for J721E wrapper

2022-09-20 Thread Rahul T R
Add support for wrapper settings for DSI bridge on j721e. Also set the DPI input to DPI0 Signed-off-by: Rahul T R --- drivers/gpu/drm/bridge/cadence/Kconfig| 10 drivers/gpu/drm/bridge/cadence/Makefile | 1 + .../gpu/drm/bridge/cadence/cdns-dsi-core.c| 37 +-

[PATCH v7 0/5] Add support for CDNS DSI J721E wrapper

2022-09-20 Thread Rahul T R
Following series of patches adds supports for CDNS DSI bridge on j721e. v7: - Rebased to next-20220920 - Accumulated the Reviewed-by acks v6: - Dropped generic definations for properties like reg, resets etc.. - Fixed the defination for port@0 and port@1 - removed the ti,sn65dsi86 node from

Re: [PATCH v3 1/6] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195

2022-09-20 Thread Krzysztof Kozlowski
On 20/09/2022 16:01, Jason-JH.Lin wrote: > For previous MediaTek SoCs, such as MT8173, there are 2 display HW > pipelines binding to 1 mmsys with the same power domain, the same > clock driver and the same mediatek-drm driver. > > For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding

Re: [BUG] ls1046a: eDMA does not transfer data from I2C

2022-09-20 Thread Sean Anderson
On 9/20/22 6:07 AM, Robin Murphy wrote: > On 2022-09-19 23:24, Sean Anderson wrote: >> Hi all, >> >> I discovered a bug in either imx_i2c or fsl-edma on the LS1046A where no >> data is read in i2c_imx_dma_read except for the last two bytes (which >> are not read using DMA). This is perhaps best

[PATCH V2 1/3] dt-bindings: vendor-prefixes: add NewVision vendor prefix

2022-09-20 Thread Chris Morgan
From: Chris Morgan NewVision (also sometimes written as New Vision) is a company based in Shenzen that manufactures ICs for controlling LCD panels. https://www.newvisiondisplay.com/ Signed-off-by: Chris Morgan --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed,

[PATCH V2 3/3] drm/panel: Add NewVision NV3051D MIPI-DSI LCD panel

2022-09-20 Thread Chris Morgan
From: Chris Morgan Add NewVision NV3051D MIPI-DSI LCD panel Support NewVision NV3051D panels as found on the Anbernic RG353P and RG353V. The underlying LCD part number for the RG353x devices is unknown, so the device name and a fallback for the driver IC is used instead. Signed-off-by: Chris

[PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

2022-09-20 Thread Chris Morgan
From: Chris Morgan Add documentation for the NewVision NV3051D panel bindings. Note that for the two expected consumers of this panel binding the underlying LCD model is unknown. Name "anbernic,rg353p-panel" is used because the hardware itself is known as "anbernic,rg353p". Signed-off-by: Chris

[PATCH V2 0/3] drm/panel: Add NewVision NV3051D Panels

2022-09-20 Thread Chris Morgan
From: Chris Morgan Add the NewVision NV3051D panel as found on the Anbernic RG353P and RG353V. The underlying LCD panel itself is unknown (the NV3051D is the controller), so the device name is used for the panel with a fallback to the driver IC. Changes from V1: - Changed compatible string to

Re: [PATCH] drm/panfrost: Give name to anonymous coredump object union

2022-09-20 Thread Alyssa Rosenzweig
On Tue, Sep 20, 2022 at 02:26:52PM +0100, Steven Price wrote: > On 19/09/2022 07:44, Adri??n Larumbe wrote: > > Hi Steven, > > > > On 13.09.2022 09:45, Steven Price wrote: > >> On 12/09/2022 17:44, Adri??n Larumbe wrote: > >>> Building Mesa's Perfetto requires including the panfrost drm uAPI

Re: [PATCH 4/5] drm/damage-helper: Do partial updates if framebuffer has not been changed

2022-09-20 Thread Daniel Stone
Hi, On Tue, 20 Sept 2022 at 15:31, Ville Syrjälä wrote: > On Tue, Sep 20, 2022 at 03:56:18PM +0200, Thomas Zimmermann wrote: > > Set partial updates on a plane if the framebuffer has not been changed > > on an atomic commit. If such a plane has damage clips, the driver will > > use them;

Re: [PATCH 4/5] drm/damage-helper: Do partial updates if framebuffer has not been changed

2022-09-20 Thread Ville Syrjälä
On Tue, Sep 20, 2022 at 03:56:18PM +0200, Thomas Zimmermann wrote: > Set partial updates on a plane if the framebuffer has not been changed > on an atomic commit. If such a plane has damage clips, the driver will > use them; otherwise the update is effectively empty. Planes that change > their

Re: [PATCH v5 00/21] Move all drivers to a common dma-buf locking convention

2022-09-20 Thread Sumit Semwal
Hi Dmitry, On Wed, 14 Sept 2022 at 00:58, Dmitry Osipenko wrote: > > Hello, > > This series moves all drivers to a dynamic dma-buf locking specification. > From now on all dma-buf importers are made responsible for holding > dma-buf's reservation lock around all operations performed over

Re: [PATCH v5 15/21] dma-buf: Move dma_buf_vmap() to dynamic locking specification

2022-09-20 Thread Sumit Semwal
Hi Dmitry, Thanks very much for the series. On Wed, 14 Sept 2022 at 00:59, Dmitry Osipenko wrote: > > Move dma_buf_vmap/vunmap_unlocked() functions to the dynamic locking > specification by asserting that the reservation lock is held. Thanks for the patch; just a minor nit - I think you mean

[PATCH v3 4/6] Revert "drm/mediatek: Add mediatek-drm of vdosys0 support for mt8195"

2022-09-20 Thread Jason-JH . Lin
This reverts commit 7266e90a51a32722a94daa3cb5b8fa278059e49e. Due to the compatible changing of mt8195 from "mediatek,mt8195-mmsys" to "mediatek,mt8195-vdosys0", we have to revert this patch and send a new patch with the new compatible. Signed-off-by: Jason-JH.Lin ---

[PATCH v3 3/6] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0

2022-09-20 Thread Jason-JH . Lin
1. Add mt8195 driver data with compatible "mediatek-mt8195-vdosys0". 2. Add mt8195 routing table settings of vdosys0. Signed-off-by: Jason-JH.Lin --- drivers/soc/mediatek/mt8195-mmsys.h | 370 drivers/soc/mediatek/mtk-mmsys.c| 11 + 2 files changed, 381

[PATCH v3 5/6] drm/mediatek: add mediatek-drm of vdosys0 support for mt8195

2022-09-20 Thread Jason-JH . Lin
Add driver data of mt8195 vdosys0 to mediatek-drm and the sub driver. Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 28 2 files changed, 34 insertions(+) diff --git

[PATCH v3 2/6] Revert "soc: mediatek: add mtk-mmsys support for mt8195 vdosys0"

2022-09-20 Thread Jason-JH . Lin
This reverts commit b804923b7ccb9c9629703364e927b48cd02a9254. Due to the compatible changing of mt8195 from "mediatek,mt8195-mmsys" to "mediatek,mt8195-vdosys0", we have to revert this patch and send a new patch with the new compatible. Signed-off-by: Jason-JH.Lin ---

[PATCH v3 1/6] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195

2022-09-20 Thread Jason-JH . Lin
For previous MediaTek SoCs, such as MT8173, there are 2 display HW pipelines binding to 1 mmsys with the same power domain, the same clock driver and the same mediatek-drm driver. For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding to 2 different power domains, different clock

[PATCH v3 6/6] soc: mediatek: remove DDP_DOMPONENT_DITHER from enum

2022-09-20 Thread Jason-JH . Lin
After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0, mmsys header can remove the useless DDP_COMPONENT_DITHER enum. Signed-off-by: Jason-JH.Lin Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Rex-BC Chen Acked-by: Matthias Brugger --- include/linux/soc/mediatek/mtk-mmsys.h

[PATCH v3 0/6] Change mmsys compatible for mt8195 mediatek-drm

2022-09-20 Thread Jason-JH . Lin
For previous MediaTek SoCs, such as MT8173, there are 2 display HW pipelines binding to 1 mmsys with the same power domain, the same clock driver and the same mediatek-drm driver. For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding to 2 different power domains, different clock

[PATCH 4/5] drm/damage-helper: Do partial updates if framebuffer has not been changed

2022-09-20 Thread Thomas Zimmermann
Set partial updates on a plane if the framebuffer has not been changed on an atomic commit. If such a plane has damage clips, the driver will use them; otherwise the update is effectively empty. Planes that change their framebuffer still perform a full update. This heuristic optimizes the case of

[PATCH 2/5] drm/damage-helper: Decouple partial plane updates from damage clipping

2022-09-20 Thread Thomas Zimmermann
Introduce a distinct flag fb_damage_partial_update in plane state to signal the option for a partial plane update. Replaces the semantics of having no damaged areas to trigger a full update. Decoupling the existence of damage clipping from partial plane updates will allow to sometimes avoid plane

[PATCH 3/5] drm/damage-helper: Do partial updates on legacy cursor changes

2022-09-20 Thread Thomas Zimmermann
In the case of a legacy cursor update, only update the cursor plane. Keep other planes clear from changes. Setting the 'partial_update' flag when these planes don't have damage-clipping areas acts as if no update will be performed. Signed-off-by: Thomas Zimmermann ---

[PATCH 1/5] drm/damage-helper: Style changes

2022-09-20 Thread Thomas Zimmermann
Rename several variables in the damage-helper code to better reflect the use of old and new state. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_damage_helper.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git

[PATCH 5/5] drm/damage-helper: Avoid partial updates for DIRTYFB without damage

2022-09-20 Thread Thomas Zimmermann
Always do a full plane update when userspace sends a DIRTYFB ioctl without damage information. Userspace not changing the framebuffer or marking changed regions can easily be interpreted as if there was no change at all. Therefore set the new fb_dirty flag on all plane's with a dirty framebuffer

[PATCH 0/5] drm/damage-helper: Improve damage-clipping heuristics

2022-09-20 Thread Thomas Zimmermann
DRM Drivers can minimize a plane update by looking at damage clipping information provided by userspace. So far, not having damage information starts a full-plane update. Improve the heuristics for detecting partial and full-plane updates by looking at the various state variables of a plane

Re: [PATCH] drm/panfrost: Give name to anonymous coredump object union

2022-09-20 Thread Steven Price
On 19/09/2022 07:44, Adrián Larumbe wrote: > Hi Steven, > > On 13.09.2022 09:45, Steven Price wrote: >> On 12/09/2022 17:44, Adrián Larumbe wrote: >>> Building Mesa's Perfetto requires including the panfrost drm uAPI header in >>> C++ code, but the C++ compiler requires anonymous unions to have

Re: [PATCH] drm/amdgpu: initialize r variable into amdgpu_cs_submit function

2022-09-20 Thread Christian König
Am 20.09.22 um 14:32 schrieb Tommaso Merciai: Hi Christian, On Tue, Sep 20, 2022 at 02:23:58PM +0200, Christian König wrote: Am 20.09.22 um 14:22 schrieb Tommaso Merciai: The builds of arm64 allmodconfig with clang failed to build next-20220920 with the following result: 1190:3: error

  1   2   >