Re: [PATCH v2 1/2] dt-bindings: display: bridge: Add GPIO display mux binding

2023-02-09 Thread Pin-yen Lin
Hi Laurent, On Tue, Feb 7, 2023 at 11:21 PM Laurent Pinchart wrote: > > Hello Pin-yen, > > On Tue, Feb 07, 2023 at 06:30:36PM +0800, Pin-yen Lin wrote: > > On Tue, Feb 7, 2023 at 6:25 PM Laurent Pinchart wrote: > > > On Tue, Feb 07, 2023 at 06:07:44PM +0800, Pin-yen Lin wrote: > > > > On Wed,

Re: [PATCH] drm/vmwgfx: Make the driver work without the dummy resources

2023-02-09 Thread Christian König
Am 10.02.23 um 03:34 schrieb Zack Rusin: From: Zack Rusin In change 180253782038 ("drm/ttm: stop allocating dummy resources during BO creation") ttm stopped allocating dummy resources but vmwgfx was never ported to handle it. Make the driver treat null resources as initial creation and port

error: 'const struct dc_dsc_config' has no member named 'is_frl'

2023-02-09 Thread Randy Dunlap
Hi, The 'is_frl' struct field is conditional: #if defined(CONFIG_DRM_AMD_DC_DCN) bool is_frl; /* indicate if DSC is applied based on HDMI FRL sink's capability */ #endif so code that uses it should be careful, otherwise build errors may happen:

Re: [Freedreno] [PATCH v3 27/27] drm/msm/dpu: add support for wide planes

2023-02-09 Thread Dmitry Baryshkov
On 10/02/2023 03:12, Abhinav Kumar wrote: Hi Dmitry On 2/9/2023 4:09 PM, Dmitry Baryshkov wrote:   . On Fri, 10 Feb 2023 at 00:12, Abhinav Kumar wrote: Hi Dmitry On 2/9/2023 1:23 PM, Dmitry Baryshkov wrote: Hi Abhinav, On Thu, 9 Feb 2023 at 21:25, Abhinav Kumar wrote: On 2/9/2023

[PATCH] drm/amd/display: Remove the unused variable pre_connection_type

2023-02-09 Thread Jiapeng Chong
Variable pre_connection_type is not effectively used, so delete it. Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4031 Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/link/link_detection.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH] drm/vmwgfx: Make the driver work without the dummy resources

2023-02-09 Thread Zack Rusin
From: Zack Rusin In change 180253782038 ("drm/ttm: stop allocating dummy resources during BO creation") ttm stopped allocating dummy resources but vmwgfx was never ported to handle it. Make the driver treat null resources as initial creation and port code to handle null resources in general.

[PATCH] drm/amd/display: Remove the unused variable ds_port

2023-02-09 Thread Jiapeng Chong
Variable ds_port is not effectively used, so delete it. drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_capability.c:280:35: warning: variable ‘ds_port’ set but not used. Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4030 Signed-off-by: Jiapeng

Re: [git pull] drm fixes for 6.2-rc8

2023-02-09 Thread pr-tracker-bot
The pull request you sent on Fri, 10 Feb 2023 11:19:51 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-02-10 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/38c1e0c65865426676123cc9a127526fa02bcac6 Thank you! -- Deet-doot-dot, I am a bot.

[RFC] drm/i915/uapi/huc: two levels of HuC authentication

2023-02-09 Thread Daniele Ceraolo Spurio
Starting on DG2, the owner of HuC authentication is the GSC FW. On MTL, with the GSC moving into the media GT and being loaded by i915, this can result in a significant delay in HuC readiness on init/resume. To reduce the impact, the HuC load & authentication has been split in 2 parts: 1) The HuC

[git pull] drm fixes for 6.2-rc8

2023-02-09 Thread Dave Airlie
Hi Linus, Weekly fixes, the amdgpu had a few small fixes to display flicker on certain configurations, however it was found the the flicker was lessened but there were other unintended consequences, so for now they've been reverted and replaced with an option for users to test with so future

Re: [Freedreno] [PATCH v3 27/27] drm/msm/dpu: add support for wide planes

2023-02-09 Thread Abhinav Kumar
Hi Dmitry On 2/9/2023 4:09 PM, Dmitry Baryshkov wrote: . On Fri, 10 Feb 2023 at 00:12, Abhinav Kumar wrote: Hi Dmitry On 2/9/2023 1:23 PM, Dmitry Baryshkov wrote: Hi Abhinav, On Thu, 9 Feb 2023 at 21:25, Abhinav Kumar wrote: On 2/9/2023 3:45 AM, Dmitry Baryshkov wrote: On Thu, 9

[PATCH -next] drm/amd/display: clean up some inconsistent indentings

2023-02-09 Thread Yang Li
drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_factory.c:145 get_ddc_line() warn: inconsistent indenting drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_factory.c:201 dc_link_construct_phy() warn: inconsistent indenting Reported-by: Abaci Robot Link:

[PATCH -next] drm/amd/display: Simplify bool conversion

2023-02-09 Thread Yang Li
./drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c:1610:68-73: WARNING: conversion to bool not needed here Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4025 Signed-off-by: Yang Li ---

[PATCH v4 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-02-09 Thread Alan Previn
Add MTL's function for ARB session creation using PXP firmware version 4.3 ABI structure format. Also add MTL's function for ARB session invalidation but this reuses PXP firmware version 4.2 ABI structure format. Before checking the return status, look at the GSC-CS-Mem-Header's pending-bit

[PATCH v4 3/8] drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet to GSC

2023-02-09 Thread Alan Previn
Add helper functions into a new file for heci-packet-submission. The helpers will handle generating the MTL GSC-CS Memory-Header and submission of the Heci-Cmd-Packet instructions to the engine. NOTE1: These common functions for heci-packet-submission will be used by different i915 callers:

[PATCH v4 7/8] drm/i915/pxp: On MTL, KCR enabling doesn't wait on tee component

2023-02-09 Thread Alan Previn
On legacy platforms, KCR HW enabling is done at the time the mei component interface is bound. It's also disabled during unbind. However, for MTL onwards, we don't depend on a tee component to start sending GSC-CS firmware messages. Thus, immediately enable (or disable) KCR HW on PXP's init, fini

[PATCH v4 6/8] drm/i915/pxp: MTL-KCR interrupt ctrl's are in GT-0

2023-02-09 Thread Alan Previn
Despite KCR subsystem being in the media-tile (close to the GSC-CS), the IRQ controls for it are on GT-0 with other global IRQ controls. Thus, add a helper for KCR hw interrupt enable/disable functions to get the correct gt structure (for uncore) for MTL. In the helper, we get GT-0's handle for

[PATCH v4 4/8] drm/i915/pxp: Add GSC-CS backend to send GSC fw messages

2023-02-09 Thread Alan Previn
Add GSC engine based method for sending PXP firmware packets to the GSC firmware for MTL (and future) products. Use the newly added helpers to populate the GSC-CS memory header and send the message packet to the FW by dispatching the GSC_HECI_CMD_PKT instruction on the GSC engine. We use

[PATCH v4 8/8] drm/i915/pxp: Enable PXP with MTL-GSC-CS

2023-02-09 Thread Alan Previn
Enable PXP with MTL-GSC-CS: add the has_pxp into device info and increase the timeouts for new GSC-CS + firmware specs. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/i915_pci.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 2 +- 2 files changed, 2 insertions(+), 1

[PATCH v4 2/8] drm/i915/pxp: Add MTL hw-plumbing enabling for KCR operation

2023-02-09 Thread Alan Previn
Add MTL hw-plumbing enabling for KCR operation under PXP which includes: 1. Updating 'pick-gt' to get the media tile for KCR interrupt handling 2. Adding MTL's KCR registers for PXP operation (init, status-checking, etc.). While doing #2, lets create a separate registers header file for

[PATCH v4 1/8] drm/i915/pxp: Add GSC-CS back-end resource init and cleanup

2023-02-09 Thread Alan Previn
For MTL, the PXP back-end transport uses the GSC engine to submit HECI packets through the HW to the GSC firmware for PXP arb session management. This submission uses a non-priveleged batch buffer, a buffer for the command packet and of course a context targeting the GSC-CS. Thus for MTL, we need

[PATCH v4 0/8] drm/i915/pxp: Add MTL PXP Support

2023-02-09 Thread Alan Previn
This series enables PXP on MTL. On ADL/TGL platforms, we rely on the mei driver via the i915-mei PXP component interface to establish a connection to the security firmware via the HECI device interface. That interface is used to create and teardown the PXP ARB session. PXP ARB session is created

Re: [PATCH v3] drm/ast: Fix start address computation

2023-02-09 Thread Jammy Huang
On 2023/2/9 下午 05:55, Thomas Zimmermann wrote: Am 09.02.23 um 10:44 schrieb Jocelyn Falempe: During the driver conversion to shmem, the start address for the scanout buffer was set to the base PCI address. In most cases it works because only the lower 24bits are used, and due to alignment it

Re: [Freedreno] [PATCH v3 27/27] drm/msm/dpu: add support for wide planes

2023-02-09 Thread Dmitry Baryshkov
. On Fri, 10 Feb 2023 at 00:12, Abhinav Kumar wrote: > > Hi Dmitry > > On 2/9/2023 1:23 PM, Dmitry Baryshkov wrote: > > Hi Abhinav, > > > > On Thu, 9 Feb 2023 at 21:25, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 2/9/2023 3:45 AM, Dmitry Baryshkov wrote: > >>> On Thu, 9 Feb 2023 at 04:19,

Re: linux-next: duplicate patch in the drm-misc-fixes tree

2023-02-09 Thread David Airlie
On Fri, Feb 10, 2023 at 9:47 AM Stephen Rothwell wrote: > > Hi all, > > The following commit is also in the drm-fixes tree as a different commit > (but the same patch): > > 94d8b6572a1f ("nvidiafb: detect the hardware support before removing > console.") > > This is commit > > 04119ab1a49f

linux-next: duplicate patch in the drm-misc-fixes tree

2023-02-09 Thread Stephen Rothwell
Hi all, The following commit is also in the drm-fixes tree as a different commit (but the same patch): 94d8b6572a1f ("nvidiafb: detect the hardware support before removing console.") This is commit 04119ab1a49f ("nvidiafb: detect the hardware support before removing console.") in the

Re: [PATCH v3 4/8] drm/i915/pxp: Add GSC-CS backend to send GSC fw messages

2023-02-09 Thread Teres Alexis, Alan Previn
missed somethings on host-session-handle - for next rev. On Wed, 2023-01-25 at 00:06 -0800, Teres Alexis, Alan Previn wrote: > Add GSC engine based method for sending PXP firmware packets > to the GSC firmware for MTL (and future) products. > > Use the newly added helpers to populate the GSC-CS

Re: [RFC PATCH v2 1/4] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-02-09 Thread Dmitry Baryshkov
On Fri, 10 Feb 2023 at 00:31, Jessica Zhang wrote: > > > > On 2/9/2023 10:51 AM, Dmitry Baryshkov wrote: > > On 09/02/2023 20:44, Jessica Zhang wrote: > >> Currently, DPU will enable TE during prepare_commit(). However, this > >> will cause issues when trying to read/write to register in > >>

Re: [RFC PATCH v2 3/4] drm/msm/dpu: Remove empty prepare_commit() function

2023-02-09 Thread Jessica Zhang
On 2/9/2023 10:51 AM, Dmitry Baryshkov wrote: On 09/02/2023 20:44, Jessica Zhang wrote: Now that the TE setup has been moved to prepare_for_kickoff(), move empty prepare_commit() from DPU driver. s/move/remove/ Also the DPU's prepare_commit() is not empty. Please mention

Re: [RFC PATCH v2 1/4] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-02-09 Thread Jessica Zhang
On 2/9/2023 10:51 AM, Dmitry Baryshkov wrote: On 09/02/2023 20:44, Jessica Zhang wrote: Currently, DPU will enable TE during prepare_commit(). However, this will cause issues when trying to read/write to register in get_autorefresh_config(), because the core clock rates aren't set at that

Re: [Freedreno] [PATCH v3 27/27] drm/msm/dpu: add support for wide planes

2023-02-09 Thread Abhinav Kumar
Hi Dmitry On 2/9/2023 1:23 PM, Dmitry Baryshkov wrote: Hi Abhinav, On Thu, 9 Feb 2023 at 21:25, Abhinav Kumar wrote: On 2/9/2023 3:45 AM, Dmitry Baryshkov wrote: On Thu, 9 Feb 2023 at 04:19, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Typically SSPP can

[Cc: drm-misc folks] Re: [Intel-gfx] [CI 1/4] drm/i915/dp_mst: Add the MST topology state for modesetted CRTCs

2023-02-09 Thread Lyude Paul
On Tue, 2023-02-07 at 14:59 +0200, Imre Deak wrote: > Hi all, > > On Mon, Feb 06, 2023 at 01:48:53PM +0200, Imre Deak wrote: > > Add the MST topology for a CRTC to the atomic state if the driver > > needs to force a modeset on the CRTC after the encoder compute config > > functions are called. >

Re: [PATCH v2 02/17] drm/display/dp_mst: Handle old/new payload states in drm_dp_remove_payload()

2023-02-09 Thread Lyude Paul
On Wed, 2023-02-08 at 09:41 +0200, Imre Deak wrote: > On Tue, Feb 07, 2023 at 07:21:48PM -0500, Lyude Paul wrote: > > On Tue, 2023-02-07 at 14:11 +0200, Imre Deak wrote: > > > > And then disabled say, payload #1, that immediately after we get the ACT > > that > > the payload table in hardware

Re: [PATCH v3 27/27] drm/msm/dpu: add support for wide planes

2023-02-09 Thread Dmitry Baryshkov
Hi Abhinav, On Thu, 9 Feb 2023 at 21:25, Abhinav Kumar wrote: > > > > On 2/9/2023 3:45 AM, Dmitry Baryshkov wrote: > > On Thu, 9 Feb 2023 at 04:19, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: > >>> Typically SSPP can support rectangle with width

Re: [PATCH] drm/nouveau/disp: Fix nvif_outp_acquire_dp() argument size

2023-02-09 Thread Lyude Paul
I think that shoud be fine, which branch is it on? On Fri, 2023-01-27 at 11:42 -0800, Kees Cook wrote: > On Wed, Jan 25, 2023 at 04:24:19PM -0500, Lyude Paul wrote: > > Sorry! I've been pretty busy until now, this is: > > > > Reviewed-by: Lyude Paul > > > > Let me know if you've pushed it

Re: [PATCH v3 27/27] drm/msm/dpu: add support for wide planes

2023-02-09 Thread Abhinav Kumar
On 2/9/2023 3:45 AM, Dmitry Baryshkov wrote: On Thu, 9 Feb 2023 at 04:19, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Typically SSPP can support rectangle with width up to 2560. However it's Not always 2560. Depends on the chipset. _typically_ Would just

Re: [RFC PATCH v2 1/4] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-02-09 Thread Dmitry Baryshkov
On 09/02/2023 20:44, Jessica Zhang wrote: Currently, DPU will enable TE during prepare_commit(). However, this will cause issues when trying to read/write to register in get_autorefresh_config(), because the core clock rates aren't set at that time. This used to work because phys_enc->hw_pp is

Re: [RFC PATCH v2 3/4] drm/msm/dpu: Remove empty prepare_commit() function

2023-02-09 Thread Dmitry Baryshkov
On 09/02/2023 20:44, Jessica Zhang wrote: Now that the TE setup has been moved to prepare_for_kickoff(), move empty prepare_commit() from DPU driver. s/move/remove/ Also the DPU's prepare_commit() is not empty. Please mention dpu_encoder_prepare_commit() becoming (or being) empty.

Re: Try to address the drm_debugfs issues

2023-02-09 Thread Maxime Ripard
On Thu, Feb 09, 2023 at 04:52:54PM +0100, Christian König wrote: > Am 09.02.23 um 15:19 schrieb Maxime Ripard: > > On Thu, Feb 09, 2023 at 03:06:10PM +0100, Christian König wrote: > > > Am 09.02.23 um 14:06 schrieb Maíra Canal: > > > > On 2/9/23 09:13, Christian König wrote: > > > > > Am 09.02.23

Re: [RFC PATCH v2 4/4] drm/msm/mdp4: Remove empty prepare_commit() function

2023-02-09 Thread Dmitry Baryshkov
On 09/02/2023 20:44, Jessica Zhang wrote: Remove empty prepare_commit() function from MDP4 driver. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 5 - 1 file changed, 5 deletions(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [RFC PATCH v2 2/4] drm/msm: Check for NULL before calling prepare_commit()

2023-02-09 Thread Dmitry Baryshkov
On 09/02/2023 20:44, Jessica Zhang wrote: Add a NULL check before calling prepare_commit() in msm_atomic_commit_tail() Signed-off-by: Jessica Zhang Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

[RFC PATCH v2 4/4] drm/msm/mdp4: Remove empty prepare_commit() function

2023-02-09 Thread Jessica Zhang
Remove empty prepare_commit() function from MDP4 driver. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c index

[RFC PATCH v2 3/4] drm/msm/dpu: Remove empty prepare_commit() function

2023-02-09 Thread Jessica Zhang
Now that the TE setup has been moved to prepare_for_kickoff(), move empty prepare_commit() from DPU driver. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 19 - drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 7 ---

[RFC PATCH v2 2/4] drm/msm: Check for NULL before calling prepare_commit()

2023-02-09 Thread Jessica Zhang
Add a NULL check before calling prepare_commit() in msm_atomic_commit_tail() Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/msm_atomic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_atomic.c b/drivers/gpu/drm/msm/msm_atomic.c index

[RFC PATCH v2 1/4] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-02-09 Thread Jessica Zhang
Currently, DPU will enable TE during prepare_commit(). However, this will cause issues when trying to read/write to register in get_autorefresh_config(), because the core clock rates aren't set at that time. This used to work because phys_enc->hw_pp is only initialized in mode set [1], so the

[RFC PATCH v2 0/4] Move TE setup to prepare_for_kickoff()

2023-02-09 Thread Jessica Zhang
Move TE setup to prepare_for_kickoff() and remove empty prepare_commit() functions in both MDP4 and DPU drivers. Changes in V2: - Added changes to remove empty prepare_commit() functions Jessica Zhang (4): drm/msm/dpu: Move TE setup to prepare_for_kickoff() drm/msm: Check for NULL before

Re: [PATCH 1/3] drm/msm/adreno: Add Adreno A690 support

2023-02-09 Thread Dmitry Baryshkov
On 08/02/2023 05:40, Bjorn Andersson wrote: From: Bjorn Andersson Introduce support for the Adreno A690, found in Qualcomm SC8280XP. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 120 -

Re: [PATCH 4/9] dt-bindings: gpu: mali-bifrost: Add new MT8183 compatible

2023-02-09 Thread Rob Herring
On Wed, 08 Feb 2023 11:37:04 +0100, AngeloGioacchino Del Regno wrote: > Since new platform data was required in Panfrost for getting GPU DVFS > finally working on MediaTek SoCs, add a new "mediatek,mt8183b-mali" > compatible. > > Signed-off-by: AngeloGioacchino Del Regno > > --- >

Re: [PATCH 3/9] dt-bindings: gpu: mali-bifrost: Add compatible for MT8195 SoC

2023-02-09 Thread Rob Herring
On Wed, 08 Feb 2023 11:37:03 +0100, AngeloGioacchino Del Regno wrote: > The MediaTek MT8195 SoC has a Mali G57 MC5 (Valhall-JM) and has the > same number of power domains and requirements as MT8192 in terms of > bindings. > > Signed-off-by: AngeloGioacchino Del Regno > > --- >

Re: [PATCH 2/9] dt-bindings: gpu: mali-bifrost: Allow up to 5 power domains for MT8192

2023-02-09 Thread Rob Herring
On Wed, 08 Feb 2023 11:37:02 +0100, AngeloGioacchino Del Regno wrote: > MediaTek MT8192 (and similar) needs five power domains for the > Mali GPU and no sram-supply: change the binding to allow so. > > Signed-off-by: AngeloGioacchino Del Regno > > --- > .../bindings/gpu/arm,mali-bifrost.yaml

Re: [PATCH 1/9] dt-bindings: gpu: mali-bifrost: Don't allow sram-supply by default

2023-02-09 Thread Rob Herring
On Thu, Feb 09, 2023 at 10:15:33AM +0100, AngeloGioacchino Del Regno wrote: > Il 09/02/23 03:50, Chen-Yu Tsai ha scritto: > > On Wed, Feb 8, 2023 at 6:37 PM AngeloGioacchino Del Regno > > wrote: > > > > > > The sram-supply is MediaTek-specific, it is and will ever be used > > > only for the

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-09 Thread Ville Syrjälä
On Thu, Feb 09, 2023 at 05:03:19PM +, Simon Ser wrote: > On Thursday, February 9th, 2023 at 17:38, Joshua Ashton > wrote: > > > > I mean, the strings are the uAPI, not the integers, right? > > > > Both are uAPI these days. > > Yes. The integers are uAPI, if you change them you'll break

Re: drm: panel-orientation-quirks: Add quirk for Lenovo IdeaPad Duet 3 10IGL5

2023-02-09 Thread Darrell Kavanagh
It certainly is a learning process! Let me try to get things together properly myself, will be useful in the long run. Darrell On Thu, 9 Feb 2023 at 15:53, Hans de Goede wrote: > > Hi, > > On 2/9/23 16:36, Maxime Ripard wrote: > > Hi, > > > > On Wed, Feb 08, 2023 at 07:04:58PM +, Darrell

[pull] amdgpu drm-fixes-6.2

2023-02-09 Thread Alex Deucher
Hi Dave, Daniel, A few last minute display fixes. The following changes since commit c6ac406cd8ff610a2d5da298b1d3071acfcde7f0: drm/amdgpu/smu: skip pptable init under sriov (2023-02-08 22:33:37 -0500) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

Re: [regression][6.0] After commit b261509952bc19d1012cf732f853659be6ebc61e I see WARNING message at drivers/gpu/drm/drm_modeset_lock.c:276 drm_modeset_drop_locks+0x63/0x70

2023-02-09 Thread Leo Li
Hi Mikhail, seems like your report flew past me, thanks for the ping. This might be a simple issue of not backing off when deadlock was hit. drm_atomic_normalize_zpos() can return an error code, and I ignored it (oops!) Can you give this patch a try?

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-09 Thread Simon Ser
On Thursday, February 9th, 2023 at 17:38, Joshua Ashton wrote: > > I mean, the strings are the uAPI, not the integers, right? > > Both are uAPI these days. Yes. The integers are uAPI, if you change them you'll break libliftoff users. There is an old thread discussing this somewhere. The tl;dr

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-09 Thread Joshua Ashton
On 2/8/23 09:30, Pekka Paalanen wrote: On Fri, 3 Feb 2023 02:07:44 + Joshua Ashton wrote: Userspace has no way of controlling or knowing the pixel encoding currently, so there is no way for it to ever get the right values here. When we do add pixel_encoding control from userspace,we

[PULL] drm-intel-fixes

2023-02-09 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes our fixes for this week with a few patches targeting stable. drm-intel-fixes-2023-02-09: - Display watermark fix (Ville) - fbdev fix for PSR, FBC, DRRS (Jouni) - Move fd_install after last use of fence (Rob) - Initialize the obj flags for shmem objects (Aravind) -

Re: drm: panel-orientation-quirks: Add quirk for Lenovo IdeaPad Duet 3 10IGL5

2023-02-09 Thread Hans de Goede
Hi, On 2/9/23 16:36, Maxime Ripard wrote: > Hi, > > On Wed, Feb 08, 2023 at 07:04:58PM +, Darrell Kavanagh wrote: >> I've resolved this by adding a matching quirk in >> drivers/firmware/efi/sysfb_efi.c - see below. Right, this is a known issue on Lenovo 2-in-1s with the panel mounted 90

Re: Try to address the drm_debugfs issues

2023-02-09 Thread Christian König
Am 09.02.23 um 15:19 schrieb Maxime Ripard: On Thu, Feb 09, 2023 at 03:06:10PM +0100, Christian König wrote: Am 09.02.23 um 14:06 schrieb Maíra Canal: On 2/9/23 09:13, Christian König wrote: Am 09.02.23 um 12:23 schrieb Maíra Canal: On 2/9/23 05:18, Christian König wrote: Hello everyone,

Re: drm: panel-orientation-quirks: Add quirk for Lenovo IdeaPad Duet 3 10IGL5

2023-02-09 Thread Hans de Goede
Hi Darrell, On 2/3/23 19:32, Darrell Kavanagh wrote: > Hi, > > This is another Lenovo with detachable keyboard and 1200x1920 screen > mounted sideways. > > The following has been tested with 6.2.0-rc6. > > Thanks, > Darrell Thank you for your patch. Note that instead of "Hi, ... Thanks,

Re: [PATCH v3 0/4] Reserve DSPPs based on user request

2023-02-09 Thread Doug Anderson
Hi, On Thu, Feb 9, 2023 at 3:26 AM Kalyan Thota wrote: > > Kindly ignore my previous email. Sent too early !! > > We have tested the changes on top of tip: > https://chromium.googlesource.com/chromiumos/third_party/kernel/+log/refs/heads/chromeos-5.15 > + 5 CTM patches ( that you have quoted )

[RFC 3/3] drm/i915: Waitboost external waits

2023-02-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Userspace waits coming via the drm_syncobj route have so far been bypassing the waitboost mechanism. Use the previously added dma-fence wait tracking API and apply the same waitboosting logic which applies to other entry points. This should fix the perfomance regressions

[RFC 2/3] drm/syncobj: Mark syncobj waits as external waiters

2023-02-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the previously added dma-fence tracking of explicit waiters. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/drm_syncobj.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index

[RFC 1/3] dma-fence: Track explicit waiters

2023-02-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Track how many callers are explicity waiting on a fence to signal and allow querying that via new dma_fence_wait_count() API. This provides infrastructure on top of which generic "waitboost" concepts can be implemented by individual drivers. Wait-boosting is any reactive

[RFC 0/3] Waitboost drm syncobj waits

2023-02-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In i915 we have this concept of "wait boosting" where we give a priority boost for instance to fences which are actively waited upon from userspace. This has it's pros and cons and can certainly be discussed at lenght. However fact is some workloads really like it. Problem

[PATCH 5/6] drm/tidss: Remove return values from dispc_plane_{setup, enable}()

2023-02-09 Thread Thomas Zimmermann
Calls to dispc_plane_setup() and dispc_plane_enable() cannot fail. Remove the return value. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tidss/tidss_dispc.c | 12 drivers/gpu/drm/tidss/tidss_dispc.h | 8 drivers/gpu/drm/tidss/tidss_plane.c | 11 +-- 3

[PATCH 4/6] drm/mgag200: Implement struct drm_plane_helper_funcs.atomic_enable

2023-02-09 Thread Thomas Zimmermann
Enable the primary plane for mgag200 hardware via atomic_enable. Atomic helpers invoke this callback only when the plane becomes active. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.h | 3 +++ drivers/gpu/drm/mgag200/mgag200_mode.c | 19 --- 2 files

[PATCH 3/6] drm/mgag200: Remove disable handling from atomic_update

2023-02-09 Thread Thomas Zimmermann
The primary plane has the atomic_disable helper set, so atomic_update won't be called if the plane gets disabled. Remove the respective branch from the helper. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mode.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH 2/6] drm/ast: Implement struct drm_plane_helper_funcs.atomic_enable

2023-02-09 Thread Thomas Zimmermann
Enable the primary plane for ast hardware via atomic_enable. Atomic helpers invoke this callback only when the plane becomes active. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff

[PATCH 6/6] drm/tidss: Implement struct drm_plane_helper_funcs.atomic_enable

2023-02-09 Thread Thomas Zimmermann
Enable the primary plane for tidss hardware via atomic_enable. Atomic helpers invoke this callback only when the plane becomes active. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tidss/tidss_plane.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

[PATCH 1/6] drm/atomic-helper: Add atomic_enable plane-helper callback

2023-02-09 Thread Thomas Zimmermann
Add atomic_enable to struct drm_plane_helper_funcs. It enables a plane independently from updating the plane's content. As such, it is the inverse of the atomic_disable plane helper. Useful for hardware where plane enable state is independent from plane content. Signed-off-by: Thomas Zimmermann

[PATCH 0/6] drm: Add struct drm_plane_helper_funcs.atomic_enable

2023-02-09 Thread Thomas Zimmermann
Add atomic_enable, a plane helper that enables a plane. It is supposed to be the inverse of atomic_disable. While atomic_update can handle all of a plane's enable, disable and update functionality, many drivers also implement atomic_disable to do disabling separately. Some drivers also try to

Re: drm: panel-orientation-quirks: Add quirk for Lenovo IdeaPad Duet 3 10IGL5

2023-02-09 Thread Maxime Ripard
Hi, On Wed, Feb 08, 2023 at 07:04:58PM +, Darrell Kavanagh wrote: > I've resolved this by adding a matching quirk in > drivers/firmware/efi/sysfb_efi.c - see below. > > Are you the right people to be notifying about this? Yes, we are. Howewer, please follow

Re: [PATCH][next] drm/amd/display: Fix spelling mistakes of function name in error message

2023-02-09 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Feb 9, 2023 at 7:53 AM Colin Ian King wrote: > > The function name is being reported as dc_link_contruct when it is > actually dc_link_construct_phy. Fix this by using %s and the __func__ > for the function name. > > Signed-off-by: Colin Ian King > --- >

Re: [PATCH v2] drm/amd/display: remove duplicate include header

2023-02-09 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Feb 9, 2023 at 5:48 AM wrote: > > From: Ye Xingchen > > link_hwss.h is included more than once in link_dpms.c . > > Signed-off-by: Ye Xingchen > --- > v1 -> v2 > Fix the U+00A0 non-breaking space in the subject line. >

Re: [PATCH] drm/amd/display: fix link_validation build failure

2023-02-09 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Feb 9, 2023 at 7:45 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > When CONFIG_DRM_AMD_DC_DCN is disabled, the is_frl member > is not defined: > > drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_validation.c: In function >

Re: [PATCH] drm/amd/display: set should_disable_otg storage-class-specifier to static

2023-02-09 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Feb 9, 2023 at 8:41 AM Tom Rix wrote: > > smatch reports > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c:90:6: > warning: symbol 'should_disable_otg' was not declared. Should it be static? > > should_disable_otg() is only used in

Re: [RFC PATCH v2 00/18] Add DRM CRTC 3D LUT interface

2023-02-09 Thread Melissa Wen
On 01/31, Pekka Paalanen wrote: > On Mon, 9 Jan 2023 14:38:09 -0100 > Melissa Wen wrote: > > > On 01/09, Melissa Wen wrote: > > > Hi, > > > > > > After collecting comments in different places, here is a second version > > > of the work on adding DRM CRTC 3D LUT support to the current DRM color

Re: Try to address the drm_debugfs issues

2023-02-09 Thread Maxime Ripard
On Thu, Feb 09, 2023 at 03:06:10PM +0100, Christian König wrote: > Am 09.02.23 um 14:06 schrieb Maíra Canal: > > On 2/9/23 09:13, Christian König wrote: > > > Am 09.02.23 um 12:23 schrieb Maíra Canal: > > > > On 2/9/23 05:18, Christian König wrote: > > > > > Hello everyone, > > > > > > > > > >

Re: [PATCH v2 1/2] drm: Introduce plane SIZE_HINTS property

2023-02-09 Thread Jonas Ådahl
On Wed, Feb 08, 2023 at 11:10:16PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Add a new immutable plane property by which a plane can advertise > a handful of recommended plane sizes. This would be mostly exposed > by cursor planes as a slightly more capable replacement for > the

Re: Try to address the drm_debugfs issues

2023-02-09 Thread Christian König
Am 09.02.23 um 14:06 schrieb Maíra Canal: On 2/9/23 09:13, Christian König wrote: Am 09.02.23 um 12:23 schrieb Maíra Canal: On 2/9/23 05:18, Christian König wrote: Hello everyone, the drm_debugfs has a couple of well known design problems. Especially it wasn't possible to add files between

Re: [PATCH v11 7/9] dt-bindings: display: bridge: it6505: Add mode-switch support

2023-02-09 Thread Rob Herring
On Wed, Feb 8, 2023 at 10:00 PM Pin-yen Lin wrote: > > Hi Rob, > > Thanks for the review. > > On Wed, Feb 8, 2023 at 4:52 AM Rob Herring wrote: > > > > On Sat, Feb 04, 2023 at 09:30:38PM +0800, Pin-yen Lin wrote: > > > ITE IT6505 can be used in systems to switch the DP traffic between > > > two

[PATCH 10/11] drm: Include for mode parsing

2023-02-09 Thread Thomas Zimmermann
Include in drm_connector.c to get video_get_options() and avoid the dependency on . The replaced function fb_get_options() is just a tiny wrapper around video_get_opions(). No functional changes. Include to get fwnode_handle_put(), which had been provided via . Signed-off-by: Thomas Zimmermann

[PATCH 09/11] driver/ps3: Include for mode parsing

2023-02-09 Thread Thomas Zimmermann
Include in ps3av.c to get video_get_options() and avoid the dependency on . The replaced function fb_get_options() is just a tiny wrapper around video_get_opions(). No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/ps3/ps3av.c | 18 ++ 1 file changed, 6

[PATCH 11/11] drm: Fix comment on mode parsing

2023-02-09 Thread Thomas Zimmermann
Do not claim that there's a default mode in the video= option parser. if no option string has been given, the parser does nothing. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_modes.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_modes.c

[PATCH 08/11] fbdev: Handle video= parameter in video/cmdline.c

2023-02-09 Thread Thomas Zimmermann
Handle the command-line parameter video= in video/cmdline.c. Implement the fbdev helper fb_get_options() on top. Will allows to handle the kernel parameter in DRM without fbdev dependencies. Note that __video_get_options() has the meaning of its return value inverted compared to fb_get_options().

[PATCH 01/11] fbdev: Fix contact info in fb_cmdline.c

2023-02-09 Thread Thomas Zimmermann
Fix Daniel's email address. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Daniel Vetter --- drivers/video/fbdev/core/fb_cmdline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/core/fb_cmdline.c b/drivers/video/fbdev/core/fb_cmdline.c

[PATCH 07/11] fbdev: Move option-string lookup into helper

2023-02-09 Thread Thomas Zimmermann
Move the lookup of the option string into an internal helper. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/fb_cmdline.c | 60 --- 1 file changed, 36 insertions(+), 24 deletions(-) diff --git a/drivers/video/fbdev/core/fb_cmdline.c

[PATCH 05/11] fbdev: Read video= option with fb_get_option() in modedb

2023-02-09 Thread Thomas Zimmermann
Get the kernel's global video= parameter with fb_get_option(). Done to unexport the internal fbdev state fb_mode_config. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/modedb.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH 06/11] fbdev: Unexport fb_mode_option

2023-02-09 Thread Thomas Zimmermann
There are no external users of fb_mode_option. Unexport the variable and declare it static. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/fb_cmdline.c | 4 +--- include/linux/fb.h| 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git

[PATCH 04/11] drivers/ps3: Read video= option with fb_get_option()

2023-02-09 Thread Thomas Zimmermann
Get the kernel's global video= parameter with fb_get_option(). Done to unexport the internal fbdev state fb_mode_config. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/ps3/ps3av.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git

[PATCH 03/11] fbdev: Support NULL for name in option-string lookup

2023-02-09 Thread Thomas Zimmermann
Ignore the per-driver video options if no driver name has been specified to fb_get_option(). Return the global options in this case. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/fb_cmdline.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[PATCH 02/11] fbdev: Transfer video= option strings to caller; clarify ownership

2023-02-09 Thread Thomas Zimmermann
In fb_get_options(), always duplicate the returned option string and transfer ownership of the memory to the function's caller. Until now, only the global option string got duplicated and transferred to the caller; the per-driver options were owned by fb_get_options(). In the end, it was

[PATCH 00/11] drm,fbdev: Move video= option to drivers/video

2023-02-09 Thread Thomas Zimmermann
The kernel's video= option sets the initial video mode. It is shared by fbdev and DRM, but located within the fbdev code. Move it to drivers/video/ and adapt callers. Allows DRM (and others) to use the option without depending on fbdev. While at it, fix the interface of the lookup functions. This

[PATCH] drm/amd/display: set should_disable_otg storage-class-specifier to static

2023-02-09 Thread Tom Rix
smatch reports drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c:90:6: warning: symbol 'should_disable_otg' was not declared. Should it be static? should_disable_otg() is only used in dcn315_clk_mgr.c, so it should be static Signed-off-by: Tom Rix ---

Re: [PATCH v2 4/8] arm64: dts: qcom: sm8350: reorder device nodes

2023-02-09 Thread Dmitry Baryshkov
On 09/02/2023 05:28, Bjorn Andersson wrote: On Mon, Feb 06, 2023 at 04:57:03PM +0200, Dmitry Baryshkov wrote: Start ordering DT nodes according to agreed order. Move apps SMMU, GIC, timer, apps RSC, cpufreq ADSP and cDSP nodes to the end to the proper position at the end of /soc/. I think

[PATCH v3 6/6] arm64: dts: qcom: sm8350-hdk: enable GPU

2023-02-09 Thread Dmitry Baryshkov
Enable the GPU on the SM8350-HDK device. The ZAP shader is required for the GPU to function properly. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v3 5/6] arm64: dts: qcom: sm8350: add GPU, GMU, GPU CC and SMMU nodes

2023-02-09 Thread Dmitry Baryshkov
Add device nodes required to enable GPU on the SM8350 platform. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 178 +++ 1 file changed, 178 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi

[PATCH v3 4/6] arm64: dts: qcom: sm8350: finish reordering nodes

2023-02-09 Thread Dmitry Baryshkov
Finish reordering DT nodes by their address. Move PDC, tsens, AOSS, SRAM, SPMI and TLMM nodes to the proper position. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 764 +-- 1 file changed, 382 insertions(+), 382 deletions(-) diff --git

  1   2   >