Re: [PATCH 1/9] drm: execution context for GEM buffers v3

2023-03-01 Thread Christian König
Am 28.02.23 um 20:13 schrieb Danilo Krummrich: [SNIP] +    if (exec->prelocked) { +    dma_resv_unlock(exec->prelocked->resv); +    drm_gem_object_put(exec->prelocked); +    exec->prelocked = NULL; +    } Let's say we try to lock 3 objects A, B and C in chronological order and in

[PATCH] drm/edid: fix info leak when failing to get panel id

2023-03-01 Thread Johan Hovold
Make sure to clear the transfer buffer before fetching the EDID to avoid leaking slab data to the logs on errors that leave the buffer unchanged. Fixes: 69c7717c20cc ("drm/edid: Dump the EDID when drm_edid_get_panel_id() has an error") Cc: sta...@vger.kernel.org # 6.2 Cc: Douglas Anderson

Re: [PATCH v5] drm/virtio: Add option to disable KMS support

2023-03-01 Thread Gerd Hoffmann
On Thu, Mar 02, 2023 at 12:39:33AM +0300, Dmitry Osipenko wrote: > On 3/1/23 21:54, Rob Clark wrote: > > /* virtgpu_display.c */ > > +#if defined(CONFIG_DRM_VIRTIO_GPU_KMS) > > int virtio_gpu_modeset_init(struct virtio_gpu_device *vgdev); > > void virtio_gpu_modeset_fini(struct

Re: [PATCH v5] drm/virtio: Add option to disable KMS support

2023-03-01 Thread Gerd Hoffmann
Hi, > + if (vgdev->num_scanouts) { > + ret = virtio_gpu_modeset_init(vgdev); The call to virtio_gpu_modeset_fini() in the unregister code path needs this too. Otherwise the patch looks good to me, so with that fixed: Acked-by: Gerd Hoffmann take care, Gerd

Re: [PATCH] drm/vram-helper: turn on PRIME import/export

2023-03-01 Thread Christian König
Am 01.03.23 um 23:29 schrieb Simon Ser: We don't populate gem_prime_import_sg_table so only DMA-BUFs exported from our own device can be imported. Still, this is useful to user-space. But what happens if one of your BOs is imported into another device? Regards, Christian. Signed-off-by:

[Bug 217110] GPU Lockup on Radeon Pitcairn - VAAPI related

2023-03-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217110 --- Comment #2 from The Linux kernel's regression tracker (Thorsten Leemhuis) (regressi...@leemhuis.info) --- (In reply to The Linux kernel's regression tracker (Thorsten Leemhuis) from comment #1) > Sorry for causing you trouble (I'm just the

[Bug 217110] GPU Lockup on Radeon Pitcairn - VAAPI related

2023-03-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217110 The Linux kernel's regression tracker (Thorsten Leemhuis) (regressi...@leemhuis.info) changed: What|Removed |Added

[pull] amdgpu, amdkfd, radeon drm-fixes-6.3

2023-03-01 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.3. A bit bigger than usual since it's two weeks worth of fixes. The following changes since commit a48bba98380cb0b43dcd01d276c7efc282e3c33f: msm/fbdev: fix unused variable warning with clang. (2023-02-23 09:48:05 +1000) are available in the Git repository at:

Re: [PATCH v8 05/16] dma-buf/sync_file: Surface sync-file uABI

2023-03-01 Thread kernel test robot
Hi Rob, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm/drm-next linus/master v6.2 next-20230301] [cannot apply to drm-misc/drm-misc-next] [If your patch is applied to the wrong

Re: [PATCH drm-next v2 05/16] drm: manager to keep track of GPUs VA mappings

2023-03-01 Thread Liam R. Howlett
* Danilo Krummrich [230227 08:17]: ... > > > Would this variant be significantly more efficient? > > > > Well, what you are doing is walking the tree to see if there's anything > > there... then re-walking the tree to store it. So, yes, it's much more > > efficient.. However, writing is

[PATCH] drm/ast: Fix ARM compatibility

2023-03-01 Thread Jammy Huang
ARM architecture only has 'memory', so all devices are accessed by MMIO. Signed-off-by: Jammy Huang --- drivers/gpu/drm/ast/ast_main.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c index

Re: [PATCH v2] drm/i915/active: Fix misuse of non-idle barriers as fence trackers

2023-03-01 Thread Andi Shyti
Hi Janusz, On Sat, Feb 25, 2023 at 11:12:18PM +0100, Janusz Krzysztofik wrote: > Users reported oopses on list corruptions when using i915 perf with a > number of concurrently running graphics applications. Root cause analysis > pointed at an issue in barrier processing code -- a race among perf

[Bug 217110] New: GPU Lockup on Radeon Pitcairn - VAAPI related

2023-03-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217110 Bug ID: 217110 Summary: GPU Lockup on Radeon Pitcairn - VAAPI related Product: Drivers Version: 2.5 Kernel Version: 6.1.10 Hardware: Intel OS: Linux Tree:

Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples

2023-03-01 Thread Sebastian Reichel
Hi, On Tue, Feb 28, 2023 at 03:54:33PM -0600, Rob Herring wrote: > SPI and I2C bus node names are expected to be "spi" or "i2c", > respectively, with nothing else, a unit-address, or a '-N' index. A > pattern of 'spi0' or 'i2c0' or similar has crept in. Fix all these > cases. Mostly scripted with

Re: [Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2023-03-01 Thread Rodrigo Vivi
On Fri, Feb 17, 2023 at 09:51:37PM +0100, Daniel Vetter wrote: > Hi all, > > [I thought I've sent this out earlier this week, but alas got stuck, kinda > bad timing now since I'm out next week but oh well] > > So xe is a quite substantial thing, and I think we need a clear plan how to > land >

[PATCH] drm/vram-helper: turn on PRIME import/export

2023-03-01 Thread Simon Ser
We don't populate gem_prime_import_sg_table so only DMA-BUFs exported from our own device can be imported. Still, this is useful to user-space. Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Thomas Zimmermann Cc: Tian Tao Cc: Maxime Ripard Cc: Christian König Cc: Hans de Goede ---

Re: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files

2023-03-01 Thread Andi Shyti
> I am not sure if Tiles is appropriate usage here. Since MTL does not have the > concept of tiles. > Shouldn't we be using gt instead of tile in our usage? > > With s/tile/gt/g, > Reviewed-by: Radhakrishna Sripada yes, GT is preferred to tile, generally. Thanks for the review, I will change

Re: [PATCH] drm/vmwgfx: Avoid NULL-ptr dereference in vmw_cmd_dx_define_query()

2023-03-01 Thread Zack Rusin
On Wed, 2023-03-01 at 17:07 +0100, Thomas Zimmermann wrote: > There have been reports [1][2] that vmw_cmd_dx_define_query() can > be called with ctx_node->ctx set to NULL, which results in undefined > behavior in vmw_context_cotable(). Avoid this be returning an errno > code. > > Signed-off-by:

Re: [PATCH v4 1/4] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-03-01 Thread Dmitry Baryshkov
On 01/03/2023 19:08, Marijn Suijten wrote: On 2023-03-01 08:23:28, Abhinav Kumar wrote: On 3/1/2023 2:03 AM, Marijn Suijten wrote: On 2023-02-21 10:42:53, Jessica Zhang wrote: Then, for some patch hygiene, starting here: Depends on: "Implement tearcheck support on INTF block" [3] Changes

Re: [PATCH v4 1/4] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-03-01 Thread Abhinav Kumar
On 3/1/2023 9:08 AM, Marijn Suijten wrote: On 2023-03-01 08:23:28, Abhinav Kumar wrote: On 3/1/2023 2:03 AM, Marijn Suijten wrote: On 2023-02-21 10:42:53, Jessica Zhang wrote: Currently, DPU will enable TE during prepare_commit(). However, this will cause a crash and reboot to sahara when

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Separate wakeref tracking

2023-03-01 Thread Andrzej Hajda
On 27.02.2023 12:50, Jani Nikula wrote: On Fri, 24 Feb 2023, Andrzej Hajda wrote: From: Chris Wilson Extract the callstack tracking of intel_runtime_pm.c into its own utility so that that we can reuse it for other online debugging of scoped wakerefs. Signed-off-by: Chris Wilson

Re: [PATCH v5] drm/virtio: Add option to disable KMS support

2023-03-01 Thread Dmitry Osipenko
On 3/1/23 21:54, Rob Clark wrote: > /* virtgpu_display.c */ > +#if defined(CONFIG_DRM_VIRTIO_GPU_KMS) > int virtio_gpu_modeset_init(struct virtio_gpu_device *vgdev); > void virtio_gpu_modeset_fini(struct virtio_gpu_device *vgdev); > +#else > +static inline int virtio_gpu_modeset_init(struct

RE: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files

2023-03-01 Thread Sripada, Radhakrishna
I am not sure if Tiles is appropriate usage here. Since MTL does not have the concept of tiles. Shouldn't we be using gt instead of tile in our usage? With s/tile/gt/g, Reviewed-by: Radhakrishna Sripada > -Original Message- > From: dri-devel On Behalf Of Andi > Shyti > Sent:

RE: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files

2023-03-01 Thread Sripada, Radhakrishna
> -Original Message- > From: dri-devel On Behalf Of Andi > Shyti > Sent: Wednesday, March 1, 2023 3:03 AM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Tvrtko Ursulin ; Andi Shyti > ; Patelczyk, Maciej ; Andi > Shyti ; Wajdeczko, Michal > > Subject:

Re: [PATCH v3] drm/msm/dp: check core_initialized flag at both host_init() and host_deinit()

2023-03-01 Thread Dmitry Baryshkov
On 01/03/2023 18:57, Kuogee Hsieh wrote: On 2/28/2023 6:16 PM, Dmitry Baryshkov wrote: On Wed, 1 Mar 2023 at 02:17, Kuogee Hsieh wrote: There is a reboot/suspend test case where system suspend is forced during system booting up. Since dp_display_host_init() of external DP is executed at hpd

Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples

2023-03-01 Thread Stephen Boyd
Quoting Rob Herring (2023-02-28 13:54:33) > SPI and I2C bus node names are expected to be "spi" or "i2c", > respectively, with nothing else, a unit-address, or a '-N' index. A > pattern of 'spi0' or 'i2c0' or similar has crept in. Fix all these > cases. Mostly scripted with the following commands:

Re: [PATCH v13 00/13] Add PSR support for eDP

2023-03-01 Thread Dmitry Baryshkov
On 01/03/2023 21:06, Doug Anderson wrote: Hi, On Sun, Feb 12, 2023 at 8:29 AM Vinod Polimera wrote: Changes in v2: - Use dp bridge to set psr entry/exit instead of dpu_enocder. - Don't modify whitespaces. - Set self refresh aware from atomic_check. - Set self refresh aware only

Re: [PATCH v13 00/13] Add PSR support for eDP

2023-03-01 Thread Doug Anderson
Hi, On Wed, Mar 1, 2023 at 11:06 AM Doug Anderson wrote: > > Hi, > > On Sun, Feb 12, 2023 at 8:29 AM Vinod Polimera > wrote: > > > > Changes in v2: > > - Use dp bridge to set psr entry/exit instead of dpu_enocder. > > - Don't modify whitespaces. > > - Set self refresh aware from

Re: [PATCH] drm/amd/display: Simplify same effect if/else blocks

2023-03-01 Thread Deepak R Varma
On Mon, Jan 23, 2023 at 12:23:19AM +0530, Deepak R Varma wrote: > On Sun, Jan 15, 2023 at 12:52:10PM -0800, Joe Perches wrote: > > On Sun, 2023-01-15 at 15:30 +0530, Deepak R Varma wrote: > > > The if / else block code has same effect irrespective of the logical > > > evaluation. Hence, simply

Re: [PATCH RESEND] drm/tegra: sor: Remove redundant error logging

2023-03-01 Thread Dixit, Ashutosh
On Wed, 01 Mar 2023 11:48:06 -0800, Deepak R Varma wrote: > > A call to platform_get_irq() already prints an error on failure within > its own implementation. So printing another error based on its return > value in the caller is redundant and should be removed. The clean up > also makes if

Re: [PATCH RESEND] drm/nouveau/hwmon: Use sysfs_emit in show function callsbacks

2023-03-01 Thread Dixit, Ashutosh
On Wed, 01 Mar 2023 11:35:41 -0800, Deepak R Varma wrote: > > According to Documentation/filesystems/sysfs.rst, the show() callback > function of kobject attributes should strictly use sysfs_emit() instead > of sprintf() family functions. So, make this change. > Issue identified using the

[PATCH RESEND] drm/sti: Avoid full proxy f_ops for sti debug attributes

2023-03-01 Thread Deepak R Varma
Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() function adds the overhead of introducing a proxy file operation functions to wrap the original read/write inside file removal protection functions. This adds significant overhead in terms of introducing and managing the proxy

[PATCH RESEND] drm/tegra: sor: Remove redundant error logging

2023-03-01 Thread Deepak R Varma
A call to platform_get_irq() already prints an error on failure within its own implementation. So printing another error based on its return value in the caller is redundant and should be removed. The clean up also makes if condition block braces unnecessary. Remove that as well. Issue identified

Re: [PATCH v2 2/8] accel/qaic: Add uapi and core driver file

2023-03-01 Thread Jeffrey Hugo
On 2/17/2023 11:15 AM, Jeffrey Hugo wrote: On 2/16/2023 7:13 AM, Jacek Lawrynowicz wrote: Hi, On 06.02.2023 16:41, Jeffrey Hugo wrote: Add the QAIC driver uapi file and core driver file that binds to the PCIe device.  The core driver file also creates the accel device and manages all the

Re: [PATCH v2] drm/i915/mtl: Apply Wa_14017073508 for MTL Media Step

2023-03-01 Thread Matt Roper
On Wed, Mar 01, 2023 at 03:42:51PM +0530, Badal Nilawar wrote: > Apply Wa_14017073508 for MTL Media step instead of graphics step. > > v2: Use Media stepping instead of SoC die stepping (Matt) > > Bspec: 66623 > > Fixes: 8f70f1ec587d ("drm/i915/mtl: Add Wa_14017073508 for SAMedia") >

[PATCH RESEND] drm/nouveau/hwmon: Use sysfs_emit in show function callsbacks

2023-03-01 Thread Deepak R Varma
According to Documentation/filesystems/sysfs.rst, the show() callback function of kobject attributes should strictly use sysfs_emit() instead of sprintf() family functions. So, make this change. Issue identified using the coccinelle device_attr_show.cocci script. Signed-off-by: Deepak R Varma

Re: gud: set PATH connector property

2023-03-01 Thread Noralf Trønnes
Hi Simon, On 2/28/23 12:36, Simon Ser wrote: > Hi Noralf, > > Would it be possible to set the PATH connector property based on the > USB port used by gud? > > This would give user-space a persistent identifier for the connector: > if the user plugs in a USB display on a given port, the PATH

Re: [PATCH v13 00/13] Add PSR support for eDP

2023-03-01 Thread Doug Anderson
Hi, On Sun, Feb 12, 2023 at 8:29 AM Vinod Polimera wrote: > > Changes in v2: > - Use dp bridge to set psr entry/exit instead of dpu_enocder. > - Don't modify whitespaces. > - Set self refresh aware from atomic_check. > - Set self refresh aware only if psr is supported. > - Provide a

[PATCH v5] drm/virtio: Add option to disable KMS support

2023-03-01 Thread Rob Clark
From: Rob Clark Add a build option to disable modesetting support. This is useful in cases where the guest only needs to use the GPU in a headless mode, or (such as in the CrOS usage) window surfaces are proxied to a host compositor. As the modesetting ioctls are a big surface area for

Re: [PATCH v2 5/8] accel/qaic: Add datapath

2023-03-01 Thread Jeffrey Hugo
On 3/1/2023 10:05 AM, Stanislaw Gruszka wrote: On Wed, Mar 01, 2023 at 09:08:03AM -0700, Jeffrey Hugo wrote: This looks a bit suspicious. Are you sure you can modify sg->dma_address and still use it as valid value ? A single entry in the sg table is a contiguous mapping of memory. If it

Re: [PATCH] accel: Build sub-directories based on config options

2023-03-01 Thread Jeffrey Hugo
On 3/1/2023 9:53 AM, Stanislaw Gruszka wrote: On Wed, Mar 01, 2023 at 09:31:10AM -0700, Jeffrey Hugo wrote: On 3/1/2023 9:25 AM, Stanislaw Gruszka wrote: When accel drivers are disabled do not process into sub-directories and create built-in archives: AR

Re: [PATCH v2 5/8] accel/qaic: Add datapath

2023-03-01 Thread Stanislaw Gruszka
On Wed, Mar 01, 2023 at 09:08:03AM -0700, Jeffrey Hugo wrote: > > This looks a bit suspicious. Are you sure you can modify > > sg->dma_address and still use it as valid value ? > > A single entry in the sg table is a contiguous mapping of memory. If it > wasn't contiguous, it would have to be

Re: [PATCH v4 1/4] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-03-01 Thread Marijn Suijten
On 2023-03-01 08:23:28, Abhinav Kumar wrote: > > On 3/1/2023 2:03 AM, Marijn Suijten wrote: > > On 2023-02-21 10:42:53, Jessica Zhang wrote: > >> Currently, DPU will enable TE during prepare_commit(). However, this > >> will cause a crash and reboot to sahara when trying to read/write to > >>

Re: [PATCH v2 4/8] accel/qaic: Add control path

2023-03-01 Thread Jeffrey Hugo
On 3/1/2023 6:18 AM, Stanislaw Gruszka wrote: On Mon, Feb 06, 2023 at 08:41:41AM -0700, Jeffrey Hugo wrote: +* It turns out several of the iommu drivers don't combine adjacent +* regions, which is really what we expect based on the description of +* dma_map_sgtable(), so

Re: [PATCH v3] drm/msm/dp: check core_initialized flag at both host_init() and host_deinit()

2023-03-01 Thread Kuogee Hsieh
On 2/28/2023 6:16 PM, Dmitry Baryshkov wrote: On Wed, 1 Mar 2023 at 02:17, Kuogee Hsieh wrote: There is a reboot/suspend test case where system suspend is forced during system booting up. Since dp_display_host_init() of external DP is executed at hpd thread context, this test case may

Re: [PATCH] accel: Build sub-directories based on config options

2023-03-01 Thread Stanislaw Gruszka
On Wed, Mar 01, 2023 at 09:31:10AM -0700, Jeffrey Hugo wrote: > On 3/1/2023 9:25 AM, Stanislaw Gruszka wrote: > > When accel drivers are disabled do not process into > > sub-directories and create built-in archives: > > > >AR drivers/accel/habanalabs/built-in.a > >AR

Re: [PATCH] accel: Build sub-directories based on config options

2023-03-01 Thread Jeffrey Hugo
On 3/1/2023 9:25 AM, Stanislaw Gruszka wrote: When accel drivers are disabled do not process into sub-directories and create built-in archives: AR drivers/accel/habanalabs/built-in.a AR drivers/accel/ivpu/built-in.a Signed-off-by: Stanislaw Gruszka Should there be a fixes

[PATCH] accel: Build sub-directories based on config options

2023-03-01 Thread Stanislaw Gruszka
When accel drivers are disabled do not process into sub-directories and create built-in archives: AR drivers/accel/habanalabs/built-in.a AR drivers/accel/ivpu/built-in.a Signed-off-by: Stanislaw Gruszka --- drivers/accel/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH v4 1/4] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-03-01 Thread Abhinav Kumar
On 3/1/2023 2:03 AM, Marijn Suijten wrote: On 2023-02-21 10:42:53, Jessica Zhang wrote: Currently, DPU will enable TE during prepare_commit(). However, this will cause a crash and reboot to sahara when trying to read/write to register in get_autorefresh_config(), because the core clock rates

Re: [PATCH v2 8/8] MAINTAINERS: Add entry for QAIC driver

2023-03-01 Thread Jeffrey Hugo
On 3/1/2023 6:03 AM, Stanislaw Gruszka wrote: On Mon, Feb 06, 2023 at 08:41:45AM -0700, Jeffrey Hugo wrote: Add MAINTAINERS entry for the Qualcomm Cloud AI 100 driver. Signed-off-by: Jeffrey Hugo Reviewed-by: Carl Vanderlip --- MAINTAINERS | 8 1 file changed, 8 insertions(+)

Re: [PATCH v2 7/8] accel/qaic: Add qaic driver to the build system

2023-03-01 Thread Jeffrey Hugo
On 3/1/2023 6:02 AM, Stanislaw Gruszka wrote: On Mon, Feb 06, 2023 at 08:41:44AM -0700, Jeffrey Hugo wrote: Now that we have all the components of a minimum QAIC which can boot and run an AIC100 device, add the infrastructure that allows the QAIC driver to be built. Signed-off-by: Jeffrey Hugo

Re: [PATCH v2 3/8] accel/qaic: Add MHI controller

2023-03-01 Thread Jeffrey Hugo
On 2/28/2023 4:52 AM, Stanislaw Gruszka wrote: On Mon, Feb 06, 2023 at 08:41:40AM -0700, Jeffrey Hugo wrote: + mhi_cntl = kzalloc(sizeof(*mhi_cntl), GFP_KERNEL); [snip] + mhi_cntl->irq = kmalloc(sizeof(*mhi_cntl->irq), GFP_KERNEL); I recommend usage of devm_kzalloc(),

Re: [PATCH v2 5/8] accel/qaic: Add datapath

2023-03-01 Thread Jeffrey Hugo
On 2/27/2023 10:14 AM, Stanislaw Gruszka wrote: On Fri, Feb 24, 2023 at 12:36:51PM -0700, Jeffrey Hugo wrote: +static int reserve_pages(unsigned long start_pfn, unsigned long nr_pages, +bool reserve) +{ + unsigned long pfn; + unsigned long end_pfn = start_pfn

[PATCH] drm/vmwgfx: Avoid NULL-ptr dereference in vmw_cmd_dx_define_query()

2023-03-01 Thread Thomas Zimmermann
There have been reports [1][2] that vmw_cmd_dx_define_query() can be called with ctx_node->ctx set to NULL, which results in undefined behavior in vmw_context_cotable(). Avoid this be returning an errno code. Signed-off-by: Thomas Zimmermann Link: https://www.cve.org/CVERecord?id=CVE-2022-38096

Re: [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-03-01 Thread Rob Clark
On Wed, Mar 1, 2023 at 7:31 AM Sebastian Wick wrote: > > On Tue, Feb 28, 2023 at 11:52 PM Rob Clark wrote: > > > > On Tue, Feb 28, 2023 at 6:30 AM Sebastian Wick > > wrote: > > > > > > On Tue, Feb 28, 2023 at 12:48 AM Rob Clark wrote: > > > > > > > > On Mon, Feb 27, 2023 at 2:44 PM Sebastian

Re: [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-03-01 Thread Rodrigo Vivi
On Mon, Feb 27, 2023 at 02:20:04PM -0800, Rob Clark wrote: > On Mon, Feb 27, 2023 at 1:36 PM Rodrigo Vivi wrote: > > > > On Fri, Feb 24, 2023 at 09:59:57AM -0800, Rob Clark wrote: > > > On Fri, Feb 24, 2023 at 7:27 AM Luben Tuikov wrote: > > > > > > > > On 2023-02-24 06:37, Tvrtko Ursulin wrote:

Re: [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-03-01 Thread Sebastian Wick
On Tue, Feb 28, 2023 at 11:52 PM Rob Clark wrote: > > On Tue, Feb 28, 2023 at 6:30 AM Sebastian Wick > wrote: > > > > On Tue, Feb 28, 2023 at 12:48 AM Rob Clark wrote: > > > > > > On Mon, Feb 27, 2023 at 2:44 PM Sebastian Wick > > > wrote: > > > > > > > > On Mon, Feb 27, 2023 at 11:20 PM Rob

[PATCH 18/22] drm/tilcdc: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 17/22] drm/tidss: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tidss/tidss_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 21/22] drm/vc4: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c

[PATCH 22/22] drm/xlnx: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/xlnx/zynqmp_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 20/22] drm/tve200: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tve200/tve200_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 15/22] drm/stm: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/stm/drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/stm/drv.c

[PATCH 19/22] drm/arcpgu: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/arcpgu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tiny/arcpgu.c

[PATCH 14/22] drm/sti: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/sti/sti_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_drv.c

[PATCH 11/22] drm/meson: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/meson/meson_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 12/22] drm/mxsfb/lcdif: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mxsfb/lcdif_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 16/22] drm/sun4i: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/sun4i/sun4i_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 13/22] drm/mxsfb: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 10/22] drm/logicvc: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/logicvc/logicvc_drm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 08/22] drm/imx: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 09/22] drm/kmb: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/kmb/kmb_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_drv.c

[PATCH 06/22] drm/fsl-dcu: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 05/22] drm/atmel-hlcdc: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 07/22] drm/imx/dcss: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/imx/dcss/dcss-kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 04/22] drm/aspeed: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 03/22] arm/malidp: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/arm/malidp_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_drv.c

[PATCH 02/22] arm/hdlcd: Use GEM DMA fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids possible shadow buffering and makes the code simpler. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/arm/hdlcd_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c

[PATCH 01/22] drm/fbdev-dma: Implement fbdev emulation for GEM DMA helpers

2023-03-01 Thread Thomas Zimmermann
Implement fbdev emulation that is optimized for drivers that use DMA helpers. The buffers may no tbe moveable, may not require damage handling and have to be located in system memory. This allows fbdev emulation to operate directly on the buffer and mmap it to userspace. Besides those

[PATCH 00/22] drm/dma-helper: Add dedicated fbdev emulation

2023-03-01 Thread Thomas Zimmermann
Add fbdev emulation that is optimized for DMA helpers, as used by most drivers. It operates directly on GEM DMA buffers in system memory. Memory pages are mmap'ed directly to userspace. No implicit shadow buffers need to be allocated; as can happen with the generic fbdev emulation. Convert drivers

Re: [PATCH v2] drm/edid: Fix csync detailed mode parsing

2023-03-01 Thread Ville Syrjälä
On Wed, Mar 01, 2023 at 10:49:26AM +0200, Jani Nikula wrote: > On Tue, 28 Feb 2023, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Remove the bogus csync check and replace it with something that: > > - triggers for all forms of csync, not just the basic analog variant > > - actually

Re: [PATCH v6 1/2] drm: add kms driver for loongson display controller

2023-03-01 Thread Sui jingfeng
' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/suijingfeng/MAINTAINERS-add-maintainers-for-DRM-LOONGSON-driver/20230301-153240 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link

Re: [PATCH AUTOSEL 6.2 18/60] drm/msm/dp: Remove INIT_SETUP delay

2023-03-01 Thread Sasha Levin
On Mon, Feb 27, 2023 at 10:12:20AM +0100, Johan Hovold wrote: On Sun, Feb 26, 2023 at 09:00:03PM -0500, Sasha Levin wrote: From: Bjorn Andersson [ Upstream commit e17af1c9d861dc177e5b56009bd4f71ace688d97 ] During initalization of the DisplayPort controller an EV_HPD_INIT_SETUP event is

[PATCH] drm/amd/pm: set vangogh_set_apu_thermal_limit storage-class-specifier to static

2023-03-01 Thread Tom Rix
gcc with W=1 reports drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:1600:5: error: no previous prototype for ‘vangogh_set_apu_thermal_limit’ [-Werror=missing-prototypes] 1600 | int vangogh_set_apu_thermal_limit(struct smu_context *smu, uint32_t limit) |

Re: [PATCH] drm/msm: Initialize mode_config earlier

2023-03-01 Thread Johan Hovold
On Tue, Jan 24, 2023 at 09:09:02AM +0100, Johan Hovold wrote: > On Mon, Jan 23, 2023 at 09:17:49AM -0800, Bjorn Andersson wrote: > > On Mon, Jan 23, 2023 at 05:01:45PM +0100, Johan Hovold wrote: > > > On Tue, Jan 17, 2023 at 09:04:39AM +0100, Johan Hovold wrote: > > > > On Mon, Jan 16, 2023 at

[PATCH] gpu: host1x: Don't rely on dma_fence_wait_timeout return value

2023-03-01 Thread Mikko Perttunen
From: Mikko Perttunen dma_fence_wait_timeout (along with a host of other jiffies-based timeouting functions) returns zero both in case of timeout and when the wait completes during the last jiffy before timeout. As such, we can't rely on it to distinguish between success and timeout. To prevent

Re: [PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2023-03-01 Thread Alexander Potapenko
> > I'd like to avoid touching per-arch asm/string.h files if possible. > > Can't we do like below (i.e. keep asm implementations as-is, but > automatically redirect to __msan_memset()) ? If yes, we could move all > __msan_*() redirection from per-arch asm/string.h files to the common >

Re: [PATCH 5/6] habanalabs: use notifications and graceful reset for decoder

2023-03-01 Thread Stanislaw Gruszka
On Mon, Feb 27, 2023 at 01:13:05PM +0200, Oded Gabbay wrote: > From: Tomer Tayar > > Add notifications to user in case of decoder abnormal interrupts, and > use the graceful reset mechanism if reset is required. > > Signed-off-by: Tomer Tayar > Reviewed-by: Oded Gabbay > Signed-off-by: Oded

Re: [PATCH 4/6] habanalabs: assert return value of hw_fini

2023-03-01 Thread Stanislaw Gruszka
On Mon, Feb 27, 2023 at 01:13:04PM +0200, Oded Gabbay wrote: > From: Dafna Hirschfeld > > Since hw_fini return error code for failure indication, we should > check its return value. Currently it might only fail upon soft-reset > from hl_device_reset. Later patch will add hw_fini failure in case

Re: [PATCH v6 1/2] drm: add kms driver for loongson display controller

2023-03-01 Thread kernel test robot
-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/suijingfeng/MAINTAINERS-add-maintainers-for-DRM-LOONGSON-driver/20230301-153240 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r

Re: [PATCH 2/6] habanalabs: add device id to all threads names

2023-03-01 Thread Stanislaw Gruszka
On Mon, Feb 27, 2023 at 01:13:02PM +0200, Oded Gabbay wrote: > From: Sagiv Ozeri > > Compute driver threads names will start with hlX-*, when X is the > device id. > This will help distinguish them from the NIC thread names. > > Signed-off-by: Sagiv Ozeri > Reviewed-by: Oded Gabbay >

Re: [PATCH 1/6] habanalabs: add helper function to get vm hash node

2023-03-01 Thread Stanislaw Gruszka
On Mon, Feb 27, 2023 at 01:13:01PM +0200, Oded Gabbay wrote: > From: Tomer Tayar > > Add a helper function to search the vm hash for a node with a given > virtual address. > As opposed to the current code, this function explicitly returns NULL > when no node is found, instead of basing on the

Re: [PATCH v2 6/8] accel/qaic: Add mhi_qaic_cntl

2023-03-01 Thread Stanislaw Gruszka
On Mon, Feb 06, 2023 at 08:41:43AM -0700, Jeffrey Hugo wrote: > From: Pranjal Ramajor Asha Kanojiya > > Some of the MHI channels for an AIC100 device need to be routed to > userspace so that userspace can communicate directly with QSM. The MHI > bus does not support this, and while the WWAN

Re: [PATCH v2 4/8] accel/qaic: Add control path

2023-03-01 Thread Stanislaw Gruszka
On Mon, Feb 06, 2023 at 08:41:41AM -0700, Jeffrey Hugo wrote: > + * It turns out several of the iommu drivers don't combine adjacent > + * regions, which is really what we expect based on the description of > + * dma_map_sgtable(), so lets see if that can be done. It makes our >

Re: [PATCH v2 8/8] MAINTAINERS: Add entry for QAIC driver

2023-03-01 Thread Stanislaw Gruszka
On Mon, Feb 06, 2023 at 08:41:45AM -0700, Jeffrey Hugo wrote: > Add MAINTAINERS entry for the Qualcomm Cloud AI 100 driver. > > Signed-off-by: Jeffrey Hugo > Reviewed-by: Carl Vanderlip > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) > > diff --git a/MAINTAINERS

Re: [PATCH v2 7/8] accel/qaic: Add qaic driver to the build system

2023-03-01 Thread Stanislaw Gruszka
On Mon, Feb 06, 2023 at 08:41:44AM -0700, Jeffrey Hugo wrote: > Now that we have all the components of a minimum QAIC which can boot and > run an AIC100 device, add the infrastructure that allows the QAIC driver > to be built. > > Signed-off-by: Jeffrey Hugo > Reviewed-by: Carl Vanderlip > ---

[PATCH 5/5] habanalabs: use a mutex rather than a spinlock

2023-03-01 Thread Oded Gabbay
From: Koby Elbaz There are two reasons why mutex is better here: 1. There's a critical section relatively long, where in certain scenarios (e.g., multiple VM allocations) taking a spinlock might cause noticeable performance degradation. 2. It will remove the incorrect usage of mutex under

[PATCH 4/5] habanalabs: allow getting HL_INFO_DRAM_USAGE during soft-reset

2023-03-01 Thread Oded Gabbay
From: Dafna Hirschfeld We can allow userspace to query the dram usage during soft-reset. Signed-off-by: Dafna Hirschfeld Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/common/habanalabs_ioctl.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

[PATCH 3/5] habanalabs/gaudi2: fix register address on PDMA/EDMA idle check

2023-03-01 Thread Oded Gabbay
From: Koby Elbaz The PDMA/EDMA is_idle routines didn't check the correct CORE register in order to get the accurate idle state. Moreover, it's better to make the is_idle routine more robust by adding additional checks (IS_HALTED) before announcing that the core is idle. Signed-off-by: Koby

[PATCH 1/5] habanalabs: fix few misspelled words in the code

2023-03-01 Thread Oded Gabbay
From: farah kassabri Run spell checker on the code and fix accordingly. Signed-off-by: farah kassabri Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/common/command_submission.c | 2 +- drivers/accel/habanalabs/common/habanalabs.h | 4 ++--

  1   2   >