Re: [PATCH] drm/msm/adreno: Fix SM6375 GPU ID

2023-08-25 Thread Rob Clark
EN1, > .revn = 619, > .fw = { > > --- > base-commit: 6269320850097903b30be8f07a5c61d9f7592393 > change-id: 20230825-topic-6375_gpu_id-cf1596e2b147 > > Best regards, > -- > Konrad Dybcio >

Re: [PATCH v4 4/4] drm/msm/dsi: Enable widebus for DSI

2023-08-25 Thread Abhinav Kumar
On 8/22/2023 10:42 AM, Jessica Zhang wrote: DSI 6G v2.5.x+ supports a data-bus widen mode that allows DSI to send 48 bits of compressed data instead of 24. Enable this mode whenever DSC is enabled for supported chipsets. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dsi/dsi.c

Re: [PATCH v4 2/4] drm/msm/dpu: Enable widebus for DSI INTF

2023-08-25 Thread Abhinav Kumar
On 8/22/2023 10:42 AM, Jessica Zhang wrote: DPU supports a data-bus widen mode for DSI INTF. Enable this mode for all supported chipsets if widebus is enabled for DSI. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 7 +--

Re: [PATCH] drm/msm/dp: Add newlines to debug printks

2023-08-25 Thread Abhinav Kumar
On 8/25/2023 4:01 PM, Stephen Boyd wrote: These debug printks are missing newlines, causing drm debug logs to be hard to read. Add newlines so that the messages are on their own line. Cc: Kuogee Hsieh Cc: Vinod Polimera Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_link.c |

Re: [PATCH] drm/connector: Add newline to debug printk

2023-08-25 Thread Simon Ser
Reviewed-by: Simon Ser

[PATCH] drm/connector: Add newline to debug printk

2023-08-25 Thread Stephen Boyd
This debug printk is missing a newline, causing drm debug logs to be hard to read. Add a newline so that the message is on its own line. Cc: Simon Ser Cc: Pekka Paalanen Cc: Daniel Vetter Fixes: 8f86c82aba8b ("drm/connector: demote connector force-probes for non-master clients")

Re: [PATCH] drm/msm/dp: Add newlines to debug printks

2023-08-25 Thread Dmitry Baryshkov
On Sat, 26 Aug 2023 at 02:01, Stephen Boyd wrote: > > These debug printks are missing newlines, causing drm debug logs to be > hard to read. Add newlines so that the messages are on their own line. > > Cc: Kuogee Hsieh > Cc: Vinod Polimera > Signed-off-by: Stephen Boyd > --- >

[PATCH] drm/msm/dp: Add newlines to debug printks

2023-08-25 Thread Stephen Boyd
These debug printks are missing newlines, causing drm debug logs to be hard to read. Add newlines so that the messages are on their own line. Cc: Kuogee Hsieh Cc: Vinod Polimera Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_link.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH v1] drm/msm/dp: do not reinitialize phy unless retry during link training

2023-08-25 Thread Stephen Boyd
Quoting Kuogee Hsieh (2023-08-08 15:19:50) > DP PHY re-initialization done using dp_ctrl_reinitialize_mainlink() will > cause PLL unlocked initially and then PLL gets locked at the end of > initialization. PLL_UNLOCKED interrupt will fire during this time if the > interrupt mask is enabled. >

Re: [PATCH] accel/habanalabs: refactor deprecated strncpy to strscpy_pad

2023-08-25 Thread Kees Cook
On Fri, Aug 25, 2023 at 10:09:51PM +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > We see that `prop->cpucp_info.card_name` is supposed to be > NUL-terminated based on its usage within `__hwmon_device_register()` > (wherein it's called

Re: [PATCH] habanalabs/gaudi: refactor deprecated strncpy

2023-08-25 Thread Justin Stitt
dev->card_type = le32_to_cpu(hdev->asic_prop.cpucp_info.card_type); > > --- > base-commit: f9604036a3fb6149badf346994b46b03f9292db7 > change-id: > 20230824-strncpy-drivers-accel-habanalabs-gaudi-gaudi-c-f0b5814ced38 > > Best regards, > -- > Justin Stitt > [1]: https://lore.kernel.org/r/20230825-strncpy-habanalabs-combined-v1-1-daa05a89b...@google.com

Re: [PATCH] habanalabs/gaudi2: refactor deprecated strncpy

2023-08-25 Thread Justin Stitt
/* Overwrite binning masks with the actual binning values from F/W */ > hdev->dram_binning = prop->cpucp_info.dram_binning_mask; > > --- > base-commit: f9604036a3fb6149badf346994b46b03f9292db7 > change-id: > 20230824-strncpy-drivers-accel-habanalabs-gaudi2-gaudi2-c-0b3f717bee12 > > Best regards, > -- > Justin Stitt > [1]: https://lore.kernel.org/r/20230825-strncpy-habanalabs-combined-v1-1-daa05a89b...@google.com

Re: [PATCH] habanalabs/goya: refactor deprecated strncpy

2023-08-25 Thread Justin Stitt
trncpy(prop->cpucp_info.card_name, GOYA_DEFAULT_CARD_NAME, > + strscpy(prop->cpucp_info.card_name, GOYA_DEFAULT_CARD_NAME, > CARD_NAME_MAX_LEN); > > return 0; > > --- > base-commit: f9604036a3fb6149badf346994b46b03f9292db7

[PATCH] accel/habanalabs: refactor deprecated strncpy to strscpy_pad

2023-08-25 Thread Justin Stitt
y_pad(prop->cpucp_info.card_name, GOYA_DEFAULT_CARD_NAME, CARD_NAME_MAX_LEN); return 0; --- base-commit: 706a741595047797872e669b3101429ab8d378ef change-id: 20230825-strncpy-habanalabs-combined-c43b1d11960e Best regards, -- Justin Stitt

Re: [RFC PATCH 04/10] drm/panel_helper: Introduce drm_panel_helper

2023-08-25 Thread Doug Anderson
Maxime, On Sun, Aug 6, 2023 at 11:41 PM Maxime Ripard wrote: > > Hi Doug, > > Thanks for working on this :) > > On Fri, Aug 04, 2023 at 02:06:07PM -0700, Douglas Anderson wrote: > > The goal of this file is to contain helper functions for panel drivers > > to use. To start off with, let's add

[PATCH] drm/msm/adreno: Fix SM6375 GPU ID

2023-08-25 Thread Konrad Dybcio
= { --- base-commit: 6269320850097903b30be8f07a5c61d9f7592393 change-id: 20230825-topic-6375_gpu_id-cf1596e2b147 Best regards, -- Konrad Dybcio

Re: [PATCH v1] drm/msm/dp: do not reinitialize phy unless retry during link training

2023-08-25 Thread Abhinav Kumar
On 8/8/2023 3:19 PM, Kuogee Hsieh wrote: DP PHY re-initialization done using dp_ctrl_reinitialize_mainlink() will cause PLL unlocked initially and then PLL gets locked at the end of initialization. PLL_UNLOCKED interrupt will fire during this time if the interrupt mask is enabled. There

Re: [PATCH v7 09/11] drm/mediatek: dp: Add support for embedded DisplayPort aux-bus

2023-08-25 Thread Nícolas F . R . A . Prado
On Fri, Aug 25, 2023 at 05:42:59PM +0200, Michael Walle wrote: > Hi Nicolas, > > > > > For the eDP case we can support using aux-bus on MediaTek DP: this > > > > gives us the possibility to declare our panel as generic "panel-edp" > > > > which will automatically configure the timings and

Re: [PATCH] habanalabs/gaudi: refactor deprecated strncpy

2023-08-25 Thread Kees Cook
On Thu, Aug 24, 2023 at 08:41:26PM +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > A suitable replacement is `strscpy` [2] due to the fact that it > guarantees NUL-termination on its destination buffer argument which is > _not_ the case

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-08-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 --- Comment #35 from Mario Limonciello (AMD) (mario.limoncie...@amd.com) --- > Kernel modules: nvidiafb, nouveau > Kernel command line: BOOT_IMAGE=/boot/vmlinuz-6.4.11-060411-generic > root=UUID=218238de-a398-4391-b329-f9e1a095db36 ro

Re: [PATCH v2 2/3] drm/i915/guc: Close deregister-context race against CT-loss

2023-08-25 Thread Teres Alexis, Alan Previn
just a follow up note-to-self: On Tue, 2023-08-15 at 12:08 -0700, Teres Alexis, Alan Previn wrote: > On Tue, 2023-08-15 at 09:56 -0400, Vivi, Rodrigo wrote: > > On Mon, Aug 14, 2023 at 06:12:09PM -0700, Alan Previn wrote: > > > [snip] in guc_submission_send_busy_loop, we are incrementing the

Re: [PATCH v2 1/3] drm/i915/guc: Flush context destruction worker at suspend

2023-08-25 Thread Teres Alexis, Alan Previn
Thanks again Rodrigo for reviewing and apologies for my tardy replies. We are stil testing on shipping platforms and these latest patches seemed to have reduced the frequency and solved the "system hangs" while suspending but its still causing issues so we continue to debug. (issue is that its

Re: [PATCH] drm/panel: Add prepare_prev_first flag to Visionox VTDR6130

2023-08-25 Thread Jessica Zhang
On 8/21/2023 3:01 AM, neil.armstr...@linaro.org wrote: Hi Maxime, On 21/08/2023 10:17, Maxime Ripard wrote: Hi, On Fri, Aug 18, 2023 at 10:25:48AM +0200, neil.armstr...@linaro.org wrote: On 17/08/2023 20:35, Dmitry Baryshkov wrote: On 16/08/2023 10:51, neil.armstr...@linaro.org wrote:

Re: [PATCH 2/6] drm: ci: Force db410c to host mode

2023-08-25 Thread Rob Clark
On Fri, Aug 25, 2023 at 8:06 AM Helen Mae Koike Fornazier wrote: > > On Friday, August 25, 2023 11:41 -03, Rob Clark wrote: > > > On Fri, Aug 25, 2023 at 7:34 AM Helen Mae Koike Fornazier > > wrote: > > > > > > On Friday, August 25, 2023 11:30 -03, Rob Clark > > > wrote: > > > > > > > On Fri,

Re: [PATCH 2/6] drm: ci: Force db410c to host mode

2023-08-25 Thread Jani Nikula
On Fri, 25 Aug 2023, "Helen Mae Koike Fornazier" wrote: > I'm not sure I get what do you call out-of-tree builds. Using 'make O=dir' (see make help) to separate source and and output directories. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center

Re: [PATCH v1 0/3] udmabuf: Add support for page migration out of movable zone or CMA

2023-08-25 Thread Jason Gunthorpe
On Thu, Aug 24, 2023 at 08:33:09PM +0200, David Hildenbrand wrote: > Sure, we can simply always fail when we detect ZONE_MOVABLE or MIGRATE_CMA. > Maybe that keeps at least some use cases working. That seems fairly reasonable Jason

Re: [PATCH v6 1/4] drm: Use XArray instead of IDR for minors

2023-08-25 Thread James Zhu
On 2023-07-24 17:14, Michał Winiarski wrote: IDR is deprecated, and since XArray manages its own state with internal locking, it simplifies the locking on DRM side. Additionally, don't use the IRQ-safe variant, since operating on drm minor is not done in IRQ context. Signed-off-by: Michał

Re: [PATCH 1/9] accel/ivpu: Move set autosuspend delay to HW specific code

2023-08-25 Thread kernel test robot
Hi Stanislaw, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on next-20230825] [cannot apply to drm-misc/drm-misc-next linus/master v6.5-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[PATCH 09/10] drm/tests: Add test for drm_mode_addfb2()

2023-08-25 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_mode_addfb2 function. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 100 ++- 1 file changed, 98 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c

[PATCH 08/10] drm/tests: Add test for drm_framebuffer_free()

2023-08-25 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_free function. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 49 1 file changed, 49 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c

[PATCH 07/10] drm/tests: Add test for drm_framebuffer_init()

2023-08-25 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_init function. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 52 1 file changed, 52 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c

Re: [git pull] drm fixes for 6.5 final

2023-08-25 Thread pr-tracker-bot
The pull request you sent on Fri, 25 Aug 2023 13:07:17 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-08-25 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/beaa71d6e64103403a328bcc8cefa6e9b19544c1 Thank you! -- Deet-doot-dot, I am a bot.

[PATCH 06/10] drm/tests: Add test for drm_framebuffer_lookup()

2023-08-25 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_lookup function. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c

[PATCH 05/10] drm/tests: Add test for drm_framebuffer_cleanup()

2023-08-25 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_cleanup function. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 49 1 file changed, 49 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c

[PATCH 03/10] drm/tests: Add test case for drm_internal_framebuffer_create()

2023-08-25 Thread Carlos Eduardo Gallo Filho
Introduce a test to cover the creation of framebuffer with modifier on a device that doesn't support it. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 28 1 file changed, 28 insertions(+) diff --git

[PATCH 04/10] drm/tests: Add test for drm_framebuffer_check_src_coords()

2023-08-25 Thread Carlos Eduardo Gallo Filho
Add a parametrized test for the drm_framebuffer_check_src_coords function. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/drm_framebuffer.c| 1 + drivers/gpu/drm/tests/drm_framebuffer_test.c | 61 2 files changed, 62 insertions(+) diff --git

[PATCH 02/10] drm/tests: Add parameters to the drm_test_framebuffer_create test

2023-08-25 Thread Carlos Eduardo Gallo Filho
Extend the existing test case to cover: 1. Invalid flag atribute in the struct drm_mode_fb_cmd2. 2. Pixel format which requires non-linear modifier with DRM_FORMAT_MOD_LINEAR set. 3. Non-zero buffer offset for an unused plane Also replace strcpy to strscpy on test_to_desc for improved security

[PATCH 01/10] drm/tests: Stop using deprecated dev_private member on drm_framebuffer tests

2023-08-25 Thread Carlos Eduardo Gallo Filho
The dev_private member of drm_device is deprecated and its use should be avoided. Stop using it by embedding the drm_device onto a mock struct with a void pointer like dev_private, using it instead. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 29

[PATCH 00/10] Increase coverage on drm_framebuffer.c

2023-08-25 Thread Carlos Eduardo Gallo Filho
This patchset includes new KUnit tests for 7 untested functions from drm_framebuffer.c and improvements to the existent one. The first patch replace the use of dev_private member from drm_device mock on the existent test by embedding it into an outer struct containing a generic pointer. The

Re: [PATCH v7 09/11] drm/mediatek: dp: Add support for embedded DisplayPort aux-bus

2023-08-25 Thread Michael Walle
Hi Nicolas, > For the eDP case we can support using aux-bus on MediaTek DP: this > gives us the possibility to declare our panel as generic "panel-edp" > which will automatically configure the timings and available modes > via the EDID that we read from it. > > To do this, move the panel

Re: [PATCH 0/3] Make Allwinner A64's pll-mipi keep its rate when parent rate changes

2023-08-25 Thread Frank Oltmanns
Thank you for your feedback, Maxime! On 2023-08-25 at 10:13:53 +0200, Maxime Ripard wrote: > [[PGP Signed Part:Undecided]] > Hi, > > On Fri, Aug 25, 2023 at 07:36:36AM +0200, Frank Oltmanns wrote: >> I would like to make the Allwinner A64's pll-mipi to keep its rate when >> its parent's

Re: [PATCH 2/6] drm: ci: Force db410c to host mode

2023-08-25 Thread Helen Mae Koike Fornazier
On Friday, August 25, 2023 11:41 -03, Rob Clark wrote: > On Fri, Aug 25, 2023 at 7:34 AM Helen Mae Koike Fornazier > wrote: > > > > On Friday, August 25, 2023 11:30 -03, Rob Clark wrote: > > > > > On Fri, Aug 25, 2023 at 6:56 AM Jani Nikula > > > wrote: > > > > > > > > On Fri, 25 Aug 2023,

Re: [PATCH 2/6] drm: ci: Force db410c to host mode

2023-08-25 Thread Rob Clark
On Fri, Aug 25, 2023 at 7:34 AM Helen Mae Koike Fornazier wrote: > > On Friday, August 25, 2023 11:30 -03, Rob Clark wrote: > > > On Fri, Aug 25, 2023 at 6:56 AM Jani Nikula > > wrote: > > > > > > On Fri, 25 Aug 2023, Vignesh Raman wrote: > > > > Force db410c to host mode to fix network issue

Re: [PATCH v2 31/34] drm/amd/display: set stream gamut remap matrix to MPC for DCN301

2023-08-25 Thread Melissa Wen
On 08/22, Pekka Paalanen wrote: > On Thu, 10 Aug 2023 15:03:11 -0100 > Melissa Wen wrote: > > > dc->caps.color.mpc.gamut_remap says there is a post-blending color block > > for gamut remap matrix for DCN3 HW family and newer versions. However, > > those drivers still follow DCN10 programming

Re: [PATCH 2/6] drm: ci: Force db410c to host mode

2023-08-25 Thread Helen Mae Koike Fornazier
On Friday, August 25, 2023 11:30 -03, Rob Clark wrote: > On Fri, Aug 25, 2023 at 6:56 AM Jani Nikula > wrote: > > > > On Fri, 25 Aug 2023, Vignesh Raman wrote: > > > Force db410c to host mode to fix network issue which results in failure > > > to mount root fs via NFS. > > > See > > >

Re: [PATCH 2/6] drm: ci: Force db410c to host mode

2023-08-25 Thread Rob Clark
On Fri, Aug 25, 2023 at 6:56 AM Jani Nikula wrote: > > On Fri, 25 Aug 2023, Vignesh Raman wrote: > > Force db410c to host mode to fix network issue which results in failure > > to mount root fs via NFS. > > See > >

Re: [PATCH v2 19/34] drm/amd/display: decouple steps for mapping CRTC degamma to DC plane

2023-08-25 Thread Melissa Wen
On 08/22, Pekka Paalanen wrote: > On Thu, 10 Aug 2023 15:02:59 -0100 > Melissa Wen wrote: > > > The next patch adds pre-blending degamma to AMD color mgmt pipeline, but > > pre-blending degamma caps (DPP) is currently in use to provide DRM CRTC > > atomic degamma or implict degamma on legacy

Re: [PATCH 2/6] drm: ci: Force db410c to host mode

2023-08-25 Thread Maxime Ripard
Hi Helen, On Fri, Aug 25, 2023 at 03:09:04PM +0100, Helen Mae Koike Fornazier wrote: > Hi Jani, thanks for your comments > > On Friday, August 25, 2023 10:56 -03, Jani Nikula > wrote: > > > On Fri, 25 Aug 2023, Vignesh Raman wrote: > > > Force db410c to host mode to fix network issue which

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-08-25 Thread Javier Martinez Canillas
Jocelyn Falempe writes: Hello Jocelyn, > After discussions on IRC, the consensus is that the DRM drivers should > avoid software color conversion, and only advertise the formats supported > by hardware. > Update the doc accordingly so that the rule and exceptions are clear for > everyone. > >

Re: [PATCH v2 07/34] drm/amd/display: explicitly define EOTF and inverse EOTF

2023-08-25 Thread Melissa Wen
On 08/22, Pekka Paalanen wrote: > On Thu, 10 Aug 2023 15:02:47 -0100 > Melissa Wen wrote: > > > Instead of relying on color block names to get the transfer function > > intention regarding encoding pixel's luminance, define supported > > Electro-Optical Transfer Functions (EOTFs) and inverse

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-08-25 Thread Maxime Ripard
On Fri, 25 Aug 2023 16:04:18 +0200, Jocelyn Falempe wrote: > After discussions on IRC, the consensus is that the DRM drivers should > avoid software color conversion, and only advertise the formats supported > by hardware. > Update the doc accordingly so that the rule and exceptions are clear for

Re: [V10 7/8] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0

2023-08-25 Thread Lazar, Lijo
On 8/25/2023 2:08 PM, Evan Quan wrote: Fulfill the SMU13.0.0 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 3 + drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 3 +-

Re: [V10 5/8] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-08-25 Thread Lazar, Lijo
On 8/25/2023 2:08 PM, Evan Quan wrote: With WBRF feature supported, as a driver responding to the frequencies, amdgpu driver is able to do shadow pstate switching to mitigate possible interference(between its (G-)DDR memory clocks and local radio module frequency bands used by Wifi 6/6e/7).

Re: [BUG] KCSAN: data-race in drm_sched_entity_is_ready [gpu_sched] / drm_sched_entity_push_job [gpu_sched]

2023-08-25 Thread Mirsad Todorovac
Hi Christian, Aha, thanks, that explains it. Then the KCSAN report must be false positive. Kind regards, Mirsad On 8/25/23 09:05, Christian König wrote: Hi Mirsad, the name SPSC stands for SingleProducerSingleConsumer, so yes even by the name of the component we make it clear that this can

Re: [PATCH 2/6] drm: ci: Force db410c to host mode

2023-08-25 Thread Helen Mae Koike Fornazier
Hi Jani, thanks for your comments On Friday, August 25, 2023 10:56 -03, Jani Nikula wrote: > On Fri, 25 Aug 2023, Vignesh Raman wrote: > > Force db410c to host mode to fix network issue which results in failure > > to mount root fs via NFS. > > See > >

[PATCH v3] drm/plane: Add documentation about software color conversion.

2023-08-25 Thread Jocelyn Falempe
After discussions on IRC, the consensus is that the DRM drivers should avoid software color conversion, and only advertise the formats supported by hardware. Update the doc accordingly so that the rule and exceptions are clear for everyone. Acked-by: Simon Ser Signed-off-by: Jocelyn Falempe ---

Re: [PATCH v7 09/11] drm/mediatek: dp: Add support for embedded DisplayPort aux-bus

2023-08-25 Thread Nícolas F . R . A . Prado
Hi, On Fri, Aug 25, 2023 at 02:01:09PM +0200, Michael Walle wrote: > Hi AngeloGioacchino, > > > For the eDP case we can support using aux-bus on MediaTek DP: this > > gives us the possibility to declare our panel as generic "panel-edp" > > which will automatically configure the timings and

Re: [PATCH 2/6] drm: ci: Force db410c to host mode

2023-08-25 Thread Jani Nikula
On Fri, 25 Aug 2023, Vignesh Raman wrote: > Force db410c to host mode to fix network issue which results in failure > to mount root fs via NFS. > See > https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/cb72a629b8c15c80a54dda510743cefd1c4b65b8 > > Since this fix is not sent upstream, add it to

Re: [PATCH 3/3] drm/mst: adjust the function drm_dp_remove_payload_part2()

2023-08-25 Thread Imre Deak
On Wed, Aug 23, 2023 at 03:16:44AM +, Lin, Wayne wrote: > [AMD Official Use Only - General] > > > -Original Message- > > From: Imre Deak > > Sent: Saturday, August 19, 2023 1:46 AM > > To: Lin, Wayne > > Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; > >

Re: [PATCH v2 4/9] drm/sched: Split free_job into own work item

2023-08-25 Thread Christian König
Am 25.08.23 um 15:36 schrieb Matthew Brost: On Fri, Aug 25, 2023 at 10:02:32AM +0200, Christian König wrote: Am 25.08.23 um 04:58 schrieb Matthew Brost: On Fri, Aug 25, 2023 at 01:04:10AM +0200, Danilo Krummrich wrote: On Thu, Aug 10, 2023 at 07:31:32PM -0700, Matthew Brost wrote: Rather

Re: [PATCH v2 4/9] drm/sched: Split free_job into own work item

2023-08-25 Thread Matthew Brost
On Fri, Aug 25, 2023 at 10:02:32AM +0200, Christian König wrote: > Am 25.08.23 um 04:58 schrieb Matthew Brost: > > On Fri, Aug 25, 2023 at 01:04:10AM +0200, Danilo Krummrich wrote: > > > On Thu, Aug 10, 2023 at 07:31:32PM -0700, Matthew Brost wrote: > > > > Rather than call free_job and run_job in

Re: [PATCH v2] drm/plane: Add documentation about software color conversion.

2023-08-25 Thread Jocelyn Falempe
On 25/08/2023 14:03, Pekka Paalanen wrote: On Fri, 25 Aug 2023 10:55:35 +0200 Jocelyn Falempe wrote: After discussions on IRC, the consensus is that the DRM drivers should avoid software color conversion, and only advertise the formats supported by hardware. Update the doc accordingly so that

[PATCH] drm/tegra: Remove existing framebuffer only if we support display

2023-08-25 Thread Thierry Reding
From: Thierry Reding Tegra DRM doesn't support display on Tegra234 and later, so make sure not to remove any existing framebuffers in that case. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/drm.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

RE: [PATCH 0/5] Add the pci_get_base_class() helper and use it

2023-08-25 Thread Deucher, Alexander
[Public] > -Original Message- > From: amd-gfx On Behalf Of Sui > Jingfeng > Sent: Friday, August 25, 2023 2:27 AM > To: Bjorn Helgaas > Cc: alsa-de...@alsa-project.org; Sui Jingfeng ; > nouv...@lists.freedesktop.org; linux-ker...@vger.kernel.org; dri- > de...@lists.freedesktop.org;

[PATCH v2] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid

2023-08-25 Thread Jani Nikula
Connectors have source physical address available in display info. There's no need to parse the EDID again for this. Add drm_dp_cec_attach() to do this. Seems like the set_edid/unset_edid naming is a bit specific now that there's no need to pass the EDID at all, so aim for attach/detach going

[PATCH v4 6/8] drm: atmel-hlcdc: add DPI mode support for XLCDC

2023-08-25 Thread Manikandan Muralidharan
Add support for Display Pixel Interface (DPI) Compatible Mode support in atmel-hlcdc driver for XLCDC IP along with legacy pixel mapping.DPI mode BIT is configured in LCDC_CFG5 register. Signed-off-by: Manikandan Muralidharan [durai.manicka...@microchip.com: update DPI mode bit using is_xlcdc

[PATCH v4 3/8] drm: atmel-hlcdc: add LCD controller layer definition for sam9x75

2023-08-25 Thread Manikandan Muralidharan
Add the LCD controller layer definition and descriptor structure for sam9x75 for the following layers, - Base Layer - Overlay1 Layer - Overlay2 Layer - High End Overlay Signed-off-by: Manikandan Muralidharan --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 97 1 file

[PATCH v4 8/8] drm: atmel-hlcdc: add support for DSI output formats

2023-08-25 Thread Manikandan Muralidharan
Add support for the following DPI mode if the encoder type is DSI as per the XLCDC IP datasheet: - 16BPPCFG1 - 16BPPCFG2 - 16BPPCFG3 - 18BPPCFG1 - 18BPPCFG2 - 24BPP Signed-off-by: Manikandan Muralidharan [durai.manicka...@microchip.com: update output format using is_xlcdc flag] Signed-off-by:

[PATCH v4 7/8] drm: atmel-hlcdc: add vertical and horizontal scaling support for XLCDC

2023-08-25 Thread Manikandan Muralidharan
update the LCDC_HEOCFG30 and LCDC_HEOCFG31 registers of XLCDC IP which supports vertical and horizontal scaling with Bilinear and Bicubic co-efficients taps for Chroma and Luma componenets of the Pixel. Signed-off-by: Manikandan Muralidharan --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c |

[PATCH v4 5/8] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver

2023-08-25 Thread Manikandan Muralidharan
- XLCDC in SAM9X7 has different sets of registers and additional configuration bits when compared to previous HLCDC IP. Read/write operation on the controller registers is now separated using the XLCDC status flag. - HEO scaling, window resampling, Alpha blending, YUV-to-RGB conversion in

[PATCH v4 4/8] drm: atmel-hlcdc: Define SAM9X7 SoC XLCDC specific registers

2023-08-25 Thread Manikandan Muralidharan
From: Durai Manickam KR The register address of the XLCDC IP used in SAM9X7 SoC family are different from the previous HLCDC.Defining those address space with valid macros. Signed-off-by: Durai Manickam KR [manikanda...@microchip.com: Remove unused macro definitions] Signed-off-by: Manikandan

[PATCH v4 1/8] mfd: atmel-hlcdc: Add compatible for sam9x75 XLCD controller

2023-08-25 Thread Manikandan Muralidharan
Add compatible for sam9x75 XLCD controller. Signed-off-by: Manikandan Muralidharan --- drivers/mfd/atmel-hlcdc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/atmel-hlcdc.c b/drivers/mfd/atmel-hlcdc.c index 3c2414ba4b01..1daa7410468a 100644 --- a/drivers/mfd/atmel-hlcdc.c +++

[PATCH v4 2/8] drm: atmel-hlcdc: add flag to differentiate XLCDC and HLCDC IP

2023-08-25 Thread Manikandan Muralidharan
Add is_xlcdc flag in driver data to differentiate XLCDC and HLCDC code within the atmel-hlcdc driver files. Signed-off-by: Manikandan Muralidharan --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h

[PATCH v4 0/8] Add support for XLCDC to sam9x7 SoC family.

2023-08-25 Thread Manikandan Muralidharan
This patch series aims to add support for XLCDC IP of sam9x7 SoC family to the DRM subsystem.XLCDC IP has additional registers and new configuration bits compared to the existing register set of HLCDC IP. The new compatible string "microchip,sam9x75-xlcdc" is defined for sam9x75 variant of the

[PATCH 9/9] accel/ivpu: Move MMU register definitions to ivpu_mmu.c

2023-08-25 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz MMU registers are not platform specific so they should be defined separate to platform regs. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Stanislaw Gruszka Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_hw_37xx_reg.h | 33

[PATCH 8/9] accel/ivpu/37xx: White space cleanup

2023-08-25 Thread Stanislaw Gruszka
No functional change, adjust code formatting after previous changes. Reviewed-by: Karol Wachowski Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_hw_37xx_reg.h | 100 +- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git

[PATCH 7/9] accel/ivpu/37xx: Change register rename leftovers

2023-08-25 Thread Stanislaw Gruszka
Change remaining MTL_VPU_ register names to generation based names. Reviewed-by: Karol Wachowski Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_hw_37xx.c | 68 - drivers/accel/ivpu/ivpu_hw_37xx_reg.h | 72 +-- 2 files changed,

[PATCH 6/9] accel/ivpu: Add ivpu_bo_vaddr() and ivpu_bo_size()

2023-08-25 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz Use: - ivpu_bo_vaddr(bo) instead of bo->kvaddr - ivpu_bo_size(bo) instead of bo->base.size This is a preparation for switch to a drm_gem_shmem_object as a base for ivpu_bo, where: - bo->kvaddr becomes bo->base.vaddr - bo->base.size becomes bo->base.base.size

[PATCH 4/9] accel/ivpu: Initialize context with SSID = 1

2023-08-25 Thread Stanislaw Gruszka
From: Karol Wachowski Context with SSID = 1 is reserved and accesses on that context happen only when context is uninitialized on the VPU side. Such access triggers MMU fault (0xa) "Invalid CD Fetch", which doesn't contain any useful information besides context ID. This commit will change that

[PATCH 5/9] accel/ivpu: Move ivpu_fw_load() to ivpu_fw_init()

2023-08-25 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz ivpu_fw_load() doesn't have to be called separately in ivpu_dev_init(). Signed-off-by: Jacek Lawrynowicz Reviewed-by: Stanislaw Gruszka Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_drv.c | 4 drivers/accel/ivpu/ivpu_fw.c | 6 +++---

[PATCH 3/9] accel/ivpu: Print information about used workarounds

2023-08-25 Thread Stanislaw Gruszka
Use ivpu_dbg(MISC) to print information about workarounds. Reviewed-by: Karol Wachowski Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_drv.h | 5 + drivers/accel/ivpu/ivpu_hw_37xx.c | 5 + drivers/accel/ivpu/ivpu_hw_40xx.c | 4 3 files changed, 14 insertions(+)

[PATCH 2/9] accel/ivpu: Remove duplicated error messages

2023-08-25 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz Reduce the number of error messages per single failure in ivpu_dev_init(). Error messages are already printed by functions called from ivpu_dev_init(). Signed-off-by: Jacek Lawrynowicz Reviewed-by: Stanislaw Gruszka Signed-off-by: Stanislaw Gruszka ---

[PATCH 1/9] accel/ivpu: Move set autosuspend delay to HW specific code

2023-08-25 Thread Stanislaw Gruszka
From: Krystian Pradzynski Configure autosuspend values per HW generation and per platform. For non silicon platforms disable autosuspend for now, for silicon reduce it to 10 ms. Signed-off-by: Krystian Pradzynski Reviewed-by: Stanislaw Gruszka Signed-off-by: Stanislaw Gruszka ---

[PATCH 0/9] accel/ivpu: Update for -next 2023.08.25

2023-08-25 Thread Stanislaw Gruszka
Update for -next: - various cleanups - begin preparation for conversion to GEM SHMEM - print information about used workarounds Jacek Lawrynowicz (4): accel/ivpu: Remove duplicated error messages accel/ivpu: Move ivpu_fw_load() to ivpu_fw_init() accel/ivpu: Add ivpu_bo_vaddr() and

Re: [PATCH 1/2] drm/amdgpu: Merge debug module parameters

2023-08-25 Thread Christian König
Am 25.08.23 um 14:34 schrieb André Almeida: Em 25/08/2023 09:29, Christian König escreveu: Am 25.08.23 um 14:24 schrieb André Almeida: Em 25/08/2023 03:56, Christian König escreveu: > Am 24.08.23 um 18:25 schrieb André Almeida: >> Merge all developer debug options available as separated module

Re: [PATCH 1/2] drm/amdgpu: Merge debug module parameters

2023-08-25 Thread André Almeida
Em 25/08/2023 09:29, Christian König escreveu: Am 25.08.23 um 14:24 schrieb André Almeida: Em 25/08/2023 03:56, Christian König escreveu: > Am 24.08.23 um 18:25 schrieb André Almeida: >> Merge all developer debug options available as separated module >> parameters in one, making it obvious that

Re: [PATCH 1/2] drm/amdgpu: Merge debug module parameters

2023-08-25 Thread Christian König
Am 25.08.23 um 14:24 schrieb André Almeida: Em 25/08/2023 03:56, Christian König escreveu: > Am 24.08.23 um 18:25 schrieb André Almeida: >> Merge all developer debug options available as separated module >> parameters in one, making it obvious that are for developers. >> >> Signed-off-by: André

[PATCH 6/6] drm: ci: Remove rules

2023-08-25 Thread Vignesh Raman
Remove the rules from the following jobs, as the issues noted in the TODO comments have been resolved. This will ensure that these jobs are now included and executed as part of the CI/CD pipeline. msm:apq8016: TODO: current issue: it is not fiding the NFS root. Fix and remove this rule.

[PATCH 5/6] drm: ci: Update xfails

2023-08-25 Thread Vignesh Raman
Update amdgpu-stoney-fails, mediatek-mt8173-flakes, mediatek-mt8173-fails, rockchip-rk3399-fails, rockchip-rk3399-flakes, rockchip-rk3288-flakes, i915-cml-fails, i915-cml-flakes, msm-apq8016-flakes files. Add tests that fail sometimes into the *-flakes file and tests that are failing into the

[PATCH 4/6] drm: ci: Enable configs to fix mt8173 boot hang issue

2023-08-25 Thread Vignesh Raman
Enable regulator Enable MT6397 RTC driver Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/arm64.config | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/ci/arm64.config b/drivers/gpu/drm/ci/arm64.config index 817e18ddfd4f..ea7a6cceff40 100644 ---

[PATCH 2/6] drm: ci: Force db410c to host mode

2023-08-25 Thread Vignesh Raman
Force db410c to host mode to fix network issue which results in failure to mount root fs via NFS. See https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/cb72a629b8c15c80a54dda510743cefd1c4b65b8 Since this fix is not sent upstream, add it to build.sh script before building the kernel and dts.

[PATCH 3/6] drm: ci: virtio: update ci variables

2023-08-25 Thread Vignesh Raman
Update ci variables to fix the below error, ERROR - Igt error: malloc(): corrupted top size ERROR - Igt error: Received signal SIGABRT. ERROR - Igt error: Stack trace: ERROR - Igt error: #0 [fatal_sig_handler+0x17b] Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/test.yml | 5 - 1 file

[PATCH 1/6] drm: ci: igt_runner: remove todo

2023-08-25 Thread Vignesh Raman
/sys/kernel/debug/dri/*/state exist for every atomic KMS driver. We do not test non-atomic drivers, so remove the todo. Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/igt_runner.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ci/igt_runner.sh

[PATCH 0/6] drm: ci: fixes

2023-08-25 Thread Vignesh Raman
The patch series contains improvements, enabling new ci jobs which enables testing for Mediatek MT8173, Qualcomm APQ 8016 and VirtIO GPU, fixing issues with the ci jobs and updating the expectation files. This series is intended for drm branch topic/drm-ci. Vignesh Raman (6): drm: ci:

Re: [PATCH 1/2] drm/amdgpu: Merge debug module parameters

2023-08-25 Thread André Almeida
Em 25/08/2023 03:56, Christian König escreveu: > Am 24.08.23 um 18:25 schrieb André Almeida: >> Merge all developer debug options available as separated module >> parameters in one, making it obvious that are for developers. >> >> Signed-off-by: André Almeida >> --- >>

Re: [RFC]: shmem fd for non-DMA buffer sharing cross drivers

2023-08-25 Thread Daniel Stone
Hi, On Fri, 25 Aug 2023 at 08:56, Hsia-Jun Li wrote: > On 8/25/23 15:40, Pekka Paalanen wrote: > > if userspace cannot access things like an image's HDR metadata, then it > > will be impossible for userspace to program KMS to have the correct > > color pipeline, or to send intended HDR metadata

Re: [3/3] drm: bridge: it66121: Add audio support

2023-08-25 Thread Nishanth Menon
On 14:57-20220316, Nicolas Belin wrote: > Adding the audio support on the HDMI bridge for I2S only. > > Signed-off-by: Nicolas Belin > Signed-off-by: Andy.Hsieh > Reviewed-by: Neil Armstrong > --- > drivers/gpu/drm/bridge/ite-it66121.c | 627 +++ > 1 file changed, 627

[PATCH v4 3/3] dt-bindings: display: novatek,nt36523: define ports

2023-08-25 Thread Krzysztof Kozlowski
The panel-common schema does not define what "ports" property is, so bring the definition by referencing the panel-common-dual.yaml. Panels can be single- or dual-link, depending on the compatible, thus add if:then:else: block narrowing ports per variant. Signed-off-by: Krzysztof Kozlowski

[PATCH v4 2/3] dt-bindings: display: novatek,nt35950: define ports

2023-08-25 Thread Krzysztof Kozlowski
The panel-common schema does not define what "ports" property is, so bring the definition by referencing the panel-common-dual.yaml. Panels can be single- or dual-link, thus require only one port@0. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Rob Herring --- Changes since v3: 1. Rb tag

[PATCH v4 1/3] dt-bindings: display: panel: add common dual-link schema

2023-08-25 Thread Krzysztof Kozlowski
Add schema with common properties shared among dual-link panel ICs. Signed-off-by: Krzysztof Kozlowski --- Changes since v3: 1. Re-phrase description of binding and ports (Laurent) v3: https://lore.kernel.org/all/20230823081500.84005-1-krzysztof.kozlow...@linaro.org/ Changes since v2: 1. New

  1   2   >