Re: [PATCH v2 6/6] drm/msm/dsi: fix DSC for the bonded DSI case

2023-11-14 Thread Dmitry Baryshkov
On Wed, 15 Nov 2023 at 01:00, Jonathan Marek wrote: > > For the bonded DSI case, DSC pic_width and timing calculations should use > the width of a single panel instead of the total combined width. > > Signed-off-by: Jonathan Marek Fixes tag? I'll wait for the Tested-by by Marijn, otherwise

Re: [PATCH v2 5/6] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1

2023-11-14 Thread Dmitry Baryshkov
On Wed, 15 Nov 2023 at 01:00, Jonathan Marek wrote: > > Add a dsc_slice_per_pkt field to mipi_dsi_device struct and the necessary > changes to msm driver to support this field. > > Note that the removed "pkt_per_line = slice_per_intf * slice_per_pkt" > comment is incorrect. > > Signed-off-by:

Re: [PATCH v2 4/6] drm/msm/dsi: add a comment to explain pkt_per_line encoding

2023-11-14 Thread Dmitry Baryshkov
On Wed, 15 Nov 2023 at 01:00, Jonathan Marek wrote: > > Make it clear why the pkt_per_line value is being "divided by 2". > > Signed-off-by: Jonathan Marek > --- > drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c >

Re: [PATCH v2 3/6] drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC (fix video mode DSC)

2023-11-14 Thread Dmitry Baryshkov
On Wed, 15 Nov 2023 at 01:00, Jonathan Marek wrote: > > Video mode DSC won't work if this field is not set correctly. Set it to fix > video mode DSC (for slice_per_pkt==1 cases at least). > > Fixes: 08802f515c3 ("drm/msm/dsi: Add support for DSC configuration") > Signed-off-by: Jonathan Marek >

Re: [PATCH v2 2/6] drm/msm/dsi: set video mode widebus enable bit when widebus is enabled

2023-11-14 Thread Dmitry Baryshkov
On Wed, 15 Nov 2023 at 01:00, Jonathan Marek wrote: > > The value returned by msm_dsi_wide_bus_enabled() doesn't match what the > driver is doing in video mode. Fix that by actually enabling widebus for > video mode. > > Fixes: efcbd6f9cdeb ("drm/msm/dsi: Enable widebus for DSI") > Signed-off-by:

Re: [PATCH v2 2/6] drm/msm/dsi: set video mode widebus enable bit when widebus is enabled

2023-11-14 Thread Dmitry Baryshkov
On Wed, 15 Nov 2023 at 01:00, Jonathan Marek wrote: > > The value returned by msm_dsi_wide_bus_enabled() doesn't match what the > driver is doing in video mode. Fix that by actually enabling widebus for > video mode. > > Fixes: efcbd6f9cdeb ("drm/msm/dsi: Enable widebus for DSI") > Signed-off-by:

Re: [Spice-devel] [PATCH AUTOSEL 6.5 2/6] drm/qxl: prevent memory leak

2023-11-14 Thread Frediano Ziglio
Il giorno mer 15 nov 2023 alle ore 06:57 Sasha Levin ha scritto: > > From: Zongmin Zhou > > [ Upstream commit 0e8b9f258baed25f1c5672613699247c76b007b5 ] > > The allocated memory for qdev->dumb_heads should be released > in qxl_destroy_monitors_object before qxl suspend. >

Re: [REGRESSION]: nouveau: Asynchronous wait on fence

2023-11-14 Thread Owen T. Heisler
On 10/31/23 04:18, Linux regression tracking (Thorsten Leemhuis) wrote: On 28.10.23 04:46, Owen T. Heisler wrote: #regzbot introduced: d386a4b54607cf6f76e23815c2c9a3abc1d66882 #regzbot link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/180 ## Problem 1. Connect external display to DVI

Re: [PATCH v2] drm/amd/display: fix NULL dereference

2023-11-14 Thread José Pekkarinen
On 2023-11-14 23:01, Hamza Mahfooz wrote: On 11/14/23 10:27, José Pekkarinen wrote: The following patch will fix a minor issue where a debug message is referencing an struct that has just being checked whether is null or not. This has been noticed by using coccinelle, in the following output:

[PATCH AUTOSEL 5.10 2/3] drm/amdgpu: fix software pci_unplug on some chips

2023-11-14 Thread Sasha Levin
From: Vitaly Prosyak [ Upstream commit 4638e0c29a3f2294d5de0d052a4b8c9f33ccb957 ] When software 'pci unplug' using IGT is executed we got a sysfs directory entry is NULL for differant ras blocks like hdp, umc, etc. Before call 'sysfs_remove_file_from_group' and 'sysfs_remove_group' check that

[PATCH AUTOSEL 5.15 3/4] drm/amdgpu: fix software pci_unplug on some chips

2023-11-14 Thread Sasha Levin
From: Vitaly Prosyak [ Upstream commit 4638e0c29a3f2294d5de0d052a4b8c9f33ccb957 ] When software 'pci unplug' using IGT is executed we got a sysfs directory entry is NULL for differant ras blocks like hdp, umc, etc. Before call 'sysfs_remove_file_from_group' and 'sysfs_remove_group' check that

[PATCH AUTOSEL 5.15 2/4] drm/qxl: prevent memory leak

2023-11-14 Thread Sasha Levin
From: Zongmin Zhou [ Upstream commit 0e8b9f258baed25f1c5672613699247c76b007b5 ] The allocated memory for qdev->dumb_heads should be released in qxl_destroy_monitors_object before qxl suspend. otherwise,qxl_create_monitors_object will be called to reallocate memory for qdev->dumb_heads after qxl

[PATCH AUTOSEL 6.1 5/6] drm/amdgpu: fix software pci_unplug on some chips

2023-11-14 Thread Sasha Levin
From: Vitaly Prosyak [ Upstream commit 4638e0c29a3f2294d5de0d052a4b8c9f33ccb957 ] When software 'pci unplug' using IGT is executed we got a sysfs directory entry is NULL for differant ras blocks like hdp, umc, etc. Before call 'sysfs_remove_file_from_group' and 'sysfs_remove_group' check that

[PATCH AUTOSEL 6.1 2/6] drm/qxl: prevent memory leak

2023-11-14 Thread Sasha Levin
From: Zongmin Zhou [ Upstream commit 0e8b9f258baed25f1c5672613699247c76b007b5 ] The allocated memory for qdev->dumb_heads should be released in qxl_destroy_monitors_object before qxl suspend. otherwise,qxl_create_monitors_object will be called to reallocate memory for qdev->dumb_heads after qxl

[PATCH AUTOSEL 6.5 5/6] drm/amdgpu: fix software pci_unplug on some chips

2023-11-14 Thread Sasha Levin
From: Vitaly Prosyak [ Upstream commit 4638e0c29a3f2294d5de0d052a4b8c9f33ccb957 ] When software 'pci unplug' using IGT is executed we got a sysfs directory entry is NULL for differant ras blocks like hdp, umc, etc. Before call 'sysfs_remove_file_from_group' and 'sysfs_remove_group' check that

[PATCH AUTOSEL 6.5 2/6] drm/qxl: prevent memory leak

2023-11-14 Thread Sasha Levin
From: Zongmin Zhou [ Upstream commit 0e8b9f258baed25f1c5672613699247c76b007b5 ] The allocated memory for qdev->dumb_heads should be released in qxl_destroy_monitors_object before qxl suspend. otherwise,qxl_create_monitors_object will be called to reallocate memory for qdev->dumb_heads after qxl

[PATCH AUTOSEL 6.6 5/6] drm/amdgpu: fix software pci_unplug on some chips

2023-11-14 Thread Sasha Levin
From: Vitaly Prosyak [ Upstream commit 4638e0c29a3f2294d5de0d052a4b8c9f33ccb957 ] When software 'pci unplug' using IGT is executed we got a sysfs directory entry is NULL for differant ras blocks like hdp, umc, etc. Before call 'sysfs_remove_file_from_group' and 'sysfs_remove_group' check that

[PATCH AUTOSEL 6.6 2/6] drm/qxl: prevent memory leak

2023-11-14 Thread Sasha Levin
From: Zongmin Zhou [ Upstream commit 0e8b9f258baed25f1c5672613699247c76b007b5 ] The allocated memory for qdev->dumb_heads should be released in qxl_destroy_monitors_object before qxl suspend. otherwise,qxl_create_monitors_object will be called to reallocate memory for qdev->dumb_heads after qxl

Re: [PATCH v3 7/7] PCI: Exclude PCIe ports used for virtual links in pcie_bandwidth_available()

2023-11-14 Thread Lazar, Lijo
On 11/15/2023 1:37 AM, Mario Limonciello wrote: The USB4 spec specifies that PCIe ports that are used for tunneling PCIe traffic over USB4 fabric will be hardcoded to advertise 2.5GT/s and behave as a PCIe Gen1 device. The actual performance of these ports is controlled by the fabric

Re: [Intel-gfx] [PATCH] drm/i915/display: Fix phys_base to be relative not absolute

2023-11-14 Thread Rodrigo Vivi
On Sun, Nov 05, 2023 at 05:27:03PM +, Paz Zcharya wrote: > Fix the value of variable `phys_base` to be the relative offset in > stolen memory, and not the absolute offset of the GSM. to me it looks like the other way around. phys_base is the physical base address for the frame_buffer. Setting

Re: [PATCH 08/11] dt-bindings: display: vop2: Add rk3588 support

2023-11-14 Thread Andy Yan
On 11/15/23 05:54, Heiko Stübner wrote: Am Dienstag, 14. November 2023, 12:28:41 CET schrieb Andy Yan: From: Andy Yan The vop2 on rk3588 is similar to which on rk356x but with 4 video outputs and need to reference more grf modules. Signed-off-by: Andy Yan ---

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-14 Thread Andy Yan
Hi Heiko: On 11/15/23 07:34, Heiko Stübner wrote: Hi Andy, Am Dienstag, 14. November 2023, 12:28:55 CET schrieb Andy Yan: From: Andy Yan VOP2 on rk3588: Four video ports: VP0 Max 4096x2160 VP1 Max 4096x2160 VP2 Max 4096x2160 VP3 Max 2048x1080 4 4K Cluster windows with AFBC/line RGB and

Re: [PATCH v1] drm/virtio: Fix return value for VIRTGPU_CONTEXT_PARAM_DEBUG_NAME

2023-11-14 Thread Dmitry Osipenko
On 11/12/23 01:42, Dmitry Osipenko wrote: > The strncpy_from_user() returns number of copied bytes and not zero on > success. The non-zero return value of ioctl is treated as error. Return > zero on success instead of the number of copied bytes. > > Fixes: 7add80126bce ("drm/uapi: add explicit

Re: [PATCH] drm/sched: Define pr_fmt() for DRM using pr_*()

2023-11-14 Thread Luben Tuikov
On 2023-11-14 07:20, Jani Nikula wrote: > On Mon, 13 Nov 2023, Luben Tuikov wrote: >> Hi Jani, >> >> On 2023-11-10 07:40, Jani Nikula wrote: >>> On Thu, 09 Nov 2023, Luben Tuikov wrote: Define pr_fmt() as "[drm] " for DRM code using pr_*() facilities, especially when no devices

Re: linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-14 Thread Luben Tuikov
On 2023-11-13 22:08, Stephen Rothwell wrote: > Hi Luben, > > BTW, cherry picking commits does not avoid conflicts - in fact it can > cause conflicts if there are further changes to the files affected by > the cherry picked commit in either the tree/branch the commit was > cheery picked from or

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-14 Thread Heiko Stübner
Hi Andy, Am Dienstag, 14. November 2023, 12:28:55 CET schrieb Andy Yan: > From: Andy Yan > > VOP2 on rk3588: > > Four video ports: > VP0 Max 4096x2160 > VP1 Max 4096x2160 > VP2 Max 4096x2160 > VP3 Max 2048x1080 > > 4 4K Cluster windows with AFBC/line RGB and AFBC-only YUV support > 4 4K

[PATCH v2 6/6] drm/msm/dsi: fix DSC for the bonded DSI case

2023-11-14 Thread Jonathan Marek
For the bonded DSI case, DSC pic_width and timing calculations should use the width of a single panel instead of the total combined width. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/dsi/dsi.h | 3 ++- drivers/gpu/drm/msm/dsi/dsi_host.c| 20 +++-

[PATCH v2 5/6] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1

2023-11-14 Thread Jonathan Marek
Add a dsc_slice_per_pkt field to mipi_dsi_device struct and the necessary changes to msm driver to support this field. Note that the removed "pkt_per_line = slice_per_intf * slice_per_pkt" comment is incorrect. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/dsi/dsi_host.c | 25

[PATCH v2 4/6] drm/msm/dsi: add a comment to explain pkt_per_line encoding

2023-11-14 Thread Jonathan Marek
Make it clear why the pkt_per_line value is being "divided by 2". Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 66f198e21a7e..842765063b1b

[PATCH v2 3/6] drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC (fix video mode DSC)

2023-11-14 Thread Jonathan Marek
Video mode DSC won't work if this field is not set correctly. Set it to fix video mode DSC (for slice_per_pkt==1 cases at least). Fixes: 08802f515c3 ("drm/msm/dsi: Add support for DSC configuration") Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/dsi/dsi_host.c | 3 +++ 1 file changed, 3

[PATCH v2 2/6] drm/msm/dsi: set video mode widebus enable bit when widebus is enabled

2023-11-14 Thread Jonathan Marek
The value returned by msm_dsi_wide_bus_enabled() doesn't match what the driver is doing in video mode. Fix that by actually enabling widebus for video mode. Fixes: efcbd6f9cdeb ("drm/msm/dsi: Enable widebus for DSI") Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/dsi/dsi.xml.h | 1 +

[PATCH v2 1/6] drm/msm/dpu: fix video mode DSC for DSI

2023-11-14 Thread Jonathan Marek
Add necessary DPU changes for DSC to work with DSI video mode. Note this changes the logic to enable HCTL to match downstream, it will now be enabled for the no-DSC no-widebus case. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-

[PATCH v2 0/6] drm/msm: DSI DSC video mode fixes

2023-11-14 Thread Jonathan Marek
v2: added new patches (first two patches) to get DSC video mode running with the upstream DPU driver (tested with the vtdr6130 panel) Jonathan Marek (6): drm/msm/dpu: fix video mode DSC for DSI drm/msm/dsi: set video mode widebus enable bit when widebus is enabled drm/msm/dsi: set

Re: [PATCH v3] drm/bridge: panel: Add a device link between drm device and panel device

2023-11-14 Thread Linus Walleij
On Mon, Aug 7, 2023 at 8:06 AM Liu Ying wrote: > Add the device link when panel bridge is attached and delete the link > when panel bridge is detached. The drm device is the consumer while > the panel device is the supplier. This makes sure that the drm device > suspends eariler and resumes

Re: [PATCH 08/11] dt-bindings: display: vop2: Add rk3588 support

2023-11-14 Thread Heiko Stübner
Am Dienstag, 14. November 2023, 12:28:41 CET schrieb Andy Yan: > From: Andy Yan > > The vop2 on rk3588 is similar to which on rk356x > but with 4 video outputs and need to reference > more grf modules. > > Signed-off-by: Andy Yan > --- > > .../display/rockchip/rockchip-vop2.yaml | 25

Re: [PATCH] nouveau/gsp/r535: Fix a NULL vs error pointer bug

2023-11-14 Thread Danilo Krummrich
On 11/8/23 08:40, Dan Carpenter wrote: The r535_gsp_cmdq_get() function returns error pointers but this code checks for NULL. Also we need to propagate the error pointer back to the callers in r535_gsp_rpc_get(). Returning NULL will lead to a NULL pointer dereference. Fixes: 176fdcbddfd2

Re: [PATCH v1 1/1] drm/i915/gt: Dont wait forever when idling in suspend

2023-11-14 Thread Teres Alexis, Alan Previn
On Tue, 2023-11-14 at 08:22 -0800, Teres Alexis, Alan Previn wrote: > When suspending, add a timeout when calling > intel_gt_pm_wait_for_idle else if we have a leaked > wakeref (which would be indicative of a bug elsewhere > in the driver), driver will at exit the suspend-resume > cycle, after the

Re: [PATCH v2] drm/amd/display: fix NULL dereference

2023-11-14 Thread Hamza Mahfooz
On 11/14/23 10:27, José Pekkarinen wrote: The following patch will fix a minor issue where a debug message is referencing an struct that has just being checked whether is null or not. This has been noticed by using coccinelle, in the following output:

[PATCH v3 5/7] PCI: ACPI: Detect PCIe root ports that are used for tunneling

2023-11-14 Thread Mario Limonciello
USB4 routers support a feature called "PCIe tunneling". This allows PCIe traffic to be transmitted over USB4 fabric. PCIe root ports that are used in this fashion can be discovered by device specific data that specifies the USB4 router they are connected to. For the PCI core, the specific

[PATCH v3 7/7] PCI: Exclude PCIe ports used for virtual links in pcie_bandwidth_available()

2023-11-14 Thread Mario Limonciello
The USB4 spec specifies that PCIe ports that are used for tunneling PCIe traffic over USB4 fabric will be hardcoded to advertise 2.5GT/s and behave as a PCIe Gen1 device. The actual performance of these ports is controlled by the fabric implementation. Callers for pcie_bandwidth_available() will

[PATCH v3 6/7] PCI: Split up some logic in pcie_bandwidth_available() to separate function

2023-11-14 Thread Mario Limonciello
The logic to calculate bandwidth limits may be used at multiple call sites so split it up into its own static function instead. No intended functional changes. Suggested-by: Ilpo Järvinen Signed-off-by: Mario Limonciello --- v2->v3: * Split from previous patch version --- drivers/pci/pci.c |

[PATCH v3 4/7] PCI: pciehp: Move check for is_thunderbolt into a quirk

2023-11-14 Thread Mario Limonciello
commit 493fb50e958c ("PCI: pciehp: Assume NoCompl+ for Thunderbolt ports") added a check into pciehp code to explicitly set NoCompl+ for all Intel Thunderbolt controllers, including those that don't need it. This overloaded the purpose of the `is_thunderbolt` member of `struct pci_device` because

[PATCH v3 3/7] PCI: Drop pci_is_thunderbolt_attached()

2023-11-14 Thread Mario Limonciello
All callers have switched to dev_is_removable() for detecting hotpluggable PCIe devices. Signed-off-by: Mario Limonciello --- v2->v3: * No changes --- include/linux/pci.h | 22 -- 1 file changed, 22 deletions(-) diff --git a/include/linux/pci.h b/include/linux/pci.h index

[PATCH v3 2/7] drm/radeon: Switch from pci_is_thunderbolt_attached() to dev_is_removable()

2023-11-14 Thread Mario Limonciello
pci_is_thunderbolt_attached() looks at the hierarchy of the PCIe device to determine if any bridge along the way has the is_thunderbolt bit set. This bit will only be set when one of the devices in the hierarchy is an Intel Thunderbolt device. However PCIe devices can be connected to USB4 hubs

[PATCH v3 1/7] drm/nouveau: Switch from pci_is_thunderbolt_attached() to dev_is_removable()

2023-11-14 Thread Mario Limonciello
pci_is_thunderbolt_attached() looks at the hierarchy of the PCIe device to determine if any bridge along the way has the is_thunderbolt bit set. This bit will only be set when one of the devices in the hierarchy is an Intel Thunderbolt device. However PCIe devices can be connected to USB4 hubs

[PATCH v3 0/7] Improvements to pcie_bandwidth_available() for eGPUs

2023-11-14 Thread Mario Limonciello
The wrong values are reported from pcie_bandwidth_available() which can cause problems for performance of eGPUs. This series overhauls Thunderbolt related device detection and uses the changes to change the behavior of pcie_bandwidth_available(). v2->v3: * Stop lumping all thunderbolt VSEC and

Re: [Nouveau] [PATCH] nouveau: don't fail driver load if no display hw present.

2023-11-14 Thread Danilo Krummrich
On 11/5/23 21:37, Dave Airlie wrote: From: Dave Airlie If we get back ENODEV don't fail load. Maybe worth to note why this is OK in this case, might not be obvious to future readers of the code. Fixes: 15740541e8f0 ("drm/nouveau/devinit/tu102-: prepare for GSP-RM") Maybe I'm missing

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

2023-11-14 Thread Teres Alexis, Alan Previn
On Tue, 2023-11-14 at 17:52 +, Tvrtko Ursulin wrote: > On 14/11/2023 17:37, Teres Alexis, Alan Previn wrote: > > On Tue, 2023-11-14 at 17:27 +, Tvrtko Ursulin wrote: > > > On 13/11/2023 17:57, Teres Alexis, Alan Previn wrote: > > > > On Wed, 2023-10-25 at 13:58 +0100, Tvrtko Ursulin wrote:

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

2023-11-14 Thread Teres Alexis, Alan Previn
On Tue, 2023-11-14 at 12:36 -0500, Vivi, Rodrigo wrote: > On Tue, Nov 14, 2023 at 05:27:18PM +, Tvrtko Ursulin wrote: > > > > On 13/11/2023 17:57, Teres Alexis, Alan Previn wrote: > > > On Wed, 2023-10-25 at 13:58 +0100, Tvrtko Ursulin wrote: > > > > On 04/10/2023 18:59, Teres Alexis, Alan

Re: [PATCH 4/4] drm/msm/dsi: fix DSC for the bonded DSI case

2023-11-14 Thread Jonathan Marek
On 11/14/23 1:28 PM, Marijn Suijten wrote: On what hardware have you been testing this? Dmitry and I have a stack of patches to resolve support for Active CTL programming on newer hardware (DPU 5.0+ IIRC), where a single CTL is responsible for programming multiple INTF and DSC blocks as used in

Re: [PATCH i-g-t 2/2] lib/kunit: Execute test cases synchronously

2023-11-14 Thread Janusz Krzysztofik
Hi Mauro, Thanks for review. On Friday, 10 November 2023 08:52:04 CET Mauro Carvalho Chehab wrote: > On Mon, 6 Nov 2023 10:59:38 +0100 > Janusz Krzysztofik wrote: > > > Up to now we've been loading a KUnit test module in background and parsing > > in parallel its KTAP output with results

Re: [PATCH 4/4] drm/msm/dsi: fix DSC for the bonded DSI case

2023-11-14 Thread Marijn Suijten
On what hardware have you been testing this? Dmitry and I have a stack of patches to resolve support for Active CTL programming on newer hardware (DPU 5.0+ IIRC), where a single CTL is responsible for programming multiple INTF and DSC blocks as used in bonded DSI. On 2023-11-14 12:42:16,

Re: [PATCH 2/6] drm: Add drm_atomic_helper_buffer_damage_{iter_init,merged}() helpers

2023-11-14 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi > > Am 14.11.23 um 16:58 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: >> >> Hello Thomas, >> >> Thanks a lot for your feedback. >> >>> Hi >>> >>> Am 09.11.23 um 18:24 schrieb Javier Martinez Canillas: To be used by drivers that do

Re: [PATCH 0/6] drm: Allow the damage helpers to handle buffer damage

2023-11-14 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Hi [...] >>> And why does it flicker? Is there old data stored somewhere? >>> >> >> It flickers because the framebuffer changed and so the damage tracking >> is not used correctly to flush the damaged areas to the backing storage. > > I think I got

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

2023-11-14 Thread Tvrtko Ursulin
On 14/11/2023 17:37, Teres Alexis, Alan Previn wrote: On Tue, 2023-11-14 at 17:27 +, Tvrtko Ursulin wrote: On 13/11/2023 17:57, Teres Alexis, Alan Previn wrote: On Wed, 2023-10-25 at 13:58 +0100, Tvrtko Ursulin wrote: On 04/10/2023 18:59, Teres Alexis, Alan Previn wrote: On Thu,

Re: [PATCH] iosys-map: Rename locals used inside macros

2023-11-14 Thread Lucas De Marchi
On Tue, Oct 24, 2023 at 08:10:32AM -0500, Lucas De Marchi wrote: On Tue, Oct 24, 2023 at 01:07:10PM +0200, Michał Winiarski wrote: Widely used variable names can be used by macro users, potentially leading to name collisions. Suffix locals used inside the macros with an underscore, to reduce

[PATCH 4/4] drm/msm/dsi: fix DSC for the bonded DSI case

2023-11-14 Thread Jonathan Marek
For the bonded DSI case, DSC pic_width and timing calculations should use the width of a single panel instead of the total combined width. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/dsi/dsi.h | 3 ++- drivers/gpu/drm/msm/dsi/dsi_host.c| 20 +++-

[PATCH 3/4] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1

2023-11-14 Thread Jonathan Marek
Add a dsc_slice_per_pkt field to mipi_dsi_device struct and the necessary changes to msm driver to support this field. Note that the removed "pkt_per_line = slice_per_intf * slice_per_pkt" comment is incorrect. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/dsi/dsi_host.c | 25

[PATCH 2/4] drm/msm/dsi: add a comment to explain pkt_per_line encoding

2023-11-14 Thread Jonathan Marek
Make it clear why the pkt_per_line value is being "divided by 2". Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index bddc57726fb9..2ea2fc105fbf

[PATCH 1/4] drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC (fix video mode DSC)

2023-11-14 Thread Jonathan Marek
Video mode DSC won't work if this field is not set correctly. Set it to fix video mode DSC (for slice_per_pkt==1 cases at least). Fixes: 08802f515c3 ("drm/msm/dsi: Add support for DSC configuration") Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/dsi/dsi_host.c | 3 +++ 1 file changed, 3

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

2023-11-14 Thread Teres Alexis, Alan Previn
On Tue, 2023-11-14 at 17:27 +, Tvrtko Ursulin wrote: > On 13/11/2023 17:57, Teres Alexis, Alan Previn wrote: > > On Wed, 2023-10-25 at 13:58 +0100, Tvrtko Ursulin wrote: > > > On 04/10/2023 18:59, Teres Alexis, Alan Previn wrote: > > > > On Thu, 2023-09-28 at 13:46 +0100, Tvrtko Ursulin wrote:

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

2023-11-14 Thread Rodrigo Vivi
On Tue, Nov 14, 2023 at 05:27:18PM +, Tvrtko Ursulin wrote: > > On 13/11/2023 17:57, Teres Alexis, Alan Previn wrote: > > On Wed, 2023-10-25 at 13:58 +0100, Tvrtko Ursulin wrote: > > > On 04/10/2023 18:59, Teres Alexis, Alan Previn wrote: > > > > On Thu, 2023-09-28 at 13:46 +0100, Tvrtko

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

2023-11-14 Thread Tvrtko Ursulin
On 13/11/2023 17:57, Teres Alexis, Alan Previn wrote: On Wed, 2023-10-25 at 13:58 +0100, Tvrtko Ursulin wrote: On 04/10/2023 18:59, Teres Alexis, Alan Previn wrote: On Thu, 2023-09-28 at 13:46 +0100, Tvrtko Ursulin wrote: On 27/09/2023 17:36, Teres Alexis, Alan Previn wrote: alan:snip It

Re: [PATCH] drm/doc/rfc: SR-IOV support on the new Xe driver

2023-11-14 Thread Michal Wajdeczko
On 14.11.2023 14:22, Vivi, Rodrigo wrote: > On Tue, 2023-11-14 at 12:37 +, Tvrtko Ursulin wrote: >> >> On 10/11/2023 18:22, Michal Wajdeczko wrote: >>> The Single Root I/O Virtualization (SR-IOV) extension to the PCI >>> Express (PCIe) specification suite is supported starting from 12th >>>

Re: [PATCH] drm/doc/rfc: SR-IOV support on the new Xe driver

2023-11-14 Thread Michal Wajdeczko
On 14.11.2023 13:37, Tvrtko Ursulin wrote: > > On 10/11/2023 18:22, Michal Wajdeczko wrote: >> The Single Root I/O Virtualization (SR-IOV) extension to the PCI >> Express (PCIe) specification suite is supported starting from 12th >> generation of Intel Graphics processors. >> >> This RFC aims

Re: [PATCH v8 02/20] drm/gpuvm: Helper to get range of unmap from a remap op.

2023-11-14 Thread Danilo Krummrich
On 10/31/23 16:12, Sarah Walker wrote: From: Donald Robson Determining the start and range of the unmap stage of a remap op is a common piece of code currently implemented by multiple drivers. Add a helper for this. Changes since v7: - Renamed helper to drm_gpuva_op_remap_to_unmap_range() -

[PATCH] drm/amdgpu/gmc11: fix logic typo in AGP check

2023-11-14 Thread ivlipski
From: Alex Deucher Should be && rather than ||. Fixes: b2e1cbe6281f ("drm/amdgpu/gmc11: disable AGP on GC 11.5") Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 0/6] drm: Allow the damage helpers to handle buffer damage

2023-11-14 Thread Thomas Zimmermann
Hi Am 14.11.23 um 17:28 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hi Javier Am 09.11.23 um 18:24 schrieb Javier Martinez Canillas: Hello, This series is to fix an issue that surfaced after damage clipping was enabled for the virtio-gpu by commit 01f05940a9a7

Re: [PATCH 04/17] dt-bindings: mmc: samsung,exynos-dw-mshc: add specific compatibles for existing SoC

2023-11-14 Thread Ulf Hansson
On Wed, 8 Nov 2023 at 11:44, Krzysztof Kozlowski wrote: > > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in >

Re: [PATCH 2/6] drm: Add drm_atomic_helper_buffer_damage_{iter_init,merged}() helpers

2023-11-14 Thread Thomas Zimmermann
Hi Am 14.11.23 um 16:58 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Thanks a lot for your feedback. Hi Am 09.11.23 um 18:24 schrieb Javier Martinez Canillas: To be used by drivers that do per-buffer (e.g: virtio-gpu) uploads (rather than per-plane uploads),

Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib

2023-11-14 Thread Dmitry Baryshkov
On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > > From: Sui Jingfeng > > The it66121_create_bridge() and it66121_destroy_bridge() are added to > export the core functionalities. Create a connector manually by using > bridge connector helpers when link as a lib. > > Signed-off-by: Sui

Re: [PATCH 0/6] drm: Allow the damage helpers to handle buffer damage

2023-11-14 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi Javier > > Am 09.11.23 um 18:24 schrieb Javier Martinez Canillas: >> Hello, >> >> This series is to fix an issue that surfaced after damage clipping was >> enabled for the virtio-gpu by commit 01f05940a9a7 ("drm/virtio: Enable >> fb damage clips property for the

Re: [PATCH] drm/nouveau: Prevents NULL pointer dereference in nouveau_uvmm_sm_prepare

2023-11-14 Thread Danilo Krummrich
Hi Yuran, On 10/26/23 19:03, Yuran Pereira wrote: There are instances where the "args" argument passed to nouveau_uvmm_sm_prepare() is NULL. I.e. when nouveau_uvmm_sm_prepare() is called from nouveau_uvmm_sm_unmap_prepare() ``` static int nouveau_uvmm_sm_unmap_prepare(struct nouveau_uvmm

[PATCH v1 1/1] drm/i915/gt: Dont wait forever when idling in suspend

2023-11-14 Thread Alan Previn
When suspending, add a timeout when calling intel_gt_pm_wait_for_idle else if we have a leaked wakeref (which would be indicative of a bug elsewhere in the driver), driver will at exit the suspend-resume cycle, after the kernel detects the held reference and prints a message to abort suspending

Re: [RFC PATCH v2] drm/test: add a test suite for GEM objects backed by shmem

2023-11-14 Thread Marco Pagani
On 2023-11-10 15:41, Maxime Ripard wrote: > On Wed, Nov 08, 2023 at 02:42:03PM +0100, Marco Pagani wrote: >> This patch introduces an initial KUnit test suite for GEM objects >> backed by shmem buffers. >> >> Suggested-by: Javier Martinez Canillas >> Signed-off-by: Marco Pagani >> >> v2: >> -

Re: [RFC PATCH v3 05/12] netdev: netdevice devmem allocator

2023-11-14 Thread Pavel Begunkov
On 11/11/23 17:19, David Ahern wrote: On 11/10/23 7:26 AM, Pavel Begunkov wrote: On 11/7/23 23:03, Mina Almasry wrote: On Tue, Nov 7, 2023 at 2:55 PM David Ahern wrote: On 11/7/23 3:10 PM, Mina Almasry wrote: On Mon, Nov 6, 2023 at 3:44 PM David Ahern wrote: On 11/5/23 7:44 PM, Mina

Re: [PATCH 6/8] drm/bridge: it66121: Add a helper to initialize the DRM bridge structure

2023-11-14 Thread Dmitry Baryshkov
On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > > From: Sui Jingfeng > > Helps the it66121_probe() function to reduce weight, no functional change. This is not a proper commit message. > > Signed-off-by: Sui Jingfeng > --- > drivers/gpu/drm/bridge/ite-it66121.c | 24

Re: [PATCH 5/8] drm/bridge: it66121: Add a helper function to read chip id

2023-11-14 Thread Dmitry Baryshkov
On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > > From: Sui Jingfeng > > Read the required chip id data back by calling regmap_bulk_read() once, > reduce the number of local variables needed in it66121_probe() function. > And store its values into struct it66121_ctx, as it will be used

Re: [PATCH 4/8] drm/bridge: it66121: Add a helper function to get the next bridge

2023-11-14 Thread Dmitry Baryshkov
On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > > From: Sui Jingfeng > > Group the code lines(which with the same functional) into one dedicated > function, which reduce the weight of it66121_probe() function. Just trivial > cleanuo, no functional change. > > Signed-off-by: Sui Jingfeng >

Re: [PATCH 2/6] drm: Add drm_atomic_helper_buffer_damage_{iter_init, merged}() helpers

2023-11-14 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi > > Am 09.11.23 um 18:24 schrieb Javier Martinez Canillas: [...] >> struct drm_rect src; >> memset(iter, 0, sizeof(*iter)); >> @@ -223,7 +224,8 @@ __drm_atomic_helper_damage_iter_init(struct >> drm_atomic_helper_damage_iter *iter, >>

Re: [PATCH 3/8] drm/bridge: it66121: Add a helper function to read bus width

2023-11-14 Thread Dmitry Baryshkov
On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > > From: Sui Jingfeng > > Group those relavent code lines (which with common purpose) into one helper > function, suppress the dependency on DT to function level. Just trivial > cleanup, no functional change. > > Signed-off-by: Sui Jingfeng >

Re: [PATCH 1/2] drm: Add DRM-managed alloc_workqueue() and alloc_ordered_workqueue()

2023-11-14 Thread Jeffrey Hugo
On 1/17/2023 8:24 PM, Jiasheng Jiang wrote: On Tue, Jan 10, 2023 at 11:24:47PM +0800, Jiasheng Jiang wrote: Add drmm_alloc_workqueue() and drmm_alloc_ordered_workqueue(), the helpers that provide managed workqueue cleanup. The workqueue will be destroyed with the final reference of the DRM

Re: [PATCH 2/8] drm/bridge: it66121: Add bridge_to_it66121() helper and use it

2023-11-14 Thread Dmitry Baryshkov
On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > > From: Sui Jingfeng > > Instead of using the container_of() directly, which avoid the code lines > too long in horizontial. Just trivial cleanup, no functional change. > > Signed-off-by: Sui Jingfeng Reviewed-by: Dmitry Baryshkov > --- >

Re: [PATCH 1/8] drm/bridge: it66121: Use dev replace ctx->dev in the it66121_probe()

2023-11-14 Thread Dmitry Baryshkov
On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > > From: Sui Jingfeng > > As the value of 'ctx->dev' has already been cached to the local variable > 'dev', so keep the usage consistent. Just trivial cleanup, no functional > change. > > Signed-off-by: Sui Jingfeng Reviewed-by: Dmitry

Re: [PATCH 7/8] drm/bridge: it66121: Add another implementation for getting match data

2023-11-14 Thread Dmitry Baryshkov
On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > > From: Sui Jingfeng > > Because if use the i2c_get_match_data() function on our platform, the > following error will emerge. > > [3.597872] ACPI: bus type drm_connector registered > [3.602877] loongson :00:06.1: Found LS7A1000

Re: [PATCH 2/6] drm: Add drm_atomic_helper_buffer_damage_{iter_init,merged}() helpers

2023-11-14 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, Thanks a lot for your feedback. > Hi > > Am 09.11.23 um 18:24 schrieb Javier Martinez Canillas: >> To be used by drivers that do per-buffer (e.g: virtio-gpu) uploads (rather >> than per-plane uploads), since these type of drivers need to handle buffer >>

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

2023-11-14 Thread Michael Walle
Hi, My current guess would be that the issue I was seeing was already fixed with dd9e329af723 ("drm/bridge: ti-sn65dsi83: Fix enable/disable flow to meet spec") and I didn't properly test both changes separately. I had the exact same thought, as I've found your second patch. My cheap

[PATCH v6 2/2] drm/i915/guc: Close deregister-context race against CT-loss

2023-11-14 Thread Alan Previn
If we are at the end of suspend or very early in resume its possible an async fence signal (via rcu_call) is triggered to free_engines which could lead us to the execution of the context destruction worker (after a prior worker flush). Thus, when suspending, insert rcu_barriers at the start of

[PATCH v6 1/2] drm/i915/guc: Flush context destruction worker at suspend

2023-11-14 Thread Alan Previn
When suspending, flush the context-guc-id deregistration worker at the final stages of intel_gt_suspend_late when we finally call gt_sanitize that eventually leads down to __uc_sanitize so that the deregistration worker doesn't fire off later as we reset the GuC microcontroller. Signed-off-by:

[PATCH v6 0/2] Resolve suspend-resume racing with GuC destroy-context-worker

2023-11-14 Thread Alan Previn
This series is the result of debugging issues root caused to races between the GuC's destroyed_worker_func being triggered vs repeating suspend-resume cycles with concurrent delayed fence signals for engine-freeing. The reproduction steps require that an app is launched right before the start of

Re: [PATCH 2/6] drm: Add drm_atomic_helper_buffer_damage_{iter_init, merged}() helpers

2023-11-14 Thread Thomas Zimmermann
Hi Am 09.11.23 um 18:24 schrieb Javier Martinez Canillas: To be used by drivers that do per-buffer (e.g: virtio-gpu) uploads (rather than per-plane uploads), since these type of drivers need to handle buffer damages instead of frame damages. The drm_atomic_helper_buffer_damage_iter_init() has

Re: [PATCH 2/6] drm: Add drm_atomic_helper_buffer_damage_{iter_init,merged}() helpers

2023-11-14 Thread Thomas Zimmermann
Hi Am 09.11.23 um 18:24 schrieb Javier Martinez Canillas: To be used by drivers that do per-buffer (e.g: virtio-gpu) uploads (rather than per-plane uploads), since these type of drivers need to handle buffer damages instead of frame damages. The drm_atomic_helper_buffer_damage_iter_init() has

Re: [PATCH 0/6] drm: Allow the damage helpers to handle buffer damage

2023-11-14 Thread Thomas Zimmermann
Hi Javier Am 09.11.23 um 18:24 schrieb Javier Martinez Canillas: Hello, This series is to fix an issue that surfaced after damage clipping was enabled for the virtio-gpu by commit 01f05940a9a7 ("drm/virtio: Enable fb damage clips property for the primary plane"). After that change, flickering

[PATCH v2] drm/amd/display: fix NULL dereference

2023-11-14 Thread José Pekkarinen
The following patch will fix a minor issue where a debug message is referencing an struct that has just being checked whether is null or not. This has been noticed by using coccinelle, in the following output: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c:540:25-29: ERROR: aconnector

Re: [Intel-xe] [PATCH v3] Documentation/gpu: VM_BIND locking document

2023-11-14 Thread Thomas Hellström
Hi, Rodrigo On 11/1/23 21:11, Rodrigo Vivi wrote: Add the first version of the VM_BIND locking document which is intended to be part of the xe driver upstreaming agreement. The document describes and discuss the locking used during exec- functions, evicton and for userptr gpu-vmas. Intention

Re: [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes

2023-11-14 Thread Rob Herring
On Sun, Nov 12, 2023 at 07:43:59PM +0100, Krzysztof Kozlowski wrote: > Compatibles should not use quotes in the bindings. Unfortunately yamllint skips checking these due to a bug handling bracketed lists. There's an open issue for it[1]. > Signed-off-by: Krzysztof Kozlowski > --- >

Re: [PATCH 00/17] dt-bindings: samsung: add specific compatibles for existing SoC

2023-11-14 Thread Krzysztof Kozlowski
On Wed, 08 Nov 2023 11:43:26 +0100, Krzysztof Kozlowski wrote: > Merging > === > I propose to take entire patchset through my tree (Samsung SoC), because: > 1. Next cycle two new SoCs will be coming (Google GS101 and ExynosAutov920), > so >they will touch the same lines in some of the

[PATCH v2] drm/edid/firmware: drop drm_kms_helper.edid_firmware backward compat

2023-11-14 Thread Jani Nikula
Since the edid_firmware module parameter was moved from drm_kms_helper.ko to drm.ko in v4.15, we've had a backwards compatibility helper in place, with a DRM_NOTE() suggesting to migrate to drm.edid_firmware. This was added in commit ac6c35a4d8c7 ("drm: add backwards compatibility support for

[PATCH 3/8] drm/bridge: it66121: Add a helper function to read bus width

2023-11-14 Thread Sui Jingfeng
From: Sui Jingfeng Group those relavent code lines (which with common purpose) into one helper function, suppress the dependency on DT to function level. Just trivial cleanup, no functional change. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/bridge/ite-it66121.c | 32

[PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib

2023-11-14 Thread Sui Jingfeng
From: Sui Jingfeng The it66121_create_bridge() and it66121_destroy_bridge() are added to export the core functionalities. Create a connector manually by using bridge connector helpers when link as a lib. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/bridge/ite-it66121.c | 134

  1   2   >