Re: [PATCH v3 1/2] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-22 Thread Sakari Ailus
Hi Rafael, Björn, Thanks for the review. On Mon, Jan 22, 2024 at 07:16:54PM +0100, Rafael J. Wysocki wrote: > On Mon, Jan 22, 2024 at 7:12 PM Bjorn Helgaas wrote: > > > > On Mon, Jan 22, 2024 at 01:41:21PM +0200, Sakari Ailus wrote: > > > There are two ways to opportunistically increment a

Re: [PATCH][next] drm/nouveau/fifo/gk104: remove redundant variable ret

2024-01-22 Thread Dan Carpenter
On Tue, Jan 23, 2024 at 12:04:23AM +0100, Danilo Krummrich wrote: > On 1/16/24 13:31, Dan Carpenter wrote: > > On Tue, Jan 16, 2024 at 11:16:09AM +, Colin Ian King wrote: > > > The variable ret is being assigned a value but it isn't being > > > read afterwards. The assignment is redundant and

Re: [PATCH] drm: apple: mark local functions static

2024-01-22 Thread Arnd Bergmann
On Mon, Jan 22, 2024, at 21:50, Janne Grunau wrote: > On Wed, Jan 17, 2024, at 11:44, Arnd Bergmann wrote: >> >> -int parse_sample_rate_bit(struct dcp_parse_ctx *handle, unsigned int >> *ratebit) >> +static int parse_sample_rate_bit(struct dcp_parse_ctx *handle, >> unsigned int *ratebit) >> {

[PATCH] nouveau: rip out fence irq allow/block sequences.

2024-01-22 Thread Dave Airlie
From: Dave Airlie fences are signalled on nvidia hw using non-stall interrupts. non-stall interrupts are not latched from my reading. When nouveau emits a fence, it requests a NON_STALL signalling, but it only calls the interface to allow the non-stall irq to happen after it has already

Re: [PATCH 2/2] scripts/kernel-doc: Do not process backslash lines in comments

2024-01-22 Thread Randy Dunlap
On 1/22/24 01:31, Anna-Maria Behnsen wrote: > Commit 654784284430 ("kernel-doc: bugfix - multi-line macros") introduces > pre-processing of backslashes at the end of a line to not break multi-line > macros. This pre-processing is done independently if it is inside code or > inside a comment. >

[RFC] Revert "drm/sched: Split free_job into own work item"

2024-01-22 Thread Mario Limonciello
commit f7fe64ad0f22 ("drm/sched: Split free_job into own work item") causes graphics hangs at GDM or right after logging in on a Framework 13 AMD laptop (containing a Phoenix APU). This reverts commit f7fe64ad0f22ff034f8ebcfbd7299ee9cc9b57d7. Fixes: f7fe64ad0f22 ("drm/sched: Split free_job into

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2024-01-22 Thread 林睿祥

Re: [PATCH 1/3] dt-bindings: display: bridge: add sam9x7-lvds compatible

2024-01-22 Thread Dharma.B
Hi Conor, On 22/01/24 10:07 pm, Conor Dooley wrote: > On Mon, Jan 22, 2024 at 04:51:16PM +0100, Krzysztof Kozlowski wrote: >> On 22/01/2024 09:29, Dharma Balasubiramani wrote: >>> Add the 'sam9x7-lvds' compatible binding, which describes the >>> Low Voltage Differential Signaling (LVDS)

Re: [PATCH 1/3] dt-bindings: display: bridge: add sam9x7-lvds compatible

2024-01-22 Thread Dharma.B
Hi Krzysztof, On 22/01/24 9:21 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 22/01/2024 09:29, Dharma Balasubiramani wrote: >> Add the 'sam9x7-lvds' compatible binding, which describes the >> Low Voltage

Making drm_gpuvm work across gpu devices

2024-01-22 Thread Zeng, Oak
Hi Danilo and all, During the work of Intel's SVM code, we came up the idea of making drm_gpuvm to work across multiple gpu devices. See some discussion here: https://lore.kernel.org/dri-devel/ph7pr11mb70049e7e6a2f40bf6282ecc292...@ph7pr11mb7004.namprd11.prod.outlook.com/ The reason we try to

Re: [PATCH] drm/qxl: pass a device into ttm init.

2024-01-22 Thread Steven Rostedt
On Tue, 23 Jan 2024 12:20:15 +1000 Dave Airlie wrote: > From: Dave Airlie > > ttm init was changed to look at numa node, but that needed a device. > > Only qxl appears to not hand in a device, so just fix that. > > Fixes: b0a7ce53d494 ("drm/ttm: Schedule delayed_delete worker closer") >

[PATCH] drm/xe: Remove PVC from xe_wa kunit tests

2024-01-22 Thread Lucas De Marchi
Since the PCI IDs for PVC were added to the xe driver, the xe_wa tests should not try to create a fake PVC device since they can't find the right PCI ID. Fix bugs when running kunit: # xe_wa_gt: ASSERTION FAILED at drivers/gpu/drm/xe/tests/xe_wa_test.c:111 Expected ret == 0, but

RE: [PATCH 21/23] drm/xe/svm: GPU page fault support

2024-01-22 Thread Zeng, Oak
> -Original Message- > From: Welty, Brian > Sent: Monday, January 22, 2024 9:06 PM > To: Zeng, Oak ; dri-devel@lists.freedesktop.org; intel- > x...@lists.freedesktop.org > Cc: Bommu, Krishnaiah ; Ghimiray, Himal Prasad > ; thomas.hellst...@linux.intel.com; > Vishwanathapura, Niranjana ;

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Steven Rostedt
On Tue, 23 Jan 2024 12:32:39 +1000 Dave Airlie wrote: > On Tue, 23 Jan 2024 at 12:21, Dave Airlie wrote: > > > > On Tue, 23 Jan 2024 at 12:15, Steven Rostedt wrote: > > > > > > On Mon, 22 Jan 2024 19:56:08 -0500 > > > "Bhardwaj, Rajneesh" wrote: > > > > > > > > > > > On 1/22/2024 7:43 PM,

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Dave Airlie
On Tue, 23 Jan 2024 at 12:21, Dave Airlie wrote: > > On Tue, 23 Jan 2024 at 12:15, Steven Rostedt wrote: > > > > On Mon, 22 Jan 2024 19:56:08 -0500 > > "Bhardwaj, Rajneesh" wrote: > > > > > > > > On 1/22/2024 7:43 PM, Linus Torvalds wrote: > > > > On Mon, 22 Jan 2024 at 15:17, Steven Rostedt

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Dave Airlie
On Tue, 23 Jan 2024 at 12:15, Steven Rostedt wrote: > > On Mon, 22 Jan 2024 19:56:08 -0500 > "Bhardwaj, Rajneesh" wrote: > > > > > On 1/22/2024 7:43 PM, Linus Torvalds wrote: > > > On Mon, 22 Jan 2024 at 15:17, Steven Rostedt wrote: > > >> Perhaps this is the real fix? > > > If you send a

[PATCH] drm/qxl: pass a device into ttm init.

2024-01-22 Thread Dave Airlie
From: Dave Airlie ttm init was changed to look at numa node, but that needed a device. Only qxl appears to not hand in a device, so just fix that. Fixes: b0a7ce53d494 ("drm/ttm: Schedule delayed_delete worker closer") Reported-by: Steven Rostedt Cc: Rajneesh Bhardwaj Signed-off-by: Dave

[PATCH] drm/qxl: pass a device into ttm init.

2024-01-22 Thread Dave Airlie
From: Dave Airlie ttm init was changed to look at numa node, but that needed a device. Only qxl appears to not hand in a device, so just fix that. Fixes: b0a7ce53d494 ("drm/ttm: Schedule delayed_delete worker closer") Reported-by: Steven Rostedt Cc: Rajneesh Bhardwaj Signed-off-by: Dave

Re: [PATCH 21/23] drm/xe/svm: GPU page fault support

2024-01-22 Thread Welty, Brian
On 1/17/2024 2:12 PM, Oak Zeng wrote: On gpu page fault of a virtual address, try to fault in the virtual address range to gpu page table and let HW to retry on the faulty address. Right now, we always migrate the whole vma which contains the fault address to GPU. This is subject to change of

[linux-next:master] BUILD REGRESSION 319fbd8fc6d339e0a1c7b067eed870c518a13a02

2024-01-22 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 319fbd8fc6d339e0a1c7b067eed870c518a13a02 Add linux-next specific files for 20240122 Unverified Error/Warning (likely false positive, please contact us if interested): drivers/gpu/drm/etnaviv

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Steven Rostedt
On Mon, 22 Jan 2024 19:56:08 -0500 "Bhardwaj, Rajneesh" wrote: > > On 1/22/2024 7:43 PM, Linus Torvalds wrote: > > On Mon, 22 Jan 2024 at 15:17, Steven Rostedt wrote: > >> Perhaps this is the real fix? > > If you send a signed-off version, I'll apply it asap. > > > I think a fix might

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Linus Torvalds
On Mon, 22 Jan 2024 at 16:56, Bhardwaj, Rajneesh wrote: > > I think a fix might already be in flight. Please see Linux-Kernel Archive: > Re: [PATCH] drm/ttm: fix ttm pool initialization for no-dma-device drivers > (iu.edu) Please use lore.kernel.org that doesn't corrupt whitespace in patches

Re: [PATCH 2/5] drm/bridge: simple-bridge: Extend match support for non-DT based systems

2024-01-22 Thread Laurent Pinchart
On Tue, Jan 23, 2024 at 12:32:17AM +0800, Sui Jingfeng wrote: > Which is intended to be used on non-DT environment, where the simple-bridge > platform device is created by either the display controller driver side or > platform firmware subsystem. Could you give an example of a platform where you

Re: [PATCH 5/5] drm-bridge: display-connector: Switch to use fwnode API

2024-01-22 Thread Laurent Pinchart
On Tue, Jan 23, 2024 at 12:32:20AM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > Because API has wider coverage, it can be used on non-DT systems as well. > > Signed-off-by: Sui Jingfeng > --- > drivers/gpu/drm/bridge/display-connector.c | 22 -- > 1 file changed, 12

Re: [PATCH v1 4/6] drm/lima: handle spurious timeouts due to high irq latency

2024-01-22 Thread Qiang Yu
On Sun, Jan 21, 2024 at 11:11 PM Erico Nunes wrote: > > On Sun, Jan 21, 2024 at 12:20 PM Qiang Yu wrote: > > > > On Sun, Jan 21, 2024 at 5:56 PM Hillf Danton wrote: > > > > > > On Wed, 17 Jan 2024 04:12:10 +0100 Erico Nunes > > > > > > > > @@ -401,9 +399,33 @@ static enum drm_gpu_sched_stat >

Re: [PATCH 3/5] drm/bridge: simple-bridge: Allow acquiring the next bridge with fwnode API

2024-01-22 Thread Laurent Pinchart
On Tue, Jan 23, 2024 at 12:32:18AM +0800, Sui Jingfeng wrote: > Which make it possible to use this driver on non-DT based systems, > meanwhile, made no functional changes for DT based systems. > > Signed-off-by: Sui Jingfeng > --- > drivers/gpu/drm/bridge/simple-bridge.c | 51

Re: [PATCH 1/5] drm/bridge: Add drm_bridge_find_by_fwnode() helper

2024-01-22 Thread Laurent Pinchart
Hi Sui, Thank you for the patch. On Tue, Jan 23, 2024 at 12:32:16AM +0800, Sui Jingfeng wrote: > Because ACPI based systems only has the fwnode associated, the of_node > member of struct device is NULL. To order to move things forward, we add > drm_bridge_find_by_fwnode() to extend the support.

RE: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Bhardwaj, Rajneesh
[AMD Official Use Only - General] -Original Message- From: Steven Rostedt Sent: Monday, January 22, 2024 6:19 PM To: LKML Cc: Linus Torvalds ; Bhardwaj, Rajneesh ; Kuehling, Felix ; Koenig, Christian ; dri-devel@lists.freedesktop.org Subject: Re: [BUG] BUG: kernel NULL pointer

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Bhardwaj, Rajneesh
On 1/22/2024 7:43 PM, Linus Torvalds wrote: On Mon, 22 Jan 2024 at 15:17, Steven Rostedt wrote: Perhaps this is the real fix? If you send a signed-off version, I'll apply it asap. I think a fix might already be in flight. Please see Linux-Kernel Archive: Re: [PATCH] drm/ttm: fix ttm pool

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Linus Torvalds
On Mon, 22 Jan 2024 at 15:17, Steven Rostedt wrote: > > Perhaps this is the real fix? If you send a signed-off version, I'll apply it asap. Thanks, Linus

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Bhardwaj, Rajneesh
On 1/22/2024 7:34 PM, Steven Rostedt wrote: On Mon, 22 Jan 2024 19:29:41 -0500 "Bhardwaj, Rajneesh" wrote: In one of my previous revisions of this patch when I was experimenting, I used something like below. Wonder if that could work in your case and/or in general. diff --git

[PATCH 15/82] dma-buf: Refactor intentional wrap-around calculation

2024-01-22 Thread Kees Cook
In an effort to separate intentional arithmetic wrap-around from unexpected wrap-around, we need to refactor places that depend on this kind of math. One of the most common code patterns of this is: VAR + value < VAR Notably, this is considered "undefined behavior" for signed and pointer

[PATCH 36/82] agp: Refactor intentional wrap-around test

2024-01-22 Thread Kees Cook
In an effort to separate intentional arithmetic wrap-around from unexpected wrap-around, we need to refactor places that depend on this kind of math. One of the most common code patterns of this is: VAR + value < VAR Notably, this is considered "undefined behavior" for signed and pointer

[PATCH 50/82] drm/vc4: Refactor intentional wrap-around test

2024-01-22 Thread Kees Cook
In an effort to separate intentional arithmetic wrap-around from unexpected wrap-around, we need to refactor places that depend on this kind of math. One of the most common code patterns of this is: VAR + value < VAR Notably, this is considered "undefined behavior" for signed and pointer

[PATCH 16/82] drm/nouveau/mmu: Refactor intentional wrap-around calculation

2024-01-22 Thread Kees Cook
In an effort to separate intentional arithmetic wrap-around from unexpected wrap-around, we need to refactor places that depend on this kind of math. One of the most common code patterns of this is: VAR + value < VAR Notably, this is considered "undefined behavior" for signed and pointer

[PATCH 49/82] drm/i915: Refactor intentional wrap-around test

2024-01-22 Thread Kees Cook
In an effort to separate intentional arithmetic wrap-around from unexpected wrap-around, we need to refactor places that depend on this kind of math. One of the most common code patterns of this is: VAR + value < VAR Notably, this is considered "undefined behavior" for signed and pointer

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Steven Rostedt
On Mon, 22 Jan 2024 19:29:41 -0500 "Bhardwaj, Rajneesh" wrote: > > In one of my previous revisions of this patch when I was experimenting, > I used something like below. Wonder if that could work in your case > and/or in general. > > > diff --git a/drivers/gpu/drm/ttm/ttm_device.c >

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Bhardwaj, Rajneesh
On 1/22/2024 6:06 PM, Steven Rostedt wrote: I just kicked off testing some patches on top of 6.8-rc1 and triggered this immediately: [ note this happened on both my 32 bit an 64 bit test machines, this is just the 32 bit output ] BUG: kernel NULL pointer dereference, address: 0238

[PATCH 48/82] drm/nouveau/mmu: Refactor intentional wrap-around test

2024-01-22 Thread Kees Cook
In an effort to separate intentional arithmetic wrap-around from unexpected wrap-around, we need to refactor places that depend on this kind of math. One of the most common code patterns of this is: VAR + value < VAR Notably, this is considered "undefined behavior" for signed and pointer

[PATCH 17/82] drm/vc4: Refactor intentional wrap-around calculation

2024-01-22 Thread Kees Cook
In an effort to separate intentional arithmetic wrap-around from unexpected wrap-around, we need to refactor places that depend on this kind of math. One of the most common code patterns of this is: VAR + value < VAR Notably, this is considered "undefined behavior" for signed and pointer

Re: [PATCH v6 7/7] x86/vmware: Add TDX hypercall support

2024-01-22 Thread H. Peter Anvin
On January 22, 2024 4:04:33 PM PST, Alexey Makhalov wrote: > > >On 1/22/24 10:28 AM, H. Peter Anvin wrote: >> On January 22, 2024 8:32:22 AM PST, Dave Hansen >> wrote: >>> On 1/9/24 00:40, Alexey Makhalov wrote: +#ifdef CONFIG_INTEL_TDX_GUEST +unsigned long

Re: [PATCH v6 7/7] x86/vmware: Add TDX hypercall support

2024-01-22 Thread Alexey Makhalov
On 1/22/24 10:28 AM, H. Peter Anvin wrote: On January 22, 2024 8:32:22 AM PST, Dave Hansen wrote: On 1/9/24 00:40, Alexey Makhalov wrote: +#ifdef CONFIG_INTEL_TDX_GUEST +unsigned long vmware_tdx_hypercall(unsigned long cmd, + struct tdx_module_args *args)

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Steven Rostedt
On Mon, 22 Jan 2024 18:15:47 -0500 Steven Rostedt wrote: > > ttm_pool_init(>pool, dev, dev_to_node(dev), use_dma_alloc, > > use_dma32); <<<--- BUG! > > > > Specifically, it appears that dev is NULL and dev_to_node() doesn't like > > having a NULL pointer passed to it. > > > > Yeah,

Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Steven Rostedt
On Mon, 22 Jan 2024 18:06:05 -0500 Steven Rostedt wrote: > qxl_ttm_init+0x34/0x130 > > int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs > *funcs, > struct device *dev, struct address_space *mapping, > struct

[BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

2024-01-22 Thread Steven Rostedt
I just kicked off testing some patches on top of 6.8-rc1 and triggered this immediately: [ note this happened on both my 32 bit an 64 bit test machines, this is just the 32 bit output ] BUG: kernel NULL pointer dereference, address: 0238 #PF: supervisor read access in kernel mode #PF:

Re: [PATCH][next] drm/nouveau/fifo/gk104: remove redundant variable ret

2024-01-22 Thread Danilo Krummrich
On 1/16/24 13:31, Dan Carpenter wrote: On Tue, Jan 16, 2024 at 11:16:09AM +, Colin Ian King wrote: The variable ret is being assigned a value but it isn't being read afterwards. The assignment is redundant and so ret can be removed. Cleans up clang scan build warning: warning: Although the

Re: QAIC reset failure

2024-01-22 Thread Jeffrey Hugo
On 1/16/2024 9:58 AM, Baruch Siach wrote: Hi qaic driver maintainers, Sorry I was holiday last week and I am just now catching up on email and seeing this. I am testing an A100 device on arm64 platform. Kernel version is current Linus master as of commit 052d534373b7. The driver is unable

Re: BUG [RESEND]: kernel NULL pointer dereference, address: 0000000000000008

2024-01-22 Thread Mirsad Todorovac
On 22. 01. 2024. 09:34, Ma, Jun wrote: > Perhaps similar to the problem I encountered earlier, you can > try the following patch > > https://lists.freedesktop.org/archives/amd-gfx/2024-January/103259.html Appaarently, this patch prevented NULL dereference, it was no longer in the log. However,

Re: [BUG][BISECTED] Freeze at loading init ramdisk

2024-01-22 Thread Mirsad Todorovac
On 1/22/24 11:20, Uwe Kleine-König wrote: On Thu, Jan 18, 2024 at 09:04:05PM +0100, Mirsad Todorovac wrote: On 1/18/24 08:45, Uwe Kleine-König wrote: Hello Mirsad, On Wed, Jan 17, 2024 at 07:47:49PM +0100, Mirsad Todorovac wrote: On 1/16/24 01:32, Mirsad Todorovac wrote: On the Ubuntu

Re: [PATCH] fbcon: Fix incorrect printed function name in fbcon_prepare_logo()

2024-01-22 Thread Helge Deller
On 1/22/24 16:04, Geert Uytterhoeven wrote: If the boot logo does not fit, a message is printed, including a wrong function name prefix. Instead of correcting the function name (or using __func__), just use "fbcon", like is done in several other messages. While at it, modernize the call by

Re: [PATCH v4 2/3] Manually revert "drm/i915: Fix a VMA UAF for multi-gt platform"

2024-01-22 Thread Rodrigo Vivi
On Mon, Jan 22, 2024 at 03:04:43PM +0100, Janusz Krzysztofik wrote: > This reverts changes introduced by commit f56fe3e91787, obsoleted by > "drm/i915/vma: Fix UAF on destroy against retire race". I believe the good chunk of the first commit message should be moved here instead. But why did you

Re: [PATCH v3 08/14] drm/panthor: Add the FW logical block

2024-01-22 Thread Chris Diamand
On 22/01/2024 16:34, Boris Brezillon wrote: > On Mon, 18 Dec 2023 21:25:16 + > Chris Diamand wrote: > >>> +void panthor_fw_unplug(struct panthor_device *ptdev) >>> +{ >>> + struct panthor_fw_section *section; >>> + >>> + cancel_delayed_work_sync(>fw->watchdog.ping_work); >>> + >>> + /*

Re: [PATCH v4 1/3] drm/i915/vma: Fix UAF on destroy against retire race

2024-01-22 Thread Rodrigo Vivi
On Mon, Jan 22, 2024 at 03:04:42PM +0100, Janusz Krzysztofik wrote: > Object debugging tools were sporadically reporting illegal attempts to > free a still active i915 VMA object when parking a GPU tile believed to be > idle. > > [161.359441] ODEBUG: free active (active state 0) object:

Re: [PATCH] drm: apple: use strscpy() in place of strlcpy()

2024-01-22 Thread Janne Grunau
Hej, On Mon, Jan 22, 2024, at 17:11, Arnd Bergmann wrote: > From: Arnd Bergmann > > Since commit d26270061ae6 ("string: Remove strlcpy()"), the strlcpy() > function causes a build failure. > > Since the return value is ignored, changing it to the strscpy() > causes no change in behavior but

Re: [PATCH] drm: apple: mark local functions static

2024-01-22 Thread Janne Grunau
Hej, On Wed, Jan 17, 2024, at 11:44, Arnd Bergmann wrote: > From: Arnd Bergmann > > With linux-6.8, the kernel warns about functions that have no > extern declaration, so mark both of these static. > > Fixes: 2d782b0d007d ("gpu: drm: apple: Add sound mode parsing") > Signed-off-by: Arnd Bergmann

[PATCH] dt-bindings: display: nxp, tda998x: Fix 'audio-ports' constraints

2024-01-22 Thread Rob Herring
The constraints for 'audio-ports' don't match the description. There can be 1 or 2 DAI entries and each entry is exactly 2 values. Also, the values' sizes are 32-bits, not 8-bits. Move the size constraints to the outer dimension (number of DAIs) and add constraints on inner array values.

[PATCH 2/2] scripts/kernel-doc: Do not process backslash lines in comments

2024-01-22 Thread Anna-Maria Behnsen
Commit 654784284430 ("kernel-doc: bugfix - multi-line macros") introduces pre-processing of backslashes at the end of a line to not break multi-line macros. This pre-processing is done independently if it is inside code or inside a comment. This illustation of a hierarchy as a code block inside a

[PATCH 0/2] kernel-doc: Do not pre-process comments

2024-01-22 Thread Anna-Maria Behnsen
Hi, this is a repost of the RFC queue https://lkml.kernel.org/r/20240116151456.48238-1-anna-ma...@linutronix.de Jonathan Corbet is fine with this change and mentioned in an answer the following: "The kernel-doc change should really go together with the DRM change. I'm happy to carry both

[PATCH 1/2] drm/vram-helper: Fix 'multi-line' kernel-doc comments

2024-01-22 Thread Anna-Maria Behnsen
Reformat lines in kernel-doc comments, which make use of the backslash at the end to suggest it is a multi-line comment. kernel-doc is able to process e.g. the short description of a function properly, even if it is across two lines. No functional change. Signed-off-by: Anna-Maria Behnsen

Re: [PATCH v2 00/47] tty: vt: cleanup and documentation

2024-01-22 Thread Helge Deller
On 1/22/24 12:03, Jiri Slaby (SUSE) wrote: Push the console code (vt.c, vt.h, console.h, ...) into a bit more maintainable state. Especially all around consw structure and document it. CSI parser is also a bit cleaned up. More to follow some time in the next round. I've not yet looked through

[PATCH v4 1/3] leds: ktd2692: move ExpressWire code to library

2024-01-22 Thread Duje Mihanović
The ExpressWire protocol is shared between at least KTD2692 and KTD2801 with slight differences such as timings and the former not having a defined set of pulses for enabling the protocol (possibly because it does not support PWM unlike KTD2801). Despite these differences the ExpressWire handling

[PATCH v4 2/3] dt-bindings: backlight: add Kinetic KTD2801 binding

2024-01-22 Thread Duje Mihanović
KTD2801 is a LED backlight driver IC found in samsung,coreprimevelte. The brightness can be set using PWM or the ExpressWire protocol. Add a DT binding for the KTD2801. Reviewed-by: Krzysztof Kozlowski Reviewed-by: Linus Walleij Signed-off-by: Duje Mihanović ---

[PATCH v4 3/3] backlight: Add Kinetic KTD2801 backlight support

2024-01-22 Thread Duje Mihanović
KTD2801 is a LED backlight driver IC found in samsung,coreprimevelte. The brightness can be set using PWM or the ExpressWire protocol. Add support for the KTD2801. Reviewed-by: Linus Walleij Signed-off-by: Duje Mihanović --- MAINTAINERS | 6 ++

[PATCH v4 0/3] Kinetic ExpressWire library and KTD2801 backlight driver

2024-01-22 Thread Duje Mihanović
Hello, This series adds support for the Kinetic KTD2801 LED backlight driver IC found in samsung,coreprimevelte. Support is already upstream for the somewhat similar KTD2692 flash driver, and this series since v3 also moves its ExpressWire code into a separate library and converts the KTD2692

Re: [PATCH v2 00/33] spi: get rid of some legacy macros

2024-01-22 Thread Jonathan Cameron
On Mon, 22 Jan 2024 18:18:22 + Mark Brown wrote: > On Mon, Jan 22, 2024 at 07:06:55PM +0100, Uwe Kleine-König wrote: > > > Note that Jonathan Cameron has already applied patch 3 to his tree, it > > didn't appear in a public tree though yet. I still included it here to > > make the kernel

Re: [PATCH 0/2] drm/vmwgfx backport two fixes to v6.1.x branch

2024-01-22 Thread Greg KH
On Mon, Jan 22, 2024 at 06:10:11PM +0100, Jocelyn Falempe wrote: > Hi, > > I've backported this two commits: > f9e96bf19054 drm/vmwgfx: Fix possible invalid drm gem put calls > 91398b413d03 drm/vmwgfx: Keep a gem reference to user bos in surfaces > > They both fixes a950b989ea29 ("drm/vmwgfx: Do

Re: [PATCH v6 7/7] x86/vmware: Add TDX hypercall support

2024-01-22 Thread H. Peter Anvin
On January 22, 2024 8:32:22 AM PST, Dave Hansen wrote: >On 1/9/24 00:40, Alexey Makhalov wrote: >> +#ifdef CONFIG_INTEL_TDX_GUEST >> +unsigned long vmware_tdx_hypercall(unsigned long cmd, >> + struct tdx_module_args *args) >> +{ >> +if

Re: [PATCH v2 00/33] spi: get rid of some legacy macros

2024-01-22 Thread Mark Brown
On Mon, Jan 22, 2024 at 07:06:55PM +0100, Uwe Kleine-König wrote: > Note that Jonathan Cameron has already applied patch 3 to his tree, it > didn't appear in a public tree though yet. I still included it here to > make the kernel build bots happy. It's also going to be needed for buildability of

Re: [PATCH v3 1/2] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-22 Thread Rafael J. Wysocki
On Mon, Jan 22, 2024 at 7:12 PM Bjorn Helgaas wrote: > > On Mon, Jan 22, 2024 at 01:41:21PM +0200, Sakari Ailus wrote: > > There are two ways to opportunistically increment a device's runtime PM > > usage count, calling either pm_runtime_get_if_active() or > > pm_runtime_get_if_in_use(). The

Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

2024-01-22 Thread Duje Mihanović
On Monday, January 22, 2024 6:50:31 PM CET Daniel Thompson wrote: > On Mon, Jan 22, 2024 at 06:26:04PM +0100, Duje Mihanović wrote: > > On Monday, January 22, 2024 5:57:53 PM CET Duje Mihanović wrote: > > > On Monday, January 22, 2024 5:50:11 PM CET Daniel Thompson wrote: > > > > AFAICT nothing

Re: [PATCH v3 1/2] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-22 Thread Bjorn Helgaas
On Mon, Jan 22, 2024 at 01:41:21PM +0200, Sakari Ailus wrote: > There are two ways to opportunistically increment a device's runtime PM > usage count, calling either pm_runtime_get_if_active() or > pm_runtime_get_if_in_use(). The former has an argument to tell whether to > ignore the usage count

[PATCH v2 00/33] spi: get rid of some legacy macros

2024-01-22 Thread Uwe Kleine-König
Hello, this is v2 of this patch set. Changes since (implicit) v1, sent with Message-Id: cover.1705348269.git.u.kleine-koe...@pengutronix.de: - Rebase to v6.8-rc1 - Fix a build failure on sh - Added the tags received in (implicit) v1. The slave-mt27xx driver needs some more work. The patch

[PATCH v2 25/33] staging: fbtft: Follow renaming of SPI "master" to "controller"

2024-01-22 Thread Uwe Kleine-König
In commit 8caab75fd2c2 ("spi: Generalize SPI "master" to "controller"") some functions and struct members were renamed. To not break all drivers compatibility macros were provided. To be able to remove these compatibility macros push the renaming into this driver. Signed-off-by: Uwe Kleine-König

[PATCH v2 29/33] video: fbdev: mmp: Follow renaming of SPI "master" to "controller"

2024-01-22 Thread Uwe Kleine-König
In commit 8caab75fd2c2 ("spi: Generalize SPI "master" to "controller"") some functions and struct members were renamed. To not break all drivers compatibility macros were provided. To be able to remove these compatibility macros push the renaming into this driver. Signed-off-by: Uwe Kleine-König

Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

2024-01-22 Thread Daniel Thompson
On Mon, Jan 22, 2024 at 06:26:04PM +0100, Duje Mihanović wrote: > On Monday, January 22, 2024 5:57:53 PM CET Duje Mihanović wrote: > > On Monday, January 22, 2024 5:50:11 PM CET Daniel Thompson wrote: > > > AFAICT nothing will inhibit setting GPIOLIB so allyes- and allmodconfig > > > builds will

Re: [PATCH 13/14] drm/msm/dp: move next_bridge handling to dp_display

2024-01-22 Thread Kuogee Hsieh
On 1/19/2024 6:31 PM, Dmitry Baryshkov wrote: On Fri, 19 Jan 2024 at 23:14, Kuogee Hsieh wrote: Dmitry, I am testing this patch serial with msm-next branch. This patch cause system crash during booting up for me. Is this patch work for you? Yes, tested on top of linux-next. However I

Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

2024-01-22 Thread Duje Mihanović
On Monday, January 22, 2024 5:57:53 PM CET Duje Mihanović wrote: > On Monday, January 22, 2024 5:50:11 PM CET Daniel Thompson wrote: > > AFAICT nothing will inhibit setting GPIOLIB so allyes- and allmodconfig > > builds will always end up with GPIOLIB enabled. If we are happy to > > select it then

Re: linux-next: build warning after merge of the drm-intel tree

2024-01-22 Thread Jani Nikula
On Mon, 22 Jan 2024, Stephen Rothwell wrote: >> [1] >> https://patchwork.freedesktop.org/patch/msgid/20231114081033.27343-1-bagasdo...@gmail.com > > This is still not fixed. Thanks for the reminder. Commit 1a84c213146a ("drm/dp_mst: Separate @failing_port list in drm_dp_mst_atomic_check_mgr()

[PATCH 2/2] drm/vmwgfx: Keep a gem reference to user bos in surfaces

2024-01-22 Thread Jocelyn Falempe
From: Zack Rusin commit 91398b413d03660fd5828f7b4abc64e884b98069 upstream Surfaces can be backed (i.e. stored in) memory objects (mob's) which are created and managed by the userspace as GEM buffers. Surfaces grab only a ttm reference which means that the gem object can be deleted underneath

[PATCH 1/2] drm/vmwgfx: Fix possible invalid drm gem put calls

2024-01-22 Thread Jocelyn Falempe
From: Zack Rusin commit f9e96bf1905479f18e83a3a4c314a8dfa56ede2c upstream vmw_bo_unreference sets the input buffer to null on exit, resulting in null ptr deref's on the subsequent drm gem put calls. This went unnoticed because only very old userspace would be exercising those paths but it

[PATCH 0/2] drm/vmwgfx backport two fixes to v6.1.x branch

2024-01-22 Thread Jocelyn Falempe
Hi, I've backported this two commits: f9e96bf19054 drm/vmwgfx: Fix possible invalid drm gem put calls 91398b413d03 drm/vmwgfx: Keep a gem reference to user bos in surfaces They both fixes a950b989ea29 ("drm/vmwgfx: Do not drop the reference to the handle too soon") which has been backported to

Re: [PATCH] drm/dp_mst: Separate @failing_port list in drm_dp_mst_atomic_check_mgr() comment

2024-01-22 Thread Jani Nikula
On Tue, 14 Nov 2023, Bagas Sanjaya wrote: > Stephen Rothwell reported htmldocs warnings when merging drm-intel > tree: > > Documentation/gpu/drm-kms-helpers:296: > drivers/gpu/drm/display/drm_dp_mst_topology.c:5484: ERROR: Unexpected > indentation. > Documentation/gpu/drm-kms-helpers:296: >

Re: [PATCH] drm/bridge: anx7625: Ensure bridge is suspended in disable()

2024-01-22 Thread Doug Anderson
Hi, On Thu, Jan 18, 2024 at 9:30 AM Doug Anderson wrote: > > Hi, > > On Wed, Jan 17, 2024 at 5:59 PM Hsin-Yi Wang wrote: > > > > Similar to commit 26db46bc9c67 ("drm/bridge: parade-ps8640: Ensure bridge > > is suspended in .post_disable()"). Add a mutex to ensure that aux transfer > > won't

Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

2024-01-22 Thread Duje Mihanović
On Monday, January 22, 2024 5:50:11 PM CET Daniel Thompson wrote: > On Mon, Jan 22, 2024 at 05:24:51PM +0100, Duje Mihanović wrote: > > I believe a "select" would be more appropriate here unless these backlights > > should be hidden if GPIOLIB is disabled. The catch with "select" is that > >

Re: [PATCH AUTOSEL 6.1 04/53] drm: Fix color LUT rounding

2024-01-22 Thread Ville Syrjälä
On Mon, Jan 22, 2024 at 10:08:05AM -0500, Sasha Levin wrote: > From: Ville Syrjälä > > [ Upstream commit c6fbb6bca10838485b820e8a26c23996f77ce580 ] Why is this being backported? > > The current implementation of drm_color_lut_extract() > generates weird results. Eg. if we go through all the >

Re: [PATCH] accel/habanalabs: use kcalloc() instead of kzalloc()

2024-01-22 Thread Gustavo A. R. Silva
On 1/20/24 09:10, Erick Archer wrote: As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them

Re: [PATCH v3 3/3] backlight: Add Kinetic KTD2801 backlight support

2024-01-22 Thread Daniel Thompson
On Mon, Jan 22, 2024 at 05:24:56PM +0100, Duje Mihanović wrote: > On Monday, January 22, 2024 11:28:05 AM CET Daniel Thompson wrote: > > On Sat, Jan 20, 2024 at 10:26:45PM +0100, Duje Mihanović wrote: > > > diff --git a/drivers/video/backlight/ktd2801-backlight.c > > >

Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

2024-01-22 Thread Daniel Thompson
On Mon, Jan 22, 2024 at 05:24:51PM +0100, Duje Mihanović wrote: > On Monday, January 22, 2024 11:19:26 AM CET Daniel Thompson wrote: > > On Sat, Jan 20, 2024 at 10:26:43PM +0100, Duje Mihanović wrote: > > > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > > > index

[PATCH v16 4/5] MAINTAINERS: Update entries for Renesas DRM drivers

2024-01-22 Thread Biju Das
The rcar-du has never been maintained in drm-misc. So exclude only this driver from drm-misc. Also, add the tree entry for sh_mobile. Signed-off-by: Biju Das Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven # shmob_drm --- v15->v16: * Added Rb and Ack tag from Geert. v15: * New

[PATCH v16 5/5] MAINTAINERS: Create entry for Renesas RZ DRM drivers

2024-01-22 Thread Biju Das
Create entry for Renesas RZ DRM drivers and add my self as a maintainer. Signed-off-by: Biju Das Reviewed-by: Laurent Pinchart --- v15->v16: * No change v14->v15: * Added drm-misc tree entry. * Sorted the entry(Placed before SHMOBILE) v13->v14: * Now SHMOBILE has maintainer entries. So

[PATCH v16 3/5] drm: renesas: Add RZ/G2L DU Support

2024-01-22 Thread Biju Das
The LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). It has DPI/DSI interfaces and supports a maximum resolution of 1080p along with 2 RPFs to support the blending of two picture layers and raster operations (ROPs). The DU

[PATCH v16 0/5] Add RZ/{G2L,G2LC} and RZ/V2L Display Unit support

2024-01-22 Thread Biju Das
This path series aims to add support for RZ/G2L DU DRM driver. RZ/G2L LCD controller composed of Frame compression Processor(FCPVD), Video signal processor (VSPD) and Display unit(DU). The output of LCDC is connected to Display parallel interface and MIPI link video interface. The output from

[PATCH v16 2/5] dt-bindings: display: renesas, rzg2l-du: Document RZ/V2L DU bindings

2024-01-22 Thread Biju Das
Document DU found in RZ/V2L SoC. The DU block is identical to RZ/G2L SoC and therefore use RZ/G2L fallback to avoid any driver changes. Signed-off-by: Biju Das Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven --- v15->v16: * No change. v14->v15: * No

[PATCH v16 1/5] dt-bindings: display: Document Renesas RZ/G2L DU bindings

2024-01-22 Thread Biju Das
The RZ/G2L LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). The DU module supports the following hardware features − Display Parallel Interface (DPI) and MIPI LINK Video Interface − Display timing master − Generates video

Re: [PATCH 1/3] dt-bindings: display: bridge: add sam9x7-lvds compatible

2024-01-22 Thread Conor Dooley
On Mon, Jan 22, 2024 at 04:51:16PM +0100, Krzysztof Kozlowski wrote: > On 22/01/2024 09:29, Dharma Balasubiramani wrote: > > Add the 'sam9x7-lvds' compatible binding, which describes the > > Low Voltage Differential Signaling (LVDS) Controller found on Microchip's > > sam9x7 series System-on-Chip

Re: [PATCH v3 13/14] dt-bindings: gpu: mali-valhall-csf: Add support for Arm Mali CSF GPUs

2024-01-22 Thread Boris Brezillon
Hi Rob, We didn't hear back from you, so I assumed you were happy with Liviu's explanations and sent a v4 with just the s/space/tab/ formatting fix. Please let us know if you have any concerns with v4 binding docs. Thanks, Boris On Wed, 6 Dec 2023 10:59:38 + Liviu Dudau wrote: > Hi Rob,

Re: [PATCH v3 08/14] drm/panthor: Add the FW logical block

2024-01-22 Thread Boris Brezillon
On Mon, 18 Dec 2023 21:25:16 + Chris Diamand wrote: > > +void panthor_fw_unplug(struct panthor_device *ptdev) > > +{ > > + struct panthor_fw_section *section; > > + > > + cancel_delayed_work_sync(>fw->watchdog.ping_work); > > + > > + /* Make sure the IRQ handler can be called after

[PATCH 3/5] drm/bridge: simple-bridge: Allow acquiring the next bridge with fwnode API

2024-01-22 Thread Sui Jingfeng
Which make it possible to use this driver on non-DT based systems, meanwhile, made no functional changes for DT based systems. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/bridge/simple-bridge.c | 51 ++ 1 file changed, 44 insertions(+), 7 deletions(-) diff --git

[PATCH 2/5] drm/bridge: simple-bridge: Extend match support for non-DT based systems

2024-01-22 Thread Sui Jingfeng
Which is intended to be used on non-DT environment, where the simple-bridge platform device is created by either the display controller driver side or platform firmware subsystem. To avoid duplication and to keep consistent, we choose to reuse the OF match tables. Because the potentional user may

[PATCH 1/5] drm/bridge: Add drm_bridge_find_by_fwnode() helper

2024-01-22 Thread Sui Jingfeng
Because ACPI based systems only has the fwnode associated, the of_node member of struct device is NULL. To order to move things forward, we add drm_bridge_find_by_fwnode() to extend the support. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/drm_bridge.c | 33 +

  1   2   3   4   >