Re: [PATCH 1/3] bits: introduce fixed-type genmasks

2024-01-23 Thread Jani Nikula
On Tue, 23 Jan 2024, Lucas De Marchi wrote: > From: Yury Norov > > Generalize __GENMASK() to support different types, and implement > fixed-types versions of GENMASK() based on it. The fixed-type version > allows more strict checks to the min/max values accepted, which is > useful for defining

Re: [PATCH] mm: Remove double faults once write a device pfn

2024-01-23 Thread Christian König
Am 24.01.24 um 03:43 schrieb Zhou, Xianrong: [AMD Official Use Only - General] The vmf_insert_pfn_prot could cause unnecessary double faults on a device pfn. Because currently the vmf_insert_pfn_prot does not make the pfn writable so the pte entry is normally read-only or dirty catching.

Re: Making drm_gpuvm work across gpu devices

2024-01-23 Thread Christian König
Am 24.01.24 um 05:14 schrieb Zeng, Oak: Danilo, Maybe before I give up, I should also ask, currently drm_gpuvm is designed for BO-centric world. Is it easy to make the va range split/merge work simply for va range, but without BO? Conceptually this should work as we are merge/splitting

Re: [PATCH v3 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format

2024-01-23 Thread Dharma.B
Hi Conor & All, On 22/01/24 2:46 pm, Conor Dooley wrote: > On Mon, Jan 22, 2024 at 03:38:41AM +,dharm...@microchip.com wrote: >> Hi Conor, >> On 19/01/24 5:33 pm, Conor Dooley - M52691 wrote: >>> On Fri, Jan 19, 2024 at 03:32:49AM +,dharm...@microchip.com wrote: On 18/01/24 9:10

[PATCH 3/3] drm/i915: Convert REG_GENMASK* to fixed-width GENMASK_*

2024-01-23 Thread Lucas De Marchi
Now that include/linux/bits.h implements fixed-width GENMASK_*, use them to implement the i915/xe specific macros. Converting each driver to use the generic macros are left for later, when/if other driver-specific macros are also generalized. Signed-off-by: Lucas De Marchi ---

[PATCH 0/3] Fixed-type GENMASK/BIT

2024-01-23 Thread Lucas De Marchi
Move the implementation of REG_GENMASK/REG_BIT to a more appropriate place to be shared by i915, xe and possibly other parts of the kernel. For now this re-defines the old macros. In future we may start using the new macros directly, but that's a more intrusive search-and-replace. Yury, I added

[PATCH 1/3] bits: introduce fixed-type genmasks

2024-01-23 Thread Lucas De Marchi
From: Yury Norov Generalize __GENMASK() to support different types, and implement fixed-types versions of GENMASK() based on it. The fixed-type version allows more strict checks to the min/max values accepted, which is useful for defining registers like implemented by i915 and xe drivers with

[PATCH 2/3] bits: Introduce fixed-type BIT

2024-01-23 Thread Lucas De Marchi
Implement fixed-type BIT() to help drivers add stricter checks, like was done for GENMASK. Signed-off-by: Lucas De Marchi --- include/linux/bits.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/bits.h b/include/linux/bits.h index cb94128171b2..5754a1251078 100644 ---

RE: Making drm_gpuvm work across gpu devices

2024-01-23 Thread Zeng, Oak
Danilo, Maybe before I give up, I should also ask, currently drm_gpuvm is designed for BO-centric world. Is it easy to make the va range split/merge work simply for va range, but without BO? Conceptually this should work as we are merge/splitting virtual address range which can be decoupled

Re: Re: [PATCH] drm/xe: Remove PVC from xe_wa kunit tests

2024-01-23 Thread Lucas De Marchi
On Tue, Jan 23, 2024 at 07:55:38PM -0800, Matt Roper wrote: On Mon, Jan 22, 2024 at 07:12:42PM -0800, Lucas De Marchi wrote: Since the PCI IDs for PVC were added to the xe driver, the xe_wa tests This first line doesn't seem to be worded right. I think you meant either "weren't added" or

RE: Making drm_gpuvm work across gpu devices

2024-01-23 Thread Zeng, Oak
Thanks a lot Danilo. Maybe I wasn't clear enough. In the solution I proposed, each device still have separate vm/page tables. Each device still need to manage the mapping, page table flags etc. It is just in svm use case, all devices share one drm_gpuvm instance. As I understand it,

Re: [PATCH] drm/xe: Remove PVC from xe_wa kunit tests

2024-01-23 Thread Matt Roper
On Mon, Jan 22, 2024 at 07:12:42PM -0800, Lucas De Marchi wrote: > Since the PCI IDs for PVC were added to the xe driver, the xe_wa tests This first line doesn't seem to be worded right. I think you meant either "weren't added" or "were only added to topic/xe-for-CI." Assuming you can reword

[linux-next:master] BUILD REGRESSION 774551425799cb5bbac94e1768fd69eec4f78dd4

2024-01-23 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 774551425799cb5bbac94e1768fd69eec4f78dd4 Add linux-next specific files for 20240123 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202401231518.8q9ld8n7-...@intel.com https

[PATCH v2 8/8] drm/lima: standardize debug messages by ip name

2024-01-23 Thread Erico Nunes
Some debug messages carried the ip name, or included "lima", or included both the ip name and then the numbered ip name again. Make the messages more consistent by always looking up and showing the ip name first. Signed-off-by: Erico Nunes --- drivers/gpu/drm/lima/lima_gp.c | 20

[PATCH v2 5/8] drm/lima: handle spurious timeouts due to high irq latency

2024-01-23 Thread Erico Nunes
There are several unexplained and unreproduced cases of rendering timeouts with lima, for which one theory is high IRQ latency coming from somewhere else in the system. This kind of occurrence may cause applications to trigger unnecessary resets of the GPU or even applications to hang if it hits

[PATCH v2 7/8] drm/lima: increase default job timeout to 10s

2024-01-23 Thread Erico Nunes
The previous 500ms default timeout was fairly optimistic and could be hit by real world applications. Many distributions targeting devices with a Mali-4xx already bumped this timeout to a higher limit. We can be generous here with a high value as 10s since this should mostly catch buggy jobs like

[PATCH v2 4/8] drm/lima: set gp bus_stop bit before hard reset

2024-01-23 Thread Erico Nunes
This is required for reliable hard resets. Otherwise, doing a hard reset while a task is still running (such as a task which is being stopped by the drm_sched timeout handler) may result in random mmu write timeouts or lockups which cause the entire gpu to hang. Signed-off-by: Erico Nunes ---

[PATCH v2 2/8] drm/lima: reset async_reset on gp hard reset

2024-01-23 Thread Erico Nunes
Lima gp jobs use an async reset to avoid having to wait for the soft reset right after a job. The soft reset is done at the end of a job and a reset_complete flag is expected to be set at the next job. However, in case the user runs into a job timeout from any application, a hard reset is issued

[PATCH v2 6/8] drm/lima: remove guilty drm_sched context handling

2024-01-23 Thread Erico Nunes
Marking the context as guilty currently only makes the application which hits a single timeout problem to stop its rendering context entirely. All jobs submitted later are dropped from the guilty context. Lima runs on fairly underpowered hardware for modern standards and it is not entirely

[PATCH v2 3/8] drm/lima: set pp bus_stop bit before hard reset

2024-01-23 Thread Erico Nunes
This is required for reliable hard resets. Otherwise, doing a hard reset while a task is still running (such as a task which is being stopped by the drm_sched timeout handler) may result in random mmu write timeouts or lockups which cause the entire gpu to hang. Signed-off-by: Erico Nunes

[PATCH v2 0/8] drm/lima: fixes and improvements to error recovery

2024-01-23 Thread Erico Nunes
v1 reference: https://patchwork.kernel.org/project/dri-devel/cover/20240117031212.1104034-1-nunes.er...@gmail.com/ Changes v1 -> v2: - Dropped patch 1 which aimed to fix https://gitlab.freedesktop.org/mesa/mesa/-/issues/8415 . That will require more testing and an actual fix to the irq/timeout

[PATCH v2 1/8] drm/lima: reset async_reset on pp hard reset

2024-01-23 Thread Erico Nunes
Lima pp jobs use an async reset to avoid having to wait for the soft reset right after a job. The soft reset is done at the end of a job and a reset_complete flag is expected to be set at the next job. However, in case the user runs into a job timeout from any application, a hard reset is issued

Re: [PATCH] drm/Makefile: Move tiny drivers before native drivers

2024-01-23 Thread Huacai Chen
Hi, Javier and Thomas, On Wed, Jan 24, 2024 at 5:21 AM Jaak Ristioja wrote: > > Hi, > > I apologize for not finding the time to test this earlier. > > On 11.12.23 05:08, Huacai Chen wrote: > > And Jaak, could you please test with the below patch (but keep the > > original order in Makefile) and

[PATCH v3 5/5] drm: xlnx: zynqmp_dpsub: Set live video in format

2024-01-23 Thread Anatoliy Klymenko
ZynqMP DPSUB supports 2 modes of operations in regard to video data input. In the first mode, DPSUB uses DMA engine to pull video data from memory buffers. To support this the driver implements CRTC and DRM bridge representing DP encoder. In the second mode, DPSUB acquires video data pushed from

[PATCH v3 3/5] drm: xlnx: zynqmp_dpsub: Clear status register ASAP

2024-01-23 Thread Anatoliy Klymenko
Clear status register as soon as we read it. Addressing comments from https://lore.kernel.org/dri-devel/beb551c7-bb7e-4cd0-b166-e9aad90c4...@ideasonboard.com/ Signed-off-by: Anatoliy Klymenko --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v3 2/5] drm: xlnx: zynqmp_dpsub: Fix timing for live mode

2024-01-23 Thread Anatoliy Klymenko
Expect external video timing in live video input mode, program DPSUB acordingly. Reviewed-by: Tomi Valkeinen Signed-off-by: Anatoliy Klymenko --- drivers/gpu/drm/xlnx/zynqmp_disp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c

[PATCH v3 0/5] Fixing live video input in ZynqMP DPSUB

2024-01-23 Thread Anatoliy Klymenko
Add few missing pieces to support ZynqMP DPSUB live video in mode. ZynqMP DPSUB supports 2 modes of operations in regard to video data input. In the first mode, DPSUB uses DMA engine to pull video data from memory buffers. To support this the driver implements CRTC and DRM bridge

[PATCH v3 1/5] drm: xlnx: zynqmp_dpsub: Make drm bridge discoverable

2024-01-23 Thread Anatoliy Klymenko
ZynqMP DPSUB supports 2 input modes: DMA based and live video. In the first mode, the driver implements CRTC and DP encoder DRM bridge to model the complete display pipeline. In this case, DRM bridge is being directly instantiated within the driver, not using any bridge discovery mechanisms. In

[PATCH v3 4/5] drm: xlnx: zynqmp_dpsub: Filter interrupts against mask

2024-01-23 Thread Anatoliy Klymenko
Filter out status register against the interrupts' mask. Some events are being reported via DP status register, even if corresponding interrupts have been disabled. One instance of such event leads to generation of VBLANK when the driver is in DRM bridge mode, which in turn results in NULL

RE: [PATCH] mm: Remove double faults once write a device pfn

2024-01-23 Thread Zhou, Xianrong
[AMD Official Use Only - General] > >>> The vmf_insert_pfn_prot could cause unnecessary double faults on a > >>> device pfn. Because currently the vmf_insert_pfn_prot does not make > >>> the pfn writable so the pte entry is normally read-only or dirty > >>> catching. > >> What? How do you got to

Re: [PATCH RFC 1/4] drm/panel: add driver for simulated panel

2024-01-23 Thread Dmitry Baryshkov
On Wed, 17 Jan 2024 at 00:31, Jessica Zhang wrote: > > Add a driver for simulating panels. This module also supports a mode > parameter for users to specify a custom mode. If no custom mode is set, > it will fall back to a custom, hard-coded mode. > > Signed-off-by: Jessica Zhang > --- >

[PATCH v4 3/3] dt-bindings: soc: mediatek: Change mediatek, gce-events to refernece

2024-01-23 Thread Jason-JH . Lin
Change mediatek,gce-events property to reference mediatek,gce-props.yaml instead of defining itself. Signed-off-by: Jason-JH.Lin Reviewed-by: Conor Dooley --- .../bindings/soc/mediatek/mediatek,ccorr.yaml| 12 .../bindings/soc/mediatek/mediatek,mutex.yaml| 11

[PATCH v4 2/3] dt-bindings: media: mediatek: mdp: Change mediatek, gce-events to reference

2024-01-23 Thread Jason-JH . Lin
Change mediatek,gce-events property to reference mediatek,gce-props.yaml instead of defining itself. Signed-off-by: Jason-JH.Lin Reviewed-by: Conor Dooley --- .../bindings/media/mediatek,mdp3-rdma.yaml | 11 +++ .../devicetree/bindings/media/mediatek,mdp3-rsz.yaml | 12

[PATCH v4 0/3] Add mediatek, gce-props.yaml for other bindings reference

2024-01-23 Thread Jason-JH . Lin
From: Jason-jh Lin The property "mediatek,gce-events" is used for GCE event ID corresponding to a hardware event signal sent by the hardware or a software driver. If the mailbox providers or consumers want to manipulate the value of the event ID, they need to know the specific event ID. Since

[PATCH v4 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml

2024-01-23 Thread Jason-JH . Lin
Add mediatek,gce-props.yaml for common GCE properties that is used for both mailbox providers and consumers. We place the common property "mediatek,gce-events" in this binding currently. The property "mediatek,gce-events" is used for GCE event ID corresponding to a hardware event signal sent by

Re: [PATCH v1 1/6] drm/lima: fix devfreq refcount imbalance for job timeouts

2024-01-23 Thread Qiang Yu
On Wed, Jan 24, 2024 at 7:19 AM Erico Nunes wrote: > > On Fri, Jan 19, 2024 at 2:50 AM Qiang Yu wrote: > > > > On Thu, Jan 18, 2024 at 7:14 PM Erico Nunes wrote: > > > > > > On Thu, Jan 18, 2024 at 2:36 AM Qiang Yu wrote: > > > > > > > > So this is caused by same job trigger both done and

Re: Making drm_gpuvm work across gpu devices

2024-01-23 Thread Danilo Krummrich
Hi Oak, On 1/23/24 20:37, Zeng, Oak wrote: Thanks Christian. I have some comment inline below. Danilo, can you also take a look and give your feedback? Thanks. I agree with everything Christian already wrote. Except for the KFD parts, which I'm simply not familiar with, I had exactly the

Re: [PATCH v1 1/6] drm/lima: fix devfreq refcount imbalance for job timeouts

2024-01-23 Thread Erico Nunes
On Fri, Jan 19, 2024 at 2:50 AM Qiang Yu wrote: > > On Thu, Jan 18, 2024 at 7:14 PM Erico Nunes wrote: > > > > On Thu, Jan 18, 2024 at 2:36 AM Qiang Yu wrote: > > > > > > So this is caused by same job trigger both done and timeout handling? > > > I think a better way to solve this is to make

Re: [PATCH v4 1/3] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-23 Thread Sakari Ailus
On Tue, Jan 23, 2024 at 03:48:01PM -0600, Bjorn Helgaas wrote: > On Tue, Jan 23, 2024 at 08:44:04PM +, Sakari Ailus wrote: > > On Tue, Jan 23, 2024 at 11:24:23AM -0600, Bjorn Helgaas wrote: > > ... > > > > - I don't know whether it's feasible, but it would be nice if the > > >

Re: [PATCH v4 1/3] drm/i915/vma: Fix UAF on destroy against retire race

2024-01-23 Thread Rodrigo Vivi
On Tue, Jan 23, 2024 at 11:51:15AM +0100, Janusz Krzysztofik wrote: > Hi Rodrigo, > > Thank you for review. > > On Monday, 22 January 2024 22:09:38 CET Rodrigo Vivi wrote: > > On Mon, Jan 22, 2024 at 03:04:42PM +0100, Janusz Krzysztofik wrote: > > > Object debugging tools were sporadically

Re: [PATCH v3 4/5] drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c

2024-01-23 Thread Abhinav Kumar
On 12/25/2023 5:08 AM, Dmitry Baryshkov wrote: dpu_encoder_phys_wb is the only user of encoder's atomic_check callback. Move corresponding checks to drm_writeback_connector's implementation and drop the dpu_encoder_phys_wb_atomic_check() function. Signed-off-by: Dmitry Baryshkov ---

[PATCH 2/3] udmabuf: Sync buffer mappings for attached devices

2024-01-23 Thread Andrew Davis
Currently this driver creates a SGT table using the CPU as the target device, then performs the dma_sync operations against that SGT. This is backwards to how DMA-BUFs are supposed to behave. This may have worked for the case where these buffers were given only back to the same CPU that produced

[PATCH 3/3] udmabuf: Use module_misc_device() to register this device

2024-01-23 Thread Andrew Davis
Now that we do not need to call dma_coerce_mask_and_coherent() on our miscdevice device, use the module_misc_device() helper for registering and module init/exit. Signed-off-by: Andrew Davis --- drivers/dma-buf/udmabuf.c | 30 +- 1 file changed, 1 insertion(+), 29

[PATCH 1/3] udmabuf: Keep track current device mappings

2024-01-23 Thread Andrew Davis
When a device attaches to and maps our buffer we need to keep track of this mapping/device. This is needed for synchronization with these devices when beginning and ending CPU access for instance. Add a list that tracks device mappings as part of {map,unmap}_udmabuf(). Signed-off-by: Andrew Davis

Re: linux-next: Tree for Jan 23 (drm/xe/)

2024-01-23 Thread Randy Dunlap
On 1/22/24 18:29, Stephen Rothwell wrote: > Hi all, > > News: there will be no linux-next release on Friday > > Changes since 20240122: > on ARM64, when DRM_I915 is not set DRM_XE=m DEBUG_FS is not set ../drivers/gpu/drm/i915/display/intel_display_debugfs.c:1091:6: error: redefinition of

Re: [PATCH v4 1/3] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-23 Thread Bjorn Helgaas
On Tue, Jan 23, 2024 at 08:44:04PM +, Sakari Ailus wrote: > On Tue, Jan 23, 2024 at 11:24:23AM -0600, Bjorn Helgaas wrote: > ... > > - I don't know whether it's feasible, but it would be nice if the > > intel_pm_runtime_pm.c rework could be done in one shot instead of > > being split

Re: [PATCH] doc: admin-guide/kernel-parameters: remove useless comment

2024-01-23 Thread Jonathan Corbet
Vegard Nossum writes: > This comment about DRM drivers has been there since the first git > commit. It simply doesn't belong in kernel-parameters; remove it. > > Signed-off-by: Vegard Nossum > --- > Documentation/admin-guide/kernel-parameters.rst | 5 - > 1 file changed, 5 deletions(-) > >

Re: [PATCH] docs/accel: correct links to mailing list archives

2024-01-23 Thread Jonathan Corbet
Hu Haowen <2023002...@link.tyut.edu.cn> writes: > Since the mailing archive list lkml.org is obsolete, change the links into > lore.kernel.org's ones. > > Signed-off-by: Hu Haowen <2023002...@link.tyut.edu.cn> > --- > Documentation/accel/introduction.rst | 4 ++-- > 1 file changed, 2

Re: [PATCH] drm/Makefile: Move tiny drivers before native drivers

2024-01-23 Thread Jaak Ristioja
Hi, I apologize for not finding the time to test this earlier. On 11.12.23 05:08, Huacai Chen wrote: And Jaak, could you please test with the below patch (but keep the original order in Makefile) and then give me the dmesg output? diff --git a/drivers/video/aperture.c

Re: [bug report] drm/amdkfd: Export DMABufs from KFD using GEM handles

2024-01-23 Thread Felix Kuehling
On 2024-01-23 5:21, Dan Carpenter wrote: Hello Felix Kuehling, The patch 1819200166ce: "drm/amdkfd: Export DMABufs from KFD using GEM handles" from Aug 24, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/dma-buf/dma-buf.c:729 dma_buf_get() warn:

Re: [PATCH v4 1/3] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-23 Thread Sakari Ailus
Hi Bjorn, Thanks for the review. On Tue, Jan 23, 2024 at 11:24:23AM -0600, Bjorn Helgaas wrote: > On Tue, Jan 23, 2024 at 11:56:42AM +0200, Sakari Ailus wrote: > > There are two ways to opportunistically increment a device's runtime PM > > usage count, calling either pm_runtime_get_if_active()

Re: [PATCH v2 2/2] drm/amdgpu: Implement check_async_props for planes

2024-01-23 Thread Harry Wentland
On 2024-01-23 13:02, Xaver Hugl wrote: > Am Mo., 22. Jan. 2024 um 16:50 Uhr schrieb Harry Wentland > : >> >> >> >> On 2024-01-19 13:25, Ville Syrjälä wrote: >>> On Fri, Jan 19, 2024 at 03:12:35PM -0300, André Almeida wrote: AMD GPUs can do async flips with changes on more properties than

Re: Making drm_gpuvm work across gpu devices

2024-01-23 Thread Felix Kuehling
On 2024-01-23 14:37, Zeng, Oak wrote: Thanks Christian. I have some comment inline below. Danilo, can you also take a look and give your feedback? Thanks. Sorry, just catching up with this thread now. I'm also not familiar with drm_gpuvm. Some general observations based on my experience

[PATCH v3 39/39] drm/bridge: remove ->get_edid callback

2024-01-23 Thread Jani Nikula
There are no more users of the ->get_edid callback left. They've all been converted to ->edid_read. Remove the callback, and the fallback in drm_bridge_edid_read(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_bridge.c | 19 --- include/drm/drm_bridge.h | 30

[PATCH v3 38/39] drm/bridge: ti-sn65dsi86: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index

[PATCH v3 37/39] drm/bridge: tc358767: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/tc358767.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index

[PATCH v3 35/39] drm: bridge: dw_hdmi: clear the EDID property and CEC address on failures

2024-01-23 Thread Jani Nikula
If EDID read fails, clear the EDID property and CEC address. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index

[PATCH v3 36/39] drm/bridge: tc358767: update the EDID property

2024-01-23 Thread Jani Nikula
The EDID property should be updated between reading the EDID and adding the modes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/tc358767.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index

[PATCH v3 34/39] drm: bridge: dw_hdmi: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. v2: Fix -Wuninitialized (kernel test robot) Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 43 ++- 1 file changed, 26 insertions(+), 17 deletions(-) diff --git

[PATCH v3 33/39] drm: adv7511: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 47 +--- 1 file changed, 30 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c

[PATCH v3 31/39] drm/omap/hdmi5: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/omapdrm/dss/hdmi5.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5.c b/drivers/gpu/drm/omapdrm/dss/hdmi5.c index

[PATCH v3 32/39] drm: xlnx: zynqmp_dpsub: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c index

[PATCH v3 30/39] drm/omap/hdmi4: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c

[PATCH v3 28/39] drm/msm/hdmi: fix indent

2024-01-23 Thread Jani Nikula
Remove the excess leading tabs. Signed-off-by: Jani Nikula --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c index

[PATCH v3 29/39] drm/msm/hdmi: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c

[PATCH v3 27/39] drm/mediatek/hdmi: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c

[PATCH v3 26/39] drm/mediatek/dp: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/mediatek/mtk_dp.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c

[PATCH v3 25/39] drm/bridge: sii902x: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/sii902x.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c

[PATCH v3 24/39] drm/bridge: sii902x: use display info is_hdmi

2024-01-23 Thread Jani Nikula
Use the pre-parsed information instead of parsing EDID again. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/sii902x.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c index

[PATCH v3 23/39] drm/bridge: nxp-ptn3460: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. v2: Fix -Wsometimes-uninitialized (kernel test robot) Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/nxp-ptn3460.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git

[PATCH v3 22/39] drm/bridge: megachips: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- .../bridge/megachips-stdp-ge-b850v3-fw.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c

[PATCH v3 21/39] drm/bridge: lt9611uxc: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c

[PATCH v3 20/39] drm/bridge: lt9611: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/lontium-lt9611.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c

[PATCH v3 19/39] drm: bridge: it66121: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/ite-it66121.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c

[PATCH v3 18/39] drm/bridge: it6505: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/ite-it6505.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c

[PATCH v3 17/39] drm/bridge: display-connector: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/display-connector.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/display-connector.c

[PATCH v3 16/39] drm/bridge: cdns-mhdp8546: clear the EDID property on failures

2024-01-23 Thread Jani Nikula
If EDID read fails, clear the EDID property. Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c

[PATCH v3 15/39] drm/bridge: cdns-mhdp8546: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback and functions. Signed-off-by: Jani Nikula --- .../drm/bridge/cadence/cdns-mhdp8546-core.c | 26 +-- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c

[PATCH v3 14/39] drm/bridge: anx7625: switch to ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based callback. v2: Fix build (goto out;) Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/analogix/anx7625.c | 30 --- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c

[PATCH v3 13/39] drm/bridge: remove drm_bridge_get_edid() in favour of drm_bridge_edid_read()

2024-01-23 Thread Jani Nikula
All users of drm_bridge_get_edid() have been converted to use drm_bridge_edid_read(). Remove drm_bridge_get_edid(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_bridge.c | 28 ++-- include/drm/drm_bridge.h | 2 -- 2 files changed, 2 insertions(+), 28

[PATCH v3 12/39] drm/meson: switch to drm_bridge_edid_read()

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based functions. Not ideal, should use source physical address from connector info. Signed-off-by: Jani Nikula --- drivers/gpu/drm/meson/meson_encoder_hdmi.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git

[PATCH v3 11/39] drm/bridge: tfp410: clear the EDID property on failures

2024-01-23 Thread Jani Nikula
If EDID read fails, clear the EDID property. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/ti-tfp410.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v3 10/39] drm/bridge: tfp410: use drm_bridge_edid_read()

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based functions. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/ti-tfp410.c | 16 1 file changed, 8 insertions(+), 8

[PATCH v3 09/39] drm: bridge: simple-bridge: clear the EDID property on failures

2024-01-23 Thread Jani Nikula
If EDID read fails, clear the EDID property. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/simple-bridge.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH v3 08/39] drm: bridge: simple-bridge: use drm_bridge_edid_read()

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based functions. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/simple-bridge.c | 16 1 file changed, 8 insertions(+), 8

[PATCH v3 07/39] drm/bridge: lt9611uxc: use drm_bridge_read_edid()

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based functions. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH v3 06/39] drm/bridge: lt8912b: use ->edid_read callback

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based functions. Cc: Adrien Grassein Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 8 1 file changed, 4

[PATCH v3 05/39] drm/bridge: lt8912b: clear the EDID property on failures

2024-01-23 Thread Jani Nikula
If EDID read fails, clear the EDID property. Cc: Adrien Grassein Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH v3 04/39] drm/bridge: lt8912b: use drm_bridge_read_edid()

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based functions. cc: Adrien Grassein Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 12 ++-- 1 file changed,

[PATCH v3 03/39] drm/bridge: chrontel-ch7033: switch to drm_bridge_read_edid()

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based functions. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/bridge/chrontel-ch7033.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH v3 01/39] drm/bridge: add ->edid_read hook and drm_bridge_edid_read()

2024-01-23 Thread Jani Nikula
Add new struct drm_edid based ->edid_read hook and drm_bridge_edid_read() function to call the hook. v2: Include drm/drm_edid.h Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_bridge.c | 46 +++- include/drm/drm_bridge.h | 33 ++ 2

[PATCH v3 02/39] drm/bridge: switch to drm_bridge_read_edid()

2024-01-23 Thread Jani Nikula
Prefer using the struct drm_edid based functions. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_bridge_connector.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c index

[PATCH v3 00/39] drm/bridge: switch to struct drm_edid

2024-01-23 Thread Jani Nikula
v3 of [1] with a couple of patches fixed. BR, Jani. [1] https://patchwork.freedesktop.org/series/128149/ Jani Nikula (39): drm/bridge: add ->edid_read hook and drm_bridge_edid_read() drm/bridge: switch to drm_bridge_read_edid() drm/bridge: chrontel-ch7033: switch to

RE: Making drm_gpuvm work across gpu devices

2024-01-23 Thread Zeng, Oak
Thanks Christian. I have some comment inline below. Danilo, can you also take a look and give your feedback? Thanks. > -Original Message- > From: Christian König > Sent: Tuesday, January 23, 2024 6:13 AM > To: Zeng, Oak ; Danilo Krummrich ; > Dave Airlie ; Daniel Vetter > Cc: Welty,

Re: [PATCH] Revert "drivers/firmware: Move sysfb_init() from device_initcall to subsys_initcall_sync"

2024-01-23 Thread Jani Nikula
On Tue, 23 Jan 2024, Jani Nikula wrote: > On Tue, 23 Jan 2024, Thomas Zimmermann wrote: >> This reverts commit 60aebc9559492cea6a9625f514a8041717e3a2e4. >> >> Commit 60aebc9559492cea ("drivers/firmware: Move sysfb_init() from >> device_initcall to subsys_initcall_sync") messes up initialization

Re: [PATCH] drm: apple: mark local functions static

2024-01-23 Thread Janne Grunau
Hej Arnd, On Tue, Jan 23, 2024, at 08:34, Arnd Bergmann wrote: > On Mon, Jan 22, 2024, at 21:50, Janne Grunau wrote: >> On Wed, Jan 17, 2024, at 11:44, Arnd Bergmann wrote: >>> >>> -int parse_sample_rate_bit(struct dcp_parse_ctx *handle, unsigned int >>> *ratebit) >>> +static int

[PATCH RESEND] drm/virtio: set segment size for virtio_gpu device

2024-01-23 Thread Sebastian Ott
Hej, debug dma code is not happy with virtio gpu (arm64 VM): [ 305.881733] [ cut here ] [ 305.883117] DMA-API: virtio-pci :07:00.0: mapping sg segment longer than device claims to support [len=262144] [max=65536] [ 305.885976] WARNING: CPU: 8 PID: 2002 at

Re: [PATCH v2 2/2] drm/amdgpu: Implement check_async_props for planes

2024-01-23 Thread Xaver Hugl
Am Mo., 22. Jan. 2024 um 16:50 Uhr schrieb Harry Wentland : > > > > On 2024-01-19 13:25, Ville Syrjälä wrote: > > On Fri, Jan 19, 2024 at 03:12:35PM -0300, André Almeida wrote: > >> AMD GPUs can do async flips with changes on more properties than just > >> the FB ID, so implement a custom

Re: [RFC] Revert "drm/sched: Split free_job into own work item"

2024-01-23 Thread Mario Limonciello
On 1/22/2024 20:11, Mario Limonciello wrote: commit f7fe64ad0f22 ("drm/sched: Split free_job into own work item") causes graphics hangs at GDM or right after logging in on a Framework 13 AMD laptop (containing a Phoenix APU). This reverts commit f7fe64ad0f22ff034f8ebcfbd7299ee9cc9b57d7. Fixes:

fb_defio and page->mapping

2024-01-23 Thread Matthew Wilcox
We're currently trying to remove page->mapping from the entire kernel. This has me interested in fb_defio and since I made such a mess of it with commits ccf953d8f3d6 / 0b78f8bcf495, I'd like to discuss what to do before diving in. Folios continue to have a mapping. So we can effectively do

  1   2   >