Re: [PATCH v2 0/3] backlight: mp3309c: Allow to use on non-OF platforms

2024-02-08 Thread Lee Jones
On Thu, 08 Feb 2024, Andy Shevchenko wrote: > On Thu, Feb 08, 2024 at 06:14:55PM +, Lee Jones wrote: > > On Thu, 08 Feb 2024, Andy Shevchenko wrote: > > > On Thu, Feb 08, 2024 at 05:39:46PM +, Lee Jones wrote: > > > > On Thu, 08 Feb 2024, Andy Shevchenko wrote: > > > > > On Thu, Feb 08,

Re: [PATCH 1/3] dt-bindings: display: panel-simple-dsi: add s6e3fa7 ams559nk06 compat

2024-02-08 Thread Krzysztof Kozlowski
On 09/02/2024 01:16, Richard Acayan wrote: > The Samsung S6E3FA7 display controller and AMS559NK06 panel are used for > the display in Pixel 3a devices. Add the compatible for it. > > Signed-off-by: Richard Acayan > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 3/8] firmware/sysfb: Set firmware-framebuffer parent device

2024-02-08 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm-tip/drm-tip linus/master v6.8-rc3 next-20240208] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

[linux-next:master] BUILD REGRESSION b1d3a0e70c3881d2f8cf6692ccf7c2a4fb2d030d

2024-02-08 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: b1d3a0e70c3881d2f8cf6692ccf7c2a4fb2d030d Add linux-next specific files for 20240208 Error/Warning: (recently discovered and may have been fixed) arch/sh/boot/compressed/../../../../lib

Re: [PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions

2024-02-08 Thread Michael Ellerman
Thomas Zimmermann writes: > Am 07.02.24 um 17:13 schrieb Randy Dunlap: >> When VIDEO is not set, there is a build error. Fix that by selecting >> VIDEO for PS3_PS3AV. >> >> ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined! >> >> Fixes: dae7fbf43fd0 ("driver/ps3: Include

[git pull] drm fixes for 6.8-rc4

2024-02-08 Thread Dave Airlie
Hi Linus, Regular weekly fixes, xe, amdgpu and msm are most of them, with some misc in i915, ivpu and nouveau, scattered but nothing too intense at this point. Dave. drm-fixes-2024-02-09: drm fixes for 6.8-rc4 i915: - gvt: docs fix, uninit var, MAINTAINERS ivpu: - add aborted job status -

Re: [PATCH 2/3] drm/panel: add samsung s6e3fa7 panel driver

2024-02-08 Thread Jessica Zhang
On 2/8/2024 4:16 PM, Richard Acayan wrote: The S6E3FA7 display controller is enabled in every Pixel 3a (non-XL) variant. Add the driver for it, generated by linux-mdss-dsi-panel-driver-generator. There are other panels connected to the same S6E3FA7 display controller, such as the AMS604NL01

Re: [PATCH i-g-t v2] benchmarks: Add VKMS benchmark

2024-02-08 Thread Maíra Canal
On 2/8/24 17:04, Arthur Grillo wrote: Create a benchmark for the VKMS driver. Use a KMS layout with deliberate odd sizes to try to avoid alignment accidents and run it for FRAME_COUNT frames flipping framebuffers in each plane. This benchmark was suggested by Pekka Paalanen to better analyse

[PATCH 1/3] dt-bindings: display: panel-simple-dsi: add s6e3fa7 ams559nk06 compat

2024-02-08 Thread Richard Acayan
The Samsung S6E3FA7 display controller and AMS559NK06 panel are used for the display in Pixel 3a devices. Add the compatible for it. Signed-off-by: Richard Acayan --- .../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH 3/3] arm64: dts: qcom: sdm670-google-sargo: add panel

2024-02-08 Thread Richard Acayan
Add the panel used in the Google Pixel 3a. Signed-off-by: Richard Acayan --- .../boot/dts/qcom/sdm670-google-sargo.dts | 64 +++ 1 file changed, 64 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts

[PATCH 2/3] drm/panel: add samsung s6e3fa7 panel driver

2024-02-08 Thread Richard Acayan
The S6E3FA7 display controller is enabled in every Pixel 3a (non-XL) variant. Add the driver for it, generated by linux-mdss-dsi-panel-driver-generator. There are other panels connected to the same S6E3FA7 display controller, such as the AMS604NL01 panel, which are incompatible with this driver.

[PATCH 0/3] drm/panel: Pixel 3a Panel

2024-02-08 Thread Richard Acayan
This adds support for the AMS559NK06 panel with the S6E3FA7 display controller and enables the display subsystem on the Pixel 3a. Richard Acayan (3): dt-bindings: display: panel-simple-dsi: add s6e3fa7 ams559nk06 compat drm/panel: add samsung s6e3fa7 panel driver arm64: dts: qcom:

Re: [PATCH 15/17] drm/msm/dpu: allow certain formats for CDM for DP

2024-02-08 Thread Paloma Arellano
On 1/25/2024 1:58 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano wrote: CDM block supports formats other than H1V2 for DP. Since we are now adding support for CDM over DP, relax the checks to allow all other formats for DP other than H1V2. Signed-off-by: Paloma Arellano

Re: [PATCH v4 4/5] drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c

2024-02-08 Thread Paloma Arellano
On 2/8/2024 10:49 AM, Abhinav Kumar wrote: On 2/8/2024 7:20 AM, Dmitry Baryshkov wrote: dpu_encoder_phys_wb is the only user of encoder's atomic_check callback. Move corresponding checks to drm_writeback_connector's implementation and drop the dpu_encoder_phys_wb_atomic_check() function.

Re: [PATCH 12/17] drm/msm/dpu: add support of new peripheral flush mechanism

2024-02-08 Thread Paloma Arellano
On 1/27/2024 9:42 PM, Dmitry Baryshkov wrote: On Sun, 28 Jan 2024 at 07:41, Paloma Arellano wrote: On 1/25/2024 1:49 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano wrote: From: Kuogee Hsieh Introduce a peripheral flushing mechanism to decouple peripheral metadata

Re: Re: [PATCH v3 3/3] drm/i915: Convert REG_GENMASK* to fixed-width GENMASK_*

2024-02-08 Thread Lucas De Marchi
On Thu, Feb 08, 2024 at 09:07:32PM +0100, Andi Shyti wrote: Hi Lucas, ... +#define REG_GENMASK(__high, __low) GENMASK_U32(__high, __low) +#define REG_GENMASK64(__high, __low) GENMASK_U64(__high, __low) +#define REG_GENMASK16(__high, __low) GENMASK_U16(__high, __low) +#define

Re: [PATCH v3 00/32] spi: get rid of some legacy macros

2024-02-08 Thread Mark Brown
On Wed, 07 Feb 2024 19:40:14 +0100, Uwe Kleine-König wrote: > Changes since v2 > (https://lore.kernel.org/linux-spi/cover.1705944943.git.u.kleine-koe...@pengutronix.de): > > - Drop patch "mtd: rawnand: fsl_elbc: Let .probe retry if local bus is >missing" which doesn't belong into this

Re: Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT

2024-02-08 Thread Lucas De Marchi
On Thu, Feb 08, 2024 at 09:04:45PM +0100, Andi Shyti wrote: Hi Lucas, looks good, just one idea... ... +#define BIT_U8(b) ((u8)(BIT_INPUT_CHECK(u8, b) + BIT(b))) +#define BIT_U16(b) ((u16)(BIT_INPUT_CHECK(u16, b) + BIT(b))) +#define BIT_U32(b)

[PATCH v4 3/3] drm/amdgpu: Make it possible to async flip overlay planes

2024-02-08 Thread André Almeida
amdgpu can handle async flips on overlay planes, so mark it as true during the plane initialization. Signed-off-by: André Almeida --- v4: new patch drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v4 1/3] drm/atomic: Allow userspace to use explicit sync with atomic async flips

2024-02-08 Thread André Almeida
Allow userspace to use explicit synchronization with atomic async flips. That means that the flip will wait for some hardware fence, and then will flip as soon as possible (async) in regard of the vblank. Signed-off-by: André Almeida --- v4: no changes drivers/gpu/drm/drm_atomic_uapi.c | 4

[PATCH v4 2/3] drm: Allow drivers to choose plane types to async flip

2024-02-08 Thread André Almeida
Different planes may have different capabilities of doing async flips, so create a field to let drivers allow async flip per plane type. Signed-off-by: André Almeida --- v4: new patch drivers/gpu/drm/drm_atomic_uapi.c | 4 ++-- drivers/gpu/drm/drm_plane.c | 3 +++ include/drm/drm_plane.h

[PATCH v4 0/3] drm/atomic: Allow drivers to write their own plane check for async

2024-02-08 Thread André Almeida
Hi, AMD hardware can do async flips with overlay planes, so this patchset does a small redesign to allow drivers to choose per plane type if they can or cannot do async flips. It also allows async commits with IN_FENCE_ID in any driver. Changes from v3: - Major patchset redesign v3:

Re: [PATCH v3 3/3] drm/i915: Convert REG_GENMASK* to fixed-width GENMASK_*

2024-02-08 Thread Andi Shyti
Hi Lucas, ... > +#define REG_GENMASK(__high, __low) GENMASK_U32(__high, __low) > +#define REG_GENMASK64(__high, __low) GENMASK_U64(__high, __low) > +#define REG_GENMASK16(__high, __low) GENMASK_U16(__high, __low) > +#define REG_GENMASK8(__high, __low) GENMASK_U8(__high, __low) I was hoping

[PATCH i-g-t v2] benchmarks: Add VKMS benchmark

2024-02-08 Thread Arthur Grillo
Create a benchmark for the VKMS driver. Use a KMS layout with deliberate odd sizes to try to avoid alignment accidents and run it for FRAME_COUNT frames flipping framebuffers in each plane. This benchmark was suggested by Pekka Paalanen to better analyse possible performance regression on the

Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT

2024-02-08 Thread Andi Shyti
Hi Lucas, looks good, just one idea... ... > +#define BIT_U8(b)((u8)(BIT_INPUT_CHECK(u8, b) + BIT(b))) > +#define BIT_U16(b) ((u16)(BIT_INPUT_CHECK(u16, b) + BIT(b))) > +#define BIT_U32(b) ((u32)(BIT_INPUT_CHECK(u32, b) + BIT(b))) > +#define BIT_U64(b)

Re: [PATCH v3 1/3] bits: introduce fixed-type genmasks

2024-02-08 Thread Andi Shyti
Hi Lucas and Yury, On Wed, Feb 07, 2024 at 11:45:19PM -0800, Lucas De Marchi wrote: > From: Yury Norov > > Generalize __GENMASK() to support different types, and implement > fixed-types versions of GENMASK() based on it. The fixed-type version > allows more strict checks to the min/max values

Re: [PATCH i-g-t] benchmarks: Add VKMS benchmark

2024-02-08 Thread Arthur Grillo
On 08/02/24 06:50, Pekka Paalanen wrote: > On Wed, 07 Feb 2024 17:17:15 -0300 > Arthur Grillo wrote: > >> Create a benchmark for the VKMS driver. Use a KMS layout with deliberate >> odd sizes to try to avoid alignment accidents and run it for FRAME_COUNT >> frames flipping framebuffers in

Re: [PATCH v2 5/6] drm/panel: st7703: Drive XBD599 panel at higher clock rate

2024-02-08 Thread Maxime Ripard
Hi Frank, On Mon, Feb 05, 2024 at 04:22:28PM +0100, Frank Oltmanns wrote: > This panel is used in the pinephone that runs on a Allwinner A64 SOC. > The SOC requires pll-mipi to run at more than 500 MHz. > > This is the relevant clock tree: > pll-mipi > tcon0 >tcon-data-clock > >

Re: [PATCH v4 4/5] drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c

2024-02-08 Thread Abhinav Kumar
On 2/8/2024 7:20 AM, Dmitry Baryshkov wrote: dpu_encoder_phys_wb is the only user of encoder's atomic_check callback. Move corresponding checks to drm_writeback_connector's implementation and drop the dpu_encoder_phys_wb_atomic_check() function. Signed-off-by: Dmitry Baryshkov ---

Re: [PATCH v4 1/3] drm: Add drm_get_acpi_edid() helper

2024-02-08 Thread Mario Limonciello
On 2/8/2024 08:31, Jani Nikula wrote: On Thu, 08 Feb 2024, Maxime Ripard wrote: On Thu, Feb 08, 2024 at 11:57:11AM +0200, Jani Nikula wrote: On Wed, 07 Feb 2024, Mario Limonciello wrote: Some manufacturers have intentionally put an EDID that differs from the EDID on the internal panel on

Re: [PATCH v3 1/3] backlight: mp3309c: Make use of device properties

2024-02-08 Thread Andy Shevchenko
On Thu, Feb 08, 2024 at 08:24:46PM +0200, Andy Shevchenko wrote: > Convert the module to be property provider agnostic and allow > it to be used on non-OF platforms. > > Add mod_devicetable.h include. It seems some emails are missing, I just sent a 'resend v3' hopefully without missing parts.

[PATCH v3 2/3] backlight: mp3309c: use dev_err_probe() instead of dev_err()

2024-02-08 Thread Andy Shevchenko
Replace dev_err() with dev_err_probe(). This helps in simplifing code and standardizing the error output. Tested-by: Flavio Suligoi Reviewed-by: Daniel Thompson Signed-off-by: Andy Shevchenko --- drivers/video/backlight/mp3309c.c | 18 +++--- 1 file changed, 7 insertions(+), 11

[PATCH v3 3/3] backlight: mp3309c: Utilise temporary variable for struct device

2024-02-08 Thread Andy Shevchenko
We have a temporary variable to keep pointer to struct device. Utilise it where it makes sense. Reviewed-by: Daniel Thompson Tested-by: Flavio Suligoi Signed-off-by: Andy Shevchenko --- drivers/video/backlight/mp3309c.c | 30 -- 1 file changed, 12 insertions(+), 18

[resend, PATCH v3 0/3] backlight: mp3309c: Allow to use on non-OF platforms

2024-02-08 Thread Andy Shevchenko
Allow to use driver on non-OF platforms and other cleanups. Changelog v3: - rebased on top of the last changes against this driver (Lee) - added tags to patch 2 (Daniel, Flavio) Changelog v2: - rename pm3309c_parse_dt_node() --> mp3309c_parse_fwnode() (Daniel)

[PATCH v3 1/3] backlight: mp3309c: Make use of device properties

2024-02-08 Thread Andy Shevchenko
Convert the module to be property provider agnostic and allow it to be used on non-OF platforms. Add mod_devicetable.h include. Tested-by: Flavio Suligoi Reviewed-by: Daniel Thompson Signed-off-by: Andy Shevchenko --- drivers/video/backlight/mp3309c.c | 44 +-- 1

[PATCH v3 2/3] backlight: mp3309c: use dev_err_probe() instead of dev_err()

2024-02-08 Thread Andy Shevchenko
Replace dev_err() with dev_err_probe(). This helps in simplifing code and standardizing the error output. Tested-by: Flavio Suligoi Reviewed-by: Daniel Thompson Signed-off-by: Andy Shevchenko --- drivers/video/backlight/mp3309c.c | 18 +++--- 1 file changed, 7 insertions(+), 11

[PATCH v3 0/3] backlight: mp3309c: Allow to use on non-OF platforms

2024-02-08 Thread Andy Shevchenko
Allow to use driver on non-OF platforms and other cleanups. Changelog v3: - rebased on top of the last changes against this driver (Lee) - added tags to patch 2 (Daniel, Flavio) Changelog v2: - rename pm3309c_parse_dt_node() --> mp3309c_parse_fwnode() (Daniel)

Re: [PATCH] drm/i915: Add flex arrays to struct i915_syncmap

2024-02-08 Thread Gustavo A. R. Silva
On 2/8/24 12:13, Erick Archer wrote: The "struct i915_syncmap" uses a dynamically sized set of trailing elements. It can use an "u32" array or a "struct i915_syncmap *" array. So, use the preferred way in the kernel declaring flexible arrays [1]. Because there are two possibilities for the

[PATCH v3 1/3] backlight: mp3309c: Make use of device properties

2024-02-08 Thread Andy Shevchenko
Convert the module to be property provider agnostic and allow it to be used on non-OF platforms. Add mod_devicetable.h include. Tested-by: Flavio Suligoi Reviewed-by: Daniel Thompson Signed-off-by: Andy Shevchenko --- drivers/video/backlight/mp3309c.c | 44 +-- 1

[PATCH v3 3/3] backlight: mp3309c: Utilise temporary variable for struct device

2024-02-08 Thread Andy Shevchenko
We have a temporary variable to keep pointer to struct device. Utilise it where it makes sense. Reviewed-by: Daniel Thompson Tested-by: Flavio Suligoi Signed-off-by: Andy Shevchenko --- drivers/video/backlight/mp3309c.c | 30 -- 1 file changed, 12 insertions(+), 18

Re: [PATCH v2 0/3] backlight: mp3309c: Allow to use on non-OF platforms

2024-02-08 Thread Andy Shevchenko
On Thu, Feb 08, 2024 at 06:14:55PM +, Lee Jones wrote: > On Thu, 08 Feb 2024, Andy Shevchenko wrote: > > On Thu, Feb 08, 2024 at 05:39:46PM +, Lee Jones wrote: > > > On Thu, 08 Feb 2024, Andy Shevchenko wrote: > > > > On Thu, Feb 08, 2024 at 11:34:25AM +, Lee Jones wrote: > > > > > On

Re: [PATCH v2 0/3] backlight: mp3309c: Allow to use on non-OF platforms

2024-02-08 Thread Lee Jones
On Thu, 08 Feb 2024, Andy Shevchenko wrote: > On Thu, Feb 08, 2024 at 05:39:46PM +, Lee Jones wrote: > > On Thu, 08 Feb 2024, Andy Shevchenko wrote: > > > On Thu, Feb 08, 2024 at 11:34:25AM +, Lee Jones wrote: > > > > On Thu, 01 Feb 2024, Andy Shevchenko wrote: > > ... > > > > > >

[PATCH] drm/i915: Add flex arrays to struct i915_syncmap

2024-02-08 Thread Erick Archer
The "struct i915_syncmap" uses a dynamically sized set of trailing elements. It can use an "u32" array or a "struct i915_syncmap *" array. So, use the preferred way in the kernel declaring flexible arrays [1]. Because there are two possibilities for the trailing arrays, it is necessary to declare

Re: [PATCH v2 0/3] backlight: mp3309c: Allow to use on non-OF platforms

2024-02-08 Thread Andy Shevchenko
On Thu, Feb 08, 2024 at 05:39:46PM +, Lee Jones wrote: > On Thu, 08 Feb 2024, Andy Shevchenko wrote: > > On Thu, Feb 08, 2024 at 11:34:25AM +, Lee Jones wrote: > > > On Thu, 01 Feb 2024, Andy Shevchenko wrote: ... > > > > backlight: mp3309c: Utilise temporary variable for struct device

Re: [PATCH v2] drm/i915: Add GuC submission interface version query

2024-02-08 Thread Souza, Jose
On Thu, 2024-02-08 at 07:19 -0800, José Roberto de Souza wrote: > On Thu, 2024-02-08 at 14:59 +, Tvrtko Ursulin wrote: > > On 08/02/2024 14:30, Souza, Jose wrote: > > > On Thu, 2024-02-08 at 08:25 +, Tvrtko Ursulin wrote: > > > > From: Tvrtko Ursulin > > > > > > > > Add a new query to

Re: [RFC] drm/i915: Add GuC submission interface version query

2024-02-08 Thread John Harrison
On 2/8/2024 00:41, Tvrtko Ursulin wrote: On 07/02/2024 19:34, John Harrison wrote: On 2/7/2024 10:49, Tvrtko Ursulin wrote: On 07/02/2024 18:12, John Harrison wrote: On 2/7/2024 03:56, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add a new query to the GuC submission interface version. Mesa

Re: [PATCH v2 0/3] backlight: mp3309c: Allow to use on non-OF platforms

2024-02-08 Thread Lee Jones
On Thu, 08 Feb 2024, Andy Shevchenko wrote: > On Thu, Feb 08, 2024 at 11:34:25AM +, Lee Jones wrote: > > On Thu, 01 Feb 2024, Andy Shevchenko wrote: > > ... > > > > backlight: mp3309c: Utilise temporary variable for struct device > > (1) > > > Set no longer applies. Please rebase,

Re: [PATCH v4] drm/msm/dsi: Document DSC related pclk_rate and hdisplay calculations

2024-02-08 Thread Abhinav Kumar
On 2/8/2024 7:23 AM, Dmitry Baryshkov wrote: Provide actual documentation for the pclk and hdisplay calculations in the case of DSC compression being used. Signed-off-by: Dmitry Baryshkov --- Changes since v3: - refresh rate -> transfer time (Abhinav) Changes since v2: - Followed

Re: [PATCH v2 0/3] backlight: mp3309c: Allow to use on non-OF platforms

2024-02-08 Thread Andy Shevchenko
On Thu, Feb 08, 2024 at 11:34:25AM +, Lee Jones wrote: > On Thu, 01 Feb 2024, Andy Shevchenko wrote: ... > > backlight: mp3309c: Utilise temporary variable for struct device (1) > Set no longer applies. Please rebase, thanks. I got a contradictory messages: 1) email that says that all

Re: [PATCH v2 0/4] backlight: hx8357: Clean up and make OF-independent

2024-02-08 Thread Lee Jones
On Thu, 08 Feb 2024, Andy Shevchenko wrote: > On Thu, Feb 08, 2024 at 10:53:04AM +, Lee Jones wrote: > > On Thu, 01 Feb 2024, Andy Shevchenko wrote: > > ... > > > Someone may wish to address this: > > > > WARNING: DT compatible string "himax,hx8369" appears un-documented -- check > >

Re: [PATCH v2 0/4] backlight: hx8357: Clean up and make OF-independent

2024-02-08 Thread Andy Shevchenko
On Thu, Feb 08, 2024 at 10:53:04AM +, Lee Jones wrote: > On Thu, 01 Feb 2024, Andy Shevchenko wrote: ... > Someone may wish to address this: > > WARNING: DT compatible string "himax,hx8369" appears un-documented -- check > ./Documentation/devicetree/bindings/ > #58: FILE:

Re: [PATCH 3/5] drm/msm: mdss: Add X1E80100 support

2024-02-08 Thread Abhinav Kumar
On 2/8/2024 5:46 AM, Abel Vesa wrote: On 24-02-08 15:42:04, Dmitry Baryshkov wrote: On Thu, 8 Feb 2024 at 15:37, Abel Vesa wrote: On 24-01-29 17:11:25, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 15:19, Abel Vesa wrote: Add support for MDSS on X1E80100. Signed-off-by: Abel Vesa

[pull] amdgpu drm-fixes-6.8

2024-02-08 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.8. The following changes since commit d0399da9fb5f8e3d897b9776bffee2d3bfe20210: drm/sched: Re-queue run job worker when drm_sched_entity_pop_job() returns NULL (2024-02-06 12:47:43 +1000) are available in the Git repository at:

Re: [PATCH v4 03/14] drm/panthor: Add the device logical block

2024-02-08 Thread Boris Brezillon
On Thu, 8 Feb 2024 16:18:48 + Liviu Dudau wrote: > On Thu, Feb 08, 2024 at 05:00:23PM +0100, Boris Brezillon wrote: > > On Thu, 8 Feb 2024 15:55:36 + > > Liviu Dudau wrote: > > > > > On Thu, Feb 08, 2024 at 04:14:59PM +0100, Boris Brezillon wrote: > > > > On Thu, 8 Feb 2024

Re: xe vs amdgpu userptr handling

2024-02-08 Thread Daniel Vetter
On Wed, Feb 07, 2024 at 08:08:42AM -0300, Maíra Canal wrote: > Adding another point to this discussion, would it make sense to somehow > create a generic structure that all drivers, including shmem drivers, could > use it? So the issue is a bit that at least the userptr for shmem drivers I've

Re: [PATCH v4 03/14] drm/panthor: Add the device logical block

2024-02-08 Thread Liviu Dudau
On Thu, Feb 08, 2024 at 05:00:23PM +0100, Boris Brezillon wrote: > On Thu, 8 Feb 2024 15:55:36 + > Liviu Dudau wrote: > > > On Thu, Feb 08, 2024 at 04:14:59PM +0100, Boris Brezillon wrote: > > > On Thu, 8 Feb 2024 14:30:02 + > > > Liviu Dudau wrote: > > > > > > > > +int

Re: [PATCH v4 04/14] drm/panthor: Add the GPU logical block

2024-02-08 Thread Steven Price
On 22/01/2024 16:30, Boris Brezillon wrote: > Handles everything that's not related to the FW, the MMU or the > scheduler. This is the block dealing with the GPU property retrieval, > the GPU block power on/off logic, and some global operations, like > global cache flushing. > > v4: > - Expose

Re: [PATCH 2/2] xfs: disable large folio support in xfile_create

2024-02-08 Thread Darrick J. Wong
On Wed, Feb 07, 2024 at 05:56:21PM -0800, Andrew Morton wrote: > On Thu, 11 Jan 2024 18:22:50 -0800 "Darrick J. Wong" > wrote: > > > On Thu, Jan 11, 2024 at 10:45:53PM +, Matthew Wilcox wrote: > > > On Thu, Jan 11, 2024 at 02:00:53PM -0800, Andrew Morton wrote: > > > > On Wed, 10 Jan 2024

Re: [PATCH v4 00/14] drm: Add a driver for CSF-based Mali GPUs

2024-02-08 Thread Liviu Dudau
On Mon, Jan 22, 2024 at 05:30:31PM +0100, Boris Brezillon wrote: > Hello, Hi, > > This is the 4th version of the kernel driver for Mali CSF-based GPUs. > > A branch based on drm-misc-next and containing all the dependencies > that are not yet available in drm-misc-next here[1], and another [2]

Re: [PATCH v4 03/14] drm/panthor: Add the device logical block

2024-02-08 Thread Boris Brezillon
On Thu, 8 Feb 2024 15:55:36 + Liviu Dudau wrote: > On Thu, Feb 08, 2024 at 04:14:59PM +0100, Boris Brezillon wrote: > > On Thu, 8 Feb 2024 14:30:02 + > > Liviu Dudau wrote: > > > > > > +int panthor_device_init(struct panthor_device *ptdev) > > > > +{ > > > > + struct resource

Re: [PATCH v5 1/3] drm/buddy: Implement tracking clear page feature

2024-02-08 Thread Arunpravin Paneer Selvam
On 1/31/2024 11:52 PM, Matthew Auld wrote: On 30/01/2024 19:48, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each block as

Re: [PATCH v4 03/14] drm/panthor: Add the device logical block

2024-02-08 Thread Liviu Dudau
On Thu, Feb 08, 2024 at 04:14:59PM +0100, Boris Brezillon wrote: > On Thu, 8 Feb 2024 14:30:02 + > Liviu Dudau wrote: > > > > +int panthor_device_init(struct panthor_device *ptdev) > > > +{ > > > + struct resource *res; > > > + struct page *p; > > > + int ret; > > > + > > > + ptdev->coherent

[PATCH v6 3/3] drm/buddy: Add defragmentation support

2024-02-08 Thread Arunpravin Paneer Selvam
Add a function to support defragmentation. v1: Defragment the memory beginning from min_order till the required memory space is available. Signed-off-by: Arunpravin Paneer Selvam Suggested-by: Matthew Auld --- drivers/gpu/drm/drm_buddy.c | 67 +++--

[PATCH v6 1/3] drm/buddy: Implement tracking clear page feature

2024-02-08 Thread Arunpravin Paneer Selvam
- Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. - Track the available cleared pages size - If driver requests cleared memory we prefer cleared

[PATCH v6 2/3] drm/amdgpu: Enable clear page functionality

2024-02-08 Thread Arunpravin Paneer Selvam
Add clear page support in vram memory region. v1:(Christian) - Dont handle clear page as TTM flag since when moving the BO back in from GTT again we don't need that. - Make a specialized version of amdgpu_fill_buffer() which only clears the VRAM areas which are not already cleared -

Re: [PATCH v3 1/2] drm/buddy: Implement tracking clear page feature

2024-02-08 Thread Arunpravin Paneer Selvam
On 1/31/2024 11:59 PM, Matthew Auld wrote: On 30/01/2024 20:30, Arunpravin Paneer Selvam wrote: Hi Matthew, On 12/21/2023 12:51 AM, Matthew Auld wrote: Hi, On 14/12/2023 13:42, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the

Re: [PATCH] drm/tests/drm_buddy: add alloc_contiguous test

2024-02-08 Thread Arunpravin Paneer Selvam
On 2/8/2024 8:06 PM, Matthew Auld wrote: Sanity check DRM_BUDDY_CONTIGUOUS_ALLOCATION. That's really quick :) Reviewed-by: Arunpravin Paneer Selvam References:https://gitlab.freedesktop.org/drm/amd/-/issues/3097 Signed-off-by: Matthew Auld Cc: Arunpravin Paneer Selvam Cc: Limonciello Cc:

Re: Re: [etnaviv-next v13 7/7] drm/etnaviv: Add support for vivante GPU cores attached via PCI(e)

2024-02-08 Thread Maxime Ripard
On Wed, Feb 07, 2024 at 10:35:49AM +0100, Daniel Vetter wrote: > On Wed, Feb 07, 2024 at 01:27:59AM +0800, Sui Jingfeng wrote: > > The component helper functions are the glue, which is used to bind multiple > > GPU cores to a virtual master platform device. Which is fine and works well > > for the

[PATCH v4] drm/msm/dsi: Document DSC related pclk_rate and hdisplay calculations

2024-02-08 Thread Dmitry Baryshkov
_total -= hdisplay; if (wide_bus_enabled && !(msm_host->mode_flags & MIPI_DSI_MODE_VIDEO)) --- base-commit: b1d3a0e70c3881d2f8cf6692ccf7c2a4fb2d030d change-id: 20240208-fd_document_dsc_pclk_rate-da6a62919876 Best regards, -- Dmitry Baryshkov

Re: [PATCH] gpu: drm: display: indent fix in comment

2024-02-08 Thread Kousik Sanagavarapu
On Thu, Jan 25, 2024 at 12:05:56AM +0530, Kousik Sanagavarapu wrote: > The comments explaining the function "drm_dp_mst_atom_check_mgr()" had > uneven indentation which made "make htmldocs" complain: > > Documentation/gpu/drm-kms-helpers:296: >

[PATCH v4 4/5] drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c

2024-02-08 Thread Dmitry Baryshkov
dpu_encoder_phys_wb is the only user of encoder's atomic_check callback. Move corresponding checks to drm_writeback_connector's implementation and drop the dpu_encoder_phys_wb_atomic_check() function. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 54

[PATCH v4 1/5] drm/msm/dpu: split irq_control into irq_enable and _disable

2024-02-08 Thread Dmitry Baryshkov
The single helper for both enable and disable cases is too complicated, especially if we start adding more code to these helpers. Split it into irq_enable and irq_disable cases. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c|

[PATCH v4 0/5] drm/msm/dpu: remove dpu_encoder_phys_ops::atomic_mode_set callback

2024-02-08 Thread Dmitry Baryshkov
| 3 +- 9 files changed, 274 insertions(+), 224 deletions(-) --- base-commit: b1d3a0e70c3881d2f8cf6692ccf7c2a4fb2d030d change-id: 20240208-fd_remove_phys_ops_atomic_mode_set-ab706706b374 Best regards, -- Dmitry Baryshkov

[PATCH v4 2/5] drm/msm/dpu: split _dpu_encoder_resource_control_helper()

2024-02-08 Thread Dmitry Baryshkov
Follow the _dpu_encoder_irq_control() change and split the _dpu_encoder_resource_control_helper() into enable and disable parts. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 45 +++--

[PATCH v4 5/5] drm/msm/dpu: drop dpu_encoder_phys_ops::atomic_check()

2024-02-08 Thread Dmitry Baryshkov
Writeback was the last user of dpu_encoder_phys_ops's atomic_check() callback. As the code was moved to the dpu_writeback.c, the callback becomes unused. Drop it now. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 15

[PATCH v4 3/5] drm/msm/dpu: drop dpu_encoder_phys_ops.atomic_mode_set

2024-02-08 Thread Dmitry Baryshkov
The atomic_mode_set() callback only sets the phys_enc's IRQ data. As the INTF and WB are statically allocated to each encoder/phys_enc, drop the atomic_mode_set callback and set the IRQs during encoder init. For the CMD panel usecase some of IRQ indexes depend on the selected resources. Move

Re: [PATCH v2] drm/i915: Add GuC submission interface version query

2024-02-08 Thread Souza, Jose
On Thu, 2024-02-08 at 14:59 +, Tvrtko Ursulin wrote: > On 08/02/2024 14:30, Souza, Jose wrote: > > On Thu, 2024-02-08 at 08:25 +, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > Add a new query to the GuC submission interface version. > > > > > > Mesa intends to use this

Re: [PATCH v4 03/14] drm/panthor: Add the device logical block

2024-02-08 Thread Boris Brezillon
On Thu, 8 Feb 2024 14:30:02 + Liviu Dudau wrote: > > +#ifdef CONFIG_PM > > +int panthor_device_resume(struct device *dev) > > +{ > > + struct panthor_device *ptdev = dev_get_drvdata(dev); > > + int ret, cookie; > > + > > + if (atomic_read(>pm.state) !=

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-02-08 Thread Ville Syrjälä
On Wed, Feb 07, 2024 at 11:02:27PM +0200, Imre Deak wrote: > On Wed, Feb 07, 2024 at 10:48:53PM +0200, Imre Deak wrote: > > On Wed, Feb 07, 2024 at 10:02:18PM +0200, Ville Syrjälä wrote: > > > > [...] > > > > +static int > > > > +drm_dp_tunnel_atomic_check_group_bw(struct drm_dp_tunnel_group_state

Re: [PATCH v4 03/14] drm/panthor: Add the device logical block

2024-02-08 Thread Boris Brezillon
On Thu, 8 Feb 2024 14:30:02 + Liviu Dudau wrote: > > +int panthor_device_init(struct panthor_device *ptdev) > > +{ > > + struct resource *res; > > + struct page *p; > > + int ret; > > + > > + ptdev->coherent = device_get_dma_attr(ptdev->base.dev) == > > DEV_DMA_COHERENT; > > + > > +

Re: [PATCH v2] drm/i915: Add GuC submission interface version query

2024-02-08 Thread Tvrtko Ursulin
On 08/02/2024 14:30, Souza, Jose wrote: On Thu, 2024-02-08 at 08:25 +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add a new query to the GuC submission interface version. Mesa intends to use this information to check for old firmware versions with a known bug where using the render and

[PATCH v4 2/4] drm/msm/dpu: support binding to the mdp5 devices

2024-02-08 Thread Dmitry Baryshkov
Existing MDP5 devices have slightly different bindings. The main register region is called `mdp_phys' instead of `mdp'. Also vbif register regions are a part of the parent, MDSS device. Add support for handling this binding differences. Signed-off-by: Dmitry Baryshkov ---

[PATCH v4 3/4] drm/msm: add a kernel param to select between MDP5 and DPU drivers

2024-02-08 Thread Dmitry Baryshkov
For some of the platforms (e.g. SDM660, SDM630, MSM8996, etc.) it is possible to support this platform via the DPU driver (e.g. to provide support for DP, multirect, etc). Add a modparam to be able to switch between these two drivers. All platforms supported by both drivers are by default handled

[PATCH v4 4/4] drm/msm/dpu: add support for SDM660 and SDM630 platforms

2024-02-08 Thread Dmitry Baryshkov
Bring in hardware support for the SDM660 and SDM630 platforms, which belong to the same DPU generation as MSM8998. Note, by default these platforms are still handled by the MDP5 driver unless the `msm.prefer_mdp5=false' parameter is provided. Co-developed-by: Konrad Dybcio Signed-off-by: Konrad

[PATCH v4 0/4] drm/msm: provide migration path from MDP5 to DPU driver

2024-02-08 Thread Dmitry Baryshkov
Over the last several years the DPU driver has been actively developed, while the MDP5 is mostly in the maintenance mode. This results in some features being available only in the DPU driver. For example, bandwidth scaling, writeback support, properly supported bonded DSI aka dual DSI support, DSC

[PATCH v4 1/4] drm/msm/mdss: generate MDSS data for MDP5 platforms

2024-02-08 Thread Dmitry Baryshkov
Older (mdp5) platforms do not use per-SoC compatible strings. Instead they use a single compat entry 'qcom,mdss'. To facilitate migrating these platforms to the DPU driver provide a way to generate the MDSS / UBWC data at runtime, when the DPU driver asks for it. It is not possible to generate

[PATCH v2] drm/msm/dpu: make "vblank timeout" more useful

2024-02-08 Thread Dmitry Baryshkov
We have several reports of vblank timeout messages. However after some debugging it was found that there might be different causes to that. To allow us to identify the DPU block that gets stuck, include the actual CTL_FLUSH value into the timeout message and trigger the devcore snapshot capture.

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-08 Thread Matthew Auld
On 08/02/2024 14:17, Matthew Auld wrote: On 08/02/2024 13:47, Arunpravin Paneer Selvam wrote: Hi Matthew, On 2/8/2024 7:00 PM, Matthew Auld wrote: On 07/02/2024 17:44, Arunpravin Paneer Selvam wrote: Few users have observed display corruption when they boot the machine to KDE Plasma or

[PATCH] drm/tests/drm_buddy: add alloc_contiguous test

2024-02-08 Thread Matthew Auld
Sanity check DRM_BUDDY_CONTIGUOUS_ALLOCATION. References: https://gitlab.freedesktop.org/drm/amd/-/issues/3097 Signed-off-by: Matthew Auld Cc: Arunpravin Paneer Selvam Cc: Limonciello Cc: Christian König --- drivers/gpu/drm/tests/drm_buddy_test.c | 89 ++ 1 file

Re: Re: [PATCH v4 1/3] drm: Add drm_get_acpi_edid() helper

2024-02-08 Thread Jani Nikula
On Thu, 08 Feb 2024, Maxime Ripard wrote: > On Thu, Feb 08, 2024 at 11:57:11AM +0200, Jani Nikula wrote: >> On Wed, 07 Feb 2024, Mario Limonciello wrote: >> > Some manufacturers have intentionally put an EDID that differs from >> > the EDID on the internal panel on laptops. Drivers can call

Re: [PATCH] dt-bindings: backlight: qcom-wled: Fix bouncing email addresses

2024-02-08 Thread Lee Jones
On Fri, 02 Feb 2024, Jeffrey Hugo wrote: > Bjorn is no longer at Linaro. Update his email address to @kernel to > match the .mailmap entry. > > The servers for @codeaurora are long retired and messages sent there > will bounce. Update Kiran's email address to match the .mailmap entry. > >

Re: [PATCH v2 0/3] backlight: mp3309c: Allow to use on non-OF platforms

2024-02-08 Thread Lee Jones
On Thu, 01 Feb 2024 17:14:12 +0200, Andy Shevchenko wrote: > Allow to use driver on non-OF platforms and other cleanups. > > Changelog v2: > - rename pm3309c_parse_dt_node() --> mp3309c_parse_fwnode() (Daniel) > - add tags (Daniel, Flavio) > - new patch 2 > > [...] Applied, thanks! [1/3]

Re: [PATCH v2] drm/i915: Add GuC submission interface version query

2024-02-08 Thread Souza, Jose
On Thu, 2024-02-08 at 08:25 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Add a new query to the GuC submission interface version. > > Mesa intends to use this information to check for old firmware versions > with a known bug where using the render and compute command streamers >

Re: [PATCH v4 03/14] drm/panthor: Add the device logical block

2024-02-08 Thread Liviu Dudau
Hi Boris, On Mon, Jan 22, 2024 at 05:30:34PM +0100, Boris Brezillon wrote: > The panthor driver is designed in a modular way, where each logical > block is dealing with a specific HW-block or software feature. In order > for those blocks to communicate with each other, we need a central >

Re: [PATCH v4 01/14] drm/panthor: Add uAPI

2024-02-08 Thread Liviu Dudau
Hi Boris, Minor spelling issues to raise in the documentation text uAPI: On Mon, Jan 22, 2024 at 05:30:32PM +0100, Boris Brezillon wrote: > Panthor follows the lead of other recently submitted drivers with > ioctls allowing us to support modern Vulkan features, like sparse memory > binding: > >

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-08 Thread Matthew Auld
On 08/02/2024 13:47, Arunpravin Paneer Selvam wrote: Hi Matthew, On 2/8/2024 7:00 PM, Matthew Auld wrote: On 07/02/2024 17:44, Arunpravin Paneer Selvam wrote: Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the problem

Re: [PATCH i-g-t] benchmarks: Add VKMS benchmark

2024-02-08 Thread Kamil Konieczny
Hi Arthur, On 2024-02-07 at 17:17:15 -0300, Arthur Grillo wrote: > Create a benchmark for the VKMS driver. Use a KMS layout with deliberate > odd sizes to try to avoid alignment accidents and run it for FRAME_COUNT > frames flipping framebuffers in each plane. > > Link:

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-08 Thread Mario Limonciello
On 2/8/2024 06:06, Arunpravin Paneer Selvam wrote: Hi Christian, On 2/8/2024 12:27 PM, Christian König wrote: Am 07.02.24 um 18:44 schrieb Arunpravin Paneer Selvam: Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the

Re: [PATCH] drm/buddy: Fix alloc_range() error handling code

2024-02-08 Thread Arunpravin Paneer Selvam
Hi Matthew, On 2/8/2024 7:00 PM, Matthew Auld wrote: On 07/02/2024 17:44, Arunpravin Paneer Selvam wrote: Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the problem that whenever alloc_range() couldn't find the required

Re: [PATCH 3/5] drm/msm: mdss: Add X1E80100 support

2024-02-08 Thread Abel Vesa
On 24-02-08 15:42:04, Dmitry Baryshkov wrote: > On Thu, 8 Feb 2024 at 15:37, Abel Vesa wrote: > > > > On 24-01-29 17:11:25, Dmitry Baryshkov wrote: > > > On Mon, 29 Jan 2024 at 15:19, Abel Vesa wrote: > > > > > > > > Add support for MDSS on X1E80100. > > > > > > > > Signed-off-by: Abel Vesa > >

  1   2   >