Re: [PATCH v2 13/19] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-02-10 Thread Dmitry Baryshkov
On Sun, 11 Feb 2024 at 06:06, Abhinav Kumar wrote: > > > > On 2/10/2024 1:46 PM, Dmitry Baryshkov wrote: > > On Sat, 10 Feb 2024 at 20:50, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 2/10/2024 10:14 AM, Abhinav Kumar wrote: > >>> > >>> > >>> On 2/10/2024 2:09 AM, Dmitry Baryshkov wrote: >

Re: [PATCH] gpu: drm: display: indent fix in comment

2024-02-10 Thread Randy Dunlap
On 2/8/24 07:20, Kousik Sanagavarapu wrote: > On Thu, Jan 25, 2024 at 12:05:56AM +0530, Kousik Sanagavarapu wrote: >> The comments explaining the function "drm_dp_mst_atom_check_mgr()" had >> uneven indentation which made "make htmldocs" complain: >> >>

Re: [PATCH v2 15/19] drm/msm/dp: enable SDP and SDE periph flush update

2024-02-10 Thread Dmitry Baryshkov
On Sun, 11 Feb 2024 at 06:12, Abhinav Kumar wrote: > > > > On 2/10/2024 2:11 PM, Dmitry Baryshkov wrote: > > On Sat, 10 Feb 2024 at 23:49, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 2/10/2024 2:16 AM, Dmitry Baryshkov wrote: > >>> On Sat, 10 Feb 2024 at 03:52, Paloma Arellano > >>>

Re: [PATCH v4 1/3] drm: Add drm_get_acpi_edid() helper

2024-02-10 Thread Mario Limonciello
On 2/9/2024 12:57, Daniel Vetter wrote: On Fri, Feb 09, 2024 at 09:34:13AM -0600, Mario Limonciello wrote: On 2/9/2024 05:07, Daniel Vetter wrote: On Thu, Feb 08, 2024 at 11:57:11AM +0200, Jani Nikula wrote: On Wed, 07 Feb 2024, Mario Limonciello wrote: Some manufacturers have intentionally

Re: [PATCH v2 15/19] drm/msm/dp: enable SDP and SDE periph flush update

2024-02-10 Thread Abhinav Kumar
On 2/10/2024 2:11 PM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 23:49, Abhinav Kumar wrote: On 2/10/2024 2:16 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: DP controller can be setup to operate in either SDP update flush mode or peripheral

Re: [PATCH v2 13/19] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-02-10 Thread Abhinav Kumar
On 2/10/2024 1:46 PM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 20:50, Abhinav Kumar wrote: On 2/10/2024 10:14 AM, Abhinav Kumar wrote: On 2/10/2024 2:09 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: Add support to pack and send the VSC SDP

Re: [PATCH v2 15/19] drm/msm/dp: enable SDP and SDE periph flush update

2024-02-10 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 23:49, Abhinav Kumar wrote: > > > > On 2/10/2024 2:16 AM, Dmitry Baryshkov wrote: > > On Sat, 10 Feb 2024 at 03:52, Paloma Arellano > > wrote: > >> > >> DP controller can be setup to operate in either SDP update flush mode or > >> peripheral flush mode based on the DP

Re: [PATCH v2 15/19] drm/msm/dp: enable SDP and SDE periph flush update

2024-02-10 Thread Abhinav Kumar
On 2/10/2024 2:16 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: DP controller can be setup to operate in either SDP update flush mode or peripheral flush mode based on the DP controller hardware version. Starting in DP v1.2, the hardware documents

Re: [PATCH v2 13/19] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-02-10 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 20:50, Abhinav Kumar wrote: > > > > On 2/10/2024 10:14 AM, Abhinav Kumar wrote: > > > > > > On 2/10/2024 2:09 AM, Dmitry Baryshkov wrote: > >> On Sat, 10 Feb 2024 at 03:52, Paloma Arellano > >> wrote: > >>> > >>> Add support to pack and send the VSC SDP packet for DP. This

Re: [PATCH v2 19/19] drm/msm/dp: allow YUV420 mode for DP connector when CDM available

2024-02-10 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 21:19, Abhinav Kumar wrote: > > > > On 2/10/2024 3:33 AM, Dmitry Baryshkov wrote: > > On Sat, 10 Feb 2024 at 03:52, Paloma Arellano > > wrote: > >> > >> All the components of YUV420 over DP are added. Therefore, let's mark the > >> connector property as true for DP

[PATCH v3] drm/dp: add an API to indicate if sink supports VSC SDP

2024-02-10 Thread Abhinav Kumar
From: Paloma Arellano YUV420 format is supported only in the VSC SDP packet and not through MSA. Hence add an API which indicates the sink support which can be used by the rest of the DP programming. changes in v3: - fix the commit title prefix to drm/dp - get rid of redundant

Re: [PATCH v2 19/19] drm/msm/dp: allow YUV420 mode for DP connector when CDM available

2024-02-10 Thread Abhinav Kumar
On 2/10/2024 3:33 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: All the components of YUV420 over DP are added. Therefore, let's mark the connector property as true for DP connector when the DP type is not eDP and when there is a CDM block available.

Re: [PATCH v2 13/19] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-02-10 Thread Abhinav Kumar
On 2/10/2024 10:14 AM, Abhinav Kumar wrote: On 2/10/2024 2:09 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: Add support to pack and send the VSC SDP packet for DP. This therefore allows the transmision of format information to the sinks which is needed

Re: [PATCH v4] drm/ci: add tests on vkms

2024-02-10 Thread Maíra Canal
Hi Vignesh, On 2/1/24 03:53, Vignesh Raman wrote: Add job that runs igt on top of vkms. Signed-off-by: Vignesh Raman Acked-by: Jessica Zhang Tested-by: Jessica Zhang Acked-by: Maxime Ripard Signed-off-by: Helen Koike --- v2: - do not mv modules to /lib/modules in the job definition,

Re: [PATCH v3 9/9] drm/ci: uprev IGT and update testlist

2024-02-10 Thread Maíra Canal
On 2/10/24 15:17, Maíra Canal wrote: On 1/30/24 12:03, Vignesh Raman wrote: Uprev IGT and add amd, v3d, vc4 and vgem specific tests to testlist. Have testlist.txt per driver and include a base testlist so that the driver specific tests will run only on those hardware. Signed-off-by: Vignesh

Re: [PATCH v3 9/9] drm/ci: uprev IGT and update testlist

2024-02-10 Thread Maíra Canal
On 1/30/24 12:03, Vignesh Raman wrote: Uprev IGT and add amd, v3d, vc4 and vgem specific tests to testlist. Have testlist.txt per driver and include a base testlist so that the driver specific tests will run only on those hardware. Signed-off-by: Vignesh Raman --- v3: - New patch in series

Re: [PATCH v2 13/19] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-02-10 Thread Abhinav Kumar
On 2/10/2024 2:09 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: Add support to pack and send the VSC SDP packet for DP. This therefore allows the transmision of format information to the sinks which is needed for YUV420 support over DP. Changes in v2:

[drm-misc:for-linux-next 49/49] drivers/gpu/drm/tests/drm_mm_test.c:191:32: error: implicit declaration of function 'drm_debug_printer'; did you mean 'drm_dbg_printer'?

2024-02-10 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: 7edd06233958d9086a9e3eb723a8768d3c5a9ce1 commit: e154c4fc7bf2d5c3f86d07628ab1cb03e8085c25 [49/49] drm: remove drm_debug_printer in favor of drm_dbg_printer config: m68k-allmodconfig

[drm-misc:for-linux-next 40/49] drivers/gpu/drm/xe/xe_guc_submit.c:814:48: error: passing argument 1 of 'drm_err_printer' from incompatible pointer type

2024-02-10 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: 7edd06233958d9086a9e3eb723a8768d3c5a9ce1 commit: 5e0c04c8c40b69ab165d52964433859d8b666376 [40/49] drm/print: make drm_err_printer() device specific by using drm_err() config: loongarch-allmodconfig

Re: [PATCH v2 1/2] dt-bindings: display/msm: gpu: Allow multiple digits for patchid

2024-02-10 Thread David Heidelberg
Reviewed-by: David Heidelberg

Re: [PATCH v2 2/2] drm/msm/adreno: Add A305B support

2024-02-10 Thread David Heidelberg
Reviewed-by: David Heidelberg

Re: [PATCH] drm/xe: Prefer struct_size over open coded arithmetic

2024-02-10 Thread Gustavo A. R. Silva
On 2/10/24 08:19, Erick Archer wrote: This is an effort to get rid of all multiplications from allocation functions in order to prevent integer overflows [1]. As the "q" variable is a pointer to "struct xe_exec_queue" and this structure ends in a flexible array: struct xe_exec_queue {

[PATCH] backlight: ktd2801: make timing struct static

2024-02-10 Thread Duje Mihanović
= { .poweroff_us = 2600, .detect_delay_us = 150, .detect_us = 270, --- base-commit: 66c76c1cd984c14660453dfa2118014817924375 change-id: 20240210-ktd2801-static-e1c23d19600c Best regards, -- Duje Mihanović

RE: Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT

2024-02-10 Thread David Laight
... > >> +#define BIT_U8(b) ((u8)(BIT_INPUT_CHECK(u8, b) + BIT(b))) > >> +#define BIT_U16(b)((u16)(BIT_INPUT_CHECK(u16, b) + > >> BIT(b))) > >> +#define BIT_U32(b)((u32)(BIT_INPUT_CHECK(u32, b) + > >> BIT(b))) > >> +#define BIT_U64(b)

[PATCH] drm/xe: Prefer struct_size over open coded arithmetic

2024-02-10 Thread Erick Archer
This is an effort to get rid of all multiplications from allocation functions in order to prevent integer overflows [1]. As the "q" variable is a pointer to "struct xe_exec_queue" and this structure ends in a flexible array: struct xe_exec_queue { [...] struct xe_lrc lrc[]; };

Re: [PATCH v2 19/19] drm/msm/dp: allow YUV420 mode for DP connector when CDM available

2024-02-10 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: > > All the components of YUV420 over DP are added. Therefore, let's mark the > connector property as true for DP connector when the DP type is not eDP > and when there is a CDM block available. > > Changes in v2: > - Check for if

Re: [PATCH v2 18/19] drm/msm/dpu: reserve CDM blocks for DP if mode is YUV420

2024-02-10 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: > > Reserve CDM blocks for DP if the mode format is YUV420. Currently this > reservation only works for writeback and DP if the format is YUV420. But > this can be easily extented to other YUV formats for DP. > > Changes in v2: > -

Re: [PATCH v2 17/19] drm/msm/dpu: modify timing engine programming for YUV420 over DP

2024-02-10 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: > > Adjust the encoder timing engine setup programming in the case of video > mode for YUV420 over DP to accommodate CDM. > > Changes in v2: > - Move timing engine programming to this patch > > Signed-off-by: Paloma Arellano > --- >

Re: [PATCH v2 15/19] drm/msm/dp: enable SDP and SDE periph flush update

2024-02-10 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: > > DP controller can be setup to operate in either SDP update flush mode or > peripheral flush mode based on the DP controller hardware version. > > Starting in DP v1.2, the hardware documents require the use of > peripheral flush mode for SDP

Re: [PATCH v2 14/19] drm/msm/dpu: add support of new peripheral flush mechanism

2024-02-10 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: > > From: Kuogee Hsieh > > Introduce a peripheral flushing mechanism to decouple peripheral > metadata flushing from timing engine related flush. > > Changes in v2: > - Fixed some misalignment issues > > Signed-off-by: Kuogee Hsieh >

Re: [PATCH v3] drm/panel: st7703: Fix Panel Initialization for Anbernic RG353V-V2

2024-02-10 Thread Guido Günther
Hi, On Sat, Feb 10, 2024 at 01:24:43AM +0100, Ao Zhong wrote: > This patch addresses an issue with the Anbernic RG353V-V2 panel > initialization that was caused by incorrect parameter. The correct > initialization sequence was derived by referencing the JELOS (Just > Enough Linux OS) BSP kernel's

Re: [PATCH v2 13/19] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-02-10 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: > > Add support to pack and send the VSC SDP packet for DP. This therefore > allows the transmision of format information to the sinks which is > needed for YUV420 support over DP. > > Changes in v2: > - Rename GENERIC0_SDPSIZE macro to

Re: [PATCH v2 12/19] drm/msm/dp: move parity calculation to dp_utils

2024-02-10 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: > > Parity calculation is necessary for VSC SDP implementation. Therefore > create new files dp_utils.c and dp_utils.h and move the parity > calculating functions here. This ensures that they are usable by SDP > programming in both dp_catalog.c

Re: [PATCH v2 11/19] drm/msm/dp: change clock related programming for YUV420 over DP

2024-02-10 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: > > Change all relevant DP controller related programming for YUV420 cases. > Namely, change the pixel clock math to consider YUV420 and modify the > MVID programming to consider YUV420. > > Changes in v2: > - Move configuration control

Re: [PATCH v2 02/19] drm/msm/dp: add an API to indicate if sink supports VSC SDP

2024-02-10 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 11:37, Dmitry Baryshkov wrote: > > On Sat, 10 Feb 2024 at 03:53, Paloma Arellano > wrote: > > > > YUV420 format is supported only in the VSC SDP packet and not through > > MSA. Hence add an API which indicates the sink support which can be used > > by the rest of the DP

Re: [PATCH v2 10/19] drm/msm/dp: program config ctrl for YUV420 over DP

2024-02-10 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 03:53, Paloma Arellano wrote: > > Change relevant DP controller related programming for YUV420 cases. > Program the configuration control register to indicate YUV420. > > Changes in v2: > - Create a new patch only for configuration control programming > >

Re: [PATCH v2 08/19] drm/msm/dp: check if VSC SDP is supported in DP programming

2024-02-10 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: > > In the DP driver, check if VSC SDP is supported and propagate this value > to dp_panel. In dp_display's dp_mode, the out_fmt_is_yuv_420 parameter > must also utilize this value since YUV420 is only allowed when VSC SDP > is supported. > >

Re: [PATCH v2 04/19] drm/msm/dpu: allow dpu_encoder_helper_phys_setup_cdm to work for DP

2024-02-10 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: > > Generalize dpu_encoder_helper_phys_setup_cdm to be compatible with DP. > > Changes in v2: > - Minor formatting changes > - Move the modification of the dimesions for CDM setup to a new > patch > > Signed-off-by:

Re: [PATCH v2 03/19] drm/msm/dpu: pass mode dimensions instead of fb size in CDM setup

2024-02-10 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: > > Modify the output width and height parameters of hw_cdm to utilize the > physical encoder's data instead of obtaining the information from the > framebuffer. CDM is to be set up to utilize the actual output data since > at CDM setup, there

Re: [PATCH v2 02/19] drm/msm/dp: add an API to indicate if sink supports VSC SDP

2024-02-10 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 03:53, Paloma Arellano wrote: > > YUV420 format is supported only in the VSC SDP packet and not through > MSA. Hence add an API which indicates the sink support which can be used > by the rest of the DP programming. > > Changes in v2: > - Move VSC SDP support check

Re: [PATCH v2 01/19] drm/msm/dpu: allow certain formats for CDM for DP

2024-02-10 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: > > CDM block supports formats other than H1V2 for DP. Since we are now > adding support for CDM over DP, relax the checks to allow all other > formats for DP other than H1V2. > > Changes in v2: > - Add fixes tag > - Move patch

Re: [PATCH] fbdev/sh7760fb: allow modular build

2024-02-10 Thread John Paul Adrian Glaubitz
On Fri, 2024-02-09 at 21:39 -0800, Randy Dunlap wrote: > There is no reason to prohibit sh7760fb from being built as a > loadable module as suggested by Geert, so change the config symbol > from bool to tristate to allow that and change the FB dependency as > needed. > > Fixes: f75f71b2c418

Re: [PATCH] fbdev/sh7760fb: allow modular build

2024-02-10 Thread Javier Martinez Canillas
Randy Dunlap writes: > There is no reason to prohibit sh7760fb from being built as a > loadable module as suggested by Geert, so change the config symbol > from bool to tristate to allow that and change the FB dependency as > needed. > > Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y") >

Re: [PATCH v4 07/14] drm/panthor: Add the MMU/VM logical block

2024-02-10 Thread Boris Brezillon
Hi Steve, On Fri, 9 Feb 2024 16:51:46 + Steven Price wrote: > On 22/01/2024 16:30, Boris Brezillon wrote: > > MMU and VM management is related and placed in the same source file. > > > > Page table updates are delegated to the io-pgtable-arm driver that's in > > the iommu subsystem. > > >