Re: (subset) [PATCH 0/3] drm/panel: Pixel 3a Panel

2024-03-18 Thread Bjorn Andersson
On Thu, 08 Feb 2024 19:16:41 -0500, Richard Acayan wrote: > This adds support for the AMS559NK06 panel with the S6E3FA7 display > controller and enables the display subsystem on the Pixel 3a. > > Richard Acayan (3): > dt-bindings: display: panel-simple-dsi: add s6e3fa7 ams559nk06 compat >

Re: [PATCH v2 3/4] drm/msm/dp: Delete the old 500 ms wait for eDP HPD in aux transfer

2024-03-18 Thread Dmitry Baryshkov
On Tue, 19 Mar 2024 at 02:19, Abhinav Kumar wrote: > > +bjorn, johan as fyi for sc8280xp > > On 3/15/2024 2:36 PM, Douglas Anderson wrote: > > Before the introduction of the wait_hpd_asserted() callback in commit > > 841d742f094e ("drm/dp: Add wait_hpd_asserted() callback to struct > >

Re: [PATCH v2 5/8] drm: xlnx: zynqmp_dpsub: Set input live format

2024-03-18 Thread Laurent Pinchart
Hi Anatoliy, Thank you for the patch. On Tue, Mar 12, 2024 at 05:55:02PM -0700, Anatoliy Klymenko wrote: > Program live video input format according to selected media bus format. > > In the bridge mode of operation, DPSUB is connected to FPGA CRTC which > almost certainly supports a single

Re: [PATCH v2 4/4] drm/msm/dp: Fix typo in static function (ststus => status)

2024-03-18 Thread Abhinav Kumar
On 3/18/2024 12:37 PM, Doug Anderson wrote: Hi, On Mon, Mar 18, 2024 at 12:26 PM Stephen Boyd wrote: Quoting Douglas Anderson (2024-03-15 14:36:32) This is a no-op change to just fix a typo in the name of a static function. Signed-off-by: Douglas Anderson --- Changes in v2: - ("Fix

Re: [PATCH v2 3/4] drm/msm/dp: Delete the old 500 ms wait for eDP HPD in aux transfer

2024-03-18 Thread Abhinav Kumar
+bjorn, johan as fyi for sc8280xp On 3/15/2024 2:36 PM, Douglas Anderson wrote: Before the introduction of the wait_hpd_asserted() callback in commit 841d742f094e ("drm/dp: Add wait_hpd_asserted() callback to struct drm_dp_aux") the API between panel drivers and DP AUX bus drivers was that it

Re: [PATCH v2 4/8] drm: xlnx: zynqmp_dpsub: Minimize usage of global flag

2024-03-18 Thread Laurent Pinchart
Hi Anatoliy, Thank you for the patch. On Tue, Mar 12, 2024 at 05:55:01PM -0700, Anatoliy Klymenko wrote: > Avoid usage of global zynqmp_dpsub.dma_enabled flag in DPSUB layer > context. This flag signals whether the driver runs in DRM CRTC or DRM > bridge mode, assuming that all display layers

Re: [PATCH v2 3/8] drm: xlnx: zynqmp_dpsub: Anounce supported input formats

2024-03-18 Thread Laurent Pinchart
Hi Anatoliy, Thank you for the patch. On Tue, Mar 12, 2024 at 05:55:00PM -0700, Anatoliy Klymenko wrote: > DPSUB in bridge mode supports multiple input media bus formats. > > Announce the list of supported input media bus formats via > drm_bridge.atomic_get_input_bus_fmts callback. > Introduce

[PATCH] video: fbdev: au1200fb: replace deprecated strncpy with strscpy

2024-03-18 Thread Justin Stitt
strscpy(fbi->fix.id, "AU1200"); fbi->fix.smem_start = fbdev->fb_phys; fbi->fix.smem_len = fbdev->fb_len; fbi->fix.type = FB_TYPE_PACKED_PIXELS; --- base-commit: bf3a69c6861ff4dc7892d895c87074af7bc1c400 change-id: 20240318-strncpy-drivers-video-fbdev-au1200fb-c-7bc337998096 Best regards, -- Justin Stitt

[PATCH] software node: Implement device_get_match_data fwnode callback

2024-03-18 Thread Sui Jingfeng
This makes it possible to support (and/or test) a few drivers that originates from DT World on the x86-64 platform. Originally, those drivers using the of_device_get_match_data() function to get match data. For example, drivers/gpu/drm/bridge/simple-bridge.c and

Re: [PATCH v2 2/8] drm: xlnx: zynqmp_dpsub: Update live format defines

2024-03-18 Thread Laurent Pinchart
Hi Anatoliy, Thank you for the patch. On Tue, Mar 12, 2024 at 05:54:59PM -0700, Anatoliy Klymenko wrote: > Update live format defines to match DPSUB AV_BUF_LIVE_VID_CONFIG register > layout. > > Signed-off-by: Anatoliy Klymenko Reviewed-by: Laurent Pinchart > --- >

Re: [01/43] drm/fbdev-generic: Do not set physical framebuffer address

2024-03-18 Thread Sui Jingfeng
Hi, On 2024/3/12 23:44, Thomas Zimmermann wrote: Framebuffer memory is allocated via vmalloc() from non-contiguous physical pages. The physical framebuffer start address is therefore meaningless. Do not set it. The value is not used within the kernel and only exported to userspace on

[PATCH v9 3/3] drm/tests: Add a test case for drm buddy clear allocation

2024-03-18 Thread Arunpravin Paneer Selvam
Add a new test case for the drm buddy clear and dirty allocation. Signed-off-by: Arunpravin Paneer Selvam Suggested-by: Matthew Auld --- drivers/gpu/drm/tests/drm_buddy_test.c | 127 + 1 file changed, 127 insertions(+) diff --git

[PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-18 Thread Arunpravin Paneer Selvam
Add clear page support in vram memory region. v1(Christian): - Dont handle clear page as TTM flag since when moving the BO back in from GTT again we don't need that. - Make a specialized version of amdgpu_fill_buffer() which only clears the VRAM areas which are not already cleared -

[PATCH v9 1/3] drm/buddy: Implement tracking clear page feature

2024-03-18 Thread Arunpravin Paneer Selvam
- Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. - Track the available cleared pages size - If driver requests cleared memory we prefer cleared

Re: [PATCH 2/2] drm/panel: simple: Add POWERTIP PH128800T006-ZHC01 panel entry

2024-03-18 Thread Jessica Zhang
On 3/18/2024 9:17 AM, Nathan Morrisson wrote: Add support for the POWERTIP PH128800T006-ZHC01 10.1" (1280x800) LCD-TFT panel. Signed-off-by: Nathan Morrisson Hi Nathan, Acked-by: Jessica Zhang Thanks, Jessica Zhang --- drivers/gpu/drm/panel/panel-simple.c | 29

[PATCH 0/2] Add POWERTIP PH128800T006-ZHC01 panel

2024-03-18 Thread Nathan Morrisson
Add the device tree bindings, timings, and compatible string for the POWERTIP PH128800T006-ZHC01 panel. Nathan Morrisson (2): dt-bindings: display: simple: Add POWERTIP PH128800T-006-ZHC01 panel drm/panel: simple: Add POWERTIP PH128800T006-ZHC01 panel entry

[PATCH 1/2] dt-bindings: display: simple: Add POWERTIP PH128800T-006-ZHC01 panel

2024-03-18 Thread Nathan Morrisson
Add POWERTIP PH128800T-006-ZHC01 10.1" LCD-TFT LVDS panel compatible string. Signed-off-by: Nathan Morrisson --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH 2/2] drm/panel: simple: Add POWERTIP PH128800T006-ZHC01 panel entry

2024-03-18 Thread Nathan Morrisson
Add support for the POWERTIP PH128800T006-ZHC01 10.1" (1280x800) LCD-TFT panel. Signed-off-by: Nathan Morrisson --- drivers/gpu/drm/panel/panel-simple.c | 29 1 file changed, 29 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c

[PATCH 2/3] drm/bridge: analogix_dp: simplify analogix_dp_{set/get}_lane_link_training helpers

2024-03-18 Thread Lucas Stach
From: Wyon Bi There is no need for separate functions for each lane, as we can deduct the register offset to read/write from the lane index. Signed-off-by: Wyon Bi Signed-off-by: Lucas Stach --- .../drm/bridge/analogix/analogix_dp_core.c| 97 ++-

[PATCH 3/3] drm/bridge: analogix_dp: don't adjust further when clock recovery succeeded

2024-03-18 Thread Lucas Stach
Take a early return from the clock recovery training when the sink reports CR_DONE for all lanes. There is no point in trying to adjust the link parameters further. Signed-off-by: Lucas Stach --- .../drm/bridge/analogix/analogix_dp_core.c| 58 +-- 1 file changed, 29

[PATCH 1/3] drm/bridge: analogix_dp: properly handle zero sized AUX transactions

2024-03-18 Thread Lucas Stach
Address only transactions without any data are valid and should not be flagged as short transactions. Simply return the message size when no transaction errors occured. CC: sta...@vger.kernel.org Signed-off-by: Lucas Stach --- drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 5 + 1 file

Re: [PATCH] drm/i915/gt: Reset queue_priority_hint on parking

2024-03-18 Thread Rodrigo Vivi
On Mon, Mar 18, 2024 at 02:58:47PM +0100, Janusz Krzysztofik wrote: > From: Chris Wilson > > Originally, with strict in order execution, we could complete execution > only when the queue was empty. Preempt-to-busy allows replacement of an > active request that may complete before the preemption

Re: [PATCH v2 4/4] drm/msm/dp: Fix typo in static function (ststus => status)

2024-03-18 Thread Doug Anderson
Hi, On Mon, Mar 18, 2024 at 12:26 PM Stephen Boyd wrote: > > Quoting Douglas Anderson (2024-03-15 14:36:32) > > This is a no-op change to just fix a typo in the name of a static function. > > > > Signed-off-by: Douglas Anderson > > --- > > > > Changes in v2: > > - ("Fix typo in static function

Re: [PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-18 Thread Sui Jingfeng
On 2024/3/19 03:23, Sui Jingfeng wrote: 2) It should be exist at product level kernel. It should NOT be exist at product level kernel. -- Best regards, Sui

Re: [PATCH v2 4/4] drm/msm/dp: Fix typo in static function (ststus => status)

2024-03-18 Thread Stephen Boyd
Quoting Douglas Anderson (2024-03-15 14:36:32) > This is a no-op change to just fix a typo in the name of a static function. > > Signed-off-by: Douglas Anderson > --- > > Changes in v2: > - ("Fix typo in static function (ststus => status)") new for v2. This was sent at

Re: [PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-18 Thread Sui Jingfeng
Hi, On 2024/3/19 02:04, Laurent Pinchart wrote: Improving core helpers is certainly a good idea, and if we do so, we can simplify drivers. What I'm concerned is that commit 00084f0c01bf creates a silent probe failure path, No, I can't agree here. It doesn't creates a silent probe failure

Re: [PATCH] drm/tilcdc: Set preferred depth

2024-03-18 Thread Frej Drejhammar
Hi, Kevin Kevin Hao writes: > I had also thought about a similar modification before, but personally, > I considered such changes a bit aggressive for a patch that needs to be > backported to a stable kernel (especially for a LTS kernel such as v6.6 > which I am working on). That's why I opted

drm/tiny: QUESTION: What to use instead of drm_simple_display_pipe ?

2024-03-18 Thread Mehdi Djait
Hello everyone :) I am implementing a tiny drm driver and I am currently working on the V2: https://lore.kernel.org/dri-devel/cover.1701267411.git.mehdi.dj...@bootlin.com/ I got a review on the v1 telling me not to use the drm_simple_display_pipe. Can someone please explain this further ? Or

Re: [PATCH v2] fbmon: prevent division by zero in fb_videomode_from_videomode()

2024-03-18 Thread Helge Deller
On 3/18/24 09:11, Roman Smirnov wrote: On Fri, 15 Mar 2024 09:44:08 +0100 Helge Deller wrote: On 3/5/24 14:51, Roman Smirnov wrote: The expression htotal * vtotal can have a zero value on overflow. I'm not sure if those always results in zero in kernel on overflow. Might be

Re: [PATCH 6/6] drm: zynqmp_dp: Add debugfs interface for compliance testing

2024-03-18 Thread Sean Anderson
On 3/18/24 13:50, Laurent Pinchart wrote: > On Mon, Mar 18, 2024 at 11:06:40AM -0400, Sean Anderson wrote: >> On 3/16/24 06:14, kernel test robot wrote: >> > Hi Sean, >> > >> > kernel test robot noticed the following build warnings: >> > >> > [auto build test WARNING on v6.8] >> > [cannot apply

Re: [PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-18 Thread Sui Jingfeng
Hi, On 2024/3/19 02:04, Laurent Pinchart wrote: Hi Sui, On Tue, Mar 19, 2024 at 12:42:41AM +0800, Sui Jingfeng wrote: On 2024/3/19 00:06, Laurent Pinchart wrote: Commit 00084f0c01bf ("drm: bridge: thc63lvd1024: Switch to use of_graph_get_remote_node()") simplified the thc63lvd1024 driver by

Re: [PATCH v2 2/4] drm/msm/dp: Account for the timeout in wait_hpd_asserted() callback

2024-03-18 Thread Abhinav Kumar
On 3/15/2024 2:36 PM, Douglas Anderson wrote: The DP wait_hpd_asserted() callback is passed a timeout which indicates how long we should wait for HPD. This timeout was being ignored in the MSM DP implementation and instead a hardcoded 500 ms timeout was used. Fix it to use the proper timeout.

Re: [PATCH v2 1/4] drm/msm/dp: Avoid a long timeout for AUX transfer if nothing connected

2024-03-18 Thread Abhinav Kumar
On 3/15/2024 2:36 PM, Douglas Anderson wrote: As documented in the description of the transfer() function of "struct drm_dp_aux", the transfer() function can be called at any time regardless of the state of the DP port. Specifically if the kernel has the DP AUX character device enabled and

Re: [PATCH 5/6] drm: zynqmp_dp: Optionally ignore DPCD errors

2024-03-18 Thread Sean Anderson
On 3/18/24 13:47, Laurent Pinchart wrote: > Hi Sean, > > Thank you for the patch. > > On Fri, Mar 15, 2024 at 07:09:15PM -0400, Sean Anderson wrote: >> When testing, it's convenient to be able to ignore DPCD errors if there >> is test equipment which can't emulate a DPRX connected to the output.

Re: [PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-18 Thread Laurent Pinchart
Hi Sui, On Tue, Mar 19, 2024 at 12:42:41AM +0800, Sui Jingfeng wrote: > On 2024/3/19 00:06, Laurent Pinchart wrote: > > Commit 00084f0c01bf ("drm: bridge: thc63lvd1024: Switch to use > > of_graph_get_remote_node()") simplified the thc63lvd1024 driver by > > replacing hand-rolled code with a

Re: [PATCH 3/6] drm: zynqmp_dp: Add locking

2024-03-18 Thread Sean Anderson
On 3/18/24 13:59, Laurent Pinchart wrote: > Hi Sean, > > On Mon, Mar 18, 2024 at 01:29:12PM -0400, Sean Anderson wrote: >> On 3/18/24 13:16, Laurent Pinchart wrote: >> > On Fri, Mar 15, 2024 at 07:09:13PM -0400, Sean Anderson wrote: >> >> Add some locking, since none is provided by the drm

Re: [PATCH] drm/msm/dp: move link_ready out of HPD event thread

2024-03-18 Thread Abhinav Kumar
On 3/15/2024 8:57 AM, Johan Hovold wrote: On Thu, Mar 14, 2024 at 09:30:57AM -0700, Abhinav Kumar wrote: On 3/14/2024 8:38 AM, Johan Hovold wrote: On Wed, Mar 13, 2024 at 10:24:08AM -0700, Abhinav Kumar wrote: Perhaps I'm missing something in the race that you are trying to describe (and

Re: [PATCH 3/6] drm: zynqmp_dp: Add locking

2024-03-18 Thread Laurent Pinchart
Hi Sean, On Mon, Mar 18, 2024 at 01:29:12PM -0400, Sean Anderson wrote: > On 3/18/24 13:16, Laurent Pinchart wrote: > > On Fri, Mar 15, 2024 at 07:09:13PM -0400, Sean Anderson wrote: > >> Add some locking, since none is provided by the drm subsystem. This will > > > > That's not quite right, the

Re: [PATCH 6/6] drm: zynqmp_dp: Add debugfs interface for compliance testing

2024-03-18 Thread Laurent Pinchart
On Sat, Mar 16, 2024 at 07:56:52PM +0200, Dmitry Baryshkov wrote: > On Sat, 16 Mar 2024 at 01:09, Sean Anderson wrote: > > > > Add a debugfs interface for exercising the various test modes supported > > by the DisplayPort controller. This allows performing compliance > > testing, or performing

Re: [PATCH 6/6] drm: zynqmp_dp: Add debugfs interface for compliance testing

2024-03-18 Thread Laurent Pinchart
On Mon, Mar 18, 2024 at 11:06:40AM -0400, Sean Anderson wrote: > On 3/16/24 06:14, kernel test robot wrote: > > Hi Sean, > > > > kernel test robot noticed the following build warnings: > > > > [auto build test WARNING on v6.8] > > [cannot apply to drm-misc/drm-misc-next linus/master

Re: [PATCH 5/6] drm: zynqmp_dp: Optionally ignore DPCD errors

2024-03-18 Thread Laurent Pinchart
Hi Sean, Thank you for the patch. On Fri, Mar 15, 2024 at 07:09:15PM -0400, Sean Anderson wrote: > When testing, it's convenient to be able to ignore DPCD errors if there > is test equipment which can't emulate a DPRX connected to the output. > Add some (currently-unused) options to ignore these

Re: [PATCH 4/6] drm: zynqmp_dp: Split off several helper functions

2024-03-18 Thread Laurent Pinchart
Hi Sean, Thank you for the patch. On Fri, Mar 15, 2024 at 07:09:14PM -0400, Sean Anderson wrote: > In preparation for supporting compliance testing, split off several > helper functions. No functional change intended. > > Signed-off-by: Sean Anderson > --- > >

Re: [PATCH 3/6] drm: zynqmp_dp: Add locking

2024-03-18 Thread Sean Anderson
On 3/18/24 13:16, Laurent Pinchart wrote: > Hi Sean, > > Thank you for the patch. > > On Fri, Mar 15, 2024 at 07:09:13PM -0400, Sean Anderson wrote: >> Add some locking, since none is provided by the drm subsystem. This will > > That's not quite right, the DRM core doesn't call bridge

Re: [PATCH 3/6] drm: zynqmp_dp: Add locking

2024-03-18 Thread Laurent Pinchart
Hi Sean, Thank you for the patch. On Fri, Mar 15, 2024 at 07:09:13PM -0400, Sean Anderson wrote: > Add some locking, since none is provided by the drm subsystem. This will That's not quite right, the DRM core doesn't call bridge operations concurrently. We may need locking to protect against

Re: [PATCH 07/43] fbdev/deferred-io: Provide get_page hook in struct fb_deferred_io

2024-03-18 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Add a callback for drivers to provide framebuffer pages to fbdev's > deferred-I/O helpers. Implementations need to acquire a reference on > the page before returning it. Returning NULL generates a SIGBUS > signal. > > This will be useful for DRM's fbdev emulation with

Re: [PATCH 2/6] drm: zynqmp_dp: Adjust training values per-lane

2024-03-18 Thread Laurent Pinchart
Hi Sean, Thank you for the patch. On Fri, Mar 15, 2024 at 07:09:12PM -0400, Sean Anderson wrote: > The feedback we get from the DPRX is per-lane. Make changes using this > information, instead of picking the maximum values from all lanes. This > results in more-consistent training on marginal

Re: [PATCH 06/43] fbdev/deferred-io: Always call get_page() for framebuffer pages

2024-03-18 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Unconditionally call get_page() after looking up a page from the > framebuffer memory. Guarantees that we always hold a reference. > > This change also refactors the code such that it can support a > driver-supplied get_page helper. This will be useful for DRM's >

Re: [PATCH 05/43] fbdev/deferred-io: Test smem_start for I/O memory

2024-03-18 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Test smem_start before looking up pages from its value. Return > NULL if it is unset. This will result in a SIGBUS signal. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms

Re: [PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-18 Thread Sui Jingfeng
Hi, On 2024/3/19 00:06, Laurent Pinchart wrote: Commit 00084f0c01bf ("drm: bridge: thc63lvd1024: Switch to use of_graph_get_remote_node()") simplified the thc63lvd1024 driver by replacing hand-rolled code with a helper function. [...] While doing so, it created an error code path at

Re: [PATCH 1/6] drm: zynqmp_dp: Downgrade log level for aux retries message

2024-03-18 Thread Laurent Pinchart
Hi Sean, Thank you for the patch. On Fri, Mar 15, 2024 at 07:09:11PM -0400, Sean Anderson wrote: > Enable this message for verbose debugging only as it is otherwise > printed after every AUX message, quickly filling the log buffer. > > Signed-off-by: Sean Anderson > --- > >

Re: [PATCH v6 1/3] dt-bindings: display: add STM32 LVDS device

2024-03-18 Thread Yannick FERTRE
Hi Raphael, thanks for the patch. Acked-by: Yannick Fertre Best regards On 2/26/24 11:48, Raphael Gallais-Pou wrote: Add "st,stm32mp25-lvds" compatible. Signed-off-by: Raphael Gallais-Pou Reviewed-by: Conor Dooley --- Depends on: "dt-bindings: stm32: add clocks and reset binding for

Re: [PATCH 1/2] dt-bindings: display: simple: Add POWERTIP PH128800T-006-ZHC01 panel

2024-03-18 Thread Krzysztof Kozlowski
On 18/03/2024 17:17, Nathan Morrisson wrote: > Add POWERTIP PH128800T-006-ZHC01 10.1" LCD-TFT LVDS panel compatible > string. > > Signed-off-by: Nathan Morrisson > --- > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by:

Re: [PATCH] drm/Makefile: Move tiny drivers before native drivers

2024-03-18 Thread Thomas Zimmermann
Hi Am 18.03.24 um 16:42 schrieb Jaak Ristioja: Hi Huacai, Uh, no, sorry, I did not get to test such changes. From what Thomas wrote I presumed that this got fixed and no further action would be required. Right. We reverted the problematic patch and the issue should be gone now. Best

Re: [PATCH v2] drm/panthor: Fix the CONFIG_PM=n case

2024-03-18 Thread AngeloGioacchino Del Regno
Il 18/03/24 16:31, Boris Brezillon ha scritto: Putting a hard dependency on CONFIG_PM is not possible because of a circular dependency issue, and it's actually not desirable either. In order to support this use case, we forcibly resume at init time, and suspend at unplug time. v2: - Drop the

Re: [PATCH v9 20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-18 Thread Ville Syrjälä
On Mon, Mar 18, 2024 at 02:49:47PM +0100, Maxime Ripard wrote: > Hi, > > On Fri, Mar 15, 2024 at 10:22:05AM +0200, Ville Syrjälä wrote: > > On Mon, Mar 11, 2024 at 03:49:48PM +0100, Maxime Ripard wrote: > > > Infoframes in KMS is usually handled by a bunch of low-level helpers > > > that require

Re: [PATCH v6 2/3] drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver

2024-03-18 Thread Yannick FERTRE
Hi Raphael, thanks for the patch. Acked-by: Yannick Fertre Best regards On 2/26/24 11:48, Raphael Gallais-Pou wrote: The Low-Voltage Differential Signaling (LVDS) Display Interface Transmitter handles the LVDS protocol: it maps the pixels received from the upstream Pixel-DMA LCD-TFT Display

Re: [PATCH v2] drm/panthor: Fix the CONFIG_PM=n case

2024-03-18 Thread Steven Price
On 18/03/2024 15:31, Boris Brezillon wrote: > Putting a hard dependency on CONFIG_PM is not possible because of a > circular dependency issue, and it's actually not desirable either. In > order to support this use case, we forcibly resume at init time, and > suspend at unplug time. > > v2: > -

[PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-18 Thread Laurent Pinchart
Commit 00084f0c01bf ("drm: bridge: thc63lvd1024: Switch to use of_graph_get_remote_node()") simplified the thc63lvd1024 driver by replacing hand-rolled code with a helper function. While doing so, it created an error code path at probe time without any error message, potentially causing probe

Re: [PATCH] drm: bridge: thc63lvd1024: Switch to use of_graph_get_remote_node()

2024-03-18 Thread Sui Jingfeng
Hi, On 2024/3/18 23:57, Laurent Pinchart wrote: On Mon, Mar 18, 2024 at 11:53:11PM +0800, Sui Jingfeng wrote: On 2024/3/18 23:33, Laurent Pinchart wrote: On Sun, Mar 17, 2024 at 01:28:00AM +0800, Sui Jingfeng wrote: To reduce boilerplate, use of_graph_get_remote_node() helper instead of the

Re: [PATCH] drm: bridge: thc63lvd1024: Switch to use of_graph_get_remote_node()

2024-03-18 Thread Laurent Pinchart
On Mon, Mar 18, 2024 at 11:53:11PM +0800, Sui Jingfeng wrote: > On 2024/3/18 23:33, Laurent Pinchart wrote: > > On Sun, Mar 17, 2024 at 01:28:00AM +0800, Sui Jingfeng wrote: > >> To reduce boilerplate, use of_graph_get_remote_node() helper instead of > >> the hand-rolling code. > >> > >>

Re: [PATCH] drm: bridge: thc63lvd1024: Switch to use of_graph_get_remote_node()

2024-03-18 Thread Sui Jingfeng
Hi, On 2024/3/18 23:33, Laurent Pinchart wrote: Hi Sui, Thank you for the patch. On Sun, Mar 17, 2024 at 01:28:00AM +0800, Sui Jingfeng wrote: To reduce boilerplate, use of_graph_get_remote_node() helper instead of the hand-rolling code. Signed-off-by: Sui Jingfeng ---

Re: [PATCH] drm/Makefile: Move tiny drivers before native drivers

2024-03-18 Thread Jaak Ristioja
Hi Huacai, Uh, no, sorry, I did not get to test such changes. From what Thomas wrote I presumed that this got fixed and no further action would be required. To speed things up I would appreciate it if you provided a patch. As I worked around the problem for the end user by changing the

Re: [PATCH] drm: bridge: thc63lvd1024: Switch to use of_graph_get_remote_node()

2024-03-18 Thread Laurent Pinchart
Hi Sui, Thank you for the patch. On Sun, Mar 17, 2024 at 01:28:00AM +0800, Sui Jingfeng wrote: > To reduce boilerplate, use of_graph_get_remote_node() helper instead of > the hand-rolling code. > > Signed-off-by: Sui Jingfeng > --- > drivers/gpu/drm/bridge/thc63lvd1024.c | 24

Re: [PATCH v4] Fix divide-by-zero regression on DP MST unplug with nouveau

2024-03-18 Thread Imre Deak
On Sat, Mar 16, 2024 at 12:05:59PM +, Chris Bainbridge wrote: > Fix a regression when using nouveau and unplugging a StarTech MSTDP122DP > DisplayPort 1.2 MST hub (the same regression does not appear when using > a Cable Matters DisplayPort 1.4 MST hub). Trace: Thanks for the report and fix,

[PATCH v2] drm/panthor: Fix the CONFIG_PM=n case

2024-03-18 Thread Boris Brezillon
Putting a hard dependency on CONFIG_PM is not possible because of a circular dependency issue, and it's actually not desirable either. In order to support this use case, we forcibly resume at init time, and suspend at unplug time. v2: - Drop the #ifdef CONFIG_PM section around panthor_pm_ops's

Re: [PATCH 2/5] drm/gem: Add a mountpoint parameter to drm_gem_object_init()

2024-03-18 Thread Tvrtko Ursulin
On 18/03/2024 15:05, Christian König wrote: Am 18.03.24 um 15:24 schrieb Maíra Canal: Not that the CC list wasn't big enough, but I'm adding MM folks in the CC list. On 3/18/24 11:04, Christian König wrote: Am 18.03.24 um 14:28 schrieb Maíra Canal: Hi Christian, On 3/18/24 10:10,

Re: [PATCH] drm/panthor: Don't use virt_to_pfn()

2024-03-18 Thread Boris Brezillon
On Mon, 18 Mar 2024 15:11:42 + Robin Murphy wrote: > On 18/03/2024 2:51 pm, Steven Price wrote: > > virt_to_pfn() isn't available on x86 (except to xen) so breaks > > COMPILE_TEST builds. Avoid its use completely by instead storing the > > struct page pointer allocated in

Re: [PATCH] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE

2024-03-18 Thread Jani Nikula
On Mon, 18 Mar 2024, "Luca Weiss" wrote: > Would you know the correct fix for this? I'm aware of the pattern > "select FOO || !FOO" but I guess it's also not applicable here? I don't think that pattern works for select, only for depends on. And I think the problem, again, is the abuse of select

Re: [PATCH] drm: bridge: thc63lvd1024: Switch to use of_graph_get_remote_node()

2024-03-18 Thread Neil Armstrong
Hi, On Sun, 17 Mar 2024 01:28:00 +0800, Sui Jingfeng wrote: > To reduce boilerplate, use of_graph_get_remote_node() helper instead of > the hand-rolling code. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] drm: bridge: thc63lvd1024: Switch to

Re: [PATCH] drm: bridge: dw_hdmi: Switch to of_graph_get_remote_node()

2024-03-18 Thread Neil Armstrong
Hi, On Sun, 17 Mar 2024 01:05:13 +0800, Sui Jingfeng wrote: > To reduce boilerplate, use of_graph_get_remote_node() helper instead of > the hand-rolling code. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] drm: bridge: dw_hdmi: Switch to

Re: [PATCH] drm/bridge: it66121: Remove a duplicated invoke of of_device_is_available()

2024-03-18 Thread Neil Armstrong
Hi, On Sun, 17 Mar 2024 01:44:19 +0800, Sui Jingfeng wrote: > The calling of of_device_is_available() in it66121_probe() is duplicated, > as the of_graph_get_remote_node() has already do the check for us. There > is no need to call it again, thus delete the later one. > > Thanks, Applied to

Re: [PATCH] drm/bridge: ite66121: Register HPD interrupt handler only when 'client->irq > 0'

2024-03-18 Thread Neil Armstrong
Hi, On Sun, 17 Mar 2024 00:05:36 +0800, Sui Jingfeng wrote: > If a specific design doesn't wire IT66121's interrupt signal output pin up > to the display controller side, then we should not register the interrupt > handler. Such a decision is valid usage, as we can fall back to polling > mode.

Re: [PATCH 6/6] drm: zynqmp_dp: Add debugfs interface for compliance testing

2024-03-18 Thread Sean Anderson
On 3/16/24 13:56, Dmitry Baryshkov wrote: > On Sat, 16 Mar 2024 at 01:09, Sean Anderson wrote: >> >> Add a debugfs interface for exercising the various test modes supported >> by the DisplayPort controller. This allows performing compliance >> testing, or performing signal integrity measurements

Re: [PATCH 3/6] drm: zynqmp_dp: Add locking

2024-03-18 Thread Sean Anderson
On 3/16/24 05:52, kernel test robot wrote: > Hi Sean, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on v6.8] > [also build test WARNING on linus/master next-20240315] > [cannot apply to drm-misc/drm-misc-next] > [If your patch is applied to the wrong

Re: [PATCH] drm/panel: ilitek-ili9881c: Fix warning with GPIO controllers that sleep

2024-03-18 Thread Neil Armstrong
Hi, On Sun, 17 Mar 2024 17:48:39 +0200, Laurent Pinchart wrote: > The ilitek-ili9881c controls the reset GPIO using the non-sleeping > gpiod_set_value() function. This complains loudly when the GPIO > controller needs to sleep. As the caller can sleep, use > gpiod_set_value_cansleep() to fix the

Re: [PATCH 0/2] drm/panel: Add Startek KD050HDFIA020-C020A support

2024-03-18 Thread Neil Armstrong
Hi, On Sun, 17 Mar 2024 17:57:44 +0200, Laurent Pinchart wrote: > This small series adds support for the Startek KD050HDFIA020-C020A panel > to the ilitek-ili9881c driver. There's not much special here, patch 1/2 > addresses the DT binding and patch 2/2 the driver. Please see individual > patches

Re: [PATCH] drm/panthor: Don't use virt_to_pfn()

2024-03-18 Thread Robin Murphy
On 18/03/2024 2:51 pm, Steven Price wrote: virt_to_pfn() isn't available on x86 (except to xen) so breaks COMPILE_TEST builds. Avoid its use completely by instead storing the struct page pointer allocated in panthor_device_init() and using page_to_pfn() instead. Signed-off-by: Steven Price ---

Re: [PATCH] drm/panthor: Don't use virt_to_pfn()

2024-03-18 Thread Boris Brezillon
On Mon, 18 Mar 2024 14:51:19 + Steven Price wrote: > virt_to_pfn() isn't available on x86 (except to xen) so breaks > COMPILE_TEST builds. Avoid its use completely by instead storing the > struct page pointer allocated in panthor_device_init() and using > page_to_pfn() instead. > >

Re: [PATCH 6/6] drm: zynqmp_dp: Add debugfs interface for compliance testing

2024-03-18 Thread Sean Anderson
On 3/16/24 06:55, kernel test robot wrote: > Hi Sean, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on v6.8] > [cannot apply to drm-misc/drm-misc-next linus/master next-20240315] > [If your patch is applied to the wrong git tree, kindly drop us a note. >

Re: [PATCH 6/6] drm: zynqmp_dp: Add debugfs interface for compliance testing

2024-03-18 Thread Sean Anderson
On 3/16/24 06:14, kernel test robot wrote: > Hi Sean, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on v6.8] > [cannot apply to drm-misc/drm-misc-next linus/master next-20240315] > [If your patch is applied to the wrong git tree, kindly drop us a note.

Re: [PATCH 2/5] drm/gem: Add a mountpoint parameter to drm_gem_object_init()

2024-03-18 Thread Christian König
Am 18.03.24 um 15:24 schrieb Maíra Canal: Not that the CC list wasn't big enough, but I'm adding MM folks in the CC list. On 3/18/24 11:04, Christian König wrote: Am 18.03.24 um 14:28 schrieb Maíra Canal: Hi Christian, On 3/18/24 10:10, Christian König wrote: Am 18.03.24 um 13:42 schrieb

Re: [PATCH] Revert "drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE"

2024-03-18 Thread Neil Armstrong
Hi, On Mon, 18 Mar 2024 15:16:21 +0100, Neil Armstrong wrote: > This reverts commit e3f18b0dd1db242791afbc3bd173026163ce0ccc. > > Selecting DRM_KMS_HELPER for DRM_PANEL_BRIDGE leads to: > WARNING: unmet direct dependencies detected for DRM_KMS_HELPER > Depends on [m]: HAS_IOMEM [=y] && DRM

[drm-misc:for-linux-next-fixes 1/1] ld.lld: error: undefined symbol: __drm_dev_dbg

2024-03-18 Thread kernel test robot
/20240318/202403182236.bedkbjub-...@intel.com/config) compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 8f68022f8e6e54d1aeae4ed301f5a015963089b7) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240318/202403182236.bedkbjub-...@intel.com/reproduce

[drm-misc:for-linux-next-fixes 1/1] undefined reference to `__drm_dev_dbg'

2024-03-18 Thread kernel test robot
/20240318/202403182243.do4x1bo0-...@intel.com/config) compiler: hppa-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240318/202403182243.do4x1bo0-...@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version

Re: [PATCH] drm/panthor: Fix the CONFIG_PM=n case

2024-03-18 Thread Steven Price
On 18/03/2024 14:49, Boris Brezillon wrote: > On Mon, 18 Mar 2024 14:34:07 + > Steven Price wrote: > >> On 18/03/2024 14:18, Boris Brezillon wrote: >>> On Mon, 18 Mar 2024 13:49:52 + >>> Steven Price wrote: >>> On 18/03/2024 13:08, Boris Brezillon wrote: > On Mon, 18 Mar

Re: [PATCH] Revert "drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE"

2024-03-18 Thread Jani Nikula
> select DRM_PANEL > help > DRM bridge wrapper of DRM panels > > --- > base-commit: e3f18b0dd1db242791afbc3bd173026163ce0ccc > change-id: > 20240318-revert-select-drm_kms_helper-for-drm_panel_bridge-0e4ad7c73496 > > Best regards, -- Jani Nikula, Intel

[PATCH] drm/panthor: Don't use virt_to_pfn()

2024-03-18 Thread Steven Price
virt_to_pfn() isn't available on x86 (except to xen) so breaks COMPILE_TEST builds. Avoid its use completely by instead storing the struct page pointer allocated in panthor_device_init() and using page_to_pfn() instead. Signed-off-by: Steven Price --- drivers/gpu/drm/panthor/panthor_device.c |

Re: [PATCH] drm/panthor: Fix the CONFIG_PM=n case

2024-03-18 Thread Boris Brezillon
On Mon, 18 Mar 2024 14:34:07 + Steven Price wrote: > On 18/03/2024 14:18, Boris Brezillon wrote: > > On Mon, 18 Mar 2024 13:49:52 + > > Steven Price wrote: > > > >> On 18/03/2024 13:08, Boris Brezillon wrote: > >>> On Mon, 18 Mar 2024 11:31:05 + > >>> Steven Price wrote: > >>>

Re: [PATCH v4 03/11] drm/ci: uprev IGT and update testlist

2024-03-18 Thread Vignesh Raman
Hi Dmitry, On 15/03/24 17:07, Dmitry Baryshkov wrote: On Wed, 6 Mar 2024 at 05:08, Vignesh Raman wrote: Uprev IGT and add amd, v3d, vc4 and vgem specific tests to testlist. Have testlist.txt per driver and include a base testlist so that the driver specific tests will run only on those

Re: [PATCH] drm/Makefile: Move tiny drivers before native drivers

2024-03-18 Thread Huacai Chen
Hi, Jaak, I'm still here as a boring man. :) Have you ever tested whether using "fs_initcall(sysfb_init)" works fine on your machine? Huacai On Wed, Jan 24, 2024 at 5:21 AM Jaak Ristioja wrote: > > Hi, > > I apologize for not finding the time to test this earlier. > > On 11.12.23 05:08, Huacai

Re: [PATCH v17 0/9] Enable Adaptive Sync SDP Support for DP

2024-03-18 Thread Jani Nikula
On Mon, 11 Mar 2024, Mitul Golani wrote: > An Adaptive-Sync-capable DP protocol converter indicates its > support by setting the related bit in the DPCD register. This > is valid for DP and edp as well. > > Computes AS SDP values based on the display configuration, > ensuring proper handling of

Re: [v3,5/5] drm/xe: Enable 32bits build

2024-03-18 Thread Guenter Roeck
On 3/18/24 06:28, Lucas De Marchi wrote: On Sun, Mar 17, 2024 at 09:14:14AM -0700, Guenter Roeck wrote: Hi, On Thu, Jan 18, 2024 at 04:16:12PM -0800, Lucas De Marchi wrote: Now that all the issues with 32bits are fixed, enable it again. Reviewed-by: Matt Roper Signed-off-by: Lucas De Marchi

Re: [PATCH] drm/panthor: Fix the CONFIG_PM=n case

2024-03-18 Thread Steven Price
On 18/03/2024 14:18, Boris Brezillon wrote: > On Mon, 18 Mar 2024 13:49:52 + > Steven Price wrote: > >> On 18/03/2024 13:08, Boris Brezillon wrote: >>> On Mon, 18 Mar 2024 11:31:05 + >>> Steven Price wrote: >>> On 18/03/2024 08:58, Boris Brezillon wrote: > Putting a hard

Re: [PATCH 2/5] drm/gem: Add a mountpoint parameter to drm_gem_object_init()

2024-03-18 Thread Maíra Canal
Not that the CC list wasn't big enough, but I'm adding MM folks in the CC list. On 3/18/24 11:04, Christian König wrote: Am 18.03.24 um 14:28 schrieb Maíra Canal: Hi Christian, On 3/18/24 10:10, Christian König wrote: Am 18.03.24 um 13:42 schrieb Maíra Canal: Hi Christian, On 3/12/24

Re: [PATCH] Revert "drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE"

2024-03-18 Thread Lucas De Marchi
On Mon, Mar 18, 2024 at 03:16:21PM +0100, Neil Armstrong wrote: This reverts commit e3f18b0dd1db242791afbc3bd173026163ce0ccc. Selecting DRM_KMS_HELPER for DRM_PANEL_BRIDGE leads to: WARNING: unmet direct dependencies detected for DRM_KMS_HELPER Depends on [m]: HAS_IOMEM [=y] && DRM [=m] ...

Re: [PATCH] drm/panthor: Fix the CONFIG_PM=n case

2024-03-18 Thread Boris Brezillon
On Mon, 18 Mar 2024 13:49:52 + Steven Price wrote: > On 18/03/2024 13:08, Boris Brezillon wrote: > > On Mon, 18 Mar 2024 11:31:05 + > > Steven Price wrote: > > > >> On 18/03/2024 08:58, Boris Brezillon wrote: > >>> Putting a hard dependency on CONFIG_PM is not possible because of a

[PATCH] Revert "drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE"

2024-03-18 Thread Neil Armstrong
ends on DRM_BRIDGE - select DRM_KMS_HELPER select DRM_PANEL help DRM bridge wrapper of DRM panels --- base-commit: e3f18b0dd1db242791afbc3bd173026163ce0ccc change-id: 20240318-revert-select-drm_kms_helper-for-drm_panel_bridge-0e4ad7c73496 Best regards, -- Neil Armstrong

Re: [PATCH] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE

2024-03-18 Thread Neil Armstrong
On 18/03/2024 14:41, Ville Syrjälä wrote: On Mon, Mar 18, 2024 at 12:52:10PM +0200, Jani Nikula wrote: On Mon, 18 Mar 2024, Neil Armstrong wrote: Hi, On Thu, 11 Jan 2024 13:38:04 +0100, Luca Weiss wrote: Since the kconfig symbol of DRM_PANEL_BRIDGE is only adding bridge/panel.o to

Re: [PATCH 2/5] drm/gem: Add a mountpoint parameter to drm_gem_object_init()

2024-03-18 Thread Christian König
Am 18.03.24 um 14:28 schrieb Maíra Canal: Hi Christian, On 3/18/24 10:10, Christian König wrote: Am 18.03.24 um 13:42 schrieb Maíra Canal: Hi Christian, On 3/12/24 10:48, Christian König wrote: Am 12.03.24 um 14:09 schrieb Tvrtko Ursulin: On 12/03/2024 10:37, Christian König wrote: Am

Re: [PATCH] drm/panthor: Fix the CONFIG_PM=n case

2024-03-18 Thread Robin Murphy
On 18/03/2024 1:49 pm, Steven Price wrote: On 18/03/2024 13:08, Boris Brezillon wrote: On Mon, 18 Mar 2024 11:31:05 + Steven Price wrote: On 18/03/2024 08:58, Boris Brezillon wrote: Putting a hard dependency on CONFIG_PM is not possible because of a circular dependency issue, and it's

  1   2   >