Re: [PATCH v2 2/4] dt-bindings: display/xlnx/zynqmp-dpsub: Add audio DMAs

2024-03-20 Thread Tomi Valkeinen
On 20/03/2024 17:37, Rob Herring wrote: On Tue, Mar 19, 2024 at 10:22:37AM +0200, Tomi Valkeinen wrote: The DP subsystem for ZynqMP support audio via two channels, and the DP DMA has dma-engines for those channels. For some reason the DT binding has not specified those channels, even if the

[PATCH v2] drm/amdgpu: refactor code to split devcoredump code

2024-03-20 Thread Sunil Khatri
Refractor devcoredump code into new files since its functionality is expanded further and better to slit and devcoredump to have its own file. v2: Fix the build failure caught by arm compiler of implicit function declaration with #ifdef Cc: Ivan Lipski Signed-off-by: Sunil Khatri ---

RE: [PATCH] drm/i915/gt: Report full vm address range

2024-03-20 Thread Mrozek, Michal
> If we provide the total GTT size we will have one page that will be contended > between kernel and userspace and, if userspace is unaware that the page > belongs to the > kernel, we might step on each other toe. That's fine, Compute needs to know total GTT size. Not available GTT size.

[PATCH libdrm] modetest: add support for YUV422 and YUV444 plane format

2024-03-20 Thread Dmitry Baryshkov
Currently modetest supports only the YUV420 and YVU420 planar YCbCr plane formats (aka YV12 and YU12). Extend the code to add support for YUV422 / YVU422 and YUV444 / YVU444 plane formats. Signed-off-by: Dmitry Baryshkov --- tests/modetest/buffers.c | 42

[PATCH] video/hdmi: prefer length specifier in format over string copying

2024-03-20 Thread Justin Stitt
)\n", hdmi_spd_sdi_get_name(frame->sdi), frame->sdi); } --- base-commit: a4145ce1e7bc247fd6f2846e8699473448717b37 change-id: 20240320-strncpy-drivers-video-hdmi-c-bc18d585971f Best regards, -- Justin Stitt

[PATCH] fbdev: uvesafb: replace deprecated strncpy with strscpy_pad

2024-03-20 Thread Justin Stitt
, buf); return count; } static DRIVER_ATTR_RW(v86d); --- base-commit: a4145ce1e7bc247fd6f2846e8699473448717b37 change-id: 20240320-strncpy-drivers-video-fbdev-uvesafb-c-43668c4ef6c8 Best regards, -- Justin Stitt

Re: [RFC 2/2] drm/xe/FLR: Support PCIe FLR

2024-03-20 Thread Lucas De Marchi
On Wed, Mar 20, 2024 at 04:14:26PM +0530, Aravind Iddamsetty wrote: PCI subsystem provides callbacks to inform the driver about a request to do function level reset by user, initiated by writing to sysfs entry /sys/bus/pci/devices/.../reset. This will allow the driver to handle FLR without the

Re: [PATCH] video: fbdev: au1200fb: replace deprecated strncpy with strscpy

2024-03-20 Thread Helge Deller
On 3/20/24 23:35, Justin Stitt wrote: Hi, On Wed, Mar 20, 2024 at 12:56 AM Helge Deller wrote: On 3/19/24 00:46, Justin Stitt wrote: strncpy() is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces.

[PATCH] video: fbdev: fsl-diu-fb: replace deprecated strncpy with strscpy_pad

2024-03-20 Thread Justin Stitt
strncpy() is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. A better alternative is strscpy() as it guarantees NUL-termination on the destination buffer. Since we are eventually copying over to

Re: [PATCH] video: fbdev: au1200fb: replace deprecated strncpy with strscpy

2024-03-20 Thread Justin Stitt
Hi, On Wed, Mar 20, 2024 at 12:56 AM Helge Deller wrote: > > On 3/19/24 00:46, Justin Stitt wrote: > > strncpy() is deprecated for use on NUL-terminated destination strings > > [1] and as such we should prefer more robust and less ambiguous string > > interfaces. > > > > Let's use the new

Re: [RFC 0/2] drm/xe: Support PCIe FLR

2024-03-20 Thread Lucas De Marchi
On Wed, Mar 20, 2024 at 04:14:24PM +0530, Aravind Iddamsetty wrote: PCI subsystem provides callbacks to inform the driver about a request to do function level reset by user, initiated by writing to sysfs entry /sys/bus/pci/devices/.../reset. This will allow the driver to handle FLR without the

Re: [PATCH] drm/Makefile: Move tiny drivers before native drivers

2024-03-20 Thread Jaak Ristioja
Hi Huacai, On 19.03.24 16:16, Huacai Chen wrote: Hi, Jaak, On Mon, Mar 18, 2024 at 11:42 PM Jaak Ristioja wrote: Hi Huacai, Uh, no, sorry, I did not get to test such changes. From what Thomas wrote I presumed that this got fixed and no further action would be required. To speed things up

Re: [RFC 1/2] drm: add devm release action

2024-03-20 Thread Rodrigo Vivi
On Wed, Mar 20, 2024 at 04:14:25PM +0530, Aravind Iddamsetty wrote: > In scenarios where drm_dev_put is directly called by driver we want to > release devm_drm_dev_init_release action associated with struct > drm_device. > > Cc: Thomas Hellstr_m > > Signed-off-by: Aravind Iddamsetty > --- >

Re: [RFC 2/2] drm/xe/FLR: Support PCIe FLR

2024-03-20 Thread Rodrigo Vivi
On Wed, Mar 20, 2024 at 04:14:26PM +0530, Aravind Iddamsetty wrote: > PCI subsystem provides callbacks to inform the driver about a request to > do function level reset by user, initiated by writing to sysfs entry > /sys/bus/pci/devices/.../reset. This will allow the driver to handle FLR > without

Re: [PATCH 1/2] drm/panel: ltk050h3146w: add MIPI_DSI_MODE_VIDEO to LTK050H3148W flags

2024-03-20 Thread Jessica Zhang
On 3/20/2024 6:12 AM, Heiko Stuebner wrote: From: Heiko Stuebner Similar to other variants, the LTK050H3148W wants to run in video mode when displaying data. So far only the Synopsis DSI driver was using this panel and it is always switching to video mode, independent of this flag being

Re: [PATCH 2/5] drm/bridge: simple-bridge: Extend match support for non-DT based systems

2024-03-20 Thread Andy Shevchenko
On Tue, Jan 23, 2024 at 12:32:17AM +0800, Sui Jingfeng wrote: > Which is intended to be used on non-DT environment, where the simple-bridge > platform device is created by either the display controller driver side or > platform firmware subsystem. To avoid duplication and to keep consistent, > we

Re: [PATCH 5/5] drm-bridge: display-connector: Switch to use fwnode API

2024-03-20 Thread Andy Shevchenko
On Tue, Jan 23, 2024 at 03:20:26AM +0200, Laurent Pinchart wrote: > On Tue, Jan 23, 2024 at 12:32:20AM +0800, Sui Jingfeng wrote: ... > > conn->bridge.of_node = pdev->dev.of_node; > > + conn->bridge.fwnode = pdev->dev.fwnode; > > This goes in the right direction. Let's address the other

[Bug 218617] Linux Kernel Bug Report: "Scheduling while atomic" Kernel Panic and System Freeze on NVIDIA RTX 2000 Ada Generation Laptop GPU

2024-03-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218617 --- Comment #2 from Sarah S. (sarah.salzst...@gmail.com) --- Thank you for letting me know! Sincerely, Sarah S. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

Re: [PATCH] software node: Implement device_get_match_data fwnode callback

2024-03-20 Thread Andy Shevchenko
On Thu, Mar 21, 2024 at 03:22:05AM +0800, Sui Jingfeng wrote: > On 2024/3/20 18:39, Andy Shevchenko wrote: > > On Tue, Mar 19, 2024 at 07:42:22AM +0800, Sui Jingfeng wrote: > > > This makes it possible to support (and/or test) a few drivers that > > > originates from DT World on the x86-64

[Bug 218617] Linux Kernel Bug Report: "Scheduling while atomic" Kernel Panic and System Freeze on NVIDIA RTX 2000 Ada Generation Laptop GPU

2024-03-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218617 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED

[PATCH 11/11] drm/i915/dp_mst: Enable HBLANK expansion quirk for UHBR rates

2024-03-20 Thread Imre Deak
Enabling the 5k@60Hz uncompressed mode on the MediaTek/Dell U3224KBA monitor results in a blank screen, at least on MTL platforms on UHBR link rates with some (<30) uncompressed bpp values. Enabling compression fixes the problem, so do that for now. Windows enables DSC always if the sink supports

[PATCH 09/11] drm/dp_mst: Add drm_dp_mst_aux_for_parent()

2024-03-20 Thread Imre Deak
Add a function to get the AUX device of the parent of an MST port, used by a follow-up i915 patch in the patchset. Cc: Lyude Paul Cc: dri-devel@lists.freedesktop.org Signed-off-by: Imre Deak --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 16 1 file changed, 16

[PATCH 08/11] drm/dp_mst: Factor out drm_dp_mst_port_is_logical()

2024-03-20 Thread Imre Deak
Factor out a function to check if an MST port is logical, used by a follow-up i915 patch in the patchset. Cc: Lyude Paul Cc: dri-devel@lists.freedesktop.org Signed-off-by: Imre Deak --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 6 +++--- include/drm/display/drm_dp_mst_helper.h | 7

[PATCH 07/11] drm/dp: Add drm_dp_uhbr_channel_coding_supported()

2024-03-20 Thread Imre Deak
Factor out a function to check for UHBR channel coding support used by a follow-up patch in the patchset. Cc: dri-devel@lists.freedesktop.org Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- include/drm/display/drm_dp_helper.h | 6 ++ 2 files changed, 7

[PATCH 01/11] drm/i915/dp: Fix DSC line buffer depth programming

2024-03-20 Thread Imre Deak
Fix the calculation of the DSC line buffer depth. This is limited both by the source's and sink's maximum line buffer depth, but the former one was not taken into account. On all Intel platform's the source's maximum buffer depth is 13, so the overall limit is simply the minimum of the

Re: [PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

2024-03-20 Thread Sui Jingfeng
On 2024/3/19 23:49, Neil Armstrong wrote: On 18/03/2024 20:23, Sui Jingfeng wrote: Hi, On 2024/3/19 02:04, Laurent Pinchart wrote: Improving core helpers is certainly a good idea, and if we do so, we can simplify drivers. What I'm concerned is that commit 00084f0c01bf creates a silent

Re: [PATCH] drm/i915/gt: Reset queue_priority_hint on parking

2024-03-20 Thread Janusz Krzysztofik
Hi Andi, On Wednesday, 20 March 2024 15:29:58 CET Andi Shyti wrote: > Hi Janusz, > > ... > > > Fixes: 22b7a426bbe1 ("drm/i915/execlists: Preempt-to-busy") > > Closes: https://gitlab.freedesktop.org/drm/intel/issues/10154 > > Signed-off-by: Chris Wilson > > Cc: Mika Kuoppala > > Signed-off-by:

Re: Missing commits from drm-misc-next on linux-next

2024-03-20 Thread Nícolas F . R . A . Prado
On Thu, Mar 21, 2024 at 02:08:59AM +0800, Chen-Yu Tsai wrote: > On Thu, Mar 21, 2024 at 1:59 AM Nícolas F. R. A. Prado > wrote: > > > > On Wed, Mar 20, 2024 at 04:19:51PM +0100, Maxime Ripard wrote: > > > Hi, > > > > > > On Wed, Mar 20, 2024 at 11:07:34AM -0400, Nícolas F. R. A. Prado wrote: > >

[PATCH] drm/amdgpu: refactor code to split devcoredump code

2024-03-20 Thread Sunil Khatri
Refractor devcoredump code into new files since its functionality is expanded further and better to slit and devcoredump to have its own file. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- .../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 218

Re: [PATCH] software node: Implement device_get_match_data fwnode callback

2024-03-20 Thread Sui Jingfeng
Hi, On 2024/3/20 18:39, Andy Shevchenko wrote: +Cc: Vladimir On Tue, Mar 19, 2024 at 07:42:22AM +0800, Sui Jingfeng wrote: This makes it possible to support (and/or test) a few drivers that originates from DT World on the x86-64 platform. Originally, those drivers using the

Re: drm/tiny: QUESTION: What to use instead of drm_simple_display_pipe ?

2024-03-20 Thread Mehdi Djait
Hello Javier, Hello Thomas, On Tue, Mar 19, 2024 at 09:52:34AM +0100, Javier Martinez Canillas wrote: > Thomas Zimmermann writes: > > Hello Mehdi, > > > Hi > > > > Am 18.03.24 um 20:18 schrieb Mehdi Djait: > >> Hello everyone :) > >> > >> I am implementing a tiny drm driver and I am currently

Re: Future handling of complex RGB devices on Linux v3

2024-03-20 Thread Werner Sembach
Am 20.03.24 um 12:33 schrieb Werner Sembach: Am 20.03.24 um 12:16 schrieb Werner Sembach: Hi Hans and the others, Am 22.02.24 um 14:14 schrieb Werner Sembach: Hi, Thanks everyone for the exhaustive feedback. And at least this thread is a good comprehesive reference for the future ^^.

[Bug 218617] New: Linux Kernel Bug Report: "Scheduling while atomic" Kernel Panic and System Freeze on NVIDIA RTX 2000 Ada Generation Laptop GPU

2024-03-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218617 Bug ID: 218617 Summary: Linux Kernel Bug Report: "Scheduling while atomic" Kernel Panic and System Freeze on NVIDIA RTX 2000 Ada Generation Laptop GPU Product: Drivers

Re: [PATCH] drm/i915/gt: Report full vm address range

2024-03-20 Thread Andi Shyti
Hi Michal, On Mon, Mar 18, 2024 at 05:21:54AM +, Mrozek, Michal wrote: > > > Lionel, Michal, thoughts? > Compute UMD needs to know exact GTT total size. the problem is that we cannot apply the workaround without reserving one page from the GTT total size and we need to apply the workaround.

Re: Nova and staging Rust abstractions

2024-03-20 Thread Greg KH
On Wed, Mar 20, 2024 at 06:58:43PM +0100, Danilo Krummrich wrote: > @Greg, can you please have a first quick look at rust-device [5]? If they are sent as patches to review, yes, I can get to them as part of my normal patch review cycle. Otherwise I have no cyeles to dig through random github

Re: Missing commits from drm-misc-next on linux-next

2024-03-20 Thread Chen-Yu Tsai
On Thu, Mar 21, 2024 at 1:59 AM Nícolas F. R. A. Prado wrote: > > On Wed, Mar 20, 2024 at 04:19:51PM +0100, Maxime Ripard wrote: > > Hi, > > > > On Wed, Mar 20, 2024 at 11:07:34AM -0400, Nícolas F. R. A. Prado wrote: > > > I noticed that there are some commits from drm-misc-next [1] that haven't

Re: [PATCH v6 0/3] Disable automatic load CCS load balancing

2024-03-20 Thread Andi Shyti
Hi Tvrtko, On Wed, Mar 20, 2024 at 03:40:18PM +, Tvrtko Ursulin wrote: > On 20/03/2024 15:06, Andi Shyti wrote: > > Ping! Any thoughts here? > > I only casually observed the discussion after I saw Matt suggested further > simplifications. As I understood it, you will bring back the uabi

Re: Missing commits from drm-misc-next on linux-next

2024-03-20 Thread Nícolas F . R . A . Prado
On Wed, Mar 20, 2024 at 04:19:51PM +0100, Maxime Ripard wrote: > Hi, > > On Wed, Mar 20, 2024 at 11:07:34AM -0400, Nícolas F. R. A. Prado wrote: > > I noticed that there are some commits from drm-misc-next [1] that haven't > > been > > added to the for-linux-next [2] branch, and consequently

Nova and staging Rust abstractions

2024-03-20 Thread Danilo Krummrich
Hi all, In this mail I briefly want to announce the Nova project and subsequently talk about the first efforts taken in order to upstream required Rust abstractions: We just started to work on Nova, a Rust-based GSP-only driver for Nvidia GPUs. Nova, in the long term, is intended to serve as

Re: [v5,11/13] drm/ast: Use drm_connector_helper_get_modes()

2024-03-20 Thread Sui Jingfeng
Hi, On 2024/3/20 17:34, Thomas Zimmermann wrote: The .get_modes() code for VGA and SIL164 connectors does not depend on either type of connector. Replace the driver code with the common helper drm_connector_helper_get_modes(). It reads EDID data via DDC and updates the connector's EDID

Re: [v5,10/13] drm/ast: Acquire I/O-register lock in DDC code

2024-03-20 Thread Sui Jingfeng
Hi, Tested with ast2600 hardware, no obvious problem found yet. dmesg  | grep ast  ast :09:00.0: VGA not enabled on entry, requesting chip POST  ast :09:00.0: Using default configuration  ast :09:00.0: AST 2600 detected  ast :09:00.0: [drm] Using analog VGA  ast :09:00.0:

Re: [v5, 09/13] drm/ast: Rename struct i2c_algo_bit_data callbacks and their parameters

2024-03-20 Thread Sui Jingfeng
Hi, On 2024/3/20 17:34, Thomas Zimmermann wrote: Align the names of the algo-bit helpers with ast's convention of using an ast prefix plus the struct's name plus the callback's name for such function symbols. Change the parameter names of these helpers to 'data' and 'state', as used in the

Re: [v5,08/13] drm/ast: Store AST device in struct ast_ddc

2024-03-20 Thread Sui Jingfeng
Hi, On 2024/3/20 17:34, Thomas Zimmermann wrote: The DDC code needs the AST device. Store a pointer in struct ast_ddc and avoid internal upcasts. Improves type safety within the DDC code. Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng -- Best regards, Sui

Re: [v5,07/13] drm/ast: Pass AST device to ast_ddc_create()

2024-03-20 Thread Sui Jingfeng
Hi, On 2024/3/20 17:34, Thomas Zimmermann wrote: The DDC code needs the AST device. Pass it to ast_ddc_create() and avoid an internal upcast. Improves type safety within the DDC code. Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng -- Best regards, Sui

Re: [v5,06/13] drm/ast: Rename struct ast_i2c_chan to struct ast_ddc

2024-03-20 Thread Sui Jingfeng
Hi, On 2024/3/20 17:34, Thomas Zimmermann wrote: The struct struct ast_i2c_chan represents the Display Data Channel (DDC); I2C is the underlying bus. Rename the structure, the variables and the helper ast_i2c_create() to ddc-like terms. No functional changes. Signed-off-by: Thomas Zimmermann

Re: [v5,05/13] drm/ast: Move DDC code to ast_ddc.{c,h}

2024-03-20 Thread Sui Jingfeng
Hi, On 2024/3/20 17:34, Thomas Zimmermann wrote: Rename ast_i2c.c to ast_ddc.c and move its interface into the new header ast_ddc.h. Update all include statements as necessary and change the adapter name to 'AST DDC bus'. This avoids including I2C headers in the driver's main header file,

Re: [v5, 04/13] drm/ast: Allocate instance of struct ast_i2c_chan with managed helpers

2024-03-20 Thread Sui Jingfeng
Hi, On 2024/3/20 17:34, Thomas Zimmermann wrote: Replace kzalloc() with drmm_kzalloc() and thereby put the release of the I2C instance into a separate action. Avoids explicit error roll- back in ast_i2c_chan_create(). No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by:

Re: [v5,01/13] drm/ast: Include where necessary

2024-03-20 Thread Sui Jingfeng
Hi, On 2024/3/20 17:34, Thomas Zimmermann wrote: Include to get of_property_read_u32() in the source files that need it. Avoids the proxy include via . Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng -- Best regards, Sui

Re: [PATCH v2] dt-bindings: display: samsung,exynos5-dp: convert to DT Schema

2024-03-20 Thread Conor Dooley
On Wed, Mar 13, 2024 at 07:28:55PM +0100, Krzysztof Kozlowski wrote: > + clock-names: > +items: > + - const: dp > + phy-names: > +items: > + - const: dp The items lists here are redundant when you only have a single item, no? Isnt it just phy-names: const: dp ? Otherwise,

Re: [PATCH] drm/panel: atna33xc20: Fix unbalanced regulator in the case HPD doesn't assert

2024-03-20 Thread Neil Armstrong
On 20/03/2024 16:33, Doug Anderson wrote: Hi, On Thu, Mar 14, 2024 at 3:32 PM Jessica Zhang wrote: On 3/13/2024 2:12 PM, Douglas Anderson via B4 Relay wrote: From: Douglas Anderson When the atna33xc20 driver was first written the resume code never returned an error. If there was a problem

Re: [PATCH v6 0/3] Disable automatic load CCS load balancing

2024-03-20 Thread Tvrtko Ursulin
On 20/03/2024 15:06, Andi Shyti wrote: Ping! Any thoughts here? I only casually observed the discussion after I saw Matt suggested further simplifications. As I understood it, you will bring back the uabi engine games when adding the dynamic behaviour and that is fine by me. Regards,

Re: [PATCH v2 2/4] dt-bindings: display/xlnx/zynqmp-dpsub: Add audio DMAs

2024-03-20 Thread Rob Herring
On Tue, Mar 19, 2024 at 10:22:37AM +0200, Tomi Valkeinen wrote: > The DP subsystem for ZynqMP support audio via two channels, and the DP > DMA has dma-engines for those channels. For some reason the DT binding > has not specified those channels, even if the picture included in >

Re: [PATCH] drm/panel: atna33xc20: Fix unbalanced regulator in the case HPD doesn't assert

2024-03-20 Thread Doug Anderson
Hi, On Thu, Mar 14, 2024 at 3:32 PM Jessica Zhang wrote: > > On 3/13/2024 2:12 PM, Douglas Anderson via B4 Relay wrote: > > From: Douglas Anderson > > > > When the atna33xc20 driver was first written the resume code never > > returned an error. If there was a problem waiting for HPD it just > >

Re: [PATCH 1/1] drm/qxl: fixes qxl_fence_wait

2024-03-20 Thread Linux regression tracking (Thorsten Leemhuis)
On 08.03.24 02:08, Alex Constantino wrote: > Fix OOM scenario by doing multiple notifications to the OOM handler through > a busy wait logic. > Changes from commit 5a838e5d5825 ("drm/qxl: simplify qxl_fence_wait") would > result in a '[TTM] Buffer eviction failed' exception whenever it reached a >

Re: Missing commits from drm-misc-next on linux-next

2024-03-20 Thread Maxime Ripard
Hi, On Wed, Mar 20, 2024 at 11:07:34AM -0400, Nícolas F. R. A. Prado wrote: > I noticed that there are some commits from drm-misc-next [1] that haven't been > added to the for-linux-next [2] branch, and consequently haven't made their > way > into linux-next. > > Namely, commit bf0390e2c95b

Re: Missing commits from drm-misc-next on linux-next

2024-03-20 Thread Chen-Yu Tsai
On Wed, Mar 20, 2024 at 11:07 PM Nícolas F. R. A. Prado wrote: > > Hi, > > I noticed that there are some commits from drm-misc-next [1] that haven't been > added to the for-linux-next [2] branch, and consequently haven't made their > way > into linux-next. > > Namely, commit bf0390e2c95b

Missing commits from drm-misc-next on linux-next

2024-03-20 Thread Nícolas F . R . A . Prado
Hi, I noticed that there are some commits from drm-misc-next [1] that haven't been added to the for-linux-next [2] branch, and consequently haven't made their way into linux-next. Namely, commit bf0390e2c95b ("drm/panel: add samsung s6e3fa7 panel driver") and commit 2689b33b8864 ("dt-bindings:

Re: [PATCH v6 0/3] Disable automatic load CCS load balancing

2024-03-20 Thread Andi Shyti
Ping! Any thoughts here? Andi On Wed, Mar 13, 2024 at 09:19:48PM +0100, Andi Shyti wrote: > Hi, > > this series does basically two things: > > 1. Disables automatic load balancing as adviced by the hardware >workaround. > > 2. Assigns all the CCS slices to one single user engine. The user

Re: [PATCH] drm/i915/gt: Reset queue_priority_hint on parking

2024-03-20 Thread Andi Shyti
Hi Janusz, ... > Fixes: 22b7a426bbe1 ("drm/i915/execlists: Preempt-to-busy") > Closes: https://gitlab.freedesktop.org/drm/intel/issues/10154 > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Signed-off-by: Janusz Krzysztofik > Cc: Chris Wilson > Cc: # v5.4+ this tag list is a bit

Re: [PATCH v2 1/2] drm/prime: reject DMA-BUF attach when get_sg_table is missing

2024-03-20 Thread Rob Clark
On Thu, Mar 2, 2023 at 6:35 AM Simon Ser wrote: > > drm_gem_map_dma_buf() requires drm_gem_object_funcs.get_sg_table > to be implemented, or else WARNs. > > Allow drivers to leave this hook unimplemented to implement purely > local DMA-BUFs (ie, DMA-BUFs which cannot be imported anywhere > else

Re: STM32 DSI controller driver: mode_valid clock tolerance

2024-03-20 Thread Raphael Gallais-Pou
On 3/8/24 09:35, Sean Nyekjaer wrote: > Hi, Hi Sean, Sorry for not responding earlier. I've also added Antonio Borneo, which is the author of the implementation of the mode_valid() hook. > I’m using a stm32mp157 with a sn65dsi83 DSI2LVDS bridge. > The LVDS display is having a minimum clock

Re: STM32 DSI controller driver: mode_valid clock tolerance

2024-03-20 Thread Maxime Ripard
Hi Sean, On Fri, Mar 08, 2024 at 09:35:27AM +0100, Sean Nyekjaer wrote: > I’m using a stm32mp157 with a sn65dsi83 DSI2LVDS bridge. The LVDS > display is having a minimum clock of 25.2 MHz, typical of 27,2 MHz and > a max of 30,5 MHz. > > I will fail the mode_valid check with MODE_CLOCK_RANGE. It

[PATCH 2/2] drm/panel: ltk050h3146w: drop duplicate commands from LTK050H3148W init

2024-03-20 Thread Heiko Stuebner
From: Heiko Stuebner The init sequence specifies the 0x11 and 0x29 dsi commands, which are the exit-sleep and display-on commands. In the actual prepare step the driver already uses the appropriate function calls for those, so drop the duplicates. Fixes: e5f9d543419c ("drm/panel: ltk050h3146w:

[PATCH 1/2] drm/panel: ltk050h3146w: add MIPI_DSI_MODE_VIDEO to LTK050H3148W flags

2024-03-20 Thread Heiko Stuebner
From: Heiko Stuebner Similar to other variants, the LTK050H3148W wants to run in video mode when displaying data. So far only the Synopsis DSI driver was using this panel and it is always switching to video mode, independent of this flag being set. Other DSI drivers might handle this

Re: Future handling of complex RGB devices on Linux v3

2024-03-20 Thread Werner Sembach
Am 20.03.24 um 12:16 schrieb Werner Sembach: Hi Hans and the others, Am 22.02.24 um 14:14 schrieb Werner Sembach: Hi, Thanks everyone for the exhaustive feedback. And at least this thread is a good comprehesive reference for the future ^^. To recap the hopefully final UAPI for complex

Re: Future handling of complex RGB devices on Linux v3

2024-03-20 Thread Werner Sembach
Hi Hans and the others, Am 22.02.24 um 14:14 schrieb Werner Sembach: Hi, Thanks everyone for the exhaustive feedback. And at least this thread is a good comprehesive reference for the future ^^. To recap the hopefully final UAPI for complex RGB lighting devices: - By default there is a

[RFC 0/2] drm/xe: Support PCIe FLR

2024-03-20 Thread Aravind Iddamsetty
PCI subsystem provides callbacks to inform the driver about a request to do function level reset by user, initiated by writing to sysfs entry /sys/bus/pci/devices/.../reset. This will allow the driver to handle FLR without the need to do unbind and rebind as the driver needs to reinitialize the

[RFC 2/2] drm/xe/FLR: Support PCIe FLR

2024-03-20 Thread Aravind Iddamsetty
PCI subsystem provides callbacks to inform the driver about a request to do function level reset by user, initiated by writing to sysfs entry /sys/bus/pci/devices/.../reset. This will allow the driver to handle FLR without the need to do unbind and rebind as the driver needs to reinitialize the

[RFC 1/2] drm: add devm release action

2024-03-20 Thread Aravind Iddamsetty
In scenarios where drm_dev_put is directly called by driver we want to release devm_drm_dev_init_release action associated with struct drm_device. Cc: Thomas Hellstr_m Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/drm_drv.c | 6 ++ include/drm/drm_drv.h | 4 2 files

Re: [PATCH] software node: Implement device_get_match_data fwnode callback

2024-03-20 Thread Andy Shevchenko
+Cc: Vladimir On Tue, Mar 19, 2024 at 07:42:22AM +0800, Sui Jingfeng wrote: > This makes it possible to support (and/or test) a few drivers that > originates from DT World on the x86-64 platform. Originally, those > drivers using the of_device_get_match_data() function to get match > data. For

[PATCH v5 10/13] drm/ast: Acquire I/O-register lock in DDC code

2024-03-20 Thread Thomas Zimmermann
The modeset lock protects the DDC code from concurrent modeset operations, which use the same registers. Move that code from the connector helpers into the DDC helpers .pre_xfer() and .post_xfer(). Both, .pre_xfer() and .post_xfer(), enclose the transfer of data blocks over the I2C channel in the

[PATCH v5 09/13] drm/ast: Rename struct i2c_algo_bit_data callbacks and their parameters

2024-03-20 Thread Thomas Zimmermann
Align the names of the algo-bit helpers with ast's convention of using an ast prefix plus the struct's name plus the callback's name for such function symbols. Change the parameter names of these helpers to 'data' and 'state', as used in the declaration of struct i2c_algo_bit_data. No functional

[PATCH v5 03/13] drm/ast: Remove struct ast_{vga,sil165}_connector

2024-03-20 Thread Thomas Zimmermann
Both, struct ast_vga_connector and struct ast_sil164_connector, are now wrappers around struct drm_connector. Remove them. Signed-off-by: Thomas Zimmermann Reviewed-by: Patrik Jakobsson --- drivers/gpu/drm/ast/ast_drv.h | 24 ++-- drivers/gpu/drm/ast/ast_mode.c | 22

[PATCH v5 05/13] drm/ast: Move DDC code to ast_ddc.{c,h}

2024-03-20 Thread Thomas Zimmermann
Rename ast_i2c.c to ast_ddc.c and move its interface into the new header ast_ddc.h. Update all include statements as necessary and change the adapter name to 'AST DDC bus'. This avoids including I2C headers in the driver's main header file, which doesn't need them. Renaming files to _ddc

[PATCH v5 08/13] drm/ast: Store AST device in struct ast_ddc

2024-03-20 Thread Thomas Zimmermann
The DDC code needs the AST device. Store a pointer in struct ast_ddc and avoid internal upcasts. Improves type safety within the DDC code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_ddc.c | 10 +- drivers/gpu/drm/ast/ast_ddc.h | 4 ++-- 2 files changed, 7

[PATCH v5 04/13] drm/ast: Allocate instance of struct ast_i2c_chan with managed helpers

2024-03-20 Thread Thomas Zimmermann
Replace kzalloc() with drmm_kzalloc() and thereby put the release of the I2C instance into a separate action. Avoids explicit error roll- back in ast_i2c_chan_create(). No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_i2c.c | 9 ++--- 1 file changed, 2

[PATCH v5 12/13] drm/ast: Implement polling for VGA and SIL164 connectors

2024-03-20 Thread Thomas Zimmermann
Implement polling for VGA and SIL164 connectors. Set the flag DRM_CONNECTOR_POLL_DISCONNECT for each to detect the removal of the monitor cable. Implement struct drm_connector_helper_funcs.detect_ctx for each type of connector by testing for EDID data. The helper drm_connector_helper_detect_ctx()

[PATCH v5 07/13] drm/ast: Pass AST device to ast_ddc_create()

2024-03-20 Thread Thomas Zimmermann
The DDC code needs the AST device. Pass it to ast_ddc_create() and avoid an internal upcast. Improves type safety within the DDC code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_ddc.c | 3 ++- drivers/gpu/drm/ast/ast_ddc.h | 3 ++- drivers/gpu/drm/ast/ast_mode.c | 6 --

[PATCH v5 13/13] drm/ast: Automatically clean up poll helper

2024-03-20 Thread Thomas Zimmermann
Automatically clean up the conncetor-poll thread as part of the DRM device release. The new helper drmm_kms_helper_poll_init() provides a shared implementation for all drivers. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 4 +++- drivers/gpu/drm/drm_probe_helper.c

[PATCH v5 00/13] drm/ast: Detect connector status for VGA and SIL164

2024-03-20 Thread Thomas Zimmermann
Detect the status of the VGA or SIL164 conenctor by polling the DDC channel. Update the status at runtime and flip the BMC status as well. Patches 1 adds a missing include statement that will be required to make later patches compile. Patches 2 and 3 simplify the VGA and SIL164 connectors, such

[PATCH v5 02/13] drm/ast: Fail probing if DDC channel could not be initialized

2024-03-20 Thread Thomas Zimmermann
Expect the hardware to provide a DDC channel. Fail probing if its initialization fails. Failing to initialize the DDC indicates a larger problem, so there's no point in continuing. v4: * give a rational in the commit message Signed-off-by: Thomas Zimmermann Reviewed-by: Patrik Jakobsson

[PATCH v5 06/13] drm/ast: Rename struct ast_i2c_chan to struct ast_ddc

2024-03-20 Thread Thomas Zimmermann
The struct struct ast_i2c_chan represents the Display Data Channel (DDC); I2C is the underlying bus. Rename the structure, the variables and the helper ast_i2c_create() to ddc-like terms. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_ddc.c | 71

[PATCH v5 11/13] drm/ast: Use drm_connector_helper_get_modes()

2024-03-20 Thread Thomas Zimmermann
The .get_modes() code for VGA and SIL164 connectors does not depend on either type of connector. Replace the driver code with the common helper drm_connector_helper_get_modes(). It reads EDID data via DDC and updates the connector's EDID property. Signed-off-by: Thomas Zimmermann ---

[PATCH v5 01/13] drm/ast: Include where necessary

2024-03-20 Thread Thomas Zimmermann
Include to get of_property_read_u32() in the source files that need it. Avoids the proxy include via . Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.c | 1 + drivers/gpu/drm/ast/ast_main.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/ast/ast_drv.c

Re: [PATCH] nouveau/gsp: don't check devinit disable on GSP.

2024-03-20 Thread Timothy Maden
Hello Can this be merged please ? On 3/14/24 03:45, Dave Airlie wrote: From: Dave Airlie GSP should be handling this and I can see no evidence in opengpu driver that this register should be touched. Fixed acceleration on 2080 Ti GPUs. Fixes: 15740541e8f0 ("drm/nouveau/devinit/tu102-:

Re: Handling pageflip timeouts

2024-03-20 Thread Simon Ser
Note, the kernel already sends synthetic page-flip events when a CRTC goes from on → off. I think it would make sense to do the same for all pending page-flips before the device is destroyed in the kernel.

Re: [PATCH v3 09/14] drm/mediatek: Rename files "mtk_drm_ddp_comp.c" to "mtk_ddp_comp.c"

2024-03-20 Thread AngeloGioacchino Del Regno
Il 20/03/24 03:42, Shawn Sung ha scritto: From: Hsiao Chien Sung Rename files mtk_drm_ddp_comp.c to mtk_ddp_comp.c and modify the Makefile accordingly. Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v3 07/14] drm/mediatek: Rename files "mtk_drm_crtc.c" to "mtk_crtc.c"

2024-03-20 Thread AngeloGioacchino Del Regno
Il 20/03/24 03:42, Shawn Sung ha scritto: From: Hsiao Chien Sung Rename files mtk_drm_crtc.c to mtk_crtc.c and modify the Makefile accordingly. Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung Reviewed-by: AngeloGioacchino Del Regno

RE: EXTERNAL: Re: [PATCH v2 6/6] backlight: Remove fb_blank from struct backlight_properties

2024-03-20 Thread FLAVIO SULIGOI
HI Thomas, ... > >> Remove the field fb_blank from struct backlight_properties and remove > >> all code that still sets or reads it. Backlight blank status is now > >> tracked exclusively in struct backlight_properties.state. > >> > >> The core backlight code keeps the fb_blank and state fields

Re: [PATCH v2 6/6] backlight: Remove fb_blank from struct backlight_properties

2024-03-20 Thread Thomas Zimmermann
Hi Am 20.03.24 um 09:46 schrieb FLAVIO SULIGOI: Hi Thomas, ... Remove the field fb_blank from struct backlight_properties and remove all code that still sets or reads it. Backlight blank status is now tracked exclusively in struct backlight_properties.state. The core backlight code keeps

RE: [PATCH v2 6/6] backlight: Remove fb_blank from struct backlight_properties

2024-03-20 Thread FLAVIO SULIGOI
Hi Thomas, ... > Remove the field fb_blank from struct backlight_properties and remove all > code that still sets or reads it. Backlight blank status is now tracked > exclusively > in struct backlight_properties.state. > > The core backlight code keeps the fb_blank and state fields in sync, but

Re: Handling pageflip timeouts

2024-03-20 Thread Pekka Paalanen
On Wed, 13 Mar 2024 15:45:47 +0100 Xaver Hugl wrote: > Hi all, > > This was already discussed on IRC, but I think this should be on the > mailing list as well and get some more official conclusion that's > written down somewhere. > > Recently I've experienced a GPU reset, which the system

Re: [Linaro-mm-sig] [PATCH] dma-buf: Fix NULL pointer dereference in sanitycheck()

2024-03-20 Thread Christian König
Am 20.03.24 um 00:15 schrieb Pavel Sakharov: If due to a memory allocation failure mock_chain() returns NULL, it is passed to dma_fence_enable_sw_signaling() resulting in NULL pointer dereference there. Call dma_fence_enable_sw_signaling() only if mock_chain() succeeds. Found by Linux

Re: [PATCH v3] video: fbdev: panel-tpo-td043mtea1: Convert sprintf() family to sysfs_emit() family

2024-03-20 Thread Helge Deller
On 3/19/24 10:23, Li Zhijian wrote: Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit().

Re: [PATCH] video: fbdev: au1200fb: replace deprecated strncpy with strscpy

2024-03-20 Thread Helge Deller
On 3/19/24 00:46, Justin Stitt wrote: strncpy() is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. Let's use the new 2-argument strscpy() which guarantees NUL-termination on the destination buffer while

Re: [PATCH v2 8/8] drm: zynqmp_dp: Add debugfs interface for compliance testing

2024-03-20 Thread Tomi Valkeinen
On 20/03/2024 00:51, Sean Anderson wrote: +/** + * enum test_pattern - Test patterns for test testing "for test testing"? =) @@ -1655,6 +2321,9 @@ static void zynqmp_dp_hpd_irq_work_func(struct work_struct *work) u8 status[DP_LINK_STATUS_SIZE + 2]; int err; + if

Re: [PATCH v2 7/8] drm: zynqmp_dp: Split off several helper functions

2024-03-20 Thread Tomi Valkeinen
On 20/03/2024 00:51, Sean Anderson wrote: In preparation for supporting compliance testing, split off several helper functions. No functional change intended. Signed-off-by: Sean Anderson Reviewed-by: Laurent Pinchart --- (no changes since v1) drivers/gpu/drm/xlnx/zynqmp_dp.c | 49

Re: [PATCH v2 5/8] drm: zynqmp_dp: Don't retrain the link in our IRQ

2024-03-20 Thread Tomi Valkeinen
On 20/03/2024 00:51, Sean Anderson wrote: Retraining the link can take a while, and might involve waiting for DPCD reads/writes to complete. This is inappropriate for an IRQ handler. Just schedule this work for later completion. This is racy, but will be fixed in the next commit. You should

[PATCH 0/1] Add interface to allocate MediaTek GEM buffer

2024-03-20 Thread Shawn Sung
From: Hsiao Chien Sung Add an interface to allocate Mediatek GEM buffers, allow the IOCTLs to be used by render nodes. This patch also sets the RENDER driver feature. This patch is: - Based on 20240320024222.14234-1-shawn.s...@mediatek.com - Reviewed on

[PATCH 1/1] drm/mediatek: Add interface to allocate MediaTek GEM buffer.

2024-03-20 Thread Shawn Sung
From: CK Hu Add an interface to allocate MediaTek GEM buffers, allow the IOCTLs to be used by render nodes. This patch also sets the RENDER driver feature. Signed-off-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 16 ++-

  1   2   >