Re: Re: drm/debugfs: Drop conditionals around of_node pointers

2024-04-29 Thread 隋景峰
Hi, > -原始邮件- > 发件人: "Maxime Ripard" > 发送时间: 2024-04-29 19:30:24 (星期一) > 收件人: "Sui Jingfeng" > 抄送: "Sui Jingfeng" , "Maarten Lankhorst" > , "Thomas Zimmermann" > , "David Airlie" , "Daniel Vetter" > , "Douglas Anderson" , "Laurent > Pinchart" , "Biju Das" > ,

Re: [PATCH v2 1/2] drm/nouveau/firmware: Fix SG_DEBUG error with nvkm_firmware_ctor()

2024-04-29 Thread David Airlie
> V2: > * Fixup explanation as the prior one was bogus For v2 of both patches, Reviewed-by: Dave Airlie Please apply to drm-misc-fixes Dave.

Re: [PATCH] drm/panel: ili9341: Remove a superfluous else after return

2024-04-29 Thread Jessica Zhang
On 4/29/2024 10:12 AM, Sui Jingfeng wrote: The else clause after the ruturn clause is not useful. Hi Sui, Spelling nit: ruturn --> return Besides that, Reviewed-by: Jessica Zhang Thanks, Jessica Zhang Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c |

Re: [PATCH v2 1/8] drm/mipi-dsi: Fix theoretical int overflow in mipi_dsi_dcs_write_seq()

2024-04-29 Thread Doug Anderson
Hi, On Fri, Apr 26, 2024 at 11:22 PM Sam Ravnborg wrote: > > On Sat, Apr 27, 2024 at 04:44:33AM +0300, Dmitry Baryshkov wrote: > > On Sat, 27 Apr 2024 at 02:59, Douglas Anderson > > wrote: > > > > > > The mipi_dsi_dcs_write_seq() macro makes a call to > > > mipi_dsi_dcs_write_buffer() which

[linux-next:master] BUILD REGRESSION b0a2c79c6f3590b74742cbbc76687014d47972d8

2024-04-29 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: b0a2c79c6f3590b74742cbbc76687014d47972d8 Add linux-next specific files for 20240429 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/20240429.kkvw8mvg-...@intel.com https

AMD Dell m18 r1/7600XT Laptop Issue dcn31_panel_cntl_construct+0x49/0x60 [amdgpu]

2024-04-29 Thread Gregory Carter
is this a bug or a support issue for this laptop? [4.739919] [ cut here ] [4.739920] WARNING: CPU: 17 PID: 551 at drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_panel_cntl.c:172 dcn31_panel_cntl_construct+0x49/0x60 [amdgpu] [4.740183] Modules linked in:

Re: [PATCH] drm: ci: fix the xfails for apq8016

2024-04-29 Thread Helen Koike
On 25/04/2024 11:01, Helen Koike wrote: On 08/04/2024 14:04, Abhinav Kumar wrote: Hi Helen Gentle reminder on this. If you are okay, we can land it via msm-next tree... Thanks Abhinav On 4/1/2024 1:48 PM, Abhinav Kumar wrote: After IGT migrating to dynamic sub-tests, the pipe

Re: [PATCH 2/4] WIP: drm: Introduce rvkms

2024-04-29 Thread Lyude Paul
On Thu, 2024-04-25 at 15:46 +, Benno Lossin wrote: > On 22.04.24 03:54, Lyude Paul wrote: > > On Wed, 2024-03-27 at 21:06 +, Benno Lossin wrote: > > > On 22.03.24 23:03, Lyude Paul wrote: > > > > + > > > > +pub(crate) type Connector = > > > > connector::Connector; > > > > + > > > > +impl

[PATCH v2 2/2] drm/amd/display: Move PRIMARY plane zpos higher

2024-04-29 Thread sunpeng.li
From: Leo Li [Why] Compositors have different ways of assigning surfaces to DRM planes for render offloading. It may decide between various strategies: overlay, underlay, or a mix of both (see here for more info: https://gitlab.freedesktop.org/emersion/libliftoff/-/issues/76) One way for

[PATCH v2 1/2] drm/amd/display: Introduce overlay cursor mode

2024-04-29 Thread sunpeng.li
From: Leo Li [Why] DCN is the display hardware for amdgpu. DRM planes are backed by DCN hardware pipes, which carry pixel data from one end (memory), to the other (output encoder). Each DCN pipe has the ability to blend in a cursor early on in the pipeline. In other words, there are no

[PATCH v8 35/35] drm-print: workaround compiler meh

2024-04-29 Thread Jim Cromie
For some reason I cannot grok, I get an unused variable 'category' warning/error, though the usage follows immediately. This drops the local var and directly derefs in the macro-call, which somehow avoids the warning. commit 9fd6f61a297e ("drm/print: add drm_dbg_printer() for drm device specific

[PATCH v8 25/35] docs/dyndbg: explain new delimiters: comma, percent

2024-04-29 Thread Jim Cromie
Add mention of comma and percent delimiters into the respective paragraphs describing their equivalents: space and newline. Signed-off-by: Jim Cromie --- .../admin-guide/dynamic-debug-howto.rst| 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git

[PATCH v8 34/35] drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN

2024-04-29 Thread Jim Cromie
Time for some quality CI Signed-off-by: Jim Cromie --- drivers/gpu/drm/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 5a0c476361c3..b2ea73ae48f0 100644 --- a/drivers/gpu/drm/Kconfig +++

[PATCH v8 32/35] drm: use correct ccflags-y spelling

2024-04-29 Thread Jim Cromie
Incorrectly spelled CFLAGS- failed to add -DDYNAMIC_DEBUG_MODULE, which broke builds with: CONFIG_DRM_USE_DYNAMIC_DEBUG=y CONFIG_DYNAMIC_DEBUG_CORE=y CONFIG_DYNAMIC_DEBUG=n Also add subdir-ccflags so that all drivers pick up the addition. Fixes: 84ec67288c10 ("drm_print: wrap drm_*_dbg in

[PATCH v8 31/35] drm-dyndbg: adapt to use DYNDBG_CLASSMAP_PARAM

2024-04-29 Thread Jim Cromie
use new export --- drivers/gpu/drm/drm_print.c | 8 ++-- include/drm/drm_print.h | 6 -- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c index 4a5f2317229b..efdf82f8cbbb 100644 --- a/drivers/gpu/drm/drm_print.c

[PATCH v8 27/35] selftests-dyndbg: test dyndbg-to-tracefs

2024-04-29 Thread Jim Cromie
Add a series of trace-tests: test_actual_trace() etc, to validate that the dyndbg-to-tracefs feature (using +T flag) works as intended. The 1st test uses the global tracebuf, the rest use/excercise private tracebufs. These tests are currently optional, via "TRACE" arg1, because the feature code

[PATCH v8 33/35] drm-drivers: DRM_CLASSMAP_USE in 2nd batch of drivers, helpers

2024-04-29 Thread Jim Cromie
Add a DRM_CLASSMAP_USE declaration to 2nd batch of helpers and *_drv.c files. For drivers, add the decl just above the module's PARAMs, since it identifies the "inherited" drm.debug param. Note: with CONFIG_DRM_USE_DYNAMIC_DEBUG=y, a module not also declaring DRM_CLASSMAP_USE will have its

[PATCH v8 28/35] dyndbg-doc: explain flags parse 1st

2024-04-29 Thread Jim Cromie
When writing queries to >control, flags are parsed 1st, since they are the only required field. So if the flags draw an error, then keyword errors aren't reported. This can be mildly confusing/annoying, so explain it instead. This note could be moved up to just after the grammar id's the flags,

[PATCH v8 30/35] drm+drivers: adapt to use DYNDBG_CLASSMAP_{DEFINE, USE}

2024-04-29 Thread Jim Cromie
Follow dynamic_debug API change from DECLARE_DYNDBG_CLASSMAP to DYNDBG_CLASSMAP_{DEFINE,USE}. Prior to this, we used DECLARE_DYNDBG_CLASSMAP, which was preserved to decouple DRM conversion. I'm unsure of the full functionality in-between, a round of lkp-testing will help. Fixes: f158936b60a7

[PATCH v8 29/35] dyndbg: add __counted_by annotations

2024-04-29 Thread Jim Cromie
Tell the compiler about our vectors (array,length), in 2 places: h: struct _ddebug_info, which keeps refs to the __dyndbg_* ELF/DATA sections, these are all vectors with a length. c: struct ddebug_table, which has sub-refs into _ddebug_info.* Signed-off-by: Jim Cromie ---

[PATCH v8 26/35] selftests-dyndbg: add test_mod_submod

2024-04-29 Thread Jim Cromie
This new test-fn runs 3 module/submodule modprobe scenarios, variously using both the generic dyndbg= modprobe arg, and the test-module's classmap-params to manipulate the test-mod*'s pr_debugs. In all cases, the current flag-settings are counted and tested vs expectations. The 3rd scenario

[PATCH v8 21/35] dyndbg: treat comma as a token separator

2024-04-29 Thread Jim Cromie
Treat comma as a token terminator, just like a space. This allows a user to avoid quoting hassles when spaces are otherwise needed: :#> modprobe drm dyndbg=class,DRM_UT_CORE,+p\;class,DRM_UT_KMS,+p or as a boot arg: drm.dyndbg=class,DRM_UT_CORE,+p # todo: support multi-query here Given the

[PATCH v8 24/35] selftests-dyndbg: test_percent_splitting multi-cmds on module classes

2024-04-29 Thread Jim Cromie
New fn tests multi-queries composed with % splitters. It uses both test_dynamic_debug and test_dynamic_debug_submod, and manipulates several classes at once. So despite the syntactic-oriented name, it also tests classmaps. Signed-off-by: Jim Cromie --- .../dynamic_debug/dyndbg_selftest.sh

[PATCH v8 23/35] dyndbg: split multi-query strings with %

2024-04-29 Thread Jim Cromie
Multi-query strings have long allowed: modprobe drm dyndbg="class DRM_UT_CORE +p; class DRM_UT_KMS +p" modprobe drm dyndbg=< [ 203.902703] dyndbg: query parse failed [ 203.902871] dyndbg: processed 2 queries, with 0 matches, 2 errs bash: echo: write error: Invalid argument The '%' splits

[PATCH v8 22/35] selftests-dyndbg: add comma_terminator_tests

2024-04-29 Thread Jim Cromie
New fn validates parsing and effect of queries using combinations of commas and spaces to delimit the tokens. It manipulates pr-debugs in builtin module/params, so might have deps I havent foreseen on odd configurations. Signed-off-by: Jim Cromie ---

[PATCH v8 20/35] dyndbg-doc: add classmap info to howto

2024-04-29 Thread Jim Cromie
Describe the 3 API macros providing dynamic_debug's classmaps DYNDBG_CLASSMAP_DEFINE - create, exports a module's classmap DYNDBG_CLASSMAP_USE- refer to exported map DYNDBG_CLASSMAP_PARAM - bind control param to the classmap DYNDBG_CLASSMAP_PARAM_REF + use module's storage - __drm_debug cc:

[PATCH v8 21/35] dyndbg: treat comma as a token separator

2024-04-29 Thread Jim Cromie
Treat comma as a token terminator, just like a space. This allows a user to avoid quoting hassles when spaces are otherwise needed: :#> modprobe drm dyndbg=class,DRM_UT_CORE,+p\;class,DRM_UT_KMS,+p or as a boot arg: drm.dyndbg=class,DRM_UT_CORE,+p # todo: support multi-query here Given the

[PATCH v8 22/35] selftests-dyndbg: add comma_terminator_tests

2024-04-29 Thread Jim Cromie
New fn validates parsing and effect of queries using combinations of commas and spaces to delimit the tokens. It manipulates pr-debugs in builtin module/params, so might have deps I havent foreseen on odd configurations. Signed-off-by: Jim Cromie ---

[PATCH v8 11/35] dyndbg: silence debugs with no-change updates

2024-04-29 Thread Jim Cromie
In ddebug_apply_class_bitmap(), check for actual changes to the bits before announcing them, to declutter logs. no functional change. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/dynamic_debug.c

[PATCH v8 13/35] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap

2024-04-29 Thread Jim Cromie
old_bits arg is currently a pointer to the input bits, but this could allow inadvertent changes to the input by the fn. Disallow this. And constify new_bits while here. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 21 +++-- 1 file changed, 11 insertions(+), 10

[PATCH v8 20/35] dyndbg-doc: add classmap info to howto

2024-04-29 Thread Jim Cromie
Describe the 3 API macros providing dynamic_debug's classmaps DYNDBG_CLASSMAP_DEFINE - create, exports a module's classmap DYNDBG_CLASSMAP_USE- refer to exported map DYNDBG_CLASSMAP_PARAM - bind control param to the classmap DYNDBG_CLASSMAP_PARAM_REF + use module's storage - __drm_debug cc:

[PATCH v8 19/35] dyndbg-API: promote DYNDBG_CLASSMAP_PARAM to API

2024-04-29 Thread Jim Cromie
move the DYNDBG_CLASSMAP_PARAM macro from test-dynamic-debug.c into the header, and refine it, by distinguishing the 2 use cases: 1.DYNDBG_CLASSMAP_PARAM_REF for DRM, to pass in extern __drm_debug by name. dyndbg keeps bits in it, so drm can still use it as before 2.DYNDBG_CLASSMAP_PARAM

[PATCH v8 18/35] selftests-dyndbg: exit 127 if no facility

2024-04-29 Thread Jim Cromie
Test if /proc/dynamic_debug/control exists, exit 127 otherwise. This distinguishes an untestable config from both pass & fail. The 127 choice is pretty arbitrary, but imitating bisect. That control file's presense guarantees that dynamic-debugging is configured (unless /proc is off, unusually),

[PATCH v8 14/35] dyndbg: reduce verbose=3 messages in ddebug_add_module

2024-04-29 Thread Jim Cromie
When modprobing a module, dyndbg currently logs/says "add-module", and then "skipping" if the module has no prdbgs. Instead just check 1st and return quietly. no functional change Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-)

[PATCH v8 09/35] dyndbg: drop NUM_TYPE_ARRAY

2024-04-29 Thread Jim Cromie
ARRAY_SIZE works here, since array decl is complete. no functional change Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index

[PATCH v8 10/35] dyndbg: reduce verbose/debug clutter

2024-04-29 Thread Jim Cromie
currently, for verbose=3, these are logged (blank lines for clarity): dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' dyndbg: flags=0x1 dyndbg: *flagsp=0x1 *maskp=0x dyndbg: parsed: func="" file="" module=""

[PATCH v8 17/35] selftests-dyndbg: add tools/testing/selftests/dynamic_debug/*

2024-04-29 Thread Jim Cromie
Add a selftest script for dynamic-debug. The config requires CONFIG_TEST_DYNAMIC_DEBUG=m (and CONFIG_TEST_DYNAMIC_DEBUG_SUBMOD=m), which tacitly requires either CONFIG_DYNAMIC_DEBUG=y or CONFIG_DYNAMIC_DEBUG_CORE=y ATM this has just basic_tests(), it modifies pr_debug flags in a few builtins

[PATCH v8 08/35] dyndbg: split param_set_dyndbg_classes to _module & wrapper fns

2024-04-29 Thread Jim Cromie
Split api-fn: param_set_dyndbg_classes(), adding modname param and passing NULL in from api-fn. The new arg allows caller to specify that only one module is affected by a prdbgs update. This selectivity will be used later to narrow the scope of changes made. no functional change.

[PATCH v8 15/35] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code

2024-04-29 Thread Jim Cromie
Remove the NAMED class types; these 2 classmap types accept class names at the PARAM interface, for example: echo +DRM_UT_CORE,-DRM_UT_KMS > /sys/module/drm/parameters/debug_names The code works, but its only used by test-dynamic-debug, and wasn't asked for by anyone else, so reduce

[PATCH v8 12/35] dyndbg: tighten ddebug_class_name() 1st arg type

2024-04-29 Thread Jim Cromie
Change function's 1st arg-type, and deref in the caller. The fn doesn't need any other fields in the struct. no functional change. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/dynamic_debug.c

[PATCH v8 16/35] dyndbg-API: fix DECLARE_DYNDBG_CLASSMAP

2024-04-29 Thread Jim Cromie
DECLARE_DYNDBG_CLASSMAP() has a design error; its usage fails a basic K rule: "define once, refer many times". It is used across DRM core & drivers, each use re-defines the classmap understood by that module; and all must match for the modules to respond together when DRM.debug categories are

[PATCH v8 06/35] dyndbg: replace classmap list with a vector

2024-04-29 Thread Jim Cromie
Classmaps are stored in an elf section/array, but are individually list-linked onto dyndbg's per-module ddebug_table for operation. This is unnecessary; even when ddebug_attach_classmap() is handling the builtin section (with classmaps for multiple builtin modules), its contents are ordered, so a

[PATCH v8 04/35] dyndbg: reword "class unknown, " to "class:_UNKNOWN_"

2024-04-29 Thread Jim Cromie
When a dyndbg classname is unknown to a kernel module (as before previous patch), the callsite is un-addressable via >control queries. The control-file displays this condition as "class unknown," currently. That spelling is sub-optimal, so change it to "class:_UNKNOWN_" to loudly announce the

[PATCH v8 05/35] dyndbg: make ddebug_class_param union members same size

2024-04-29 Thread Jim Cromie
struct ddebug_class_param keeps a ref to the state-storage of the param; make both class-types use the same unsigned long storage type. ISTM this is simpler and safer. Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 2 +- lib/dynamic_debug.c | 2 +- 2 files changed, 2

[PATCH v8 07/35] dyndbg: ddebug_apply_class_bitmap - add module arg, select on it

2024-04-29 Thread Jim Cromie
Add param: query_module to ddebug_apply_class_bitmap(), and pass it thru to _ddebug_queries(), replacing NULL with query_module. This allows its caller to update just one module, or all (as currently). We'll use this later to propagate drm.debug to each USEr as they're modprobed. No functional

[PATCH v8 03/35] test-dyndbg: fixup CLASSMAP usage error

2024-04-29 Thread Jim Cromie
A more careful reading of logging output from test_dynamic_debug.ko reveals: lib/test_dynamic_debug.c:103 [test_dynamic_debug]do_cats =pmf "doing categories\n" lib/test_dynamic_debug.c:105 [test_dynamic_debug]do_cats =p "LOW msg\n" class:MID lib/test_dynamic_debug.c:106

[PATCH v8 02/35] docs/dyndbg: update examples \012 to \n

2024-04-29 Thread Jim Cromie
commit 47ea6f99d06e ("dyndbg: use ESCAPE_SPACE for cat control") changed the control-file to display format strings with "\n" rather than "\012". Update the docs to match the new reality. Signed-off-by: Jim Cromie --- Documentation/admin-guide/dynamic-debug-howto.rst | 10 +- 1 file

[PATCH v8 01/35] dyndbg: fix old BUG_ON in >control parser

2024-04-29 Thread Jim Cromie
Fix a BUG_ON from 2009. Even if it looks "unreachable" (I didn't really look), lets make sure by removing it, doing pr_err and return -EINVAL instead. cc: sta...@vger.kernel.org Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[PATCH v8 00/35] fix CONFIG_DRM_USE_DYNAMIC_DEBUG=y regression

2024-04-29 Thread Jim Cromie
hi Greg, Jason, DRM-folk, This patchset fixes the CONFIG_DRM_USE_DYNAMIC_DEBUG=y regression, Fixes: bb2ff6c27bc9 ("drm: Disable dynamic debug as broken") this is v8. Its also here: https://github.com/jimc/linux/tree/dd-classmap-fix-8a v7 had at least 2 problems:

Re: drm-misc migration to Gitlab server

2024-04-29 Thread Helen Koike
On 29/04/2024 14:56, Jani Nikula wrote: On Mon, 29 Apr 2024, Helen Koike wrote: On 01/04/2024 13:49, Tvrtko Ursulin wrote: No issues accessing the repo just a slight confusion and how to handle the workflow. More specifically, if I have a patch which wants to be merged to drm-misc-next, is

[PATCH v2 2/2] drm/nouveau/gsp: Use the sg allocator for level 2 of radix3

2024-04-29 Thread Lyude Paul
Currently we allocate all 3 levels of radix3 page tables using nvkm_gsp_mem_ctor(), which uses dma_alloc_coherent() for allocating all of the relevant memory. This can end up failing in scenarios where the system has very high memory fragmentation, and we can't find enough contiguous memory to

[PATCH v2 1/2] drm/nouveau/firmware: Fix SG_DEBUG error with nvkm_firmware_ctor()

2024-04-29 Thread Lyude Paul
Currently, enabling SG_DEBUG in the kernel will cause nouveau to hit a BUG() on startup: kernel BUG at include/linux/scatterlist.h:187! invalid opcode: [#1] PREEMPT SMP NOPTI CPU: 7 PID: 930 Comm: (udev-worker) Not tainted 6.9.0-rc3Lyude-Test+ #30 Hardware name: MSI MS-7A39/A320M

Re: drm-misc migration to Gitlab server

2024-04-29 Thread Jani Nikula
On Mon, 29 Apr 2024, Helen Koike wrote: > On 01/04/2024 13:49, Tvrtko Ursulin wrote: >> No issues accessing the repo just a slight confusion and how to handle >> the workflow. More specifically, if I have a patch which wants to be >> merged to drm-misc-next, is the mailing list based worklflow

Re: [PATCH 2/2] drm/nouveau/gsp: Use the sg allocator for level 2 of radix3

2024-04-29 Thread Lyude Paul
On Mon, 2024-04-29 at 16:03 +1000, Dave Airlie wrote: > > Currently, this can result in runtime PM issues on systems where > > memory > > Luckily, we don't actually need to allocate coherent memory for the > > page > > table thanks to being able to pass the GPU a radix3 page table for > >

Re: [PATCH] drm: deprecate driver date

2024-04-29 Thread Jani Nikula
On Mon, 29 Apr 2024, Hamza Mahfooz wrote: > On 4/29/24 12:43, Jani Nikula wrote: >> The driver date serves no useful purpose, because it's hardly ever >> updated. The information is misleading at best. >> >> As described in Documentation/gpu/drm-internals.rst: >> >>The driver date,

Re: [PATCH] drm: deprecate driver date

2024-04-29 Thread Hamza Mahfooz
On 4/29/24 12:43, Jani Nikula wrote: The driver date serves no useful purpose, because it's hardly ever updated. The information is misleading at best. As described in Documentation/gpu/drm-internals.rst: The driver date, formatted as MMDD, is meant to identify the date of the latest

[PATCH] drm: drm_of.c: Using EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL

2024-04-29 Thread Sui Jingfeng
Linux kernel puts strict limits on which functions and data structures are available to loadable kernel modules; only those that have been explicitly exported with EXPORT_SYMBOL() or EXPORT_SYMBOL_GPL() are accessible. In the case of EXPORT_SYMBOL_GPL(), only modules that declare a GPL-compatible

Re: nouveau: r535.c:1266:3: error: label at end of compound statement default: with gcc-8

2024-04-29 Thread Arnd Bergmann
On Mon, Apr 29, 2024, at 19:08, Timur Tabi wrote: > On Mon, 2024-04-29 at 17:30 +0200, Linux regression tracking (Thorsten > Leemhuis) wrote: >> TWIMC, there is another report about this in this thread (sadly some of >> its post did not make it to lore): >> >>

[PATCH] drm/panel: ili9341: Remove a superfluous else after return

2024-04-29 Thread Sui Jingfeng
The else clause after the ruturn clause is not useful. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c

Re: nouveau: r535.c:1266:3: error: label at end of compound statement default: with gcc-8

2024-04-29 Thread Timur Tabi
On Mon, 2024-04-29 at 17:30 +0200, Linux regression tracking (Thorsten Leemhuis) wrote: > TWIMC, there is another report about this in this thread (sadly some of > its post did not make it to lore): > > https://lore.kernel.org/all/162ef3c0-1d7b-4220-a21f-b0008657f...@redhat.com/ > > Ciao,

Re: drm-misc migration to Gitlab server

2024-04-29 Thread Helen Koike
On 01/04/2024 13:49, Tvrtko Ursulin wrote: On 12/03/2024 13:56, Maxime Ripard wrote: Hi, On Tue, Feb 20, 2024 at 09:49:25AM +0100, Maxime Ripard wrote: ## Changing the default location repo Dim gets its repos list in the drm-rerere nightly.conf file. We will need to change that file to

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-29 Thread Sui Jingfeng
Hi, On 2024/4/29 19:55, Maxime Ripard wrote: On Sat, Apr 27, 2024 at 01:57:46PM +0800, Sui Jingfeng wrote: Hi, On 2024/4/26 14:23, Maxime Ripard wrote: Hi, On Fri, Apr 26, 2024 at 04:43:18AM +0800, Sui Jingfeng wrote: On 2024/4/26 03:10, Andy Shevchenko wrote: On Fri, Apr 26, 2024 at

Re: [PATCH v4 7/8] drm/v3d: Use gemfs/THP in BO creation if available

2024-04-29 Thread Maíra Canal
Hi Iago, On 4/29/24 02:22, Iago Toral wrote: Hi Maíra, a question below: El dom, 28-04-2024 a las 09:40 -0300, Maíra Canal escribió: Although Big/Super Pages could appear naturally, it would be quite hard to have 1MB or 64KB allocated contiguously naturally. Therefore, we can force the

[PATCH] drm: deprecate driver date

2024-04-29 Thread Jani Nikula
The driver date serves no useful purpose, because it's hardly ever updated. The information is misleading at best. As described in Documentation/gpu/drm-internals.rst: The driver date, formatted as MMDD, is meant to identify the date of the latest modification to the driver. However, as

Re: [PATCH] drm/amd/display: Add MSF panel to DPCD 0x317 patch list

2024-04-29 Thread Alex Deucher
Applied. Thanks! On Fri, Mar 8, 2024 at 8:58 PM wrote: > > From: Tobias Jakobi > > This 8.4 inch panel is integrated in the Ayaneo Kun handheld > device. The panel resolution is 2560×1600, i.e. it has > portrait dimensions. > > Decoding the EDID shows: > Manufacturer: MSF > Model: 4099 >

Re: [PATCH] drm/amd/display: Remove duplicate dcn401/dcn401_clk_mgr.h header

2024-04-29 Thread Alex Deucher
Applied. Thanks! On Wed, Apr 24, 2024 at 11:42 PM Jiapeng Chong wrote: > > ./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c: > dcn401/dcn401_clk_mgr.h is included more than once. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8885 >

Re: [PATCH] drm/amd/display: Remove duplicate spl/dc_spl_types.h header

2024-04-29 Thread Alex Deucher
Applied. Thanks! On Wed, Apr 24, 2024 at 9:52 PM Jiapeng Chong wrote: > > ./drivers/gpu/drm/amd/display/dc/inc/hw/transform.h: spl/dc_spl_types.h is > included more than once. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8884 > Signed-off-by: Jiapeng

Re: [PATCH] drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq()

2024-04-29 Thread Alex Deucher
Applied. Thanks! On Sun, Apr 28, 2024 at 9:32 PM Zhou, Bob wrote: > > [Public] > > Reviewed-by: Bob Zhou > > Regards, > Bob > > -Original Message- > From: Dan Carpenter > Sent: 2024年4月28日 20:57 > To: Zhou, Bob > Cc: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; David

Re: [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-04-29 Thread Jani Nikula
On Mon, 29 Apr 2024, Doug Anderson wrote: > Hi, > > On Mon, Apr 29, 2024 at 2:38 AM Neil Armstrong > wrote: >> >> > +/** >> > + * struct mipi_dsi_multi_context - Context to call multiple MIPI DSI >> > funcs in a row >> > + * @dsi: Pointer to the MIPI DSI device >> > + * @accum_err: Storage for

Re: [PATCH 1/2] drm: print top commit sha after loading the driver

2024-04-29 Thread Lucas De Marchi
On Mon, Apr 29, 2024 at 02:02:28PM GMT, Jani Nikula wrote: On Wed, 24 Apr 2024, Farah Kassabri wrote: Add the last driver sha to the existing log message which prints the drm device info. The commit message fails to answer the most important question: why? Especially, what makes drm devices

Re: nouveau: r535.c:1266:3: error: label at end of compound statement default: with gcc-8

2024-04-29 Thread Linux regression tracking (Thorsten Leemhuis)
On 29.04.24 17:06, Naresh Kamboju wrote: > Following build warnings / errors noticed on Linux next-20240429 tag on the > arm64, arm and riscv with gcc-8 and gcc-13 builds pass. > > Reported-by: Linux Kernel Functional Testing > > Commit id: > b58a0bc904ff nouveau: ad

nouveau: r535.c:1266:3: error: label at end of compound statement default: with gcc-8

2024-04-29 Thread Naresh Kamboju
Following build warnings / errors noticed on Linux next-20240429 tag on the arm64, arm and riscv with gcc-8 and gcc-13 builds pass. Reported-by: Linux Kernel Functional Testing Commit id: b58a0bc904ff nouveau: add command-line GSP-RM registry support Buids: -- gcc-8-arm64-defconfig - Fail

Re: [PATCH v4 05/16] SoC: mediatek: mt8365: support audio clock control

2024-04-29 Thread Mark Brown
On Fri, Apr 26, 2024 at 07:22:34PM +0200, Alexandre Mergnat wrote: > Add audio clock wrapper and audio tuner control. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in

Re: [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-04-29 Thread Doug Anderson
Hi, On Mon, Apr 29, 2024 at 2:38 AM Neil Armstrong wrote: > > > +/** > > + * struct mipi_dsi_multi_context - Context to call multiple MIPI DSI funcs > > in a row > > + * @dsi: Pointer to the MIPI DSI device > > + * @accum_err: Storage for the accumulated error over the multiple calls. > > Init

Re: [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-04-29 Thread Doug Anderson
Hi, On Fri, Apr 26, 2024 at 11:33 PM Sam Ravnborg wrote: > > > --- > > Right now this patch introduces two new functions in > > drm_mipi_dsi.c. Alternatively we could have changed the prototype of > > the "chatty" functions and made the deprecated macros adapt to the new > > prototype. While

RE: [PATCH] drm/i915/gt: Automate CCS Mode setting during engine resets

2024-04-29 Thread Gibala, Krzysztof
Tested-by: Krzysztof Gibala -Original Message- From: Andi Shyti Sent: Friday, April 26, 2024 2:07 AM To: intel-gfx ; dri-devel Cc: Andi Shyti ; Andi Shyti ; Gnattu OC ; Chris Wilson ; Joonas Lahtinen ; Roper, Matthew D ; sta...@vger.kernel.org Subject: [PATCH] drm/i915/gt:

Re: [PATCH v3] drm/i915/vma: Fix UAF on reopen vs destroy race

2024-04-29 Thread Thomas Hellström
On Thu, 2024-04-25 at 20:42 +0200, Janusz Krzysztofik wrote: > Hi Thomas, > > On Tuesday, 16 April 2024 18:40:12 CEST Rodrigo Vivi wrote: > > On Tue, Apr 16, 2024 at 10:09:46AM +0200, Janusz Krzysztofik wrote: > > > Hi Rodrigo, > > > > > > On Tuesday, 16 April 2024 03:16:31 CEST Rodrigo Vivi

Re: [PATCH] MAINTAINERS: Move the drm-intel repo location to fd.o GitLab

2024-04-29 Thread Rodrigo Vivi
On Fri, Apr 26, 2024 at 05:02:54PM +0100, Tvrtko Ursulin wrote: > > > On 26/04/2024 16:47, Lucas De Marchi wrote: > > On Wed, Apr 24, 2024 at 01:41:59PM GMT, Ryszard Knop wrote: > > > The drm-intel repo is moving from the classic fd.o git host to GitLab. > > > Update its location with a URL

Re: [PATCH] drm/i915/gt: Automate CCS Mode setting during engine resets

2024-04-29 Thread Rodrigo Vivi
On Fri, Apr 26, 2024 at 02:07:23AM +0200, Andi Shyti wrote: > We missed setting the CCS mode during resume and engine resets. > Create a workaround to be added in the engine's workaround list. > This workaround sets the XEHP_CCS_MODE value at every reset. > > The issue can be reproduced by

Re: [PATCH v1 1/1] drm/ili9341: Remove the duplicative driver

2024-04-29 Thread Andy Shevchenko
On Mon, Apr 29, 2024 at 01:39:06PM +0200, Maxime Ripard wrote: > On Thu, Apr 25, 2024 at 06:04:50PM +0300, Andy Shevchenko wrote: > > On Thu, Apr 25, 2024 at 04:58:06PM +0200, Maxime Ripard wrote: > > > On Thu, Apr 25, 2024 at 03:42:07PM +0300, Andy Shevchenko wrote: > > > > First of all, the

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-29 Thread Maxime Ripard
On Sat, Apr 27, 2024 at 01:57:46PM +0800, Sui Jingfeng wrote: > Hi, > > > On 2024/4/26 14:23, Maxime Ripard wrote: > > Hi, > > > > On Fri, Apr 26, 2024 at 04:43:18AM +0800, Sui Jingfeng wrote: > > > On 2024/4/26 03:10, Andy Shevchenko wrote: > > > > On Fri, Apr 26, 2024 at 02:08:16AM +0800, Sui

Re: [PATCH v1 1/1] drm/ili9341: Remove the duplicative driver

2024-04-29 Thread Maxime Ripard
On Thu, Apr 25, 2024 at 06:04:50PM +0300, Andy Shevchenko wrote: > On Thu, Apr 25, 2024 at 04:58:06PM +0200, Maxime Ripard wrote: > > Hi, > > > > On Thu, Apr 25, 2024 at 03:42:07PM +0300, Andy Shevchenko wrote: > > > First of all, the driver was introduced when it was already > > > two drivers

Re: drm/debugfs: Drop conditionals around of_node pointers

2024-04-29 Thread Maxime Ripard
On Sun, Apr 28, 2024 at 04:52:13PM +0800, Sui Jingfeng wrote: > ping > > 在 2024/3/22 06:22, Sui Jingfeng 写道: > > Having conditional around the of_node pointer of the drm_bridge structure > > turns out to make driver code use ugly #ifdef blocks. The code being ugly is an opinion, what problem is

Re: [PATCH] drm/debugfs: Drop conditionals around of_node pointers

2024-04-29 Thread Dmitry Baryshkov
On Fri, Mar 22, 2024 at 06:22:58AM +0800, Sui Jingfeng wrote: > Having conditional around the of_node pointer of the drm_bridge structure > turns out to make driver code use ugly #ifdef blocks. Drop the conditionals > to simplify debugfs. > > Fixes: d8dfccde2709 ("drm/bridge: Drop conditionals

Re: [PATCH RESEND] Revert "drm/bridge: ti-sn65dsi83: Fix enable error path"

2024-04-29 Thread Robert Foss
On Fri, 26 Apr 2024 14:22:59 +0200, Luca Ceresoli wrote: > This reverts commit 8a91b29f1f50ce7742cdbe5cf11d17f128511f3f. > > The regulator_disable() added by the original commit solves one kind of > regulator imbalance but adds another one as it allows the regulator to be > disabled one more time

Re: [PATCH] drm/kmb: Replace of_node_put() with automatic cleanup handler

2024-04-29 Thread Javier Carrasco
On 4/10/24 22:45, Javier Carrasco wrote: > Make use of the __free() cleanup handler to automatically free nodes > when they get out of scope. > > Suggested-by: Julia Lawall > Signed-off-by: Javier Carrasco > --- > The patch is based on the latest linux-next tag (next-20240410). > --- >

Re: [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-04-29 Thread Neil Armstrong
Hello Mister Anderson, On 27/04/2024 01:58, Douglas Anderson wrote: The current mipi_dsi_*_write_seq() macros are non-intutitive because they contain a hidden "return" statement that will return out of the _caller_ of the macro. Let's mark them as deprecated and instead introduce some new

Re: [PATCH] drm/i915/gt: Disarm breadcrumbs if engines are already idle

2024-04-29 Thread Janusz Krzysztofik
Hi Andrzej, On Friday, 26 April 2024 18:13:02 CEST Nirmoy Das wrote: > > On 4/23/2024 6:23 PM, Janusz Krzysztofik wrote: > > From: Chris Wilson > > > > The breadcrumbs use a GT wakeref for guarding the interrupt, but are > > disarmed during release of the engine wakeref. This leaves a hole

Re: [PATCH v2 0/8] drm/mipi-dsi: Reduce bloat and add funcs for cleaner init seqs

2024-04-29 Thread Jani Nikula
On Fri, 26 Apr 2024, Douglas Anderson wrote: > The consensus of many DRM folks is that we want to move away from DSI > drivers defining tables of init commands. Instead, we want to move to > init functions that can use common DRM functions. The issue thus far > has been that using the macros

Re: [PATCH 06/23] drm/xe/svm: Introduce a helper to build sg table from hmm range

2024-04-29 Thread Thomas Hellström
On Fri, 2024-04-26 at 13:35 -0300, Jason Gunthorpe wrote: > On Fri, Apr 26, 2024 at 04:49:26PM +0200, Thomas Hellström wrote: > > On Fri, 2024-04-26 at 09:00 -0300, Jason Gunthorpe wrote: > > > On Fri, Apr 26, 2024 at 11:55:05AM +0200, Thomas Hellström wrote: > > > > First, the gpu_vma structure

Re: [PATCH v4 8/8] drm/v3d: Add modparam for turning off Big/Super Pages

2024-04-29 Thread Tvrtko Ursulin
On 28/04/2024 13:40, Maíra Canal wrote: Add a modparam for turning off Big/Super Pages to make sure that if an user doesn't want Big/Super Pages enabled, it can disabled it by setting the modparam to false. Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_drv.c | 7 +++

Re: [PATCH] drm/stm: dsi: relax mode_valid clock tolerance

2024-04-29 Thread Sean Nyekjaer
Hi, On Wed, Apr 24, 2024 at 09:21:17AM UTC, Maxime Ripard wrote: > Hi, > > Sorry, my previous review didn't go through. > > On Fri, Mar 22, 2024 at 11:47:31AM +0100, Sean Nyekjaer wrote: > > When using the DSI interface via DSI2LVDS bridge, it seems a bit harsh > > to reguire the requested and

Re: [PATCH v2 3/6] drm/xe: Add helper to accumulate exec queue runtime

2024-04-29 Thread Tvrtko Ursulin
On 26/04/2024 19:59, Umesh Nerlige Ramappa wrote: On Fri, Apr 26, 2024 at 11:49:32AM +0100, Tvrtko Ursulin wrote: On 24/04/2024 00:56, Lucas De Marchi wrote: From: Umesh Nerlige Ramappa Add a helper to accumulate per-client runtime of all its exec queues. Currently that is done in 2

[PATCH] drm/exynos: Add check for dma_set_max_seg_size

2024-04-29 Thread Chen Ni
Add check for the return value of dma_set_max_seg_size() and return the error if it fails in order to catch the error. Fixes: ddfd4ab6bb08 ("drm/exynos: Fix dma_parms allocation") Signed-off-by: Chen Ni --- drivers/gpu/drm/exynos/exynos_drm_dma.c | 5 - 1 file changed, 4 insertions(+), 1

Re: [PATCH] drm/fb_dma: Add checks in drm_fb_dma_get_scanout_buffer()

2024-04-29 Thread Thomas Zimmermann
Am 26.04.24 um 14:10 schrieb Jocelyn Falempe: plane->state and plane->state->fb can be NULL, so add a check before dereferencing them. Found by testing with the imx driver. Fixes: 879b3b6511fe9 ("drm/fb_dma: Add generic get_scanout_buffer() for drm_panic") Signed-off-by: Jocelyn Falempe

Re: After suspend/resume cycle ASPEED VGA monitor suffers with "No Signal" state.

2024-04-29 Thread Thomas Zimmermann
Hi Am 23.04.24 um 21:51 schrieb Cary Garrett: Hello, An Aspeed VGA monitor, in my case AST 2400, after a suspend/resume cycle suffers with a "No Signal" state. This is also true of a IPMI/BMC remote console. To restore the "Signal" state requires a reboot or the following workaround. To

Re: [PATCH] drm/virtio: fix memory leak of vbuf

2024-04-29 Thread Markus Elfring
… > Therefore, when upload fails,vbuf needs to be free directly. Please choose a corresponding imperative wording for an improved change description. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n94 Regards,

Re: [PATCH v4 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC

2024-04-29 Thread Krzysztof Kozlowski
On 26/04/2024 19:22, Alexandre Mergnat wrote: >regulators: > type: object > $ref: /schemas/regulator/mediatek,mt6357-regulator.yaml > @@ -83,6 +111,12 @@ examples: > interrupt-controller; > #interrupt-cells = <2>; > > +audio-codec { > +

Re: [PATCH 2/2] drm/nouveau/gsp: Use the sg allocator for level 2 of radix3

2024-04-29 Thread Dave Airlie
> Currently, this can result in runtime PM issues on systems where memory > Luckily, we don't actually need to allocate coherent memory for the page > table thanks to being able to pass the GPU a radix3 page table for > suspend/resume data. So, let's rewrite nvkm_gsp_radix3_sg() to use the sg >

Re: [PATCH v4 02/16] ASoC: dt-bindings: mediatek,mt8365-mt6357: Add audio sound card document

2024-04-29 Thread Krzysztof Kozlowski
On 26/04/2024 19:22, Alexandre Mergnat wrote: > + link-name: > +description: Indicates dai-link name and PCM stream name > +enum: > + - I2S_IN_BE > + - I2S_OUT_BE > + - PCM1_BE > + - PDM1_BE > + - PDM2_BE > + - PDM3_BE > +

  1   2   >