t; NSEC_PER_SEC)
[...]
There's an off-by-one error between the subject line and the actual
changes. The subject line seems to have the correct comparison.
Ben.
--
Ben Hutchings, Software Developer Codethink Ltd
https://www.codethink.co.uk/ Dale Ho
Paul
Signed-off-by: Bjorn Helgaas
Cc: nouv...@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Cc: Karol Herbst
Cc: Ben Skeggs
[bwh: Backported to 3.16:
- Use dev_{err,info}() instead of pci_{err,info}()
- Adjust context]
Signed-off-by: Ben Hutchings
---
drivers/p
This is one of several modes sometimes called WXGA.
Signed-off-by: Ben Hutchings
---
Documentation/EDID/1280x768.S | 45 +++
1 file changed, 45 insertions(+)
create mode 100644 Documentation/EDID/1280x768.S
diff --git a/Documentation/EDID/1280x768.S b
and subtractions and fix the comment.
Signed-off-by: Ben Hutchings
---
Documentation/EDID/1024x768.S | 4 ++--
Documentation/EDID/1280x1024.S | 4 ++--
Documentation/EDID/1600x1200.S | 4 ++--
Documentation/EDID/1680x1050.S | 4 ++--
Documentation/EDID/1920x1080.S | 4 ++--
Documentation/EDID/800x600.S
Hiding all commands is unhelpful unless there's some way to override
it (e.g. Kbuild's V=1). The -s option is available for those who like
it.
Signed-off-by: Ben Hutchings
---
Documentation/EDID/Makefile | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
.
Signed-off-by: Ben Hutchings
---
Documentation/EDID/edid.S | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/Documentation/EDID/edid.S b/Documentation/EDID/edid.S
index ce4b8b4a20b2..8abbf6c24d88 100644
--- a/Documentation/EDID/edid.S
+++ b/Documentation/EDID/edid.S
@@ -48,8
This should match standard HDTV 720p 60 Hz timings.
Signed-off-by: Ben Hutchings
---
Documentation/EDID/1280x720.S | 45 +++
1 file changed, 45 insertions(+)
create mode 100644 Documentation/EDID/1280x720.S
diff --git a/Documentation/EDID/1280x720.S b
.S
create mode 100644 Documentation/EDID/1280x768.S
--
Ben Hutchings, Software Developer Codethink Ltd
https://www.codethink.co.uk/ Dale House, 35 Dale Street
Manchester, M1 2HF, Unit
m/msm: fix leak in failed get_pages")
Signed-off-by: Ben Hutchings <ben.hutchi...@codethink.co.uk>
---
drivers/gpu/drm/msm/msm_gem.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
in
ted to 3.16: pipe_config is a struct not a pointer]
Signed-off-by: Ben Hutchings <b...@decadent.org.uk>
---
drivers/gpu/drm/i915/intel_display.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/
Adreno firmware files is now in qcom/
> > > subfolder,
> > > especially now that we are adding some of them in linux-firmware.
> > >
> > > Reported-by: Ben Hutchings <b...@decadent.org.uk>
> > > Signed-off-by: Nicolas Dechesne <nicolas.deche.
e were running in IRQ context from
> the HPD signal.
>
> Thus this patch changes the logic to handle the HPD signal
> via a work_struct so we can be out of irq context.
[...]
Shouldn't there also be a cancel_work_sync() in the remove function?
Ben.
--
Ben Hutchings
Software Developer, Code
: -6
and I can log in there. But, as the driver detects this error after the
point of no return (remove_conflicting_framebuffers()), the display
remains broken.
Ben.
--
Ben Hutchings
The program is absolutely right; therefore, the computer must be wrong.
-- next part --
-prefetchable) [size=8M]
> Expansion ROM at [disabled]
> Capabilities: [dc] Power Management version 1
> Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA
> PME(D0-,D1-,D2-,D3hot-,D3cold-)
> Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
[...
e(rdev);
> else
> @@ -1614,8 +1650,12 @@ static int radeon_debugfs_pm_info(struct seq_file *m,
> void *data)
> struct drm_info_node *node = (struct drm_info_node *) m->private;
> struct drm_device *dev = node->minor->dev;
> struct radeon_device *rdev
n
> create mode 100644 radeon/HAWAII_rlc.bin
> create mode 100644 radeon/HAWAII_sdma.bin
> create mode 100644 radeon/HAWAII_smc.bin
[...]
Applied, thanks.
Ben.
--
Ben Hutchings
friends: People who know you well, but like you anyway.
-- next part ---
buffer.
Signed-off-by: Chris Wilson
Cc: Dave Airlie
Reviewed-by: Ville Syrj?l?
Cc: dri-devel at lists.freedesktop.org
Signed-off-by: Dave Airlie
Signed-off-by: Ben Hutchings
---
drivers/gpu/drm/drm_drv.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
--- a/drivers/gpu/drm/drm_drv.c
)dma->pagelist[page_nr]);
get_page(page);
vmf->page = page;
--
Ben Hutchings
If at first you don't succeed, you're doing about average.
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 b
By definition, the page offset will not affect the result.
Compile-tested only.
Signed-off-by: Ben Hutchings
---
drivers/gpu/drm/drm_vm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_vm.c b/drivers/gpu/drm/drm_vm.c
index b5c5af7..8ef6503 100644
Various bits of code are mixing making assumptions about the size of
dma_addr_t or resource_size_t, or mixing up pointer and integer types.
All these fixes are based on compiler warnings and so far as I can see
the bugs are practically harmless.
Ben.
Ben Hutchings (8):
IB/cxgb4: Fix
connector {
> > __u32 connection;
> > __u32 mm_width, mm_height; /**< HxW in millimeters */
> > __u32 subpixel;
> > +
> > + __u32 pad;
> > };
> >
> > #define DRM_MODE_PROP_PENDING (1<<0)
> > --
> > 1.8.4.rc3
>
On Wed, 2013-09-18 at 16:33 -0400, Alex Deucher wrote:
On Wed, Sep 18, 2013 at 4:32 PM, Alex Deucher alexdeuc...@gmail.com wrote:
Hi Ben,
The attached patches add new firmware for radeon GPUs. Please apply
to the firmware tree.
Attached this time...
Applied, thanks.
Ben.
--
Ben
On Wed, 2013-05-15 at 15:28 -0400, Alex Deucher wrote:
> Hi Ben,
>
> The attached patch adds the new radeon ucode required for the new
> hainan asic. Please apply to the firmware tree.
Applied, thanks.
Ben.
--
Ben Hutchings
Experience is what causes a person to make new mist
On Wed, 2013-05-15 at 15:28 -0400, Alex Deucher wrote:
Hi Ben,
The attached patch adds the new radeon ucode required for the new
hainan asic. Please apply to the firmware tree.
Applied, thanks.
Ben.
--
Ben Hutchings
Experience is what causes a person to make new mistakes instead of old
On Fri, 2013-04-12 at 11:26 -0400, Alex Deucher wrote:
> Hi Ben,
>
> Attached are patches for the Linux firmware tree to update to the
> latest ucode for UVD support and adds support for the new Oland GPUs.
>
> Thanks!
Applied, thanks.
Ben.
--
Ben Hutchings
All extremis
On Fri, 2013-04-12 at 11:26 -0400, Alex Deucher wrote:
Hi Ben,
Attached are patches for the Linux firmware tree to update to the
latest ucode for UVD support and adds support for the new Oland GPUs.
Thanks!
Applied, thanks.
Ben.
--
Ben Hutchings
All extremists should be taken out
mp; ACPI_WMI)
Make all the ACPI support depend on X86 and select
X86_PLATFORM_DEVICES.
Signed-off-by: Ben Hutchings
---
Debian has had this patch (or earlier versions of it) for the last 20
months. I submitted it previously but didn't receive any response.
Please apply or explain what's wrong with
depend on X86 and select
X86_PLATFORM_DEVICES.
Signed-off-by: Ben Hutchings b...@decadent.org.uk
---
Debian has had this patch (or earlier versions of it) for the last 20
months. I submitted it previously but didn't receive any response.
Please apply or explain what's wrong with it.
Ben
eeds to be set always to "1", Project: DevSNB
>
> Reviewed-by: Rodrigo Vivi
> Signed-off-by: Daniel Vetter
> Signed-off-by: Abdallah Chatila
[...]
Also queued up for 3.2, thanks.
Ben.
--
Ben Hutchings
Everything shou
: DevSNB
Reviewed-by: Rodrigo Vivi rodrigo.v...@gmail.com
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
Signed-off-by: Abdallah Chatila abdallah.chat...@ericsson.com
[...]
Also queued up for 3.2, thanks.
Ben.
--
Ben Hutchings
Everything should be made as simple as possible, but not simpler
://bugs.freedesktop.org/show_bug.cgi?id=56139
> >
> > Signed-off-by: Alex Deucher
> > Cc: stable at vger.kernel.org
>
> Looks like the stable cc got dropped when this patch got pulled. The
> original patch was backported to older kernels.
[...]
Queued up for 3.2, thanks.
B
/show_bug.cgi?id=56139
Signed-off-by: Alex Deucher alexander.deuc...@amd.com
Cc: sta...@vger.kernel.org
Looks like the stable cc got dropped when this patch got pulled. The
original patch was backported to older kernels.
[...]
Queued up for 3.2, thanks.
Ben.
--
Ben Hutchings
Design
6 merge window, so newer kernels don't need it.
[...]
Added to the queue for 3.2, thanks.
Ben.
--
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application
don't need it.
[...]
Added to the queue for 3.2, thanks.
Ben.
--
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.
signature.asc
Description: This is a digitally signed message part
___
dri-devel mailing list
dri-devel
On Sun, 2012-10-07 at 15:11 +0100, Chris Wilson wrote:
> On Sun, 07 Oct 2012 15:01:17 +0100, Ben Hutchings
> wrote:
> > On Mon, 2012-10-01 at 03:24 -0700, Jonathan Nieder wrote:
> > > Hi Ben,
> > >
> > > Please consider
> > >
> > >
with this patch, and with libdrm lacking 2.4.34~22 and 2.4.38~10,
>X freezes at startup.
>
> "No regressions" means you probably shouldn't take this patch without
> a safety to work around the old X userspace,
[...]
Then this workaround is also required in mainline. And o
On Sun, 2012-10-07 at 15:11 +0100, Chris Wilson wrote:
On Sun, 07 Oct 2012 15:01:17 +0100, Ben Hutchings b...@decadent.org.uk
wrote:
On Mon, 2012-10-01 at 03:24 -0700, Jonathan Nieder wrote:
Hi Ben,
Please consider
cc22a938fc1d drm/i915: add Ivy Bridge GT2 Server entries
el/git/torvalds/linux.git;a=commit;h=bc42aabc6a01b92b0f961d65671564e0e1cd7592
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=17629
Signed-off-by: Paul Menzel
Cc:
Cc: Adam Jackson
Cc: Ian Pilcher
Signed-off-by: Dave Airlie
Signed-off-by: Ben Hutchings
---
drivers/gpu/drm/drm_edid.c
...@gmail.com
Signed-off-by: Dave Airlie airl...@redhat.com
Signed-off-by: Ben Hutchings b...@decadent.org.uk
---
drivers/gpu/drm/drm_edid.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index a8743c3..b7ee230 100644
--- a/drivers/gpu
Most architectures define virt_to_page() as a macro that casts its
argument such that an argument of type unsigned long will be accepted
without complaint. However, the proper type is void *, and passing
unsigned long results in a warning on MIPS.
Signed-off-by: Ben Hutchings
---
drivers/gpu
By definition, the page offset will not affect the result.
Compile-tested only.
Signed-off-by: Ben Hutchings
---
drivers/gpu/drm/drm_vm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/drm_vm.c b/drivers/gpu/drm/drm_vm.c
index 8c03eaf..98c3922 100644
This series fixes compiler warnings on some architectures about implicit
conversions and narrowing conversions between pointer and integer types.
Please apply these to the appropriate trees.
Ben.
Ben Hutchings (8):
IB/cxgb4: Fix formatting of physical address
farsync: Fix confusion about
On Tue, Dec 20, 2011 at 05:32:13PM +0100, Daniel Vetter wrote:
> On Tue, Dec 20, 2011 at 12:09:39AM +0000, Ben Hutchings wrote:
> > [Re-sent to the right address, I hope.]
> >
> > Kees, in commit 01e2f533a234dc62d16c0d3d4fb9d71cf1ce50c3 ("drm: do not
> > leak kern
On Mon, 2011-12-19 at 18:35 -0800, Kees Cook wrote:
> On Mon, Dec 19, 2011 at 6:18 PM, Ben Hutchings wrote:
> > On Mon, 2011-12-19 at 16:14 -0800, Kees Cook wrote:
> >> On Mon, Dec 19, 2011 at 4:09 PM, Ben Hutchings
> >> wrote:
> >> > Kees, in commit 0
On Mon, 2011-12-19 at 16:14 -0800, Kees Cook wrote:
> On Mon, Dec 19, 2011 at 4:09 PM, Ben Hutchings wrote:
> > Kees, in commit 01e2f533a234dc62d16c0d3d4fb9d71cf1ce50c3 ("drm: do not
> > leak kernel addresses via /proc/dri/*/vma") you changed the l
physical address may be truncated
(in theory at least).
I think it would make more sense to make this entire file readable by
root only, but I don't know whether anything depends on being able to
read it. Its existence is conditional on DRM_DEBUG_CODE != 0 but that
is always true at the moment
On Tue, Dec 20, 2011 at 05:32:13PM +0100, Daniel Vetter wrote:
On Tue, Dec 20, 2011 at 12:09:39AM +, Ben Hutchings wrote:
[Re-sent to the right address, I hope.]
Kees, in commit 01e2f533a234dc62d16c0d3d4fb9d71cf1ce50c3 (drm: do not
leak kernel addresses via /proc/dri/*/vma) you
This series fixes compiler warnings on some architectures about implicit
conversions and narrowing conversions between pointer and integer types.
Please apply these to the appropriate trees.
Ben.
Ben Hutchings (8):
IB/cxgb4: Fix formatting of physical address
farsync: Fix confusion about
By definition, the page offset will not affect the result.
Compile-tested only.
Signed-off-by: Ben Hutchings b...@decadent.org.uk
---
drivers/gpu/drm/drm_vm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/drm_vm.c b/drivers/gpu/drm/drm_vm.c
index
Most architectures define virt_to_page() as a macro that casts its
argument such that an argument of type unsigned long will be accepted
without complaint. However, the proper type is void *, and passing
unsigned long results in a warning on MIPS.
Signed-off-by: Ben Hutchings b
ast).
I think it would make more sense to make this entire file readable by
root only, but I don't know whether anything depends on being able to
read it. Its existence is conditional on DRM_DEBUG_CODE != 0 but that
is always true at the moment.
Ben.
--
Ben Hutchings
Humans are not rational bein
at least).
I think it would make more sense to make this entire file readable by
root only, but I don't know whether anything depends on being able to
read it. Its existence is conditional on DRM_DEBUG_CODE != 0 but that
is always true at the moment.
Ben.
--
Ben Hutchings
Humans are not rational
On Mon, 2011-12-19 at 16:14 -0800, Kees Cook wrote:
On Mon, Dec 19, 2011 at 4:09 PM, Ben Hutchings b...@decadent.org.uk wrote:
Kees, in commit 01e2f533a234dc62d16c0d3d4fb9d71cf1ce50c3 (drm: do not
leak kernel addresses via /proc/dri/*/vma) you changed the logging of
high_memory
On Mon, 2011-12-19 at 18:35 -0800, Kees Cook wrote:
On Mon, Dec 19, 2011 at 6:18 PM, Ben Hutchings b...@decadent.org.uk wrote:
On Mon, 2011-12-19 at 16:14 -0800, Kees Cook wrote:
On Mon, Dec 19, 2011 at 4:09 PM, Ben Hutchings b...@decadent.org.uk
wrote:
Kees, in commit
sense to make this entire file readable by
root only, but I don't know whether anything depends on being able to
read it. Its existence is conditional on DRM_DEBUG_CODE != 0 but that
is always true at the moment.
Ben.
--
Ben Hutchings
Humans are not rational beings; they are rationalising beings
kms: Add support for interrupts on r6xx/r7xx chips (v3)
And the 'Northern Islands' GPUs and 'Fusion' APUs appear to require the
'MC' firmware blobs:
commit 0af62b0168043896a042b005ff88caa77dd94d04
Author: Alex Deucher
Date: Thu Jan 6 21:19:31 2011 -0500
drm/radeon/kms: add ucode loader
21:19:31 2011 -0500
drm/radeon/kms: add ucode loader for NI
Therefore I think that at least r600_init(), rv770_init(),
evergreen_init() and cayman_init() should be treating failure to load
firmware as a fatal error.
Ben.
--
Ben Hutchings
Teamwork is essential - it allows you to blame
These operations are required to be atomic and therefore they
must be suitable for use with volatile-qualified variables.
Ben.
--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus
away. If you see more
warnings of that kind, it's probably fine to just do the same on m68k.
The volatile modifier doesn't really hurt in this case.
These operations are required to be atomic and therefore they
must be suitable for use with volatile-qualified variables.
Ben.
--
Ben Hutchings
We
The ACPI support code probably wasn't very useful on ia64, and now
depends on mxm-wmi which is definitely x86-only.
Compile-tested on ia64 and i386.
Signed-off-by: Ben Hutchings
---
drivers/gpu/drm/nouveau/Kconfig |4 ++--
drivers/gpu/drm/nouveau/Makefile |2 ++
drivers/gpu
On Mon, 2011-03-21 at 07:38 +, Chris Wilson wrote:
> On Sun, 20 Mar 2011 23:07:04 +0000, Ben Hutchings
> wrote:
> > Applying this quirk to the 855GM in all systems causes regressions
> > (Debian bugs #493096, #619019). Instead, apply the quirk to specific
> > model
Add some more IDs as listed in the old X driver.
Signed-off-by: Ben Hutchings
---
Is there some reason these were omitted from the kernel driver?
If not, it seems sensible to include them.
Ben.
drivers/gpu/drm/i915/intel_display.c |8
1 files changed, 8 insertions(+), 0 deletions
if pipe A was turned
off. However, that seems to be a problem only when using UMS. So
remove the quirk for the 845G as well.
Signed-off-by: Ben Hutchings
---
Needs people to test it, as I can't.
Ben.
drivers/gpu/drm/i915/intel_display.c | 23 +++
1 files changed, 19 insertions
On Mon, 2011-03-21 at 07:38 +, Chris Wilson wrote:
On Sun, 20 Mar 2011 23:07:04 +, Ben Hutchings b...@decadent.org.uk
wrote:
Applying this quirk to the 855GM in all systems causes regressions
(Debian bugs #493096, #619019). Instead, apply the quirk to specific
models as listed
Add some more IDs as listed in the old X driver.
Signed-off-by: Ben Hutchings b...@decadent.org.uk
---
Is there some reason these were omitted from the kernel driver?
If not, it seems sensible to include them.
Ben.
drivers/gpu/drm/i915/intel_display.c |8
1 files changed, 8
if pipe A was turned
off. However, that seems to be a problem only when using UMS. So
remove the quirk for the 845G as well.
Signed-off-by: Ben Hutchings b...@decadent.org.uk
---
Needs people to test it, as I can't.
Ben.
drivers/gpu/drm/i915/intel_display.c | 23 +++
1 files
CONFIG_ACPI_VIDEO depends on more than just CONFIG_ACPI, so add those
dependencies to the Kconfig select condition and make the code
conditional on CONFIG_ACPI_VIDEO.
Signed-off-by: Ben Hutchings
---
On Sat, 2010-12-25 at 16:21 +0100, Francisco Jerez wrote:
[...]
> > --- a/drivers/g
CONFIG_ACPI_VIDEO depends on more than just CONFIG_ACPI, so add those
dependencies to the Kconfig select condition and make the code
conditional on CONFIG_ACPI_VIDEO.
Fixes building for ia64 (ACPI && !X86).
Signed-off-by: Ben Hutchings
---
Please send this up to Linus for 2.6.
this build failure here:
>
> http://lkml.org/lkml/2010/8/23/127
>
> Is there no other way to fix this? From the Kconfig description
> of VGA_ARB I thought I would not need this (and it's a new thing too),
> so why make my kernel bigger so easily?
should define dummy
s_sideport_present(rdev);
if (r)
return r;
return 0;
--
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: applica
. Do you have any suggestions for how we should to this?
Could you maintain a drm-2.6.33 branch?
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type
. Do you have any suggestions for how we should to this?
Could you maintain a drm-2.6.33 branch?
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
signature.asc
Description: This is a digitally signed message part
-mc.igp_sideport_enabled = radeon_atombios_sideport_present(rdev);
if (r)
return r;
return 0;
--
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
signature.asc
Description: This is a digitally signed message part
Make inclusion of asm/agp.h conditional on TTM_HAS_AGP. The use
of the functions declared in it is already conditional.
Reported-by: Geert Stappers stapp...@stappers.nl
Signed-off-by: Ben Hutchings b...@decadent.org.uk
Tested-by: Geert Stappers stapp...@stappers.nl
---
drivers/gpu/drm/ttm
Make inclusion of conditional on TTM_HAS_AGP. The use
of the functions declared in it is already conditional.
Reported-by: Geert Stappers
Signed-off-by: Ben Hutchings
Tested-by: Geert Stappers
---
drivers/gpu/drm/ttm/ttm_page_alloc.c |2 ++
1 files changed, 2 insertions(+), 0 deletions
75 matches
Mail list logo
