Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-22 Thread Boqun Feng
On Thu, May 23, 2024 at 08:15:13AM +0900, FUJITA Tomonori wrote: > Hi, > > On Wed, 22 May 2024 09:37:30 +0200 > Philipp Stanner wrote: > > >> > +/// Abstraction around a C firmware struct. > >> > +/// > >> > +/// This is a simple abstraction around the C firmware API. Just > >> > like with the

Re: [PATCH RFC 03/18] rust: drm: file: Add File abstraction

2023-03-13 Thread Boqun Feng
On Mon, Mar 13, 2023 at 12:49:57PM -0500, Faith Ekstrand wrote: > On Fri, 2023-03-10 at 07:16 +0900, Asahi Lina wrote: > > On 10/03/2023 06.16, Faith Ekstrand wrote: > > > On Tue, 2023-03-07 at 23:25 +0900, Asahi Lina wrote: > > > > A DRM File is the DRM counterpart to a kernel file structure, > >

Re: [PATCH RFC 02/18] rust: drm: Add Device and Driver abstractions

2023-03-10 Thread Boqun Feng
On Tue, Mar 07, 2023 at 11:25:27PM +0900, Asahi Lina wrote: > Add the initial abstractions for DRM drivers and devices. These go > together in one commit since they are fairly tightly coupled types. > > A few things have been stubbed out, to be implemented as further bits of > the DRM subsystem

Re: [PATCH RFC 02/18] rust: drm: Add Device and Driver abstractions

2023-03-10 Thread Boqun Feng
On Tue, Mar 07, 2023 at 11:25:27PM +0900, Asahi Lina wrote: [...] > + > +// SAFETY: `Device` only holds a pointer to a C device, which is safe to be > used from any thread. > +unsafe impl Send for Device {} > + > +// SAFETY: `Device` only holds a pointer to a C device, references to which > are

Re: [PATCH RFC v7 00/23] DEPT(Dependency Tracker)

2023-01-20 Thread Boqun Feng
On Sat, Jan 21, 2023 at 12:28:14PM +0900, Byungchul Park wrote: > On Thu, Jan 19, 2023 at 07:07:59PM -0800, Boqun Feng wrote: > > On Thu, Jan 19, 2023 at 06:23:49PM -0800, Boqun Feng wrote: > > > On Fri, Jan 20, 2023 at 10:51:45AM +0900, Byungchul Park wrote: >

Re: [PATCH RFC v7 00/23] DEPT(Dependency Tracker)

2023-01-19 Thread Boqun Feng
On Thu, Jan 19, 2023 at 07:07:59PM -0800, Boqun Feng wrote: > On Thu, Jan 19, 2023 at 06:23:49PM -0800, Boqun Feng wrote: > > On Fri, Jan 20, 2023 at 10:51:45AM +0900, Byungchul Park wrote: > > > Boqun wrote: > > > > On Thu, Jan 19, 2023 at 01:33:58PM +, Matthew

Re: [PATCH RFC v7 00/23] DEPT(Dependency Tracker)

2023-01-19 Thread Boqun Feng
On Thu, Jan 19, 2023 at 06:23:49PM -0800, Boqun Feng wrote: > On Fri, Jan 20, 2023 at 10:51:45AM +0900, Byungchul Park wrote: > > Boqun wrote: > > > On Thu, Jan 19, 2023 at 01:33:58PM +, Matthew Wilcox wrote: > > > > On Thu, Jan 19, 2023 at 03:23:08

Re: [PATCH RFC v7 00/23] DEPT(Dependency Tracker)

2023-01-19 Thread Boqun Feng
On Fri, Jan 20, 2023 at 10:51:45AM +0900, Byungchul Park wrote: > Boqun wrote: > > On Thu, Jan 19, 2023 at 01:33:58PM +, Matthew Wilcox wrote: > > > On Thu, Jan 19, 2023 at 03:23:08PM +0900, Byungchul Park wrote: > > > > Boqun wrote: > > > > > *Looks like the DEPT dependency graph doesn't

Re: [PATCH RFC v7 00/23] DEPT(Dependency Tracker)

2023-01-19 Thread Boqun Feng
On Thu, Jan 19, 2023 at 01:33:58PM +, Matthew Wilcox wrote: > On Thu, Jan 19, 2023 at 03:23:08PM +0900, Byungchul Park wrote: > > Boqun wrote: > > > * Looks like the DEPT dependency graph doesn't handle the > > > fair/unfair readers as lockdep current does. Which bring the > > > next

Re: [PATCH RFC v7 00/23] DEPT(Dependency Tracker)

2023-01-17 Thread Boqun Feng
[Cc Waiman] On Mon, Jan 16, 2023 at 10:00:52AM -0800, Linus Torvalds wrote: > [ Back from travel, so trying to make sense of this series.. ] > > On Sun, Jan 8, 2023 at 7:33 PM Byungchul Park wrote: > > > > I've been developing a tool for detecting deadlock possibilities by > > tracking

Re: [PATCH 2/2] drm: add lockdep assert to drm_is_current_master_locked

2021-07-30 Thread Boqun Feng
On Fri, Jul 30, 2021 at 04:06:44PM +0800, Desmond Cheong Zhi Xi wrote: > On 30/7/21 2:08 pm, Boqun Feng wrote: > > On Fri, Jul 30, 2021 at 12:15:15PM +0800, Desmond Cheong Zhi Xi wrote: > > > In drm_is_current_master_locked, accessing drm_file.master should be > &g

Re: [PATCH 2/2] drm: add lockdep assert to drm_is_current_master_locked

2021-07-30 Thread Boqun Feng
On Fri, Jul 30, 2021 at 12:15:15PM +0800, Desmond Cheong Zhi Xi wrote: > In drm_is_current_master_locked, accessing drm_file.master should be > protected by either drm_file.master_lookup_lock or > drm_device.master_mutex. This was previously awkward to assert with > lockdep. > > Following patch

Re: [PATCH 1/3] drm: use the lookup lock in drm_is_current_master

2021-07-23 Thread Boqun Feng
On Thu, Jul 22, 2021 at 09:02:41PM +0200, Daniel Vetter wrote: > On Thu, Jul 22, 2021 at 6:00 PM Boqun Feng wrote: > > > > On Thu, Jul 22, 2021 at 12:38:10PM +0200, Daniel Vetter wrote: > > > On Thu, Jul 22, 2021 at 05:29:27PM +0800, Desmond Cheong Zhi

Re: [PATCH 1/3] drm: use the lookup lock in drm_is_current_master

2021-07-22 Thread Boqun Feng
On Thu, Jul 22, 2021 at 12:38:10PM +0200, Daniel Vetter wrote: > On Thu, Jul 22, 2021 at 05:29:27PM +0800, Desmond Cheong Zhi Xi wrote: > > Inside drm_is_current_master, using the outer drm_device.master_mutex > > to protect reads of drm_file.master makes the function prone to creating > > lock

Re: WARNING: suspicious RCU usage in modeset_lock

2020-12-22 Thread Boqun Feng
Hi Dmitry, On Fri, Dec 18, 2020 at 12:27:04PM +0100, Dmitry Vyukov wrote: > On Fri, Dec 18, 2020 at 2:30 AM Boqun Feng wrote: > > > > On Thu, Dec 17, 2020 at 07:21:18AM -0800, Paul E. McKenney wrote: > > > On Thu, Dec 17, 2020 at 11:03:20AM +0100, Daniel Vetter wrote

Re: WARNING: suspicious RCU usage in modeset_lock

2020-12-18 Thread Boqun Feng
On Thu, Dec 17, 2020 at 07:21:18AM -0800, Paul E. McKenney wrote: > On Thu, Dec 17, 2020 at 11:03:20AM +0100, Daniel Vetter wrote: > > On Wed, Dec 16, 2020 at 5:16 PM Paul E. McKenney wrote: > > > > > > On Wed, Dec 16, 2020 at 10:52:06AM +0100, Daniel Vetter wrote: > > > > On Wed, Dec 16, 2020 at

Re: [PATCH] video: hyperv_fb: Directly use the MMIO VRAM

2020-11-21 Thread Boqun Feng
Fixes: d21987d709e8 ("video: hyperv: hyperv_fb: Support deferred IO for > Hyper-V frame buffer driver") > Fixes: 3a6fb6c4255c ("video: hyperv: hyperv_fb: Use physical memory for fb on > HyperV Gen 1 VMs.") > Cc: Wei Hu > Cc: Boqun Feng > Signed-off-by: Dexuan C