Re: [PATCH] drm: bridge: cdns-mhdp8546: Add mode_valid hook for the drm_bridge_funcs

2024-05-24 Thread Dmitry Baryshkov
On Fri, May 24, 2024 at 12:43:48PM +0530, Jayesh Choudhary wrote: > With the support for the 'DRM_BRIDGE_ATTACH_NO_CONNECTOR' case, > the connector_helper funcs are not initialized if the encoder has this > flag in its bridge_attach call. Till now we had mode_valid hook only in > the

Re: [PATCH v3 1/2] drm/bridge: sii902x: Fix mode_valid hook

2024-05-24 Thread Dmitry Baryshkov
On Fri, May 24, 2024 at 03:05:08PM +0530, Jayesh Choudhary wrote: > Currently, mode_valid hook returns all mode as valid and it is > defined only in drm_connector_helper_funcs. With the introduction of > 'DRM_BRIDGE_ATTACH_NO_CONNECTOR', connector is not initialized in > bridge_attach call for

Re: [PATCH v2 1/2] drm/bridge: sii902x: Fix mode_valid hook

2024-05-24 Thread Dmitry Baryshkov
On Fri, May 24, 2024 at 01:03:04PM +0530, Jayesh Choudhary wrote: > Currently, mode_valid hook returns all mode as valid and it is > defined only in drm_connector_helper_funcs. With the introduction of > 'DRM_BRIDGE_ATTACH_NO_CONNECTOR', connector is not initialized in > bridge_attach call for

Re: [PATCH RFC] drm/panel-edp: add fat warning against adding new panel compatibles

2024-05-23 Thread Dmitry Baryshkov
On Thu, May 23, 2024 at 08:36:39AM -0700, Doug Anderson wrote: > Hi, > > On Wed, May 22, 2024 at 3:07 PM Dmitry Baryshkov > wrote: > > > > Add a fat warning against adding new panel compatibles to the panel-edp > > driver. All new users of the eDP panels are suppos

Re: [PATCH v14 23/28] drm/connector: hdmi: Create Infoframe DebugFS entries

2024-05-23 Thread Dmitry Baryshkov
t; drivers/gpu/drm/drm_debugfs.c | 152 > ++ > 1 file changed, 152 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 22/28] drm/tests: Add infoframes test

2024-05-23 Thread Dmitry Baryshkov
drivers/gpu/drm/tests/drm_connector_test.c | 219 > + > 1 file changed, 219 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 21/28] drm/connector: hdmi: Add Infoframes generation

2024-05-23 Thread Dmitry Baryshkov
helper.h| 7 + > include/drm/drm_connector.h| 111 ++- > 6 files changed, 480 insertions(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 20/28] drm/tests: Add RGB Quantization tests

2024-05-23 Thread Dmitry Baryshkov
rks as expected. > > Reviewed-by: Dave Stevenson > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 355 > + > 1 file changed, 355 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 19/28] drm/connector: hdmi: Add RGB Quantization Range to the connector state

2024-05-23 Thread Dmitry Baryshkov
changed, 36 insertions(+) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 18/28] drm/tests: Add tests for Broadcast RGB property

2024-05-23 Thread Dmitry Baryshkov
. > > Reviewed-by: Dave Stevenson > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/tests/drm_connector_test.c | 116 > drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 151 > + > 2 files changed, 267 insertio

Re: [PATCH v14 17/28] drm/connector: hdmi: Add Broadcast RGB property

2024-05-23 Thread Dmitry Baryshkov
On Tue, May 21, 2024 at 12:13:50PM +0200, Maxime Ripard wrote: > The i915 driver has a property to force the RGB range of an HDMI output. > The vc4 driver then implemented the same property with the same > semantics. KWin has support for it, and a PR for mutter is also there to > support it. > >

Re: [PATCH v14 16/28] drm/tests: Add HDMI connector bpc and format tests

2024-05-23 Thread Dmitry Baryshkov
> --- > drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 509 > + > drivers/gpu/drm/tests/drm_kunit_edid.h | 160 +++ > 2 files changed, 669 insertions(+) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 15/28] drm/connector: hdmi: Compute bpc and format automatically

2024-05-23 Thread Dmitry Baryshkov
On Tue, May 21, 2024 at 12:13:48PM +0200, Maxime Ripard wrote: > Now that we have all the infrastructure needed, we can add some code > that will, for a given connector state and mode, compute the best output > format and bpc. > > The algorithm is equivalent to the one already found in i915 and

Re: [PATCH v14 14/28] drm/tests: Add HDMI connector rate filter hook tests

2024-05-23 Thread Dmitry Baryshkov
n > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 65 > ++ > 1 file changed, 65 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 13/28] drm/connector: hdmi: Add custom hook to filter TMDS character rate

2024-05-23 Thread Dmitry Baryshkov
u/drm/drm_connector.c| 4 +++ > drivers/gpu/drm/tests/drm_connector_test.c | 14 ++ > drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 4 +++ > include/drm/drm_connector.h| 31 > ++++++ > 5 files chan

Re: [PATCH v2 1/6] drm/ci: uprev mesa version

2024-05-23 Thread Dmitry Baryshkov
On Thu, 23 May 2024 at 09:07, Vignesh Raman wrote: > > Hi Dmitry, > > On 20/05/24 16:13, Dmitry Baryshkov wrote: > > On Fri, May 17, 2024 at 02:54:57PM +0530, Vignesh Raman wrote: > >> zlib.net is not allowing tarball download anymore and results > >> i

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-05-23 Thread Dmitry Baryshkov
On Thu, 23 May 2024 at 02:57, Abhinav Kumar wrote: > > > > On 5/22/2024 1:05 PM, Dmitry Baryshkov wrote: > > On Wed, 22 May 2024 at 21:38, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 5/20/2024 5:12 AM, Dmitry Baryshkov wrote: >

Re: [PATCH v14 12/28] drm/tests: Add TDMS character rate connector state tests

2024-05-23 Thread Dmitry Baryshkov
Dave Stevenson > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 166 > drivers/gpu/drm/tests/drm_kunit_edid.h | 216 > + > 2 files changed, 382 insertions(+) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 11/28] drm/connector: hdmi: Calculate TMDS character rate

2024-05-23 Thread Dmitry Baryshkov
/drm/display/drm_hdmi_state_helper.c| 67 > ++ > drivers/gpu/drm/drm_atomic.c | 1 + > drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 3 + > include/drm/drm_connector.h| 5 ++ > 4 files change

Re: [PATCH v14 09/28] drm/display: hdmi: Add HDMI compute clock helper

2024-05-23 Thread Dmitry Baryshkov
On Tue, May 21, 2024 at 12:13:42PM +0200, Maxime Ripard wrote: > A lot of HDMI drivers have some variation of the formula to calculate > the TMDS character rate from a mode, but few of them actually take all > parameters into account. > > Let's create a helper to provide that rate taking all

Re: [PATCH v14 08/28] drm/tests: Add output formats tests

2024-05-23 Thread Dmitry Baryshkov
rm_hdmi_connector_get_output_format_name(4)); Nit: it might be better to use a bigger value here. It's easier to miss this if other formats get added for whatever reason. Nevertheless: Reviewed-by: Dmitry Baryshkov > +}; > + > +static struct kunit_case drm_hdmi_con

Re: [PATCH v14 07/28] drm/connector: hdmi: Add support for output format

2024-05-23 Thread Dmitry Baryshkov
| 9 +++ > drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 22 +++ > include/drm/drm_connector.h| 20 ++ > 6 files changed, 81 insertions(+), 6 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 06/28] drm/tests: Add output bpc tests

2024-05-23 Thread Dmitry Baryshkov
ivers/gpu/drm/tests/drm_kunit_edid.h | 106 + > 5 files changed, 686 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 05/28] drm/connector: hdmi: Add output BPC to the connector state

2024-05-22 Thread Dmitry Baryshkov
> include/drm/drm_connector.h | 12 +++- > 5 files changed, 63 insertions(+), 6 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 04/28] drm/connector: hdmi: Create an HDMI sub-state

2024-05-22 Thread Dmitry Baryshkov
| 2 ++ > drivers/gpu/drm/display/drm_hdmi_state_helper.c | 41 > + > include/drm/display/drm_hdmi_state_helper.h | 16 ++ > include/drm/drm_connector.h | 7 + > 5 files changed, 73 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 03/28] drm/tests: connector: Add tests for drmm_connector_hdmi_init

2024-05-22 Thread Dmitry Baryshkov
drivers/gpu/drm/tests/drm_connector_test.c | 123 > + > 1 file changed, 123 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 02/28] drm/mode_object: Export drm_mode_obj_find_prop_id for tests

2024-05-22 Thread Dmitry Baryshkov
drm/drm_mode_object.c | 1 + > 1 file changed, 1 insertion(+) > If this ever gets reposted, it might be better to move this just before the patch 6 "drm/tests: Add output bpc tests", which actually uses this function. Nevertheless: Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v14 01/28] drm/connector: Introduce an HDMI connector initialization function

2024-05-22 Thread Dmitry Baryshkov
> more consistent. > > Reviewed-by: Dave Stevenson > Reviewed-by: Sui Jingfeng > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/drm_connector.c | 39 +++ > include/drm/drm_connector.h | 5 + > 2 files changed, 44 insertions(+) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

[PATCH RFC] drm/panel-edp: add fat warning against adding new panel compatibles

2024-05-22 Thread Dmitry Baryshkov
e retained for backwards compatibility. Suggested-by: Doug Anderson Signed-off-by: Dmitry Baryshkov --- The following compatibles were never used by the devices supported by the upstream kernel and are a subject to possible removal: - auo,b133han05 - auo,b140han06 - ivo,m133nwf4-r0 - lg,lp097qx1

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-05-22 Thread Dmitry Baryshkov
On Wed, 22 May 2024 at 21:38, Abhinav Kumar wrote: > > > > On 5/20/2024 5:12 AM, Dmitry Baryshkov wrote: > > Command mode panels provide TE signal back to the DSI host to signal > > that the frame display has completed and update of the image will not > > cause te

Re: [PATCH 2/7] drm/msm/dpu: convert vsync source defines to the enum

2024-05-22 Thread Dmitry Baryshkov
On Wed, 22 May 2024 at 21:41, Abhinav Kumar wrote: > > > > On 5/20/2024 5:12 AM, Dmitry Baryshkov wrote: > > Add enum dpu_vsync_source instead of a series of defines. Use this enum > > to pass vsync information. > > > > Signed-off-by: Dmitry Baryshkov > &g

Re: [PATCH 0/7] drm/msm/dpu: handle non-default TE source pins

2024-05-22 Thread Dmitry Baryshkov
On Wed, 22 May 2024 at 21:39, Abhinav Kumar wrote: > > > > On 5/20/2024 5:12 AM, Dmitry Baryshkov wrote: > > Command-mode DSI panels need to signal the display controlller when > > vsync happens, so that the device can start sending the next frame. Some > > devi

[PATCH v2 14/14] drm/msm/hdmi: wire in hpd_enable/hpd_disable bridge ops

2024-05-22 Thread Dmitry Baryshkov
The HDMI driver already has msm_hdmi_hpd_enable() and msm_hdmi_hpd_disable() functions. Wire them into the msm_hdmi_bridge_funcs, so that HPD can be enabled and disabled dynamically rather than always having HPD events generation enabled. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm

[PATCH v2 07/14] drm/msm/hdmi: switch to pm_runtime_resume_and_get()

2024-05-22 Thread Dmitry Baryshkov
The pm_runtime_get_sync() function is a bad choise for runtime power management. Switch HDMI driver to pm_runtime_resume_and_get() and add proper error handling, while we are at it. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 2 +- drivers/gpu/drm/msm/hdmi

[PATCH v2 06/14] drm/msm/hdmi: switch to clk_bulk API

2024-05-22 Thread Dmitry Baryshkov
The last platform using legacy clock names for HDMI block (APQ8064) switched to new clock names in 5.16. It's time to stop caring about old DT, drop hand-coded helpers and switch to clk_bulk_* API. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c | 15

[PATCH v2 09/14] drm/msm/hdmi: implement proper runtime PM handling

2024-05-22 Thread Dmitry Baryshkov
It is completely not obvious, but the so-called 'hpd' clocks and regulators are required for the HDMI host to function properly. Merge pwr and hpd regulators. Use regulators, clocks and pinctrl to implement proper runtime PM callbacks. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm

[PATCH v2 10/14] drm/msm/hdmi: rename hpd_clks to pwr_clks

2024-05-22 Thread Dmitry Baryshkov
As these clocks are now used in the runtime PM callbacks, they have no connection to 'HPD'. Rename corresponding fields to follow clocks purpose, to power up the HDMI controller. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c | 26 +- drivers/gpu/drm

[PATCH v2 08/14] drm/msm/hdmi: add runtime PM calls to DDC transfer function

2024-05-22 Thread Dmitry Baryshkov
We must be sure that the HDMI controller is powered on, while performing the DDC transfer. Add corresponding runtime PM calls to msm_hdmi_i2c_xfer(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions

[PATCH v2 13/14] drm/msm/hdmi: ensure that HDMI is one if HPD is requested

2024-05-22 Thread Dmitry Baryshkov
The HDMI block needs to be enabled to properly generate HPD events. Make sure it is not turned off in the disable paths if HPD delivery is enabled. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c| 1 + drivers/gpu/drm/msm/hdmi/hdmi.h| 2 ++ drivers/gpu/drm

[PATCH v2 11/14] drm/msm/hdmi: expand the HDMI_CFG macro

2024-05-22 Thread Dmitry Baryshkov
Expand the HDMI_CFG() macro in HDMI config description. It has no added value other than hiding some boilerplate declarations. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c | 16 drivers/gpu/drm/msm/hdmi/hdmi.h | 2 +- 2 files changed, 9 insertions(+), 9

[PATCH v2 04/14] drm/msm/hdmi: set infoframes on all pre_enable calls

2024-05-22 Thread Dmitry Baryshkov
In consequent modeset calls, the atomic_pre_enable() will be called several times without calling atomic_post_disable() inbetween. Thus iframes will not be updated for the next mode. Fix this by setting the iframe outside of the !power_on check. Signed-off-by: Dmitry Baryshkov --- drivers/gpu

[PATCH v2 12/14] drm/msm/hdmi: drop hpd-gpios support

2024-05-22 Thread Dmitry Baryshkov
device. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c | 14 +++--- drivers/gpu/drm/msm/hdmi/hdmi.h | 2 -- drivers/gpu/drm/msm/hdmi/hdmi_hpd.c | 53 +++-- 3 files changed, 7 insertions(+), 62 deletions(-) diff --git a/drivers/gpu

[PATCH v2 01/14] drm/msm/hdmi: move the alt_iface clock to the hpd list

2024-05-22 Thread Dmitry Baryshkov
According to the vendor kernel [1] , the alt_iface clock should be enabled together with the rest of HPD clocks, to make HPD to work properly. [1] https://git.codelinaro.org/clo/la/kernel/msm-3.18/-/commit/e07a5487e521e57f76083c0a6e2f995414ac6d03 Signed-off-by: Dmitry Baryshkov --- drivers

[PATCH v2 03/14] drm/msm/hdmi: switch to atomic_pre_enable/post_disable

2024-05-22 Thread Dmitry Baryshkov
In preparation of reworking the HDMI mode setting, switch pre_enable and post_disable callbacks to their atomic variants. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/gpu

[PATCH v2 05/14] drm/msm/hdmi: drop clock frequency assignment

2024-05-22 Thread Dmitry Baryshkov
The only clock which has frequency being set through hpd_freqs is the "core" aka MDSS_HDMI_CLK clock. It always has the specified frequency, so we can drop corresponding clk_set_rate() call together with the hpd_freq infrastructure. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/dr

[PATCH v2 02/14] drm/msm/hdmi: simplify extp clock handling

2024-05-22 Thread Dmitry Baryshkov
With the extp being the only "power" clock left, remove the surrounding loops and handle the extp clock directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c| 24 drivers/gpu/drm/msm/hdmi/hdmi.h| 6 +- drivers/g

[PATCH v2 00/14] drm/msm/hdmi: rework and fix the HPD even generation

2024-05-22 Thread Dmitry Baryshkov
deletions(-) --- base-commit: 8314289a8d50a4e05d8ece1ae0445a3b57bb4d3b change-id: 20240522-fd-hdmi-hpd-e3868deb6ae0 Best regards, -- Dmitry Baryshkov

[PATCH v2] Revert "drm/msm/dpu: drop dpu_encoder_phys_ops.atomic_mode_set"

2024-05-22 Thread Dmitry Baryshkov
ker_thread+0x1ac/0x37c kthread+0x114/0x118 ret_from_fork+0x10/0x20 Fixes: d13f638c9b88 ("drm/msm/dpu: drop dpu_encoder_phys_ops.atomic_mode_set") Signed-off-by: Dmitry Baryshkov --- Changes in v2: - Expanded commit message to describe the reason for revert and added a call trace (A

Re: [PATCH] drm/bridge: adv7511: Fix Intermittent EDID failures

2024-05-22 Thread Dmitry Baryshkov
On Mon, May 20, 2024 at 08:16:14PM -0500, Adam Ford wrote: > In the process of adding support for shared IRQ pins, a scenario > was accidentally created where adv7511_irq_process returned > prematurely causing the EDID to fail randomly. > > Since the interrupt handler is broken up into two main

Re: [PATCH] drm/display/dp: fix all kernel-doc warnings

2024-05-22 Thread Dmitry Baryshkov
On Tue, May 21, 2024 at 08:59:06PM -0700, Randy Dunlap wrote: > Hi Dmitry, > > On 5/20/24 3:37 AM, Dmitry Baryshkov wrote: > > On Wed, May 15, 2024 at 05:26:42PM -0700, Randy Dunlap wrote: > >> Fix a struct member name in drm_dp_as_sdp. > >> Add Returns:

[PATCH v3 3/3] drm/panel/lg-sw43408: mark sw43408_backlight_ops as static

2024-05-22 Thread Dmitry Baryshkov
t;) Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-lg-sw43408.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-lg-sw43408.c b/drivers/gpu/drm/panel/panel-lg-sw43408.c index 115f4702d59f..2b3a73696dce 100644 --- a/drivers/gpu/drm/pane

[PATCH v3 0/3] drm/panel: two fixes for lg-sw43408

2024-05-22 Thread Dmitry Baryshkov
-...@lists.freedesktop.org Cc: intel-...@lists.freedesktop.org Cc: linux-arm-...@vger.kernel.org Cc: freedr...@lists.freedesktop.org Signed-off-by: Dmitry Baryshkov Changes in v3: - Split DRM_DISPLAY_DSC_HELPER from DRM_DISPLAY_DP_HELPER - Added missing Fixes tags - Link to v2: https

[PATCH v3 1/3] drm/display: split DSC helpers from DP helpers

2024-05-22 Thread Dmitry Baryshkov
symbol. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/amd/amdgpu/Kconfig | 1 + drivers/gpu/drm/display/Kconfig| 6 ++ drivers/gpu/drm/display/Makefile | 3 ++- drivers/gpu/drm/i915/Kconfig | 1 + drivers/gpu/drm/msm/Kconfig| 1 + drivers/gpu/drm/panel/Kconfig | 4

[PATCH v3 2/3] drm/panel/lg-sw43408: select CONFIG_DRM_DISPLAY_DP_HELPER

2024-05-22 Thread Dmitry Baryshkov
("drm: panel: Add LG sw43408 panel driver") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 4a2f621433ef..3e3f63479544 100644 --- a/drivers/gpu

Re: [PATCH v4 08/10] drm/vs: add vs drm master driver

2024-05-21 Thread Dmitry Baryshkov
On Tue, May 21, 2024 at 06:58:15PM +0800, keith wrote: > Add vs DRM master driver for JH7110 SoC > ADD DMA GEM driver > > Signed-off-by: keith > --- > drivers/gpu/drm/verisilicon/Makefile | 3 +- > drivers/gpu/drm/verisilicon/vs_drv.c | 718 +++ > 2 files changed, 720

Re: [PATCH v4 07/10] drm/vs: add ctrc fun

2024-05-21 Thread Dmitry Baryshkov
On Tue, May 21, 2024 at 06:58:14PM +0800, keith wrote: > add crtc funs and helper funs > > Signed-off-by: keith > --- > drivers/gpu/drm/verisilicon/Makefile | 3 +- > drivers/gpu/drm/verisilicon/vs_crtc.c | 241 ++ > drivers/gpu/drm/verisilicon/vs_crtc.h | 17 ++ > 3

Re: [PATCH v4 06/10] drm/vs: add vs plane api

2024-05-21 Thread Dmitry Baryshkov
On Tue, May 21, 2024 at 06:58:13PM +0800, keith wrote: > add plane funs and helper funs > add vs drm common struct and funs > > Signed-off-by: keith > --- > drivers/gpu/drm/verisilicon/Makefile | 3 +- > drivers/gpu/drm/verisilicon/vs_drv.h | 93 + >

Re: [PATCH v4 05/10] drm/vs: add vs mode config init

2024-05-21 Thread Dmitry Baryshkov
On Tue, May 21, 2024 at 06:58:12PM +0800, keith wrote: > add vs mode config base api Commit message? Please describe e.g. why are you using drm_atomic_helper_commit_tail_rpm() instead of drm_atomic_helper_commit_tail(). > > Signed-off-by: keith Name > --- >

Re: [PATCH v4 04/10] drm/vs: Add hardware funcs for vs.

2024-05-21 Thread Dmitry Baryshkov
On Tue, May 21, 2024 at 06:58:11PM +0800, keith wrote: > add hardware base api for vs drm Commit message is nearly missing. Please describe your hardware. > > Signed-off-by: keith Full name please > --- > MAINTAINERS|1 + > drivers/gpu/drm/Kconfig

Re: [PATCH v4 10/10] drm/vs: add simple dsi encoder

2024-05-21 Thread Dmitry Baryshkov
On Tue, May 21, 2024 at 06:58:17PM +0800, keith wrote: > add encoder to match cdns dsi driver > > Signed-off-by: keith Please fix your git configuration to include your full name into the S-o-B and Author fields. > --- > drivers/gpu/drm/verisilicon/Makefile| 3 +- >

Re: [PATCH v2] drm/bridge: analogix: remove unused struct 'bridge_init'

2024-05-20 Thread Dmitry Baryshkov
ix_dp_core.c | 5 - > 1 file changed, 5 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH 1/6] drm/bridge: analogix: remove unused struct 'bridge_init'

2024-05-20 Thread Dmitry Baryshkov
On Mon, May 20, 2024 at 12:57:36PM +, Dr. David Alan Gilbert wrote: > * Dmitry Baryshkov (dmitry.barysh...@linaro.org) wrote: > > On Sun, May 19, 2024 at 10:43:44PM +, Dr. David Alan Gilbert wrote: > > > * Dmitry Baryshkov (dmitry.barysh...@linaro.org) wrote: > >

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Dmitry Baryshkov
On Mon, May 20, 2024 at 07:46:05AM -0500, Adam Ford wrote: > On Mon, May 20, 2024 at 7:00 AM Dmitry Baryshkov > wrote: > > > > On Mon, 20 May 2024 at 14:48, Sui Jingfeng wrote: > > > > > > Hi, > > > > > > > > > On 5/20/24 19:13, Dm

Re: [PATCH v2] drm/panel-edp: Add entry for BOE NV133WUM-N63 panel

2024-05-20 Thread Dmitry Baryshkov
On Mon, May 20, 2024 at 01:06:00PM -0700, Clayton Craft wrote: > This panel is found on some laptops e.g., variants of the Thinkpad X13s. > > Signed-off-by: Clayton Craft > --- > drivers/gpu/drm/panel/panel-edp.c | 1 + > 1 file changed, 1 insertion(+) Please don't send patches as a response

Re: [PATCH v2] drm/panel-edp: Add timings for BOE NV133WUM-N63

2024-05-20 Thread Dmitry Baryshkov
On Thu, Nov 02, 2023 at 11:19:07AM -0700, Clayton Craft wrote: > This panel is found on laptops e.g., variants of the Thinkpad X13s. > Configuration was collected from the panel's EDID. > > Signed-off-by: Clayton Craft > --- > > V2: renamed to "*_mode" since there is only 1 mode listed > >

Re: [PATCH 08/11] drm/msm/dp: switch to struct drm_edid

2024-05-20 Thread Dmitry Baryshkov
On Mon, 20 May 2024 at 15:25, Jani Nikula wrote: > > On Sun, 19 May 2024, Dmitry Baryshkov wrote: > > On Tue, May 14, 2024 at 03:55:14PM +0300, Jani Nikula wrote: > >> Prefer the struct drm_edid based functions for reading the EDID and > >> updating the connecto

[PATCH 4/7] drm/msm/dpu: pull the is_cmd_mode out of _dpu_encoder_update_vsync_source()

2024-05-20 Thread Dmitry Baryshkov
Setting vsync source makes sense only for DSI CMD panels. Pull the is_cmd_mode condition out of the function into the calling code, so that it becomes more explicit. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 5/7] drm/msm/dpu: rework vsync_source handling

2024-05-20 Thread Dmitry Baryshkov
The struct msm_display_info has is_te_using_watchdog_timer field which is neither used anywhere nor is flexible enough to specify different sources. Replace it with the field specifying the vsync source using enum dpu_vsync_source. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp

[PATCH 3/7] drm/msm/dsi: drop unused GPIOs handling

2024-05-20 Thread Dmitry Baryshkov
Neither disp-enable-gpios nor disp-te-gpios are defined in the schema. None of the board DT files use those GPIO pins. Drop them from the driver. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_host.c | 37 - 1 file changed, 37 deletions

[PATCH 7/7] drm/msm/dpu: support setting the TE source

2024-05-20 Thread Dmitry Baryshkov
Make the DPU driver use the TE source specified in the DT. If none is specified, the driver defaults to the first GPIO (mdp_vsync0). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 44 - 1 file changed, 43 insertions(+), 1 deletion

[PATCH 6/7] drm/msm/dsi: parse vsync source from device tree

2024-05-20 Thread Dmitry Baryshkov
Allow board's device tree to specify the vsync source (aka TE source). If the property is omitted, the display controller driver will use the default setting. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi.h | 1 + drivers/gpu/drm/msm/dsi/dsi_host.c| 11

[PATCH 2/7] drm/msm/dpu: convert vsync source defines to the enum

2024-05-20 Thread Dmitry Baryshkov
Add enum dpu_vsync_source instead of a series of defines. Use this enum to pass vsync information. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 2

[PATCH 0/7] drm/msm/dpu: handle non-default TE source pins

2024-05-20 Thread Dmitry Baryshkov
and DPU drivers. Signed-off-by: Dmitry Baryshkov --- Dmitry Baryshkov (7): dt-bindings: display/msm/dsi: allow specifying TE source drm/msm/dpu: convert vsync source defines to the enum drm/msm/dsi: drop unused GPIOs handling drm/msm/dpu: pull the is_cmd_mode out

[PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-05-20 Thread Dmitry Baryshkov
-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dsi-controller-main.yaml| 16 1 file changed, 16 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Dmitry Baryshkov
On Mon, 20 May 2024 at 14:48, Sui Jingfeng wrote: > > Hi, > > > On 5/20/24 19:13, Dmitry Baryshkov wrote: > > On Mon, 20 May 2024 at 14:11, Sui Jingfeng wrote: > >> > >> Hi, > >> > >> On 5/20/24 06:11, Dmitry Baryshkov wrote: >

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Dmitry Baryshkov
On Mon, 20 May 2024 at 14:11, Sui Jingfeng wrote: > > Hi, > > On 5/20/24 06:11, Dmitry Baryshkov wrote: > > On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote: > >> Commit f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins") > >

Re: [PATCH v2 6/6] drm/ci: update xfails for the new testlist

2024-05-20 Thread Dmitry Baryshkov
or-lazor-limozeen-skips.txt | 4 + > .../gpu/drm/ci/xfails/msm-sdm845-fails.txt| 38 +--- > .../gpu/drm/ci/xfails/msm-sdm845-flakes.txt | 26 ++- > .../gpu/drm/ci/xfails/msm-sdm845-skips.txt| 7 + Reviewed-by: Dmitry Baryshkov # msm testlists We'd need to triage why the te

Re: [PATCH v2 5/6] drm/ci: skip driver specific tests

2024-05-20 Thread Dmitry Baryshkov
On Fri, May 17, 2024 at 02:55:01PM +0530, Vignesh Raman wrote: > Skip driver specific tests and skip kms tests for > panfrost driver since it is not a kms driver. > > Signed-off-by: Vignesh Raman > --- I didn't perform a through check, but generally looks good. Reviewed-by: D

Re: [PATCH v2 4/6] drm/ci: uprev IGT

2024-05-20 Thread Dmitry Baryshkov
h fixes this issue. Disable building xe driver > tests for non-intel platforms. > > Signed-off-by: Vignesh Raman > --- > > v2: > - Split IGT uprev to seperate patch. > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v2 3/6] drm/ci: build virtual GPU driver as module

2024-05-20 Thread Dmitry Baryshkov
On Fri, May 17, 2024 at 02:54:59PM +0530, Vignesh Raman wrote: > With latest IGT, the tests tries to load the module and it > fails. So build the virtual GPU driver for virtio as module. Why? If the test fails on module loading (if the driver is built-in) then it's the test that needs to be

Re: [PATCH v2 2/6] drm/ci: generate testlist from build

2024-05-20 Thread Dmitry Baryshkov
On Fri, May 17, 2024 at 02:54:58PM +0530, Vignesh Raman wrote: > Stop vendoring the testlist into the kernel. Instead, use the > testlist from the IGT build to ensure we do not miss renamed > or newly added tests. > > Signed-off-by: Vignesh Raman > --- > > v2: > - Fix testlist generation for

Re: [PATCH v2 1/6] drm/ci: uprev mesa version

2024-05-20 Thread Dmitry Baryshkov
On Fri, May 17, 2024 at 02:54:57PM +0530, Vignesh Raman wrote: > zlib.net is not allowing tarball download anymore and results > in below error in kernel+rootfs_arm32 container build, > urllib.error.HTTPError: HTTP Error 403: Forbidden > urllib.error.HTTPError: HTTP Error 415: Unsupported Media

Re: [PATCH] drm/mode: fix all kernel-doc warnings

2024-05-20 Thread Dmitry Baryshkov
On Wed, May 15, 2024 at 05:26:52PM -0700, Randy Dunlap wrote: > Add @width and @height descriptions for drm_plane_size_hint > along with a reference to more info. > > Add a short description for drm_mode_closefb. > > Change 7 macros not to be marked as kernel-doc notation to prevent >

Re: [PATCH] drm/display/dp: fix all kernel-doc warnings

2024-05-20 Thread Dmitry Baryshkov
On Wed, May 15, 2024 at 05:26:42PM -0700, Randy Dunlap wrote: > Fix a struct member name in drm_dp_as_sdp. > Add Returns: kernel-doc syntax for 4 functions. > In the Returns: sections, spell "%true" and "%false" consistently. > > Fixes these kernel-doc warnings: > > drm_dp_helper.h:126:

Re: [PATCH 1/6] drm/bridge: analogix: remove unused struct 'bridge_init'

2024-05-20 Thread Dmitry Baryshkov
On Sun, May 19, 2024 at 10:43:44PM +, Dr. David Alan Gilbert wrote: > * Dmitry Baryshkov (dmitry.barysh...@linaro.org) wrote: > > On Sat, May 18, 2024 at 12:24:27AM +0100, li...@treblig.org wrote: > > > From: "Dr. David Alan Gilbert" > > > > > &

Re: [PATCH] drm/panel: lg-sw43408: Fix an error handling path in sw43408_probe()

2024-05-20 Thread Dmitry Baryshkov
er") > Signed-off-by: Christophe JAILLET > --- > Compile tested only > --- > drivers/gpu/drm/panel/panel-lg-sw43408.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Dmitry Baryshkov
On Mon, 20 May 2024 at 06:29, Liu Ying wrote: > > On 5/20/24 06:11, Dmitry Baryshkov wrote: > > On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote: > >> Commit f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins") > >> fails to consid

Re: [PATCH 1/6] drm/bridge: analogix: remove unused struct 'bridge_init'

2024-05-19 Thread Dmitry Baryshkov
On Sat, May 18, 2024 at 12:24:27AM +0100, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > 'bridge_init' is unused, I think following: > commit 6a1688ae8794 ("drm/bridge: ptn3460: Convert to I2C driver model") > (which is where a git --follow finds it) > Remove it. Please rephrase

Re: [PATCH 8/8] drm/panel: himax-hx83102: use wrapped MIPI DCS functions

2024-05-19 Thread Dmitry Baryshkov
> --- > > drivers/gpu/drm/panel/panel-himax-hx83102.c | 92 +++-- > 1 file changed, 28 insertions(+), 64 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH 7/8] drm/panel: himax-hx83102: Check for errors on the NOP in prepare()

2024-05-19 Thread Dmitry Baryshkov
uld fail too. > > Found by code inspection. > > Fixes: 0ef94554dc40 ("drm/panel: himax-hx83102: Break out as separate driver") > Signed-off-by: Douglas Anderson > --- > > drivers/gpu/drm/panel/panel-himax-hx83102.c | 6 +- > 1 file changed, 5 insertions(+)

Re: [PATCH 6/8] drm/panel: himax-hx83102: If prepare fails, disable GPIO before regulators

2024-05-19 Thread Dmitry Baryshkov
panel: himax-hx83102: Break out as separate driver") > Signed-off-by: Douglas Anderson > --- > > drivers/gpu/drm/panel/panel-himax-hx83102.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH 5/8] drm/panel: ilitek-ili9882t: Check for errors on the NOP in prepare()

2024-05-19 Thread Dmitry Baryshkov
uld fail too. > > Found by code inspection. > > Fixes: e2450d32e5fb ("drm/panel: ili9882t: Break out as separate driver") > Signed-off-by: Douglas Anderson > --- > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH 4/8] drm/panel: ilitek-ili9882t: If prepare fails, disable GPIO before regulators

2024-05-19 Thread Dmitry Baryshkov
ili9882t: Break out as separate driver") > Signed-off-by: Douglas Anderson > --- > > drivers/gpu/drm/panel/panel-ilitek-ili9882t.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH 3/8] drm/panel: boe-tv101wum-nl6: Check for errors on the NOP in prepare()

2024-05-19 Thread Dmitry Baryshkov
uld fail too. > > Found by code inspection. > > Fixes: 812562b8d881 ("drm/panel: boe-tv101wum-nl6: Fine tune the panel power > sequence") > Signed-off-by: Douglas Anderson > --- > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH 2/8] drm/panel: boe-tv101wum-nl6: If prepare fails, disable GPIO before regulators

2024-05-19 Thread Dmitry Baryshkov
nel: support for boe tv101wum-nl6 wuxga dsi video > mode panel") > Signed-off-by: Douglas Anderson > --- > > drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH 1/8] drm/panel: himax-hx8394: Handle errors from mipi_dsi_dcs_set_display_on() better

2024-05-19 Thread Dmitry Baryshkov
5dc9360f741 ("drm: panel: Add Himax HX8394 panel controller driver") > Signed-off-by: Douglas Anderson > --- > > drivers/gpu/drm/panel/panel-himax-hx8394.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH] drm/komeda: remove unused struct 'gamma_curve_segment'

2024-05-19 Thread Dmitry Baryshkov
komeda_color_mgmt.c | 5 - > 1 file changed, 5 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-19 Thread Dmitry Baryshkov
On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote: > Commit f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins") > fails to consider the case where adv7511->i2c_main->irq is zero, i.e., > no interrupt requested at all. > > Without interrupt, adv7511_wait_for_edid() could

Re: [PATCH v2 1/3] drm/bridge: tc358767: Use dev_err_probe

2024-05-19 Thread Dmitry Baryshkov
rivers/gpu/drm/bridge/tc358767.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH 0/2] drm/bridge: Add 'struct device *' field to the drm_bridge structure

2024-05-19 Thread Dmitry Baryshkov
On Thu, May 16, 2024 at 08:04:59PM +0800, Sui Jingfeng wrote: > > > On 5/16/24 18:40, Sui Jingfeng wrote: > > use 'to_i2c_client(bridge->dev)' to retrieve the pointer > > to_i2c_client(bridge->kdev). > > Besides, this also means that we don't need to add the fwnode > pointer into struct

  1   2   3   4   5   6   7   8   9   10   >