Re: Kernel 5.15.150 black screen with AMD Raven/Picasso GPU

2024-05-23 Thread Greg KH
On Thu, May 23, 2024 at 05:59:39PM +0200, Armin Wolf wrote: > Am 23.05.24 um 15:13 schrieb Barry Kauler: > > > On Wed, May 22, 2024 at 12:58 AM Armin Wolf wrote: > > > Am 20.05.24 um 18:22 schrieb Alex Deucher: > > > > > > > On Sat, May 18, 2024 at 8:17 PM Armin Wolf wrote: > > > > > Am

Re: [PATCH 1/2] drm/rockchip: vop: clear DMA stop bit on flush on RK3066

2024-05-19 Thread Greg KH
On Sun, May 19, 2024 at 05:38:24AM -0300, Val Packett wrote: > > > On Sun, May 19 2024 at 09:59:47 +02:00:00, Greg KH > wrote: > > On Sun, May 19, 2024 at 04:31:31AM -0300, Val Packett wrote: > > > On the RK3066, there is a bit that must be cleared on flush, &

Re: [PATCH 1/2] drm/rockchip: vop: clear DMA stop bit on flush on RK3066

2024-05-19 Thread Greg KH
On Sun, May 19, 2024 at 04:31:31AM -0300, Val Packett wrote: > On the RK3066, there is a bit that must be cleared on flush, otherwise > we do not get display output (at least for RGB). > > Signed-off-by: Val Packett > Cc: sta...@vger.kernel.org > --- > Hi! This was required to get display

Re: [PATCH 2/2] drm/rockchip: vop: enable VOP_FEATURE_INTERNAL_RGB on RK3066

2024-05-19 Thread Greg KH
On Sun, May 19, 2024 at 04:31:32AM -0300, Val Packett wrote: > Signed-off-by: Val Packett > Cc: sta...@vger.kernel.org > --- > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 + > 1 file changed, 1 insertion(+) Maybe the DRM subsystem has more lax rules, but I know I can't take patches without

Re: [Regression] 6.9.0: WARNING: workqueue: WQ_MEM_RECLAIM ttm:ttm_bo_delayed_delete [ttm] is flushing !WQ_MEM_RECLAIM events:qxl_gc_work [qxl]

2024-05-13 Thread Greg KH
On Wed, May 08, 2024 at 02:51:10PM +0200, Linux regression tracking (Thorsten Leemhuis) wrote: > On 08.05.24 14:35, Anders Blomdell wrote: > > On 2024-05-07 07:04, Linux regression tracking (Thorsten Leemhuis) wrote: > >> On 06.05.24 16:30, David Wang wrote: > On 30.04.24 08:13, David Wang

Re: [linux-next:master] BUILD REGRESSION 9c6ecb3cb6e20c4fd7997047213ba0efcf9ada1a

2024-05-03 Thread Greg KH
On Fri, May 03, 2024 at 11:30:50AM +0530, Krishna Kurapati PSSNV wrote: > > > On 5/3/2024 10:42 AM, Greg KH wrote: > > Ok, I'm getting tired of seeing these for the USB portion of the tree, > > so I went to look for: > > > > On Fri, May 03, 2024 at 04:44:42

Re: [linux-next:master] BUILD REGRESSION 9c6ecb3cb6e20c4fd7997047213ba0efcf9ada1a

2024-05-02 Thread Greg KH
Ok, I'm getting tired of seeing these for the USB portion of the tree, so I went to look for: On Fri, May 03, 2024 at 04:44:42AM +0800, kernel test robot wrote: > |-- arc-randconfig-002-20240503 > | `-- drivers-usb-dwc3-core.c:warning:variable-hw_mode-set-but-not-used This warning (same for

Re: 答复: [PATCH v5.10] drm/amd/display: Wake DMCUB before executing GPINT commands

2024-04-18 Thread Greg KH
On Thu, Apr 18, 2024 at 03:19:46AM +, wangzhu wrote: > Hi Greg, thanks for your reply. Since there is no patch to fix CVE-2023-52624 > in linux-5.10, there is a patch in the linux-6.7 branch to fix it, its commit > is 2ef98c6d753a744e333b7e34b9cf687040fba57d ("drm/amd/display: Wake DMCUB >

Re: 答复: [PATCH v6.6] drm/amd/display: Wake DMCUB before executing GPINT commands

2024-04-17 Thread Greg KH
On Thu, Apr 18, 2024 at 01:51:33AM +, wangzhu wrote: > Hi Greg, thanks for your reply. Since there is no patch to fix CVE-2023-52624 > in linux-5.10, there is a patch in the linux-6.7 branch, its commit is > 2ef98c6d753a744e333b7e34b9cf687040fba57d ("drm/amd/display: Wake DMCUB before >

Re: [PATCH v6.6] drm/amd/display: Wake DMCUB before executing GPINT commands

2024-04-15 Thread Greg KH
On Tue, Apr 16, 2024 at 03:52:40AM +, Zhu Wang wrote: > From: Nicholas Kazlauskas > > stable inclusion > from stable-v6.7.3 > commit 2ef98c6d753a744e333b7e34b9cf687040fba57d > category: bugfix > bugzilla: https://gitee.com/src-openeuler/kernel/issues/I9BV4C > CVE: CVE-2023-52624 > >

Re: [PATCH v5.10] drm/amd/display: Wake DMCUB before executing GPINT commands

2024-04-15 Thread Greg KH
On Tue, Apr 16, 2024 at 02:43:47AM +, Zhu Wang wrote: > From: Nicholas Kazlauskas > > stable inclusion > from stable-v6.7.3 > commit2ef98c6d753a7 ("drm/amd/display: Wake DMCUB before executing > GPINT commands") > category: bugfix > bugzilla:

Re: [PATCH 4.19.y] drm/vkms: call drm_atomic_helper_shutdown before drm_dev_put()

2024-04-11 Thread Greg KH
On Tue, Apr 09, 2024 at 10:38:34AM +0800, guomengqi (A) wrote: > > 在 2024/4/5 17:30, Greg KH 写道: > > On Wed, Apr 03, 2024 at 05:47:16PM +0800, Guo Mengqi wrote: > > > commit 73a82b22963d ("drm/atomic: Fix potential use-after-free > > > in nonblocking c

Re: [PATCH] staging: fbtft: fb_st7789v: support setting offset

2024-04-09 Thread Greg KH
On Wed, Apr 10, 2024 at 01:28:06AM +0800, Yuguo Pei wrote: > On Tue, 9 Apr 2024 17:49:25 +0200, Greg KH wrote: > > So you are now hard-coding the size? > > Yes, the change just helps developers who want to adapt to different screen > sizes. So there is no change?

Re: [PATCH] staging: fbtft: fb_st7789v: support setting offset

2024-04-09 Thread Greg KH
On Sat, Apr 06, 2024 at 12:57:47AM +0800, purofle wrote: > Some screen sizes using st7789v chips are different from 240x320, > and offsets need to be set to display all images properly. > > Signed-off-by: purofle We need a semi-real name here please. > --- > drivers/staging/fbtft/fb_st7789v.c

Re: [PATCH 4.19.y] drm/vkms: call drm_atomic_helper_shutdown before drm_dev_put()

2024-04-05 Thread Greg KH
On Wed, Apr 03, 2024 at 05:47:16PM +0800, Guo Mengqi wrote: > commit 73a82b22963d ("drm/atomic: Fix potential use-after-free > in nonblocking commits") introduced drm_dev_get/put() to > drm_atomic_helper_shutdown(). And this cause problem in vkms driver exit > process. > > vkms_exit() >

Re: [PATCH v2 1/1] Revert "drm/qxl: simplify qxl_fence_wait"

2024-04-04 Thread Greg KH
On Thu, Apr 04, 2024 at 07:14:48PM +0100, Alex Constantino wrote: > This reverts commit 5a838e5d5825c85556011478abde708251cc0776. > > Changes from commit 5a838e5d5825 ("drm/qxl: simplify qxl_fence_wait") would > result in a '[TTM] Buffer eviction failed' exception whenever it reached a > timeout.

Re: [PATCH] drm/vkms: call drm_atomic_helper_shutdown before drm_dev_put()

2024-03-29 Thread Greg KH
On Thu, Mar 21, 2024 at 03:55:37PM +0800, guomengqi (A) wrote: > > 在 2024/3/21 15:39, Greg KH 写道: > > On Thu, Mar 21, 2024 at 03:07:52PM +0800, Guo Mengqi wrote: > > > commit 73a82b22963d ("drm/atomic: Fix potential use-after-free > > > in nonblocking c

Re: [PATCH v2 5/6] staging: fbtft: Remove reference to fb_blank

2024-03-22 Thread Greg KH
On Tue, Mar 19, 2024 at 10:37:24AM +0100, Thomas Zimmermann wrote: > The field fb_blank in struct backlight_properties is deprecated and > should not be used. Don't output its value in the driver's debug print. > > Signed-off-by: Thomas Zimmermann > Reviewed-by: Dan Carpenter Acked-by: Greg

Re: [PATCH] drm/vkms: call drm_atomic_helper_shutdown before drm_dev_put()

2024-03-21 Thread Greg KH
On Thu, Mar 21, 2024 at 03:07:52PM +0800, Guo Mengqi wrote: > commit 73a82b22963d ("drm/atomic: Fix potential use-after-free > in nonblocking commits") introduced drm_dev_get/put() to > drm_atomic_helper_shutdown(). And this cause problem in vkms driver exit > process. > > vkms_exit() >

Re: Nova and staging Rust abstractions

2024-03-20 Thread Greg KH
On Wed, Mar 20, 2024 at 06:58:43PM +0100, Danilo Krummrich wrote: > @Greg, can you please have a first quick look at rust-device [5]? If they are sent as patches to review, yes, I can get to them as part of my normal patch review cycle. Otherwise I have no cyeles to dig through random github

Re: [PATCH stable v6.7] drm/nouveau: don't fini scheduler before entity flush

2024-03-04 Thread Greg KH
On Mon, Mar 04, 2024 at 07:10:56PM +0100, Danilo Krummrich wrote: > On 3/4/24 18:55, Greg KH wrote: > > On Mon, Mar 04, 2024 at 06:01:46PM +0100, Danilo Krummrich wrote: > > > Cc: # v6.7 only > > You say 6.7 only, but this commit is in 6.6, so why not 6.6 also? >

Re: [PATCH stable v6.7] drm/nouveau: don't fini scheduler before entity flush

2024-03-04 Thread Greg KH
On Mon, Mar 04, 2024 at 06:01:46PM +0100, Danilo Krummrich wrote: > This bug is present in v6.7 only, since the scheduler design has been > re-worked in v6.8. Now queued up, thanks. greg k-h

Re: [PATCH stable v6.7] drm/nouveau: don't fini scheduler before entity flush

2024-03-04 Thread Greg KH
On Mon, Mar 04, 2024 at 06:01:46PM +0100, Danilo Krummrich wrote: > This bug is present in v6.7 only, since the scheduler design has been > re-worked in v6.8. > > Client scheduler entities must be flushed before an associated GPU > scheduler is teared down. Otherwise the entitiy might still hold

Re: [PATCH v2 2/8] staging/fbtft: Include

2024-02-17 Thread Greg KH
On Tue, Feb 13, 2024 at 09:42:20AM +0100, Thomas Zimmermann wrote: > Resolved the proxy include via , which does not require the > backlight header. > > Signed-off-by: Thomas Zimmermann Acked-by: Greg Kroah-Hartman

Re: [PATCH 0/2] drm/vmwgfx backport two fixes to v6.1.x branch

2024-01-22 Thread Greg KH
On Mon, Jan 22, 2024 at 06:10:11PM +0100, Jocelyn Falempe wrote: > Hi, > > I've backported this two commits: > f9e96bf19054 drm/vmwgfx: Fix possible invalid drm gem put calls > 91398b413d03 drm/vmwgfx: Keep a gem reference to user bos in surfaces > > They both fixes a950b989ea29 ("drm/vmwgfx: Do

Re: [PATCH 31/45] tty: vt: use VESA blanking constants

2024-01-18 Thread Greg KH
On Thu, Jan 18, 2024 at 09:41:34AM +0100, Thomas Zimmermann wrote: > Hi > > Am 18.01.24 um 09:32 schrieb Jiri Slaby: > > On 18. 01. 24, 9:30, Thomas Zimmermann wrote: > > > Am 18.01.24 um 08:57 schrieb Jiri Slaby (SUSE): > > > > There are VESA blanking constants defined in console.h already. So

Re: [RFC PATCH] drm/amd/display: fix bandwidth validation failure on DCN 2.1

2024-01-03 Thread Greg KH
On Wed, Jan 03, 2024 at 09:44:18AM -0500, Hamza Mahfooz wrote: > On 12/29/23 11:25, Melissa Wen wrote: > > IGT `amdgpu/amd_color/crtc-lut-accuracy` fails right at the beginning of > > the test execution, during atomic check, because DC rejects the > > bandwidth state for a fb sizing 64x64. The

Re: [PATCH 1/1] Revert "drm/edid: Fix csync detailed mode parsing"

2023-12-09 Thread Greg KH
On Wed, Dec 06, 2023 at 11:49:46AM +0300, kova...@altlinux.org wrote: > From: Vasiliy Kovalev > > This reverts commit 5a46dc8e4a064769e916d87bf9bccae75afc7289. > > Commit 50b6f2c8297793f7f3315623db78dcff85158e96 upstream. > > Commit 5a46dc8e4a0647 ("drm/edid: Fix csync detailed mode parsing")

Re: [PATCH v2 1/2] driver core: Export device_is_dependent() to modules

2023-11-27 Thread Greg KH
On Mon, Nov 27, 2023 at 05:38:13PM +0100, Maxime Ripard wrote: > Greg, Rafael, > > On Mon, Nov 27, 2023 at 01:14:13PM +0800, Liu Ying wrote: > > Export device_is_dependent() since the drm_kms_helper module is starting > > to use it. > > > > Signed-off-by: Liu Ying > > --- > > v2: > > * Newly

Re: [PATCH v7 1/3] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-17 Thread Greg KH
On Fri, Nov 17, 2023 at 01:46:32PM -0800, Hsin-Yi Wang wrote: > Generic edp gets mode from edid. However, some panels report incorrect > mode in this way, resulting in glitches on panel. Introduce a new quirk > additional_mode to the generic edid to pick a correct hardcoded mode. > >

Re: [PATCH] drm/amd/pm: replace 1-element arrays with flexible-array members

2023-11-09 Thread Greg KH
On Thu, Nov 09, 2023 at 10:43:50AM +0200, José Pekkarinen wrote: > On 2023-11-08 09:29, Greg KH wrote: > > On Wed, Nov 08, 2023 at 08:54:35AM +0200, José Pekkarinen wrote: > > > The following case seems to be safe to be replaced with a flexible > > > array > > &

Re: [PATCH] drm/amd/pm: replace 1-element arrays with flexible-array members

2023-11-07 Thread Greg KH
On Wed, Nov 08, 2023 at 08:54:35AM +0200, José Pekkarinen wrote: > The following case seems to be safe to be replaced with a flexible array > to clean up the added coccinelle warning. This patch will just do it. > > drivers/gpu/drm/amd/pm/powerplay/smumgr/smu8_smumgr.h:76:38-63: WARNING use >

Re: [PATCH v6 4/5] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-07 Thread Greg KH
On Tue, Nov 07, 2023 at 12:41:54PM -0800, Hsin-Yi Wang wrote: > Generic edp gets mode from edid. However, some panels report incorrect > mode in this way, resulting in glitches on panel. Introduce a new quirk > additional_mode to the generic edid to pick a correct hardcoded mode. > >

Re: [PATCH v6 3/5] drm/panel-edp: drm/panel-edp: Add several generic edp panels

2023-11-07 Thread Greg KH
On Tue, Nov 07, 2023 at 12:41:53PM -0800, Hsin-Yi Wang wrote: > Add a few generic edp panels used by mt8186 chromebooks. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Douglas Anderson > --- > no change. > --- > drivers/gpu/drm/panel/panel-edp.c | 51 +++ > 1 file

Re: [PATCH] drm/amd/display: remove redundant check

2023-10-31 Thread Greg KH
On Tue, Oct 31, 2023 at 01:42:17PM +0200, José Pekkarinen wrote: > On 2023-10-31 07:48, Greg KH wrote: > > On Mon, Oct 30, 2023 at 07:17:48PM +0200, José Pekkarinen wrote: > > > This patch addresses the following warning spotted by > > > using coccinelle where the

Re: [PATCH] drm/amd/display: remove redundant check

2023-10-30 Thread Greg KH
On Mon, Oct 30, 2023 at 07:17:48PM +0200, José Pekkarinen wrote: > This patch addresses the following warning spotted by > using coccinelle where the case checked does the same > than the else case. > > drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10: > WARNING:

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-10-09 Thread Greg KH
On Mon, Oct 09, 2023 at 02:46:40PM +0200, Christian König wrote: > Am 07.10.23 um 11:50 schrieb Greg KH: > > On Sun, Sep 10, 2023 at 03:43:01PM -0500, Bryan Jennings wrote: > > > This is also causing log spam on 5.15. It was included in 5.15.1

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-10-07 Thread Greg KH
On Sun, Sep 10, 2023 at 03:43:01PM -0500, Bryan Jennings wrote: > This is also causing log spam on 5.15. It was included in 5.15.128 as > commit 4921792e04f2125b5eadef9dbe9417a8354c7eff. I encountered this and > found https://gitlab.freedesktop.org/drm/amd/-/issues/2820 while researching > the

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-09-12 Thread Greg KH
On Sun, Sep 10, 2023 at 03:43:01PM -0500, Bryan Jennings wrote: > This is also causing log spam on 5.15. It was included in 5.15.128 as > commit 4921792e04f2125b5eadef9dbe9417a8354c7eff. I encountered this and > found https://gitlab.freedesktop.org/drm/amd/-/issues/2820 while researching > the

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-08-31 Thread Greg KH
On Thu, Aug 31, 2023 at 03:26:28PM +0200, Christian König wrote: > Am 31.08.23 um 12:56 schrieb Greg KH: > > On Thu, Aug 31, 2023 at 12:27:27PM +0200, Christian König wrote: > > > Am 30.08.23 um 20:53 schrieb Chia-I Wu: > > > > On Sun, Jul 23, 2023 at 6:24 PM Sash

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-08-31 Thread Greg KH
On Thu, Aug 31, 2023 at 12:27:27PM +0200, Christian König wrote: > Am 30.08.23 um 20:53 schrieb Chia-I Wu: > > On Sun, Jul 23, 2023 at 6:24 PM Sasha Levin wrote: > > > From: Lang Yu > > > > > > [ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ] > > > > > > When using cpu to update

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-08-31 Thread Greg KH
On Wed, Aug 30, 2023 at 11:53:29AM -0700, Chia-I Wu wrote: > On Sun, Jul 23, 2023 at 6:24 PM Sasha Levin wrote: > > > > From: Lang Yu > > > > [ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ] > > > > When using cpu to update page tables, vm update fences are unused. > > Install stub

Re: [PATCH 8/8] staging/fbtft: Use fb_ops helpers for deferred I/O

2023-08-28 Thread Greg KH
On Mon, Aug 28, 2023 at 03:14:24PM +0200, Thomas Zimmermann wrote: > Generate callback functions for struct fb_ops with the fbdev macro > FB_GEN_DEFAULT_DEFERRED_SYSMEM_OPS(). Initialize struct fb_ops to > the generated functions with an fbdev initializer macro. > > Signed-off-by: Thomas

Re: [PATCH 7/8] staging/fbtft: Initialize fb_op struct as static const

2023-08-28 Thread Greg KH
On Mon, Aug 28, 2023 at 03:14:23PM +0200, Thomas Zimmermann wrote: > Replace dynamic allocation of the fb_ops instance with static > allocation. Initialize the fields at module-load time. The owner > field changes to THIS_MODULE, as in all other fbdev drivers. > > Signed-off-by: Thomas Zimmermann

Re: [PATCH v2 4/4] staging/sm750fb: Do not include

2023-07-06 Thread Greg KH
On Thu, Jul 06, 2023 at 12:42:17PM +0200, Thomas Zimmermann wrote: > The sm750fb driver does not need anything from . > Remove the include statements. > > Signed-off-by: Thomas Zimmermann > Reviewed-by: Javier Martinez Canillas > Cc: Sudip Mukherjee > Cc: Teddy Wang > --- >

Re: [PATCH v10 00/25] DEPT(Dependency Tracker)

2023-06-26 Thread Greg KH
On Mon, Jun 26, 2023 at 08:56:35PM +0900, Byungchul Park wrote: > >From now on, I can work on LKML again! I'm wondering if DEPT has been > helping kernel debugging well even though it's a form of patches yet. > > I'm happy to see that DEPT reports a real problem in practice. See: > > >

Re: [PATCH] dma-buf: keep the signaling time of merged fences

2023-06-21 Thread Greg KH
On Wed, Jun 21, 2023 at 02:05:07PM +0200, Christian König wrote: > Am 21.06.23 um 13:02 schrieb Greg KH: > > On Wed, Jun 21, 2023 at 09:32:04AM +0200, Christian König wrote: > > > Some Android CTS is testing for that. > > > > > > Signed-off-by: Christian Kön

Re: [PATCH] dma-buf: keep the signaling time of merged fences

2023-06-21 Thread Greg KH
On Wed, Jun 21, 2023 at 09:32:04AM +0200, Christian König wrote: > Some Android CTS is testing for that. > > Signed-off-by: Christian König > CC: sta...@vger.kernel.org What commit id does this fix? thanks, greg k-h

Re: [PATCH] dma-buf: keep the signaling time of merged fences

2023-06-21 Thread Greg KH
On Wed, Jun 21, 2023 at 09:32:04AM +0200, Christian König wrote: > Some Android CTS is testing for that. > > Signed-off-by: Christian König > CC: sta...@vger.kernel.org > --- > drivers/dma-buf/dma-fence-unwrap.c | 11 +-- > drivers/dma-buf/dma-fence.c| 5 +++-- >

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

2023-06-05 Thread Greg KH
On Mon, Jun 05, 2023 at 04:48:12PM +0200, Thomas Zimmermann wrote: > Add Kconfig option CONFIG_FB_DEVICE and make the virtual fbdev > device optional. If the new option has not been selected, fbdev > does not create a files in devfs or sysfs. > > Most modern Linux systems run a DRM-based graphics

Re: [PATCH v2] drm/amdgpu: add a missing lock for AMDGPU_SCHED

2023-04-26 Thread Greg KH
On Tue, Apr 25, 2023 at 11:17:14PM -0700, Chia-I Wu wrote: > mgr->ctx_handles should be protected by mgr->lock. > > v2: improve commit message > > Signed-off-by: Chia-I Wu > Cc: sta...@vger.kernel.org What commit id does this fix? How far back in stable kernels should this go? thanks, greg

Re: [PATCH] drm/amdgpu: add a missing lock for AMDGPU_SCHED

2023-04-25 Thread Greg KH
On Tue, Apr 25, 2023 at 05:48:27PM -0700, Chia-I Wu wrote: > Signed-off-by: Chia-I Wu > Cc: sta...@vger.kernel.org I know I can not take patches without any changelog text at all, maybe the DRM developers are more lax, but it's not a good idea at all. thanks, greg k-h

Re: [PATCH] Revert "accel/qaic: Add mhi_qaic_cntl"

2023-04-12 Thread Greg KH
On Wed, Apr 12, 2023 at 07:57:44AM -0600, Jeffrey Hugo wrote: > This reverts commit 566fc96198b4bb07ca6806386956669881225271. > > This exposes a userspace API that is still under debate. Revert the > change before the uAPI gets exposed to avoid making a mistake. QAIC is > otherwise still

Re: linux-next: build failure after merge of the driver-core tree

2023-04-12 Thread Greg KH
10:31 AM, Daniel Vetter wrote: > > > > > On Tue, Apr 11, 2023 at 09:29:27AM -0600, Jeffrey Hugo wrote: > > > > > > On 4/11/2023 9:26 AM, Jeffrey Hugo wrote: > > > > > > > On 4/11/2023 9:13 AM, Greg KH wrote: > > > > > > > >

Re: linux-next: build failure after merge of the driver-core tree

2023-04-11 Thread Greg KH
On Tue, Apr 11, 2023 at 09:08:39AM -0600, Jeffrey Hugo wrote: > On 4/11/2023 9:01 AM, Daniel Vetter wrote: > > On Tue, Apr 11, 2023 at 12:40:28PM +0200, Greg KH wrote: > > > On Tue, Apr 11, 2023 at 11:55:20AM +0200, Daniel Vetter wrote: > > > > On Tue, Apr 11, 202

Re: linux-next: build failure after merge of the driver-core tree

2023-04-11 Thread Greg KH
On Tue, Apr 11, 2023 at 11:55:20AM +0200, Daniel Vetter wrote: > On Tue, Apr 11, 2023 at 02:38:12PM +1000, Stephen Rothwell wrote: > > Hi all, > > > > After merging the driver-core tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > In file included from

Re: [PATCH] Staging: fbtft: fbtft-bus: fixed extra space and parenthesis issue

2023-04-08 Thread Greg KH
On Sat, Apr 08, 2023 at 10:33:23AM +0530, Deepanshu Kartikey wrote: > Fixed a coding styling issue > > Signed-off-by: Deepanshu Kartikey > --- > drivers/staging/fbtft/fbtft-bus.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/fbtft/fbtft-bus.c >

Re: [PATCH] staging: fbtft: fbtft-bus.c added params

2023-04-08 Thread Greg KH
On Sat, Apr 08, 2023 at 01:48:17PM +0530, Deepanshu Kartikey wrote: > Added cpu_to_be16 param in define_fbtft_write_reg > > Signed-off-by: Deepanshu Kartikey > --- > drivers/staging/fbtft/fbtft-bus.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCHv2] fbcon: Check font dimension limits

2023-01-31 Thread Greg KH
On Sun, Jan 29, 2023 at 04:17:40PM +0100, Samuel Thibault wrote: > blit_x and blit_y are u32, so fbcon currently cannot support fonts > larger than 32x32. > > The 32x32 case also needs shifting an unsigned int, to properly set bit > 31, otherwise we get "UBSAN: shift-out-of-bounds in

Re: linux-next: manual merge of the usb tree with the drm-intel-fixes tree

2023-01-30 Thread Greg KH
On Tue, Jan 31, 2023 at 01:03:05PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the usb tree got a conflict in: > > drivers/gpu/drm/i915/gt/intel_engine_cs.c > > between commit: > > 5bc4b43d5c6c ("drm/i915: Fix up locking around dumping requests lists") > >

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-29 Thread Greg KH
On Fri, Jan 27, 2023 at 03:02:41PM +, Limonciello, Mario wrote: > [Public] > > > > > -Original Message- > > From: Linux kernel regression tracking (Thorsten Leemhuis) > > > > Sent: Friday, January 27, 2023 03:15 > > To: Greg KH ;

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-26 Thread Greg KH
On Fri, Jan 20, 2023 at 11:51:04AM -0600, Limonciello, Mario wrote: > On 1/20/2023 11:46, Guenter Roeck wrote: > > On Thu, Jan 12, 2023 at 04:50:44PM +0800, Wayne Lin wrote: > > > This reverts commit 4d07b0bc403403438d9cf88450506240c5faf92f. > > > > > > [Why] > > > Changes cause regression on

Re: [PATCH] fbcon: Check font dimension limits

2023-01-25 Thread Greg KH
On Thu, Jan 26, 2023 at 01:49:12AM +0100, Samuel Thibault wrote: > blit_x and blit_y are uint32_t, so fbcon currently cannot support fonts > larger than 32x32. "u32" you mean, right? > The 32x32 case also needs shifting an unsigned int, to properly set bit > 31, otherwise we get "UBSAN:

Re: [PATCH 5.10 1/1] drm/amdkfd: Check for null pointer after calling kmemdup

2023-01-12 Thread Greg KH
On Thu, Jan 12, 2023 at 04:26:45PM +0100, Daniel Vetter wrote: > On Thu, 12 Jan 2023 at 13:47, Greg KH wrote: > > On Wed, Jan 04, 2023 at 07:56:33PM +0200, Dragos-Marian Panait wrote: > > > From: Jiasheng Jiang > > > > > > [ Upstream commit abfa

Re: [PATCH 5.10 1/1] drm/amdkfd: Check for null pointer after calling kmemdup

2023-01-12 Thread Greg KH
On Wed, Jan 04, 2023 at 07:56:33PM +0200, Dragos-Marian Panait wrote: > From: Jiasheng Jiang > > [ Upstream commit abfaf0eee97925905e742aa3b0b72e04a918fa9e ] > > As the possible failure of the allocation, kmemdup() may return NULL > pointer. > Therefore, it should be better to check the

Re: [PATCH 1/2] drm/atomic: Allow vblank-enabled + self-refresh "disable"

2023-01-05 Thread Greg KH
On Thu, Jan 05, 2023 at 05:40:17PM -0800, Brian Norris wrote: > The self-refresh helper framework overloads "disable" to sometimes mean > "go into self-refresh mode," and this mode activates automatically > (e.g., after some period of unchanging display output). In such cases, > the display pipe

Re: [PATCH 4.19 1/1] drm/amdkfd: Check for null pointer after calling kmemdup

2023-01-05 Thread Greg KH
On Wed, Jan 04, 2023 at 08:05:57PM +0200, Dragos-Marian Panait wrote: > > On 04.01.2023 16:48, Greg KH wrote: > > On Wed, Jan 04, 2023 at 09:35:03AM -0500, Alex Deucher wrote: > > > On Wed, Jan 4, 2023 at 8:23 AM Christian König > > > wrote: > > >

Re: [PATCH 4.19 1/1] drm/amdkfd: Check for null pointer after calling kmemdup

2023-01-04 Thread Greg KH
On Wed, Jan 04, 2023 at 09:35:03AM -0500, Alex Deucher wrote: > On Wed, Jan 4, 2023 at 8:23 AM Christian König > wrote: > > > > Am 04.01.23 um 13:41 schrieb Greg KH: > > > On Tue, Jan 03, 2023 at 08:43:08PM +0200, Dragos-Marian Panait wrote: > > >> From: J

Re: [PATCH 4.19 1/1] drm/amdkfd: Check for null pointer after calling kmemdup

2023-01-04 Thread Greg KH
On Tue, Jan 03, 2023 at 08:43:08PM +0200, Dragos-Marian Panait wrote: > From: Jiasheng Jiang > > [ Upstream commit abfaf0eee97925905e742aa3b0b72e04a918fa9e ] > > As the possible failure of the allocation, kmemdup() may return NULL > pointer. > Therefore, it should be better to check the

Re: [PATCH 4.19 0/1] drm/amdkfd: Check for null pointer after calling kmemdup

2023-01-04 Thread Greg KH
On Tue, Jan 03, 2023 at 08:43:07PM +0200, Dragos-Marian Panait wrote: > The following commit is needed to fix CVE-2022-3108: That's a funny cve, given that you can not ever trigger it in a system, right? Why was a CVE allocated for that? {sigh}

Re: [PATCH 1/2] habanalabs/uapi: move uapi file to drm

2022-12-27 Thread Greg KH
On Tue, Dec 27, 2022 at 02:04:14PM +0200, Oded Gabbay wrote: > On Tue, Dec 27, 2022 at 9:26 AM Greg KH wrote: > > > > On Mon, Dec 26, 2022 at 11:32:26PM +0200, Oded Gabbay wrote: > > > Move the habanalabs.h uapi file from include/uapi/misc to > >

Re: [PATCH 1/2] habanalabs/uapi: move uapi file to drm

2022-12-26 Thread Greg KH
On Mon, Dec 26, 2022 at 11:32:26PM +0200, Oded Gabbay wrote: > Move the habanalabs.h uapi file from include/uapi/misc to > include/uapi/drm, and rename it to habanalabs_accel.h. > > This is required before moving the actual driver to the accel > subsystem. What requires this? Isn't this going

Re: [PATCH v3] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent

2022-12-23 Thread Greg KH
On Sat, Dec 24, 2022 at 10:50:01AM +0800, Jiasheng Jiang wrote: > Yes, it is the same as mine. > As the previous patch had not been merged into the Linux kernel, > my tool found the same error and report it. > And both of us chose the most concise way to fix the error. > That is why the patches

Re: [PATCH v3] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent

2022-12-23 Thread Greg KH
On Thu, Dec 15, 2022 at 08:31:12PM +0800, Jiasheng Jiang wrote: > Add the check for the return value of dma_alloc_coherent in order to > avoid NULL pointer dereference. > > This flaw was found using an experimental static analysis tool we are > developing, APP-Miner, which has not been disclosed.

Re: [PATCH] drivers: staging: fbtft: Replace usage of udelay

2022-12-14 Thread Greg KH
On Thu, Dec 15, 2022 at 01:37:46AM +, Haris M. Bhatti wrote: > checkpatch highlighted that use of udelay should be replaced by > usleep_range. > --- > drivers/staging/fbtft/fb_ra8875.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent

2022-12-14 Thread Greg KH
On Wed, Dec 14, 2022 at 10:54:14AM +0800, Jiasheng Jiang wrote: > Add the check for the return value of dma_alloc_coherent in order to > avoid NULL pointer dereference. > > This flaw was found using an experimental static analysis tool we are > developing, APP-Miner, which has not been disclosed.

Re: [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent

2022-12-13 Thread Greg KH
On Tue, Dec 13, 2022 at 08:21:16PM +0800, Jiasheng Jiang wrote: > Add the check for the return value of dma_alloc_coherent > in order to avoid NULL pointer dereference. > > Fixes: 055276c13205 ("usb: gadget: add Aspeed ast2600 udc driver") > Signed-off-by: Jiasheng Jiang Again, please prove

Re: [PATCH] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent

2022-12-13 Thread Greg KH
On Tue, Dec 13, 2022 at 08:15:20PM +0800, Jiasheng Jiang wrote: > Thanks, I found my mistake and I will submit a v2. > > > And how did you find this potential problem? What tool did you use and > > why did you not follow the documentation for properly describing the > > tool? > > I used a tool

Re: [PATCH] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent

2022-12-12 Thread Greg KH
On Tue, Dec 13, 2022 at 10:51:19AM +0800, Jiasheng Jiang wrote: > Add the check for the return value of dma_alloc_coherent > in order to avoid NULL pointer dereference. > > Fixes: 055276c13205 ("usb: gadget: add Aspeed ast2600 udc driver") > Signed-off-by: Jiasheng Jiang > --- >

Re: [PATCH v2 0/6] drm/gud: Use the shadow plane helper

2022-12-01 Thread Greg KH
On Thu, Dec 01, 2022 at 02:14:42PM +0100, Noralf Trønnes wrote: > > > Den 01.12.2022 13.12, skrev Greg KH: > > On Thu, Dec 01, 2022 at 11:00:44AM +0100, Noralf Trønnes wrote: > >> > >> > >> Den 01.12.2022 06.55, skrev Greg KH: > >>> On Wed, N

Re: [PATCH v2 0/6] drm/gud: Use the shadow plane helper

2022-12-01 Thread Greg KH
On Thu, Dec 01, 2022 at 11:00:44AM +0100, Noralf Trønnes wrote: > > > Den 01.12.2022 06.55, skrev Greg KH: > > On Wed, Nov 30, 2022 at 08:26:48PM +0100, Noralf Trønnes via B4 Submission > > Endpoint wrote: > >> Hi, > >> > >> I have started to l

Re: [PATCH v2 0/6] drm/gud: Use the shadow plane helper

2022-12-01 Thread Greg KH
On Wed, Nov 30, 2022 at 08:26:48PM +0100, Noralf Trønnes via B4 Submission Endpoint wrote: > Hi, > > I have started to look at igt for testing and want to use CRC tests. To > implement support for this I need to move away from the simple kms > helper. > > When looking around for examples I came

Re: [PATCH 0/7] DYNAMIC_DEBUG fixups for rc

2022-11-16 Thread Greg KH
On Fri, Nov 11, 2022 at 03:17:08PM -0700, Jim Cromie wrote: > hi Jason, Greg, DRM-folk, > > drm.debug-on-dyndbg has a regression due to a chicken-&-egg problem; > drm.debug is applied to enable dyndbg callsites before the dependent > modules' callsites are available to be enabled. > > My "fixes"

Re: [PATCH 1/7] drm: mark drm.debug-on-dyndbg as BROKEN for now

2022-11-16 Thread Greg KH
On Fri, Nov 11, 2022 at 03:17:09PM -0700, Jim Cromie wrote: > drm.debug-on-dyndbg has a regression, due to a chicken-egg > initialization problem: > > 1- modprobe i915 >i915 needs drm.ko, which is loaded 1st > > 2- "modprobe drm drm.debug=0x1ff" (virtual/implied) >drm.debug is set

Re: [PATCH v2] video/aperture: Call sysfb_disable() before removing PCI devices

2022-10-26 Thread Greg KH
On Wed, Oct 26, 2022 at 04:44:48PM +0200, Thomas Zimmermann wrote: > Call sysfb_disable() from aperture_remove_conflicting_pci_devices() > before removing PCI devices. Without, simpledrm can still bind to > simple-framebuffer devices after the hardware driver has taken over > the hardware. Both

Re: [PATCH] video/aperture: Call sysfb_disable() before removing PCI devices

2022-10-25 Thread Greg KH
On Tue, Oct 25, 2022 at 01:04:53PM +0200, Thomas Zimmermann wrote: > Call sysfb_disable() from aperture_remove_conflicting_pci_devices() > before removing PCI devices. Without, simpledrm can still bind to > simple-framebuffer devices after the hardware driver has taken over > the hardware. Both

Re: [Regression] CPU stalls and eventually causes a complete system freeze with 6.0.3 due to "video/aperture: Disable and unregister sysfb devices via aperture helpers"

2022-10-25 Thread Greg KH
On Tue, Oct 25, 2022 at 11:21:57AM +0200, Thomas Zimmermann wrote: > Hi > > Am 25.10.22 um 10:45 schrieb Andreas Thalhammer: > [...] > > > Yeah, it's also part of a larger changeset. But I wouldn't want to > > > backport all those changes either. > > > > > > Attached is a simple patch for

Re: [Regression] CPU stalls and eventually causes a complete system freeze with 6.0.3 due to "video/aperture: Disable and unregister sysfb devices via aperture helpers"

2022-10-24 Thread Greg KH
On Mon, Oct 24, 2022 at 12:41:43PM +0200, Thorsten Leemhuis wrote: > Hi! Thx for the reply. > > On 24.10.22 12:26, Thomas Zimmermann wrote: > > Am 23.10.22 um 10:04 schrieb Thorsten Leemhuis: > >> > >> I noticed a regression report in bugzilla.kernel.org. As many (most?) > >> kernel developer

Re: [PATCH v2] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-10-06 Thread Greg KH
On Fri, Oct 07, 2022 at 12:58:45AM +0800, Zheng Wang wrote: > If intel_gvt_dma_map_guest_page failed, it will call > ppgtt_invalidate_spt, which will finally free the spt. > But the caller does not notice that, it will free spt again in error path. > > Fix this by spliting invalidate and free in

Re: [PATCH] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-10-02 Thread Greg KH
On Wed, Sep 28, 2022 at 11:33:40AM +0800, Zheng Wang wrote: > If intel_gvt_dma_map_guest_page failed, it will call > ppgtt_invalidate_spt, which will finally free the spt. > But the caller does not notice that, it will free spt again in error path. > > Fix this by only freeing spt in

Re: [PATCH v7 0/9] dyndbg: drm.debug adaptation

2022-09-24 Thread Greg KH
On Sun, Sep 11, 2022 at 11:28:43PM -0600, Jim Cromie wrote: > hi Greg, Dan, Jason, DRM-folk, > > heres follow-up to V6: > rebased on driver-core/driver-core-next for -v6 applied bits (thanks) > rework drm_debug_enabled{_raw,_instrumented,} per Dan. > > It excludes: > nouveau parts

Re: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

2022-09-17 Thread Greg KH
On Fri, Sep 16, 2022 at 11:54:42PM +0800, Zheng Hacker wrote: > >From afe79848cb74cc8e45ab426d13fa2394c87e0422 Mon Sep 17 00:00:00 2001 > From: xmzyshypnc <1002992...@qq.com> > Date: Fri, 16 Sep 2022 23:48:23 +0800 > Subject: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry > >

Re: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

2022-09-16 Thread Greg KH
On Fri, Sep 16, 2022 at 02:39:21PM +0800, Zheng Hacker wrote: > >From 8d95c1399e3ff345500a575e21254a73b0c89144 Mon Sep 17 00:00:00 2001 > From: xmzyshypnc <1002992...@qq.com> > Date: Fri, 16 Sep 2022 14:37:48 +0800 > Subject: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry > >

Re: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

2022-09-08 Thread Greg KH
On Thu, Sep 08, 2022 at 05:09:40PM +0800, Zheng Hacker wrote: > Hi Zhenyu, > > This issue has been open for a few days. Could you plz write a patch > for that :) I'm not familiar with the logical code here. As this is only able to be hit in a theoretical system, it isn't that high of a priority,

Re: [PATCH v6 00/57] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-09-07 Thread Greg KH
On Sun, Sep 04, 2022 at 03:40:37PM -0600, Jim Cromie wrote: > hi Greg, Jason, DRM-folk, Steven, > > If Im not too late for linux-next in this cycle, heres V6. Diffs are minor: > > - rebased onto e47eb90a0a9a (tag: next-20220901, linux-next/master) >gets past Kconfig conflict, same for

Re: [PATCH v6 21/57] dyndbg: test DECLARE_DYNDBG_CLASSMAP, sysfs nodes

2022-09-07 Thread Greg KH
On Wed, Sep 07, 2022 at 04:54:00PM +0200, Greg KH wrote: > On Sun, Sep 04, 2022 at 03:40:58PM -0600, Jim Cromie wrote: > > Demonstrate use of DECLARE_DYNDBG_CLASSMAP macro, and expose them as > > sysfs-nodes for testing. > > Wait, why sysfs? > > sysfs isn't for t

Re: [PATCH v6 21/57] dyndbg: test DECLARE_DYNDBG_CLASSMAP, sysfs nodes

2022-09-07 Thread Greg KH
On Sun, Sep 04, 2022 at 03:40:58PM -0600, Jim Cromie wrote: > Demonstrate use of DECLARE_DYNDBG_CLASSMAP macro, and expose them as > sysfs-nodes for testing. Wait, why sysfs? sysfs isn't for testing, why not use debugfs? > > For each of the 4 class-map-types: > > - declare a class-map of

Re: [PATCH v4 00/41] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-09-06 Thread Greg KH
On Tue, Sep 06, 2022 at 09:18:09PM +0200, Daniel Vetter wrote: > On Fri, Aug 12, 2022 at 08:03:47AM +0200, Greg KH wrote: > > On Thu, Aug 11, 2022 at 06:52:40PM +0200, Daniel Vetter wrote: > > > On Wed, Aug 03, 2022 at 04:13:05PM -0400, Jason Baron wrote: > > > > &g

Re: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

2022-09-05 Thread Greg KH
On Mon, Sep 05, 2022 at 03:46:09PM +0800, Zheng Hacker wrote: > I rewrote the letter. Hope it works. > > There is a double-free security bug in split_2MB_gtt_entry. > > Here is a calling chain : > ppgtt_populate_spt->ppgtt_populate_shadow_entry->split_2MB_gtt_entry. > If

Re: [PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in vcn_v4_0_stop

2022-08-15 Thread Greg KH
On Mon, Aug 15, 2022 at 09:11:18PM +0600, Khalid Masum wrote: > On 8/15/22 20:15, Dong, Ruijing wrote: > > [AMD Official Use Only - General] > > > > Sorry, which "r" value was overwritten? I didn't see the point of making > > this change. > > > > Thanks > > Ruijing > > > > -Original

  1   2   3   4   5   6   7   8   >