Daniel Vetter writes:
Hello Sima,
Thanks for your feedback.
> On Tue, Jan 09, 2024 at 01:05:59PM +0100, Javier Martinez Canillas wrote:
>> The device is initialized in the driver's probe callback and as part of
>> that initialization, the required firmware is loaded.
: f99f5f3ea7ef ("drm/imagination: Add GPU ID parsing and firmware loading")
Suggested-by: Maxime Ripard
Signed-off-by: Javier Martinez Canillas
---
drivers/gpu/drm/imagination/pvr_device.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i
Andrew Davis writes:
> Add SGX GPU device entry to base DRA7x dtsi file.
>
> Signed-off-by: Andrew Davis
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Andrew Davis writes:
> Add SGX GPU device entry to base AM437x dtsi file.
>
> Signed-off-by: Andrew Davis
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Andrew Davis writes:
> Add SGX GPU device entry to base AM33xx dtsi file.
>
> Signed-off-by: Andrew Davis
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Andrew Davis writes:
> Add SGX GPU device entry to base OMAP5 dtsi file.
>
> Signed-off-by: Andrew Davis
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Andrew Davis writes:
> Add SGX GPU device entry to base OMAP4 dtsi file.
>
> Signed-off-by: Andrew Davis
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Andrew Davis writes:
> Add SGX GPU device entries to base OMAP3 dtsi files.
>
> Signed-off-by: Andrew Davis
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Maxime?
After a adding a commit message and Suggested-by tag:
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ONSOLE.
>
> Signed-off-by: Lukas Bulwahn
> ---
Makes sense to me.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
y: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ned-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
nd uses the range for removing the firmware framebuffer. For
> GEN2 VMBUS devices no range can be detected, so the driver clears all
> firmware framebuffers.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
homas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Javier Martinez Canillas writes:
> The helper is generic, it doesn't use the opaque EDID type struct drm_edid
> and is also used by drivers that only support non-probeable displays such
> as fixed panels.
>
> These drivers add a list of modes using drm_mode_probed_add
, there are no functional changes. But besides being a more logical
place for this helper, it could also allow to eventually make drm_edid.o
optional and not included in drm.o if only fixed panels must be supported
in a given system.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Jani Nikula
---
Changes in v2
Jani Nikula writes:
Hello Jani,
> On Tue, 02 Jan 2024, Javier Martinez Canillas wrote:
>> The helper is generic and doesn't use the opaque EDID type struct drm_edid
>> and is also used by drivers that only support non-probeable displays, such
>> as fixed panels.
>>
, there are no functional changes. But besides being a more logical
place for this helper, it could also allow to eventually make drm_edid.o
optional and not included in drm.o if only fixed panels must be supported
in a given system.
Signed-off-by: Javier Martinez Canillas
---
drivers/gpu/drm/drm_edid.c | 23
ort for CursorMob and CursorBypass
> 4")
> Reported-by: Stefan Hoffmeister
> Closes: https://gitlab.freedesktop.org/drm/misc/-/issues/34
> Cc: Martin Krastev
> Cc: Maaz Mombasawala
> Cc: Ian Forbes
> Cc: Broadcom internal kernel review list
>
> Cc: dri-devel@lists.freedesktop.org
> Cc: # v5.19+
> ---
I'm not familiar with this driver but your explanation in the commit
message is very clear and from inspecting the code, the change looks
correct to me.
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Javier Martinez Canillas writes:
> Hello,
>
> This patch-set adds support for the family of SSD133x Solomon controllers,
> such as the SSD1331. These are used for RGB Dot Matrix OLED/PLED panels.
>
> This is a v5 that is basically the same than the previous v4 but dropping
Add a Device Tree binding schema for the OLED panels based on the
Solomon SSD133x family of controllers.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Rob Herring
---
Changes in v5:
- Drop I2C example in DT binding schema due that bus not being supported.
Changes in v3:
- Move solomon
nges in v2:
- Unconditionally set the width and height constraints (Conor Dooley).
- Fix indentation in the DTS examples (Krzysztof Kozlowski).
Javier Martinez Canillas (4):
dt-bindings: display: ssd1307fb: Add vendor prefix to width and height
dt-bindings: display: ssd132x: Add vendor prefi
.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Jocelyn Falempe
---
Changes in v5:
- Drop "solomon,ssd1331" entry from ssd130x-i2c due I2C bus not being supported.
Changes in v4:
- Fix typo in commit message (Jocelyn Falempe).
drivers/gpu/drm/solomon/ssd130x-spi.c | 7 +
drive
he width and height properties.
Fixes: 591825fba8a2 ("dt-bindings: display: ssd1307fb: Remove default width and
height values")
Reported-by: Conor Dooley
Closes:
https://lore.kernel.org/dri-devel/20231218-example-envision-b41ca8efa251@spud/
Signed-off-by: Javier Martinez Canillas
Acked-by
ies.
Fixes: 2d23e7d6bacb ("dt-bindings: display: Add SSD132x OLED controllers")
Reported-by: Conor Dooley
Closes:
https://lore.kernel.org/dri-devel/20231218-example-envision-b41ca8efa251@spud/
Signed-off-by: Javier Martinez Canillas
Acked-by: Rob Herring
---
(no changes since v1)
Add a Device Tree binding schema for the OLED panels based on the
Solomon SSD133x family of controllers.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Rob Herring
---
(no changes since v3)
Changes in v3:
- Move solomon,ssd-common.yaml ref before the properties section and
width
ies.
Fixes: 2d23e7d6bacb ("dt-bindings: display: Add SSD132x OLED controllers")
Reported-by: Conor Dooley
Closes:
https://lore.kernel.org/dri-devel/20231218-example-envision-b41ca8efa251@spud/
Signed-off-by: Javier Martinez Canillas
Acked-by: Rob Herring
---
(no changes since v1)
.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Jocelyn Falempe
---
Changes in v4:
- Fix typo in commit message (Jocelyn Falempe).
drivers/gpu/drm/solomon/ssd130x-i2c.c | 5 +
drivers/gpu/drm/solomon/ssd130x-spi.c | 7 +
drivers/gpu/drm/solomon/ssd130x.c | 370
the properties section and
width/height constraints after the other properties (Conor Dooley).
Changes in v2:
- Unconditionally set the width and height constraints (Conor Dooley).
- Fix indentation in the DTS examples (Krzysztof Kozlowski).
Javier Martinez Canillas (4):
dt-bindings: display
he width and height properties.
Fixes: 591825fba8a2 ("dt-bindings: display: ssd1307fb: Remove default width and
height values")
Reported-by: Conor Dooley
Closes:
https://lore.kernel.org/dri-devel/20231218-example-envision-b41ca8efa251@spud/
Signed-off-by: Javier Martinez Canillas
Acked-by
Jocelyn Falempe writes:
Hello Jocelyn,
Thanks a lot for your review!
> On 19/12/2023 21:34, Javier Martinez Canillas wrote:
>> The Solomon SSD133x controllers (such as the SSD1331) are used by RGB dot
>> matrix OLED panels, add a modesetting pipeline to support
Ville Syrjala writes:
> From: Ville Syrjälä
>
> Sprinkle some extra WARNs around so that we might catch
> premature framebuffer destruction more readily.
>
> Signed-off-by: Ville Syrjälä
> ---
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canill
ramebuffer list. Fortunately I was able to convince it to oops
> instead, and from there it was easier to track down the culprit.
>
> Cc: sta...@vger.kernel.org
> Signed-off-by: Ville Syrjälä
> ---
Acked-by: Javier Martinez Canillas
> drivers/gpu/drm/drm_plane.c | 1 +
> 1 fil
-off-by: Javier Martinez Canillas
---
(no changes since v1)
drivers/gpu/drm/solomon/ssd130x-i2c.c | 5 +
drivers/gpu/drm/solomon/ssd130x-spi.c | 7 +
drivers/gpu/drm/solomon/ssd130x.c | 370 ++
drivers/gpu/drm/solomon/ssd130x.h | 5 +-
4 files changed, 386
Add a Device Tree binding schema for the OLED panels based on the
Solomon SSD133x family of controllers.
Signed-off-by: Javier Martinez Canillas
---
Changes in v3:
- Move solomon,ssd-common.yaml ref before the properties section and
width/height constraints after the other properties (Conor
ies.
Fixes: 2d23e7d6bacb ("dt-bindings: display: Add SSD132x OLED controllers")
Reported-by: Conor Dooley
Closes:
https://lore.kernel.org/dri-devel/20231218-example-envision-b41ca8efa251@spud/
Signed-off-by: Javier Martinez Canillas
---
(no changes since v1)
.../devicetree/bi
he width and height properties.
Fixes: 591825fba8a2 ("dt-bindings: display: ssd1307fb: Remove default width and
height values")
Reported-by: Conor Dooley
Closes:
https://lore.kernel.org/dri-devel/20231218-example-envision-b41ca8efa251@spud/
Signed-off-by: Javier Martinez Canillas
---
(no
(Conor Dooley).
Changes in v2:
- Unconditionally set the width and height constraints (Conor Dooley).
- Fix indentation in the DTS examples (Krzysztof Kozlowski).
Javier Martinez Canillas (4):
dt-bindings: display: ssd1307fb: Add vendor prefix to width and height
dt-bindings: display: ssd132x
Krzysztof Kozlowski writes:
Hello Krzysztof,
> On 19/12/2023 12:20, Javier Martinez Canillas wrote:
[...]
>>>> +allOf:
>>>> + - $ref: solomon,ssd-common.yaml#
>>>> +
[...]
>>>
>>> + width:
>>> +default: 96
>>&
Conor Dooley writes:
Hello Conor,
> On Mon, Dec 18, 2023 at 02:20:35PM +0100, Javier Martinez Canillas wrote:
[...]
>> +allOf:
>> + - $ref: solomon,ssd-common.yaml#
>> +
>> + - properties:
>> + width:
>> +default: 96
>> + h
Conor Dooley writes:
Hello Connor,
> On Sun, Dec 17, 2023 at 11:00:07PM +0100, Javier Martinez Canillas wrote:
>> Conor Dooley writes:
>>
>> Hello Conor,
>>
>> > On Sun, Dec 17, 2023 at 10:33:24PM +
Krzysztof Kozlowski writes:
Hello Krzysztof,
> On 17/12/2023 11:07, Javier Martinez Canillas wrote:
>>> + - if:
>> + properties:
>> +compatible:
>> + contains:
>> +const: solomon,ssd1331
>> +the
-off-by: Javier Martinez Canillas
---
drivers/gpu/drm/solomon/ssd130x-i2c.c | 5 +
drivers/gpu/drm/solomon/ssd130x-spi.c | 7 +
drivers/gpu/drm/solomon/ssd130x.c | 370 ++
drivers/gpu/drm/solomon/ssd130x.h | 5 +-
4 files changed, 386 insertions(+), 1
binding schema for the SSD133x controllers and patch #2
extends the ssd130x DRM driver to support the SSD133x controller family.
Best regards,
Javier
Javier Martinez Canillas (2):
dt-bindings: display: Add SSD133x OLED controllers
drm/ssd130x: Add support for the SSD133x OLED controller family
Add a Device Tree binding schema for the OLED panels based on the
Solomon SSD133x family of controllers.
Signed-off-by: Javier Martinez Canillas
---
.../bindings/display/solomon,ssd133x.yaml | 63 +++
1 file changed, 63 insertions(+)
create mode 100644
Documentation
Conor Dooley writes:
Hello Conor,
> On Sun, Dec 17, 2023 at 10:33:24PM +0100, Javier Martinez Canillas wrote:
[...]
>> >> +then:
>> >> + properties:
>> >> +width:
>> >> + default: 96
>> >> +height
Add a Device Tree binding schema for the OLED panels based on the
Solomon SSD133x family of controllers.
Signed-off-by: Javier Martinez Canillas
---
Changes in v2:
- Unconditionally set the width and height constraints (Conor Dooley).
- Fix indentation in the DTS examples (Krzysztof Kozlowski
-off-by: Javier Martinez Canillas
---
(no changes since v1)
drivers/gpu/drm/solomon/ssd130x-i2c.c | 5 +
drivers/gpu/drm/solomon/ssd130x-spi.c | 7 +
drivers/gpu/drm/solomon/ssd130x.c | 370 ++
drivers/gpu/drm/solomon/ssd130x.h | 5 +-
4 files changed, 386
:
- Unconditionally set the width and height constraints (Conor Dooley).
- Fix indentation in the DTS examples (Krzysztof Kozlowski).
Javier Martinez Canillas (2):
dt-bindings: display: Add SSD133x OLED controllers
drm/ssd130x: Add support for the SSD133x OLED controller family
.../bindings/display
Conor Dooley writes:
Hello Conor,
Thanks a lot for your feedback.
> On Mon, Dec 18, 2023 at 02:20:35PM +0100, Javier Martinez Canillas wrote:
[...]
>> +
>> + - properties:
>> + width:
>> +default: 96
>> + height:
>> +def
Conor Dooley writes:
Hello Connor,
> On Sun, Dec 17, 2023 at 11:07:03AM +0100, Javier Martinez Canillas wrote:
[...]
>> +properties:
>> + compatible:
>> +enum:
>> + - solomon,ssd1331
>> +
>> +required:
>> + - compatible
>>
ge managers"
> default n
> - depends on DRM=y
> + depends on DRM
> depends on STACKTRACE_SUPPORT
> select STACKDEPOT
> help
> --
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
r-domains: %d\n", err);
> + dev_err(dev, "failed to parse power-domains: %d\n", err);
> return err;
> }
>
Makes sense to me.
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Huacai Chen writes:
> Hi, Javier,
>
> On Mon, Dec 11, 2023 at 4:33 PM Javier Martinez Canillas
> wrote:
>>
>> Huacai Chen writes:
>>
>> Hello Huacai,
>>
>> > Hi, Javier,
>> >
>> > On Wed, Nov 8, 2023 at 4:24 PM Javier Martin
Huacai Chen writes:
Hello Huacai,
> Hi, Javier,
>
> On Wed, Nov 8, 2023 at 4:24 PM Javier Martinez Canillas
> wrote:
>>
>> Hello,
>>
>> On Wed, Nov 8, 2023 at 9:14 AM Thomas Zimmermann wrote:
>> >
>> > Hi,
>> >
>>
>> [
Rob Herring writes:
> On Mon, Dec 04, 2023 at 05:05:30PM +0100, Javier Martinez Canillas wrote:
>> Rob Herring writes:
>>
>> > On Mon, Dec 4, 2023 at 3:39 AM Javier Martinez Canillas
>> > wrote:
>> >> Rob Herring writes:
>> >>
Rob Herring writes:
> On Mon, Dec 4, 2023 at 3:39 AM Javier Martinez Canillas
> wrote:
>> Rob Herring writes:
>> > On Fri, Dec 1, 2023 at 4:21 AM Javier Martinez Canillas
[...]
>>
>> > However, there might be one other issue with that and this fix. The
d fbdev devices to fbcon's VT
(/sys/class/vtconsole/vtcon1/bind) and also kernel command line parameter
to choose which fbdev driver is mapped to which VT console (fbcon=map:n).
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
d-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Rob Herring writes:
Hello Rob,
> On Fri, Dec 1, 2023 at 4:21 AM Javier Martinez Canillas
[...]
>> >> I don't have a better idea than this patch but maybe Thomas or Sima do?
>> >
>> > At SUSE, we've carried such a patch in our repos for some time. It works
&
ve is no longer needed.
>
> Signed-off-by: Jean Delvare
> Cc: David Airlie
> Cc: Daniel Vetter
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Thomas Zimmermann writes:
> Hi
>
> Am 18.11.23 um 12:10 schrieb Javier Martinez Canillas:
>> Ard Biesheuvel writes:
>>
>> Hello Ard,
>>
>>> On Fri, 17 Nov 2023 at 00:09, Rob Herring wrote:
>>
>> [...]
>>
>>>>>>
Thomas Zimmermann writes:
> Hi Javier
>
> Am 01.12.23 um 09:54 schrieb Javier Martinez Canillas:
>> Thomas Zimmermann writes:
>>
>>> Use the screen_info instance from the device instead of dereferencing
>>> the global screen_info state. Decouples th
Thomas Zimmermann
> ---
Same comments that in patch #2. But regardless:
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
if (!si)
> + return -ENOMEM;
> +
Why a copy? In any case maybe the global screen_info should be duplicated
when is set as the device platform data in sysfb_init() ?
I agree with the direction of the patch though, so whatever you decide:
Reviewed-by: Javier Martinez Canillas
Thomas Zimmermann writes:
> Get the global screen_info's address once and access the data via
> this pointer. Limits the use of global state.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
t; @@ -17,7 +17,6 @@
> #include
> #include
> #include
> -#include
>
> #include
>
> --
> 2.43.0
>
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
r kernel configs.
It's a fair point though that probably the only option is to enable it
unconditionally.
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
using W=1 or
> CONFIG_DRM_EXTRA_CHECKS introducing warnings, and people using them
> fixing the warnings...
>
> I really do think making it unconditional is the only way.
>
Fair enough.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
l Makefiles, depending on the
>> case.
>
> I'm all for it, but yeah, we need some easy way to opt-in/opt-out. Some
> drivers are pretty much unmaintained now and are likely to never fix
> those warnings.
>
Maybe add a Kconfig symbol for it instead of making unconditional?
Some
Geert Uytterhoeven writes:
Hello Geert,
> Hi Maxime,
>
> On Wed, Nov 29, 2023 at 9:35 AM Maxime Ripard wrote:
>> On Tue, Nov 28, 2023 at 08:16:18PM +0100, Geert Uytterhoeven wrote:
>> > On Tue, Nov 28, 2023 at 8:03 PM Javier Martinez Canillas
>> > wrote:
Maxime Ripard writes:
Hello Maxime,
> Hi,
>
> On Tue, Nov 28, 2023 at 08:16:18PM +0100, Geert Uytterhoeven wrote:
>> On Tue, Nov 28, 2023 at 8:03 PM Javier Martinez Canillas
>> wrote:
>> > Geert Uytterhoeven writes:
>> > > The Imagination Technolog
Geert Uytterhoeven writes:
> Hi Javier,
>
> On Tue, Nov 28, 2023 at 8:03 PM Javier Martinez Canillas
> wrote:
>> Geert Uytterhoeven writes:
>> > The Imagination Technologies PowerVR Series 6 GPU is currently only
>> > supported on Texas Instruments K3
depends on ARM || ARM64 and others such as
DRM_ETNAVIV don't even have an SoC or architecture dependency.
In any case, I agree with you that restricting to only K3 makes sense.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
connector_test.c | 38 ++
> 1 file changed, 38 insertions(+)
>
The test looks good to me but I would like Maxime to review before is merged.
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Javier Martinez Canillas writes:
> Hello,
>
> This series is to fix an issue that surfaced after damage clipping was
> enabled for the virtio-gpu by commit 01f05940a9a7 ("drm/virtio: Enable
> fb damage clips property for the primary plane").
>
> After th
tspot properties from cursor planes
> drm/virtio: Use the hotspot properties from cursor planes
> drm: Remove legacy cursor hotspot code
> drm: Introduce DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT
>
Pushed to drm-misc (drm-misc-next). Thanks!
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Simon Ser writes:
Hello Simon,
> On Wednesday, November 22nd, 2023 at 13:49, Javier Martinez Canillas
> wrote:
>
>> Any objections to merge the series ?
>
> No objections from me :)
>
Perfect, I'll merge this series then to unblock the mutter MR. Thanks again!
-
age or any other damage
accumulation algorithm for buffer damage handling.
Suggested-by: Simon Ser
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Simon Ser
Reviewed-by: Thomas Zimmermann
Reviewed-by: Zack Rusin
Acked-by: Sima Vetter
---
Changes in v4:
- Reference
t;drm/virtio: Enable fb damage clips property for the
primary plane")
Cc: # v6.4+
Reported-by: nerdopolis
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218115
Suggested-by: Thomas Zimmermann
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Thomas Zimmermann
Reviewed-by: Zack Ru
mage clips
should be ignored.
Also add references to further documentation about the two damage types.
Suggested-by: Simon Ser
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Simon Ser
Reviewed-by: Thomas Zimmermann
Reviewed-by: Zack Rusin
Acked-by: Sima Vetter
---
Changes in v4:
- A
The driver does per-buffer uploads and needs to force a full plane update
if the plane's attached framebuffer has change since the last page-flip.
Suggested-by: Sima Vetter
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Thomas Zimmermann
Reviewed-by: Zack Rusin
Acked-by: Sima Vetter
ses: https://bugzilla.kernel.org/show_bug.cgi?id=218115
Suggested-by: Sima Vetter
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Thomas Zimmermann
Reviewed-by: Zack Rusin
Acked-by: Sima Vetter
---
(no changes since v2)
Changes in v2:
- Set struct drm_plane_state .ignore_damage_clips in virtio-g
ge_clips in virtio-gpu plane's
.atomic_check instead of using a different helpers (Thomas Zimmermann).
- Set struct drm_plane_state .ignore_damage_clips in vmwgfx plane's
.atomic_check instead of using a different helpers (Thomas Zimmermann).
Javier Martinez Canillas (5):
drm: Allow drivers
ct link:
> https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3337
The mutter chages are already in good shape and the MR has even be
approved by a mutter developer. Any objections to merge the series ?
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Conor Dooley writes:
Hello Connor,
> On Thu, Nov 16, 2023 at 07:07:37PM +0100, Javier Martinez Canillas wrote:
>> This is used to specify the page start address offset of the display RAM.
>>
>> The value is used as offset when setting the page start address with the
>
mage clips
should be ignored.
Also add references to further documentation about the two damage types.
Suggested-by: Simon Ser
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Simon Ser
Reviewed-by: Thomas Zimmermann
---
Changes in v3:
- Fix typo in the kernel-doc (Simon Ser).
- Add a
age or any other damage
accumulation algorithm for buffer damage handling.
Suggested-by: Simon Ser
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Simon Ser
Reviewed-by: Thomas Zimmermann
---
(no changes since v1)
Documentation/gpu/todo.rst | 20
1 file changed, 20
The driver does per-buffer uploads and needs to force a full plane update
if the plane's attached framebuffer has change since the last page-flip.
Suggested-by: Sima Vetter
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Thomas Zimmermann
---
(no changes since v2)
Changes in v2:
- Set
ses: https://bugzilla.kernel.org/show_bug.cgi?id=218115
Suggested-by: Sima Vetter
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Thomas Zimmermann
---
(no changes since v2)
Changes in v2:
- Set struct drm_plane_state .ignore_damage_clips in virtio-gpu plane's
.atomic_check instead of using a
t;drm/virtio: Enable fb damage clips property for the
primary plane")
Cc: # v6.4+
Reported-by: nerdopolis
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218115
Suggested-by: Thomas Zimmermann
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Thomas Zimmermann
---
(no change
in vmwgfx plane's
.atomic_check instead of using a different helpers (Thomas Zimmermann).
Javier Martinez Canillas (5):
drm: Allow drivers to indicate the damage helpers to ignore damage
clips
drm/virtio: Disable damage clipping if FB changed since last page-flip
drm/vmwgfx: Disable damag
empt to use the same frame
buffer provided by the firmware but getting it from different places.
I don't have a better idea than this patch but maybe Thomas or Sima do?
[0]: https://elixir.bootlin.com/linux/latest/source/drivers/video/aperture.c
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Andy Shevchenko writes:
Hello Andy,
> On Thu, Nov 16, 2023 at 07:07:38PM +0100, Javier Martinez Canillas wrote:
>> This is used to specify the page start address offset of the display RAM.
>>
>> The value is used as offset when setting the page start address with the
>
Maxime Ripard writes:
Hello Maxime,
> On Thu, Nov 16, 2023 at 07:07:39PM +0100, Javier Martinez Canillas wrote:
>> This is used to specify the page start address offset of the display RAM.
>>
>> The value is used as offset when setting the page start address with the
>
a MODALIAS of the form "spi:1.8-128160EF" even if the device has been
registered by OF.
So this is an actual fix since this driver can be built as a module.
> Signed-off-by: Mostafa Weshahy
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
.
Reported-by: Sahaj Sarup
Signed-off-by: Javier Martinez Canillas
---
drivers/video/fbdev/ssd1307fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index 5ae48e36fccb..34f014bf4994 100644
--- a/drivers/video/fbdev
.
Reported-by: Sahaj Sarup
Signed-off-by: Javier Martinez Canillas
---
drivers/gpu/drm/solomon/ssd130x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/solomon/ssd130x.c
b/drivers/gpu/drm/solomon/ssd130x.c
index bef293922b98..8944129a8e0b 100644
.
Reported-by: Sahaj Sarup
Signed-off-by: Javier Martinez Canillas
---
.../devicetree/bindings/display/solomon,ssd1307fb.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
b/Documentation/devicetree/bindings
Rob Herring writes:
> On Thu, Nov 16, 2023 at 3:36 AM Javier Martinez Canillas
> wrote:
[...]
>> >
>> > This is the opposite of what we do for memory and memory reservations.
>> > EFI is the source of truth for those.
>> >
>> > This co
101 - 200 of 2249 matches
Mail list logo
