There is a macro for this already in the header, use
that instead and delete the custom DSI write macro defined in the driver.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Sam Ravnborg
---
Changes in v2:
- Add Sam Ravnborg's Reviewed-by tag.
- Fix identation on macro usage (Sam
There is a macro for this already in the header, use
that instead and delete the custom DSI write macro defined in the driver.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Sam Ravnborg
---
Changes in v2:
- Add Sam Ravnborg's Reviewed-by tag.
- Fix identation on macro usage (Sam
There are macros for these already in the header, use
that instead and delete the custom DSI write macros defined in the driver.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Sam Ravnborg
---
Changes in v2:
- Add Sam Ravnborg's Reviewed-by tag.
- Fix identation on macro usage (Sam
are quite trivial but I've only tested this with allmodconfig
and `make M=drivers/gpu/drm/panel/` so please review and testing would be
highly appreciated.
Best regards,
Javier
Changes in v2:
- Fix identations and a usage discrepancy in one driver (Sam Ravnborg).
Javier Martinez Canillas (13
On 1/2/23 21:25, Javier Martinez Canillas wrote:
> Many panel drivers define dsi_dcs_write_seq() and dsi_generic_write_seq()
> macros to send DCS commands and generic write packets respectively, with
> the payload specified as a list of parameters instead of using arrays.
>
>
On 1/2/23 21:30, Sam Ravnborg wrote:
> On Mon, Jan 02, 2023 at 09:25:41PM +0100, Javier Martinez Canillas wrote:
>> Change made using a `clang-format -i include/drm/drm_mipi_dsi.h` command.
>>
>> Suggested-by: Sam Ravnborg
>> Signed-off-by: Javier Martinez Canillas
Martinez Canillas
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Sam Ravnborg
Tested-by: Tom Fitzhenry
Tested-by: Peter Robinson
---
Changes in v5:
- Add Peter Robinson's Tested-by tag.
Changes in v4:
- Add Tom Fitzhenry's Tested-by tag.
Changes in v3:
- Add Sam Ravnborg's reviwed-by tag
Add myself as maintainer for the driver and devicetree bindings schema.
Signed-off-by: Javier Martinez Canillas
Acked-by: Sam Ravnborg
---
Changes in v5:
- List Ondrej Jirman as a maintainer in the driver's MAINTAINERS entry.
Changes in v4:
- Add Sam Ravnborg's Acked-by tag.
MAINTAINERS | 8
Add device tree bindings for panels based on the Himax HX8394 controller,
such as the HannStar HSD060BHW4 720x1440 TFT LCD panel that is connected
through a MIPI-DSI video interface.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
---
Changes in v5:
- List Ondrej
d year to driver's copyright notice (Sam Ravnborg)
- Remove unused header include (Sam Ravnborg).
- Use mipi_dsi_dcs_write_seq() helper and drop custom macro (Sam Ravnborg).
- Drop unnecessary info messages and move useful one to debug (Sam Ravnborg).
Javier Martinez Canillas (2):
dt-bindings: di
("drm/mipi-dsi: Introduce mipi_dsi_dcs_write_seq macro") so drivers can be
changed to use that. But there isn't one yet for the latter, let's add it.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Sam Ravnborg
---
Changes in v2:
- Fix kernel-doc macro name (kernel test robot, Sa
Change made using a `clang-format -i include/drm/drm_mipi_dsi.h` command.
Suggested-by: Sam Ravnborg
Signed-off-by: Javier Martinez Canillas
---
Changes in v2:
- New patch in v2.
include/drm/drm_mipi_dsi.h | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff
On 1/2/23 20:00, Sam Ravnborg wrote:
> Hi Javier.
>
> On Wed, Dec 28, 2022 at 02:47:43AM +0100, Javier Martinez Canillas wrote:
>> Hello,
>>
>> This series contains cleanups for DRM panel drivers that define their own
>> DSI write macros instead of using what
, 0xf1, 0x12, 0x83);
>> -dsi_generic_write_seq(dsi, XPP055C272_CMD_SETMIPI,
>> +mipi_dsi_generic_write_seq(dsi, XPP055C272_CMD_SETEXTC, 0xf1, 0x12,
>> 0x83);
> This is wrong - here you should use mipi_dsi_dcs_write_seq()
> Likewise for the rest of the file.
>
Agreed.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Hello Sam,
Thanks a lot for your feedback.
On 1/2/23 19:39, Sam Ravnborg wrote:
> Hi Javier.
>
> On Wed, Dec 28, 2022 at 02:47:44AM +0100, Javier Martinez Canillas wrote:
>> Many panel drivers define dsi_dcs_write_seq() and dsi_generic_write_seq()
>> macros to send DCS
On 1/2/23 16:20, Ondřej Jirman wrote:
> On Mon, Jan 02, 2023 at 02:51:42PM +0100, Javier Martinez Canillas wrote:
>> Hello Ondřej,
>>
>> [...]
>>
>> My goal was to have some initial support in mainline even if there could be
>> some
>> issues. I
ttempt to support
the
PPP incrementally.
But since you are aware of the issues and know what are the available fixes,
I'll
let you continue with the effort and take care of the patches. Hopefully there
may
be things that will be helpful, such as the binding schema patch and the
collected
tags. I can also take care of pushing the DRM bits to the drm-misc-next tree
once
you feel that those are ready to get merged.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
field as it's in your tree.
[...]
>> https://github.com/megous/linux/commit/f19ce7bb7d72
>
> Yes, and test the driver more thoroughly:
>
> - look at clk_summary to verify clock rate the kernel thinks it's using
> - test refresh rate, somehow, to again verify the actual clock rate (kernel
> can
> lie in debugfs)
> - test power cycling the panel (eg. via system suspend/resume or other means)
>
Agreed that the more testing the better.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
l.
> Best regards,
> Pavel
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ypassed, I did not
> design
> the panel mode to be used with CPLL's 800 MHz, but with GPLL frequecy of 594
> MHz.
>
> GPLL 594/74.25 = 8 (integral divider without the need for fractional clock)
> CPLL 800/74.25 = ~10.77441077441077441077
>
> If you really want to use fractional clock, you'd need to parent it to VPLL
> and set VPLL really high, like close to 2GHz.
>
Thanks for the explanation. Then I just need to squash on top of this, the
following patch. Is that correct?
https://github.com/megous/linux/commit/f19ce7bb7d72
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
On 12/30/22 16:43, Ondřej Jirman wrote:
[...]
>>
>> +DRM DRIVER FOR HIMAX HX8394 MIPI-DSI LCD panels
>> +M: Javier Martinez Canillas
>
> +M: Ondrej Jirman
>
Great! I assume that you also are OK with listing you in the DT
binding doc. I'll include you in bo
Hello Ondřej,
Thanks a lot for your comments.
On 12/30/22 16:40, Ondřej Jirman wrote:
> Hi Javier,
>
> On Fri, Dec 30, 2022 at 12:31:52PM +0100, Javier Martinez Canillas wrote:
>> From: Kamil Trzciński
>>
>> The driver is for panels based on the Himax HX8394 controll
Add myself as maintainer for the driver and devicetree bindings schema.
Signed-off-by: Javier Martinez Canillas
Acked-by: Sam Ravnborg
---
Changes in v4:
- Add Sam Ravnborg's Acked-by tag.
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
Martinez Canillas
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Sam Ravnborg
---
Changes in v4:
- Add Tom Fitzhenry's Tested-by tag.
Changes in v3:
- Add Sam Ravnborg's reviwed-by tag.
- Move driver patch after one introducing the DT binding (Sam Ravnborg).
Changes in v2:
- Add year
Martinez Canillas
Tested-by: Tom Fitzhenry
---
Changes in v4:
- Add Tom Fitzhenry's Tested-by tag.
- Keep the DTS nodes sorted alphabetically (Tom Fitzhenry).
Changes in v2:
- Fix regulator node names (Maya Matuszczyk).
- Drop non-existent "poweroff-in-suspend" property (Maya Matuszczyk)
Add device tree bindings for panels based on the Himax HX8394 controller,
such as the HannStar HSD060BHW4 720x1440 TFT LCD panel that is connected
through a MIPI-DSI video interface.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
---
Changes in v4:
- Add fallback
bug (Sam Ravnborg).
- Fix regulator node names (Maya Matuszczyk).
- Drop non-existent "poweroff-in-suspend" property (Maya Matuszczyk).
- Remove unnecessary comments in panel node (Maya Matuszczyk).
Javier Martinez Canillas (2):
dt-bindings: display: Add Himax HX8394 panel controll
the firmware-provided framebuffer removal is the
correct thing to do IMO.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ect.
> Cheers,
> -- Guido
>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Hello Tom,
On Thu, 29 Dec 2022 at 10:39 Tom Fitzhenry wrote:
> On 27/12/22 22:03, Javier Martinez Canillas wrote:
> > From: Ondrej Jirman
> >
> > The phone's display is using Hannstar LCD panel, and Goodix based
> > touchscreen. Support it.
> >
> &g
Hello Jagan,
On Thu, 29 Dec 2022 at 10:54 Jagan Teki wrote:
>
[…]
> > > compatible:
> > > items:
> > > - enum:
> > > - hannstar,hsd060bhw4
> > > - const: himax,hx8394
> > >
> > > himax,hx8394 is the actual controller and is denoted as fallback
> compatible.
> > >
> >
There is a macro for this already in the header, use
that instead and delete the custom DSI write macro defined in the driver.
Signed-off-by: Javier Martinez Canillas
---
.../panel/panel-sony-tulip-truly-nt35521.c| 348 +-
1 file changed, 170 insertions(+), 178 deletions
There are macros for these already in the header, use
that instead and delete the custom DSI write macros defined in the driver.
Signed-off-by: Javier Martinez Canillas
---
drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c | 50 +++-
1 file changed, 17 insertions(+), 33 deletions
There is a macro for this already in the header, use
that instead and delete the custom DSI write macro defined in the driver.
Signed-off-by: Javier Martinez Canillas
---
.../gpu/drm/panel/panel-xinpeng-xpp055c272.c | 44 ---
1 file changed, 18 insertions(+), 26 deletions
There is a macro for this already in the header, use
that instead and delete the custom DSI write macro defined in the driver.
Signed-off-by: Javier Martinez Canillas
---
.../gpu/drm/panel/panel-sharp-ls060t1sx01.c | 19 ++-
1 file changed, 2 insertions(+), 17 deletions
There is a macro for this already in the header, use
that instead and delete the custom DSI write macro defined in the driver.
Signed-off-by: Javier Martinez Canillas
---
.../panel/panel-samsung-s6e88a0-ams452ef01.c | 24 +++
1 file changed, 8 insertions(+), 16 deletions
There is a macro for this already in the header, use
that instead and delete the custom DSI write macro defined in the driver.
Signed-off-by: Javier Martinez Canillas
---
.../gpu/drm/panel/panel-mantix-mlaf057we51.c | 24 +++
1 file changed, 8 insertions(+), 16 deletions
There are macros for these already in the header, use
that instead and delete the custom DSI write macros defined in the driver.
Signed-off-by: Javier Martinez Canillas
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 83 ---
1 file changed, 33 insertions(+), 50 deletions
There is a macro for this already in the header, use
that instead and delete the custom DSI write macro defined in the driver.
Signed-off-by: Javier Martinez Canillas
---
drivers/gpu/drm/panel/panel-novatek-nt35950.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff
There is a macro for this already in the header, use
that instead and delete the custom DSI write macro defined in the driver.
Signed-off-by: Javier Martinez Canillas
---
drivers/gpu/drm/panel/panel-samsung-sofef00.c | 24 +++
1 file changed, 8 insertions(+), 16 deletions
There is a macro for this already in the header, use
that instead and delete the custom DSI write macro defined in the driver.
Signed-off-by: Javier Martinez Canillas
---
drivers/gpu/drm/panel/panel-elida-kd35t133.c | 34
1 file changed, 13 insertions(+), 21 deletions
("drm/mipi-dsi: Introduce mipi_dsi_dcs_write_seq macro") so drivers can be
changed to use that. But there isn't one yet for the latter, let's add it.
Signed-off-by: Javier Martinez Canillas
---
include/drm/drm_mipi_dsi.h | 16
1 file changed, 16 insertions(+)
diff --git
There is a macro for this already in the header, use
that instead and delete the custom DSI write macro defined in the driver.
Signed-off-by: Javier Martinez Canillas
---
.../drm/panel/panel-leadtek-ltk050h3146w.c| 64 ---
1 file changed, 28 insertions(+), 36 deletions
There is a macro for this already in the header, use
that instead and delete the custom DSI write macro defined in the driver.
Signed-off-by: Javier Martinez Canillas
---
.../gpu/drm/panel/panel-boe-bf060y8m-aj0.c| 28 +++
1 file changed, 10 insertions(+), 18 deletions
There are macros for these already in the header, use
that instead and delete the custom DSI write macros defined in the driver.
Signed-off-by: Javier Martinez Canillas
---
.../drm/panel/panel-asus-z00t-tm5p5-n35596.c | 96 ---
1 file changed, 40 insertions(+), 56 deletions
appreciated.
Best regards,
Javier
Javier Martinez Canillas (14):
drm/mipi-dsi: Add a mipi_dsi_dcs_write_seq() macro
drm/panel-asus-z00t-tm5p5-n35596: Drop custom DSI write macros
drm/panel-sitronix-st7703: Drop custom DSI write macros
drm/panel-leadtek-ltk050h3146w: Drop custom DSI write macro
On Tue, Dec 27, 2022 at 8:37 PM Jagan Teki wrote:
>
> On Wed, Dec 28, 2022 at 12:58 AM Javier Martinez Canillas
> wrote:
> >
> > Hello Jagan,
> >
> > On Tue, Dec 27, 2022 at 7:16 PM Jagan Teki
> > wrote:
> >
> > [...]
>
Hello Jagan,
On Tue, Dec 27, 2022 at 7:16 PM Jagan Teki wrote:
[...]
> > +allOf:
> > + - $ref: panel-common.yaml#
> > +
> > +properties:
> > + compatible:
> > +enum:
> > + # HannStar HSD060BHW4 5.99" 720x1440 TFT LCD panel
> > + - hannstar,hsd060bhw4
>
> Parent controller can
pu_pci_probe(struct pci_dev *pdev,
> }
> #endif
>
> - /* Get rid of things like offb */
> - ret = drm_aperture_remove_conflicting_pci_framebuffers(pdev,
> _kms_driver);
> - if (ret)
> - return ret;
> -
I'm not familiar with the amdgpu driver but yes, something like that
is what I had in mind.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Martinez Canillas
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Sam Ravnborg
---
Changes in v3:
- Add Sam Ravnborg's reviwed-by tag.
- Move driver patch after one introducing the DT binding (Sam Ravnborg).
Changes in v2:
- Add year to driver's copyright notice (Sam Ravnborg)
- Remove unused
Add myself as maintainer for the driver and devicetree bindings schema.
Signed-off-by: Javier Martinez Canillas
---
(no changes since v1)
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2e832cf29bec..175d72203fb6 100644
--- a/MAINTAINERS
Martinez Canillas
---
(no changes since v2)
Changes in v2:
- Fix regulator node names (Maya Matuszczyk).
- Drop non-existent "poweroff-in-suspend" property (Maya Matuszczyk).
- Remove unnecessary comments in panel node (Maya Matuszczyk).
.../dts/rockchip/rk3399-pinephone-pro.dts
s and move useful one to debug (Sam Ravnborg).
- Fix regulator node names (Maya Matuszczyk).
- Drop non-existent "poweroff-in-suspend" property (Maya Matuszczyk).
- Remove unnecessary comments in panel node (Maya Matuszczyk).
Javier Martinez Canillas (2):
dt-bindings: display: Add Himax HX
Add device tree bindings for panels based on the Himax HX8394 controller,
such as the HannStar HSD060BHW4 720x1440 TFT LCD panel that is connected
through a MIPI-DSI video interface.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
---
Changes in v3:
- Fix example
ation/devicetree/bindings/display/panel/himax,hx8394.example.dtb
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Hello Sam,
On 12/26/22 16:05, Sam Ravnborg wrote:
> Hi Javier.
>
> On Mon, Dec 26, 2022 at 02:49:05PM +0100, Javier Martinez Canillas wrote:
>> From: Kamil Trzciński
>>
>> The driver is for panels based on the Himax HX8394 controller, such as the
>> HannStar
tuszczyk).
- Remove unnecessary comments in panel node (Maya Matuszczyk).
Javier Martinez Canillas (2):
dt-bindings: display: Add Himax HX8394 panel controller
MAINTAINERS: Add entry for Himax HX8394 panel controller driver
Kamil Trzciński (1):
drm: panel: Add Himax HX8394 panel controller driver
Add device tree bindings for panels based on the Himax HX8394 controller,
such as the HannStar HSD060BHW4 720x1440 TFT LCD panel that is connected
through a MIPI-DSI video interface.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
---
Changes in v2:
- Drop redundant
Martinez Canillas
Signed-off-by: Javier Martinez Canillas
---
Changes in v2:
- Add year to driver's copyright notice (Sam Ravnborg)
- Remove unused header include (Sam Ravnborg).
- Use mipi_dsi_dcs_write_seq() helper and drop custom macro (Sam Ravnborg).
- Drop unnecessary info messages and move
Hello Sam,
On 12/23/22 10:17, Sam Ravnborg wrote:
> Hi Javier.
>
> On Thu, Dec 22, 2022 at 11:38:27PM +0100, Javier Martinez Canillas wrote:
>> From: Kamil Trzciński
>>
>> The driver is for panels based on the Himax HX8394 controller, such as the
>> HannStar
Hello Krzysztof,
On 12/23/22 09:12, Krzysztof Kozlowski wrote:
[...]
> With three above:
>
> Reviewed-by: Krzysztof Kozlowski
>
Thanks a lot for the review! I'll fix the issues you pointed out in v2.
> Best regards,
> Krzysztof
>
--
Best regards,
Javier Martinez Ca
On 11/18/22 23:36, Uwe Kleine-König wrote:
> From: Uwe Kleine-König
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König
> ---
Reviewed-by: Javier Martinez Canillas
--
Best rega
On 11/18/22 23:36, Uwe Kleine-König wrote:
> From: Uwe Kleine-König
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König
> ---
Reviewed-by: Javier Martinez Canillas
--
Best rega
On 11/18/22 23:36, Uwe Kleine-König wrote:
> From: Uwe Kleine-König
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König
> ---
Reviewed-by: Javier Martinez Canillas
--
Best rega
On 11/18/22 23:36, Uwe Kleine-König wrote:
> From: Uwe Kleine-König
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König
> ---
Reviewed-by: Javier Martinez Canillas
--
Best rega
On 11/18/22 23:36, Uwe Kleine-König wrote:
> From: Uwe Kleine-König
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König
> ---
Reviewed-by: Javier Martinez Canillas
--
Best rega
Add device tree bindings for panels based on the Himax HX8394 controller,
such as the HannStar HSD060BHW4 720x1440 TFT LCD panel that is connected
through a MIPI-DSI video interface.
Signed-off-by: Javier Martinez Canillas
---
.../bindings/display/panel/himax,hx8394.yaml | 68
Martinez Canillas
Signed-off-by: Javier Martinez Canillas
---
drivers/gpu/drm/panel/Kconfig | 12 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-himax-hx8394.c | 460 +
3 files changed, 473 insertions(+)
create mode 100644 drivers
a Fedora
37 Workstation image.
Best regards,
Javier
Javier Martinez Canillas (2):
dt-bindings: display: Add Himax HX8394 panel controller bindings
MAINTAINERS: Add entry for Himax HX8394 panel controller driver
Kamil Trzciński (1):
drm: panel: Add Himax HX8394 panel controller driver
Ondrej
.remove = ch7006_remove,
>
> .driver = {
Looks good to me.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
solves the issue in practice for amdgpu,
but don't think is a general solution and would like to know Thomas' opinion
on this before as well.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
the helper creates the list of color formats.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
and the display remained blank.
>
> Signed-off-by: Thomas Zimmermann
> ---
Thanks a lot for fixing this.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
f the 15-bit formats.
>
> Signed-off-by: Thomas Zimmermann
> ---
After addressing what was discussed with José,
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
map dst, src;
> +
> + struct drm_framebuffer fb = {
> + .format = drm_format_info(DRM_FORMAT_ARGB),
Shouldn't this be DRM_FORMAT_XRGB instead?
Other than that, the patch looks good to me.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
On 12/13/22 21:12, Thomas Zimmermann wrote:
> Add dedicated helper to convert from XRGB to ARGB. Sets
> all alpha bits to make pixels fully opaque.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martine
h as XRGB565, introduce
> dedicated branches that handle this for all formats.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
o fix this in struct screen_info,
> + * as this could break UAPI. The best solution is to compute
> + * bits_per_pixel here and ignore lfb_depth. In the loop below,
> + * ignore simplefb formats with alpha bits, as EFI and VESA
> + * don't specify alpha channels.
> + */
Thanks a
tion, which would require
> fixing. So change these tests to return no error, but print a warning.
>
> v2:
> * update omapfb2 (kernel test robot)
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
On 12/16/22 18:46, Thomas Zimmermann wrote:
> Fix coding style. No functional changes.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ned-off-by: Thomas Zimmermann
> ---
> drivers/video/fbdev/core/fbmem.c | 33 --
> drivers/video/fbdev/core/fbsysfs.c | 1 -
> include/linux/fb.h | 22
> 3 files changed, 56 deletions(-)
Nice patch!
Reviewed-by: Ja
ned-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ned-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
On 12/19/22 17:05, Thomas Zimmermann wrote:
> Fix coding style. No functional changes.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ned-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ned-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
On 12/19/22 17:05, Thomas Zimmermann wrote:
> Move the palette array into struct offb_par and allocate both via
> framebuffer_alloc(), as intended by fbdev. No functional changes.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best r
ned-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
On 12/19/22 17:05, Thomas Zimmermann wrote:
> The efifb_par structure holds the palette for efifb. It will also
> be useful for storing the device's aperture range.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Ma
goto err_unmap;
> - }
> - info->apertures->ranges[0].base = info->fix.smem_start;
> - info->apertures->ranges[0].size = info->fix.smem_len;
> -
> info->fbops = _fb_ops;
> info->flags = FBINFO_DEFAULT;
> info->pseudo
y: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
y: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
On 12/19/22 17:05, Thomas Zimmermann wrote:
> The apertures field in struct fb_info is not used by DRM drivers. Do
> not allocate it.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
On 12/19/22 17:05, Thomas Zimmermann wrote:
> Generic fbdev drivers use the apertures field in struct fb_info to
> control ownership of the framebuffer memory and graphics device. Do
> not set the values in radeon.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier
On 12/19/22 17:05, Thomas Zimmermann wrote:
> Generic fbdev drivers use the apertures field in struct fb_info to
> control ownership of the framebuffer memory and graphics device. Do
> not set the values in i915.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier
On 12/19/22 17:05, Thomas Zimmermann wrote:
> Generic fbdev drivers use the apertures field in struct fb_info to
> control ownership of the framebuffer memory and graphics device. Do
> not set the values in gma500.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier
emd/systemd/tree/src/vconsole/90-vconsole.rules.in?h=v222
> # 3
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
On 12/19/22 17:04, Thomas Zimmermann wrote:
> Fix coding style. No functional changes.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
901 - 1000 of 2249 matches
Mail list logo
