omas Zimmermann
> Cc: Laurent Pinchart
> Cc: Kieran Bingham
As I'm on Cc, I'm fine with this too.
Reviewed-by: Kieran Bingham
> Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Quoting Jacopo Mondi (2024-03-14 10:12:47)
> Hello
>
> gentle nudge for
>
> *) libcamera: are we ok being listed here ?
I think it's fine ...
Acked-by: Kieran Bingham
> *) DRM/KMS: is it ok splitting the list of projects in the way I've
>done ?
>
> Thanks
Quoting Kieran Bingham (2023-09-03 16:23:46)
> Hi Alexandra
>
> Quoting Alexandra Diupina (2023-09-03 14:37:09)
> > rcar_du_group_get() never returns a negative
> > error code (always returns 0), so change
> > the comment about returned value
>
> If so, the
clean up some redundant error path handling in
drivers/gpu/drm/renesas/rcar-du/rcar_du_crtc.c too ?
Still, this does correct the documentation to match the implementation
as it stands so... for that ...
Reviewed-by: Kieran Bingham
But removing an unused error path seems like a worthy clean up
op
Quoting Wolfram Sang (2023-08-16 11:56:41)
> Not RCAR, but R-Car.
>
Reviewed-by: Kieran Bingham
> Signed-off-by: Wolfram Sang
> ---
> drivers/gpu/drm/renesas/rcar-du/rcar_du_plane.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers
#include
> -#include
> #include
> #include
> #include
> diff --git a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> index aa95b85a2964..8048bdca2d6c 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> +++ b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> @@ -10,7 +10,6 @@
> #include
> #include
> #include
> -#include
> #include
> #include
> #include
Reviewed-by: Kieran Bingham
Quoting Laurent Pinchart (2023-05-30 10:26:39)
> drm_info() adds proper context to the kernel log message, as it receives
> the drm_device pointer. It is thus preferred over DRM_INFO(). Replace
> the latter with the former.
>
> Signed-off-by: Laurent Pinchart
Reviewed-by:
s could remain a single line return statement with:
return dev_err_probe(rcdu->dev, ret, "failed to initialize
CMM\n");
Or if you're really concerned about 80 chars:
return dev_err_probe(rcdu->dev, ret,
nd definitley expected 'temporary' to
mean less than 7 years, I very much approve of this patchset.
Thank you for all your efforts Uwe.
Reviewed-by: Kieran Bingham
> This patch is based on v6.4-rc1, and applies fine on today's next.
> (There are also no new drivers that need adaption in next.
Quoting Biju Das (2023-04-24 17:10:20)
> Create vendor specific renesas directory and move renesas drivers
> to that directory.
>
> Signed-off-by: Biju Das
Acked-by: Kieran Bingham
able booting for this SoC. Public users only have ES2 onwards.
>
> Signed-off-by: Wolfram Sang
Wow, this lets us get rid of workarounds all throughout.
This looks pretty decisive, and complete to me.
Reviewed-by: Kieran Bingham
> ---
> Please apply individually per subsystem. T
Quoting Dan Carpenter (2023-02-27 10:06:59)
> The drmm_encoder_alloc() function returns error pointers. It never
> returns NULL. Fix the check accordingly.
Yes, indeed. Thanks.
Reviewed-by: Kieran Bingham
>
> Fixes: 7a1adbd23990 ("drm: rcar-du: Use drmm_encoder_alloc() to
Quoting Tomi Valkeinen (2022-12-19 14:01:38)
> V3U is actually gen 4 IP, like in V4H. Bumb up V3U gen in the
s/Bumb/bump/
Reviewed-by: Kieran Bingham
> rcar_du_r8a779a0_info.
>
> Signed-off-by: Tomi Valkeinen
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +-
&g
, I'm
happy.
I like the MHZ() macro for readability too.
Reviewed-by: Kieran Bingham
> ---
> drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c | 497 ++-
> drivers/gpu/drm/rcar-du/rcar_mipi_dsi_regs.h | 6 +-
> 2 files changed, 375 insertions(+), 128 deletions(-)
>
Quoting Tomi Valkeinen (2022-11-17 15:49:36)
> On 17/11/2022 17:46, Kieran Bingham wrote:
> >> + if (ret)
> >> + return ret;
> >> +
> >> + if (setup_info->hsfreq <= MHZ(1000))
> >> +
Quoting Tomi Valkeinen (2022-11-17 12:25:46)
> From: Tomi Valkeinen
>
> Add DSI support for r8a779g0. The main differences to r8a779a0 are in
> the PLL and PHTW setups.
>
> Signed-off-by: Tomi Valkeinen
> ---
> drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c | 484 +++
>
dy. I guess that has knock on effects through the driver though...
Aside from that, Which may need more work to handle correctly:
Reviewed-by: Kieran Bingham
> + .features = RCAR_DU_FEATURE_CRTC_IRQ
> + | RCAR_DU_FEATURE_VSP1_SOURCE
> +
Quoting Tomi Valkeinen (2022-11-17 12:25:44)
> From: Tomi Valkeinen
>
> Add DT nodes needed for the mini DP connector. The DP is driven by
> sn65dsi86, which in turn gets the pixel data from the SoC via DSI.
>
> Signed-off-by: Tomi Valkeinen
Reviewed-by: Kieran Bingham
remote-endpoint =
> <_out_dsi0>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> +
193,6 +203,10 @@ static const struct mssr_mod_clk r8a779g0_mod_clks[]
> __initconst = {
> DEF_MOD("tmu3", 716,R8A779G0_CLK_SASYNCPERD2),
> DEF_MOD("tmu4", 717,R8A779G0_CLK_SASYNCPERD2),
> DEF_MOD("tpu0", 718,R8A
; - R-Car V3U SoC. The encoder can operate in either DSI or CSI-2 mode, with up
> + R-Car V3U/V4H SoC. The encoder can operate in either DSI or CSI-2 mode,
> with up
That's 81 chars I think ... so perhaps the 'up' should go 'down' a line
... but hey it's one char, I don't care too much,
Quoting Tomi Valkeinen (2022-11-17 12:25:40)
> From: Tomi Valkeinen
>
> Extend the Renesas DU display bindings to support the r8a779g0 V4H.
>
> Signed-off-by: Tomi Valkeinen
Matches my expectations, and interpretations of the datasheets.
Reviewed-by: Kieran Bingham
> --
sabled, without having
> to use #ifdef guards.
>
> This has the advantage of always compiling these functions in,
> independently of any Kconfig option. Thanks to that, bugs and other
> regressions are subsequently easier to catch.
>
> Signed-off-by: Paul Cercueil
Reviewed-by:
asonable to me.
Reviewed-by: Kieran Bingham
> ---
> Cc: Laurent Pinchart
> Cc: Kieran Bingham
> Cc: linux-renesas-...@vger.kernel.org
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 9 +++--
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/dri
Quoting Javier Martinez Canillas (2022-11-03 11:53:14)
> Hello Kieran,
>
> On 11/3/22 11:59, Kieran Bingham wrote:
> > Hi Randy,
> >
> > Quoting Randy Dunlap (2022-11-03 06:06:45)
> >> ping. I have verified (on linux-next-20221103) that this is still needed.
&
dsi_pclk_enable'
> > aarch64-linux-ld: drivers/gpu/drm/rcar-du/rcar_du_crtc.o: in function
> > `rcar_du_crtc_atomic_disable':
> > rcar_du_crtc.c:(.text+0x47cc): undefined reference to
> > `rcar_mipi_dsi_pclk_disable'
> >
> > Fixes: 957fe62d7d15 ("drm: rcar-du: Fi
Quoting Laurent Pinchart (2022-09-28 11:05:33)
> Hi Kieran,
>
> On Wed, Sep 28, 2022 at 10:59:36AM +0100, Kieran Bingham wrote:
> > Quoting Laurent Pinchart (2022-09-28 01:58:12)
> > > From: Kieran Bingham
> >
> > It looks like this has progressed a bit since
Quoting Laurent Pinchart (2022-09-28 01:58:12)
> From: Kieran Bingham
>
It looks like this has progressed a bit since it left my computer ;-)
> The LCDIF includes a color space converter that supports YUV input. Use
> it to support YUV planes, either through the converter i
does anyone have one that could test this patch?
Anyway:
Reviewed-by: Kieran Bingham
> Fixes: 9db35bb349a0 ("drm: lcdif: Add support for i.MX8MP LCDIF variant")
> Signed-off-by: Laurent Pinchart
> ---
> Changes since v1:
>
> - Use coefficients from imx-pxp.c
> ---
>
I mean, I like BIT (and sometimes GENMASK) but ... What was going on
there!
Defintely better this way.
Reviewed-by: Kieran Bingham
> -#define DISP_PARA_LINE_PATTERN_RGB565 GENMASK(28, 26)
> -#define DISP_PARA_LINE_PATTERN_RGB888 0
> +#define DISP_PARA_LINE_PATTERN_UYVY_H (
Quoting Laurent Pinchart (2022-09-28 01:58:09)
> A couple of the register macro values are incorrectly indented. Fix
> them.
>
Argh, there was already a v2 posted. Sometimes (more often than I like)
I really hate email...
Reviewed-by: Kieran Bingham
> Signed-off-by: Laur
Quoting Laurent Pinchart (2022-09-28 00:38:18)
> A couple of the register macro values are incorrectly indented. Fix
> them.
>
Reviewed-by: Kieran Bingham
> Signed-off-by: Laurent Pinchart
> ---
> drivers/gpu/drm/mxsfb/lcdif_regs.h | 4 ++--
> 1 file changed, 2 inser
from the Makefile. Fix it.
>
> Fixes: 841281fe52a7 ("drm: rcar-du: Drop LVDS device tree backward
> compatibility")
> Signed-off-by: Laurent Pinchart
Reviewed-by: Kieran Bingham
> ---
> drivers/gpu/drm/rcar-du/Makefile | 7 ---
> 1 file changed, 7 deletions(-)
&g
Quoting Rasmus Villemoes (2022-07-07 10:46:24)
> On 05/07/2022 17.10, Kieran Bingham wrote:
> > Hi Rasmus,
> >
> > Quoting Rasmus Villemoes (2022-07-05 10:08:37)
> >> Hi
> >>
> >> I have an imx8mp board with a sn65dsi86 and a (full-size) Displa
Hi Rasmus,
Quoting Rasmus Villemoes (2022-07-05 10:08:37)
> Hi
>
> I have an imx8mp board with a sn65dsi86 and a (full-size) DisplayPort
> connector, which I'm trying to get up and running.
>
> The display connector registers itself as a bridge; I do get
> successfully to the end of
(Dropping CC/lists)
Quoting Sam Ravnborg (2022-07-03 21:27:23)
> This patch is what is left on a previous attempt to make the
> ti-sn65dsi86 support DRM_BRIDGE_ATTACH_NO_CONNECTOR.
>
> I ran into several challenges on the way:
> - I never found a way to retreive bpc when the driver
> do not
Hi Sam,
Quoting Sam Ravnborg (2022-02-06 19:09:11)
> >
> > The code builds - but needs testing.
>
> Hrmff, no it does not build. The fixes was by accident not included.
> Will wait a bit for feedback before posting a v2.
>
> Sam
Do you have any plan to send a v2 on this series?
I
, use backlight_get_brightness() which does all
> this and insulates this from future changes.
>
> Signed-off-by: Stephen Kitt
> Cc: Laurent Pinchart
> Cc: Kieran Bingham
Hi Stephen,
This looks reasonable to me too.
Reviewed-by: Kieran Bingham
> Cc: David Airlie
> Cc: D
Quoting Biju Das (2022-06-07 11:58:08)
> Hi All,
>
> Gentle ping. Are we happy with this patch?
>
The patch itself looks fine to me.
Reviewed-by: Kieran Bingham
> Since RZ/G2L is using separate drm driver,
> I can drop this patch, if needed.
>
But indeed, it's not cle
to determine
if it causes issues? Or does it need validating through the hardware
teams?
> + rcar_du_plane_write(rgrp, index, PnALPHAR, 0);
Reviewed-by: Kieran Bingham
> }
>
> static void rcar_du_plane_setup_format(struct rcar_du_group *rgrp,
> --
> 2.25.1
>
car_du_vsp.c) without any added value. Drop it.
>
> Reported-by: Biju Das
> Suggested-by: Geert Uytterhoeven
> Signed-off-by: Laurent Pinchart
Reviewed-by: Kieran Bingham
> ---
> drivers/gpu/drm/rcar-du/rcar_cmm.c | 2 +-
> drivers/gpu/drm/rcar-du/rcar_cmm.h
vailability, so that
> it will fall back to polling, if HPD is not available.
Reviewed-by: Kieran Bingham
>
> Signed-off-by: Biju Das
> ---
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/br
When the CMM is enabled, the HDSE offset is further adjusted to
compensate for consumed pixels.
Explain this further, with an extra comment at the point the offset is
adjusted.
Suggested-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 5 +
1
Quoting Doug Anderson (2022-03-23 21:47:17)
> Hi,
>
> On Thu, Mar 17, 2022 at 6:13 AM Kieran Bingham
> wrote:
> >
> > @@ -1241,9 +1350,32 @@ static int ti_sn_bridge_probe(struct
> > auxiliary_device *adev,
> > pdata->
From: Laurent Pinchart
Implement the bridge connector-related .get_edid() operation, and report
the related bridge capabilities and type.
Signed-off-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
Changes since v1:
- The connector .get_modes() operation
operations are legacy and new users should use
DRM_BRIDGE_ATTACH_NO_CONNECTOR.
Signed-off-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
Changes since v1:
- Document the no_hpd field
- Rely on the SN_HPD_DISABLE_REG default value in the HPD case
- Add a TODO comment regarding IRQ support
-by: Laurent Pinchart
Reworked to set bridge type based on the next bridge/connector.
Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Reviewed-by: Douglas Anderson
--
Changes since v1/RFC:
- Rebased on top of "drm/bridge: ti-sn65dsi86: switch to
devm_drm_of_get_bridge"
/rcar.git
branch: kbingham/drm-misc/next/sn65dsi86/hpd
Kieran Bingham (1):
drm/bridge: ti-sn65dsi86: Support hotplug detection
Laurent Pinchart (2):
drm/bridge: ti-sn65dsi86: Support DisplayPort (non-eDP) mode
drm/bridge: ti-sn65dsi86: Implement bridge connector operations
drivers/gpu/drm
Hi Doug,
Quoting Doug Anderson (2022-03-10 23:10:20)
> Hi,
>
> On Thu, Mar 10, 2022 at 7:22 AM Kieran Bingham
> wrote:
> >
> > From: Laurent Pinchart
> >
> > Implement the bridge connector-related .get_edid() operation, and report
> > the related br
Hi Doug,
Quoting Doug Anderson (2022-03-10 23:10:12)
> Hi,
>
> On Thu, Mar 10, 2022 at 7:22 AM Kieran Bingham
> wrote:
> >
> > @@ -1135,6 +1161,36 @@ static void ti_sn_bridge_atomic_post_disable(struct
> > drm_bridge *bridge,
> > pm_runtime_put_sync
Hi Doug, Sam,
Quoting Doug Anderson (2022-03-10 23:21:38)
> Hi,
>
> On Thu, Mar 10, 2022 at 7:22 AM Kieran Bingham
> wrote:
> >
> > Implement support for non eDP connectors on the TI-SN65DSI86 bridge, and
> > provide IRQ based hotplug detect to identify whe
Hi Laurent
Quoting Laurent Pinchart (2022-03-10 16:42:48)
> Hi Kieran,
>
> Thank you for the patch.
>
> On Thu, Mar 10, 2022 at 03:22:27PM +, Kieran Bingham wrote:
> > When the SN65DSI86 is used in DisplayPort mode, its output is likely
> > routed to a Displ
Quoting Kieran Bingham (2022-03-10 15:22:27)
> When the SN65DSI86 is used in DisplayPort mode, its output is likely
> routed to a DisplayPort connector, which can benefit from hotplug
> detection. Support it in such cases, with polling mode only for now.
>
> The implementa
From: Laurent Pinchart
Implement the bridge connector-related .get_edid() operation, and report
the related bridge capabilities and type.
Signed-off-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
Changes since v1:
- The connector .get_modes() operation doesn't rely on EDID anymore
are legacy and new users should use
DRM_BRIDGE_ATTACH_NO_CONNECTOR.
Signed-off-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
Changes since v1:
- Document the no_hpd field
- Rely on the SN_HPD_DISABLE_REG default value in the HPD case
- Add a TODO comment regarding IRQ support
[Kieran]
- Fix
-by: Laurent Pinchart
Reworked to set bridge type based on the next bridge/connector.
Signed-off-by: Kieran Bingham
--
Changes since v1/RFC:
- Rebased on top of "drm/bridge: ti-sn65dsi86: switch to
devm_drm_of_get_bridge"
- eDP/DP mode determined from the next bridge connector type
/20220206154405.124-1-...@ravnborg.org/
[1] git://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git
branch: kbingham/drm-misc/next/sn65dsi86/hpd
Kieran Bingham (1):
drm/bridge: ti-sn65dsi86: Support hotplug detection
Laurent Pinchart (2):
drm/bridge: ti-sn65dsi86: Support DisplayPort (non
Quoting Kieran Bingham (2022-03-10 14:04:09)
> Quoting Kieran Bingham (2022-03-07 17:59:54)
> > From: Laurent Pinchart
> >
> > Despite the SN65DSI86 being an eDP bridge, on some systems its output is
> > routed to a DisplayPort connector. Enable DisplayPort mode
Quoting Kieran Bingham (2022-03-07 17:59:54)
> From: Laurent Pinchart
>
> Despite the SN65DSI86 being an eDP bridge, on some systems its output is
> routed to a DisplayPort connector. Enable DisplayPort mode when the next
> component in the display pipeline is detected a
Hi Doug,
Quoting Doug Anderson (2022-03-07 19:52:08)
> Hi,
>
> On Mon, Mar 7, 2022 at 10:00 AM Kieran Bingham
> wrote:
> >
> > From: Laurent Pinchart
> >
> > Implement the bridge connector-related .get_edid() operation, and report
> > the related br
Quoting Doug Anderson (2022-03-07 23:22:00)
> Hi,
>
> On Mon, Mar 7, 2022 at 10:00 AM Kieran Bingham
> wrote:
> >
> > From: Laurent Pinchart
> >
> > Despite the SN65DSI86 being an eDP bridge, on some systems its output is
> > routed to a DisplayPo
Hi Sam,
Quoting Sam Ravnborg (2022-02-06 15:44:02)
> From: Rob Clark
>
> Slightly awkward to fish out the display_info when we aren't creating
> own connector. But I don't see an obvious better way.
>
> v3:
> - Rebased and dropped the ti_sn_bridge_get_bpp() patch
>as this was solved in a
Quoting Doug Anderson (2022-03-07 23:22:17)
> Hi,
>
> On Mon, Mar 7, 2022 at 10:00 AM Kieran Bingham
> wrote:
> >
> > @@ -1264,6 +1321,14 @@ static int ti_sn_bridge_probe(struct
> > auxiliary_device *adev,
> >
Hi Doug,
Quoting Doug Anderson (2022-03-07 23:21:28)
> Hi,
>
> On Mon, Mar 7, 2022 at 10:00 AM Kieran Bingham
> wrote:
> >
> > From: Laurent Pinchart
> >
> > Now that the driver supports the connector-related bridge operations,
> > make the conne
From: Laurent Pinchart
Implement the bridge connector-related .get_edid() operation, and report
the related bridge capabilities and type.
Signed-off-by: Laurent Pinchart
Reviewed-by: Stephen Boyd
Reviewed-by: Douglas Anderson
Signed-off-by: Kieran Bingham
---
Changes since v1
are legacy and new users should use
DRM_BRIDGE_ATTACH_NO_CONNECTOR.
Signed-off-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
Changes since v1:
- Document the no_hpd field
- Rely on the SN_HPD_DISABLE_REG default value in the HPD case
- Add a TODO comment regarding IRQ support
[Kieran]
- Fix
From: Laurent Pinchart
Now that the driver supports the connector-related bridge operations,
make the connector creation optional. This enables usage of the
sn65dsi86 with the DRM bridge connector helper.
Signed-off-by: Laurent Pinchart
Signed-off-by: Kieran Bingham
---
Changes since v1
-by: Laurent Pinchart
Reworked to set bridge type based on the next bridge/connector.
Signed-off-by: Kieran Bingham
--
Changes since v1/RFC:
- Rebased on top of "drm/bridge: ti-sn65dsi86: switch to
devm_drm_of_get_bridge"
- eDP/DP mode determined from the next bridge connector type.
.2110878-1-nikita.yo...@cogentembedded.com/
Kieran Bingham (1):
drm/bridge: ti-sn65dsi86: Support hotplug detection
Laurent Pinchart (3):
drm/bridge: ti-sn65dsi86: Implement bridge connector operations
drm/bridge: ti-sn65dsi86: Make connector creation optional
drm/bridge: ti-sn65dsi86: Support
Hi Doug,
Quoting Doug Anderson (2022-02-23 18:25:13)
> Hi,
>
> On Wed, Feb 23, 2022 at 9:43 AM Kieran Bingham
> wrote:
> >
> > Hi All,
> >
> > I'm working to respin the remainder of these patches, now that I have
> > IRQ based HPD working on the
Hi José
Quoting Kieran Bingham (2022-03-03 21:59:26)
> Quoting José Expósito (2022-03-03 18:37:20)
> > On Mon, Feb 28, 2022 at 11:24:36PM +0000, Kieran Bingham wrote:
> > > Hi José
> > >
> > > Quoting José Expósito (2022-02-28 18:39:54)
> > > > The
Quoting José Expósito (2022-03-03 18:37:20)
> On Mon, Feb 28, 2022 at 11:24:36PM +0000, Kieran Bingham wrote:
> > Hi José
> >
> > Quoting José Expósito (2022-02-28 18:39:54)
> > > The function "drm_of_find_panel_or_bridge" has been deprecated i
think this is cleaner all round.
Reviewed-by: Kieran Bingham
>
> Signed-off-by: Laurent Pinchart
> ---
> drivers/gpu/drm/rcar-du/rcar_du_plane.c | 6 ++
> drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 9 -
> 2 files changed, 6 insertions(+), 9 deletions(-)
>
> dif
Quoting Laurent Pinchart (2022-02-21 17:13:39)
> The VSP1 sink selection through register DEFR8 is only available on Gen2
> hardware. Skip it on Gen3.
aha, interesting, and I see how this leads into the second patch.
Looks fine on it's own too though:
Reviewed-by: Kieran Bingham
>
Hi José
Quoting José Expósito (2022-02-28 18:39:54)
> The function "drm_of_find_panel_or_bridge" has been deprecated in
> favor of "devm_drm_of_get_bridge".
>
> Switch to the new function and reduce boilerplate.
>
> Signed-off-by: José Expósito
> ---
> drivers/gpu/drm/bridge/ti-sn65dsi86.c |
Hi Doug, Laurent,
Quoting Laurent Pinchart (2021-06-23 14:59:00)
> Hi Doug,
>
> On Wed, Mar 24, 2021 at 03:47:07PM -0700, Doug Anderson wrote:
> > On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote:
> > >
> > > Despite the SN65DSI86 being an eDP bridge, on some systems its output is
> > >
Hi All,
I'm working to respin the remainder of these patches, now that I have
IRQ based HPD working on the SN65DSI86, and the (non-eDP) mode is used
for Renesas R-Car boards.
Quoting Doug Anderson (2021-06-24 00:51:12)
> Hi,
>
> On Wed, Jun 23, 2021 at 4:26 PM Laurent Pinchart
> wrote:
> >
> >
Quoting Laurent Pinchart (2022-02-23 16:25:28)
> Hello,
>
> On Wed, Feb 23, 2022 at 04:17:22PM +0000, Kieran Bingham wrote:
> > Quoting Laurent Pinchart (2021-12-29 23:44:29)
> > > On Sat, Dec 25, 2021 at 09:31:51AM +0300, Nikita Yushchenko wrote:
> > > > Hotpl
roller - as it's a factor
of the bridge?
On Falcon-V3U with HPD additions to SN65DSI86:
Tested-by: Kieran Bingham
> > In result, once encoders are switched to bridge_connector,
> > bridge-detected HPD stops working.
> >
> > This patch adds a call to that API on init pa
t; +
> + if (mode->htotal - mode->hsync_start < min_sync_porch)
> return MODE_HBLANK_NARROW;
Is the '19' in the hdse offset, this min_sync_port - 1 for position
correction? It looks something like that. And the rest seems ok.
With or without the additional optional comment suggestion above:
Reviewed-by: Kieran Bingham
>
> vbp = (mode->vtotal - mode->vsync_end) / (interlaced ? 2 : 1);
>
> base-commit: c18c889bb5e014e144716044991112f16833
> prerequisite-patch-id: dc9121a1b85ea05bf3eae2b0ac2168d47101ee87
> --
> Regards,
>
> Laurent Pinchart
>
_du_plane_reset() and rcar_du_vsp_plane_reset().
> However, the helpers have been adjusted to set it properly at reset, so
> this is not needed anymore.
Sounds helpful ;-)
> Cc: linux-renesas-...@vger.kernel.org
> Cc: Kieran Bingham
> Cc: Laurent Pinchart
> Signed-off-by: Maxime Rip
n't have
... so it seems reasonable to accept that this whole driver can be
disabled in that instance.
Reading your mail that brought this thread up in my inbox, I think
you've already hit merge on this, so don't worry about adding a tag in
that instance, but I think this is ok.
Reviewed-by
ot;clk: renesas:
> Remove R-Car Gen2 legacy DT clock support"), in v5.5, which removes
> support for legacy bindings for clocks. The LBDS compatibility code is
s/LBDS/LVDS/
> thus not needed anymore. Drop it.
Oh, I'm almost sad to see such exotic code go...
But code gone is less c
Quoting Neil Armstrong (2022-01-17 13:53:47)
> On 17/01/2022 11:58, Kieran Bingham wrote:
> > Hi Neil,
> > This fixes the issue for me here on an H3 Salvator-XS.
> >
> > Could you add...
> >
> > Bisected-by: Kieran Bingham
> > Tested-by: Kiera
;>
> >>>>> ==><===========
> >>>>> diff --git a/drivers/gpu/drm/drm_bridge.c
> >>>>> b/drivers/gpu/drm/drm_bridge.c index c96847fc0ebc..7019acd37716
> >>>>> 100644
> >>>>> --- a/
Quoting Antonio Borneo (2021-12-20 15:53:12)
> On Mon, 2021-12-20 at 14:54 +0000, Kieran Bingham wrote:
> > Hi Antonio,
> >
> > Quoting Antonio Borneo (2021-12-18 18:28:04)
> > > Commit 680532c50bca ("drm: adv7511: Add support for
> > > i2c_new_
probe
> failure.
Ouch, it does seem that way. I guess no one has used the CEC for quite
some time, as it must have been like this for a while?
> Once the new i2c address is read from the device tree, override
> the default address before any attempt to access the cec.
Revie
are still waiting
to probe. Is the message still appropriate enough in that case?
I think it's probably fine, so
Reviewed-by: Kieran Bingham
> goto error;
> }
>
> --
> 2.25.1
>
if (hsfreqrange_table[i][0] >= hsfreq) {
It's hard to tell from this patch, or this point alone, but I see that
fout_target is already limited at 125000, so hsfreq can never be
bigger than 25U.
So ... this is fine (as long as the table and validation check are kept
in s
Quoting Laurent Pinchart (2021-12-01 21:57:29)
> From: LUU HOAI
>
> The driver supports the MIPI DSI/CSI-2 TX encoder found in the R-Car V3U
> SoC. It currently supports DSI mode only.
>
> Signed-off-by: LUU HOAI
> Signed-off-by: Laurent Pinchart
> Reviewed-by:
Quoting Laurent Pinchart (2021-12-01 04:38:46)
> Hi Kieran,
>
> Thank you for the patch.
>
> On Tue, Nov 30, 2021 at 04:25:12PM +, Kieran Bingham wrote:
> > The bridge probe ordering for DSI devices has been clarified and further
> > documented in
>
> I'
Quoting Laurent Pinchart (2021-12-01 05:24:06)
> From: LUU HOAI
>
> The driver supports the MIPI DSI/CSI-2 TX encoder found in the R-Car V3U
> SoC. It currently supports DSI mode only.
>
> Signed-off-by: LUU HOAI
> Signed-off-by: Laurent Pinchart
> Reviewed-by:
Hi Laurent,
Quoting Kieran Bingham (2021-11-30 16:25:13)
> Instead of open coding the calls for
> drm_of_find_panel_or_bridge()
> devm_drm_panel_bridge_add()
>
> use the devm_drm_of_get_bridge() helper directly.
>
> Signed-off-by: Kieran Bingham
> ---
> v2:
>
Instead of open coding the calls for
drm_of_find_panel_or_bridge()
devm_drm_panel_bridge_add()
use the devm_drm_of_get_bridge() helper directly.
Signed-off-by: Kieran Bingham
---
v2:
- New patch
drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c | 19 ---
1 file changed, 4
perpetual -EPROBE_DEFER
loop between the two devices.
Signed-off-by: Kieran Bingham
---
v2
- Remove now unused panel variable from rcar_mipi_dsi_probe()
drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c | 49 +
1 file changed, 26 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/d
of this series have
already been accepted by Laurent and squashed into his tree, so are not
reposted.
Kieran Bingham (2):
drm: rcar-du: mipi-dsi: Support bridge probe ordering
drm: rcar-du: mipi-dsi: Use devm_drm_of_get_bridge helper
drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c | 38
Hi Jagan,
Quoting Jagan Teki (2021-11-30 07:38:57)
> Hi Kieran,
>
> On Fri, Nov 26, 2021 at 3:45 PM Kieran Bingham
> wrote:
> >
> > The bridge probe ordering for DSI devices has been clarified and further
> > documented in
> >
> > To support connect
as
Signed-off-by: Kieran Bingham
---
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index 5612a9e7a905..5a8131ef81d5 100644
--- a/drivers/gpu/d
ed in
> >
> > To support connecting with the SN65DSI86 device after commit c3b75d4734cb
> > ("drm/bridge: sn65dsi86: Register and attach our DSI device at probe"),
> > update to the new probe ordering to remove a perpetual -EPROBE_DEFER loop
> > between the two d
From: Kieran Bingham
Signed-off-by: Kieran Bingham
---
drivers/gpu/drm/rcar-du/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rcar-du/Makefile b/drivers/gpu/drm/rcar-du/Makefile
index adc1b49d02cf..286bc81b3e7c 100644
--- a/drivers/gpu/drm/rcar-du
1 - 100 of 646 matches
Mail list logo
